[00:22:06] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EMartin) [00:49:16] !log changed donations queue consumer and thank you mailer to use 3 minute cycles [00:49:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:57:42] (PS1) Ejegg: IDE reformat: thank you module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554395 [00:57:44] (PS1) Ejegg: TY batch size is freeform entry [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554396 [00:57:59] eileen: ^^^ will let us set a better batch size from the UI [00:59:19] ccccccddfrjhghffhknuffgdibfclvkivfvnckggbeut [00:59:22] ack [01:02:07] (CR) Eileen: [C: +2] IDE reformat: thank you module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554395 (owner: Ejegg) [01:05:47] (CR) Eileen: [C: +2] "Yep - that does it!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554396 (owner: Ejegg) [01:05:56] thanks! [01:07:32] we should really make those drush jobs take the batch size and time limit on the command line [01:07:34] (Merged) jenkins-bot: IDE reformat: thank you module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554395 (owner: Ejegg) [01:07:45] so we can handle all the settings via the process-control repo [01:07:53] and get built-in logging [01:11:19] (Merged) jenkins-bot: TY batch size is freeform entry [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554396 (owner: Ejegg) [01:15:51] ok, both kinds of queue delay are heading back down [01:31:19] ejegg: thanks for all these adjustments. and keeping things smooth. [01:35:20] oh weird, that's a big jump in average time to civi / time to TY [01:35:37] i'd guess it's donations from the previous day coming in from audit files, though [01:49:23] ah yeah [01:51:14] (PS1) Ejegg: IDE reformat: wmf_campaign module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554399 [02:01:08] (PS1) Ejegg: Wmf_campaigns: don't log when no row exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554400 [02:01:36] I was going to propose getting rid of wmf_campaigns, but it looks like there really are some current campaigns with notifications turned on [02:02:02] basically MG and endowments [02:02:29] though I'd guess those usually trigger large donation bot emails too [02:05:05] ding ding [02:05:34] Ha! Just heard it here too [02:05:51] Already half a mil for 'today' [02:07:33] (CR) Eileen: [C: +2] IDE reformat: wmf_campaign module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554399 (owner: Ejegg) [02:12:18] ejegg: looking at the campaign patch - it seems odd that we would want to log [02:12:19] watchdog('wmf_campaigns', "No campaign for message", NULL, WATCHDOG_INFO); [02:12:19] eileen: oh hey, we can do more caching in wmf_campaigns [02:12:32] eileen: yeah, that can go too [02:13:00] & we only need to call WmfCampaign::fromKey once huh? [02:13:05] per campaign [02:13:19] (Merged) jenkins-bot: IDE reformat: wmf_campaign module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554399 (owner: Ejegg) [02:13:54] ejegg: do you want me to +2 what is in there & then you can do the next changes? [02:14:04] or do you want to edit it [02:14:59] it seems we need to cache an array like [campaignKey => email] [02:16:44] (CR) Eileen: [C: +2] "I think there is more we can do here as discussed on IRC but perhaps merge this & then remove the other watchdog & increase caching" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554400 (owner: Ejegg) [02:16:52] I merged it [02:19:22] oh cool, I'll do the rest in another patch [02:19:56] eileen the whole table has 15 rows [02:20:17] ejegg: let's just load the whole table once then?> [02:20:24] yep yep [02:22:16] (Merged) jenkins-bot: Wmf_campaigns: don't log when no row exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554400 (owner: Ejegg) [02:51:18] (PS1) Ejegg: Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 [02:53:30] ooh, that has a bug [02:54:09] will the test catch it? [02:54:37] yep, looks like it did! [02:56:53] (CR) jerkins-bot: [V: -1] Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 (owner: Ejegg) [02:58:22] (PS2) Ejegg: Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 [03:03:45] (CR) jerkins-bot: [V: -1] Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 (owner: Ejegg) [03:10:23] shoot, I'll fix that in the morning [03:10:31] gnight all [03:24:43] (PS3) Ejegg: Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 [03:29:14] (PS4) Ejegg: Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 [03:51:01] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EBjune) The credit balance still has 789,697 minFraud scoring credits left (as of 12/3 7:49PM PST), so the balance should not be the problem. [03:58:40] (PS1) Ejegg: Update grafana links [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/554406 [04:19:05] (CR) XenoRyet: [C: +2] Update grafana links [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/554406 (owner: Ejegg) [04:19:07] (Merged) jenkins-bot: Update grafana links [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/554406 (owner: Ejegg) [04:27:54] (PS1) Eileen: wmf_campaigns - take it a bit further [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554408 [04:29:09] (CR) Eileen: [C: +1] "I think this is an improvement but I was thinking we could take it a bit further like https://gerrit.wikimedia.org/r/#/c/wikimedia/fundrai" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 (owner: Ejegg) [04:32:02] (CR) Eileen: [C: +2] "Those links definitely seem to work better!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/554406 (owner: Ejegg) [04:53:12] (PS1) AndyRussG: Prevent repeated colors in plots [wikimedia/fundraising/centralnotice_analytics] - https://gerrit.wikimedia.org/r/554410 [06:06:49] (PS2) AndyRussG: Prevent repeated colors in plots [wikimedia/fundraising/centralnotice_analytics] - https://gerrit.wikimedia.org/r/554410 [13:16:31] (CR) Ejegg: [C: +1] "Yeah, the simpler cache makes sense. If we're stripping it down this far, we can rid of the rest of the class instance bits." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554408 (owner: Eileen) [13:40:31] Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Ingenico recurring cancel process question - https://phabricator.wikimedia.org/T239741 (MBeat33) Open→Resolved a:MBeat33 Thanks, @mepps and @Ejegg for clarifying this yesterday. I'll tell my team that all donations, even one-time's, i... [14:14:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Populate financial_type_id and payment_instrument_id for contribution_recur - https://phabricator.wikimedia.org/T239818 (Ejegg) [14:42:04] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554515 [14:42:07] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554515 (owner: Ejegg) [14:52:02] (PS1) Ejegg: wmf_campaigns - take it all the way [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554520 [14:52:52] (CR) Ejegg: [C: +1] "all those things I mentioned in the last comment are in this patch: https://gerrit.wikimedia.org/r/554520" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554408 (owner: Eileen) [15:13:15] (PS1) Ejegg: Log when pushing message to recurring queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/554529 [15:14:47] fr-tech I'm actually ADDING a log line there, but it seems like an important bit of info that we're missing ^^^ [15:15:05] also, I just turned off debug logging for Ingenico on the payments-wiki side [15:15:13] after seeing a lot of useless junk in that log [15:15:30] !log disabled debug logging for Ingenico on payments-wiki [15:15:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:15:45] better late than never [15:16:42] Thank ya's down to 4 min [15:19:25] !log updated fundraising CiviCRM from 0f51030071 to 970b7b214b [15:19:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:22:53] taking a look ejegg [15:23:28] (CR) Mepps: [C: +2] wmf_campaigns - take it all the way [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554520 (owner: Ejegg) [15:23:49] (CR) Mepps: [C: +2] Log when pushing message to recurring queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/554529 (owner: Ejegg) [15:27:49] thanks mepps! [15:28:03] I'll +2 the parent patch to that wmf_campaigns one [15:28:13] (CR) Ejegg: [C: +2] wmf_campaigns - take it a bit further [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554408 (owner: Eileen) [15:28:40] which just leaves the grandparent patch needing a +2 [15:29:24] eileen had +1ed it with the suggestions she put in ^^^ - mepps, want to push https://gerrit.wikimedia.org/r/554404 over the line? [15:29:29] (Merged) jenkins-bot: Log when pushing message to recurring queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/554529 (owner: Ejegg) [15:30:05] ejegg so i just need to +2 right? [15:30:13] i was a litlte confused by the way the chain worked [15:30:23] yep! [15:30:47] (CR) Mepps: [C: +2] Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 (owner: Ejegg) [15:30:55] Thanks! [15:31:16] I'll deploy those in a moment - brb [15:36:25] (Merged) jenkins-bot: Wmf_campaigns: one fewer log line, more caching [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554404 (owner: Ejegg) [15:36:32] (Merged) jenkins-bot: wmf_campaigns - take it a bit further [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554408 (owner: Eileen) [15:36:34] (Merged) jenkins-bot: wmf_campaigns - take it all the way [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554520 (owner: Ejegg) [16:12:54] (PS1) Ejegg: Large donation: don't log below-minimum donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554547 [16:17:02] I always wondered about that log ejegg [16:22:10] cstone feel free to propose other log reductions! [16:23:04] (CR) Cstone: [C: +2] Large donation: don't log below-minimum donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554547 (owner: Ejegg) [16:24:15] fr-tech there's a scrum of scrums meeting in 10 min [16:24:32] Anything (besides the obvious) you want me to bring up? [16:25:07] fr-tech hmmm I guess nothing here eh, thanks! [16:25:20] "ejegg" I meant ^ [16:25:26] ;) [16:28:16] ok, cool [16:28:36] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554553 [16:28:50] (Merged) jenkins-bot: Large donation: don't log below-minimum donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554547 (owner: Ejegg) [16:29:01] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554553 (owner: Ejegg) [16:33:40] !log updated fundraising CiviCRM from 970b7b214b to 6812488f3a [16:33:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:11:20] Fundraising Sprint X-rays, Fundraising-Backlog: Investigation: Tracking the drop in _all_wikimedia contact source job total rows - https://phabricator.wikimedia.org/T239635 (KHaggard) That makes sense. I'm attaching the most recent jobs from this morning below - and things seem to be running as normal a... [17:13:01] (PS1) Ejegg: Fix campaign notification UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554573 [17:13:22] mepps oops, those wmf_campaigns patches broke the config UI ^^^ [17:29:07] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (Ejegg) We apply all of our in-house filters first, then skip the MinFraud check if we've already decided not to process the donation. Can you paste in a few examples of contribution tracking IDs fo... [17:30:07] Wikimedia-Fundraising-CiviCRM: New Gift Source = Alternative Gifts created - https://phabricator.wikimedia.org/T239845 (RLewis) [17:32:16] (CR) Ejegg: "cdenes, looks like there's at least one space-before-punctuation in the french version that would be better as an  ." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552057 (owner: Cdenes) [17:35:46] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EMartin) Some recent examples from 12/4: 73143616.1, 73137282.1, 73091579.1, 73080482.1,73080991.1,73070725.1,73073754.1. Issue started on 12/2. [17:44:46] fr-tech anyone want to review this little fix to a thing I broke earlier today? https://gerrit.wikimedia.org/r/554573 [17:45:19] Not in the critical path to import donations, but will block MG or endowments folks the next time they try to configure notifications [18:15:21] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EMartin) In many cases they are missing more than minfraud. Also missing our checks. See examples. Thanks for looking at this. [18:18:40] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (XenoRyet) @EMartin could you give me some example donations, or point me at a list of them somewhere? I'll dig around the logs and see what I can find. [18:21:15] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EMartin) Hi, I put a few in the Phab task earlier. Please let me know if you need more. https://phabricator.wikimedia.org/T239769 [19:29:56] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (Ejegg) We didn't stop any of those for fraud - they're all listed with a near-zero risk score and validation_action=process. What made them appear as stopped for fraud to you? [19:32:32] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EMartin) I pulled them out of Ingenico's console where I search for anything with a status 600, usually from the prior day to give things time to settle. Oddly, I haven't seen these unscored transact... [20:02:38] (CR) Eileen: [C: +2] "Yep I agree" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554573 (owner: Ejegg) [20:03:53] ejegg: I'm laughing at the 'take it all the way' commit title :-) [20:05:58] hehe [20:06:07] take it to the limit! [20:06:31] :-) [20:08:22] (Merged) jenkins-bot: Fix campaign notification UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554573 (owner: Ejegg) [20:08:58] thanks! [20:09:52] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554611 [20:10:00] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554611 (owner: Ejegg) [20:14:25] (PS1) Eileen: security/core#59 - Fix SQL injection in civicrm/ajax/dedupefind [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554612 [20:14:27] (PS1) Eileen: security/core#65 - Fix XSS in Dashboard Report Title [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554613 [20:14:29] (PS1) Eileen: Apiv4 update [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554614 [20:16:37] oh yeah, let's get those out too! [20:16:49] thanks for staying on top of that [20:16:58] (CR) Ejegg: [C: +2] security/core#59 - Fix SQL injection in civicrm/ajax/dedupefind [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554612 (owner: Eileen) [20:17:53] (CR) Ejegg: [C: +2] security/core#65 - Fix XSS in Dashboard Report Title [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554613 (owner: Eileen) [20:22:41] (Merged) jenkins-bot: security/core#59 - Fix SQL injection in civicrm/ajax/dedupefind [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554612 (owner: Eileen) [20:23:16] (Merged) jenkins-bot: security/core#65 - Fix XSS in Dashboard Report Title [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554613 (owner: Eileen) [20:28:17] (CR) Ejegg: [C: +2] Apiv4 update [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554614 (owner: Eileen) [20:34:18] (Merged) jenkins-bot: Apiv4 update [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554614 (owner: Eileen) [20:35:38] (PS1) Eileen: Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 [20:38:08] (CR) jerkins-bot: [V: -1] Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 (owner: Eileen) [20:39:13] (PS1) Ejegg: Fix error handling on minfraud emergency mail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/554621 [20:40:39] (PS2) Eileen: Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 [20:44:23] (PS1) Eileen: CiviCRM submodule udpate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554624 [20:49:43] fundraising-tech-ops: reconfigure payments*:/srv to /var/log - https://phabricator.wikimedia.org/T211594 (Jgreen) Here's the procedure I used for the first batch: systemctl stop puppet; rm /etc/cron.d/puppet; killall -9 puppet rm /etc/rsyslog.conf systemctl stop apache2 systemctl stop auditd systemctl stop... [20:50:47] fundraising-tech-ops: reconfigure payments*:/srv to /var/log - https://phabricator.wikimedia.org/T211594 (Jgreen) [20:51:33] (PS3) Eileen: Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 [20:54:17] (CR) jerkins-bot: [V: -1] Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 (owner: Eileen) [20:56:10] (PS4) Eileen: Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 [20:56:26] (CR) Eileen: [C: +2] CiviCRM submodule udpate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554624 (owner: Eileen) [21:01:44] (Merged) jenkins-bot: CiviCRM submodule udpate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554624 (owner: Eileen) [21:02:49] that 'reobjectify' method looks bizarre [21:04:00] (CR) Ejegg: [C: +2] Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 (owner: Eileen) [21:06:25] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (Ejegg) Ahh, while our fraud filters are one way things stop at 600, they're not the only way. If there's an error redirecting the user to our site, or if our API calls to capture / approve the paymen... [21:07:50] (Abandoned) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554611 (owner: Ejegg) [21:08:17] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/554629 [21:08:26] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/554629 (owner: Ejegg) [21:09:41] (Merged) jenkins-bot: Implement xKerman/restricted-unserialize package to guard against unsafe unserialize [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554620 (owner: Eileen) [21:10:04] Fundraising-Backlog: Transactions stopped for Fraud are unscored - https://phabricator.wikimedia.org/T239769 (EMartin) I see....I'm settling those caught where I can but the volumes are getting too big to capture all of those at 0 any longer...that's a good tidbit to know that it may be indicative of an API... [21:16:26] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/554629 (owner: Ejegg) [21:34:12] (PS1) Eileen: CiviCRM submodule udpate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554634 [21:34:36] (CR) Eileen: [C: +2] CiviCRM submodule udpate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554634 (owner: Eileen) [21:40:13] (Merged) jenkins-bot: CiviCRM submodule udpate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/554634 (owner: Eileen) [21:42:07] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554635 [21:42:16] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/554635 (owner: Eileen) [21:48:51] !log civicrm revision changed from 6812488f3a to 4a72ad4e63, config revision is 9f4db1edad (CiviCRM security patches ) [21:48:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:52:28] Civi security patches ^ incl the one released a few mins ago [21:59:07] actually not yet realeased :-) [21:59:23] I mean upstream - it is deployed [22:00:28] thanks! [22:03:19] fr-tech anyone have some good ideas for dash? [22:04:12] I think we can maybe deal with the stuck 'chart loading' overlay [22:04:18] by using the xhr timeout property [22:04:37] and just trying the exact same thing again (once or twice) after the gateway timeout is past [22:05:16] since once dash gets the query result back it caches it, even if the gateway has disconnected [22:08:26] Can we cache query results globally - I think we do per user now? [22:09:37] ejegg: if you look at processing rate over 3 days you can see our 'good' is better now [22:10:59] :) [22:11:20] eileen the dash does cache globally [22:11:41] ah cool - I got that wrong [22:11:42] key is just based on query params, not on user [22:12:19] but that mostly just helps for the 'totals earned' chart [22:12:31] which has fixed times [22:12:59] the other charts are mostly querying with a start time relative to now [22:13:13] so everybody's query ends up different [22:13:39] ah [22:14:42] would rounding to the whole minute or 2 minutes help? [22:14:53] or 5 [22:14:54] it might! [22:17:40] ah, wait, the parameter is actually sent as 'daysago=1' [22:17:46] so that does cache [22:17:53] sorry for the misinfo [22:20:59] ok [22:23:30] ejegg: when i was watching queries the other day, the dash ones ran for about 50-65 seconds before completion. [22:23:43] just as a reference. [22:39:59] thanks dwisehaupt [22:45:04] ooh, I wonder if dash should cache the promises returned from db queries [22:45:52] so if I make a query, then you make the same query while mine is still running and hasn't had results cached yet [22:46:29] then we both get results as soon as my query finishes [22:47:43] that sounds pretty useful [22:58:25] Wikimedia-Fundraising-Banners: Mobile large - donate later option in toolbar doesn't work after selecting an amount - https://phabricator.wikimedia.org/T231838 (spatton) For the sake of expedience, I'm choosing the former (letting the input remain after amount selection) - https://meta.wikimedia.org/w/index.... [23:05:59] Wikimedia-Fundraising-Banners: Donate Later link does not work after donation amount has been selected - https://phabricator.wikimedia.org/T238604 (jbolorinos-ctr) This issue was fixed by Sam here: https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-spatton_m_lg_RMLbug_fix&diff=next...