[08:11:53] Wikimedia-Fundraising: post-donation survey link broken - https://phabricator.wikimedia.org/T240079 (jijiki) @Pcoombe Yes, they had visited Canada about a month ago, that explains it:) [14:28:35] Fundraising-Backlog: We need a way to test our payments forms without submitting real donations - https://phabricator.wikimedia.org/T240219 (spatton) [15:00:14] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frdb1003.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T239139 (Jgreen) [15:00:27] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frdb1003.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T239139 (Jgreen) Open→Resolved Done! [16:02:13] ejegg i'm in our call [16:02:22] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice alerts: Include user info and other event data in alert - https://phabricator.wikimedia.org/T224934 (chasemp) p:Triage→Normal [16:02:31] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice, Security: CentralNotice alerts: Specific alerts config for production monitoring - https://phabricator.wikimedia.org/T224931 (chasemp) p:Triage→Normal [16:02:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice alerts: Investigate productionization and e-mail alerts - https://phabricator.wikimedia.org/T224927 (chasemp) p:Triage→Normal [16:02:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice alerts: Hide verbose output from pywikibot unless --debug flag used - https://phabricator.wikimedia.org/T224926 (chasemp) p:Triage→Normal [16:03:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice alerts: Implement alerts based on campaign and user - https://phabricator.wikimedia.org/T224925 (chasemp) p:Triage→Normal [16:03:31] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice alerts: Add error handling - https://phabricator.wikimedia.org/T224699 (chasemp) p:Triage→Normal [16:52:35] Fundraising-Backlog, Fr-CentralNotice-translations, MediaWiki-extensions-CentralNotice, Security-Team, and 3 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (chasemp) p:Triage→High [17:41:56] Fundraising Sprint X-rays, Fundraising-Backlog: Ingenico transactions stuck at 600 without fraud scores - https://phabricator.wikimedia.org/T239769 (EMartin) Current examples from 12.8 74199693.1 74198321.2 74177728.1 74012707.2 74011082.1 73779706.1 73778693.1 73778875.1 73777604.1 [17:50:12] Fundraising-Backlog: investigate unintended recurring from December 2019 - https://phabricator.wikimedia.org/T240242 (DStrine) [17:51:42] Fundraising Sprint X-rays, Fundraising-Backlog: investigate unintended recurring from December 2019 - https://phabricator.wikimedia.org/T240242 (DStrine) [18:41:33] (PS1) XenoRyet: Fix cycle day for monthly conversions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) [18:42:07] fr-tech: I think that patch ought to do it for fixing the cycle days, if someone wants to take a look and double check my SQL. [18:43:43] (CR) jerkins-bot: [V: -1] Fix cycle day for monthly conversions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) (owner: XenoRyet) [18:45:25] looking XenoRyet [18:45:50] Cool. Just uploading another patch set now, I used the wrong quotes. [18:46:17] (PS2) XenoRyet: Fix cycle day for monthly conversions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) [18:53:30] XenoRyet: I think you're missing an alias definition, the cr. references in start_date [18:53:54] Heh, copypasta error. I don't even really need an alias in there. I'll fix it. [18:53:55] referenced* [18:54:45] (PS3) XenoRyet: Fix cycle day for monthly conversions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) [18:57:03] I'm a little bit of two minds as to whether or not I should put some extra conditions in the where clause. Stuff like 'cycle_day = 1' and 'cr.start_date = date_add(cr.create_date, interval 1 month)' [18:57:33] That would be extra sure it's just monthly convert we'd be updating, but it also feels a little redundant. [19:01:00] I like the extra filters [19:01:16] does adding those change the count vs not adding them? [19:01:18] I certainly don't mind them. I'll throw 'em on. [19:01:26] if you turn the update into a select count(*) [19:01:31] I'll check. [19:01:34] can't help testing [19:01:43] s/help/hurt/ [19:01:49] Absolutely. The more the better on this sort of thing. [19:01:51] can HELP :) [19:02:17] you just cant help testing! [19:02:27] :> [19:03:06] in an unrelated note, does anyone have sql editor auto-complete working in mysql workbench. I feel like this used to work and now I have to type everything out [19:03:36] ctrl+space has saved many needless keystrokes in my life [19:04:18] hmm just in the UI at the top jgleeson ? the autocomplete is working for me there [19:04:19] Row count is the same with the extra filters. [19:04:47] So what do you think? Add 'em or no? [19:05:30] good news. hmm I'm the paranoid type so I'd still add them in but they might be redundant like you said if the count is the same [19:06:15] I'll put 'em in. If nothing else it'll help readability in terms of showing exactly what we're trying to get at. [19:06:23] yeah I like for readability [19:06:26] +1 [19:08:46] (PS4) XenoRyet: Fix cycle day for monthly conversions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) [19:10:06] After this, I think I'll try getting mysql workbench working too. Freehanding SQL is for the birds. [19:10:40] yeah it makes life easier although still no auto-complete after setting it in preferences grrr [19:11:24] Fundraising-Backlog: Investigate how to setup IDEAL and be campaign ready by end of Q2 - https://phabricator.wikimedia.org/T240252 (DStrine) [19:20:47] (CR) Jgleeson: [C: +2] "Looks good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) (owner: XenoRyet) [19:20:52] Fundraising-Backlog, fundraising-tech-ops: Adjust /var/log/messages file rotation to daily keeping 28 days - https://phabricator.wikimedia.org/T240082 (Dwisehaupt) Open→Resolved rotations and compression worked as desired. [19:26:15] (Merged) jenkins-bot: Fix cycle day for monthly conversions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556020 (https://phabricator.wikimedia.org/T239627) (owner: XenoRyet) [19:29:39] fr-tech, dstrine, Seddon how does the log for the 'limit traffic' attribute work on CN campaigns? [19:30:49] jgleeson you mean the log in the CentralNotice UI? [19:33:30] sorry, logic* [19:33:34] not log [19:33:36] :/ [19:35:05] cstone: Now that both parts of the fix are merged, do you want to do the deploy or shall I? [19:35:59] if you want to now you can, im doing a bit of log diving, or i can in a bit [19:36:34] I'll go ahead and do it then. [19:37:04] jgleeson / XenoRyet you can get SQL autocomplete in PHPStorm if you set up data sources [19:38:05] ejegg: The recurring jobs are still turned off from yesterday, yea? [19:38:24] XenoRyet: yep [19:38:30] cool [19:45:26] jgleeson: the 'limit traffic' stuff is implemented in chooser.js [19:46:03] chooseCampaign fn takes the available campaigns with their priority level and traffic limits, plus a random number from 0 to 1 [19:46:46] setCampaignAllocations looks at priority level and traffic limits, and doles out chunks of that [0..1] spectrum [19:47:05] first giving the emergency campaigns as much traffic as they asked for [19:47:28] then allocating what's left to the high priority campaigns [19:47:33] then the medium, etc [19:48:11] i believe that a 60% emergency campaign and a 40% high campaign would completely occupy the allocation [19:48:28] leaving nothing left for the medium, etc level campaigns [19:49:46] anyway, once setCampaignAllocations decides where the breakpoints are from [0..1], chooseObjInAllocatedArray takes that allocation and the random number, and returns the campaign that the random number points to [19:50:53] Then if you want to know about campaign fallback, that operates on a cycle a bit higher up. [19:51:31] after the campaign is allocated, there may or may not be a corresponding banner to display [19:51:53] depending on banner-specific targeting and pre-display mixins [19:52:26] so if there's no banner displayed, campagin fallback then says 'remove this campaign and recalculate', throwing it back to chooseCampaign [19:55:54] (PS1) XenoRyet: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556045 [19:57:25] (CR) XenoRyet: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556045 (owner: XenoRyet) [19:59:25] ejegg: that's one I'll have to read a few times for it to sink in [19:59:29] thanks for the detailed overview [20:01:34] hmm fr-tech when looking at the recurring wrong day logs I saw that the duplicate merchant reference error was back and they all had .1, it looks like ones that are above ten are being truncated, like .15 to .1 [20:02:36] so any recurring payments that are over the 10th installment aren't getting through [20:07:43] that seems bad [20:09:26] cstone: oh crap, really? [20:09:48] dang, we seriously need more visibility into these numbers [20:11:06] I cant tell if its related to the patch to fix the long names or if they just happened in the same time frame, i think the long name patch was out for a whole day before this started [20:11:39] it started on 11/20 [20:12:11] ohhhh [20:12:15] let's see then [20:12:32] That could definitely be happening [20:13:23] yep, that sounds right [20:13:36] the yaml file has order_id limited to 10 chars [20:13:36] (PS8) Jgleeson: WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [20:13:38] (PS10) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) [20:13:40] (PS5) Jgleeson: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 (owner: Mepps) [20:13:58] cstone let's double check the rest of those limits [20:14:19] because we sure weren't getting complaints from the API for >10 char merchant reference numbers [20:14:32] is there nice documentation somewhere my quick search got me nothing [20:15:10] https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/index.html?paymentPlatform=ALL [20:15:28] hmm, that url looks different than I remember [20:15:39] lemme check out wiki docs and make sure their pointers are up to date [20:16:03] https://www.mediawiki.org/wiki/Fundraising_tech#Payment_Processors [20:16:12] has a link to https://epayments-api.developer-ingenico.com/ [20:16:23] which is still good [20:17:27] ohhh, there'a a merchantOrderId which has to be an integer (10) [20:17:38] and also a merchantReferecne which can be a string(40) [20:17:51] we're mapping to the merchantReference so we should use string (40) [20:18:07] cstone do you see where that needs to be updated? [20:20:34] in the yaml? [20:25:39] (PS6) Jgleeson: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 (owner: Mepps) [20:30:22] yep [20:33:12] fr-tech I'll be a bit late to the meeting [20:39:16] (PS7) Jgleeson: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 (owner: Mepps) [21:04:43] (CR) XenoRyet: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556045 (owner: XenoRyet) [21:14:03] Fundraising-Backlog: VI/MC requiring support for authorizations on refunds 4/2020 - https://phabricator.wikimedia.org/T240035 (DStrine) @EMartin @Ppena This will only apply to us if we need to do batch refunds. This doesn't happen that often for us but it will make batch refunds more complicated and expensi... [21:16:29] Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe count report hanging - https://phabricator.wikimedia.org/T240269 (MBeat33) [21:31:21] Fundraising-Backlog: Recurring payment merchant reference ids are truncated when over .9 - https://phabricator.wikimedia.org/T240272 (Cstone) [21:42:04] Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe count report and manual merges are hanging - https://phabricator.wikimedia.org/T240269 (MBeat33) [21:49:14] fr-tech, I'm gonna get back to packing boxes. see you all tomorrow o/ [21:51:51] jgleeson|away: have fun! [21:58:45] (PS1) Cstone: Change merchantReference to 40 character length alphanumeric. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/556064 (https://phabricator.wikimedia.org/T240272) [22:03:01] cstone ooh, I just noticed ipAddress is now a string(45) [22:04:02] ah hah is there a page in their documentation that nicely lists all of these? I only see chunks on example calls [22:04:28] there's this: https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/hostedcheckouts/create.html?paymentPlatform=ALL#hostedcheckouts-create-payload [22:04:36] but you have to expand each bit one at a time [22:06:35] ah okay thanks [22:15:51] (PS2) Cstone: Update ingenico field lengths and types. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/556064 (https://phabricator.wikimedia.org/T240272) [22:16:05] ejegg surname and locale both increased too so I changed those to match [22:18:41] or should I limit last name to match the civi db? [22:21:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI to enter donations directly into the queue - https://phabricator.wikimedia.org/T240284 (Ejegg) [22:39:59] (CR) XenoRyet: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556045 (owner: XenoRyet) [22:47:06] (CR) Ejegg: [C: +2] "Thanks, Christine!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/556064 (https://phabricator.wikimedia.org/T240272) (owner: Cstone) [22:47:25] (Merged) jenkins-bot: Update ingenico field lengths and types. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/556064 (https://phabricator.wikimedia.org/T240272) (owner: Cstone) [22:50:32] cstone so... those constraints are actually in 2 places now: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/ingenico_gateway/config/data_constraints.yaml [22:50:51] that ^^ shouldn't be causing us any problems now [22:51:03] but it would be nice to keep in sync, if you wanna put in another patch [22:51:37] yeah that makes sense [22:54:49] !log updated civicrm from 7eab025ec0 to 09149e0427 [22:54:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:03:47] (PS1) Cstone: Update field lengths and types. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556079 [23:04:34] !log reenabled Ingenico Connect recurring charge job [23:04:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:06:50] Fundraising Sprint X-rays, Fundraising-Backlog, Recurring-Donations: Recurring monthly conversion - processing date question - https://phabricator.wikimedia.org/T239627 (XenoRyet) This is fixed now. The patch to give monthly convert subscriptions the correct cycle day is live, and all existing month... [23:07:49] Fundraising Sprint X-rays, Fundraising-Backlog, Recurring-Donations: Recurring monthly conversion - processing date question - https://phabricator.wikimedia.org/T239627 (XenoRyet) a:XenoRyet [23:08:43] Fundraising Sprint X-rays, Fundraising-Backlog: investigate unintended recurring from December 2019 - https://phabricator.wikimedia.org/T240242 (XenoRyet) a:XenoRyet [23:15:17] fr-tech I haven't deployed smashpig recently, I'm blanking on its steps I know theres the version to update [23:19:17] hmmm 'fraid I don't know either [23:19:45] (PS3) Cdenes: French, Dutch, and Norwegian new TY emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552057 [23:24:28] cstone: There's this page, that I think did get updated last time we deployed Smashpig [23:24:29] https://www.mediawiki.org/wiki/Fundraising_tech/Deployment [23:24:52] hah thanks i was looking for that but on the other deployment page and the smashpig page [23:40:09] cstone oh no, it's even more involved than that now! [23:40:56] since we stopped saying to use the version 'dev-master' (just means the latest thing in git) [23:41:08] and started telling CRM to use the 'stable' version [23:41:21] we now have to give an actual version number to each thing we want to deploy [23:41:32] really tho it's just two more commands [23:41:40] I'll add 'em to that page [23:45:47] cstone: ok, added steps 2 and 3 there [23:45:53] ok thanks! [23:46:05] v0.5.11.3 is probably what we want to call this next version [23:46:16] the git tag! thats what i was thinking of [23:46:40] yep yep. I think that's the right syntax. plz fix the wiki if i bungled it! [23:47:58] yep its right [23:48:46] and updating on packagist is just pressing the update button? [23:51:02] cstone yep! [23:51:12] oh - one more note to add to that page [23:52:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: EOY summary text-format emails should be automatically generated from HTML - https://phabricator.wikimedia.org/T240298 (Ejegg)