[00:04:36] eileen: ah sorry forgot to mention that. so there are a ton of emails going out this week and we might not see that sharp of a drop in traffic. When we discussed the most quiet part of the week, it seems that would be early in the AM Pacific time on Monday. [00:05:16] dstrine: ok - maybe I'll just sneak a few chunks in when it doesn't look crazy theen [00:05:42] eileen: The problem is that, if we are turning off the queue to do this too, that makes people worried [00:06:12] could you try to do some pieces that are not microsoft and google this week and maybe save them for monday? [00:06:16] (Merged) jenkins-bot: Array formatting IDE cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556095 (owner: Eileen) [00:06:55] OK - I think small chunks are OK with the queues on when they are not crazy. I might only have the big 2 left in the file though. [00:07:37] eileen: ok if you want to test, let us know how it goes. I'm going to start an email on this just so everyone is in the loop [00:08:04] alright - I'll try a few more tonight & see [00:10:26] eileen: ah sorry I just saw your email. I'll reply there [00:10:36] cool [00:10:56] It takes me a decent amount of time to write the sprint reports and I'm basically afk until I get that out on Tuesdays :P [00:13:18] (PS2) Ejegg: Report recurring stats to grafana via hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556264 (https://phabricator.wikimedia.org/T199390) [00:17:40] (PS1) Eileen: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556297 [00:17:52] (CR) Eileen: [C: +2] Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556297 (owner: Eileen) [00:23:41] (Merged) jenkins-bot: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556297 (owner: Eileen) [00:28:10] (PS1) Eileen: Simplify duplication check. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556298 [00:29:05] ejegg: I can't find the ticket now for the exceptions - I found one query touching the wmf_contribution_extra that I thought could be slightly simplified ^^ [00:33:34] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556299 [00:34:00] eileen weird, did it get closed? [00:34:22] I swear it had 'exception' in the title [00:34:30] but I don't see it in our backlog now [00:34:35] not sure - still looking but also - my merge commit looks like it includes stuff it doesn't - I think it was cherry-pick deployed https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/556299/-1..1 [00:34:45] ie. the smashpig - the other 2 are tests [00:34:52] I don't think there is a problem just flagging it [00:34:57] yep, that was merged to the wrong branch first [00:35:06] then cherry-picked back to master [00:35:09] ok - well this should clean it up then I think? [00:35:14] yep [00:35:22] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556299 (owner: Eileen) [00:40:32] (PS2) Ejegg: dev/core#1444 Permit activities with campaigns on contact tab for contacts without 'administer CiviCampaign' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554667 (https://phabricator.wikimedia.org/T239374) (owner: Eileen) [00:40:38] (CR) Ejegg: [C: +2] dev/core#1444 Permit activities with campaigns on contact tab for contacts without 'administer CiviCampaign' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554667 (https://phabricator.wikimedia.org/T239374) (owner: Eileen) [00:43:55] ejegg: did you re-enable the dedupe? [00:44:59] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556299 (owner: Eileen) [00:46:18] (Merged) jenkins-bot: dev/core#1444 Permit activities with campaigns on contact tab for contacts without 'administer CiviCampaign' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/554667 (https://phabricator.wikimedia.org/T239374) (owner: Eileen) [00:46:55] !log civicrm revision changed from b519d4fb73 to 7b971ac58c, config revision is 9fb34fd93a [00:47:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:48:19] ejegg: ok - gonna turn dedupe back on & monitor for a bit - I just did a revert commit [00:50:23] (PS1) Ejegg: Update data constraints for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556300 [00:51:10] (CR) jerkins-bot: [V: -1] Update data constraints for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556300 (owner: Ejegg) [00:54:49] !log rocess-control config revision is 3f60e8fe9e [00:54:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:56:29] ejegg: ^^ - I can see there IS a DS agent doing non-reactive deduping (from the logs) - MBeat is Adriana doing pro-active deduping? It's kinda a waste of time until the dedupe job has caught up but logs suggest she is [00:56:48] she most likely is, eileen [00:57:18] I've just re-enabled the dedupe job so it will start running again when queue volume permits [00:57:57] thanks, is that a general thing, that if the script is off then proative human dedupe is made superfluous, eileen ? [00:58:05] Yeah really it is [00:58:16] I mean 90% of deduping is done by the script [00:58:25] so 90% of your time is wasted if the script is off [00:58:48] well, we will need a lot more heads up for when the script will be turned off, multiple contractors workflow depends on that [00:58:51] you could use the batch merge button - but then you'd be creating the load we turned the script off to avoid :-) [00:59:39] ejegg: when was the script turned off? Normally it's off at the start of the big english but this year it wasn't turned off straight away - but it actually self throttles when volume is really high [01:00:50] If you are using the Deduper to dedupe then at least you get the advantage of the bulk of the work being done by the script - but I think deduping whole ranges doesn't make sense [01:02:16] I’m going to need to follow up about systematizing this workflow, managing the contractors for dedupe has taken bandwidth from Sandra and I [01:02:39] I can see the script is working on the range around 37353866 to 37358888 now [01:02:54] and trying to balance the needs of Civi script versus human workflows will require care [01:03:04] & Adriana is betwee 34800000,35099999 [01:03:16] so it looks like she isn't doing the same range as the script [01:03:36] So I guess it's not a double up [01:04:52] It's mostly just that there is a short period where our servers have an incredible volume [01:05:42] but based on comparing those ranges it seems what she is doing is not time wasted [01:06:30] cool, thank you. is there a way to generate cid range queries that will avoid overlapping with that the script is doing? [01:06:33] *what the [01:07:10] Well I guess as of now the script is up to 37358888 - so focus on numbers below that for now & the script will hopefully start catching up now [01:07:27] great to know, thank you! [01:08:15] does the script start over at CID 1 when it catches up? if so could a little alarm go off so we can make queries to factor for that? [01:08:29] i’m thinking a cowbell or something… [01:09:25] lol - no we have to manually restart at cid 1 if we want o - sometimes it's good to re-do old ones because the script catches more now [01:09:55] oops eileen just saw your question [01:10:03] lemme see [01:12:49] i think it must have been right after the commit you just reverted [01:13:03] since I was fiddling with other jobs a couple hours later [01:13:11] so Dec 3 16:00 or so UTC [01:14:06] MBeat: I tried a handful that were in the range that were script-deduped before recent changes & just clicked 'safe merge' & 1 out of 10 'just merged' - so based on that non-representative sample 10% of the less rigourously manually deduped chunks might script-merge if we ran the script over again [01:15:03] I got 2 out of 10 that time :-) [01:15:35] thanks for testing. when my brain’s less tired I will think about how to optimize human workflows relative to script activity. maybe a little flag that would indicate to Sandra and I whether the script is on or not would be a start [01:16:35] eileen: would be nifty to output some stats to grafana for the dedupe job! [01:17:13] eileen: does this look like an OK pattern for a Civi ext to output stats via a hook? [01:17:15] MBeat: ejegg perhaps we want to track the last id range scriptt deduped [01:17:25] yeah - maybe that ^^ [01:17:30] https://gerrit.wikimedia.org/r/556264 [01:19:18] ejegg: no deadlocks so far since restarting dedupe :-) [01:24:05] script-got-up-to-here number would be cool [01:27:25] yeah - did you just try to run the dedupe report? [01:48:20] Processed id range 37353866 to 37358888 [01:48:20] 2019-12-11 01:46:43,884 INFO Merged 2778. Skipped 189 [01:53:26] hmm that's weird - it did odd things to grafana running tthat [01:53:59] ie the q delay got all wonky [02:00:23] eileen-taxi: looks like there was a bump in ingenico donations around the same time [02:00:46] guessing those were picked up from audit files [02:01:13] tho i don't see the audit parser on the jobs chart - that might be an oversight [06:55:26] !log process-control config revision is f34450e3ba - turn off dedupe to do Benevity import [06:55:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [09:15:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Q2-FY2019-20-cleanup-list: Add index to created_date & index_date for civicrm_contact - https://phabricator.wikimedia.org/T232036 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton We did this - never got added into the sprint though [09:20:52] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Undo WmfException::isNoEmail hack - https://phabricator.wikimedia.org/T136784 (Eileenmcnaughton) [09:21:51] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Undo WmfException::isNoEmail hack - https://phabricator.wikimedia.org/T136784 (Eileenmcnaughton) @Ejegg I found it - - @DStrine merged the exceptions one into this one. I've pulled... [09:22:36] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Undo WmfException::isNoEmail hack - https://phabricator.wikimedia.org/T136784 (Eileenmcnaughton) Opps - dang wrong phab. Actually I'm closing this one. I don't think we need 2-year-... [09:22:43] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Undo WmfException::isNoEmail hack - https://phabricator.wikimedia.org/T136784 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton [09:23:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird FK constraint problems in Civi - https://phabricator.wikimedia.org/T182148 (Eileenmcnaughton) @Ejegg I found it -the exception one & second time around am commenting on the right phab :-) - @DStrine merged the exceptions one into this one. I've pu... [09:23:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ensure we are coping with deadlock Exceptions properly & our q doesn't corrupt at high volume - https://phabricator.wikimedia.org/T182148 (Eileenmcnaughton) [09:24:08] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Ensure we are coping with deadlock Exceptions properly & our q doesn't corrupt at high volume - https://phabricator.wikimedia.org/T182148 (Eileenmcnaughton) [09:25:55] (PS1) Eileen: Remove unnecessary query when updating org, if no name udpate. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/556335 (https://phabricator.wikimedia.org/T182148) [09:27:28] (PS2) Eileen: Remove unnecessary query when updating org, if no name udpate. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/556335 (https://phabricator.wikimedia.org/T182148) [09:35:49] (PS2) Eileen: Simplify duplication check. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556298 (https://phabricator.wikimedia.org/T182148) [09:36:10] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Ensure we are coping with deadlock Exceptions properly & our q doesn't corrupt at high volume, reduce unecessary potent... - https://phabricator.wikimedia.org/T182148 [15:48:26] Wikimedia-Fundraising-Banners: RML popup remains from large fr-banner after scrolling down and switching to nag - https://phabricator.wikimedia.org/T237699 (spatton) I added a quick fix for this into dsk lg current best: https://meta.wikimedia.org/w/index.php?title=MediaWiki%3ACentralnotice-template-B1920_07... [16:00:12] (PS3) Ejegg: Remove unnecessary query when updating org, if no name udpate. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/556335 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [16:00:19] (CR) Ejegg: [C: +2] Remove unnecessary query when updating org, if no name udpate. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/556335 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [16:06:38] (Merged) jenkins-bot: Remove unnecessary query when updating org, if no name udpate. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/556335 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [16:27:16] fr-tech anything to share with scrum of scrums? [16:27:36] ejegg: thanks, nothing here! [17:07:38] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Ensure we are coping with deadlock Exceptions properly & our q doesn't corrupt at high volume, reduce unecessary potentially blocking queries - https://phabricator.wikimedia.org/T182148... [17:07:58] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Updated Subject Lines: French, Dutch, Norwegian - https://phabricator.wikimedia.org/T239215 (Ejegg) p:Triage→Normal a:CDenes_WMF [17:08:49] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Investigation: Tracking the drop in _all_wikimedia contact source job total rows - https://phabricator.wikimedia.org/T239635 (Ejegg) p:Triage→High a:Ejegg [17:08:57] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Investigation: Tracking the drop in _all_wikimedia contact source job total rows - https://phabricator.wikimedia.org/T239635 (Ejegg) Open→Resolved [17:37:36] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: EOY summary text-format emails should be automatically generated from HTML - https://phabricator.wikimedia.org/T240298 (Ejegg) p:Triage→High a:Ejegg [17:54:51] (PS1) Ejegg: EOY Summary: use autoconverted html for plaintext [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556433 (https://phabricator.wikimedia.org/T240298) [18:00:18] (CR) jerkins-bot: [V: -1] EOY Summary: use autoconverted html for plaintext [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556433 (https://phabricator.wikimedia.org/T240298) (owner: Ejegg) [18:01:45] (PS2) Ejegg: EOY Summary: use autoconverted html for plaintext [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556433 (https://phabricator.wikimedia.org/T240298) [18:04:35] (PS1) Ejegg: Cancel bg query loop when donation-age cleans up [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/556434 [18:18:42] Fundraising-Backlog, fundraising-tech-ops: Issue new Civi SSL cert for jadams (new hire) - https://phabricator.wikimedia.org/T240110 (Dwisehaupt) Thanks, @Lgruwell-WMF @kaythaney, as soon as we get the update to the contact page with his info, I'll generate his certificate and send it along. [19:10:53] (PS1) Ejegg: Log failure reason in orphan slayer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556453 (https://phabricator.wikimedia.org/T239769) [19:23:31] Fundraising-Backlog, fundraising-tech-ops: Issue new Civi SSL cert for jadams (new hire) - https://phabricator.wikimedia.org/T240110 (Dwisehaupt) Contact page has been updated, SSL cert created and sent to jadams along with the password via SMS. [19:27:46] fr-tech gonna run a quick errand [19:43:02] !log process-control config revision is 8c073ae64a [19:43:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:43:18] !log re-enabled dedupe (off from last night benevity import attempt) [19:43:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:54:21] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (EYener) Hi @Eileenmcnaughton, do you think I can star... [20:01:49] fundraising-tech-ops: refactor drush install - https://phabricator.wikimedia.org/T240499 (Jgreen) [20:02:19] fundraising-tech-ops: refactor drush install - https://phabricator.wikimedia.org/T240499 (Eileenmcnaughton) Composer? [20:08:48] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) @EYener - the list of all the maili... [20:12:36] (PS1) Cstone: Fix truncated recurring donations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556461 (https://phabricator.wikimedia.org/T240272) [20:21:22] what is the public export job - seems to fail about once a day [20:30:24] eileen: it runs every half hour, so those are pretty good averages :P [20:30:31] ok cool [20:30:49] it exports some spreadsheets we serve up here: https://frdata.wikimedia.org/ [20:31:04] I'm going to head out for a bit - I need to check if I can find a rabbit hutch for someone's xmas.... [21:03:23] Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (spatton) [21:07:11] fr-tech - see above [21:08:43] pcoombe: thanks! [21:09:20] Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (Pcoombe) I see two related looking javascript errors: ` Skipped unresolvable module ext.centralNotice.adminUi.bannerEditor resolveStubbornly @ load.php?lang=en&modules=startup&o... [21:11:25] Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (Pcoombe) p:Triage→Unbreak! [21:11:41] dstrine: fr-tech: yes definitely ubn [21:11:47] probably caused by the train deploy [21:12:37] argh! [21:13:31] AndyRussG: this looks like an opportunity for some 'git bisect' [21:14:05] I'm guessing the wmf_deploy branch of CentralNotice hasn't changed? [21:14:45] Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (DStrine) We are discussing on IRC. It's possibly due to the train deploy and #wikimedia-operations has been notified. [21:14:59] ejegg: not that I know of [21:15:45] ok, I'll see if I can replicate it on the latest commits in core [21:16:23] whoa: - Installing microsoft/tolerant-php-parser [21:16:34] (output of composer update in latest core) [21:17:49] ah crud, mcrMigrationStage not letting me run update.php [21:19:53] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (DStrine) [21:21:04] blindly changing it to SCHEMA_COMPAT_NEW and hoping I don't lose all my test setup [21:21:23] cool, main page still exists [21:21:59] jquery stuff is indeed broken on CN admin UI [21:22:13] (replicated locally) [21:23:11] dstrine: ejegg: pcoombe: appears to be fixed following train rollback! [21:23:33] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (Jdforrester-WMF) `jquery.ui.datepicker` was removed in wmf.10, yes. `wmf_deploy` strikes yet again. [21:23:37] not for me yet, just caching? [21:24:19] ok fixed now [21:25:07] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/556069/ probably the culprit, at least for the 2nd error I saw. Not sure about the first one [21:25:19] "Skipped unresolvable module ext.centralNotice.adminUi.bannerEditor" [21:25:41] pcoombe yep yep [21:26:21] ok, can confirm, rolling back to before that commit does fix the issue [21:26:50] So shall we just update our aliases for the jquery dependencies and do a quick CentralNotice update? [21:27:23] or... just revert that patch for now? [21:28:22] pcoombe: ejegg: it's the date picker that causes the unresolvable module [21:28:24] hmm, how did they determine "no longer used in core and bundled or [21:28:27] WMF-deployed extensions." [21:28:29] ? [21:28:36] See CentralNoticeHooks.php [21:28:45] They probably grepped only extension.json files [21:29:16] AndyRussG: looks like there are others we depend on - jquery.ui.core, .sortable, .draggable, .droppable, .multiselect [21:29:28] ah, I bet you're right! [21:29:41] and even .dialog [21:29:59] right, all in the hooks file, none of them in extension.json [21:31:29] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/389d9bff78694c8ded51c98d4eb2b09323f56663/includes/CentralNoticeHooks.php#75 [21:32:16] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (EYener) Great! Thank you, @Eileenmcnaughton! [21:34:56] AndyRussG: so it looks like we can just replace those all with one jquery.ui dependency for when the train rolls forward again? [21:35:10] PROBLEM - check_ipsec on mintaka is CRITICAL: Strongswan CRITICAL - ok: 1 not-conn: frban2001_v4 [21:35:16] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (AndyRussG) >>! In T240505#5733732, @Jdforrester-WMF wrote: > `jquery.ui.datepicker` was removed in wmf.10, yes. `wmf_deploy` strikes... [21:35:44] ejegg: can we? do you have doc on that? [21:36:11] yes it sounds like it was only the aliases removed, not the actual modules [21:36:18] the aliases patch just defines modules for each of the "jquery.ui.core" etc [21:36:27] which have no content, just a dependency on "jquery.ui" [21:36:45] See all the changes linked to https://phabricator.wikimedia.org/T219604 doing it for other extensions [21:37:32] pcoombe: ejegg: ah ok got it... Yeah so let's try to patch and fix so the train can roll tomorrow [21:38:22] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (AndyRussG) As per T219604, it's just the RL modules aliases that have changed, but the modules are still around, so we should be abl... [21:40:10] RECOVERY - check_ipsec on mintaka is OK: Strongswan OK - 2 ESP OK [21:41:06] (PS1) Jforrester: Remove use of jquery.ui module aliases [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/556477 (https://phabricator.wikimedia.org/T219604) [21:41:25] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (dduvall) [21:42:06] I guess a follow-on task would be to figure out why the CN uses weren't noticed. They don't appear in the Codesearch link in the description of https://phabricator.wikimedia.org/T219604 [21:43:54] (PS2) Jforrester: Remove use of jquery.ui module aliases [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/556477 (https://phabricator.wikimedia.org/T219604) [21:43:56] fr-tech ejegg James_F suggest we test and merge this so the train can continue [21:43:58] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/556477 [21:50:32] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: investigate unintended recurring from December 2019 - https://phabricator.wikimedia.org/T240242 (XenoRyet) Ok, for recurring donations canceled in December of this year, they don't seem clumped by date and they h... [22:04:49] ejegg trying to update smashpig on DI so CI is fixed for it and it added some extra files besides the change, is that normal? It seems to be reverting what your last update did https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/556478 [22:09:50] (CR) AndyRussG: [C: +2] "Thanks much!!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/556477 (https://phabricator.wikimedia.org/T219604) (owner: Jforrester) [22:12:44] (Merged) jenkins-bot: Remove use of jquery.ui module aliases [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/556477 (https://phabricator.wikimedia.org/T219604) (owner: Jforrester) [22:23:36] cstone yah that's your old version of composer [22:23:49] ah okay [22:24:04] just submit the change without the license or the php files [22:24:15] just the yaml and the installed.json [22:24:23] ok that makes sense, thanks [22:24:23] ejegg: I'm having trouble with my ssh key in Gerrit... Do you think that when the CN fix lands on the beta cluster you can cherry pick to wmf_deploy branch? [22:24:37] AndyRussG: sure thing! [22:24:53] so I guess jquery.ui.multiselect still does exist? [22:25:04] don't see it removed in the problem patch [22:26:01] ejegg: yeah this fixes things locally for me! https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/556477 [22:26:06] just waiting for beta cluster [22:26:43] thanks much!!!! [22:29:41] also its later in the day than I thought it was, fr-tech I put up the recurring fix here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/556461 [22:31:17] ejegg: it's working on the beta cluster, can you download, cherry-pick to wmf_deploy and git review? [22:31:20] thanks much in advance! [22:31:43] AndyRussG: oh, I could also just cherry-pick to wmf_deploy in the gerrit UI, no? [22:31:54] but... I'll do it via git review [22:32:01] oh right I forgot about that! [22:32:04] I can do that too then [22:32:07] okok [22:32:43] (PS1) AndyRussG: Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556487 (https://phabricator.wikimedia.org/T219604) [22:33:40] (CR) AndyRussG: [C: +2] Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556487 (https://phabricator.wikimedia.org/T219604) (owner: AndyRussG) [22:34:31] (CR) jerkins-bot: [V: -1] Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556487 (https://phabricator.wikimedia.org/T219604) (owner: AndyRussG) [22:34:36] cstone ok, looks good to me [22:34:43] hrm, V-1 on that? [22:34:52] cstone that date math looks fine [22:35:14] Yea, looks good to me as well. Seems like reasonable results when I run it as a select. [22:35:16] the two chunks added back up to the 6058 too [22:37:10] (CR) XenoRyet: [C: +2] Fix truncated recurring donations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556461 (https://phabricator.wikimedia.org/T240272) (owner: Cstone) [22:38:19] (PS1) Jforrester: build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556490 (https://phabricator.wikimedia.org/T192167) [22:38:36] thanks XenoRyet ! [22:39:06] (PS2) Jforrester: Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556487 (https://phabricator.wikimedia.org/T219604) (owner: AndyRussG) [22:40:28] (CR) jerkins-bot: [V: -1] build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556490 (https://phabricator.wikimedia.org/T192167) (owner: Jforrester) [22:43:09] (Merged) jenkins-bot: Fix truncated recurring donations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556461 (https://phabricator.wikimedia.org/T240272) (owner: Cstone) [22:46:35] (CR) Jforrester: [V: +2 C: +2] build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556490 (https://phabricator.wikimedia.org/T192167) (owner: Jforrester) [22:51:44] (Merged) jenkins-bot: Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/556487 (https://phabricator.wikimedia.org/T219604) (owner: AndyRussG) [22:53:42] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556494 [22:54:15] Fundraising-Backlog, fundraising-tech-ops: Issue new Civi SSL cert for jadams (new hire) - https://phabricator.wikimedia.org/T240110 (Dwisehaupt) The civicrm account has been created for him also. He will just need to reset his password for access using: https://civicrm.wikimedia.org/user/password [22:54:42] XenoRyet: I'm not sure I've done one of these updates, do I need to do something to have it actually run? [22:55:10] Yea, after the deploy is done, you need to run drush updb. [22:55:23] you do that in the drupal directory. [22:55:28] ok cool thanks [22:56:20] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556494 (owner: Cstone) [22:56:56] (CR) Cstone: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/556494 (owner: Cstone) [22:59:01] !log civicrm revision changed from 7b971ac58c to 8c8aa0e6d3 [22:59:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:03:00] (PS1) Jforrester: build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] (wmf/1.35.0-wmf.10) - https://gerrit.wikimedia.org/r/556496 (https://phabricator.wikimedia.org/T192167) [23:03:06] (CR) Jforrester: [V: +2 C: +2] build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] (wmf/1.35.0-wmf.10) - https://gerrit.wikimedia.org/r/556496 (https://phabricator.wikimedia.org/T192167) (owner: Jforrester) [23:03:31] (PS1) Jforrester: Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf/1.35.0-wmf.10) - https://gerrit.wikimedia.org/r/556497 (https://phabricator.wikimedia.org/T219604) [23:03:38] (CR) Jforrester: [C: +2] Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf/1.35.0-wmf.10) - https://gerrit.wikimedia.org/r/556497 (https://phabricator.wikimedia.org/T219604) (owner: Jforrester) [23:06:48] (Merged) jenkins-bot: Remove use of jquery.ui module aliases [extensions/CentralNotice] (wmf/1.35.0-wmf.10) - https://gerrit.wikimedia.org/r/556497 (https://phabricator.wikimedia.org/T219604) (owner: Jforrester) [23:22:23] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Patch-For-Review: Unbreak now (please) : newly broken CentralNotice admin interface - https://phabricator.wikimedia.org/T240505 (Jdforrester-WMF) Open→Resolved a:Jdforrester-WMF Declaring this fix.