[00:14:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) [00:17:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) [00:22:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) [05:20:54] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) [05:23:41] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) [11:19:20] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/557920 (owner: L10n-bot) [13:24:17] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556953 (owner: L10n-bot) [13:24:44] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/557920 (owner: L10n-bot) [13:44:43] ccccccelhikljfirljbrhkdvflcuifjcrkdnebgrkrvb [14:25:27] tzag fr-tech! [14:26:01] howdy mepps! [14:26:08] how goes it ejegg? [14:27:52] pretty good [14:28:35] didn't get much done on the house over the weekend, but we chilled with Naila's friends a bunch [14:28:43] how bout with you? [14:32:56] hmm, the weekend always feels like a blur by monday ejegg, it was mostly spent running after the kids as usual [14:40:28] tzag fr-tech [14:40:39] hey jgleeson [14:40:56] hey :) [14:41:42] hello jgleeson ! [14:41:47] hey ejegg :) [14:42:36] mepps: so I basically used up the remaining two days vacation I had last week instead of 2 HALF days as planned so I'll submit that shortly to safeguard and copy you in [14:52:29] sounds good jgleeson! [16:49:34] Fundraising-Backlog, Readers-Web-Backlog (Tracking): [Bug] Banner causes misalignment in article - https://phabricator.wikimedia.org/T240641 (Jdlrobson) Fundraising let us know if we can help in any way. [17:15:13] PROBLEM - check_raid on bellatrix is CRITICAL: CRITICAL: HPSA [P420i/slot0: OK, log_1: 16.37TB,RAID6 OK, phy_1I:1:1: Predictive Failure] [17:20:15] PROBLEM - check_raid on bellatrix is CRITICAL: CRITICAL: HPSA [P420i/slot0: OK, log_1: 16.37TB,RAID6 OK, phy_1I:1:1: Predictive Failure] [17:21:47] fundraising-tech-ops, DC-Ops: hw troubleshooting: hardware RAID predictive failure for bellatrix.frack.codfw.wmnet - https://phabricator.wikimedia.org/T240876 (Jgreen) [17:25:15] PROBLEM - check_raid on bellatrix is CRITICAL: CRITICAL: HPSA [P420i/slot0: OK, log_1: 16.37TB,RAID6 OK, phy_1I:1:1: Predictive Failure] [17:30:15] PROBLEM - check_raid on bellatrix is CRITICAL: CRITICAL: HPSA [P420i/slot0: OK, log_1: 16.37TB,RAID6 OK, phy_1I:1:1: Predictive Failure] [17:31:50] ACKNOWLEDGEMENT - check_raid on bellatrix is CRITICAL: CRITICAL: HPSA [P420i/slot0: OK, log_1: 16.37TB,RAID6 OK, phy_1I:1:1: Predictive Failure] Jeff_Green see T240876 [17:42:02] fundraising-tech-ops, DC-Ops: hw troubleshooting: hardware RAID predictive failure for bellatrix.frack.codfw.wmnet - https://phabricator.wikimedia.org/T240876 (Jgreen) bellatrix:~$ sudo ssacli controller slot=0 physicaldrive 1I:1:1 show detail [sudo] password for jgreen: Smart Array P420i in Slot 0 (E... [17:42:15] fundraising-tech-ops, DC-Ops: hw troubleshooting: hardware RAID predictive failure for bellatrix.frack.codfw.wmnet - https://phabricator.wikimedia.org/T240876 (Jgreen) [17:45:24] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: hw troubleshooting: hardware RAID predictive failure for bellatrix.frack.codfw.wmnet - https://phabricator.wikimedia.org/T240876 (Jgreen) [17:45:39] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: hw troubleshooting: hardware RAID predictive failure for bellatrix.frack.codfw.wmnet - https://phabricator.wikimedia.org/T240876 (Jgreen) a:Papaul [17:46:38] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: hw troubleshooting: hardware RAID predictive failure for bellatrix.frack.codfw.wmnet - https://phabricator.wikimedia.org/T240876 (Jgreen) Please note this server is still in service. [18:04:27] Fundraising-Backlog, fundraising-tech-ops: Monitor and investigate possible event dropping by Kafkatee - https://phabricator.wikimedia.org/T239564 (Jgreen) We've started collecting a whole bunch of metrics from kafkatee: https://frmon.frdev.wikimedia.org/d/xhmR5OBWk/kafkatee?orgId=1 [18:21:57] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558154 [19:09:38] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: copyedit needed for Endowment TY email - https://phabricator.wikimedia.org/T240731 (Cstone) a:Cstone [19:12:48] Wikimedia-Fundraising-Banners: Email input accepts invalid email address - https://phabricator.wikimedia.org/T240887 (jbolorinos-ctr) [19:19:29] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) a:AndyRussG [19:27:52] Wikimedia-Fundraising-Banners: Email input accepts invalid email address - https://phabricator.wikimedia.org/T240887 (Pcoombe) The current validation simply uses the MediaWiki core function `mw.util.validateEmail`. That could be changed, but there's some disagreement in T150394 about what to consider valid.... [19:33:21] Wikimedia-Fundraising-Banners: Email input accepts invalid email address - https://phabricator.wikimedia.org/T240887 (EWilfong_WMF) I'll add that there is verification on the Acoustic (nee, IBM and Silverpop) side as well so some emails will either not make it into the system or will never be sent to due to... [19:39:20] Wikimedia-Fundraising-Banners: Make it easier to fallback to Adyen in banners - https://phabricator.wikimedia.org/T240892 (Pcoombe) [19:42:55] Fundraising-Backlog: Solution for 3DS2.0 name field issue which caused Wikimedia to shut off 3Ds on payment page - https://phabricator.wikimedia.org/T236332 (EMartin) Ingenico advises that this change will be deployed mid January 2020 now. [19:58:29] Wikimedia-Fundraising-Banners: Email input accepts invalid email address - https://phabricator.wikimedia.org/T240887 (jbolorinos-ctr) oh nice! ok well I wanted to report it just in case...would this be affecting our bounce rates though? Are those measured after Acoustic (IBM, Silverpop) validation? Or before? [20:06:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Safari issue redirecting to PayPal - https://phabricator.wikimedia.org/T240896 (Ejegg) [20:24:29] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558154 (owner: Cstone) [20:34:46] (CR) Cstone: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558154 (owner: Cstone) [20:37:45] !log civicrm revision changed from ad2303ef72 to 505c653da1 [20:37:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:51:19] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: copyedit needed for Endowment TY email - https://phabricator.wikimedia.org/T240731 (Cstone) This has been deployed and I just tested it, it looks good. [20:52:26] (CR) Umherirrender: Use IDatabase::buildLike (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/557106 (owner: Umherirrender) [21:17:32] (PS2) Ejegg: Schema change for region-level geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/552121 (https://phabricator.wikimedia.org/T226438) [21:17:56] (PS34) Ejegg: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [21:20:43] (PS8) Jgleeson: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 (owner: Mepps) [21:40:25] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Safari issue redirecting to PayPal - https://phabricator.wikimedia.org/T240896 (Ejegg) We're redirecting with this code: top.location.href = result.redirect; Could we possibly be serving payments-wiki inside a frame for some users? Special... [21:49:59] so fr-tech I'm wanting to make a change to a commit 2 back from the one I'm working on and it looks like I can do it with git rebase -i and by marking the commit I want to change as 'edit'. Let's give it a go! [21:51:16] I wonder if I can git stash the changes and then reapply them on the edited commit [21:51:33] (CR) XenoRyet: [C: +2] EOY Summary: use autoconverted html for plaintext [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556433 (https://phabricator.wikimedia.org/T240298) (owner: Ejegg) [21:52:52] looks like that worked [21:53:51] perfect [21:54:07] so the commit I wanted to change was 840b8603060cf6e8ddacac3a29c5e9b951574e49 [21:54:33] so I did git rebase -i 840b8603060cf6e8ddacac3a29c5e9b951574e49^ (the caret starts from the one before I want to edit) [21:54:59] set the commit to edit in the rebase plan (plan feels like the right description) [21:56:00] once saved, it took me to the commit I wanted to edit and then I did `git stash pop` to retore the changes I stashed earlier [21:56:16] I then add that and ran `git commit --amend --no-edit` [21:56:28] follow by git rebase --continue [21:56:34] and it looks like it worked as expect [21:56:36] ed [21:57:23] (Merged) jenkins-bot: EOY Summary: use autoconverted html for plaintext [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556433 (https://phabricator.wikimedia.org/T240298) (owner: Ejegg) [22:00:08] (PS9) Jgleeson: WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [22:00:10] (PS11) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) [22:01:10] (CR) jerkins-bot: [V: -1] WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) (owner: Jgleeson) [22:02:47] Fundraising-Backlog, fundraising-tech-ops: Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) Question for the analytics folks: what our the requirements in terms of uptime and disaster recovery? With a single database server we run daily backups and store them offhos... [22:04:11] 22:00:58 Creating databases with the prefix 'civicrm_jenkins_wikimedia_fundraising_civicrm_docker_1641_' [22:04:13] 22:00:58 ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") [22:04:25] looks like some CI weirdness [22:09:43] (PS10) Jgleeson: WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [22:09:45] (PS12) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) [22:10:14] I've removed the WIP twice .. but they don't seem to wanna go [22:11:11] oooo I think it's cause I'm editing the commit message in the rebase plan [22:11:16] maybe that text is just ignored [22:11:20] and it just uses the hash [22:12:03] (PS11) Jgleeson: Add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [22:12:05] (PS13) Jgleeson: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) [22:12:07] that looks better [22:12:59] what I should have been doing is setting the commits I wanted to change the message for to 'reword' in the rebase plan [22:13:13] after doing that I could removed the WIP: prefix [22:13:58] (Abandoned) Jgleeson: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 (owner: Mepps) [22:15:02] mepps: I just squashed your patch into the original patch for the civi extension [22:15:26] so now we've just got two commits [22:17:04] (PS14) Jgleeson: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) [22:17:40] I just added the 'Depends-On' tag to the commit at the top so it's clear we need the other drupal module update in place for it to work [22:28:32] (CR) Cstone: [C: +2] "Looks good, new filters working locally." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/556819 (owner: Ejegg) [22:29:09] (Merged) jenkins-bot: Add filters from wmf_contribution_extra [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/556819 (owner: Ejegg) [22:33:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Set headers on payments-wiki - https://phabricator.wikimedia.org/T240911 (Ejegg) [23:00:39] (PS1) Ejegg: Prevent loading gateway pages in frames [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/558244 (https://phabricator.wikimedia.org/T240911) [23:06:40] (PS2) Ejegg: Adjust Benevity import code for changes made at Benevity. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556859 (https://phabricator.wikimedia.org/T239954) (owner: Eileen) [23:06:48] (CR) Ejegg: [C: +2] Adjust Benevity import code for changes made at Benevity. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556859 (https://phabricator.wikimedia.org/T239954) (owner: Eileen) [23:12:47] (Merged) jenkins-bot: Adjust Benevity import code for changes made at Benevity. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556859 (https://phabricator.wikimedia.org/T239954) (owner: Eileen) [23:15:53] (CR) Ejegg: "Is this the right way round? $matched is truthy if the matched transaction is already imported, and in that case you want to delete the _m" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556860 (https://phabricator.wikimedia.org/T236977) (owner: Eileen) [23:19:29] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558250 [23:19:34] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558250 (owner: Ejegg) [23:28:49] !log updated fundraising civicrm from 505c653da1 to b2d0b5d66d [23:28:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:29:50] Fundraising Sprint YAMLton, the Musical, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Benevity to change the reports we receive for Benevity import - https://phabricator.wikimedia.org/T239954 (Ejegg) This has been deployed - @RLewis you can now import with the new column headers. [23:37:41] Fundraising Sprint YAMLton, the Musical, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Benevity to change the reports we receive for Benevity import - https://phabricator.wikimedia.org/T239954 (RLewis) @Ejegg whoop thanks so much for getting this fixed so quickly, we really appreciate it.