[00:12:14] (PS2) Eileen: Add error code for deadlocks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/558312 (https://phabricator.wikimedia.org/T182148) [01:21:14] (CR) Eileen: [C: +2] "I discussed with ejegg & the non-unique temp tables will be an issue. I'm giving this + 2 but will follow up with a fix on the temp tables" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) (owner: Jgleeson) [01:27:32] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558755 [01:27:40] (Merged) jenkins-bot: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 (https://phabricator.wikimedia.org/T238692) (owner: Jgleeson) [01:29:06] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558755 (owner: Eileen) [02:09:23] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/558755 (owner: Eileen) [02:13:19] (PS1) Eileen: Coding practice - use single quotes unless double quotes required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558764 [02:14:17] !log civicrm revision changed from b2d0b5d66d to 93037d6e35, config revision is 2e9bf6308b [02:14:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:36:57] (PS2) Eileen: Coding practice - use single quotes unless double quotes required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558764 [03:36:59] (PS1) Eileen: Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) [03:37:01] (PS1) Eileen: Switch from drupal query function to civi (see previous commit for rationale) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558794 (https://phabricator.wikimedia.org/T238691) [03:43:27] (CR) jerkins-bot: [V: -1] Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [03:48:01] (PS2) Eileen: Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) [03:48:03] (PS2) Eileen: Switch from drupal query function to civi (see previous commit for rationale) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558794 (https://phabricator.wikimedia.org/T238691) [04:03:24] (PS1) Eileen: Switch to unique temporary table names [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) [04:04:21] (CR) DannyS712: Switch to unique temporary table names (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [04:05:51] (CR) DannyS712: Switch to getting the name of the temp tables by function. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [04:06:13] (CR) DannyS712: Switch to unique temporary table names (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [04:06:30] (CR) DannyS712: Switch from drupal query function to civi (see previous commit for rationale) (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558794 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [04:06:57] (CR) DannyS712: [C: +1] "Looks good" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558764 (owner: Eileen) [04:07:25] (CR) DannyS712: Add error code for deadlocks (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/558312 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [04:48:37] (PS1) Eileen: Move comment closer to the code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558813 [05:03:06] (PS1) Eileen: Use single quotes when they suffice (I think the Civi boiler plate might need this cleanup too) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558817 [05:03:08] (PS1) Eileen: Add explanatory text about how the eoy summary button copes with email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558818 (https://phabricator.wikimedia.org/T238691) [05:17:20] (PS2) Eileen: Handle deadlocks as WMFExceptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558315 (https://phabricator.wikimedia.org/T182148) [05:31:38] (PS2) Eileen: Use single quotes when they suffice (I think the Civi boiler plate might need this cleanup too) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558817 [05:31:40] (PS2) Eileen: Add explanatory text about how the eoy summary button copes with email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558818 (https://phabricator.wikimedia.org/T238691) [15:33:54] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code - https://phabricator.wikimedia.org/T240802 (AndyRussG) a:AndyRussG→None [15:34:54] fr-tech any news for scrum of scrums? [15:35:13] ejegg: nothing here, thanks! [15:40:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (AndyRussG) [15:56:46] (PS3) Ejegg: Update Benevity form to make date a form-level field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558265 (https://phabricator.wikimedia.org/T236976) (owner: Eileen) [15:57:27] (CR) Ejegg: [C: +2] "This works well. Maybe a follow-on patch could do some validation of the date selected and / or truncate the list of years in the dropdown" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558265 (https://phabricator.wikimedia.org/T236976) (owner: Eileen) [16:03:18] (Merged) jenkins-bot: Update Benevity form to make date a form-level field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558265 (https://phabricator.wikimedia.org/T236976) (owner: Eileen) [16:28:24] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 4 others: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (DStrine) Banner allocation pa... [16:29:59] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 4 others: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (Ejegg) UI comments: - Cut do... [17:06:05] (PS1) Ejegg: Naive attempt to make an Endowment filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/559138 (https://phabricator.wikimedia.org/T241000) [17:06:49] (CR) jerkins-bot: [V: -1] Naive attempt to make an Endowment filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/559138 (https://phabricator.wikimedia.org/T241000) (owner: Ejegg) [17:37:51] (PS2) Ejegg: Naive attempt to make an Endowment filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/559138 (https://phabricator.wikimedia.org/T241000) [17:39:50] (CR) Ejegg: "Wow, this actually seems to perform better than the previous bit (which put the endowment filter in the join to financial_type)." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/559138 (https://phabricator.wikimedia.org/T241000) (owner: Ejegg) [17:43:18] (CR) Jgleeson: [C: +2] Use single quotes when they suffice (I think the Civi boiler plate might need this cleanup too) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558817 (owner: Eileen) [17:45:18] (CR) Jgleeson: [C: +2] Add explanatory text about how the eoy summary button copes with email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558818 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [17:49:02] (Merged) jenkins-bot: Use single quotes when they suffice (I think the Civi boiler plate might need this cleanup too) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558817 (owner: Eileen) [17:50:53] (Merged) jenkins-bot: Add explanatory text about how the eoy summary button copes with email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558818 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [17:53:12] (CR) Jgleeson: "Test this changed the results output to the cli when run via the `drush wmf-eoy-receipts -vvv` command. I'll dig in and see if I can see w" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [17:53:29] (CR) Jgleeson: "Testing*" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [18:08:11] (PS3) Ejegg: Add IsEndowment filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/559138 (https://phabricator.wikimedia.org/T241000) [18:08:50] so, fr-tech, I think that filter actually performs way better than the old way of filtering out endowment ^^^ [18:09:21] I guess mariadb is good at mapping the case statement to the indexes [18:09:34] anyone want to do some independent performance testing? [18:10:15] I would do queries locally with the old code, then again with the new code and IsEndowment='No' selected in the UI [18:10:39] then look up the generated SQL in the widget and try running each on frdev [18:19:54] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Recurring-Donations: PayPal recurring: backfilled automated cancel? - https://phabricator.wikimedia.org/T239180 (XenoRyet) a:XenoRyet [18:28:02] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Recurring-Donations: PayPal recurring: backfilled automated cancel? - https://phabricator.wikimedia.org/T239180 (XenoRyet) @MBeat33 Ok, looks like this is from an event back in 2018 when paypal sent us a bun... [18:51:55] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Recurring-Donations: PayPal recurring: backfilled automated cancel? - https://phabricator.wikimedia.org/T239180 (MBeat33) thanks, @XenoRyet [19:23:58] (PS1) Jgleeson: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) [19:25:47] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [19:33:07] mepps did XenoRyet say he would miss the mid-sprint checkin? [19:33:18] Na, I'm back. [19:33:27] Just spaced on the time, be right there. [19:33:41] Gotta find my headphone cable real fast. [19:35:06] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: January Summary Emails - https://phabricator.wikimedia.org/T240648 (Ejegg) gerrit patch: https://gerrit.wikimedia.org/r/556837 [19:38:07] hey ejegg sorry i got distracted by a toddler [19:38:10] be right there too [19:38:30] oh ejegg XenoRyet sorry i missed you! [19:38:49] No worries, it was a quick on this time anyway. [19:43:45] (PS2) Ejegg: adding all the multilingual Jan summary emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556837 (https://phabricator.wikimedia.org/T240648) (owner: Cdenes) [19:49:52] (CR) jerkins-bot: [V: -1] adding all the multilingual Jan summary emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556837 (https://phabricator.wikimedia.org/T240648) (owner: Cdenes) [19:59:54] oh right, tests need update with the english email update [20:00:16] mepps was there anything you felt like we were in danger of missing? [20:00:25] I'm focussing on those EOY email translations ^^^ [20:00:44] nope ejegg! i didn't have much this time [20:01:03] ok [20:09:11] (PS3) Ejegg: adding all the multilingual Jan summary emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556837 (https://phabricator.wikimedia.org/T240648) (owner: Cdenes) [20:17:56] fr-tech can anyone look at ^^^ ? [20:18:08] That's the one dstrine was asking us to make sure we got deployed by tomorrow [20:33:39] (CR) Mepps: [C: +2] adding all the multilingual Jan summary emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556837 (https://phabricator.wikimedia.org/T240648) (owner: Cdenes) [20:35:06] thanks mepps [20:39:53] (Merged) jenkins-bot: adding all the multilingual Jan summary emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556837 (https://phabricator.wikimedia.org/T240648) (owner: Cdenes) [20:48:31] Fundraising-Backlog, fundraising-tech-ops: frdev1001 approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [21:28:52] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Patch-For-Review: Can we use Dash to track Endowment revenue? - https://phabricator.wikimedia.org/T241000 (Ejegg) a:Ejegg [21:33:59] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Patch-For-Review: Try a test IDEAL donation through adyen - https://phabricator.wikimedia.org/T240981 (Ejegg) a:jgleeson [21:38:48] (PS2) Eileen: Teach PEAR about deadlock errors [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/368517 (https://phabricator.wikimedia.org/T118487) (owner: Ejegg) [21:40:10] (CR) Eileen: [C: +1] "ejegg I'm pretty sure this is a good part of our solution - I've started some upstreaming - per comments & added a little to it so if you " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/368517 (https://phabricator.wikimedia.org/T118487) (owner: Ejegg) [22:17:30] (PS3) Eileen: Teach PEAR about deadlock errors [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/368517 (https://phabricator.wikimedia.org/T118487) (owner: Ejegg) [22:18:07] https://tools.wmflabs.org/wikibugs//nick eileen [22:36:00] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Recurring-Donations: PayPal recurring: backfilled automated cancel? - https://phabricator.wikimedia.org/T239180 (XenoRyet) Looks like there are many more like this, but we actually have a ticket for fixing th... [22:39:06] (PS1) Cdenes: adding the subject lines for the Jan EOY Summary Emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559222 [22:39:17] (CR) jerkins-bot: [V: -1] adding the subject lines for the Jan EOY Summary Emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559222 (owner: Cdenes) [22:41:26] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Finish fixing bad contribution_recur data from PayPal October 2018 cancel-storm - https://phabricator.wikimedia.org/T217379 (XenoRyet) a:XenoRyet [22:42:48] (Abandoned) Cdenes: adding the subject lines for the Jan EOY Summary Emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559222 (owner: Cdenes) [22:44:33] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Finish fixing bad contribution_recur data from PayPal October 2018 cancel-storm - https://phabricator.wikimedia.org/T217379 (XenoRyet) [22:44:35] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Recurring-Donations: PayPal recurring: backfilled automated cancel? - https://phabricator.wikimedia.org/T239180 (XenoRyet) [22:48:21] (CR) Ejegg: [C: +2] "Thanks for the impetus, Eileen!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/368517 (https://phabricator.wikimedia.org/T118487) (owner: Ejegg) [22:54:40] (Merged) jenkins-bot: Teach PEAR about deadlock errors [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/368517 (https://phabricator.wikimedia.org/T118487) (owner: Ejegg) [23:07:41] (PS1) XenoRyet: Fix bad contribution_recur data from PayPal October 2018 cancel-storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559227 (https://phabricator.wikimedia.org/T217379) [23:09:09] XenoRyet: oh huh, do we really update the next_sched_contribution_date when we record paypal txns? [23:09:38] (CR) jerkins-bot: [V: -1] Fix bad contribution_recur data from PayPal October 2018 cancel-storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559227 (https://phabricator.wikimedia.org/T217379) (owner: XenoRyet) [23:11:01] Am I updating it? I meant to only select against it to get stuff that's still actively recurring. [23:12:52] (PS1) Ejegg: EOY summary: subject line translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559229 (https://phabricator.wikimedia.org/T240648) [23:13:42] XenoRyet: and that does catch them? [23:14:02] I mean, when we record a new payment, we do update that field? [23:14:09] Yea, they are all apparently getting their next scheduled date set, even though it doesn't matter. [23:14:40] OK, if we're touching the recur record in any case, let's set the status in that same place. [23:15:05] Yea, I'll do that in a different patch. [23:15:15] got it [23:16:08] (PS2) XenoRyet: Fix bad contribution_recur data from PayPal October 2018 cancel-storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559227 (https://phabricator.wikimedia.org/T217379) [23:17:19] (PS3) XenoRyet: Fix bad contribution_recur data from PayPal October 2018 cancel-storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559227 (https://phabricator.wikimedia.org/T217379) [23:19:30] (CR) jerkins-bot: [V: -1] EOY summary: subject line translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/559229 (https://phabricator.wikimedia.org/T240648) (owner: Ejegg) [23:49:35] ejegg: I think we can reduce the deadlocks. From local I think they are mostly on acl_contact_cache table & that dropping the fk will likely fix