[05:23:58] (PS2) Eileen: Fix a bug in omnirecipient load on new jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) [05:24:20] (CR) Eileen: "ejegg I've finally updated this" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [05:30:22] (CR) jerkins-bot: [V: -1] Fix a bug in omnirecipient load on new jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [05:38:40] (PS3) Eileen: Fix a bug in omnirecipient load on new jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) [05:39:28] (PS1) Eileen: Add indexes to civicrm_acl_cache.modified_date. * * Despite being basically empty this table is involved in deadlocks * frequently. * * I've added this index upstream * https://github.com/civicrm/civicrm-core/pull/16144 * It should be super quick to run so won't require an outage. * * I'm looking into further ways to improve contention on this table * https://lab.civicrm.org/dev/core/issues/1486 [wikime [05:39:29] (https://phabricator.wikimedia.org/T182148) [16:10:25] (CR) Ejegg: [C: +2] Fix a bug in omnirecipient load on new jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [16:15:57] hi jgleeson ! [16:16:03] hey ejegg :)P [16:16:05] -P [16:16:11] hehe [16:16:11] how's it goin [16:16:17] oh, pretty good [16:16:39] just getting started a bit late [16:16:43] good good [16:16:47] looking at eileen's patches [16:16:53] (Merged) jenkins-bot: Fix a bug in omnirecipient load on new jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [16:17:02] gonna review the one to add the acl contact cache index [16:17:11] seems like it shouldn't hurt, at the least [16:17:44] I'm gonna update this patch today https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/558793/ to meet the commit guidelines mentiond by DannyS712 and +2 [16:17:47] then there was that one other of hers that was a prerequisite for the others you +2ed [16:17:53] ^^ [16:17:59] ahhh, that was the change you wanted to see [16:18:01] gotcha [16:18:17] heh, I'mma edit the commit message on the index change too [16:18:26] I also caught you figured out how to pull in the hooks [16:18:30] with a good ole require [16:18:49] so I'll take another go at that patch at some point [16:18:50] jgleeson yeah, seemed like the easiest [16:19:13] I wanna pull down the adyen credentials first though from test/staging and test that out [16:19:17] then as the TODO says, I'd like to split out a bunch of other code from that monster .module file [16:19:21] I'll lagging behind on that [16:19:38] oh right, the ideal test [16:19:43] cool [16:20:08] ye [16:20:10] p [16:20:57] you know what it might be quicker to do eileen's patch first and unblock that [16:23:58] (PS4) Jgleeson: Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:25:04] (CR) Jgleeson: [C: +2] Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:28:49] ok looks like I also now get redirected to test.adyen! [16:29:07] woohoo! And they let you select the bank on their page? [16:29:45] hmm not yet. I'm getting an invalid request error page on their domain [16:29:55] so I guess I might need to inspect what we're sending [16:35:29] okok [16:35:44] I'll start playing around with that too [16:36:56] weird, gate-and-submit ended up with C+2V+2 but didn't submit [16:37:18] I think I need to drop off the combined earlier submit which has already been merged [16:37:18] (PS2) Ejegg: Switch to unique temporary table names [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:37:31] (PS2) Ejegg: Move comment closer to the code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558813 (owner: Eileen) [16:38:42] ah, maybe rebase 558793 ? [16:38:49] (PS5) Ejegg: Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:40:02] (PS4) Ejegg: Switch from drupal query function to civi (see previous commit for rationale) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558794 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:40:14] (PS3) Ejegg: Switch to unique temporary table names [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:40:24] (PS3) Ejegg: Move comment closer to the code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558813 (owner: Eileen) [16:40:41] well, there's everything rebased for easier digestion [16:42:07] (PS2) Ejegg: Add indexes to civicrm_acl_cache.modified_date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560363 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [16:42:58] (CR) Ejegg: [C: +2] Add indexes to civicrm_acl_cache.modified_date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560363 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [16:48:38] huh, even with everything rebased, zuul's not pressing submit [16:48:54] (Merged) jenkins-bot: Switch to getting the name of the temp tables by function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558793 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:48:57] (Merged) jenkins-bot: Switch from drupal query function to civi (see previous commit for rationale) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558794 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:48:59] (Merged) jenkins-bot: Switch to unique temporary table names [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558802 (https://phabricator.wikimedia.org/T238691) (owner: Eileen) [16:49:03] oh there it goes! [16:55:04] (Merged) jenkins-bot: Move comment closer to the code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/558813 (owner: Eileen) [16:55:07] (Merged) jenkins-bot: Add indexes to civicrm_acl_cache.modified_date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560363 (https://phabricator.wikimedia.org/T182148) (owner: Eileen) [17:07:33] (CR) Ejegg: "Ooh, nice way to point out the tests that don't clean up after themselves!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [18:04:58] (CR) Ejegg: "Ah, looks like a few probably-false-positives on tests that use the CiviFixtures test but call the destructor after parent::tearDown()" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [18:28:11] (PS1) Ejegg: Use base-class cleanup code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560420 [18:34:16] (PS4) Ejegg: Add check to see what contact cruft we are leaving behind [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [18:40:40] (CR) jerkins-bot: [V: -1] Add check to see what contact cruft we are leaving behind [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [18:44:35] (CR) Ejegg: [C: -1] "Hmm, still 50 failures in the cruft-detector after rebasing on top of this one. Needs more investigation" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560420 (owner: Ejegg) [18:53:01] jgleeson are you getting " [18:53:01] At this moment there are no payment methods available for this combination of amount, currency and account [18:53:04] " [18:53:09] at the adyen test site? [18:53:30] thats what I was getting [18:53:35] I got that message. Am just now logging in to the test console to see if I can enable it [18:53:45] does everyone have accounts at ca-test.adyen.com ? [18:55:44] hmm that page is not loading for me [18:56:10] cstone ah, I think you need to manually specify https [18:56:15] it doesn't redirect from http [18:56:33] hmm fr-tech I do see ideal in the 'configured payment methods' page [18:56:39] yep [18:56:54] I wonder if the bankTransfer filter is correct [18:57:03] gonna try leaving that bit out [18:57:43] i do have an account [18:58:41] ok, cool [19:00:16] so if I leave out the allowedMethods it just shows cards and UnionPay [19:00:27] let's see if we're sending the country [19:47:52] ok, so we're sending locale, but maybe country is separate? [19:52:01] hmm, sending billingAddress.country now and still no ideal available [19:53:12] and still no useif I switch to language=nl [19:57:49] ooh, looks like maybe we DO need to send a bank code? [19:57:55] https://docs.adyen.com/development-resources/test-cards/test-card-numbers#ideal [19:58:08] mentions a paymentMethod.issuer field [19:58:14] will try sending that [20:02:16] hmm, although here: https://docs.adyen.com/payment-methods/ideal/web-component [20:02:31] it notes that issuer is optional, and will pre-select that issuer [20:08:18] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/560429 [20:08:21] could it ben skin config? [20:08:27] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/560429 (owner: Eileen) [20:10:55] ideal is enabled in the skin config, so that's not the issue [20:13:57] OK, time to write another email to adyen? [20:16:42] I'm gonna push out those few patches [20:17:06] sorry ejegg I was away. roxys grandparents dropped in for dinner. back now just reading up [20:18:04] thanks eileen ! [20:18:16] eileen: sorry for the hold up on the prereq patch. I noticed some feedback around commit spaces so I update your patch to satisfy the guidelines [20:18:36] jgleeson: cool, I've just been messing about with a few changes to the txn setup and nothing seems to make iDEAL available on the hosted page [20:18:50] jgleeson: yeah I saw that - who is the guy who commented [20:18:54] if I take out the availableMethods it shows cards & unionpay [20:19:06] DannyS712 [20:19:21] yep but who is he? [20:19:31] @_@ [20:19:48] that index is added - I've been thinking about dropping the contact_id FK on that table [20:19:48] volunteer maybe? [20:20:17] yeah I'm afraid I just thought 'who are you' & didn't look too carefully at what he said [20:21:01] It's good to see others are making sure we keep up the standard! :) [20:21:01] Form builder in CIvi presentation https://civicrm.org/blog/josh/form-builder-gui-presented-by-coleman-watts [20:21:19] I just hope he doesn't look at any of my commits [20:24:07] :-) [20:25:06] eileen: it's christmas eve where you are right? [20:25:24] (for those who celebrate christmas) [20:25:39] I think it's officially a wmf holiday [20:25:43] in nz [20:26:01] jgleeson: yep xmas eve [20:26:39] I'm going to work part of my day & then a bit more at some point before the end of the year & get the hours in for the month overall [20:26:50] ah [20:26:52] I see [20:31:28] ejegg: meeting? [20:31:41] also AndyRussG [20:35:21] (CR) Jgleeson: [C: -1] "This is working great. I did notice the casing of the prometheus metric output is UCfirst and not lowercase like the others. Could they be" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556264 (https://phabricator.wikimedia.org/T199390) (owner: Ejegg) [20:47:21] (PS5) Ejegg: Report recurring stats to grafana via hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556264 (https://phabricator.wikimedia.org/T199390) [21:08:50] (CR) Jgleeson: [C: +2] Report recurring stats to grafana via hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556264 (https://phabricator.wikimedia.org/T199390) (owner: Ejegg) [21:15:03] (Merged) jenkins-bot: Report recurring stats to grafana via hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556264 (https://phabricator.wikimedia.org/T199390) (owner: Ejegg) [21:35:43] dstrine - Josh asked me if he could show the statement of work to a civishop who has an interest (& possibly some funds) [21:39:49] eileen: oh um I guess that's ok [21:40:05] eileen: can this be closed?https://phabricator.wikimedia.org/T236856 [21:40:05] thanks - will let him know [21:40:13] also this one:https://phabricator.wikimedia.org/T236855 [21:40:54] the first one I think yes - probably too low level to ask MG to confirm [21:41:37] the second one - there is still something causing it to slip. I have retrieved all the old data & as of now it's up to date but I 'm digging into why gaps still emerge [21:44:02] ok thanks [21:44:29] eileen: and jgleeson a related task was deployed. What's the overall status of thisone? https://phabricator.wikimedia.org/T221271 [21:45:03] I think that is done - jgleeson ? We need to tell DS how to use it... [21:48:43] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix bug where Benevity import tries & fails to validate source for contacts with one - https://phabricator.wikimedia.org/T236856 (DStrine) Open→Resolved [21:52:02] eileen: jgleeson cool! yeah resolve all the tasks on that if you think it done Congrats!! They are really looking forward to it [21:53:06] fr-tech It's nice out here. I'm taking the dog for a mini hike. I'll be back in a bit. [22:11:28] turkey dry brine started. guess we'll have to eat it now. [22:26:25] oooh, there's a whole nother countryCode parameter for adyen [22:26:30] not just billingAddress.countryCode [22:26:49] glad I checked again before I sent that email [22:27:21] annndddd... Bank Transfer(NL) now shows up as an option! [22:27:25] I assume that's ideal [22:27:47] hmm, doesn't look exactly like it [22:31:38] ooh, ok, if I get rid of allowedMethods and send countryCode=NL I do see iDEAL in the list of options [22:31:55] now the trick is to determine what allowedMethod it is [22:32:02] ideal? [22:32:43] yay, guessed right! [22:32:54] ok, I should update this WIP [22:33:45] cool cool, that more-or-less works [22:34:05] just did my first actual use of git add -p. suprisingly useful. [22:35:17] (PS2) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [22:35:43] cstone ^^^ shows a test bank list!!! [22:35:52] oooh exciting [22:36:49] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [22:37:20] might need to add some handing for the different status codes [22:39:33] odd, tests have been getting away with not specifying payment_method [22:40:54] (PS3) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [22:41:23] woo i can see the list of banks [22:43:10] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [22:45:27] (PS4) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [22:48:42] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [23:01:56] cstone cool! So I guess next we use the banks at tht bottom of that list to test the different result codes [23:11:40] are they all the test banks from adyen or did we set them up somewhere in the test console? [23:17:09] cstone they're all from adyen [23:17:32] and there are some that exist just to specify unsuccessful return codes [23:21:58] ah okay [23:22:04] I'm off to lunch - not sure if I'll be back today so merry xmas all if not [23:22:46] (PS1) Ejegg: Fix test goof in stats / hook patch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560453 [23:24:57] (PS5) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [23:26:30] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [23:29:04] (PS6) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [23:30:27] cool, looks like ideal is already in the adyen decoder class in SmashPig [23:30:48] so no updates needed for audit files [23:39:21] ok, so with iDEAL we don't get a chance to reject the txn after they come back with 'AUTHORIZED' status, I'm pretty sure [23:40:22] in that case, they should always see the TY page and we should send the donation right to Civi [23:59:38] (PS7) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson)