[00:09:01] (PS1) Eileen: Rename Deduper translation class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561393 [00:16:25] (PS1) Eileen: Towards rename - change CRM_Dedupetools to CRM_Deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561394 [00:21:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (Jgreen) Chattering in IRC, it sounds as though we should set up an interim fix--a process-control task to purge cruft either by drush or by a bash find & delete. I'm... [00:22:48] !log re-enabled fundraising cron jobs [00:22:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:53:46] (PS1) Eileen: Rename all dedupetoosl_civix functions to dedupe_civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561396 [00:53:48] (PS1) Eileen: Rename dedupetools.civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561397 [01:17:20] (PS1) Eileen: Move dedupetools file to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561399 [03:13:56] (PS1) Eileen: Update translate fn to use Util & not reference ext name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561404 [03:13:58] (PS1) Eileen: Rename dedupe extension short name to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561405 [03:14:00] (PS1) Eileen: Rename angular files to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561406 [03:14:02] (PS1) Eileen: Deduper rename - fix report templates & xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561407 [03:22:13] (PS2) Eileen: Deduper rename - fix report templates & xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561407 [03:56:11] (PS1) Eileen: Finish renaming deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561409 [03:59:01] (PS1) Eileen: Rename test folder [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561410 [03:59:41] (CR) jerkins-bot: [V: -1] Finish renaming deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561409 (owner: Eileen) [04:02:45] (CR) jerkins-bot: [V: -1] Rename test folder [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561410 (owner: Eileen) [04:06:43] (PS2) Eileen: Finish renaming deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561409 [04:06:45] (PS2) Eileen: Rename test folder [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561410 [04:20:02] (PS3) DannyS712: Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) [04:28:37] (PS1) Eileen: Readability - do trim further down, fix test comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561414 [04:28:39] (PS1) Eileen: Fix pattern in dedupe resulting in conflicts not being merged. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561415 (https://phabricator.wikimedia.org/T230954) [06:37:03] (CR) Legoktm: [C: +2] Move test-only classes to new TestAutoloadClasses declaration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561180 (https://phabricator.wikimedia.org/T196090) (owner: Umherirrender) [06:44:53] (PS1) Eileen: Convert test I want to add to to a better data provider [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561443 (https://phabricator.wikimedia.org/T230954) [06:44:55] (PS1) Eileen: Add test for merge pattern not merging. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561444 (https://phabricator.wikimedia.org/T230954) [06:44:57] (PS1) Eileen: Add merge handling for double initial in last name. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561445 (https://phabricator.wikimedia.org/T230954) [06:44:59] (PS1) Eileen: Documentation improvement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561446 [07:09:50] (Merged) jenkins-bot: Move test-only classes to new TestAutoloadClasses declaration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561180 (https://phabricator.wikimedia.org/T196090) (owner: Umherirrender) [10:03:23] (CR) AndyRussG: [C: -1] "Whoa, huge amount of work here! Congratulations, @ejegg and @Vedmaka Wakalaka, and also thanks @awight for the comments!" (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [10:52:38] (CR) Daimona Eaytoy: [C: -1] Remove uses of global $wgUser as a fallback (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [12:46:52] (CR) Jgleeson: [C: +2] Fix a couple of typos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561384 (owner: Eileen) [12:53:14] (Merged) jenkins-bot: Fix a couple of typos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561384 (owner: Eileen) [12:54:08] (CR) Jgleeson: [C: -1] "Looks good. I just have a question on the ExtensionUtil use statements." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561393 (owner: Eileen) [13:50:32] (PS1) Umherirrender: build: Upgrading grunt-banana-checker to 0.8.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/561622 [16:02:08] Happy New Year ejegg ! looks like you had a busy day off yesterday [16:04:20] happy new year jgleeson ! [16:04:33] i'm making up for it with this late start today [16:04:56] that drupal cache can get quite large! [16:21:03] Wikimedia-Fundraising-Banners: Radio inputs are not appearing on Mac 10.14/Firefox 69 + 70 - https://phabricator.wikimedia.org/T241603 (jbolorinos-ctr) Thanks for the valuable inputs @Pcoombe and @EWilfong_WMF! I just tested the link you sent and it does appear that this is a VM issue and NOT an issue with t... [16:21:48] Wikimedia-Fundraising-Banners: Radio inputs are not appearing on Mac 10.14/Firefox 69 + 70 - https://phabricator.wikimedia.org/T241603 (jbolorinos-ctr) Open→Resolved p:Triage→Lowest [16:21:49] (CR) Siebrand: [C: +2] build: Upgrading grunt-banana-checker to 0.8.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/561622 (owner: Umherirrender) [16:27:06] (Merged) jenkins-bot: build: Upgrading grunt-banana-checker to 0.8.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/561622 (owner: Umherirrender) [16:32:24] (CR) Jgleeson: [C: +2] "actually I think this can be +2'd as if and you can make the changes if needed later to save have to restack the patches next in the chain" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561393 (owner: Eileen) [16:34:10] (CR) Jgleeson: [C: +2] Towards rename - change CRM_Dedupetools to CRM_Deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561394 (owner: Eileen) [16:36:42] ejegg: I wanna quickly update the commit message for one of eileen's patches here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/561396/. once amended and pushed will I need to then update the next patch to rebase over the patch I changed or do I have to update them all up the way? [16:36:51] back to git101 for the new year for me [16:38:36] (Merged) jenkins-bot: Rename Deduper translation class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561393 (owner: Eileen) [16:39:30] (CR) Jgleeson: "I'm just gonna fix the commit message on this before +2'ing" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561396 (owner: Eileen) [16:40:26] (PS2) Jgleeson: Rename all dedupetools_civix functions to deduper_civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561396 (owner: Eileen) [16:40:28] (Merged) jenkins-bot: Towards rename - change CRM_Dedupetools to CRM_Deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561394 (owner: Eileen) [16:43:04] (PS2) Jgleeson: Rename dedupetools.civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561397 (owner: Eileen) [16:43:16] hmmm hopefully it's just that one patch [16:43:31] that needs repointing to the updated earlier patch [16:44:14] argh... looks like it's not that straightforward [16:45:45] hmm I wonder if I can just checkout the patch at the very top of the chain and rebase that over the newer version of the earlier patch [16:48:27] (PS2) Jgleeson: Move dedupetools file to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561399 (owner: Eileen) [16:48:29] (PS2) Jgleeson: Update translate fn to use Util & not reference ext name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561404 (owner: Eileen) [16:48:31] (PS2) Jgleeson: Rename dedupe extension short name to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561405 (owner: Eileen) [16:48:33] (PS2) Jgleeson: Rename angular files to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561406 (owner: Eileen) [16:48:35] (PS3) Jgleeson: Deduper rename - fix report templates & xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561407 (owner: Eileen) [16:48:37] (PS3) Jgleeson: Finish renaming deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561409 (owner: Eileen) [16:48:39] (PS3) Jgleeson: Rename test folder [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561410 (owner: Eileen) [16:48:40] jgleeson ah, sorry [16:48:41] (PS2) Jgleeson: Readability - do trim further down, fix test comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561414 (owner: Eileen) [16:48:43] (PS2) Jgleeson: Fix pattern in dedupe resulting in conflicts not being merged. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561415 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [16:48:45] (PS2) Jgleeson: Convert test I want to add to to a better data provider [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561443 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [16:48:47] (PS2) Jgleeson: Add test for merge pattern not merging. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561444 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [16:48:49] (PS2) Jgleeson: Add merge handling for double initial in last name. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561445 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [16:48:51] (PS2) Jgleeson: Documentation improvement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561446 (owner: Eileen) [16:49:10] heh, that's quite a chain of patches [16:49:12] I think that did it [16:49:52] I'm not seeing the indirect ancestor icon now [16:50:26] I did 'git rebase -i 5a8d9f84e64cbd6e7edc3c510dc9051b43f7594e' with the hash being the latest version of the earlier patch in the chain I updated [16:50:50] (CR) Jgleeson: [C: +2] Rename all dedupetools_civix functions to deduper_civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561396 (owner: Eileen) [16:58:48] jgleeson: sounds good [17:01:40] (Merged) jenkins-bot: Rename all dedupetools_civix functions to deduper_civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561396 (owner: Eileen) [17:05:17] (PS1) Ejegg: Remove unused function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561678 [17:06:04] (PS3) Ejegg: Schema change for region-level geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/552121 (https://phabricator.wikimedia.org/T226438) [17:07:08] (PS35) Ejegg: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:08:28] (CR) Ejegg: Finer geo targeting (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:08:54] Fundraising-Backlog, fundraising-tech-ops: Revoke ssl client certificate for mbrent - https://phabricator.wikimedia.org/T241744 (Dwisehaupt) [17:10:20] (CR) jerkins-bot: [V: -1] Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:12:16] hmm [17:14:09] whoa, phan caught some things that look serious [17:15:21] ah, bad rebase [17:16:46] (PS36) Ejegg: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:18:46] (CR) Jgleeson: [C: +2] Rename dedupetools.civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561397 (owner: Eileen) [17:19:18] (CR) Jgleeson: [C: +2] Move dedupetools file to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561399 (owner: Eileen) [17:25:02] (Merged) jenkins-bot: Rename dedupetools.civix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561397 (owner: Eileen) [17:25:36] (Merged) jenkins-bot: Move dedupetools file to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561399 (owner: Eileen) [18:11:36] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ccarter - https://phabricator.wikimedia.org/T241752 (Dwisehaupt) [18:12:57] thanks for those merges jgleeson [18:15:20] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for cvirtue - https://phabricator.wikimedia.org/T241753 (Dwisehaupt) [18:21:42] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Can we use Dash to track Endowment revenue? - https://phabricator.wikimedia.org/T241000 (Ejegg) Open→Resolved p:Triage→Normal [18:29:35] fr-tech shall we use this retro to go over failmail from the break? [18:29:44] !log disabled fundraising cron jobs [18:29:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:30:01] sure ejegg that sounds like a good idea [18:38:57] eileen: we're chatting about dedupe failmail over in #fr-tech-alerts [18:46:20] OK, jobs have all quieted down. Going to run the EOY summary calculator! [18:51:49] Jeff_Green: the EOY summary calculator worked! [18:52:07] yay! great [18:53:00] !log re-enabled fundraising cron jobs [18:53:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:53:54] Jeff_Green: looks like we have 282k mails to send. If we do that over the next 36 hrs, that's about 8k / hr [18:54:20] should be fun :-P [18:54:30] our TY sends for the last 2 days of the year would have been higher, I think [18:54:30] Fundraising-Backlog: Emojis in firstname/lastname causing names to be too long for Ingenico - https://phabricator.wikimedia.org/T241757 (Cstone) [18:54:32] can we adjust the rate as we go? [18:54:38] Jeff_Green: yep, totally [18:54:55] great [18:55:09] So I'll send a couple of batches of 1 as a test [18:55:15] sounds good [18:55:20] then set it up for batches of 2000 every 15 min [18:56:06] as long as we can keep the postfix queue below 100K we should be fine [18:58:26] Cool cool. Looks like the last 10 hrs of 2019 did have TY sends around 8k/hr [19:00:46] Jeff_Green: oh hey, math [19:01:02] or rather hours/day != 12 [19:01:12] we have 72 hrs to send, not 36 [19:01:21] so that's 4k/hr [19:02:56] I wouldn't get super hung-up on msg/hr, the thing that will cause us pain is when some ISP starts deferring or we get on a blacklist--neither of which are very predictable [19:03:23] ok. hopefully we're less likely to hit their threshold with the lower rate [19:03:30] yeah [19:08:25] fr-tech anyone want to review the new yaml file for sending those emails? [19:08:52] I figure we can use the --slow-start command to test a couple batches of 1 [19:09:01] and make sure they're getting marked complete [19:09:21] sure I can take a look ejegg [19:09:26] oh, I guess I could include a commented-out schedule line for now [19:09:28] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for nnichols - https://phabricator.wikimedia.org/T241758 (Dwisehaupt) [19:09:30] thanks jgleeson ! [19:12:43] jgleeson: I just pushed a second change to add a commented-out schedule line [19:13:06] running every 15 min starting at 4 min past the hr [19:13:57] just pulled that in [19:14:37] the yaml looks good. should the slow_start_command key have an actual command? I forget [19:15:27] yep, it's like the command: key - the value is on the next line [19:16:00] ah I couldn't see one but I think that might just be down to my diff not showing unaffected stuff [19:16:03] doh! [19:16:48] ejegg: isn't the job ID dynamically generated? [19:17:03] I notice we pay job id 2 explicitly [19:17:05] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jrobell - https://phabricator.wikimedia.org/T241759 (Dwisehaupt) [19:17:09] pass* [19:17:15] jgleeson yep, the calculate job outputs the ID [19:17:29] and when I ran it, it output ID 2 [19:18:02] We can look in the wmf_eoy_reciept_donor job to verify that there really are ~300k rows with job id 2 [19:19:13] so is the plan to remove that id once we've performed this batch? [19:19:18] yep, they are there [19:19:23] is that how we currently use the two step job [19:19:27] ah ok I didn't know [19:19:29] thanks [19:19:44] jgleeson: yeah, the idea would be to disable the job when the send is finished (in a few days) [19:19:50] and then next year update it with the new ID [19:19:59] got it [19:20:46] all looks good to me ejegg I guess we can start slow startin.. :) [19:21:07] thanks! [19:23:25] ok, slow-start says it sent 1 message [19:23:37] let's look at the table and make sure it got marked sent [19:25:07] looks like a donor with 4 contributions is our lucky first recipient [19:26:13] hah, and an email address with so many underscores at the start that it hangs the UI email search, which is interpreting them as wildcards [19:26:30] argh lol [19:26:44] let me see if an activity search works [19:29:07] Wikimedia-Fundraising-Banners: Dual error messages appearing - https://phabricator.wikimedia.org/T241760 (jbolorinos-ctr) [19:29:45] err, maybe my compy is just hanging? gmail won't load either [19:30:23] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jkim - https://phabricator.wikimedia.org/T241761 (Dwisehaupt) [19:30:47] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for lschreibstein - https://phabricator.wikimedia.org/T241762 (Dwisehaupt) [19:30:53] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for spatton - https://phabricator.wikimedia.org/T241763 (Dwisehaupt) [19:31:24] ejegg: process_log should show it? [19:31:39] list even [19:33:02] the process-control log just shows the counts for this job [19:33:06] not very verbose [19:33:54] sorry I meant SHOW PROCESSLIST in mysql but then realised it's not easy to call that [19:33:57] live [19:38:23] there's nothing crazy in processlist bogging down civi - I think it may be on my end [19:40:22] civi is cheerful for me [19:40:49] eileen: can you load the activity search page? [19:42:52] I can load the page - are you failing just on load? [19:47:57] eileen: yeah, it was failing on load [19:48:09] but I got to the donor record via a db query [19:48:19] anyway, I found a thing we need to fix [19:48:39] the year is defaulting to 2012 on batch sends [19:48:46] I'll put a patch up quick [19:50:14] ah, we can just do variable_set wmf_eoy_target_year [19:50:33] but it would be nice to fetch that year from the job table [19:52:08] ok, those variables look good now [19:52:11] will send another [19:58:09] oh dang, we're adding activities to deleted contacts [20:01:03] (PS1) Ejegg: EOY summary: skip activities for deleted contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561690 (https://phabricator.wikimedia.org/T195907) [20:01:15] eileen: that's the way to filter out deleted contacts, right? ^^^ [20:02:22] I think it's contact_id.is_deleted [20:04:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: EOY email send drush task should use year from job table - https://phabricator.wikimedia.org/T241766 (Ejegg) [20:05:57] eileen: I see a lot more instances of contact_is_deleted in the codebase - would that just be the return value? [20:16:33] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ccarter - https://phabricator.wikimedia.org/T241752 (Dwisehaupt) Certificate has been regenerated and sent off to ccarter. Awaiting confirmation of install to push CRL change. [20:18:07] (PS2) Ejegg: EOY summary: skip activities for deleted contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561690 (https://phabricator.wikimedia.org/T195907) [20:18:16] ok, I guess that should do it ^^^ [20:18:25] fr-tech, anyone available to review that? [20:18:52] Fundraising-Backlog, fundraising-tech-ops: Revoke ssl client certificate for mbrent - https://phabricator.wikimedia.org/T241744 (Dwisehaupt) Open→Resolved p:Triage→Normal Certificate has been revoked and CRL change has been pushed. [20:18:59] I'd like to make that fix before I turn on the eoy email send jobs [20:20:03] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for shust - https://phabricator.wikimedia.org/T241158 (Dwisehaupt) Open→Resolved p:Triage→Normal CRL update has been pushed. [frack::puppet::private] 1641206 Reissuing of shust client ssl cert [20:20:44] Fundraising-Backlog, fundraising-tech-ops: Revoke ssl client certificate for mbrent - https://phabricator.wikimedia.org/T241744 (Dwisehaupt) [frack::puppet::private] 9598750 Revoke mbrent ssl client cert [20:27:01] looking at it now ejegg [20:27:12] thanks! [20:30:43] (CR) Cstone: [C: +2] EOY summary: skip activities for deleted contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561690 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [20:30:48] thanks! [20:30:52] np [20:31:12] Looks OK to me too [20:35:12] once that merges I'll cherry-pick it over to deploy [20:35:26] so as not to half-deploy the deduper rename [20:36:50] (Merged) jenkins-bot: EOY summary: skip activities for deleted contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561690 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [20:37:38] (PS1) Ejegg: EOY summary: skip activities for deleted contacts [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561694 (https://phabricator.wikimedia.org/T195907) [20:37:53] (CR) Ejegg: [C: +2] EOY summary: skip activities for deleted contacts [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561694 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [20:43:22] ejegg: the deduper rename that is merged is intended to be safe as is - although I can understand you wanting to not have any complications right now [20:43:33] ah, cool [20:43:48] I figured you would want to deploy it all at once so we could uninstall/reinstall [20:46:54] !lof updated Fundraising CiviCRM from abf0019c44 to f4db7fdb31 [20:48:50] !log updated Fundraising CiviCRM from abf0019c44 to f4db7fdb31 [20:48:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:48:57] that's better [20:51:01] ejegg: yeah I was going to go that way but wound up doing in chunks [20:51:12] with just a rename update line [21:25:58] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for avalkov - https://phabricator.wikimedia.org/T241771 (Dwisehaupt) [21:26:17] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jkumalah - https://phabricator.wikimedia.org/T241772 (Dwisehaupt) [21:26:57] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ccogdill - https://phabricator.wikimedia.org/T241773 (Dwisehaupt) [21:27:14] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for mepps - https://phabricator.wikimedia.org/T241774 (Dwisehaupt) [21:27:32] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for bbarnes - https://phabricator.wikimedia.org/T241775 (Dwisehaupt) [21:27:48] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for dkaufman - https://phabricator.wikimedia.org/T241776 (Dwisehaupt) [21:29:52] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for krobinson - https://phabricator.wikimedia.org/T241777 (Dwisehaupt) [21:30:11] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for kthaney - https://phabricator.wikimedia.org/T241778 (Dwisehaupt) [21:30:31] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for pcoombe - https://phabricator.wikimedia.org/T241779 (Dwisehaupt) [21:30:43] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for dstrine - https://phabricator.wikimedia.org/T241780 (Dwisehaupt) [21:30:58] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for msuijkerbuijk - https://phabricator.wikimedia.org/T241782 (Dwisehaupt) [21:31:13] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rmurthy - https://phabricator.wikimedia.org/T241783 (Dwisehaupt) [21:31:28] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ejohnston - https://phabricator.wikimedia.org/T241785 (Dwisehaupt) [21:31:38] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jadams - https://phabricator.wikimedia.org/T241786 (Dwisehaupt) [21:31:51] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ejegg - https://phabricator.wikimedia.org/T241787 (Dwisehaupt) [21:32:05] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for khaggard - https://phabricator.wikimedia.org/T241788 (Dwisehaupt) [21:32:19] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ppena - https://phabricator.wikimedia.org/T241789 (Dwisehaupt) [21:33:02] sorry about the spam. certificate january fun. :) [21:35:16] (PS1) Ejegg: Remove cancel instructions from EOY email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561699 [21:35:30] fr-tech can someone review that text change? ^^^ [21:35:41] looking [21:35:53] The ideal fix would be to only include that line when the donor has an active recurring donation [21:35:59] but that would be a bit more code. [21:36:05] hmm, maybe not much? [21:36:19] (if we don't want to precompute it, that is) [21:36:38] would kindof break the model that makes the send so lightweight [21:37:16] but I guess we're already doing some per-send queries to write the activities [21:37:33] XenoRyet: hang on a sec, I'mma try the optimized route [21:37:42] and see if I can just make that show for active recurring folks [21:37:51] I was gonna say, this looks good, but I can hold on merging if you want to try a thing. [21:38:43] hmmm, so... the catch is that we have to find those recurring donations by email address, not by contact ID. [21:39:01] Though I guess we could move the contact ID lookup upstream from the activity recording fn [21:39:27] Let me know if the other solution gets squirrely and I can merge this one. [21:40:34] gah, no, I think we do need to go with this one [21:40:55] render_letter is currently working with the raw row from the db [21:41:25] ehhhh [21:41:28] welll [21:41:32] maybe it could take two args [22:03:37] Wikimedia-Fundraising-Banners: Large CC payment button on Safari Mobile 9.0 and earlier - https://phabricator.wikimedia.org/T240730 (jbolorinos-ctr) Between the dates 28 Nov 2019 - 2 Jan 2020, 0.39% of users were using Safari 9.0, as listed here: https://analytics.wikimedia.org/dashboards/browsers/#mobile-si... [22:11:51] (PS1) Ejegg: Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 [22:12:00] XenoRyet: I /think/ that will work ^^^ [22:12:29] eileen: does that look like a sane way to check for currently active recurring donations? ^^^ [22:12:36] Hmm, I guess I should add another test [22:13:03] looking [22:13:54] Wikimedia-Fundraising-Banners: Dual error messages appearing - https://phabricator.wikimedia.org/T241760 (EWilfong_WMF) I consider this a feature rather than a bug :-). Currently the legends are bolded and turned red for an error and then we further explain the actual errors below the continue button. While... [22:18:06] (CR) jerkins-bot: [V: -1] Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 (owner: Ejegg) [22:23:08] ejegg: so looking at our data - we have lots of completed & cancelled recurrings [22:23:19] Some fails [22:23:26] & 7 'In progress' [22:23:43] so that would work but we don't actually have any pendings to pick up [22:24:00] (PS2) Ejegg: Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 [22:25:29] eileen: ooh, are those 'In progress' ones stuck? [22:25:55] Maybe - only 7 [22:29:23] hmm - that test failed for me locally - the activities one - looking [22:30:16] (CR) Eileen: Only show cancel instructions when donation is active (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 (owner: Ejegg) [22:30:18] (CR) jerkins-bot: [V: -1] Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 (owner: Ejegg) [22:32:12] Probably a bit edge at this stage but it might make sense to have one activity with multiple targets rather than one per target [22:33:10] eileen: oh right [22:33:37] well for now I'll just fix that one line [22:34:34] ejegg: it looks otherwise good to me - I haven't checked the templates but I think XenoRyet did [22:34:46] (PS3) Ejegg: Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 [22:34:57] Yea, templates look fine. [22:35:36] (CR) Eileen: [C: +2] Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 (owner: Ejegg) [22:35:45] thanks! [22:40:22] (Abandoned) Ejegg: Remove cancel instructions from EOY email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561699 (owner: Ejegg) [22:41:51] (PS1) Ejegg: Only show cancel instructions when donation is active [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561706 [22:41:53] (Merged) jenkins-bot: Only show cancel instructions when donation is active [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561702 (owner: Ejegg) [22:42:06] (CR) Ejegg: [V: +2 C: +2] Only show cancel instructions when donation is active [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561706 (owner: Ejegg) [22:44:40] !log updated fundraising CiviCRM from f4db7fdb31 to 6936aa0262 [22:44:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:46:37] oh boo [22:46:45] phpmailerException: Invalid address [22:46:51] what did I screw up? [22:48:02] oho, maybe it's actually an invalid address [22:48:40] yep, turns out I hadn't even finished the rsync [22:48:45] so... need more error handling [22:53:05] (PS1) Ejegg: EOY emails: PHPMailer error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561707 [22:53:27] fr-tech looks like we'll need one more fix to get past bad email records ^^^ [22:54:00] and I guess we could tighten up our email validation [22:54:16] the one throwing the error above started with a whole bunch of dots [22:56:35] (CR) Eileen: [C: +2] EOY emails: PHPMailer error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561707 (owner: Ejegg) [22:56:41] thanks! [22:56:48] ejegg: makes sense - did you fix that email? Otherwise I will [22:56:58] not yet [22:57:17] but the way we pre-calculate things means the bad addresses are already in the table [22:58:08] yeah & also - she has donated 3 times with those preceding dots [22:58:34] I guess they are recurrings [22:59:17] (PS1) Ejegg: EOY emails: PHPMailer error handling [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561708 [22:59:36] (CR) Ejegg: [V: +2 C: +2] EOY emails: PHPMailer error handling [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561708 (owner: Ejegg) [23:03:01] (Merged) jenkins-bot: EOY emails: PHPMailer error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561707 (owner: Ejegg) [23:03:02] * bd808 leaves this for consideration -- https://medium.com/hackernoon/the-100-correct-way-to-validate-email-addresses-7c4818f24643 [23:04:40] bd808: lol [23:05:06] I have been deep into the email address validation rat hole. It is not pretty down there. [23:06:31] related: physical address validation, postal address validation, human name validation [23:07:01] none of these systems have "rules" in the same sense that physics and math do [23:07:06] oh man, yeah. we don't really try to validate that other stuff [23:09:12] !log updated Fundraising CiviCRM from 6936aa0262 to d534f4e966 [23:09:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:17:38] dangit, how is that not being caught? [23:17:44] I did deploy, right? [23:18:24] looks like yep [23:18:30] it sure looks like you did [23:19:15] hmm, that catch really should have a space after it [23:19:26] but I would assume a parse error if that was the problem [23:19:29] yeah [23:23:14] grr, failing consistently [23:23:46] you could just catch Exception - I know it's cheating [23:24:13] yeah, I'm feeling like that's the way to go for now [23:24:16] "for now" [23:24:33] :-) [23:25:05] ohhhh, namespace goof [23:25:21] forgot EoySummary is in a namespace [23:25:35] is it - I was looking for that - ah - I was trying to find phpMailer namespac [23:25:37] e [23:27:31] (PS1) Ejegg: Fix namespace of caught exception [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561710 [23:27:38] namespace/whitespace fix ^^^ [23:30:03] eileen / XenoRyet ^^^ is the fix to the fix to the fix [23:31:10] (CR) Eileen: [C: +2] Fix namespace of caught exception [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561710 (owner: Ejegg) [23:31:15] let's hope the fix fix doesn't need a fix [23:31:27] fixception? [23:31:35] :P [23:32:03] (PS1) Ejegg: Fix namespace of caught exception [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561711 [23:32:18] (CR) Ejegg: [V: +2 C: +2] Fix namespace of caught exception [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561711 (owner: Ejegg) [23:33:30] !log updated Fundraising CiviCRM from d534f4e966 to 217a1f8c63 [23:33:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:34:00] yay, 'failed to send 1 messages' [23:34:04] and no crash [23:37:41] (Merged) jenkins-bot: Fix namespace of caught exception [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561710 (owner: Ejegg) [23:38:43] ok, sent one that had an active recurring, and the link got rendered in the footer [23:38:54] (PS4) DannyS712: Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) [23:40:18] (CR) jerkins-bot: [V: -1] Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [23:41:54] Cool cool, got to one whose donation ended in 2019 and the summary email DOES NOT have the link at the bottom [23:42:16] (PS5) DannyS712: Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) [23:45:32] OK, the job is live, just staring with batch size 125 every 15 minutes [23:45:36] *starting [23:45:53] (CR) jerkins-bot: [V: -1] Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [23:45:56] so after a couple hours if everything looks good we can ramp that up