[00:01:00] ok folks, heading AFK for now [00:01:38] MBeat: if you get any crazy feedback about those mails let me know and I can stop the job [00:01:55] otherwise, I'll ramp the batch size up in 3 or 4 hours. [00:02:01] (CR) DannyS712: Remove uses of global $wgUser as a fallback (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [00:02:26] thanks, ejegg|away [00:14:59] Fundraising Dash, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Big English total raised figure and amount per second chart broken after new year UTC - https://phabricator.wikimedia.org/T241665 (Ejegg) Open→Resolved p:Triage→Normal [00:15:41] Fundraising Dash, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: /data should return non-200 status when SQL or filter error exists - https://phabricator.wikimedia.org/T240524 (Ejegg) Open→Resolved [00:15:50] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: EOY summary text-format emails should be automatically generated from HTML - https://phabricator.wikimedia.org/T240298 (Ejegg) Open→Resolved [02:27:16] (CR) Cstone: [C: +2] Log failure reason in orphan slayer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556453 (https://phabricator.wikimedia.org/T239769) (owner: Ejegg) [02:33:43] (Merged) jenkins-bot: Log failure reason in orphan slayer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556453 (https://phabricator.wikimedia.org/T239769) (owner: Ejegg) [05:04:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Drupal core update - https://phabricator.wikimedia.org/T241809 (Eileenmcnaughton) [05:05:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Drupal core update - https://phabricator.wikimedia.org/T241809 (Eileenmcnaughton) [05:05:43] (PS1) Eileen: Drupal core update 7.67 to 7.69 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/561736 (https://phabricator.wikimedia.org/T241809) [05:05:45] (PS1) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/561737 (https://phabricator.wikimedia.org/T241809) [05:06:49] (PS1) Eileen: Drupal modules update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561738 (https://phabricator.wikimedia.org/T241809) [05:08:26] (CR) jerkins-bot: [V: -1] Drupal core update 7.67 to 7.69 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/561736 (https://phabricator.wikimedia.org/T241809) (owner: Eileen) [10:12:49] (CR) Daimona Eaytoy: [C: -1] Remove uses of global $wgUser as a fallback (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [10:23:34] (PS1) Daimona Eaytoy: tests: Don't write to the actual database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 [10:24:10] (PS2) Daimona Eaytoy: tests: Don't write to the actual database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 [10:27:44] (CR) Daimona Eaytoy: [C: -1] "Done at Ie30d84ff5bdcaf64559f16b3452e71e7d1f6429c." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [11:54:51] Wikimedia-Fundraising-Banners: Fix end of year banners so they can be viewed in 2020 - https://phabricator.wikimedia.org/T241828 (Pcoombe) [11:57:16] Wikimedia-Fundraising-Banners: Split out more shared banner javascript - https://phabricator.wikimedia.org/T241829 (Pcoombe) [12:01:44] Wikimedia-Fundraising-Banners: Split out more shared banner javascript - https://phabricator.wikimedia.org/T241829 (spatton) I'm a big fan of this idea. It'll be easier to maintain + easier to test, and I think we'll want to try different hide durations and conditions in 2020. [12:32:13] Wikimedia-Fundraising-Banners: Fix end of year banners so they can be viewed in 2020 - https://phabricator.wikimedia.org/T241828 (spatton) Hey @Pcoombe, I commented out the code from the majority of NYE banners yesterday; I got all the tested ones and many drafts, too. But it did get me thinking about the se... [15:33:32] hi fr-tech! [15:33:47] anyone checking out those new EOY mailer failures? [15:36:56] ah, 'Invalid criteria for IN' [15:37:10] guessing we hit something that's been deleted [15:37:23] or had an email updated since the pre-calculation [15:41:40] oooo just saw those ejegg [15:42:32] OK, I just disabled it [15:42:38] I think it'll be a trivial change [15:46:53] yep, pretty safe to just return FALSE when that array is empty [15:47:09] oh, wikibugs got booted [15:47:22] here's the patch: https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/561879 [15:47:50] fr-tech anyone have a minute for a tiny review? ^^^ [15:48:00] (PS1) Ejegg: Don't crash on changed email address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561879 [16:25:46] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for bbarnes - https://phabricator.wikimedia.org/T241775 (Dwisehaupt) a:Dwisehaupt Heard back from bbarnes and have generated the new certificate. It has been sent via email and password sent via SMS. [16:34:17] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jadams - https://phabricator.wikimedia.org/T241786 (Dwisehaupt) a:Dwisehaupt Heard back from jadams and have generated the new certificate. It has been sent via email and password sent via SMS. [16:39:47] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: FRUEC: Debug minor discrepancy in landing page data between old and new pipelin... - https://phabricator.wikimedia.org/T236835 [16:39:49] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [16:40:08] fr-tech is anyone around? [16:41:02] howdy. [16:41:17] ejegg: I'm here, though I'm not much of a round [16:41:20] hi dwisehaupt ! I was looking for code review on a CRM thing [16:41:37] a round, like a song where several people sing the same melody starting at different times? [16:41:41] I had to turn off sending the EOY thank you summary emails [16:42:00] It's the one linked above, ejegg? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/561879 [16:42:01] Or like the priests in flatland? [16:42:07] yep, that's the one AndyRussG ! [16:42:13] okok lemme seeee [16:43:17] (CR) Dwisehaupt: [C: +1] "php isn't my strong point but this looks good to me." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561879 (owner: Ejegg) [16:43:40] Wikimedia-Fundraising-Banners: Fix end of year banners so they can be viewed in 2020 - https://phabricator.wikimedia.org/T241828 (jbolorinos-ctr) Should we add this to our Code Review meeting to discuss more? [16:43:50] i'll give it a +1 since andy is looking too and php is definitely not my strong point. :) [16:44:49] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jadams - https://phabricator.wikimedia.org/T241786 (Dwisehaupt) Confirmation from jadams that the cert installed and is working as expected. [16:44:49] dwisehaupt: thanks! [16:45:04] thanks both! [16:45:09] I'll be back from volunteering in 10ish mins and can look too if needed [16:45:21] ejegg: will the calling code differentiate at all between say, False and 0 return value? [16:45:40] The code calling that function expects a bool [16:45:58] the return value in the non-empty case is still bool, not the count itself [16:45:59] ejegg: ah right gotcha, sorry missed that [16:46:06] cstone: ejegg: dwisehaupt: also not I'm not able to test the patch [16:46:24] yeah, it's pretty edge-casey [16:46:49] Just looking for an "is it sane" "is it safe" check [16:47:18] ejegg: looks good to me, would you like me to +2 even without smoke testing? [16:47:27] ys pls [16:47:30] okok [16:48:00] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 6 others: Update CiviCRM Contacts Actions to include a new 'Send Annual Thank You Receipt' Action - https://phabricator.wikimedia.org/T238692... [16:48:12] (CR) AndyRussG: [C: +2] "something nice..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561879 (owner: Ejegg) [16:48:23] thank you! [16:48:26] yw! [16:49:03] The comment text box in the new Gerrit interface had a message that said, "Say something nice..." [16:49:11] haha [16:49:58] (PS1) Ejegg: Don't crash on changed email address [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561886 [16:50:05] Sorry, I guess I just miss the kids (they're with their mom for a few days still) so I might be going overboard with the Dad jokes to compensate [16:52:10] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: FRUEC: Detailed comparison of events in old and new log files for banner impres... - https://phabricator.wikimedia.org/T236834 [16:52:12] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [16:52:13] (CR) Ejegg: [V: +2 C: +2] Don't crash on changed email address [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/561886 (owner: Ejegg) [16:53:05] AndyRussG: i think i'm taking care of the kid interactions this week. actually hosting 8 today at our house for a D&D game. [16:54:09] !log updated fundraising CiviCRM from 217a1f8c63 to 5642a92223 [16:54:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:54:31] (Merged) jenkins-bot: Don't crash on changed email address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561879 (owner: Ejegg) [16:55:25] (CR) AndyRussG: Finer geo targeting (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [16:56:41] Wikimedia-Fundraising-Banners: Split out more shared banner javascript - https://phabricator.wikimedia.org/T241829 (jbolorinos-ctr) This one will definitely be discussed in our code review meetings, will add it to the list [16:59:34] ok, --slow-start is not crashing on the EOY mailer now [16:59:41] will turn it back on full blast [17:00:43] and that's back on [17:02:45] so in the end we only lost like 3 1/2 hrs, it'll still finish by monday morning [17:10:15] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for nnichols - https://phabricator.wikimedia.org/T241758 (Dwisehaupt) Certificate has been regenerated and password sent via SMS. [17:16:06] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 6 others: Update CiviCRM Contacts Actions to include a new 'Send Annual Thank You Receipt' Action - https://phabricator.wikimedia.org/T238692... [17:20:48] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for msuijkerbuijk - https://phabricator.wikimedia.org/T241782 (Dwisehaupt) a:Dwisehaupt Certificate regenerated and sent via email. Password sent via SMS. [17:35:41] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for avalkov - https://phabricator.wikimedia.org/T241771 (Dwisehaupt) a:Dwisehaupt Heard back from avalkov and have regenerated the certificate. Password sent via SMS. [18:04:10] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ejegg - https://phabricator.wikimedia.org/T241787 (Dwisehaupt) a:Dwisehaupt The certificate has been regenerated and ejegg provided access to the cert and password files. [18:09:54] Wikimedia-Fundraising-Banners: Separate out JS for Mobile banners - https://phabricator.wikimedia.org/T241854 (jbolorinos-ctr) [18:17:14] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for dkaufman - https://phabricator.wikimedia.org/T241776 (Dwisehaupt) a:Dwisehaupt Heard back from dkaufman and I will regenerate his certificate on Monday. [18:18:01] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rmurthy - https://phabricator.wikimedia.org/T241783 (Dwisehaupt) a:Dwisehaupt Heard back from rmurthy and I will regenerate the certificate on Monday. [18:19:52] Wikimedia-Fundraising-Banners: Separate out JS for Desktop Banners - https://phabricator.wikimedia.org/T241855 (jbolorinos-ctr) [18:20:19] Wikimedia-Fundraising-Banners: Separate out JS for Desktop Banners - https://phabricator.wikimedia.org/T241855 (jbolorinos-ctr) [18:20:58] Wikimedia-Fundraising-Banners: Separate out JS for Desktop Banners - https://phabricator.wikimedia.org/T241855 (jbolorinos-ctr) [18:21:38] Wikimedia-Fundraising-Banners: Separate out JS for Desktop Banners - https://phabricator.wikimedia.org/T241855 (jbolorinos-ctr) a:jbolorinos-ctr [18:22:01] Wikimedia-Fundraising-Banners: Separate out JS for Mobile banners - https://phabricator.wikimedia.org/T241854 (jbolorinos-ctr) a:jbolorinos-ctr [18:25:15] Wikimedia-Fundraising-Banners: Separate out JS for iPad/Tablet banners - https://phabricator.wikimedia.org/T241856 (jbolorinos-ctr) [18:29:36] Wikimedia-Fundraising-Banners: Establish naming convention for Mobile UI elements - https://phabricator.wikimedia.org/T241857 (jbolorinos-ctr) [19:26:21] Fundraising-Backlog, FR-Adyen: Update Adyen IPN processing for non-card txns - https://phabricator.wikimedia.org/T241859 (Ejegg) [19:27:29] dstrine: here's an old ticket for creating an Adyen orphan rectifier: https://phabricator.wikimedia.org/T145708 [19:28:21] ohh, complete with comments about why we couldn't build one [19:28:22] ejegg: we're gonna totally slay in 20202 [19:28:58] ejegg: are those notes still accurate? [19:28:59] well, maybe that think Will was talking about adding to results is actually necessary [19:29:07] ok [19:31:21] Fundraising-Backlog, FR-Adyen, Recurring-Donations: Investigate and break down recurring for Adyen - https://phabricator.wikimedia.org/T238101 (DStrine) [19:31:23] Fundraising-Backlog, FR-Adyen, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708 (DStrine) [19:31:42] Fundraising-Backlog, FR-Adyen, Recurring-Donations: Investigate and break down recurring for Adyen - https://phabricator.wikimedia.org/T238101 (DStrine) [19:32:29] ejegg: I'm going to convert this to the Adyen Recurring Epic. We can breakdown tasks as a group during sprint planning https://phabricator.wikimedia.org/T238101 [19:32:30] that IPN ticket was actualy for ideal - I'll change the parent task [19:32:37] oh oops [19:32:38] sorry [19:32:54] Fundraising-Backlog, FR-Adyen: Update Adyen IPN processing for non-card txns - https://phabricator.wikimedia.org/T241859 (Ejegg) [19:32:56] Fundraising-Backlog, FR-Adyen, Recurring-Donations: Investigate and break down recurring for Adyen - https://phabricator.wikimedia.org/T238101 (Ejegg) [19:32:58] Fundraising-Backlog: EPIC: Enable the ability for user to pay with iDeal through Adyen - https://phabricator.wikimedia.org/T231370 (Ejegg) [19:33:10] Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (DStrine) [19:33:58] hmm, are these a problem: "Trying to delete pending message with no order id" [19:34:25] they're WARNING-level, and just coincidentially included in a failmail that has an actual error later [19:35:02] but it makes me wonder if we're failing to zap some things from the pending queue and leaving extra work for the ingenico orphan rectifier [19:35:38] I'm not sure what any of that means [19:35:47] is this something you see in logs? [19:35:51] just looking at a failmail [19:35:58] ok [19:36:16] so everyone that gets sent to a processor gets an entry in the pending table [19:36:43] and when we get some 'final' info about the donation, we delete it (on failure or on success) [19:37:06] the orphan rectifier looks in that table [19:37:20] and anything that hasn't been resolved/deleted after 1/2 hour [19:37:30] is considered an orphan and needs to be investigated [19:37:36] and maybe pushed through [19:38:15] So that error message came from the donations queue consumer, which pulls in info about things that succeeded [19:38:32] dstrine / ejegg can you tell me who's in charge of the maxmind/minfraud account? [19:38:34] and it seems to be saying that for a LOT of those, we're not actually clearing out the pending entry [19:38:49] Jeff_Green: I've got a login that lets me do a lot of things [19:39:03] but we need higher-level assistance to get money into the account [19:39:23] when you have a chance, can you see if you can use it to generate a license key for fetching the free geoip2 databases? [19:39:32] for sure! [19:39:37] cool thx! [19:44:29] ooh, and the damaged table has a whole lot of things from the orphan rectifier [19:44:40] that seem to have been processed like 3 hrs late [19:45:05] oh wait, that's probably because we stopped all the jobs for a few hours while civi was thrashing [19:45:22] yeah, timing seems to be right [20:31:12] ejegg: are refund mismatches typically due to exchange rate differences? [20:31:22] we just got a bunch in failmail [20:32:25] jgleeson some are [20:32:44] yeah, we should quiet those down when they're < a small percent [20:32:46] fr-tech going to run an errand at lunch brb [20:32:55] I think there's an ancient phab for that [20:34:20] oh hey, this turns up: https://phabricator.wikimedia.org/rWFCG813abbb5801e3a23208d8d06773825bb55b81d78 [20:34:34] whatever happened to that? rebased or something? [20:35:31] guess I can resubmit that! [20:37:58] scammed lol [20:38:01] nice [20:51:25] ejegg: the return response for test.adyen is hiting mediawiki.d/.. normally I'd setup a host entry to get around that but with vagrants custom ports it's proving tricky. It is straight for edit that return url on test? if not I could setup a proxy locally to send mediawiki.d traffic to my paymentswiki:4430 I think [20:51:45] straightforward [20:52:08] jgleeson oh oops, that's my local servername [20:52:19] I think it's a setting in the skin on test [20:52:27] which skin codes are you using? [20:52:37] good question [20:52:49] should be in LocalSettings.php [20:54:29] I think I pulled these from our paymentswiki test localsettings, D8rS6es8 / XGn9DpTk / LjCGSSpF [20:54:32] ejegg: ^ [20:57:58] jgleeson ok, let's see what those look like on their test config site [20:58:08] have you logged in there before to make adjustments? [20:58:25] https://ca-test.adyen.com/ca/ca/login.shtml [20:58:38] my lastpass just timed out lemme log back in [21:01:02] ahh, I see - there are two 'normal' versions of the skin - LjCGSSpF for iframe and yPLm0N6v for redirect [21:01:25] ejegg: yep I've logged in here before [21:01:34] although not sure if I've changed anything [21:02:12] those versions have ResultURLs and Continue-to URLs on payments.wiki.local.wmftest.net [21:03:04] then I made some copies for my personal use - D8rS6es8 is a copy of LjCGSSpF and XGn9DpTk is a copy of yPLm0N6v [21:03:13] my versions have that mediawiki.d return URL [21:03:43] so you should change your local setup to use the ones which are configured correctly [21:03:58] and I should update the test settings in the repo not to use my custom codes [21:03:58] so those non-ejegg ones have a return URL which is close but not exactly the same as the vagrant URL for payments wiki [21:04:27] oh weird. Well, it's all testmode, so feel free to fix it [21:04:53] so I can edit those? or should I just create a me/vagrant variant? [21:05:23] ah dang, do we have the HMAC keys written down for those non-ejegg variants? [21:05:31] XenoRyet: you around? [21:05:48] Yea, what's up? [21:06:33] Want to work with jgleeson to get the adyen test skins redirecting to good URLs? [21:07:05] and also update the test credentials on the settings repo? Currently those test credentials point to skins with my custom redirect [21:07:31] I think you have the HMAC codes for the skins with the normal redirect [21:08:26] Sure, let me catch up a bit here. [21:13:21] ejegg: XenoRyet can I just add my own skin for now? and generate my own HMAC secret? [21:13:35] Yea, that'll work for now. [21:13:52] I do have the other HMAC keys around here somewhere too. [21:14:43] jgleeson argh, I'd rather we don't! [21:15:11] actually maybe it would be even easier just to update the return URLs on the existing test skins temporarily and then revert them back when I'm done testing? [21:15:27] let's set the redirects for the base skins to the vagrant ones [21:15:31] ^^ [21:15:37] Actually maybe I don't have those keys... [21:15:57] so the keys are on the skins page [21:15:58] I think [21:16:14] jgleeson let me see if I have them [21:16:21] oooo they're invisible [21:16:24] I see the problem [21:16:26] the page just lets you regenerate [21:16:35] anyway I think I can just edit the return URLS [21:16:39] I'll give that a ago? [21:16:44] a go* [21:16:50] (PS1) Ejegg: Only failmail when refund amount is > 2% more than original [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561906 [21:17:00] yea, go for it. [21:18:20] XenoRyet which skincode has name 'redirect' in your wgAdyenGatewayAccountInfo in LocalSettings? [21:19:03] That's the thing, looks like I don't have it configured on my current vagrant box. It's all just test. [21:19:24] LjCGSSpF feels familiar though. [21:19:39] yeah, that's the iframe one [21:19:48] I have the HMAC for that [21:19:53] we just need the redirect one [21:20:01] cstone - how about you? [21:20:26] Yea, I don't have it in the places I thought I did. I'll dig around though, might have an old vagrant box still hanging around. [21:21:21] (CR) Eileen: [C: +2] Only failmail when refund amount is > 2% more than original [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561906 (owner: Ejegg) [21:21:35] thanks eileen! [21:21:46] (CR) Eileen: [C: +2] "A little fraud is OK :-)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561906 (owner: Ejegg) [21:21:48] ejegg: good idea! [21:22:15] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 5 minutes ago with 2 failures. Failed resources (up to 3 shown): Exec[fetch_geoip_database] [21:22:26] heh, looks like it's about 3 years old too: https://phabricator.wikimedia.org/rWFCG813abbb5801e3a23208d8d06773825bb55b81d78 [21:22:38] dunno what happened to the original [21:23:05] I mean amountScammed must be an Adam comment? [21:23:12] totally [21:24:31] eileen: I liked that also :) [21:24:59] What's our adyen account name? I have to reset my pass and apparently I'm getting it wrong. [21:25:37] (answered in otherchan) [21:27:09] RECOVERY - check_puppetrun on frav1002 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [21:27:49] (Merged) jenkins-bot: Only failmail when refund amount is > 2% more than original [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/561906 (owner: Ejegg) [21:28:09] hmmm fr-tech why do we have live URLs in the test skin live return urks? [21:28:12] urls? [21:28:34] jgleeson oooh right [21:28:53] I forgot, you administer the prod stuf from that console too :( [21:28:53] I need to change the clean skin to breakout but I noticed the live URL is very live [21:28:59] WHAT!! [21:29:07] yeah, don't touch the live URL please [21:29:11] just the test one [21:29:31] ok luckily I didn't touch anything [21:29:45] although I was about to edit the 'clean' skin to pop out into a new window [21:29:58] as I don't have the HMAC for the ones that alreadt do [21:30:02] already do* [21:30:12] actually ejegg I could hijack your one temporarily [21:30:14] jgleeson: wait, let's not mess with that part [21:30:22] yeah, hijack that one if you need to [21:30:51] ok that feels safest [21:38:24] worked! [21:39:53] great! [21:46:33] hey I'm back (and have silence!!!) [21:46:49] hi cstone! [21:57:12] fundraising-tech-ops: modify geoip_update script for new geolite2 licensing scheme - https://phabricator.wikimedia.org/T241864 (Jgreen) [21:57:12] So we're trying to sort out credentials for the test skins on Adyen [21:57:22] ejegg: I've renamed one of your skins by appending 'vagrant-tmp' to the end of it for now as I'll likely be using it tomorrow. Once I've finished I'll switch it back to the previous urls you were using which I've captured here https://etherpad.wikimedia.org/p/adyen-ideal-testing [21:57:47] thanks jgleeson! [21:57:55] fundraising-tech-ops: modify geoip_update script for new geolite2 licensing scheme - https://phabricator.wikimedia.org/T241864 (Jgreen) Note we also need to update our web proxy for the new domain name and URL. [21:58:28] cstone there are two base skins - LjCGSSpF for iframe and yPLm0N6v for redirect [21:58:46] and then I made a copy of each for my personal use [21:59:16] In your 20-DI-accountsettings.php (I think that's the filename) [21:59:26] do you have the HMAC codes for the base one? [21:59:36] If nobody has that code, we can just regenerate [21:59:51] I just wanted to avoid breaking it for whoever currently has it working [22:00:03] err, that's the SharedSecret for yPLm0N6v [22:00:09] we have it for LjCGSSpF [22:00:35] anyway, if you have it, could you update the test settings file in the settings repo please? [22:01:05] fundraising-tech-ops: modify geoip_update script for new geolite2 licensing scheme - https://phabricator.wikimedia.org/T241864 (Jgreen) Open→Resolved Modifications are done and working in virtualbox with my personal maxmind account. I deployed the changes to the cluster without a license key, and the... [22:01:54] ejegg: do you mean the puppet generated DI config file [22:02:08] settings.d/wikis/paymentswiki/settings.d/puppet-managed/10-DonationInterface.php [22:02:16] jgleeson there's one that's puppet generated [22:02:23] if so that gets overwritten [22:02:25] and another one with the settings we have to keep private [22:02:28] ah [22:02:35] with a 20- prefix [22:02:42] and in a different folder, i think [22:03:03] lemme fire up vagrant to check [22:04:33] I put all my DI config in the root LocalSettings.php [22:04:44] oh, and that one doesn't get overwritten? [22:05:35] I don't think so but now you've got me questioning my confidence in that [22:06:02] I remember putting stuff in the other file and losing it so I then I started putting stuff in LocalSettings [22:06:15] ejegg I don't have the HMAC codes [22:06:37] cstone: OK, so we can just regenerate them [22:06:50] looks like the recommended place for the account info is here: settings.d/wikis/paymentswiki/settings.d/20-DI-test-accounts.php [22:09:26] ejegg: yeah I don't think /LocalSettings gets touched [22:09:51] * To customize your MediaWiki instance, you may change the content of this [22:09:53] * file. See settings.d/README for an alternate way of managing small snippets [22:09:55] * of configuration data, such as extension invocations. [22:10:42] hmm yeah looks like I should add them to a 20-* file https://www.mediawiki.org/wiki/MediaWiki-Vagrant#MediaWiki_settings [22:11:29] ok I need to get carpet cleaning! [22:11:32] thanks for all the info [22:11:38] have a good weekend all [22:11:40] o/ [22:28:06] fundraising-tech-ops: modify geoip_update script for new geolite2 licensing scheme - https://phabricator.wikimedia.org/T241864 (Ejegg) I'm on the signup page and there's this bit in the EULA: > > Subject to the terms and conditions of this Agreement, to the extent the Services contain any copyrightable el... [22:38:41] gotta go put the little one down for her nap, back in a bit.