[00:00:31] <wikibugs>	 Wikimedia-Fundraising-Banners: Misplaced Currency Symbol on Desktop Large - Nag banner in Hebrew - https://phabricator.wikimedia.org/T242395 (jbolorinos-ctr)
[00:07:51] <wikibugs>	 Wikimedia-Fundraising-Banners: Legal Text does not align right to left on Desktop Large Banner - https://phabricator.wikimedia.org/T242391 (jbolorinos-ctr) p:Triage→Low
[00:10:29] <wikibugs>	 Wikimedia-Fundraising-Banners: Legal Text does not align right to left on Desktop Large Banner - https://phabricator.wikimedia.org/T242391 (jbolorinos-ctr) p:Low→Lowest
[00:13:45] <wikibugs>	 Wikimedia-Fundraising-Banners: frb-greeting does not align right to left on Desktop Large - https://phabricator.wikimedia.org/T242388 (jbolorinos-ctr)
[00:18:15] <wikibugs>	 Wikimedia-Fundraising-Banners: Error messages not appearing on Mobile Large form in Hebrew - https://phabricator.wikimedia.org/T242396 (jbolorinos-ctr)
[14:46:19] <wikibugs>	 Fundraising Sprint A 2020, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Campaign fallen back to gets incorrect status code and may be incorrectly hidden - https://phabricator.wikimedia.org/T240802 (AndyRussG) >>! In T240802#5790095, @mepps wrot...
[16:06:31] <ejegg>	 hi fr-tech!
[16:13:03] <AndyRussG>	 ejegg: helllooooooooooooooooo
[16:13:54] <jgleeson>	 hey ejegg AndyRussG :)
[16:14:07] <jgleeson>	 just gotta take roxy's mum the train station, back soon!
[16:30:29] <wikibugs>	 (CR) Ejegg: [C: +2] "It ain't the most beautiful thing I've seen today, but it works!" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/563024 (https://phabricator.wikimedia.org/T235450) (owner: Eileen)
[16:36:19] <wikibugs>	 (Merged) jenkins-bot: Check field to carry over custom data by default when none is in the other contact's field [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/563024 (https://phabricator.wikimedia.org/T235450) (owner: Eileen)
[16:42:18] <jgleeson>	 fr-tech so I managed to get adyen to send standard notifications to my vagrant box using the ngrok service. Turns out you can point http public endpoints at https local so the free version works ok for that. It also looks like adyen doesn't enforce a HTTPS/TLS endpoint as the test requests from the adyen console successful hit my local server and get dropped on the queue. However, that's where
[16:42:20] <jgleeson>	 the party ends as I'm currently not getting IPN notifications back when submitting a test donation and I'm not sure why so currently trying to work that out. It also looks like the adyen test console is a little flakey as I'm finding most enabled settings are lost when clicking save :/
[16:42:36] <ejegg>	 jgleeson cool!
[16:42:50] <ejegg>	 well, the first bit (free ngrok working with local https)
[16:43:03] <jgleeson>	 :)
[16:43:17] <ejegg>	 OK, let's look at the settings
[16:44:16] <jgleeson>	 one stood out
[16:44:20] <jgleeson>	 'Include card info for recurring contract notifications'
[16:44:21] <jgleeson>	 :)
[16:45:35] <jgleeson>	 The bunch that don't seem to save are the 'Test Notifications' options where I think we can enable the different type of IPNs. Enabling anything other than authorized gets lost on save
[16:46:23] <ejegg>	 ok, I can curl that URL and it works
[16:46:35] <ejegg>	 gonna send another test and see what shows up
[16:46:39] <ejegg>	 in the console
[16:46:41] <jgleeson>	 oh wait
[16:47:01] <jgleeson>	 I DO have an a new message in the queue for one of my local donations
[16:47:07] <jgleeson>	 it must have came in when I was afk
[16:47:36] <ejegg>	 OH, nice!
[16:47:44] <jgleeson>	 "SmashPig\\\\PaymentProviders\\\\Adyen\\\\Jobs\\\\ProcessCaptureRequestJob
[16:47:48] <jgleeson>	 yep looks like the one we want
[16:48:19] <ejegg>	 Ahh, I wonder if they just run their notifier on a less frequent basis for the test site?
[16:48:38] <ejegg>	 well, good news all around
[16:48:44] <jgleeson>	 I've currently got my smashpig crons turned off so I can run the QueueJobRunner under debug and see what it does
[16:49:14] <jgleeson>	 I noticed the test messages when checking out the standard notifications test run were being sucked away from the jobrunner
[16:49:36] <jgleeson>	 and all dropped in delete pending job jobs which I guess was due to the bogus test data being send over by adyen
[16:49:59] <jgleeson>	 ejegg: yeah the less frequent cycle would make sense
[16:50:29] <jgleeson>	 sadly ngrok doesn't give me timestamp data on requests to my exposed endpoint, only the files loaded
[16:50:43] <jgleeson>	 so I see stuff like this POST /adyen                    200 OK
[16:50:45] <jgleeson>	 POST /adyen                    200 OK
[16:50:47] <jgleeson>	 POST /adyen                    200 OK
[16:50:49] <jgleeson>	 POST /adyen                    200 OK
[16:50:51] <jgleeson>	 GET  /adyen                    500 Internal Service Error
[16:51:07] <jgleeson>	 but I guess this means we can do the end to end test
[16:53:17] <ejegg>	 great!
[16:53:42] <jgleeson>	 ejegg: the message on the jobs-adyen queue looks like a normalised message that we generate. I'd be interested to see the raw message sent over from adyen prior to us normalising it to see if we get any useful new info since enabling the 'Include card info for recurring contract notifications' option. Is that message saved anywhere currently?
[16:54:17] <ejegg>	 jgleeson I don't think so, but let's look at the code
[16:54:25] <ejegg>	 maybe we just need to turn on debug logging
[16:58:11] <ejegg>	 looks like it should actually be logged at info level: $tl->info( $soapData );
[16:58:26] <ejegg>	 (in SoapListener.php, execute)
[17:02:31] <ejegg>	 jgleeson do you see anything in syslog?
[17:04:51] <jgleeson>	 sorry ejegg gotta take tilly the doctors be back soon
[17:05:02] <ejegg>	 ok, hope everything's alright!
[17:19:29] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for kthaney - https://phabricator.wikimedia.org/T241778 (Dwisehaupt) a:Dwisehaupt Certificate regenerated and sent via email. Password sent via SMS.
[17:22:41] <jgleeson>	 back ejegg, yep everything fine I just lost track of time and her appointment was in like 5 minutes after I left
[17:22:53] <jgleeson>	 luckily the doctors surgery is on the same road
[17:23:12] <jgleeson>	 so I dropped roxy and the kids off just in time!
[17:25:12] <jgleeson>	 ok ejegg I'll check out syslog
[19:00:29] <jgleeson>	 fr-tech, when I'm  trying to be clear what an acronym stands for should Iadd the expanded version in brackets e.g. IPN (Instant Payment Notifications) or should it be the full description with the acronym next to it in brackets e.g. Instant Payment Notifications (IPN). ಠ_ಠ
[19:01:07] <cstone>	 i like the second way then you can use IPN for the rest of what you're writing?
[19:01:17] <XenoRyet>	 I'd say the second way, but I don't have a real strong preference, both make sense.
[19:01:27] <jgleeson>	 ok thanks I'll go with the second
[19:01:49] <jgleeson>	 I was wondering if that way an official __way__
[19:02:00] <jgleeson>	 if there was***
[19:13:17] <dwisehaupt>	 jgleeson: the standard i've always heard of was the second.
[19:14:17] <jgleeson>	 saving the planet is a form of extremism here in the UK ... https://www.theguardian.com/uk-news/2020/jan/10/xr-extinction-rebellion-listed-extremist-ideology-police-prevent-scheme-guidance
[19:15:10] <XenoRyet>	 Sadly here too, depending on who you ask.
[19:36:19] <ejegg>	 ok, I got that email out to Adyen asking about the reference to use for recurring donations. Does that seem the the right questions to ask?
[19:39:57] <XenoRyet>	 Yea, looks about right to  me.
[19:40:02] <XenoRyet>	 We'll see what they come back with.
[19:54:19] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig: Ingenico transactions not deleted from pending - https://phabricator.wikimedia.org/T242452 (Ejegg)
[19:57:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig: Ingenico transactions not deleted from pending - https://phabricator.wikimedia.org/T242452 (Ejegg) As a fix, the pending database could fall back to invoice_id when order_id is not present.
[19:57:46] <ejegg>	 fr-tech if anyone wants to write a quick bugfix that'll save us on API calls and make the orphan rectifier less laggy, ^^^ is available
[20:01:02] <wikibugs>	 Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Leave GC donations in the limbo queue if API calls fail at result switcher - https://phabricator.wikimedia.org/T111972 (Ejegg) To investigate: is anything like this still happening for Ingenico Connect? The limbo queue is now t...
[20:02:54] <wikibugs>	 (CR) Ejegg: [C: -1] "Let's keep surname at 35 as per email from merchant services" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556079 (owner: Cstone)
[20:15:26] <jgleeson>	 ejegg: looks good to me (the email)
[20:15:38] <jgleeson>	 I think the max length of shopperReference is 100 chars
[20:15:41] <jgleeson>	 I read that somewhere
[20:16:29] <ejegg>	 ah cool, I was searching for it but I couldn't find field restrictions
[20:17:21] <jgleeson>	 yeah I can't find it either now
[20:19:55] <jgleeson>	 fr-tech, I've added a guide on how to set up ngrok locally on vagrant to enable the capturing of Adyen (and I guess other IPN gateways) IPN messages when testing donations https://www.mediawiki.org/w/index.php?title=Fundraising_tech/Testing#Adyen
[20:21:15] <jgleeson>	 feel free to fix/improve/other
[20:21:23] <XenoRyet>	 Awesome, I'll take a look and try it out.
[20:21:59] <cstone>	 thanks jgleeson !
[20:22:38] <jgleeson>	 I'm just gonna add a quick patch to install php-soap on the fundraising role as that's needed for smashpig's payment listeners
[20:23:03] <jgleeson>	 if you dont already have it just run `sudo apt update && sudo apt install php7.2-soap`
[20:26:19] <ejegg>	 thanks!
[20:52:13] <jgleeson>	 have a great weekend fr-tech!
[21:34:39] <wikibugs>	 (CR) Umherirrender: [C: +1] tests: Don't write to the actual database (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 (owner: Daimona Eaytoy)
[22:41:39] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Engage Civi Credential: Pat S. - https://phabricator.wikimedia.org/T242296 (Dwisehaupt) @LeanneS Usually for staff and contractors we need a confirmation from @Lgruwell-WMF to grant access.  As this is an external contracto...