[01:02:07] (PS1) Eileen: Remove api4 from required modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564173 (https://phabricator.wikimedia.org/T242056) [02:39:52] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog: Move queue message docs to mw.o, update - https://phabricator.wikimedia.org/T198733 (Ejegg) a:Ejegg [03:38:43] (PS1) Ejegg: Remove handling for bogus 'anonymous' and 'optout' fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564274 [14:41:18] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) [14:41:20] fundraising-tech-ops: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Jgreen) [14:41:22] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Jgreen) [15:12:31] running errands, back in a bit [15:17:49] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 7 others: Prevent target smart data from being lost on legacy merge screen - https://phabricator.wikimedia.org/T235450 (... [16:33:06] (CR) Ejegg: [C: +2] Remove api4 from required modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564173 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [16:38:47] (Merged) jenkins-bot: Remove api4 from required modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564173 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [17:44:37] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen: Update QueueConsumer to handle recurring adyen tokens - https://phabricator.wikimedia.org/T242673 (jgleeson) Thanks for the heads up @Ejegg. I'll test out the front-end patch with the new token to confirm and then clos... [18:08:42] argh, failmail cascade from paypal [18:08:49] lotsa bad audit lines [18:11:49] woah [18:18:03] thought we already had a ticket to combine multiple bad lines into one email, but I don't see it [18:19:59] i want a way to grep any old webpage straight from Firefox and pipe it to a textfile [18:20:05] without having to curl it [18:20:22] wget :) [18:30:42] heh. grep https://web.site would be pretty cool. [18:39:44] I guess you could do it in JS using regex? [18:39:52] and make it a bookmarklet ejegg [18:40:22] heh, I just saved the page to .html [18:40:33] hmm the writing to txt file might be tricky [18:45:22] (PS5) Jforrester: tests: Don't write to the actual database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 (owner: Daimona Eaytoy) [18:47:09] ejegg: fr-tech, it looks like we can't delete the Standard Notifications profiles on https://ca-test.adyen.com/ ᕙ(⇀‸↼‶)ᕗ [18:47:23] unless I'm missing the option [18:47:53] Yea, I don't see a delete button either, just that you can set them to inactive. [18:48:11] I guess we can just keep the three we have right now, and edit the urls when we need to test. [18:48:39] oh inactive might be what we need [18:48:44] to quiet down the alarming test maikl [18:48:46] mail* [18:49:14] I think that would do it, yea. [18:49:47] it also looks like once you update a profile with a new URL it still shows "This endpoint is not accepting notifications properly" :/ [18:50:10] hmm... [18:51:33] Heh, you just push a donation through? I got a hit on my listener. [18:52:10] yup! [18:54:54] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Papaul) [19:04:08] (CR) Jforrester: [C: +1] tests: Don't write to the actual database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 (owner: Daimona Eaytoy) [19:09:03] ejegg: do you happen to have a TEST version of the ws-username / ws-password which should work with https://pal-test.adyen.com/pal/Payment.wsdl ? I can't find it on frpm1001 or in the adyen test console [19:09:37] ooh, that might be missing [19:10:16] actually I think it's there [19:10:17] let me see, it would be in the smashpig adyen settings on frpm if it existed there [19:10:23] somehow I missed it :O [19:28:19] XenoRyet|brb: got into Adyen, all good, thx again! [19:32:48] jgleeson: following ur instructions I was able to make a test donation on my local vagrant!!! [19:33:07] I got redirected to https://payments.wiki.local.wmftest.net:4430/wiki/Donate-thanks/en?country=US, which I guess is correct [19:36:33] ♪~ ᕕ(ᐛ)ᕗ [19:36:48] :D [19:36:52] that looks good to me AndyRussG :) [19:37:17] yeee! [19:42:47] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 7 others: Prevent target smart data from being lost on legacy merge screen - https://phabricator.wikimedia.org/T235450 (... [19:42:49] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 5 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (Eileenmcnau... [19:43:40] (CR) Umherirrender: [C: +1] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/564338 (owner: Libraryupgrader) [19:47:16] (PS3) Jgleeson: WIP: Add recurring parameters to send to hosted checkout page for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) [19:49:11] (CR) jerkins-bot: [V: -1] WIP: Add recurring parameters to send to hosted checkout page for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) (owner: Jgleeson) [19:52:58] I really need to fix my coding styles by project once and for all [19:53:38] (PS4) Jgleeson: Add recurring parameters to send to hosted checkout page for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) [19:55:03] (CR) Umherirrender: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/564338 (owner: Libraryupgrader) [19:55:23] (CR) jerkins-bot: [V: -1] Add recurring parameters to send to hosted checkout page for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) (owner: Jgleeson) [19:55:59] Fundraising Sprint Trojan Horse Wisperer, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Duplicate donations caused by PayPal's “Final Approval” messaging - https://phabricator.wikimedia.org/T235220 (EMartin) 1.13 . Donor services updates that there is no repeat of this issue. Could this be resolved? [19:56:40] hmmm fr-tech I'm having trouble getting the Adyen recurring tuning patch through CI. I don't understand what's wrong in this jenkins failure output https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_31-php70-docker/832/console any ideas? [19:58:04] Looks like just some failing tests, yea? [19:59:14] ooo I see them now after clicking show details [19:59:16] thanks! [19:59:18] Looks like some data types aren't what's expected, and a few tests need the shopper reference added [19:59:21] oh yeah, just needs the new field [19:59:39] argh I'm not running tests locally before pushing [19:59:46] Yea, dunno why it didn't auto-expand that section, but that's all it is. [20:22:02] fr-tech I think someone stole my endpoint? :P or can I just take the one that says its not working? [20:22:50] Yea, just grab the inactive one. [20:35:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Engage Civi Credential: Pat S. - https://phabricator.wikimedia.org/T242296 (Dwisehaupt) Email auth, trimmed of full names/emails. On Tue, Jan 14, 2020 at 10:01 AM Lisa wrote: Yes, I approve.  On Thu, Jan 9, 2020 at... [20:38:06] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Maintenance script to perform recurring payment capture - https://phabricator.wikimedia.org/T242160 (jgleeson) [20:39:58] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Update Adyen SmashPig code to be able to create recurring donations - https://phabricator.wikimedia.org/T242277 (XenoRyet) a:XenoRyet [20:41:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Engage Civi Credential: Pat S. - https://phabricator.wikimedia.org/T242296 (Dwisehaupt) a:Dwisehaupt Certificate has been created and emailed. Password sent via SMS. [20:50:35] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Recurring-Donations: decide where the recurring logic is going to live - https://phabricator.wikimedia.org/T242161 (Ejegg) We're pretty clear on where everything needs to go. * In DonationInterface, add a couple o... [21:12:17] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Update Adyen SmashPig code to be able to create recurring donations - https://phabricator.wikimedia.org/T242277 (Ejegg) Adding the authorize call can be an opportunity to define the normalizati... [21:13:15] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Papaul) [21:15:21] ooops mepps ejegg I also hung up... Did you want me to also take part in looking over the regional geotargetting thing? [21:15:33] I'm available for that if u like [21:21:41] AndyRussG i think you've been pretty clear on where you think things are at so it's okay if you skip it, but i have a question [21:21:59] how do i add a local site as a project for a campign so that the banner displays? [21:23:06] mepps there's a $wg global for that [21:23:08] lemme see [21:23:17] yeah i found that ejegg [21:23:25] i guess i'm just curious about the wiki naming conventions [21:23:35] so it would be the database name for the local one, I believe [21:23:37] so in my browser the wiki is named "devwiki" but the db is named "wiki" [21:23:42] oh hmm [21:23:57] I think the db takes precedence here [21:24:27] oh, how about $wgSitename ? [21:24:50] mepps: ah ok... k also looking at the config [21:25:15] I have this: [21:25:17] $wgNoticeProjects = array( 'mw' ); [21:25:17] lemme look at the targeting code... [21:25:19] $wgNoticeProject = 'mw'; [21:25:45] ahh yeah, [21:26:03] I see the ChoiceData ResourceLoader module consulting that [21:26:03] mepps: also see https://www.mediawiki.org/wiki/Extension:CentralNotice#Quick_developer_setup [21:26:36] (though the wgCentralNoticeGeoIPBackgroundLookupModule thing is broken, I think ignore that for now) [21:27:19] what's the distinction between project and projects AndyRussG? and is your local wiki named 'mw' or does that mean something specific? [21:29:16] 'projects' is the list of things you can target in the admin UI [21:29:59] 'project' tells centralnotice what the current wiki is called, and is consulted when readers look at any page [21:30:01] mepps: ejegg: yeah, projects is the list of all targetable projects, and it is used by the infrastructure wiki [21:30:11] yes like ejegg says [21:30:23] so 'project' is for the subscribing wiki [21:30:36] so for example english and french wikipedia both have 'project' defined as 'wikipedia' [21:31:13] while english and french wiktionary both have 'project' set to 'wiktionary' [21:31:51] mepps: all the config variables are documented here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/master/README [21:32:43] oh hey, I bet that version requirement is out of date :) [21:32:52] 1.26wmf9 [21:32:55] hrmmm could be! [21:33:03] ah so the project variable defines the name of my wiki's project name? [21:33:11] yep yep [21:33:40] mepps: yes, or if you have two wikis, one to show the banners and another to control the banners, it's the name of the wiki to show the banners, aka the subscribing wiki [21:33:46] but just the name as per CentralNotice [21:33:53] right right [21:33:57] it doesn't have to be the same as any other name used elsewhere [21:36:21] gotcha [21:36:33] now it should be set up right but i'm not seeing any banners :( [21:37:17] you'd have to re-configure the campaign? [21:37:30] yes done [21:37:42] also check in the console, look at mw.centralnotice.data [21:37:45] sorry [21:37:58] mw.centralNotice.data I think [21:38:05] and mw.centralNotice.choiceData [21:38:10] to try to see what's going on [21:38:32] regarding the project vars here is how it's set up on production: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/master/wmf-config/CommonSettings.php#1961 [21:38:39] shall we debug via screenshare? [21:39:46] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Swedish Thank You Email and Subject Line - https://phabricator.wikimedia.org/T241662 (Ejegg) a:CDenes_WMF [21:40:03] and here's the other place it's set in prod: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/master/wmf-config/InitialiseSettings.php#5459 [21:40:11] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Swedish Thank You Email and Subject Line - https://phabricator.wikimedia.org/T241662 (Ejegg) Open→Resolved [21:40:34] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Italian Thank You Email and Subject Line - https://phabricator.wikimedia.org/T241658 (Ejegg) Open→Resolved a:CDenes_WMF [21:40:41] sure ejegg [21:41:00] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Papaul) ` papaul@fasw-c-codfw# show | compare [edit interfaces interface-range disabled] - member ge-0/0/21; - member ge-1/0/21; [edit interfaces interface-r... [21:41:12] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Papaul) [21:51:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: EoY recurring summary email - donation amount format confusing donors - https://phabricator.wikimedia.org/T242799 (MBeat33) [21:54:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: EoY recurring summary email - "Your continuing support" confusing donors who canceled - https://phabricator.wikimedia.org/T242800 (MBeat33) [22:02:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Engage Civi Credential: Pat S. - https://phabricator.wikimedia.org/T242296 (Dwisehaupt) Open→Resolved [22:03:19] (PS5) Jgleeson: Add recurring parameters to send to hosted checkout page for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) [22:04:15] dwisehaupt: Are you and Jeff_Green looking into T241070 by any chance? [22:04:37] Some fr-tech folks were under the impression that had been handed off to ops [22:04:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico: Civi: EoY recurring summary email - exclude canceled recurrings w/only 1 donation (audit file?) - https://phabricator.wikimedia.org/T242801 (MBeat33) [22:04:51] Hmm, I thought some bot would reply with the title and link [22:05:11] hmmm [22:05:25] yeah I remember something like that [22:05:39] (PS1) Eileen: Add json to composer.json [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564793 [22:05:47] https://phabricator.wikimedia.org/T241070 - basically setting up a Labs / Cloud Services box that we can use to pull arbitrary unmerged CentralNotice patches [22:06:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico: Civi: EoY recurring summary email - exclude canceled recurrings w/only 1 donation (audit file?) - https://phabricator.wikimedia.org/T242801 (MBeat33) [22:06:16] and let stakeholders test them before they're merged to master (at which point they can test them on wikipedia beta cluster) [22:06:26] ejegg: i have talked with jeff briefly about it. [22:06:53] (CR) Ejegg: [C: +2] Add json to composer.json [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564793 (owner: Eileen) [22:07:07] i don't have a clear idea of what is needed but would be willing to learn. both from the setting up a labs instance and what's needed for CN. [22:07:24] dwisehaupt: cool! [22:07:40] We have a ticket in the current sprint that would benefit greatly from it [22:07:46] do we have an idea of urgency or timeline? [22:08:18] woooooooo fr-tech, our recurring transactions "just work as is" with the queue consumer :) [22:08:25] adyen recurring transactions* [22:08:27] so let's see: https://wikitech.wikimedia.org/wiki/Help:Accessing_Cloud_VPS_instances [22:08:37] jgleeson: awesome! [22:08:40] right now we're queuing up a set of updates/upgrades and new machine installs. but i'm sure i can adjust to get this moving. [22:08:49] so I'll close off that ticket ejegg [22:08:55] great jgleeson [22:09:29] dwisehaupt: so maybe one of us can do the initial setup and then as time allows ops can help us puppetize various bits? [22:10:33] I might have all the accounts I need to get a bare VM and just clone wiki + extensions [22:12:07] ahh, Cloud VPS vs Toolforge - let's see which is appropriate [22:12:16] https://wikitech.wikimedia.org/wiki/Help:At_a_glance:_Cloud_VPS_and_Toolforge [22:12:48] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen: Update QueueConsumer to handle recurring adyen tokens - https://phabricator.wikimedia.org/T242673 (jgleeson) Yep, it looks like there's no changes needed to the queue consumer side of things which is great! I tested wi... [22:13:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Duplicate name when cloning a banner displays incorrect error message - https://phabricator.wikimedia.org/T242804 (jbolorinos-ctr) [22:13:04] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen: Update QueueConsumer to handle recurring adyen tokens - https://phabricator.wikimedia.org/T242673 (jgleeson) Open→Resolved [22:13:14] yeah. looking at the setup docs, it's not clear to me how you determine who is a 'project admin' [22:13:35] (Merged) jenkins-bot: Add json to composer.json [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564793 (owner: Eileen) [22:13:47] but i'd totally be down for learning and helping to puppetize as best i can. [22:14:20] most likely, we will have to puppetize within the cloud instance and then see how that would transfer to our own puppet infrastructure. [22:18:20] Hmm, so Toolforge seems a bit restricted, though we wouldn't have to manage the OS [22:20:35] ooh, this looks like what we want: https://wikitech.wikimedia.org/wiki/Help:MediaWiki-Vagrant_in_Cloud_VPS [22:27:07] PROBLEM - check_mysql on frdb2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) [22:32:13] PROBLEM - check_mysql on frdb2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) [22:34:46] asking over in #wikimedia-cloud but no answer yet [22:37:13] PROBLEM - check_mysql on frdb2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) [22:38:12] ACKNOWLEDGEMENT - check_mysql on frdb2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) Dwisehaupt mysql down for db cloning. [23:09:18] Fundraising-Backlog: Asterisks in card # field make donors think their number is autofilled - https://phabricator.wikimedia.org/T242809 (MBeat33) [23:11:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (Ejegg) Looks like a cloud VPS project is what we want here, potentially using https://wikitech.wikimedia.org/wiki/Help:MediaWiki-Vagrant... [23:16:06] fr-tech jack was mentioning credentials earlier today for ws-username / ws-password and now I am somehow not finding them [23:17:21] uh oh. private schools are out and the public is out in 15 mins. i better clear out of the library before it gets completely insane. [23:17:24] back in a few. [23:20:09] stampede! [23:31:47] fr-tech I'm going to create a Civi/gitlab repo for the smashpig extension [23:32:01] since so far it only lives in a subdirectory of our crowded crm repo [23:38:22] (CR) Ejegg: "mepps was it just the usual permissions problems deleting stuff from the templates directory? Here's what I see when I uninstall & reinsta" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [23:55:06] (PS1) Eileen: Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 [23:56:37] (CR) XenoRyet: [C: +2] "Looks good, got the right responses back." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) (owner: Jgleeson) [23:58:32] (Merged) jenkins-bot: Add recurring parameters to send to hosted checkout page for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/563240 (https://phabricator.wikimedia.org/T242275) (owner: Jgleeson)