[03:44:17] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 5 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (Eileenmcnau... [04:09:17] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 5 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (Eileenmcnau... [04:14:55] (PS2) Eileen: Set no-thank-you-reason field to NULL for manually entered Donor-Advised-Fund donations who have emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/565175 (https://phabricator.wikimedia.org/T233374) [04:14:57] (PS1) Eileen: Remove hacky-handling I tink we non longer need [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566118 [04:14:59] (PS1) Eileen: Re-run wmf_civicrm_update_7915 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566119 (https://phabricator.wikimedia.org/T232636) [05:09:02] (PS1) Eileen: Try changing core error scope in hope of getting better errors on jenkins [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566121 [05:11:43] (CR) jerkins-bot: [V: -1] Try changing core error scope in hope of getting better errors on jenkins [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566121 (owner: Eileen) [05:19:26] (PS1) Eileen: what's happeningg? [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566122 [05:21:57] (CR) jerkins-bot: [V: -1] what's happeningg? [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566122 (owner: Eileen) [05:25:30] (PS1) Eileen: Reformat code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566124 [05:34:21] (PS1) Eileen: Reduce legacy code patterns in wmf_reports.install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566125 (https://phabricator.wikimedia.org/T242056) [14:38:27] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 2 others: Central Notice message groups are slow to index - https://phabricator.wikimedia.org/T111189 (Nikerabbit) [15:12:00] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Pcoombe) Looks like this is still happening. Is there anything fundraising can do to help with this? I... [15:49:40] Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (DStrine) [16:38:53] hi fr-tech! [16:39:03] ejegg: morning! [16:39:05] hi ejegg! [16:39:10] mepps: hi! [16:39:13] Hello! [16:39:16] hey ejegg fr-tech :) [16:39:20] how's it going? [16:41:27] cstone: jgleeson: hey [16:41:37] fr-tech anyone have experience with NetBeans and XDebug? [16:42:07] I'm stuck... can't seem to get it to work on Eclipse [16:42:17] hmm it's not too bad. Had a bit of a hectic morning with the new house and getting some electrical stuff sorted but good otherwise! How about you ejegg ? [16:42:33] AndyRussG: I have used netbeans with xdebug in the past [16:42:36] what's up? [16:42:51] On Eclipse it seems to connect, XDebug vagrant settings seem fine, but it keeps re-spawning the debug session infinitely [16:42:57] Fundraising-Backlog, fundraising-tech-ops: Staging data refresh - https://phabricator.wikimedia.org/T243255 (Jgreen) p:Triage→Normal a:Jgreen I started a db restore from the 1/20/2020 backup this morning. It should be one toward the end of the day. [16:43:11] oh that's odd [16:43:13] going pretty well jgleeson. Trying to visit all my friends in a short period of time and not get sick in the process! [16:43:13] jgleeson: I just installed NetBeans and am trying to set it up to see if Eclipse was the issue [16:43:44] so far so good... [16:50:12] it's been a long time since I tried with Eclipse AndyRussG but I do remember over the years having to tinker with the IDEs to get them to play nice. A good place to look when things aren't working as expected is the xdebug.log which you have to set as a value in the config but once set it writes out some info to help diagnose issues [16:50:24] I'm just gonna grab oscar from nursery back soon! [16:51:50] fr-tech it would be great to get your thoughts on my response to cstone's end of day email from Thursday. ejegg I made some assumptions about saving stuff to civi based on my understanding but it would be great if others could confirm/correct when you get a window! thanks. back soon! [16:57:50] jgleeson|baksoon: thanks! I am currently trying with netbeans... I do have stuff in the debug log but it doesn't help much :( [17:13:13] PROBLEM - check_redis on frqueue2001 is CRITICAL: CRITICAL: replication_delay is 590 300 - REDIS 3.2.6 on 127.0.0.1:6379 has 1 databases (db0) with 2 keys, up 69 days 37 minutes - replication_delay is 590, memory use is 852.24K (peak 18.52M, 0.05% of max, fragmentation 4.68%) [17:28:13] RECOVERY - check_redis on frqueue2001 is OK: OK: REDIS 3.2.6 on 127.0.0.1:6379 has 1 databases (db0) with 2 keys, up 69 days 52 minutes - replication_delay is 9, memory use is 816.19K (peak 18.52M, 0.05% of max, fragmentation 4.63%) [17:55:48] AndyRussG: ah sorry it's not useful :( is it still doing the same things with netbeans ? [17:58:04] fr-tech I'm gonna put through an end-to-end test of our current WIP patches alongisde the frontend merged patch for adyen. If it works ok I'll push the WIP patches into review. [17:58:49] I made a start on a test but didn't get too far. I ended up taking most of yesterday as a holiday also [17:59:52] I'll follow on with the test I think as a separate patch which should hopefully allow us to push through the stuff we need to do our end-to-end test [18:02:02] fundraising-tech-ops, Operations, ops-eqiad: (ASAP) rack/setup/install frban1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Cmjohnson) [18:02:22] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: OKR 2019-2020 Q3: Support fundraising through maintaining infrastructure for payments and donor data - https://phabricator.wikimedia.org/T243019 (Jgreen) [18:03:02] fundraising-tech-ops, Operations, ops-eqiad: (ASAP) rack/setup/install frban1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Cmjohnson) these are cabled, running into an issue on the switch cfg removing from disabled vlan. connected fasw1-c ge-0/0/0 (eth 1) and fasw2-c ge-1/0/0 (e... [18:04:35] jgleeson: with netbeans it says there's an error connecting with XDebug [18:04:41] or communicating, rather [18:07:14] are you setting the IP of your host machine as the remote IP? [18:07:23] or are you using the remote_connect_back flag [18:07:42] (which picks up the IP from $_SERVER superglobal) [18:07:47] for web requests that is [18:17:14] jgleeson: ip of host machine is the remote ip [18:17:24] and remote_connect_back is off [18:21:45] hmm [18:22:25] AndyRussG: wanna jump on a hangout and see if we can work it out? [18:23:23] jgleeson: AndyRussG if you do that could I tag along too? Trying to understand more about xdebug myeslf [18:23:59] sure! [18:27:03] mepps: do we need to come up with some new OKRs? [18:29:23] fundraising-tech-ops, Operations, ops-eqiad: (ASAP) rack/setup/install frban1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Cmjohnson) [18:30:17] fundraising-tech-ops, Operations, ops-eqiad: (ASAP) rack/setup/install frban1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Cmjohnson) a:Cmjohnson→Jgreen [18:30:52] fundraising-tech-ops, Operations: (ASAP) rack/setup/install frban1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Cmjohnson) [18:33:58] jgleeson: cstone: yeah that'd be great! [18:34:11] thanks! [18:35:50] cool I'll just grab a coffee and jump into our standup channel for today [18:35:52] see you shortly [18:35:56] AndyRussG: cstone ^ [18:36:22] cstone: jgleeson: yeah also I'll grab a bit of foodz, we don't have standup but we can use the sprint planning hangout [18:38:53] oops good point AndyRussG see you in that one! [18:43:06] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Jgreen) [18:44:45] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for dkozlowski - https://phabricator.wikimedia.org/T242295 (Dwisehaupt) a:Dwisehaupt Certificate regenerated and deposited on dev host for dkozlowski. [19:04:05] Can I get a merge on this one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/566125/ - I think jenkins testing is enough without more but I want to see if with it https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/562402/ will pass [19:10:27] (CR) Ejegg: [C: +2] Reformat code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566124 (owner: Eileen) [19:10:37] thanks [19:12:39] (CR) Ejegg: [C: +2] "Oh yeah, that was pretty crufty! Thanks for the cleanup." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566125 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [19:17:28] (Merged) jenkins-bot: Reformat code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566124 (owner: Eileen) [19:17:30] (CR) jerkins-bot: [V: -1] Reduce legacy code patterns in wmf_reports.install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566125 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [19:18:16] (CR) Ejegg: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566125 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [19:24:04] (Merged) jenkins-bot: Reduce legacy code patterns in wmf_reports.install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566125 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [19:25:19] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (owner: Eileen) [19:26:00] (CR) Ejegg: "Hooray for upstreaming! Is the additional bootstrap bit in the .lock file intentional? Are we really using that via composer? I thought th" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [19:29:58] argh it looks like adyen isn't firing the IPN notifications right away [19:30:06] for test donations :/ [19:30:50] I was seeing maybe a 2 minuteish lag sometimes? [19:31:21] ooo it's actually a mistake by me, I missed off the /adyen route [19:32:25] yep! working now [19:32:36] although I now have 44 messages in the adyen-jobs queue [19:32:42] @_@ [19:33:54] haha oh no [19:40:13] (CR) Eileen: "@ejegg I think the bootstrap part came in as a dependency of 'something'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [19:44:16] ejegg: after this patch https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/564808/ - most of the rest in that queue are really trivial reformattings & such lick [19:46:30] Can anyone else look at this - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/562402/ - my issue is that I can only see part of the jenkins log - even when I choose full log. Just wondering if the page runs better for other people [19:46:33] (CR) Ejegg: "huh, if i try 'composer why twbs/bootstrap' I get "Could not find package twbs/bootstrap in project"" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [19:47:10] (CR) Eileen: "odd - I'll try again - I didn't know about composer why - cool" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [19:48:46] oh - jenkins log is there now [19:49:17] eileen it looks like the new 'is_template' field is at least part of the issue - not expected in some of the contribution comparisons [19:49:29] Ah - makes sense - that should be easy [19:53:31] ejegg: I ran this again ```composer update mrmarkfrench/silverpop-php-connector``` & it added bootstrap again [19:54:04] oh, I bet I need to composer install before composer why [19:57:05] so weird, I see no reason it should install bootstrap [19:57:36] not needed for guzzle [20:02:18] hmm - does it do something differernt for you if you run the above? [20:03:24] ah - let me try no-dev wikimedia/fundraising-crm dev-composer requires twbs/bootstrap (4.4.1) [20:04:27] eileen: if I just grab your composer.json change and do that same composer update [20:04:38] it doesn't add bootstrap [20:04:58] guessing you must have some other update locally that's getting composer-merged in [20:05:25] hmm, the 5.22 cut doesn't show bootstrap in the composer.json file but maybe that's it? [20:10:20] Fundraising-Backlog, MediaWiki-Vagrant: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (jgleeson) Resolved→Open [20:12:25] Fundraising-Backlog, MediaWiki-Vagrant: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (jgleeson) This tripped us up again today. Looks like we need to upgrade the apt.wikimedia xdebug package inline with the latest version of PHP in same repo. [20:13:03] oho, it was the xdebug package giving you trouble AndyRussG ? [20:14:29] ejegg: yep.... all updated and fixed now! [20:14:43] many thanks again jgleeson ^ :) [20:15:42] (PS6) Jgleeson: Update Adyen SmashPig code to be able to create recurring donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565131 (https://phabricator.wikimedia.org/T242277) [20:15:44] (PS8) Jgleeson: Add script to test our our Adyen recurring payment capturing. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565059 [20:16:01] (CR) Jgleeson: "How To Test:" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565059 (owner: Jgleeson) [20:16:54] np AndyRussG. hopefully we can get the latest package in the apt.wikimeda repo [20:19:10] ejegg: can you push up what you get & we'll merge that (& skip figuring it out for now :-) [20:19:13] ccccccknfuvhcntvnfrdlcdeedennibbfinvehttcdnt [20:22:05] k, will do [20:27:00] (PS3) Ejegg: Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [20:27:10] Fundraising-Backlog, FR-Adyen: Disregard Adyen recurring authorization IPNs - https://phabricator.wikimedia.org/T243334 (jgleeson) [20:29:20] (CR) Eileen: [C: +2] Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [20:31:00] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Recurring-Donations, Patch-For-Review: Maintenance script to perform recurring payment capture - https://phabricator.wikimedia.org/T242160 (jgleeson) A side-effect of this test script is that we get back an aut... [20:32:16] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 3 others: Follow up with DS to determine if silverpop contact's were likely privacy delet... - https://phabricator.wikimedia.org/T239375 [20:32:21] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 3 others: Fix missing email recipient data - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) [20:33:35] (CR) jerkins-bot: [V: -1] Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [20:40:34] (PS4) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/564062 (https://phabricator.wikimedia.org/T240802) [20:43:29] (PS1) Eileen: [Test fix] add is_template to ignored list to smooth upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566355 (https://phabricator.wikimedia.org/T242056) [20:43:34] (PS5) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/564062 (https://phabricator.wikimedia.org/T240802) [20:47:40] (PS4) Eileen: Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 [20:53:01] (PS5) Ejegg: Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [20:54:01] oops eileen I didn't see your PS4 there [20:54:18] lol - you tried the same thing :-) [20:54:36] Can you OK this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/566355/ so I can retry tests [20:54:47] (CR) Ejegg: [C: +2] Vendor update on silverpopConnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564807 (owner: Eileen) [20:56:08] ejegg: did we lose composer update wikimedia/omnimail-silverpop [20:56:15] (which was my update) [20:56:29] (although I hacked composer.json due to bootstrap issue) [20:56:36] eileen PS5 did the same thing [20:56:44] cool [21:05:27] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Fix tests and code to make Geotargeting pass CI - https://phabricator.wikimedia.org/T243013 (mepps) [21:05:44] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Fix tests and code to make Geotargeting pass CI - https://phabricator.wikimedia.org/T243013 (mepps) [21:06:15] Fundraising-Backlog, FR-Adyen: edit an internal adyen recurring donation to test it - https://phabricator.wikimedia.org/T243338 (DStrine) [21:13:32] Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Eileenmcnaughton) checked out https://gerrit.wikimedia.org/r/553059 & https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/552057/ onto staging [21:13:54] Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize createPayment responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T243340 (Ejegg) [21:16:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Engage seeing warning message when editing in Civi. - https://phabricator.wikimedia.org/T176371 (Eileenmcnaughton) @leannes I feel we can close this..... [21:17:43] Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (DStrine) [21:18:37] Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (DStrine) [21:24:54] (CR) AndyRussG: [C: +2] "Yay!!!! Thanks!!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/564062 (https://phabricator.wikimedia.org/T240802) (owner: Mepps) [21:27:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Readers-Web-Backlog, MinervaNeue (Tracking), Performance-Team (Radar): Safari crashes on some click handling events for banners that move the centralNotice element outside of the the main body - https://phabricator.wikimedia.org/T242895 (... [21:28:09] (Merged) jenkins-bot: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/564062 (https://phabricator.wikimedia.org/T240802) (owner: Mepps) [21:29:12] Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize createPayment responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T243340 (DStrine) [21:29:14] Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen: edit an internal adyen recurring donation to test it - https://phabricator.wikimedia.org/T243338 (DStrine) [21:29:17] Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen: Disregard Adyen recurring authorization IPNs - https://phabricator.wikimedia.org/T243334 (DStrine) [21:29:29] Fundraising Sprint B 2020, Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (DStrine) [21:29:31] Fundraising Sprint B 2020, Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (DStrine) [21:29:33] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising Sprint Visual Basic Instinct, and 5 others: Break down geotargeting work into next steps - https://phabricator.wikimedia.org/T243014 (DStrine) [21:29:38] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen, and 2 others: Update Adyen SmashPig code to be able to create recurring donations - https://phabricator.wikimedia.org/T242277 (DStrine) [21:29:45] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen, and 3 others: Add recurring parameters to send to hosted checkout page - https://phabricator.wikimedia.org/T242275 (DStrine) [21:29:49] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen, Recurring-Donations: decide where the recurring logic is going to live - https://phabricator.wikimedia.org/T242161 (DStrine) [21:29:53] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog, FR-Adyen, and 2 others: Maintenance script to perform recurring payment capture - https://phabricator.wikimedia.org/T242160 (DStrine) [21:30:01] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising Sprint Usual Subscripts, and 5 others: Create UI for DS to add new resolvable names - https://phabricator.wikimedia.org/T242159 (DStrine) [21:30:03] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upgrade CiviCRM to current version now BE is over - https://phabricator.wikimedia.org/T242056 (DStrine) [21:30:05] Fundraising Sprint B 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (DStrine) [21:30:07] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (DStrine) [21:30:12] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, and 2 others: Campaign fallen back to gets incorrect status code and may be incorrectly hidden - https://phabricator.wikimedia.org/T240802 (DStrine) [21:30:19] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising Sprint Visual Basic Instinct, and 4 others: Fix missing email recipient data - https://phabricator.wikimedia.org/T236855 (DStrine) [21:30:25] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising Sprint Usual Subscripts, and 5 others: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (DStrine) [21:30:34] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising Sprint Trojan Horse Wisperer, and 6 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (DStrine) [21:30:36] Fundraising Sprint B 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (DStrine) [21:30:40] Fundraising Sprint B 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (DStrine) [21:30:42] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint B 2020, Fundraising-Backlog: Move queue message docs to mw.o, update - https://phabricator.wikimedia.org/T198733 (DStrine) [21:30:44] Fundraising Sprint B 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: upstream creditnote_id fix - https://phabricator.wikimedia.org/T194313 (DStrine) [21:32:28] Fundraising-Backlog, fundraising-tech-ops: Audit mysql grants and ensure the grant scripts reflect the current reality - https://phabricator.wikimedia.org/T243342 (Dwisehaupt) [21:50:22] Can I get a +2 on this so I can retry upgrade tests https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/566355/ [21:52:46] (PS9) Jgleeson: Add script to test our Adyen recurring payment capturing. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565059 [22:07:19] (Abandoned) Eileen: Brain dump of where I see things going in future [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/547712 (owner: Eileen) [22:08:31] (CR) Eileen: [C: +2] Use base-class cleanup code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560420 (owner: Ejegg) [22:11:59] sure eileen, looking now [22:12:16] (PS2) Ejegg: [Test fix] add is_template to ignored list to smooth upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566355 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [22:12:21] (CR) Ejegg: [C: +2] [Test fix] add is_template to ignored list to smooth upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566355 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [22:14:01] (Merged) jenkins-bot: Use base-class cleanup code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/560420 (owner: Ejegg) [22:17:48] (Merged) jenkins-bot: [Test fix] add is_template to ignored list to smooth upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566355 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [22:22:38] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [22:23:50] (PS1) Eileen: Code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566371 [22:27:45] (PS1) Eileen: IDE cleanup of test class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566373 [22:35:12] (PS1) Eileen: IDE love - mostly single quotes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566375 [22:38:14] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (owner: Eileen) [22:47:34] (PS3) Ejegg: Add logging to Omnirecipient fetch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564808 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [22:47:46] (CR) Ejegg: [C: +2] Add logging to Omnirecipient fetch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564808 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [22:50:16] (PS2) Ejegg: I've finally found the bug - let's start by making the function non-static [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564822 (owner: Eileen) [22:50:39] (CR) Ejegg: [C: +2] "Looks nicer matching the other timestamp fn" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564822 (owner: Eileen) [22:51:14] Man I'm losing it trying to view jenkins output - it keeps cutting off & then crashing my browser [22:51:54] ok - if I wait long enough.... [22:52:10] (PS2) Ejegg: Code reformatting - array style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564823 (owner: Eileen) [22:52:29] (CR) Ejegg: [C: +2] Code reformatting - array style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564823 (owner: Eileen) [22:54:08] (Merged) jenkins-bot: Add logging to Omnirecipient fetch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564808 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [22:55:00] (PS2) Ejegg: Reformat arrays in test classes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564837 (owner: Eileen) [22:55:00] (CR) Ejegg: [C: +2] Reformat arrays in test classes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564837 (owner: Eileen) [22:56:56] (Merged) jenkins-bot: I've finally found the bug - let's start by making the function non-static [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564822 (owner: Eileen) [22:57:17] (PS5) Eileen: Add check to see what contact cruft we are leaving behind [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 [22:57:19] (PS1) Eileen: Fix cleanup on opt-in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566377 [22:57:28] (PS3) Ejegg: Code cleanup, use helper fn in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564827 (owner: Eileen) [22:57:51] (CR) Ejegg: [C: +2] "Here's to reliability-checking your test setup!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564827 (owner: Eileen) [22:57:58] (Merged) jenkins-bot: Code reformatting - array style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564823 (owner: Eileen) [22:58:58] (PS2) Eileen: Show phpstorm some love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564838 [22:59:20] (PS3) Eileen: Move cleanup to tear down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564839 [22:59:29] Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (MBeat33) [22:59:32] (CR) Ejegg: [C: +2] "Great success!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564838 (owner: Eileen) [22:59:34] (PS3) Eileen: Move truncating of omnimail_job_progress to parent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564840 [22:59:46] (PS3) Eileen: Force setting of omnimail_job_default_time_interval in GroupMember test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564841 [22:59:55] (PS5) Eileen: Fix bug where stretches of time were not being skipped [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564828 (https://phabricator.wikimedia.org/T236855) [23:00:10] Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (MBeat33) p:Triage→Unbreak! [23:00:28] (Merged) jenkins-bot: Reformat arrays in test classes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564837 (owner: Eileen) [23:02:56] (CR) Ejegg: [C: +2] "Yep, that's a better place for it. I guess future fixes can move the rest of those cleanupGroup calls?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564839 (owner: Eileen) [23:03:17] (Merged) jenkins-bot: Code cleanup, use helper fn in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564827 (owner: Eileen) [23:03:52] (CR) jerkins-bot: [V: -1] Add check to see what contact cruft we are leaving behind [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [23:05:28] (CR) Ejegg: [C: +2] Move truncating of omnimail_job_progress to parent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564840 (owner: Eileen) [23:05:53] (Merged) jenkins-bot: Show phpstorm some love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564838 (owner: Eileen) [23:09:15] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Tsevener) @Pcoombe Odd, we can't repro on our end but I'll dig deeper tomorrow. Do you know which cont... [23:09:47] (Merged) jenkins-bot: Move cleanup to tear down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564839 (owner: Eileen) [23:11:21] (Merged) jenkins-bot: Move truncating of omnimail_job_progress to parent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564840 (owner: Eileen) [23:30:15] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Recurring-Donations: decide where the recurring logic is going to live - https://phabricator.wikimedia.org/T242161 (Ejegg) Open→Resolved a:Ejegg [23:30:18] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, and 2 others: Maintenance script to perform recurring payment capture - https://phabricator.wikimedia.org/T242160 (Ejegg) [23:42:47] Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (MBeat33) [23:45:54] (CR) Ejegg: [C: +2] Force setting of omnimail_job_default_time_interval in GroupMember test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564841 (owner: Eileen) [23:51:33] (Merged) jenkins-bot: Force setting of omnimail_job_default_time_interval in GroupMember test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564841 (owner: Eileen) [23:52:49] Fundraising-Backlog: Estimate the proportion of people who send us complaints vs are affected by an issue - https://phabricator.wikimedia.org/T120722 (MBeat33) I still like this idea. {T243356} had 427 affected donors, from which we received 2 complaints so far, for duplicate donations on the 9th of January....