[00:16:58] (PS1) Eileen: WMF-hack - make contribution_id optional until we update SmashPig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 [00:26:43] Fundraising-Backlog, fundraising-tech-ops: Update mysql grant scripts to allow permanent user deletion - https://phabricator.wikimedia.org/T243091 (Dwisehaupt) @Jgreen Currently this shifted to 'drop user if exists' however this may leave stragglers in the case where a user still exists but we remove acc... [01:03:00] Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (MBeat33) Kris found a third example: cid=8506413 Zendesk 725434 Please let me know when the 429 refunds have been batch refunded. [01:51:14] (PS2) Eileen: Stock CiviCRM 5.22 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) [01:51:16] (PS2) Eileen: WMF-hack - make contribution_id optional until we update SmashPig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 (https://phabricator.wikimedia.org/T242056) [01:57:06] (CR) jerkins-bot: [V: -1] Stock CiviCRM 5.22 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [02:17:54] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Eileenmcnaughton) [02:18:39] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Eileenmcnaughton) As of 5.22 we have this shorter list Already merged to master db7a9600f4 (merged to master upstrea... [02:19:46] (PS3) Eileen: Stock CiviCRM 5.22 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) [02:19:48] (PS3) Eileen: WMF-hack - make contribution_id optional until we update SmashPig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 (https://phabricator.wikimedia.org/T242056) [02:19:50] (PS1) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566400 (https://phabricator.wikimedia.org/T242056) [02:21:19] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (Ejegg) Our project has bee... [02:26:44] (CR) jerkins-bot: [V: -1] Stock CiviCRM 5.22 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [02:28:51] (Abandoned) Eileen: what's happeningg? [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566122 (owner: Eileen) [02:29:10] (Abandoned) Eileen: Try changing core error scope in hope of getting better errors on jenkins [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566121 (owner: Eileen) [02:29:25] (Abandoned) Eileen: hack debug [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535766 (owner: Eileen) [02:29:44] (Abandoned) Eileen: Add target smart to tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/531337 (owner: Eileen) [02:29:52] (Abandoned) Eileen: comment to see if this is tripping [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/531553 (owner: Eileen) [02:40:08] ejegg: on the thank you email - I'm thinking I might add an extension with a send api that calls the module & put the civi ui stuff in there. That means it's in 2 places but over time we would want to migrate to it being in the civi place & it's probably easier to do it that way for now [02:47:53] OK, that sounds smart [04:11:14] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Eileenmcnaughton) a:Eileenmcnaughton @CDenes_WMF let me know if these work OK for you on staging [05:18:22] (PS2) Eileen: Code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566371 [05:18:24] (PS2) Eileen: IDE cleanup of test class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566373 [05:18:26] (PS2) Eileen: IDE love - mostly single quotes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566375 [05:18:28] (PS2) Eileen: Fix cleanup on opt-in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566377 [05:18:30] (PS6) Eileen: Add check to see what contact cruft we are leaving behind [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 [05:18:32] (PS1) Eileen: Add basic thank-you extension, exposing our thank you logic as a civi api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566413 (https://phabricator.wikimedia.org/T227903) [05:18:34] (PS1) Eileen: IDE love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566414 (https://phabricator.wikimedia.org/T227903) [05:22:56] Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (Ejegg) Hi @MBeat33. @AndyRussG (along with @Cstone and @Eileenmcnaughton) exported a file with the problems and ran the batch refund. The file is on the... [05:26:46] (CR) jerkins-bot: [V: -1] Add check to see what contact cruft we are leaving behind [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [05:26:58] (CR) jerkins-bot: [V: -1] Add basic thank-you extension, exposing our thank you logic as a civi api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566413 (https://phabricator.wikimedia.org/T227903) (owner: Eileen) [05:27:17] (CR) jerkins-bot: [V: -1] IDE love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566414 (https://phabricator.wikimedia.org/T227903) (owner: Eileen) [05:28:19] (PS2) Eileen: IDE love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566414 (https://phabricator.wikimedia.org/T227903) [05:28:21] (PS2) Eileen: Add basic thank-you extension, exposing our thank you logic as a civi api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566413 (https://phabricator.wikimedia.org/T227903) [06:33:24] Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (MBeat33) Thanks for the comprehensive and speedy followup, @Ejegg and all. [07:50:26] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: Central Notice message groups are slow to index - https://phabricator.wikimedia.org/T111189 (Nikerabbit) a:Nikerabbit [08:47:05] (PS1) Nikerabbit: Simplify Translate dependency declaration [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/566471 [08:48:11] (CR) jerkins-bot: [V: -1] Simplify Translate dependency declaration [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/566471 (owner: Nikerabbit) [08:50:22] (PS2) Nikerabbit: Simplify Translate dependency declaration [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/566471 [09:08:47] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: Central Notice message groups are slow to index - https://phabricator.wikimedia.org/T111189 (Nikerabbit) Some initial debugging on testwiki: ` Finished e... [09:52:36] (CR) Awight: [C: +2] "Great idea!" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/566471 (owner: Nikerabbit) [10:10:26] (Merged) jenkins-bot: Simplify Translate dependency declaration [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/566471 (owner: Nikerabbit) [13:49:15] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Fix tests and code to make Geotargeting pass CI - https://phabricator.wikimedia.org/T243013 (mepps) [13:49:20] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Visual Basic Instinct, and 5 others: Break down geotargeting work into next steps - https://phabricator.wikimedia.org/T243014 (mepps)... [14:52:25] Fundraising-Backlog, FR-Smashpig: Increase SmashPig PHP minimum version to 7.0 - https://phabricator.wikimedia.org/T243421 (Ejegg) [14:56:56] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: upstream creditnote_id fix - https://phabricator.wikimedia.org/T194313 (Ejegg) There's this: https://github.com/civicrm/civicrm-core/pull/15235 , in which we try to be all clever and actually guarant... [14:58:23] Wikimedia-Fundraising-Banners, Wikimedia-Portals: Run fundraising messages on portal in "Big English" countries - https://phabricator.wikimedia.org/T234467 (Pcoombe) Open→Resolved [14:58:41] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Tsevener) a:Tsevener [15:20:25] (PS1) Mepps: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566538 [15:48:51] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Jgreen) [16:06:23] fr-tech is there anything I should mention for other teams in Scrum of Scrums? [16:06:45] ejegg not that I know of, thx!!! [16:14:07] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (ayounsi) [16:20:04] nothing here ejegg ! [16:24:15] (CR) Addshore: [C: +2] tests: Don't write to the actual database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 (owner: Daimona Eaytoy) [16:27:07] I just completed the All Hands breakout sessions form and really liked the session called Data Party! [16:27:16] liked the session name* [16:27:34] all this data?!?!?! let's have a party! [16:27:44] :> [16:28:39] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, and 2 others: Update Adyen SmashPig code to be able to create recurring donations - https://phabricator.wikimedia.org/T242277 (jgleeson) a:jgleeson [16:32:28] fr-tech, it looks like we didn't pull https://phabricator.wikimedia.org/T242278 (Update civi SmashPig extension to be able to charge Adyen recurring) which I think is a required next step to trigger our recurring jobs for Adyen. I'm gonna pull that into the sprint if that's ok dstrine? [16:32:58] jgleeson sure but remember there's only three days (2.5 really) left to do it! [16:34:58] (Merged) jenkins-bot: tests: Don't write to the actual database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561807 (owner: Daimona Eaytoy) [16:44:42] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (CDenes_WMF) @Eileenmcnaughton Sounds good thank you! Is it okay if I proof/approve one language at a time? Is it possible to push just two files (1 Subject... [16:50:48] jgleeson: let's discuss in standup [16:59:19] mepps: yeah it might be a little tight although the other tickets aren't what I'd call the natural progression to the task but let's discuss in standup. just heading out to get oscar back soon! [17:04:06] fundraising-tech-ops: geoip_update run failing on frav1002 - https://phabricator.wikimedia.org/T243424 (Jgreen) [17:32:10] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (DStrine) [17:37:03] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Create safety check for new Ingenico Connect recurring - https://phabricator.wikimedia.org/T240140 (DStrine) [17:39:02] (Abandoned) Mepps: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566538 (owner: Mepps) [17:44:55] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Create safety check for new Ingenico Connect recurring - https://phabricator.wikimedia.org/T240140 (Cstone) a:Cstone [17:46:12] Fundraising-Backlog, FR-Adyen: edit an internal adyen recurring donation to test it - https://phabricator.wikimedia.org/T243338 (DStrine) [17:49:32] Fundraising-Backlog, FR-Adyen, Recurring-Donations: Update civi SmashPig extension to be able to charge Adyen recurring - https://phabricator.wikimedia.org/T242278 (Ejegg) [17:49:34] Fundraising-Backlog, FR-Adyen: Disregard Adyen recurring authorization IPNs - https://phabricator.wikimedia.org/T243334 (DStrine) [17:50:23] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize createPayment responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T243340 (jgleeson) a:jgleeson [17:57:07] (PS1) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) [18:00:19] (CR) jerkins-bot: [V: -1] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps) [18:13:59] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (Ejegg) @Jgreen and @Dwiseh... [18:32:10] (CR) Ejegg: [C: -1] "This is great! A couple of typos in captions and one stray quote mark in a template that looks to be unused so far." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [18:47:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (DStrine) [18:56:33] Fundraising-Backlog: turn on 3ds 1.0 for ingenico - https://phabricator.wikimedia.org/T243443 (DStrine) [19:00:09] Fundraising-Backlog, FR-dlocal: PAN Verification issue during India Test campaign - https://phabricator.wikimedia.org/T234342 (DStrine) [19:15:37] (CR) Mepps: "recheck" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps) [19:22:50] hmm ejegg AndyRussG ^^ this keeps failing cI, i wonder if there was a recent patch that fixed it? [19:24:53] mepps yep, looks like two of them in fact [19:25:52] one would be https://gerrit.wikimedia.org/r/565693 [19:26:17] dropping that back-compat thing that makes phan scream about a nonexistent fn call [19:26:49] not seeing the other immediately but it would probably just have suppressed that XSS-detection in that one fn [19:26:59] with an @suppress notation in the docblock [19:35:07] mepps: so in a case like that we'll also have to cherry-pick patches needed to make CI work ahead of the fix, for the SWAT deploy [19:35:24] so that the state of wmf_deploy when prod is updated doesn't fail CI [19:36:36] weird, I don't actually see any fix for the supposed XSS found by phan [19:36:45] no suppression, no code changes [19:37:00] maybe master is still failing? [19:37:25] ejegg there's one that looks like it updates the composer packages, could that be it? [19:37:29] (PS5) Ejegg: Schema change for region-level geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/552121 (https://phabricator.wikimedia.org/T226438) [19:37:40] (PS38) Ejegg: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [19:38:11] let's see if ^^^ on master fails with the same error after rebase [19:38:45] AndyRussG: it's this failure that may not actually be fixed yet: https://integration.wikimedia.org/ci/job/mwext-php72-phan-seccheck-docker/30412/console [19:39:27] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Tsevener) @Pcoombe wanted to double-check - what query items are you using to get these numbers? We no... [19:39:51] phan has a progress meter in MB and it goes up to 1577MB. That's... intimidating. [19:41:54] (CR) jerkins-bot: [V: -1] Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [19:42:44] haha, failed because suppressing things that don't need suppressing [19:43:36] but does NOT fail the seccheck [19:44:52] hmmmm [19:47:19] mepps maybe it is one of the dev dependency upgrades then? [19:47:53] (PS6) Ejegg: Schema change for region-level geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/552121 (https://phabricator.wikimedia.org/T226438) [19:47:55] (PS39) Ejegg: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [19:49:46] (PS2) Mepps: build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy) [19:50:16] this one also deals with phan-config: https://gerrit.wikimedia.org/r/562046 [19:52:48] there are three of those build ones actually [19:53:16] (PS4) Eileen: Deduper - Add new ability to save name pairs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) [19:53:34] it looks like the build is working with just this one ejegg: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/557180 [19:53:39] (CR) jerkins-bot: [V: -1] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy) [19:53:53] should i bring in all the build ones? [19:54:28] also should i be cherry-picking these into deployment or git squashing them? [19:54:55] (CR) Eileen: "I've fixed most of those things - inc hopefully stopping duplicates. I think you are saying that the name pair saving is OK but there is a" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [20:01:40] mepps: cherry-pick pls [20:01:59] I don't think I've ever used git squashing here at WMF infact! [20:04:28] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (DStrine) Open→Resolved [20:27:59] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Pcoombe) This is donations with utm_source = app_201912_6C_control and utm_campaign = iOS, so it shoul... [20:52:27] (PS2) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) [20:52:29] (PS1) Mepps: build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 [20:56:37] (CR) jerkins-bot: [V: -1] build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 (owner: Mepps) [20:57:19] (CR) jerkins-bot: [V: -1] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps) [20:58:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM contribution records should link to payment processor consoles - https://phabricator.wikimedia.org/T171543 (MBeat33) p:Low→Normal I am nudging the priority up, as this would be a nice time-saver for Donor Services given the persistent sl... [20:58:51] i've gotta admit tihs is getting a little frustrating [20:59:40] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Jgreen) [21:00:08] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [21:00:10] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: rack/setup/install frlog2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242265 (Jgreen) Open→Resolved [21:00:34] (PS1) Eileen: Add nickname to editable form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 [21:34:58] ejegg: sigh - now staging is all caught up & the name-pair stuff demos just fine there :-) [21:35:37] aww, shoot [21:47:49] one thing I spotted is the nick_name field is already on live but the way afforms work is it's actually in the filesystem so wasn't copied back to staging [21:51:28] so this session caught my eye 'Decapitated Team Breakouts / Co-working & Tech-Mgt F2F mtg' [21:52:54] Whose head gets cut off [21:53:03] Just starting updating staging DB to 5.22 civi [21:56:36] I guess one upside to having no head in a technical meeting would be not being able to overanalyze stuff [22:00:04] better than having no feet I guess [22:07:21] speaking of feet. i'm going to take a little walk to see the waves and focus my head. back in a few. [22:21:40] ejegg: I think I might deploy what has been merged - I think there are actually no patches that change stuff merged but good to get rid of the build up [22:26:05] (CR) Ejegg: "haven't tested yet but quoting looks off" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 (owner: Eileen) [22:27:53] (PS2) Eileen: Add nickname to editable form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 [22:28:22] (PS3) Eileen: Add nickname to editable form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 [22:29:17] (CR) Ejegg: "still very slightly typo-ed" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [22:30:16] eileen sure, nice to not let the undeployed stack get so tall it wobbles [22:30:40] lol - I'll just - re-fix that name-pair one [22:31:39] (CR) Ejegg: [C: +2] "Thanks for this! Let's try to do the corresponding SmashPig extension work just as soon as Adyen recurring works." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [22:35:54] (PS5) Eileen: Deduper - Add new ability to save name pairs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) [22:37:19] ejegg: I fixed those things [22:37:22] (PS6) Ejegg: Deduper - Add new ability to save name pairs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [22:37:33] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [22:37:57] Great! just going to take the followon patch for a quick test drive [22:39:44] ok - on live we've actually made those edits so it's just for less head-pain [22:42:39] Cool, it seems to work for me too! [22:42:52] (PS4) Ejegg: Add nickname to editable form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 (owner: Eileen) [22:43:08] (CR) Ejegg: [C: +2] Add nickname to editable form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 (owner: Eileen) [22:43:10] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566611 [22:43:39] wow - look at all that - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/566611/-1..1 & that's without the last 2 - [22:43:51] (Merged) jenkins-bot: Deduper - Add new ability to save name pairs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/562680 (https://phabricator.wikimedia.org/T242159) (owner: Eileen) [22:44:07] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566611 (owner: Eileen) [22:45:03] eileen so i'm still seeing no merge on contact_a:fname=Eddie, lname=Money contact_b: fname=Edward, lname=Money, nick_name=Eddie [22:45:37] hmm - but with no nick_name it does merge? [22:45:48] right, if I delete the nick name it does merge [22:46:17] at first glance it looks like your logic should handle that [22:47:45] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/566612 [22:48:13] OK - I feel like that's not in scope for what I've attempted so far & we should just log a phab - I'll see if I have a master [22:49:41] (Merged) jenkins-bot: Add nickname to editable form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566599 (owner: Eileen) [22:50:26] hmm - they are only linked by tag https://phabricator.wikimedia.org/T242303 [22:53:25] (CR) Eileen: [C: +2] Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/566612 (owner: Eileen) [22:59:15] (Merged) jenkins-bot: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/566612 (owner: Eileen) [23:10:08] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566611 (owner: Eileen) [23:14:11] !log civicrm revision changed from c74092ad63 to 7595104180, config revision is 74a355670a [23:14:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:19:42] mepps I edited T243012 because it was a duplicate of T243011 and there wasn't anything about the text below the tree selector yet [23:19:43] T243011: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 [23:19:43] T243012: Show selected countries and regions under tree selector - https://phabricator.wikimedia.org/T243012 [23:24:11] (PS1) Eileen: Vendor submodule update, silverpop_connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566619 [23:25:43] (CR) Eileen: [C: +2] Vendor submodule update, silverpop_connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566619 (owner: Eileen) [23:28:20] !log civicrm revision changed from 7595104180 to 036b742316, config revision is 74a355670a [23:28:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:29:20] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566622 [23:29:31] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/566622 (owner: Eileen) [23:31:23] !log civicrm revision changed from 036b742316 to fbd5c35fb0, config revision is 74a355670a [23:31:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log