[00:04:30] <eileen>	 dwisehaupt: I have a problem on live that I need to delete some cache files I don't have permisison on
[01:37:45] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Batch deduping not working in legacy merge ui - error about q - https://phabricator.wikimedia.org/T243474 (Eileenmcnaughton) @MBeat33 fyi -
[04:16:14] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (.Nafees791)
[04:17:43] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (Eileenmcnaughton) erm shouldn't this still be in the sprint - not sure why the tag was removed?
[04:22:49] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (.Nafees791)
[04:25:47] <eileen>	 is phab being hacked?
[04:26:24] <ejegg|away>	 oh man, sure looks like it
[04:26:54] <eileen>	 is there a channel we should ping on?
[04:27:09] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (.Nafees791)
[04:27:54] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (.Nafees791)
[04:29:21] <eileen>	 ejegg: any idea who to ping / which IRC channel?
[04:29:36] <ejegg>	 I'm pinging on releng and security channels
[04:30:43] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 4 others: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (.Nafees791)
[04:31:43] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (.Nafees791)
[04:36:00] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (.Nafees791)
[04:40:39] <ejegg>	 eileen: bd808 just blocked them
[04:40:46] <eileen>	 yay
[04:41:02] <eileen>	 they also have other wiki accounts with some vandalism on them
[04:41:15] <ejegg>	 oho?
[04:41:41] <ejegg>	 if you have other leads, maybe share them in #wikimedia-releng ?
[05:15:03] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Recurring-Donations: Civi: January 2020 Ingenico recurrings processing in duplicate? - https://phabricator.wikimedia.org/T243356 (DannyS712) >>! In T243356#5825365, @Eileenmcnaughton wrote: > erm shouldn't this still be in the spr...
[05:16:04] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Create safety check for new Ingenico Connect recurring - https://phabricator.wikimedia.org/T240140 (DannyS712) a:Cstone
[05:18:30] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, and 3 others: Campaign fallen back to gets incorrect status code and may be incorrectly hidde... - https://phabricator.wikimedia.org/T240802
[05:20:10] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, and 3 others: Add recurring parameters to send to hosted checkout page - https://phabricator.wikimedia.org/T242275 (DannyS712) Declined→Open a:jgleeson
[05:20:12] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (DannyS712)
[05:22:18] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Visual Basic Instinct, and 4 others: Fix missing email recipient data - https://phabricator.wikimedia.org/T236855 (DannyS712)
[05:23:17] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (DannyS712) a:Ejegg
[05:38:29] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Ammarpad)
[05:42:37] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (Ammarpad) Declined→Open p:Lowest→Triage a:Eileenmcnaughton
[05:45:42] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features  - https://phabricator.wikimedia.org/T241070 (Ammarpad) Stalled→Open p:Low→Triage a:Ejegg
[05:45:45] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 4 others: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (Ammarpad)
[05:48:13] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upgrade CiviCRM to current version now BE is over - https://phabricator.wikimedia.org/T242056 (Ammarpad) Stalled→Open p:Normal→Triage a:Eileenmcnaughton
[09:02:08] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen: smui - https://phabricator.wikimedia.org/T242277 (ArielGlenn) Declined→Open p:Low→Triage a:jgleeson
[09:02:10] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (ArielGlenn)
[09:03:15] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen: Update Adyen SmashPig code to be able to create recurring donations - https://phabricator.wikimedia.org/T242277 (ArielGlenn)
[09:06:22] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (ArielGlenn)
[09:06:23] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, and 2 others: tnnh - https://phabricator.wikimedia.org/T242160 (ArielGlenn) Invalid→Open p:Lowest→Triage a:jgleeson
[09:07:31] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, and 2 others: Maintenance script to perform recurring payment capture - https://phabricator.wikimedia.org/T242160 (ArielGlenn)
[09:11:18] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Usual Subscripts, and 5 others: gon - https://phabricator.wikimedia.org/T233374 (ArielGlenn) Resolved→Open a:Eileenmcnaugh...
[09:12:27] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Usual Subscripts, and 5 others: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (ArielGlenn)
[09:17:06] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Trojan Horse Wisperer, and 6 others: fvhs - https://phabricator.wikimedia.org/T232636 (ArielGlenn) Stalled→Open a:Eileenmc...
[09:17:28] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Trojan Horse Wisperer, and 6 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (...
[09:19:27] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: ih - https://phabricator.wikimedia.org/T198733 (ArielGlenn) Invalid→Open a:Ejegg
[09:19:29] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (ArielGlenn)
[09:19:45] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: Move queue message docs to mw.o, update - https://phabricator.wikimedia.org/T198733 (ArielGlenn)
[09:21:37] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: ghj - https://phabricator.wikimedia.org/T243098 (ArielGlenn) Stalled→Open p:High→Triage a:Eileenmcnaughton
[09:21:57] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (ArielGlenn)
[09:24:27] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, Recurring-Donations: ljgyb - https://phabricator.wikimedia.org/T243340 (ArielGlenn) Invalid→Open p:Normal→Triage a:jgleeson
[09:24:29] <wikibugs>	 Fundraising-Backlog, FR-Adyen, Recurring-Donations, Epic: EPIC recurring for Adyen - https://phabricator.wikimedia.org/T238101 (ArielGlenn)
[09:24:46] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize createPayment responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T243340 (ArielGlenn)
[09:26:45] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: ruri - https://phabricator.wikimedia.org/T241688 (ArielGlenn) Declined→Open p:High→Triage
[09:27:04] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Work to reduce smarty cruft on the server  - https://phabricator.wikimedia.org/T241688 (ArielGlenn)
[10:16:03] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: upstream creditnote_id fix - https://phabricator.wikimedia.org/T194313 (Aklapper)
[10:16:53] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Aklapper)
[10:17:26] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (Aklapper)
[10:17:36] <wikibugs>	 Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint Trojan Horse Wisperer, and 6 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (...
[10:19:06] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Create safety check for new Ingenico Connect recurring - https://phabricator.wikimedia.org/T240140 (Aklapper) p:Low→Triage
[10:19:36] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (Aklapper)
[10:19:48] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (Aklapper)
[10:20:01] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upgrade CiviCRM to current version now BE is over - https://phabricator.wikimedia.org/T242056 (Aklapper)
[10:21:03] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Adyen, and 2 others: Update Adyen SmashPig code to be able to create recurring donations - https://phabricator.wikimedia.org/T242277 (Aklapper)
[10:21:25] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Aklapper)
[10:21:38] <wikibugs>	 Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (Aklapper)
[12:55:28] <wikibugs>	 (PS3) Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049)
[12:55:44] <wikibugs>	 (PS2) Daimona Eaytoy: build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 (owner: Mepps)
[12:57:26] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[12:57:35] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 (owner: Mepps)
[13:00:16] <wikibugs>	 (PS1) Daimona Eaytoy: tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726
[13:00:35] <wikibugs>	 (PS4) Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049)
[13:03:29] <wikibugs>	 (CR) jerkins-bot: [V: -1] tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[14:51:14] <wikibugs>	 (PS5) Mepps: build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[14:51:15] <wikibugs>	 (PS3) Mepps: build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598
[14:51:17] <wikibugs>	 (PS3) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802)
[14:51:19] <wikibugs>	 (PS1) Mepps: Move test-only classes to new TestAutoloadClasses declaration [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566748 (https://phabricator.wikimedia.org/T196090)
[14:51:21] <wikibugs>	 (PS1) Mepps: Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749
[14:53:11] <wikibugs>	 (CR) Daimona Eaytoy: "This patch should be force-merged, or PHPUnit is going to fail for the other patches around..." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[14:54:07] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 (owner: Mepps)
[14:54:11] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[14:54:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps)
[14:54:19] <wikibugs>	 (CR) jerkins-bot: [V: -1] Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749 (owner: Mepps)
[14:54:23] <mepps>	 urg now it's all failing
[14:54:32] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move test-only classes to new TestAutoloadClasses declaration [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566748 (https://phabricator.wikimedia.org/T196090) (owner: Mepps)
[14:59:02] <AndyRussG|ish>	 mepps: ouch looks rough there
[14:59:17] <mepps>	 yeah AndyRussG this is frustrating
[14:59:34] <mepps>	 i can't seem to cherry-pick this one commit, and i'm wondering if it would make the build pass (though i don't know)
[15:00:39] <AndyRussG>	 mepps: there is a way to force the commit to be accepted and merged by Gerrit, by clicking +2 Verified
[15:00:47] <AndyRussG>	 and then after that I think there's a merge button
[15:01:00] <mepps>	 AndyRussG should i be concerned about all these failures?
[15:01:27] <AndyRussG>	 well basically not if they're due to lack of updates on those patches for CI
[15:01:40] <mepps>	 for some reason this commit is having weird issues with cherry-pick 14e58e5	
[15:01:48] <mepps>	 and i'm wondering if that would make them pass
[15:01:57] <AndyRussG>	 if you submit a chain of patches, and the last has all the CI stuff and passes CI, then it's definitely ok to force- merge the preceeding ones
[15:02:13] <mepps>	 oh now i see why, it seems to be in there
[15:02:30] <AndyRussG>	 I can take a look
[15:03:00] <mepps>	 right now, all i actually want to add is the campaign fallback one
[15:03:08] <mepps>	 i'm just trying to get all these others in to make ci pass
[15:10:40] <mepps>	 should i just +2 the campaign fallback patch and drop the others?
[15:10:48] <mepps>	 that one is only js
[15:10:54] <mepps>	 AndyRussG
[15:11:09] <AndyRussG>	 one sec, looking!
[15:11:15] <AndyRussG>	 mepps: ^
[15:11:20] <mepps>	 hey fr-tech the hacker changed out column names
[15:11:36] <mepps>	 i'm not sure i know how to change them back
[15:12:09] <AndyRussG>	 damn
[15:12:45] <ejegg>	 oh boy
[15:26:08] <AndyRussG>	 mepps: so at the end of the Gerrit chain, this is the error I see still in CI, on both the js patch and the preceeding one: PHP Fatal error:  Declaration of BannerTest::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void in /workspace/src/extensions/CentralNotice/tests/phpunit/BannerTest.php on line 182
[15:27:47] <AndyRussG>	 mepps: it looks like that one is fixed here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/561807
[15:27:51] <ejegg>	 ah, so that should have changed with the 'Updating dependencies' one?
[15:28:13] <AndyRussG>	 ejegg: which is the "updating dependencies" one?
[15:28:25] <ejegg>	 oh i see
[15:28:31] <mepps>	 weird AndyRussG that patch wasn't actually in the original merge patch
[15:28:34] <mepps>	 (that was passing)
[15:28:51] <ejegg>	 i figured the incompatibility was due to an update in phpunit
[15:29:03] <mepps>	 i guess it only just got merged, strange
[15:32:14] <AndyRussG>	 mepps: ejegg: also weird, the command I use to see differences between master and wmf_deploy doesn't show it (git log wmf_deploy..master --pretty=format:"%h%x09%s")
[15:33:19] <mepps>	 weirdly wmf_deploy is still failing ci with the cherry-pick https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/566726
[15:33:39] <mepps>	 i guess it's a different failure at least
[15:34:04] <AndyRussG>	 mepps: yeah I think that's 'cause of the lack of the other patches that updated stuff
[15:34:15] <mepps>	 AndyRussG have you pulled the latest master?
[15:34:21] <AndyRussG>	 YEP
[15:34:28] <AndyRussG>	 woops unintential caps
[15:34:41] <AndyRussG>	 mepps: is this one needed for CI? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/566749
[15:34:58] <mepps>	 ejegg thought we needed that one
[15:35:18] <AndyRussG>	 ejegg: ^ ?
[15:38:12] <ejegg>	 mepps there's a phan failure without it
[15:38:28] <wikibugs>	 (CR) AndyRussG: "recheck" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566538 (owner: Mepps)
[15:38:36] <ejegg>	 the alternative would be to put an @suppress comment on the function
[15:38:55] <AndyRussG>	 ejegg: ah okok
[15:38:57] <AndyRussG>	 hmmm
[15:40:37] <ejegg>	 gotta go to an appointment. back in an hr ish
[15:40:56] <AndyRussG>	 mepps: ah ok I did indeed have a non-updated master local branch, that's why the log wmf_deploy..master wasn't showing it, oops
[15:41:11] <mepps>	 :) AndyRussG
[15:45:33] <wikibugs>	 (PS2) Mepps: tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[15:45:35] <wikibugs>	 (PS2) Mepps: Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749
[15:45:37] <wikibugs>	 (PS4) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802)
[15:47:44] <AndyRussG>	 mepps: ok that works too!
[15:48:32] <AndyRussG>	 just make sure you have a chain Gerrit patches with all the CI ones, in whatever order, and check that the last CI one passes
[15:50:49] <wikibugs>	 (PS3) Mepps: tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[15:51:19] <mepps>	 i'll have to reset the order, but let me at least see if this one passes
[15:55:01] <AndyRussG>	 mepps: this one just passed: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/566749
[15:56:42] <AndyRussG>	 mepps: so it looks like you only really need that one and the one before it, which is the tests:... one
[15:57:21] <AndyRussG>	 oh wait...
[15:57:31] <AndyRussG>	 hmmm that one passes now too!
[15:58:03] <AndyRussG>	 K I'm confused... I guess lmk when I should look again...
[16:00:31] <AndyRussG>	 mepps: I guess get it to a state where the last one is passing and none of the preceeding ones in the relation chain in the Gerrit UI are marked as "not current"?
[16:00:58] <AndyRussG>	 then you can manually merge all the ones preceding the last one
[16:02:27] <jgleeson>	 fr-tech am I right in guess that most of our stuff would be covered in the Advancement tuning session over the Technology tuning sessioin?
[16:02:31] <jgleeson>	 -i
[16:03:18] <jgleeson>	 also the Advancement session overlaps today's standup
[16:03:19] <AndyRussG>	 huh are we supposed to go to those?
[16:03:30] <AndyRussG>	 I'm always in-tune
[16:03:44] <jgleeson>	 AndyRussG: I didn't go to the first one but I guessed we might be required to pop into one?
[16:03:47] <jgleeson>	 :)
[16:04:10] <AndyRussG>	 hmmm
[16:04:31] <jgleeson>	 it's MEDIUM TERM PLAN related
[16:04:41] <jgleeson>	 dun dun dunnnnnnnnnnnnn
[16:04:49] <mepps>	 as far as i know it's not required jgleeson
[16:05:11] <mepps>	 but we can make time if people want to go
[16:05:28] <jgleeson>	 mepps: yeah I didn't expect it to be mandatory but I'd like to hear anything fr-tech related if it's included in one of those sessions
[16:08:12] <wikibugs>	 (PS3) Mepps: Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749
[16:08:14] <wikibugs>	 (PS4) Mepps: tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[16:08:16] <wikibugs>	 (PS5) Mepps: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802)
[16:10:25] <wikibugs>	 (CR) jerkins-bot: [V: -1] Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749 (owner: Mepps)
[16:11:11] <mepps>	 Urghhh
[16:15:18] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Staging data refresh - https://phabricator.wikimedia.org/T243255 (Jgreen) Open→Resolved >>! In T243255#5824772, @Eileenmcnaughton wrote: > @Jgreen it might be good to do them I think - since it's been a while - mostly dev_drupal -  Ok dev_drupal is done...
[16:16:45] <jgleeson>	 fr-tech does our Q3 end march 31st?
[16:17:23] <jgleeson>	 are we two Qs ahead of the calendar quarters?
[16:19:47] <AndyRussG>	 jgleeson: yes and yes, I think
[16:20:44] <AndyRussG>	 mepps: seems fine now! This is the last CI one in the chain, and it passes: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/566726
[16:20:51] <jgleeson>	 thanks AndyRussG !
[16:21:13] <jgleeson>	 I wish I realised it was just two Qs ahead earlier
[16:21:28] <jgleeson>	 it would have saved me asking every few months what Q we are in
[16:21:31] <AndyRussG>	 jgleeson: yeah our fiscal year starts in July
[16:22:07] <AndyRussG>	 mepps: you can sign up for today's evening SWAT here. Just follow the format of previous requests for SWAT changes https://wikitech.wikimedia.org/wiki/Deployments
[16:22:34] <AndyRussG>	 tip: preview the wiki page before saving 'cause it's easy to accidentally mess up the table format
[16:23:13] <AndyRussG>	 Since by that time the train should have reached all wikis, the only version we need to request an update for is wmf.16
[16:23:58] <AndyRussG>	 mepps: also, if that time (4 pm Pacific) is outside your working hours, I can do it... it's just a matter of being present on IRC and testing that nothing is broken on a test server before it's deployed everywhere
[16:25:13] <AndyRussG>	 and also hanging around on IRC for a little while afterwards in case some breakage appears even despite testing
[16:25:47] <wikibugs>	 fundraising-tech-ops, Operations: (ASAP) rack/setup/install frban1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Jgreen)
[16:37:21] <mepps>	 AndyRussG yeah that's prime kid bed time in my house
[16:37:48] <mepps>	 nice AndyRussG
[16:38:13] <AndyRussG>	 mepps: ok so I can do it (if allowed, or if not someone else can)
[16:38:57] <wikibugs>	 fundraising-tech-ops: geoip_update run failing on frav1002 - https://phabricator.wikimedia.org/T243424 (Jgreen) a:Jgreen
[16:38:58] <AndyRussG>	 it's an hour earlier for me, and I don't have to do tooooo much to get my adolescent kids to go to sleep, and that happens a lot later 8p
[16:39:11] <mepps>	 hmm, i guess we can let this go, though i'm curious if anyone else will be online and would want to at least learn along iwth you
[16:39:13] <AndyRussG>	 mepps: we definitely should push it out today, it's our last chance until after AH
[16:39:22] <mepps>	 i might be able to join briefly, but i'd prefer not to be counted on
[16:40:07] <AndyRussG>	 fr-tech ^ anyone else feel like helping with the CN SWAT deploy today? 4 pm Pacific
[16:40:12] <AndyRussG>	 (no worries if not of course)
[16:41:16] <AndyRussG>	 mepps: so you can manually +2 code review, +2 verify and merge all the Gerrit changes preceding this one? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/566726
[16:41:42] <AndyRussG>	 for the wmf_deploy branch, since it's just a deployment step, we normally don't require a second person to +2 CR
[16:42:21] <wikibugs>	 (CR) Mepps: [C: +2] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[16:42:23] <AndyRussG>	 after you merge all the preceding ones, then you can +2 for just CR the test one and the campaign fallback one, and they should merge automatically
[16:42:26] <wikibugs>	 (CR) Mepps: [V: +2 C: +2] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[16:42:41] <wikibugs>	 (CR) Mepps: [V: +2 C: +2] Move test-only classes to new TestAutoloadClasses declaration [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566748 (https://phabricator.wikimedia.org/T196090) (owner: Mepps)
[16:42:49] <wikibugs>	 (CR) Mepps: [V: +2 C: +2] build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 (owner: Mepps)
[16:42:57] <wikibugs>	 (CR) Mepps: [V: +2 C: +2] Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749 (owner: Mepps)
[16:43:05] <wikibugs>	 (CR) Mepps: [C: +2] tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[16:43:05] <AndyRussG>	 mepps: thanks much!
[16:43:15] <wikibugs>	 (CR) Mepps: [C: +2] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps)
[16:43:36] <mepps>	 sure AndyRussG also for my learning, what would editing the Deployment page look like?
[16:43:49] <mepps>	 i've got to admit all the larger mediawiki processes are pretty intimidating
[16:44:32] <AndyRussG>	 mepps: there is a bunch to learn! it's all pretty clearly documented though... in that case, just click edit source on the Deployments page, and you can see how the source for that is laid out
[16:44:44] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[16:44:48] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move test-only classes to new TestAutoloadClasses declaration [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566748 (https://phabricator.wikimedia.org/T196090) (owner: Mepps)
[16:44:50] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Updating dependencies [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566598 (owner: Mepps)
[16:44:52] <mepps>	 should i put your name there AndyRussG?
[16:44:52] <wikibugs>	 (CR) jerkins-bot: [V: -1] Remove backward compatibility code for OutputPage::parseInline [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566749 (owner: Mepps)
[16:44:54] <wikibugs>	 (CR) jerkins-bot: [V: -1] tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[16:44:56] <wikibugs>	 (CR) jerkins-bot: [V: -1] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps)
[16:45:36] <AndyRussG>	 on every row for  a SWAT deploy, there is an example "Requesting Developer (irc-nickname)
[16:45:37] <AndyRussG>	     Gerrit link to backport or config change" which you copy and adjust to your case
[16:45:47] <AndyRussG>	 mepps: sure, thanks much for doing that!
[16:46:14] <mepps>	 hm the merges still failed AndyRussG, do i need somoene else to verify those patches?
[16:46:26] <AndyRussG>	 mepps: no...
[16:46:36] <AndyRussG>	 I think you need to remove jenkins-bot as a reviewer
[16:46:52] <wikibugs>	 (CR) Mepps: [C: +2] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[16:46:58] <wikibugs>	 (CR) Mepps: [V: +2 C: +2] build: Updating mediawiki/mediawiki-phan-config to 0.8.0 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/557180 (https://phabricator.wikimedia.org/T235049) (owner: Daimona Eaytoy)
[16:47:06] <AndyRussG>	 and then look for a "merge" or "submit" button in the UI
[16:47:22] <AndyRussG>	 mepps: yeah the "submit" button is there now
[16:47:30] <AndyRussG>	 at least for me (on the new Gerrit UI)
[16:48:04] <mepps>	 got it
[16:52:19] <AndyRussG>	 thx!!!!
[16:53:50] <AndyRussG>	 mmm each will only merge once the previous one has
[16:54:10] <wikibugs>	 (CR) AndyRussG: "recheck" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[16:59:05] <wikibugs>	 (Merged) jenkins-bot: tests: Don't write to the actual database [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566726 (owner: Daimona Eaytoy)
[16:59:10] <wikibugs>	 (Merged) jenkins-bot: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/566563 (https://phabricator.wikimedia.org/T240802) (owner: Mepps)
[17:01:20] <mepps>	 okay i think i did AndyRussG
[17:02:53] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jgreen - https://phabricator.wikimedia.org/T242926 (Jgreen) Open→Resolved a:Jgreen
[17:03:42] <AndyRussG>	 mepps: yaaaaay!!!! way to go :)
[17:25:31] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for tskaff - https://phabricator.wikimedia.org/T243043 (Dwisehaupt) a:Dwisehaupt Certificate regenerated and sent via email. Password sent via SMS.
[18:59:42] <ejegg>	 hmm, deadlocks?
[19:00:10] <ejegg>	 nothing in processlist
[19:07:31] <jgleeson>	 @_@
[19:07:48] <ejegg>	 seems to have quieted down. maybe a big search in the UI?
[19:08:16] <ejegg>	 I re-sent the messages that got trapped
[19:08:33] <ejegg>	 though I though eileen's patches from early Dec would make those auto-requeue
[19:08:53] <jgleeson>	 I'm guessing we don't have mysql general log enabeld?
[19:08:56] <jgleeson>	 enabled
[19:09:02] <jgleeson>	 would likely be huge
[19:09:13] <ejegg>	 no, but we do haev a slow query log which is huge anyway
[19:09:19] <ejegg>	 thanks for the reminder!
[19:09:23] <ejegg>	 I'll take a peep at that
[19:09:24] <jgleeson>	 ah maybe it will be in there!
[19:09:43] <ejegg>	 i just looked into those paypal audit d/l failmails
[19:10:27] <ejegg>	 turns out they've put some yearly reconciliation files up and they're huge.
[19:11:04] <jgleeson>	 fr-tech, I'm gonna head over to todays standup hangout an carry on with the adyen normalization if anyone wants to talk it through and sanity check my thinking! :)
[19:11:30] <ejegg>	 and since the paypal downloader runs under python without any fancy priviledge changing (drush jobs run as a diff user), process-control actually CAN kill it when it times out
[19:11:44] <ejegg>	 I'm just transferring the files manually for now
[19:12:12] <ejegg>	 jgleeson: oh great, I'll pop in shortly
[19:17:00] <AndyRussG>	 oh cool! hmmm I can be there in a few minutes
[19:20:38] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: quantify civicrm database growth - https://phabricator.wikimedia.org/T243542 (Jgreen)
[19:27:33] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Staging data refresh - https://phabricator.wikimedia.org/T243255 (Eileenmcnaughton) thanks @Jgreen
[19:36:49] <AndyRussG>	 jgleeson: ejegg: sorry on a non-work phone call that's taking a little while
[20:00:39] <wikibugs>	 (PS7) DannyS712: Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615)
[20:03:57] <wikibugs>	 (CR) jerkins-bot: [V: -1] Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712)
[20:05:58] <wikibugs>	 (PS8) DannyS712: Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615)
[20:38:22] <wikibugs>	 (CR) XenoRyet: [C: +2] Update Adyen SmashPig code to be able to create recurring donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565131 (https://phabricator.wikimedia.org/T242277) (owner: Jgleeson)
[20:38:45] <wikibugs>	 (Merged) jenkins-bot: Update Adyen SmashPig code to be able to create recurring donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565131 (https://phabricator.wikimedia.org/T242277) (owner: Jgleeson)
[20:38:58] <wikibugs>	 (CR) XenoRyet: [C: +2] Add script to test our Adyen recurring payment capturing. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565059 (owner: Jgleeson)
[20:39:18] <wikibugs>	 (Merged) jenkins-bot: Add script to test our Adyen recurring payment capturing. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/565059 (owner: Jgleeson)
[20:42:42] <icinga-wm>	 PROBLEM - check_load on frdb1002 is CRITICAL: CRITICAL - load average: 33.25, 25.17, 13.53
[20:47:52] <icinga-wm>	 PROBLEM - check_load on frdb1002 is CRITICAL: CRITICAL - load average: 30.26, 25.61, 16.81
[20:53:08] <icinga-wm>	 PROBLEM - check_load on frdb1002 is CRITICAL: CRITICAL - load average: 38.12, 33.00, 22.51
[20:58:08] <icinga-wm>	 PROBLEM - check_load on frdb1002 is CRITICAL: CRITICAL - load average: 32.94, 34.97, 26.43
[21:02:18] <icinga-wm>	 PROBLEM - check_load on frdb1002 is CRITICAL: CRITICAL - load average: 3.28, 20.68, 23.21
[21:03:37] <icinga-wm>	 ACKNOWLEDGEMENT - check_load on frdb1002 is CRITICAL: CRITICAL - load average: 3.28, 20.68, 23.21 Dwisehaupt bad queries.
[21:32:18] <icinga-wm>	 RECOVERY - check_load on frdb1002 is OK: OK - load average: 0.17, 0.37, 4.21
[21:50:18] <wikibugs>	 fundraising-tech-ops: Server data hang - https://phabricator.wikimedia.org/T243551 (Peachey88)
[21:50:52] <wikibugs>	 fundraising-tech-ops: Server data hang - https://phabricator.wikimedia.org/T243551 (Peachey88)
[22:42:47] <wikibugs>	 fundraising-tech-ops: geoip_update run failing on frav1002 - https://phabricator.wikimedia.org/T243424 (Jgreen) Open→Resolved Fixed. The issue appeared to be a (logical) change in wget behavior, where if fed an https:// request with an proxy_http environment variable, it no longer converts the client...
[23:48:26] <wikibugs>	 Fundraising-Backlog, video2commons: Commons video player does not work on IE 11 or older versions of Safari - https://phabricator.wikimedia.org/T243562 (jbolorinos-ctr)
[23:48:58] <wikibugs>	 Fundraising-Backlog, video2commons: Commons video player does not work on IE 11 or older versions of Safari - https://phabricator.wikimedia.org/T243562 (jbolorinos-ctr)
[23:57:16] <wikibugs>	 Fundraising-Backlog, video2commons: Commons video player does not work on IE 11 or older versions of Safari - https://phabricator.wikimedia.org/T243562 (jbolorinos-ctr) Just adding a note that this issue is not immediately impacting the Fundraising Team since the Thank You campaign is already over, so th...