[00:21:57] Fundraising-Backlog, Commons, TimedMediaHandler: Commons video player does not work on IE 11 or older versions of Safari - https://phabricator.wikimedia.org/T243562 (revi) [00:28:15] (PS1) Catrope: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf/1.35.0-wmf.16) - https://gerrit.wikimedia.org/r/566901 (https://phabricator.wikimedia.org/T240802) [00:28:21] (CR) Catrope: [C: +2] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf/1.35.0-wmf.16) - https://gerrit.wikimedia.org/r/566901 (https://phabricator.wikimedia.org/T240802) (owner: Catrope) [00:30:14] (CR) Catrope: [V: +2 C: +2] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf/1.35.0-wmf.16) - https://gerrit.wikimedia.org/r/566901 (https://phabricator.wikimedia.org/T240802) (owner: Catrope) [00:32:01] (PS1) Catrope: Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf/1.35.0-wmf.15) - https://gerrit.wikimedia.org/r/566902 (https://phabricator.wikimedia.org/T240802) [00:32:09] (CR) Catrope: [V: +2 C: +2] Reset hide shouldHide,reason private variables when setting new category [extensions/CentralNotice] (wmf/1.35.0-wmf.15) - https://gerrit.wikimedia.org/r/566902 (https://phabricator.wikimedia.org/T240802) (owner: Catrope) [00:32:31] fr-tech CN deploy about to happen if anyone's interested, the action is over at #wikimedia-operations [00:32:55] Thanks AndyRussG! [00:33:48] mepps: funny thing, Roan has decided not to include the CI-fixing stuff in the deploy, just 'cause it's easier and the actual change we want to deploy is teeny [00:34:06] I was just reading that [00:34:08] not as I expected, other times other deployers have balked at deploying things that don't pass CI [00:34:19] however Roan very much knows his stuff [00:34:29] That’s good! [00:35:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [ER] Request to create separate permission levels for publishing banners or updating banner code on CN - https://phabricator.wikimedia.org/T243565 (jbolorinos-ctr) [01:25:31] (PS1) Cstone: WIP: Add catch for two recurring payments happening in one month. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566909 (https://phabricator.wikimedia.org/T240140) [01:31:35] (CR) jerkins-bot: [V: -1] WIP: Add catch for two recurring payments happening in one month. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566909 (https://phabricator.wikimedia.org/T240140) (owner: Cstone) [10:16:07] (CR) Daimona Eaytoy: [C: +2] Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [10:19:14] (Merged) jenkins-bot: Remove uses of global $wgUser as a fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/561237 (https://phabricator.wikimedia.org/T241615) (owner: DannyS712) [16:22:20] AndyRussG: Hey! Question, how easy is it to remove unwanted close cookie categories? [16:43:53] Seddon: oh, are we getting complaints about cluttering requests with too many close cookies? [16:57:30] ejegg: Hey no, I just want to clean up the list in the interface and replace it with some more clearly defined categories [16:58:05] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for gpaumier - https://phabricator.wikimedia.org/T243041 (Dwisehaupt) Regenerated certificate and sent via email. Password sent via SMS. [16:58:25] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for gpaumier - https://phabricator.wikimedia.org/T243041 (Dwisehaupt) a:Dwisehaupt [17:03:09] Seddon: the hide cookie names are derived from the 'category' property of the campaigns. If we start standardising those now, all the old hide cookies should be expired by this time next year. [17:04:33] oh hmm, not seeing category in the campaign ui [17:04:37] is it on banners? [17:04:56] ah yeah, it's on banners [17:05:18] ok, so the request is to clean up that dropdown? [17:05:34] let's see where that comes from... [17:06:30] Ah, I guess choosing 'Other' and entering something leaves that choice in the dropdown forever? [17:07:37] ejegg: yeah, it adds it there but there is no way to remove them [17:09:14] Right, so it would have to be some backend SQL to clean it up now, but a possible feature would be a CN admin tab to delete old ones and maybe manage defaults like expiration [17:09:43] or just pare down the list and get rid of 'Other' in a future CN upgrade. [17:09:48] (easier) [17:10:47] sure seems like the setting belongs at campaign level, too [17:22:04] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for dallas - https://phabricator.wikimedia.org/T243040 (Dwisehaupt) a:Dwisehaupt Certificate regenerated and provided via dev server. [17:28:15] Seddon: sorry can you explain in greater detail what you want and why? [17:28:48] AndyRussG: I just want to clean up the list of close cookie categories [17:29:08] where do you see this list Seddon? [17:29:46] on the banner admin screen settings [17:29:46] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/WikiLovesLove_updatestyle [17:30:41] Seddon: ok I see... hmmm never noticed how awful that is 8p [17:31:04] Seddon: ejegg: I can dig in... or maybe mepps can! [17:31:57] Not a priority, I was just wondering how easy it is to cleanup [17:32:20] fr-tech coming, google reauth problems [17:36:24] Wikimedia-Fundraising-Banners: [ER] Update needed on Donate Wiki - Matching Gifts text - https://phabricator.wikimedia.org/T243613 (jbolorinos-ctr) [18:07:49] Seddon: prolly not impossible but no too quick... maybe we'd have to check for causing issues for viewing old banners, too? [18:14:44] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Tsevener) I'm still having trouble reproducing unfortunately. As long as the `endTime` has consistentl... [18:15:07] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Tsevener) a:Tsevener→None [19:02:34] fr-tech, I'm gonna jump in today's standup room if anyone wants to talk through the adyen stuff we're working on :) [20:30:02] (PS6) Ejegg: Fix bug where stretches of time were being skipped [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564828 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [20:30:40] (CR) Ejegg: [C: +2] "Thanks for the detailed explanation!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564828 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [20:36:41] (Merged) jenkins-bot: Fix bug where stretches of time were being skipped [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564828 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [20:48:39] (PS1) Jgleeson: WIP: Normalize createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 [20:49:17] (CR) jerkins-bot: [V: -1] WIP: Normalize createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (owner: Jgleeson) [20:57:55] (PS1) Jgleeson: WIP: Update Adyen Recurring Test Script [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 [20:58:16] (CR) jerkins-bot: [V: -1] WIP: Update Adyen Recurring Test Script [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (owner: Jgleeson) [22:58:19] (CR) Ejegg: [C: +2] "Looks good to me! Nothing too scary in the release notes and doesn't break our processes (after the application of follow-on contribution_" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [22:58:24] (CR) Ejegg: [C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566400 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [22:58:45] (PS1) Umherirrender: build: Updating dependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/567158 [23:01:24] (CR) jerkins-bot: [V: -1] Stock CiviCRM 5.22 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [23:01:27] (CR) jerkins-bot: [V: -1] WMF-hack - make contribution_id optional until we update SmashPig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [23:01:29] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566400 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [23:03:08] (CR) Ejegg: [V: +2 C: +2] Stock CiviCRM 5.22 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/562402 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [23:03:34] (CR) Ejegg: [C: +2] "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [23:10:08] (Merged) jenkins-bot: WMF-hack - make contribution_id optional until we update SmashPig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566388 (https://phabricator.wikimedia.org/T242056) (owner: Eileen) [23:10:10] (Merged) jenkins-bot: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/566400 (https://phabricator.wikimedia.org/T242056) (owner: Eileen)