[00:49:00] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog: Move queue message docs to mw.o, update - https://phabricator.wikimedia.org/T198733 (Ejegg) These docs have been moved and updated * https... [02:05:17] RECOVERY - check_yubico on frauth2001 is OK: HTTP OK: HTTP/1.1 200 OK - 663 bytes in 0.456 second response time [15:29:29] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice ... - https://phabricator.wikimedia.org/T241070 [15:53:53] back soon just switching venue [16:19:34] Wikimedia-Fundraising-Banners: [ER] Update needed on Donate Wiki - Matching Gifts text - https://phabricator.wikimedia.org/T243613 (spatton) Hey @DStrine, a few questions and we can get this done: - Transferring Peter's question from email: //Do we need something similar on https://donate.wikimedia.org/wiki... [16:43:27] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog: Move queue message docs to mw.o, update - https://phabricator.wikimedia.org/T198733 (XenoRyet) Yea, looks good. I'll move the ticket over... [16:52:16] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 1 [=1],GlobalCollect_endpoint_critical 1 [=1],Paypal_endpoint_critical 1 [=1],Yubico_endpoint_critical 1 [=1] [16:53:41] (PS42) Ejegg: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [16:54:10] ok mepps, I think that should restore the country status boxes ^^^ [16:54:21] (and probably get it passing CI again) [16:57:16] RECOVERY - check_log_messages on frav1002 is OK: OK [16:59:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Determine how to blank text of old TY mails w/o losing other mail - https://phabricator.wikimedia.org/T244503 (Ejegg) [17:16:35] (PS43) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:18:07] (CR) jerkins-bot: [V: -1] Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:30:54] (PS44) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:34:08] Fundraising-Backlog, FR-Adyen, Fr-planning-ahead: Apple Pay Specs - Adyen - https://phabricator.wikimedia.org/T229039 (Ejegg) Here's what we got from Adyen back in 2016: Merchant does the whole Apple Pay button js thing (https://developer.apple.com/apple-pay/acceptable-use-guidelines-for-websites/)... [17:38:44] (PS45) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:40:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, Patch-For-Review: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581 (Ejegg) [17:40:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, Patch-For-Review: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581 (Ejegg) The recurring-specific normalization has two parts: 1) finding the contribution_tracking_id an... [17:43:27] Wikimedia-Fundraising-Banners: [ER] Update needed on Donate Wiki - Matching Gifts text - https://phabricator.wikimedia.org/T243613 (DStrine) >>! In T243613#5856688, @spatton wrote: > Hey @DStrine, a few questions and we can get this done: > > - Does it matter where we place this? If not, we'll put it at the... [17:48:19] Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface: Recurring payment messages from frontend should go to recurring queue - https://phabricator.wikimedia.org/T165087 (Ejegg) Open→Declined On second thought, no, let's send all payment messages to the donatio... [18:04:34] Fundraising-Backlog: Implementing GPAY for donors - https://phabricator.wikimedia.org/T244513 (Aklapper) [18:05:36] Fundraising-Analysis: Additional MinFraud functionality - https://phabricator.wikimedia.org/T243464 (EMartin) Minfraud documentation on these changes here: https://dev.maxmind.com/minfraud/ [18:07:30] Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Update civi SmashPig extension to be able to charge Adyen recurring - https://phabricator.wikimedia.org/T242278 (DStrine) [18:13:26] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fr-planning-ahead: Review and comment on several upcoming projects - https://phabricator.wikimedia.org/T243294 (DStrine) [18:32:43] Fundraising-Backlog: Consolidate fr-tech onboarding documentation - https://phabricator.wikimedia.org/T244516 (mepps) [18:33:21] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (Tsevener) @Pcoombe thanks! We will look into a hotfix right away. Question for @MBeat33 - on our side... [18:36:09] Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Don't send failmail on duplicate contribution_recur insert - https://phabricator.wikimedia.org/T244518 (Ejegg) [18:37:54] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (mepps) [18:39:43] (CR) XenoRyet: [C: +2] Update Yaml::parse invocation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/569094 (owner: Ejegg) [18:40:02] (Merged) jenkins-bot: Update Yaml::parse invocation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/569094 (owner: Ejegg) [18:45:59] thanks for that patch ejegg|food [18:46:08] I forgot about that [18:53:29] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed, iOS-app-v6.6-Penguin-On-A-Sled: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (MBeat33) Hi @Tsevener it is difficult to get feedback from donors after the fact about what they saw s... [18:54:29] fundraising-tech-ops, Operations, ops-codfw: codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Papaul) [18:59:27] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (mepps) I'm thinking ab... [19:22:58] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (Ejegg) I would expect... [19:24:54] (CR) Ejegg: [C: -1] "-1ing this for more visibility. Can we move the JS to a standalone file? If there's a good reason not to, I'll remove the -1." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/565172 (https://phabricator.wikimedia.org/T233374) (owner: Eileen) [19:26:35] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Show selected countries and regions under tree selector - https://phabricator.wikimedia.org/T243012 (mepps) In my initial investig... [19:30:36] (CR) Ejegg: [C: +2] "This looks reasonable, I just don't like that there's no return statement in the fallthrough case of _civicrm_api3_deprecation_check now!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570190 (https://phabricator.wikimedia.org/T244322) (owner: Eileen) [19:31:27] (CR) Ejegg: [C: +2] "Thanks for the investigation! Definitely worth trying." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570193 (https://phabricator.wikimedia.org/T244325) (owner: Eileen) [19:36:38] (PS2) Ejegg: Remove handling for bogus 'anonymous' and 'optout' fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564274 [19:37:01] (Merged) jenkins-bot: Replace our caching fix with the alternative proposed by Coleman [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570190 (https://phabricator.wikimedia.org/T244322) (owner: Eileen) [19:37:10] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) As of 2020-02-06 the plan is to host this project in eqiad, using frdb1003 (already procured T236920) and a new procurement for the web/application server (T24099... [19:38:00] (Merged) jenkins-bot: Revert WMF delete vs truncate hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570193 (https://phabricator.wikimedia.org/T244325) (owner: Eileen) [19:38:01] ugh, lots of failmail today [19:38:47] @/ [19:39:48] some query is 'Copying to tmp table on disk' [19:39:58] Wikimedia-Fundraising: Wikimedia Foundation image cut off on IE 11 - https://phabricator.wikimedia.org/T244525 (jbolorinos-ctr) [19:41:56] Wikimedia-Fundraising, donate.wikimedia.org, Browser-Support-Internet-Explorer: Wikimedia Foundation image cut off on IE 11 - https://phabricator.wikimedia.org/T244525 (Pcoombe) [19:42:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deadlocks due to soft credit search/report - https://phabricator.wikimedia.org/T244527 (Ejegg) [19:42:23] Wikimedia-Fundraising-Banners, donate.wikimedia.org, Browser-Support-Internet-Explorer: Wikimedia Foundation image cut off on IE 11 - https://phabricator.wikimedia.org/T244525 (spatton) [19:43:51] looks like an Engage contractor [19:44:57] oh ejegg|afk that reminds me, dwisehaupt had to kill off a few queries from someone at engage earlier this week. I wonder if they're running the same one again? [19:45:59] maybe - could have to do with the Civi upgrade too [19:46:01] looking [19:46:15] jgleeson: you know we can kill queries, right? [19:46:24] yup ejegg [19:46:27] cool cool [19:46:36] I was using the crsql thingy to check the processlist [19:46:48] this is a different query. [19:47:04] although I couldn't run the query that shows us active db locks [19:48:29] lots of tables in use but no locks. [19:49:05] checking the slow log, with the others, they were just massive queries, ie: 1.2mil records but only returning 8-10 [19:51:29] that query was run multiple times and didn't return any rows. [19:51:30] # Thread_id: 22281113 Schema: civicrm QC_hit: No [19:51:30] # Query_time: 2293.302619 Lock_time: 0.003557 Rows_sent: 0 Rows_examined: 0 [19:51:33] # Rows_affected: 44911050 [19:53:11] looks like it was run 4 times in a row. not quite sure what it's intended use is. [19:54:36] no doubt cats have something to do with it [19:56:17] i'm thinking you don't have access to the slow query log, which is useful in some of these cases. [19:56:29] (PS1) Aaron Schulz: Avoid pointless use of $wgMemc [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/570705 (https://phabricator.wikimedia.org/T160813) [19:58:33] where is that located dwisehaupt ? [19:59:14] /srv/sqldata/${hostname}-slow.log [19:59:32] Ill try it out [19:59:52] frdev or frlog/ [19:59:54] ? [20:00:21] ah. that's on the individual db hosts. [20:00:35] ohes [20:00:54] so it would be on frdev, but i don't think those get packaged and shuttled to frlog. [20:01:20] jgleeson@frdev1001:/srv$ cd sqldata/ [20:01:22] -bash: cd: sqldata/: Permission denied [20:02:22] actually, we do roll that up. yay! frlog:/var/log/remote/fundraisingdb-mysql-slow [20:03:31] it's a little harder to read since it's multiline output and has the date/time/host/process for each line of each entry. [20:05:21] (PS1) Pcoombe: Make en thank you email specify one-time donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/570708 (https://phabricator.wikimedia.org/T244397) [20:06:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: make EN TY emails specify one-time donation - https://phabricator.wikimedia.org/T244397 (CCogdill_WMF) Thanks so much for jumping on this, Peter :) [20:10:16] hmm just stumbled across another Maintenance script written to test out ingenico createPayment calls https://github.com/wikimedia/wikimedia-fundraising-SmashPig/commit/80ff6bfc6735d271a5ffd74faa6d97a90b281161#diff-1035d984d2b6474b68b0724f44cc52fc [20:10:28] I'm looking at this code feeling like https://i.kym-cdn.com/entries/icons/facebook/000/019/630/ihnmotp.jpg [20:20:37] lol [20:23:52] jgleeson: I'm taking a harder look at the Adyen SmashPig code and I think we need to do some redesign [20:24:09] So the fact that you need to deal with WSDL feels like a really funky smell [20:24:43] the PaymentProvider class should be responsible for the same type of job whether it's Adyen or Ingenico [20:25:31] and the Ingenico one just takes the normalized parameter names and values, maps them to processor-specific names and values, and hands them off to the appropriate method on the API object [20:26:24] so it feels like we should go back to having the Adyen API object just being a thin wrapper around the WSDL calls [20:26:36] and have a new class be the one that implements PaymentProvider [20:27:04] then the API object is mockable for your tests of PaymentProvider functionality [20:27:48] and maybe it does a little bit less than it did before we started working on it, e.g. it doesn't multiply amount by 100, because normalizing argument values is part of the PaymentProvider's job [20:28:17] does that sound right? [20:28:37] Sorry I didn't think this all the way through a month ago :( [20:28:39] reading [20:30:09] (CR) Krinkle: [C: +2] Avoid pointless use of $wgMemc [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/570705 (https://phabricator.wikimedia.org/T160813) (owner: Aaron Schulz) [20:32:04] ejegg: I kinda see what you mean. We're duplicating a similar API across AdyenPaydmentsAPI and the ingenico/PaymentsProvider class [20:32:38] AdyenPaumentAPI could probably be the $api var within the AdyenPaymentsProvider [20:32:45] s/u/y/ [20:32:54] that kind of thing? [20:33:23] The PaymentProviderResponse stuff is doing a similar thing to make it provider agnostic [20:37:20] is https://scrutinizer-ci.com/ an alternative to travis-ci? [20:37:31] I've not seen that before [20:37:45] looks like it's running on our github stuff [20:39:11] looks like scrutinizer is not free for open source [20:39:14] and travis is [20:39:48] https://scrutinizer-ci.com/g/wikimedia/wikimedia-fundraising-SmashPig/ [20:39:56] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (mepps) In working on t... [20:44:58] jgleeson yeah, AdyenPaymentAPI would be the $api variable [20:45:03] (Merged) jenkins-bot: Avoid pointless use of $wgMemc [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/570705 (https://phabricator.wikimedia.org/T160813) (owner: Aaron Schulz) [20:45:58] scrutinizer is a thing that does static analysis. When Adam and I signed up for it, it was free! [20:46:08] And it has caught a bunch of silly mistakes for us [20:46:18] yeah it looks good [20:46:29] We're using some older setup though, so it's not actually running tests like it was before [20:46:41] oh man, sorry, it IS free for open-source! [20:46:54] \o/ [20:47:22] I think it would be useful to see this more easily [20:47:35] yeah! [20:47:42] at what point does the github repo get updated? [20:47:48] I get an email from them every time something merges [20:48:01] Oh, I think the github repo is updated when something merges to master [20:48:03] ah I see, can I register for emails or something [20:48:31] looks like I can subsribe [20:48:44] 404 [20:48:46] Not Found [20:48:48] oh noes [20:50:36] ejegg: I think your suggestion makes sense to me [20:51:18] I'm just wrapping up the ingeinco mapper stuff but feel free to paste this chat into a ticket and we can ask XenoRyet and the rest of fr-tech about pulling it into sprint [20:51:29] Cool, will do [21:16:35] Fundraising-Backlog, FR-Smashpig: Adyen PaymentProvider / API classes should be split out like Ingenico ones. - https://phabricator.wikimedia.org/T244536 (Ejegg) [21:16:47] jgleeson: does that look right? ^^^ [21:18:23] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (Ejegg) Hmm, and while... [21:20:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deadlocks due to soft credit search/report - https://phabricator.wikimedia.org/T244527 (Ejegg) [21:25:06] oof, so soft credit searches in Civi core just build a HUGE temp table to search in [21:25:40] that needs refactoring [21:28:43] @_@ [21:32:02] The first line of the ticket feels Smithian :) specifically Adam Smithian [21:33:55] argh I was trying to find the book online to remember the opening line [21:34:27] nvm back to submitting these 3 patches! [21:35:09] so I need to reset the previous 3 commits and then reorder the file across the 3 commits [21:35:47] I've done something similar by stashing changes, rebasing and editing commits, restoring the stash changes and then continuing the rebase [21:36:10] effectively swapping files across commits to make them more relevantly grouped [22:12:04] yeah, you can use rebase -i to reorder the commits and even edit them. it can get hairy pretty quick though. [22:13:14] jgleeson you can also make a scratch commit and just call it 'fixup' or something [22:13:47] then with rebase -i just put it in the right place in the line and change its prefix to 'f' so it gets squashed into the one above it [22:14:05] ejegg: this is to make it easier to review really [22:14:14] it's a little disjointed at the moment [22:14:28] hmm I've got it close to how I want it [22:14:42] but can't seem to unstage one file in the last commit [22:14:53] hmm I'll push what I have [22:14:58] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Server for previewing/usability testing new CentralNotice ... - https://phabricator.wikimedia.org/T241070 [22:16:27] oh man [22:16:50] I just realisd I've just completed that tricky rebase and forgot to run composer test ! [22:16:58] :( [22:17:35] heh, you could be lazy and let jenkins test it [22:18:20] this is turning into an Eileen patch chain [22:18:23] :) [22:19:53] (PS4) Jgleeson: WIP: Normalize createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 [22:19:55] (PS5) Jgleeson: WIP: Update Adyen Recurring Test Script [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 [22:19:57] (PS1) Jgleeson: WIP: Update Ingenico to use normalised payment provider response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570731 [22:19:59] (PS1) Jgleeson: Coding styles clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570732 [22:20:20] (CR) jerkins-bot: [V: -1] WIP: Update Adyen Recurring Test Script [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (owner: Jgleeson) [22:20:22] (CR) jerkins-bot: [V: -1] WIP: Update Ingenico to use normalised payment provider response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570731 (owner: Jgleeson) [22:20:25] (CR) jerkins-bot: [V: -1] Coding styles clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570732 (owner: Jgleeson) [22:20:27] oh that's annoying it's ignored my new commit names :/ [22:20:41] where I normalise my spelling of normalize [22:22:40] (PS5) Jgleeson: WIP: Normalize PaymentProvider Response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 [22:22:42] (PS6) Jgleeson: WIP: Update Adyen to use normalized payment provider response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 [22:22:44] (PS2) Jgleeson: WIP: Update Ingenico to use normalized payment provider response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570731 [22:22:46] (PS2) Jgleeson: Coding styles clean up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570732 [22:23:08] (CR) jerkins-bot: [V: -1] WIP: Update Ingenico to use normalized payment provider response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570731 (owner: Jgleeson) [22:23:10] (CR) jerkins-bot: [V: -1] WIP: Update Adyen to use normalized payment provider response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (owner: Jgleeson) [22:24:57] (CR) Jgleeson: Coding styles clean up (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570732 (owner: Jgleeson) [22:31:21] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: First Batch of TY Emails Pushed to Gerritt - https://phabricator.wikimedia.org/T238736 (Ejegg) Did the versions sent on Jan 7th look good? I don't see any obvious errors looking at the patch. [22:35:13] (Abandoned) Ejegg: 16 thank you email body and subject lines [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/565690 (owner: Cdenes) [22:44:00] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Ejegg) @CDenes_WMF these are all on the staging server. Feel free to use the TY mail test page to send them to yours... [22:49:21] (CR) Ejegg: [C: -1] "Looks good, just has a stray space after a table name." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/565175 (https://phabricator.wikimedia.org/T233374) (owner: Eileen) [22:50:08] (PS2) Ejegg: Remove hacky-handling I tink we non longer need [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566118 (owner: Eileen) [22:50:16] (CR) Ejegg: [C: +2] Remove hacky-handling I tink we non longer need [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566118 (owner: Eileen) [22:51:03] (CR) Ejegg: [C: +2] Re-run wmf_civicrm_update_7915 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566119 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [22:56:00] (Merged) jenkins-bot: Remove hacky-handling I tink we non longer need [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/566118 (owner: Eileen) [22:57:37] (PS2) Ejegg: Revert our hack to add an assignee to Contact Deleted by Merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570195 (https://phabricator.wikimedia.org/T244327) (owner: Eileen) [22:58:02] (CR) Ejegg: [C: +2] "Yep, that new link should be all we need." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570195 (https://phabricator.wikimedia.org/T244327) (owner: Eileen) [23:04:17] (Merged) jenkins-bot: Revert our hack to add an assignee to Contact Deleted by Merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/570195 (https://phabricator.wikimedia.org/T244327) (owner: Eileen)