[08:50:58] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: Central Notice message groups are slow to index - https://phabricator.wikimedia.org/T111189 (Nikerabbit) [08:52:56] (CR) Thiemo Kreuz (WMDE): [C: +2] Replace use of `rc_new` field with `rc_source` [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/567536 (https://phabricator.wikimedia.org/T36320) (owner: DannyS712) [09:34:57] (Merged) jenkins-bot: Replace use of `rc_new` field with `rc_source` [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/567536 (https://phabricator.wikimedia.org/T36320) (owner: DannyS712) [12:17:46] (PS10) Jgleeson: Add PaymentProviderResponse and some PaymentProvider Interfaces to to help normalize class APIs across providers. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) [12:18:05] (CR) jerkins-bot: [V: -1] Add PaymentProviderResponse and some PaymentProvider Interfaces to to help normalize class APIs across providers. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [13:10:41] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (jbond) p:Triage→Medium [13:22:20] fr-tech, today's album recommendation is Armik - Gypsy Flame (Flamenco Guitar) :) [15:00:11] thanks jgleeson! [15:25:27] Hi mepps, jgleeson... thanks jgleeson! [15:29:39] hi AndyRussG! [15:39:36] :) [16:01:52] hi mepps! [16:04:57] :) [17:00:16] Fundraising-Backlog, fundraising-tech-ops: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (EYener) @Jgreen do you have an estimated level of effort on installing Superset on the application server? We are trying to determine if this is something we should s... [17:08:02] fr-tech, I ran into a head scratching problem earlier. I've added a few new php interfaces to the smashpig payment provider stuff, e.g. CreatePayment interface containing a single method signature `public function createPayment($params);` but when submitting the patch CI rejected it due to the a "PHP4 style" contructor naming violating [17:08:03] https://integration.wikimedia.org/ci/job/composer-php70-docker/970/console which I think is just due to an over-zealous code sniff rule that maybe shouldn't be applied to interfaces. I decided to rename the interfaces to get around it for now but it got me thinking about how we name our interfaces, we seem to have a mix of approaches accross the codebases including the "I" prefix, no prefix and [17:08:05] the "Interface" suffix. Should we standardise on one? [17:10:31] IStandardise, Standardise, StandardiseInterface [17:11:16] jgleeson: ohh hmm [17:14:24] That looks like a weird CI error [17:14:41] We shouldn't let CI dictate how we name stuff if it's a silly error like that [17:15:07] WRT naming, there's also the interface Thing / class ThingImpl pattern, but I don't think that's super useful [17:15:14] unless you have interfaces for everything [17:15:39] I'm happy with the "I" prefix but am not up to date on the current thinking and standards for that in PHP [17:19:46] AndyRussG: yeah I was put off trying to fix it at the CI level as I guessed that the code sniff tweaking would be fiddly but I suppose I'm just being lazy [17:20:07] fwiw, I went with the "I" prefix [17:26:39] ah okok [17:26:43] cool! [17:29:40] naming things is hard, I like the idea of standardizing the naming though [17:30:04] jgleeson: you can also tell PHPCS to ignore certain lines with these comments: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-parts-of-a-file [17:31:43] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog: donors in Sweden not seeing full 3ds flow - https://phabricator.wikimedia.org/T245325 (DStrine) Open→Resolved [17:32:21] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog: donors in Sweden not seeing full 3ds flow - https://phabricator.wikimedia.org/T245325 (DStrine) ingenico turned on 3ds completely and removed their name field. the test seemed to run well. [17:36:43] yeah naming my kids was not easy, for example [17:36:48] :) [17:37:11] On that topic, here's today's parenting humour: http://www.smbc-comics.com/comic/bitch [17:38:26] lol [17:39:41] https://xkcd.com/2272/ [17:41:15] Fundraising-Backlog: Add Brave donations into Civi - https://phabricator.wikimedia.org/T245853 (EMartin) NOTE: The Brave donations are hand entered from the EFT reports received by Finance and all live under CID 39334101 with a gift source of Alternative Gifts. Can these be mapped to a Brave gateway within... [17:42:04] rip cool space beeps [17:42:42] how's the sleeping pattern cstone ? [17:45:26] https://xkcd.com/290/ this made me laugh and reminded me of the nintento switch party at allhands [17:45:45] getting there I was up at 4am today [17:59:05] I miss the days of my bodyclock waking me up. Now I'm woken by small humans who have no respect for the 8 hour sleep rule. [18:01:40] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Nuria) [18:02:00] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Nuria) Putting on radar for #analytics @Jgreen can ping us if he needs help. [18:04:14] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Milimetric) Excited to collaborate on this. My first thought is to caution against seeing superset as a solution. In our data pipelines, Superset com... [18:06:51] jgleeson: just wait 10-12 years, the tables will be turned! [18:07:32] haha [18:09:58] they'll pay for their crimes with unnecessary vacuuming outside their room at 6am when the time comes. [18:11:42] ohhh noo you'll regret that eh [18:12:28] yeah who am I kidding. Even in 10 years I won't be functional enough to be up and ready to do house work at 6am [18:12:49] Mmmm maybe not housework, but you'll have to get them to go to shcool [18:12:53] jgleeson: so how is it that in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/567137 we just get rid of PaymentResult? Was that logic completely unused ? [18:13:40] (PS1) Ejegg: Hebrew TY email edits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574521 (https://phabricator.wikimedia.org/T243098) [18:14:42] AndyRussG: I'm pretty sure it was unused and just copied across from https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_common/PaymentResult.php [18:15:44] AndyRussG: So that 'PaymentResult' class was meant to represent a higher-level concept about a donation attempt rather than a specific API call response [18:16:09] that is, a PaymentResult would be the final thing returned to the form layer after potentially making a bunch of API calls [18:16:33] and would say whether it was successful or not, where to send the donor next, or what errors to show to the donor [18:18:08] hmm that feels along the lines of the PaymentProviderResponse object I added [18:18:35] although that doesn't really deal with stuff like redirects or iframes. I guess it would just relevant for API responses [18:20:55] ejegg: jgleeson: ah okok thanks! [18:23:02] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, and 2 others: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (mepps... [18:23:24] Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, and 2 others: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (mepps... [18:47:51] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Patch-For-Review: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Ejegg) @CDenes_WMF it looks like the HE email went out to pro... [18:54:08] fundraising-tech-ops, DC-Ops, Operations, ops-codfw, Patch-For-Review: (ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Dwisehaupt) [19:12:00] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Dwisehaupt) Database cloning over from frdb1003. Will do the restore after the copy is finished. Will take a while as it is 290G. [19:15:14] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Patch-For-Review: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (CDenes_WMF) Tested HU email and looks good-- ready for produc... [19:16:26] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (EYener) @Milimetric Likewise excited for collaboration! I agree that visualization is the final piece of this puzzle. In parallel to discussing a front... [19:17:27] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Patch-For-Review: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (CDenes_WMF) Tested HE email and looks good for production, th... [19:28:24] (CR) AndyRussG: "Cool!!!! Thanks so much for working on this... Just a few uninformed drive-by thoughts..." (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [19:32:57] (CR) Ejegg: [C: +2] "Self-merging after independent review of content by CDenes" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574521 (https://phabricator.wikimedia.org/T243098) (owner: Ejegg) [19:33:08] (PS2) Ejegg: Hebrew TY email edits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574521 (https://phabricator.wikimedia.org/T243098) [19:37:23] (PS11) Jgleeson: Add PaymentProviderResponse to help normalize reponses across providers. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) [19:37:25] (PS12) Jgleeson: Update Adyen to use PaymentProviderResponse stuff [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T243340) [19:52:00] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Milimetric) For OLAP-style dimensional data we like Druid as a data store. So the flow there for us is: * Kafka -> Camus (bucket hourly) -> HDFS * Me... [20:00:18] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574544 [20:00:56] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574544 (owner: Eileen) [20:02:25] I'm just doing a minor deploy - includes some of cdenes patches [20:02:29] ^^ [20:03:58] !log civicrm revision changed from c086fd4e0b to 426e3547ca, config revision is 561ae21f77 [20:04:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:10:10] (Abandoned) Jgleeson: WIP: Update Ingenico to use PaymentProviderResponse stuff [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/570731 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [20:12:56] (PS13) Jgleeson: Update Adyen to break out into separate PaymentProvider and Api classes. Also map responses sent back from Api to the new PaymentProviderRespone thingy. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) [20:15:06] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, and 3 others: Normalize createPayment responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T243340 (jgleeson) The Adyen side of... [20:16:44] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: get rid of the table log_wmf_donor. - https://phabricator.wikimedia.org/T245086 (Eileenmcnaughton) Open→Resolved [20:16:46] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Truncate civicrm_log table - https://phabricator.wikimedia.org/T245085 (Eileenmcnaughton) [20:16:51] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: get rid of the table log_wmf_donor. - https://phabricator.wikimedia.org/T245086 (Eileenmcnaughton) [20:16:59] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: get rid of the table log_wmf_donor. - https://phabricator.wikimedia.org/T245086 (Eileenmcnaughton) [20:17:16] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Stop logging & drop log_civicrm_omnimail_job_progress - https://phabricator.wikimedia.org/T244934 (Eileenmcnaughton) [20:17:23] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Stop logging & drop log_civicrm_omnimail_job_progress - https://phabricator.wikimedia.org/T244934 (Eileenmcnaughton) Open→Resolved [20:17:25] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Decide what to do about the increasing civi crm db size - https://phabricator.wikimedia.org/T243870 (Eileenmcnaughton) [20:17:37] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Truncate civicrm_log table - https://phabricator.wikimedia.org/T245085 (Eileenmcnaughton) [20:17:45] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Truncate civicrm_log table - https://phabricator.wikimedia.org/T245085 (Eileenmcnaughton) Open→Resolved [20:17:47] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Decide what to do about the increasing civi crm db size - https://phabricator.wikimedia.org/T243870 (Eileenmcnaughton) [20:18:03] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, and 7 others: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (Eileenmcnaughton) [20:18:17] (PS14) Jgleeson: Update Adyen to break out into separate PaymentProvider and Api classes. Also map responses sent back from Api to the new PaymentProviderRespone thingy. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) [20:18:25] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, and 7 others: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (Eileenmcnaughton) @LeanneS... [20:20:56] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574549 [20:20:58] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574549 (owner: Eileen) [20:24:48] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Patch-For-Review: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Eileenmcnaughton) @CDenes_WMF - I just deployed what was mer... [20:27:26] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574550 [20:27:38] (Merged) jenkins-bot: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574549 (owner: Eileen) [20:27:56] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574550 (owner: Ejegg) [20:28:45] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574550 (owner: Ejegg) [20:29:50] !log updated Fundraising CiviCRM from 426e3547ca to fffc215e75 [20:29:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:30:03] (CR) AndyRussG: Update Adyen to break out into separate PaymentProvider and Api classes. Also map responses sent back from Api to the new PaymentProviderRes (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [20:36:00] (PS4) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [20:42:40] (CR) Ejegg: [C: -1] "Couple lines not now used in the recurring.inc" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) (owner: Eileen) [20:45:39] (PS5) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [20:55:42] (PS6) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [20:58:42] (PS7) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [21:00:45] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574561 [21:00:55] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574561 (owner: Eileen) [21:05:33] !log civicrm revision changed from fffc215e75 to 87b13fd3b5, config revision is 561ae21f77 [21:05:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:11:11] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (RobH) [21:14:01] (CR) Jgleeson: "Good point on the names. I think I broke the interface initially into finer grained alternatives as not all payment providers have cancel " [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [21:32:27] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: Puppetize squid for proxy use - https://phabricator.wikimedia.org/T244784 (Dwisehaupt) Verified that hosts are starting to pull in freshclam updates through squid after pfw update in T246036 [21:32:59] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: Puppetize squid for proxy use - https://phabricator.wikimedia.org/T244784 (Dwisehaupt) Open→Resolved [21:33:01] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: Research and test software to apply system configuration compliance checks. - https://phabricator.wikimedia.org/T243639 (Dwisehaupt) [21:35:10] fundraising-tech-ops: Restore frdb2001 from backup - https://phabricator.wikimedia.org/T246045 (Dwisehaupt) [21:35:55] Fundraising-Backlog, fundraising-tech-ops: Restore frdb2001 from backup - https://phabricator.wikimedia.org/T246045 (Dwisehaupt) [21:54:30] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint X-rays, Fundraising-Backlog: First Batch of TY Emails Pushed to Gerritt - https://phabricator.wikimedia.org/T238736 (jgleeson) a:jgleeson→None [21:56:31] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Update civi SmashPig extension to be able to charge Adyen recurring - https://phabricator.wikimedia.org/T242278 (jgleeson) a:jgleeson→None [22:02:29] ejegg: I went through the other places where recur.contribution_status_id might be affected that you identified - wondering if there could be anywhere else [22:02:54] (I kinda wanted to convert them to use Civi queries but thought that might be scope creep) [22:05:46] dwisehaupt: can you grab a snapshot of db table sizes - I'll kick off the delete tomorrow so maybe tomorrow am [22:06:17] eileen: sure thing. to be clear, this is just on the civicrm db, yes? [22:07:04] yes - I'll be deleting old contacts - I'm expecting contact tables to reduce in size but some increase in log table sizes - but wanting to quantify [22:08:27] ok. all set. [22:08:33] cool [22:09:10] it's gonna take a while to delete them since I'm doing via php loop [22:09:57] & sadly some contacts will come in during - but we can get some idea [22:11:42] (CR) Ejegg: [C: -1] "PaymentProviderResponse looks good, but PaymentProviderStatus here is duplicating SmashPig\CrmLink\FinalStatus." (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [22:13:37] Thanks eileen, I'm taking another look [22:14:53] eileen: Is there a new official transition diagram for recurring payments in core? [22:15:16] erm - the one we wrote in Barcelona... [22:15:25] specifically, when something is 'Failing' and keeps failing enough times to stop retrying, do we call that 'Failed' or 'Cancelled' [22:15:44] shoot, where did we put that? [22:16:03] gitlab? [22:16:16] we didn't write one .... [22:16:36] hangon there must be a gitlab though [22:18:18] https://github.com/civicrm/civicrm-core/pull/14395 [22:19:18] https://lab.civicrm.org/dev/core/issues/905 [22:22:19] ok, "Failed - we couldn't take payment and we're not going to try again." is on there. [22:22:51] But I guess we can't just switch to using that immediately [22:23:40] since there are some things marked 'Failed' that mean the new 'Failing' [22:24:42] So maybe we do this update in two steps? If so, the patch you have up now looks like a pretty solid step one. Lemme just ogle it in an IDE for a bit [22:25:06] yeah - it's a bit up in the air on that - I think sticking with Cancelled is OK for the medium term [22:25:29] OK, I guess we do record a cancel_reason that helps clarify [22:32:50] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Stop mis-using recurring contribution statuses - notably completed - https://phabricator.wikimedia.org/T244326 (Eileenmcnaughto... [22:33:17] ejegg: I just added a few notes to the phab - mostly for @mbeat's benefit [22:33:23] cool cool! [22:36:16] ejegg: I'm wondering about the civi checks we just saw - ie. php version update & emjoi support. I have 'hushed' the php version update for 1 month & set emoji support to 'remind me never' [22:36:18] so In Progress is the new Completed, and Failed gets gerunded to Failing for accuracy? TY for the details, eileen [22:36:32] MBeat: yep that's pretty much it [22:36:44] ty! [22:37:10] we were misusing 'Completed' & 'In Progress' [22:40:22] also - it should be possible to cancel 'Failing' recurrings & In Progress without any core hacks [22:40:37] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Stop hacking out civi checks - https://phabricator.wikimedia.org/T244324 (Eileenmcnaughton) Open→Resolved [22:40:39] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Eileenmcnaughton) [22:41:08] thanks for the extra cancel superpower, that should come in handy from time to time [22:41:23] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Stop hacking out civi checks - https://phabricator.wikimedia.org/T244324 (Eileenmcnaughton) I just 'hushed' emoji support chec... [22:42:33] lol - what a superpower [22:58:09] (PS8) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [22:58:11] (PS10) Eileen: Get rid of old review tags. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/573055 (https://phabricator.wikimedia.org/T245577) [23:07:34] eileen: oops, just saw your comment about the checks. So we do have an outdated php version! [23:07:53] Do you think we should do anything differently? [23:08:10] yep - not unsupported as yet - but I asked Jeff / Dallas & our update is iminent I think [23:09:14] I think we can just monitor the checks for now - if users see confusing checks we can either a) hush / disable more of them or b) go down this path https://github.com/civicrm/civicrm-core/pull/16482 [23:13:29] ooh, interesting [23:16:24] (PS1) Eileen: Merge sendannualttyemail with wmf_thankyou [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574601 (https://phabricator.wikimedia.org/T245580) [23:18:00] ejegg: I just did the merge on the thank you extension - I'm gonna test on staging - would be nice to get that feature out - but it's late in the day for you too [23:19:37] eileen: Oh, I got started very late today [23:19:44] I'll be working for another few hours [23:19:45] :-) [23:19:53] ah cool - [23:21:07] Do we want to mess with the safety checks in is_found_globalcollect_invalid_next_sched_dates ? [23:21:19] Looks like that has a couple of contribution_status_ids hardcoded [23:22:19] Just trying to think hard about this patch since it's affecting recurring payments [23:22:35] yeah - I'm glad you are ! [23:22:42] we'll definitely want to run all the related jobs on slow start for a bunch of rounds after deploy [23:22:46] because I don't know all the places it could affect [23:25:02] ahh, we need to update recurring_globalcollect_get_failure_retry_batch in recurring_globalcollect_common.inc [23:25:28] just needs the same treatment as the similar fn in the smashpig extension (accept both 'failed' and 'failing') [23:25:55] so hard coded are cancelled & failed [23:26:01] so add in failing I guess [23:26:35] I guess? [23:26:52] yeah, ok, sounds right [23:28:31] Wikimedia-Fundraising-Banners: Large CC payment button on Safari Mobile 9.0 and earlier - https://phabricator.wikimedia.org/T240730 (jbolorinos-ctr) This bug will also be affecting our Big Bundle campaign, is there any way to check for device usage by country? Maybe in certain countries the usage stats of Sa... [23:28:35] (PS9) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [23:28:53] I added it in ejegg - I didn't cleanup the hard coding [23:28:57] thanks [23:29:20] OK, finding little things like comments that are now wrong and misleading. Will note them in gerrit [23:30:16] So wait, are contribution_recur rows being created as 'In Process' ? [23:30:37] I don't see us setting the status on create [23:32:33] hmm, no, they're still getting created as 'Completed' [23:32:46] do we want to fix that here too? Or in a later patch? [23:34:13] Really they should be 'Pending' until the first contribution is received & then 'In Progress' until they end one way or another - with brief stints in 'Processing' [23:34:58] However, the create-as-Completed shouldn't cause any actual problems at this stage as we are still treating Completed as In Progress for transitional reasons [23:37:17] I would probably leave the create-as completed for this patch [23:38:29] okok [23:41:50] (CR) Ejegg: [C: -1] "the GlobalCollect function to lock a record as processing needs an update, and there's an outdated status list in a comment" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) (owner: Eileen) [23:46:05] (PS10) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [23:50:38] ejegg: I updated 2 of those things - I started on the status one but I'm wondering if it should be in code or I should create a page in docs & link to it [23:54:15] (PS11) Eileen: Update contribution recur statuses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/572764 (https://phabricator.wikimedia.org/T244326) [23:54:33] hmm well I've updated for now - will look to remove some of those statuses though [23:56:21] thanks!