[00:29:27] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574901 [00:29:42] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/574901 (owner: Eileen) [00:42:01] (PS1) Ejegg: Update exchange rates before bundle campaign [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/574903 (https://phabricator.wikimedia.org/T244946) [00:42:08] oh hmm, one of those could be truncated [00:43:29] (PS2) Ejegg: Update exchange rates before bundle campaign [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/574903 (https://phabricator.wikimedia.org/T244946) [00:48:05] (CR) Ejegg: [C: +2] Update exchange rates before bundle campaign [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/574903 (https://phabricator.wikimedia.org/T244946) (owner: Ejegg) [00:48:07] !log civicrm revision changed from bec2d6ad9f to 62e62e107c, config revision is c0ef31e2fd [00:48:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:48:27] fr-tech I just self-merged that as it's generated code [00:48:33] and the numbers look reasonable [00:49:09] I'm gonna make a quick lib update for SmashPig so we can have updated currency rates for the bundle campaign [00:49:11] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Drop old messages from queue2civicrm_log - https://phabricator.wikimedia.org/T245844 (Eileenmcnaughton) @ejegg I have deployed this but not run the script as yet [00:49:55] ejegg: I just deployed that patch ^^ - I wasn't sure if you wanted to get db size info before & after from dwisehaupt so I haven't tried to run [00:50:04] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Drop old messages from queue2civicrm_log - https://phabricator.wikimedia.org/T245844 (Ejegg) Thank @Eileenmcnaughton ! I'll figure out the initial run and scheduled j... [00:50:19] eileen: oh cool! [00:50:43] Yeah, it'll take a tiny bit of code to run that initial truncate loop [00:50:51] counting back from 2000 days to 90 [00:51:05] but I should be able to do that tomorrow [00:51:08] well - yeah - of you can just try with 2000 on the command line & see how it goes [00:51:28] probably you can run half a dozen times manually & get the worst of it done [01:01:51] oh yeah, we can run drush jobs ourselves without setting up a wrapper command [01:02:01] in that case, I might do it tonight! [01:02:14] I'll take dwisehaupt's 53GB as a 'before' figure [01:02:52] just happen to be on. i could get you a reading now. [01:03:10] sure, just that same drupal.queue2civicrm_log table... [01:03:23] imagine it hasn't grown by much in the last few days! [01:05:04] still 53G [01:05:11] 55242828 bytes to be exact. [01:05:56] hehe, thanks! [01:05:59] (PS1) Ejegg: Update vendor dir for SmashPig update [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/574905 [01:06:14] np. [01:06:25] now to start making pancakes for dinner. [01:06:26] ok, I'll push those currency rates out and then take a look at cutting that size down a bit [01:06:31] bon apetit! [01:07:30] (CR) Ejegg: [C: +2] Update vendor dir for SmashPig update [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/574905 (owner: Ejegg) [01:11:15] pancake dinner sounds great [01:13:37] (Merged) jenkins-bot: Update vendor dir for SmashPig update [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/574905 (owner: Ejegg) [01:15:01] !log updated payments-wiki from c3ca3ad6a7 to bfae734204 [01:15:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:17:16] Fundraising Sprint Dampness, Fundraising-Backlog: Incorrect currency conversion amounts on Paypal payment form (USD only countries) - https://phabricator.wikimedia.org/T244946 (Ejegg) @Dstrine this was simple but involved a change to SmashPig, so I wanted to get it out before the more complicated changes... [01:17:55] Fundraising Sprint Dampness, Fundraising-Backlog: Incorrect currency conversion amounts on Paypal payment form (USD only countries) - https://phabricator.wikimedia.org/T244946 (Ejegg) @jbolorinos-ctr this is deployed to payments-wiki [01:18:30] huh, still running the 2000 days deletion... [01:18:46] crud, i forgot to check if that timestamp column was indexed! [01:20:30] whew, it is. I guess it's just a huge table in any case [01:28:52] done! 17 minutes to delete 13M rows [01:29:10] maybe 100 days at a time [01:35:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1490 [01:37:09] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1609 [01:37:15] PROBLEM - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1612 [01:41:09] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1849 [01:41:49] guessing that replication slowness has to do with all these rows I'm deleting [01:42:54] ejegg: it on the bright side it will speed up [01:45:15] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 8275554 Threads: 2 Questions: 1580062900 Slow queries: 715952 Opens: 1694250 Flush tables: 1 Open tables: 200 Queries per second avg: 190.931 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 292 [01:46:48] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (wiki_willy) [01:47:09] RECOVERY - check_mysql on frdb1003 is OK: Uptime: 9641 Threads: 1 Questions: 11707659 Slow queries: 0 Opens: 757 Flush tables: 1 Open tables: 734 Queries per second avg: 1214.361 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 411 [01:47:15] RECOVERY - check_mysql on frdb1001 is OK: Uptime: 1240917 Threads: 55 Questions: 69826765 Slow queries: 1610 Opens: 61161 Flush tables: 1 Open tables: 772 Queries per second avg: 56.270 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 414 [01:48:50] ejegg: are we abusing the installments field for ingenico? [01:49:07] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw:fundraising single-cpu misc servers - https://phabricator.wikimedia.org/T244950 (wiki_willy) [01:49:39] that's why it wound up 'completed' [01:49:56] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need by: ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (wiki_willy) [01:50:20] eileen: oho, really? [01:50:26] OK, I guess we need to change that [01:50:32] so installments is supposed to be intent [01:50:34] but let's do that after the current recurring work [01:50:46] but we are using it as a shortcut for counting installments so far [01:51:06] re after current recurring work - what counts as 'current recurring work' [01:51:24] The stuff Jack and Andrew are doing to get Adyen recurring to work [01:52:48] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (wiki_willy) [01:53:32] otoh eileen, if you want to change that I bet we could do it really quick and not disrupt them [01:53:39] so let's see what we're using installments for [01:54:31] we are using it like a unique indicator for the trxn [01:55:02] hmm, but we're not really using it for anything outside of civi [01:55:16] no I don't think so - just to track recurings [01:55:16] I guess we could just stop messing with it entirely [01:55:34] It's because we have one trxn_id for many payments isn't i8t? [01:55:36] ohhh, but for the old globalcollect we DO use it to set the effort_id, right? [01:55:57] ah no, we're using the processor_id field for that [01:56:08] so we have [01:56:08] 'effort_id' => $recurringPayment['installments'] + 1, [01:56:10] which I always thought was wrong, but might be OK [01:56:17] yeah, I don't think we really need that [01:56:28] We don't need effort_id at all? [01:56:42] or we can just calc it on the fly? [01:57:07] I think we don't actually need it at all! [01:57:22] I see a bunch of things setting it, but nothing except tests seem to really read it [02:02:21] (PS1) Eileen: Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) [02:02:37] ejegg: so those look like the most obvious places https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/574909 [02:06:01] what's up with that audit log error? [02:08:50] (CR) jerkins-bot: [V: -1] Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) (owner: Eileen) [02:09:06] eileen: it's T245749 [02:09:07] T245749: BPay transaction crashing Ingenico audit parser - https://phabricator.wikimedia.org/T245749 [02:10:08] ah ok [02:11:09] RECOVERY - check_mysql on frdb2002 is OK: Uptime: 1326743 Threads: 1 Questions: 75640180 Slow queries: 839 Opens: 61184 Flush tables: 1 Open tables: 769 Queries per second avg: 57.011 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 472 [02:12:11] (PS2) Eileen: Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) [02:13:16] (PS3) Eileen: Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) [02:16:01] ok, got that table down to size. I'll set up the job now [02:19:23] (CR) jerkins-bot: [V: -1] Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) (owner: Eileen) [02:19:29] cool [02:20:59] hourly should be plenty frequent for that one [02:22:20] it's pushed up to the localsettings repo in case you want to take a look before I start it running [02:22:24] eileen ^^ [02:27:18] ejegg: looks fine [02:27:29] thanks! [02:29:45] (PS4) Eileen: Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) [02:30:13] I've updated the installments removal - maybe you can take a look & have a think about it tomorrow [02:30:24] thanks for clearing my review q! [02:31:21] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Drop old messages from queue2civicrm_log - https://phabricator.wikimedia.org/T245844 (Eileenmcnaughton) Open→Resolved [02:31:21] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Decide what to do about the increasing civi crm db size - https://phabricator.wikimedia.org/T243870 (Eileenmcnaughton) [02:35:30] heh, it's nice to have that done! [02:35:51] okok, I need to review some jgleeson stuff next [02:38:03] (PS2) Ejegg: Move FinalStatus to Core [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/574874 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [02:38:53] (CR) Ejegg: [C: +2] "This does feel like a better place for it. I'm a bit torn about adding more downstream work right now, but let's go for it. TODO: move Val" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/574874 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [02:39:00] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, and 2 others: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (Eileenmcnaughton) @MBeat33 thi... [02:39:13] (Merged) jenkins-bot: Move FinalStatus to Core [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/574874 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [02:39:47] (PS15) Ejegg: Add PaymentProviderResponse to help normalize repsonses across providers. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [02:39:53] (CR) Ejegg: [C: +2] Add PaymentProviderResponse to help normalize repsonses across providers. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [02:40:14] (Merged) jenkins-bot: Add PaymentProviderResponse to help normalize repsonses across providers. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567137 (https://phabricator.wikimedia.org/T243340) (owner: Jgleeson) [02:59:39] (CR) Ejegg: [C: -1] "This is looking pretty good! I think we just want to move those ...Response classes to a neutral namespace, since they have no Adyen-speci" (5 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [13:56:55] Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: Refining is failing to refine centranoticeimpression events - https://phabricator.wikimedia.org/T244771 (Ottomata) Ah Nuria, sorry I !logged in #wikimedia-analytics IRC and expected it to get posted here (like -opereations does). Th... [15:13:47] Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: Refining is failing to refine centranoticeimpression events - https://phabricator.wikimedia.org/T244771 (Ottomata) Ok fixed. The problem was that even though the table had the correctly ALTERed schema, each pre-existing partition st... [15:26:37] (CR) Ppchelko: [C: +2] Replace usage of deprecated Page in favor of WikiPage/Article [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573604 (https://phabricator.wikimedia.org/T239975) (owner: Art-Baltai) [15:31:16] fr-tech in vagrant, do I have to do anything special to update the version of Smashpig that vagrant's Civi uses? [15:31:38] i.e. to work on civi accessing the versions of Smashpig currently unmerged in Gerrit [15:37:02] AndyRussG: you can just go into the vendor dir, delete the SmashPig dir, and clone the SmashPig repo down [15:37:12] oh wait, it's already installed via git [15:37:28] can you just use normal git commands to pull patches in review? [15:40:49] ejegg: so in srv/org.wikimedia.civicrm/vendor/wikimedia/smash-pig, right? [15:40:58] yep! [15:42:21] ejegg: yay! That worked! [15:42:27] :) [15:42:30] thanks much :) [15:45:20] AndyRussG: sometimes I just rename the composer installed Smashpig package to SmashPig_bk and then symlink to srv/SmashPig if I wanna test out my local dev SmashPig changes in another project like civi [15:46:23] oh hey also sounds good jgleeson thx! [15:46:29] that also makes it easier to use xdebug and then come back to the srv/SmashPig project if I wanna debug the full end-to-end process [15:47:36] jgleeson: so you can run XDebug in your host IDE on command-line scripts running in vagrant, ye? I think maybe I remember a Phab task where you talked about how to do that? [15:48:06] yup! [15:48:21] hmmm phab task [15:48:30] or some doc for it somewherez? [15:49:18] (Merged) jenkins-bot: Replace usage of deprecated Page in favor of WikiPage/Article [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573604 (https://phabricator.wikimedia.org/T239975) (owner: Art-Baltai) [15:49:56] it may have been on one of the wikis [15:50:03] lemme see [15:55:59] AndyRussG: maybe it was this abandoned patch? https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/502495/8/puppet/modules/php/manifests/xdebug.pp [15:57:27] there's a few comments in the xdebug puppet class on that patch about settings specific to cli debugging [15:58:55] that patch was intended to build xdebug for us during a period when it wasn't available on jessie I think? [15:59:07] but then it became available and got abandoned [15:59:39] maybe it was stretch [16:02:23] sorry to be clear that patch wasn't abandoned it was reverted here https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/506121/ due to discussion on this ticket https://phabricator.wikimedia.org/T220406#5134185 [16:06:11] Fundraising-Backlog: donate.wiki FAQ page browser scroll issue - https://phabricator.wikimedia.org/T246239 (MBeat33) [16:08:03] hmmm maybeeeee [16:09:22] jgleeson: it was a link Dylan had.... [16:11:50] Fundraising-Backlog: donate.wiki FAQ page browser scroll issue - https://phabricator.wikimedia.org/T246239 (DStrine) @Pcoombe and @jbolorinos FYI [16:23:02] ah! ok AndyRussG [16:23:48] reach out if you run into any problems! [16:24:59] Fundraising-Backlog, Analytics, Analytics-Kanban, Patch-For-Review: Turnilo no longer showing sample-rate adjusted data for banner activity - https://phabricator.wikimedia.org/T241162 (Milimetric) [16:25:14] Fundraising-Backlog, Analytics, Analytics-Kanban, Patch-For-Review: Turnilo no longer showing sample-rate adjusted data for banner activity - https://phabricator.wikimedia.org/T241162 (Milimetric) a:Milimetric [16:26:05] AndyRussG: maybe this link: https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Advanced_usage#MediaWiki_debugging_using_Xdebug_and_an_IDE_in_your_host [16:29:21] fr-tech any scrum of scrums news? [16:36:28] ejegg: thanks... it was something fr-specific... also, no SoS news here [16:38:14] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Papaul) @Jgreen i already have a task (T244950) to track this down can we declined this and tack it in T244950 or do you want... [17:01:02] (PS18) Jgleeson: Break up Adyen into separate PaymentProvider and Api classes. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) [17:04:40] (CR) Jgleeson: "I moved all the response classes into the neutral namespace which also makes sense to me. I added the response typehints, nice catch!. I l" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [17:07:35] (PS19) Jgleeson: Break up Adyen into separate PaymentProvider and Api classes. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) [17:09:37] picking up oscar back soon! [17:40:19] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need by: ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Jgreen) a:Jgreen→Dwisehaupt Reassigning to Dallas since he's doing all the work! [17:43:09] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need by: ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Papaul) @Jgreen @Dwisehaupt can we resolve this task since it is a rack/setup task for dc-ops and open another task to track the work that left to be done?... [17:48:27] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need by: ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Dwisehaupt) @Papaul I'm fine with that. @Jgreen The last bit on this checklist is moving the host to staged in netbox. I just checked and I don't appear t... [17:54:07] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need by: ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Papaul) @Dwisehaupt the last step is to move the host to online and not staged. staged is after the first puppet run. once the host is live and in producti... [18:01:46] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need by: ASAP) rack/setup/install frdb2001 - https://phabricator.wikimedia.org/T245566 (Dwisehaupt) @Papaul Good to know. It can be moved to online at this point. The host has gotten it's puppet runs and is in the process of getting the db res... [18:14:10] jgleeson: was what you pasted in standup chat the response from the patches you were working on? [18:18:18] Fundraising Sprint Dampness, Fundraising-Backlog: Incorrect currency conversion amounts on Paypal payment form (USD only countries) - https://phabricator.wikimedia.org/T244946 (jbolorinos-ctr) Thanks so much @Ejegg, this is great! [18:30:51] cstone: it was the response form the TestAdyen script we added [19:20:09] oops did someone say jack just as I left? [19:23:25] haha it was me but its fine [19:23:36] sorry, want me to pop back in the chat? [19:23:44] nah I figured it out [19:24:00] ah cool [19:40:32] dwisehaupt: if you can take another snapshot of the table sizes I will compare to before I started deleting (about 500k records gone now) [19:40:58] sure thing. [19:42:00] just so i'm 100% on it, this is for the drupal db, yes? [19:43:57] no the civi one [19:44:09] ok. that's why i asked. :) [19:44:16] maybe drupal too since ejegg dropped from there :-) [19:44:44] (but not as one number since apples) [19:45:11] ok. i grabbed both, just in case. [19:46:30] cool - did you put them in that spreadsheett? [19:46:47] i did not. i'll get to that. [19:50:40] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, and 2 others: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (Eileenmcnaughton) @MBeat33 that... [19:57:45] dwisehaupt: for drupal, i only touched that queue2civicrm_log table [20:17:53] Wikimedia-Fundraising-Banners: Misplaced Currency Symbol on Desktop Large - Nag banner in Hebrew - https://phabricator.wikimedia.org/T242395 (Pcoombe) I'm not sure how to fix this until we have the translations input. @TSkaff do you have an eta for that? [20:36:46] ejegg: yes. to reclaim the space in that table, we're going to have to either optimize the table or do the sneaky alter "ENGINE=InnoDB" trick. the downside to the optimize is that it will lock the table for writes. [20:57:13] I think we can just turn off the job while you do that [21:02:40] dwisehaupt: should I be able to see the table sizes in the spreadsheet now? [21:33:41] (CR) Ejegg: [C: -1] "This looks great! Just needs that old AdyenResponse deleted." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [21:35:51] eileen: sorry, not yet. been working on something else. [21:35:52] hmm, I might just make a quick edit on that patch - deleting a file [21:41:47] Wikimedia-Fundraising-Banners: Legal Text does not align right to left on Desktop Large Banner - https://phabricator.wikimedia.org/T242391 (Pcoombe) a:Pcoombe @jbolorinos-ctr This should be fixed now, please can you confirm? https://he.wikipedia.org/?banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL [21:44:50] Wikimedia-Fundraising-Banners: PTF Checkbox does not align right to left on Desktop Small Banner - https://phabricator.wikimedia.org/T242389 (Pcoombe) a:Pcoombe @jbolorinos-ctr This should be fixed now, please can you confirm? https://he.wikipedia.org/?banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL I a... [21:45:20] Wikimedia-Fundraising-Banners: frb-greeting does not align right to left on Desktop Large - https://phabricator.wikimedia.org/T242388 (Pcoombe) a:Pcoombe @jbolorinos-ctr This should be fixed now, along with the rest of the text. Please can you confirm? https://he.wikipedia.org/?banner=B1920_0301_mlWW_dsk... [21:48:59] (PS21) Ejegg: Break up Adyen into separate PaymentProvider and Api classes. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/567141 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [22:00:10] dwisehaupt: I'm guessing it takes some mucking around for you to get it into spreadsheet form - if you can just dump those 2 snapshots you took into something I can format into the sheet - I've got another cleanup just about done so would want one more snapshot to see the impact of that [22:00:35] Wikimedia-Fundraising-Banners: frb-greeting does not align right to left on Desktop Large - https://phabricator.wikimedia.org/T242388 (jbolorinos-ctr) Hey @Pcoombe, Thanks so much for all your help! I'm verifying now that this is fixed. {F31645728} Closing as resolved [22:00:42] Hmm - it would be interesting to be able to expose this to grafana - should I make a task for that? [22:01:03] Wikimedia-Fundraising-Banners: frb-greeting does not align right to left on Desktop Large - https://phabricator.wikimedia.org/T242388 (jbolorinos-ctr) Open→Resolved [22:05:15] ok - entity_tag deletion done [22:17:59] ejegg: I think this is OK to remove installments - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/574909/ - [22:18:04] Wikimedia-Fundraising-Banners: PTF Checkbox does not align right to left on Desktop Small Banner - https://phabricator.wikimedia.org/T242389 (jbolorinos-ctr) Hey @Pcoombe That's so interesting, so the checkbox must be aligned RTL but not the checkmark itself? So weird!!! Anyways, I was able to verify the... [22:18:28] oh yep [22:20:42] just looking at effort_id - it seems to be used by the old recurring but not much else (although there are lots of references to it) [22:21:14] (PS5) Eileen: Remove setting of installments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/574909 (https://phabricator.wikimedia.org/T244326) [22:29:49] Wikimedia-Fundraising-Banners: Legal Text does not align right to left on Desktop Large Banner - https://phabricator.wikimedia.org/T242391 (jbolorinos-ctr) Open→Resolved Hey @Pcoombe, Yeah this looks great now! Fix verified (legal text now aligns correctly from RTL). {F31645759} Closing as resolved [22:34:31] (CR) Eileen: "ejegg so background questions" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564274 (owner: Ejegg) [22:38:08] eileen: i just dropped three files in /tmp on frdev: civicrm_db_sizing_20200224 civicrm_db_sizing_20200226 civicrm_db_sizing_20200226_after_entity_tag [22:38:20] thanks dwisehaupt [22:38:25] that'll give the sizes of the .ibd files. [22:39:38] cool [22:42:02] there is the possibility that some of the space saving won't happen until the table is optimized/defragged but that should stand out in the numbers. [22:46:59] Fundraising-Backlog, donate.wikimedia.org: donate.wiki FAQ page browser scroll issue - https://phabricator.wikimedia.org/T246239 (jbolorinos-ctr) Thanks for the ping @dstrine... although just for future reference I use the @jbolorinos-ctr account here instead of @jbolorinos (which I setup during my inter... [23:01:23] dwisehaupt: yeah the numbers haven't gone down at all [23:01:32] https://www.irccloud.com/pastebin/BWRTPBju/ [23:06:03] I get different values [23:19:53] hmm - turns out that gets inntermitttently updated [23:22:57] yeah. i see 29504 MB when using du and dividing the byte count by 1024. [23:24:39] dwisehaupt: so all the files you put on staging have civicrm_contact table as 30212112 [23:24:50] has it shrunk since then? [23:25:14] no [23:25:45] OK - so it looks like Optimize reclaims space - does that normally run at all? [23:26:02] optimize doesn't run regularly since it causes a write lock. [23:26:24] so we need to schedule it? [23:26:24] we can do an alter on the table that can run without that lock. [23:28:01] https://mariadb.com/kb/en/innodb-online-ddl-operations-with-the-inplace-alter-algorithm/#alter-table-engineinnodb [23:28:37] that allows us to run an alter on the table with the same innodb engine and it will do the same thing as an optimize without causing the lock issue. [23:29:03] we can do this whenever, but is generally done best when not at peak times. [23:29:35] if we do it on the master, it will take effect on the slaves also. [23:30:27] if they table were significantly large, we'd probably do it on the replicated hosts, then do a master swap, and then do the last host. but that would be a more extreme case. [23:31:40] dwisehaupt: so my feeling is that we should let the script to delete old contacts keep running (it's done about 1 m out of 6 for this first round) and then maybe schedule an outage next week to give us space to try these things [23:32:09] yeah, i agree that completing the deletion is the right route. [23:32:50] we won't necessarily need an outage if we go with the alter, but scheduling it so that we are aware and keep an eye on it is a good thing. [23:33:04] I was hoping to see what the 'progress is' - I can see it has added to the log tables (which I expected) but I wanted to see how the log-table-add compared with the saved-space in the main tables [23:33:25] but yeah - let's plan for next week [23:33:57] I think it will be sloooowww - during the last upgrade we added columns to some tables & that took about 20 mins+ per table on the big tables [23:34:27] & it won't be just the contact table affected - also activity, activity contact, wmf_donor [23:36:17] yeah. [23:36:44] this is something that should be part of semi regular maintenance with higher churn tables. [23:37:34] in addition to the optimize and alter options, we could also do a mysqldump/restore of the tables in question. [23:40:16] doing deletes is creating churn - I would expect doing that would defrag them a bit [23:41:06] I was just trying a query I found on staging but it queries the mysql db & I see no tables in that db - is that because I don't have SELECT on the tables in that DB [23:41:32] Also - if we do an outage - how long should we make it? [23:42:06] I feel like it's the sort of thing that would ideally be done 2-3 monthly with one planned for say Sep in prep for BE [23:43:01] re staging, yes, general users do not have access to the mysql db, even for select. [23:43:36] hmm - are you able to give me select access to it? [23:44:10] re outage for an optimize/alter, the only way to answer that would be to test on one of the replicas and get timing. at least that's how i'd feel comfortable with giving a number. [23:44:29] that sounds like a good idea [23:46:38] re staging: what are you looking for in the mysql tablespace. [23:48:10] not trying to be obtuse, just i've been reworking the grant scripts and want to make sure i'm covering what i need to in there. [23:50:11] looks like this is the table - FROM mysql.innodb_index_stats [23:50:23] https://stackoverflow.com/questions/781873/how-to-figure-out-size-of-indexes-in-mysql [23:59:24] try it now.