[03:35:30] (PS1) Ejegg: WIP Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) [03:35:51] (CR) jerkins-bot: [V: -1] WIP Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [11:17:21] Wikimedia-Fundraising-Banners: PTF Checkbox does not align right to left on Desktop Small Banner - https://phabricator.wikimedia.org/T242389 (Pcoombe) Open→Resolved [14:33:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (MBeat33) Sandra made the great point that in order to work as a tax receipt, TY emails may need to have to show the donor's **full name**. For US a... [14:37:37] (CR) Jgleeson: [C: +2] Move FinalStatus and ValidationAction to PaymentData [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575267 (owner: Ejegg) [14:38:05] (Merged) jenkins-bot: Move FinalStatus and ValidationAction to PaymentData [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575267 (owner: Ejegg) [14:44:58] (CR) Jgleeson: "I noticed when testing with Adyen that a SoapFault is thrown if you enter random characters in the place of trxn ids. The exception messag" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [14:52:08] (CR) Jgleeson: Ignore authorization IPN messages from recurring Adyen donations. (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [14:56:24] (CR) Ejegg: "We do have a ValidationError class that includes a field name property. Maybe it should extend PaymentError, though, so we can add it to t" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [14:56:53] (CR) Ejegg: "Instead of being its own class, these COULD just be constants on PaymentError" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [14:58:41] (CR) Jgleeson: "Yeah I feel like that brings everything together that way" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [14:59:15] (CR) Jgleeson: "actually do you mean constants on ErrorCode?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:01:15] ejegg|away: I was envisioning that the error code would indicate that it was a validation error and then then message would be populated in PaymentError [15:01:25] from your suggestion [15:08:16] RECOVERY - check_mysql on payments2003 is OK: Uptime: 61922 Threads: 10 Questions: 12 Slow queries: 0 Opens: 16 Flush tables: 1 Open tables: 10 Queries per second avg: 0.000 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [15:11:51] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11: Problem with card logo spacing on mobile large - https://phabricator.wikimedia.org/T209996 (Pcoombe) Open→Resolved a:Pcoombe Fixed in mobile large with [this change](https://meta.wikimedia.org/w/index.php?title=MediaWiki:... [15:14:29] Wikimedia-Fundraising-Banners: Large CC payment button on Safari Mobile 9.0 and earlier - https://phabricator.wikimedia.org/T240730 (Pcoombe) @jbolorinos-ctr I noticed the same was occurring on mobile small too. Should be fixed with these changes: - [mobile large](https://meta.wikimedia.org/w/index.php?titl... [15:25:51] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) @cmjohnson @Jclark-ctr could someone do the final bits on this task so we can finish the deploy? This host arrived nearly 6 months ago! [15:36:52] (CR) Ejegg: "No, I meant that these could be constants on PaymentError, like PaymentError::BAD_SIGNATURE" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:38:08] jgleeson: I'm happy to leave the ErrorCode enum its own class, just thinking out loud a bit [15:38:17] oooo I get it now [15:38:22] well, let's leave it as its own class for now [15:38:26] you remove replace BOTH [15:38:31] with consts in PaymentError [15:38:40] -remove [15:38:59] So I feel like ValidationError is properly its own class [15:39:08] with a property to indicate which field has the error [15:39:25] that feel like an important thing to be able to indicate programatically, i.e. not just in a message [15:39:42] strictly speaking, any messages in SmashPig should just be for logging [15:40:45] and the presentation layer should use the error code, and field name to decide which message to show [15:41:14] then use its own i18n logic to show it in the right language [15:42:23] anyway, I should add some of these speculations as code comments so we're more likely to revisit them after some actual use of the code [15:52:34] fr-tech hi!! can someone explain to me what this does, in civi? $recurringPayments = civicrm_api3('ContributionRecur', 'get', [ .... [15:52:45] Looks like some kind of civi-ish ORM? [15:53:05] SmahsPigRecurringProcessor.php lines 121+ [15:53:13] it's just an API call to get a specific entry from the database [15:53:49] that array can contain both WHERE conditions and special options like limits, only return certain fields, etc [15:57:38] ejegg: and so which table is it on? [15:58:41] I guess ContributionRecur = civicrm_contribution_recur? [15:59:24] Also, why does it ask for completed and failed status ones, too? [15:59:48] Mmmm finally, any tips for getting local test data? [16:01:46] AndyRussG: yep, that's correct, civicrm_contribution_recur [16:02:02] okok so it's like some magic automatic mapping I guess [16:02:10] thx :) [16:02:16] AndyRussG: the logic is in the API classes [16:02:36] civi core API classes or stuff we made? [16:02:36] you can take a deep xdebug dive into that call to see all the gory details! [16:02:43] civi core API classes [16:03:02] Ahhh, so if it's only looking for completed and failed, you should git update [16:03:14] eileen added 'in progress' and 'failing' to that list [16:03:26] yes they're there, along with many others [16:03:29] just wondering why though [16:03:54] we had been recording ongoing subscriptions as 'completed' and ones that had failed once or twice (but that we're going to retry) as 'failed' [16:04:16] that's not how core does things, though, so eileen has been tweaking our code to bring it in line [16:04:37] We figured it would be safest to leave the status of existing db rows untouched until they come up for their next charge [16:04:45] where is the list of all available statuses? does that live in some db? are there statuses that we no longer retry? (like "unsalvageable" or something)? [16:04:48] so we're still including the non-standard statuses [16:04:57] 'cancelled' is not salvagable [16:05:13] ah okok [16:05:23] also, populating the end_date field is a way to say Don't make any more charges after X date [16:07:47] (PS3) Ejegg: Add ErrorCode enum to normalize processor errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) [16:07:49] (PS2) Ejegg: Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) [16:15:40] (PS1) Ejegg: Add convenience fn to check for error code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575564 (https://phabricator.wikimedia.org/T243340) [16:16:08] ejegg: I guess the end_date population is something that happens elsewhere, unrelated to the code I'm looking at, no? [16:17:16] (CR) Ejegg: "looks like phpcs just wants lowercase boolean literals to square with mediawiki convention" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/574864 (owner: Mepps) [16:18:40] AndyRussG: ahh, there's also a cancel_date - we might populate that in recordFailedPayment [16:23:01] jgleeson: did you see eileen wants to merge your TY extension in with the one to just re-send individual donation TY emails? https://gerrit.wikimedia.org/r/574601 [16:23:24] I guess she merged that way instead of keeping yours because hers had a more generic name [16:24:26] (CR) jerkins-bot: [V: -1] Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [16:26:22] ejegg: no I hadn't seen that [16:26:31] (CR) jerkins-bot: [V: -1] Add convenience fn to check for error code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575564 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [16:26:55] (PS3) Ejegg: Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) [16:26:57] (PS2) Ejegg: Add convenience fn to check for error code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575564 (https://phabricator.wikimedia.org/T243340) [16:27:59] ejegg: ok thanks... I'm seeing tons of stuff populated by this call: $smashpigProcessors = civicrm_api3('PaymentProcessor', 'get', ['class_name' => 'Payment_SmashPig']); [16:28:21] I guess things are pre-populated for us in vagrant in that regard? [16:28:22] sometimes I'm amazed how I have no memory of things I worked on [16:28:55] how quickly I guess [16:29:13] jgleeson: oh it happens to all of us eh! don't ask me how many times I've googled switch statement formats for like all the languages I "know" [16:29:15] ejegg: none of this code feels familiar [16:29:29] AndyRussG: :) [16:30:24] oh I think mepps also did some work on this [16:30:35] hehe, I guess a lot is also boilerplate generated by civix [16:30:52] There is a bunch of stuff already in civicrm_payment_processor in my vagrant [16:31:21] this hurts my heart https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/550371/14/sites/default/civicrm/extensions/org.wikimedia.sendannualtyemail/tests/CRM/Sendannualtyemail/AnnualThankYouTest.php [16:32:38] oops! [16:35:55] ok that looks +2'able to me [16:36:49] I see you've +2'd the other patches in the chain ejegg [16:40:26] ahh, the ones to make the single-donation TY send, yeah [16:45:07] (CR) Ejegg: Banner templates (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [16:48:08] (CR) Cstone: Ignore authorization IPN messages from recurring Adyen donations. (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [16:48:34] (PS5) Cstone: Ignore authorization IPN messages from recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) [16:49:48] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jclark-ctr) [16:50:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Prepare CN deploy 2020-03 - https://phabricator.wikimedia.org/T246461 (AndyRussG) [16:50:35] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jclark-ctr) configured bios set password @Jgreen [16:54:14] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Papaul) a:Papaul [17:04:56] fr-tech do we have to make some Gerrit change to adyen/main.yaml to include a cc class, like is the case in the for ingenico/main.yaml? [17:05:37] AndyRussG: oh yeah, I can add a quick patch for that [17:07:27] ejegg: I can try... So I guess this is just because we've never charged cc for adyen via Civi before, correct? [17:10:35] yeah ejegg besides the cvv result there is nothing else different in the raw soap between the original recurring charge and a subsequent one :( [17:10:52] (PS1) Ejegg: Add Adyen config for PaymentProviderFactory [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575570 [17:11:04] AndyRussG: OK, ^^^ should do it [17:11:21] I made the change to the maintenance script so you can verify the factory call works [17:11:25] cstone ah damn [17:11:47] I still feel like the additionalData route might be doable [17:11:53] if we could actually get it to work [17:11:56] Yeah, that would be way more reliable [17:11:57] @_@ [17:12:09] OK, gotta relocate [17:12:09] yeah hmmm [17:13:12] (CR) AndyRussG: [C: +2] "Cool, thanks!!!!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575570 (owner: Ejegg) [17:13:39] (Merged) jenkins-bot: Add Adyen config for PaymentProviderFactory [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575570 (owner: Ejegg) [17:13:46] hmm [17:13:52] are recurring payments actually cc? [17:13:58] I guess they're set up with a cc [17:14:11] and subsequent charges are against the same cc [17:14:26] so I guess they are cc [17:14:59] yeah they both return visa in the raw soap [17:21:51] (PS2) Jgleeson: Map Ingenico createPayment response to Response object [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575306 (https://phabricator.wikimedia.org/T244536) [17:22:18] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (RobH) So I'm not familiar with the frack vlans and bonding setup for interfaces. However, if someone can point out a server this should duplicate... [17:23:05] AndyRussG: ^^ that patch should give a Smashpig that sends you back the same response across ingenico and adyen createPayment calls. [17:25:35] wow [17:33:25] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (RobH) Ok, updated the switch (Thanks Arzhel) and put things into the admin vlan to match dns that was already setup. This should be good to from... [17:33:35] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (RobH) [17:35:40] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jclark-ctr) a:Jgreen [17:35:45] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11: dsk lg PTF opens immediately on banner load w/o amount selection - https://phabricator.wikimedia.org/T191417 (Pcoombe) a:Pcoombe Ah ha, this looks like it could be the problem: https://stackoverflow.com/questions/33320572/interne... [17:37:52] Fundraising-Backlog, fundraising-tech-ops: Audit mysql grants and ensure the grant scripts reflect the current reality - https://phabricator.wikimedia.org/T243342 (Dwisehaupt) Audit has been run on all of the scripts and it has been merge into master. There are just a few user/password combos that need a... [18:46:19] Fundraising-Backlog, fundraising-tech-ops: Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) a:Dwisehaupt Approval noted in email. Starting the process. [18:49:24] Wikimedia-Fundraising-Banners: Translation coding issue found on nlBE banners - https://phabricator.wikimedia.org/T246474 (Reedy) [19:02:22] Fundraising-Backlog, fundraising-tech-ops: Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) [19:15:25] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11: dsk lg PTF opens immediately on banner load w/o amount selection - https://phabricator.wikimedia.org/T191417 (Pcoombe) Open→Resolved Fixed with this change: https://meta.wikimedia.org/w/index.php?title=MediaWiki%3ACentralnoti... [19:18:25] Wikimedia-Fundraising-Banners: Translation coding issue found on nlBE banners - https://phabricator.wikimedia.org/T246474 (Pcoombe) This might be correct: https://en.wiktionary.org/wiki/is#Dutch [19:19:40] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Jgreen) [19:20:05] Wikimedia-Fundraising-Banners: Translation coding issue found on nlBE banners - https://phabricator.wikimedia.org/T246474 (Aklapper) > It was noticed during testing today Was that noticed by a Dutch speaker? [19:22:21] Wikimedia-Fundraising-Banners: Translation coding issue found on nlBE banners - https://phabricator.wikimedia.org/T246474 (jbolorinos-ctr) @Aklapper I dont speak Dutch no....this may have been submitted in error, I'm just testing the banners and checking for missing translated text, so that's why I flagged t... [19:25:32] Fundraising-Backlog, fundraising-tech-ops: Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) Hi @CDenes_WMF, The two things we need to do at this point are: * have you generate an ssh keypair * get you a yubikey Instructions for generating the ssh keypair are here: https... [19:26:08] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) [19:38:22] PROBLEM - check_puppetrun on payments2003 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 3 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/etc/rssh.conf],File[/etc/vim/vimrc.local],File[/etc/update-motd.d/99-footer],File[/etc/motd.tail] [19:42:56] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Jgreen) [19:43:16] RECOVERY - check_puppetrun on payments2003 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:47:56] XenoRyet: want to take a look at some of the patches in SmashPig up for CR? [19:48:10] between jgleeson and me there are 4 or 5 ready to look at [19:48:52] Sure. They all in the review column? [19:49:43] they're all here: https://gerrit.wikimedia.org/r/#/projects/wikimedia/fundraising/SmashPig,dashboards/default [19:50:24] ah, that cstone one could use a -1 just while we search for other possibilities [19:50:24] 10-4 [19:50:42] (CR) Ejegg: [C: -1] "Let's find a more solid indicator!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [19:50:49] i think i might have found one testing it now [19:51:19] i turned on all the settings for extra soap data, then turned off ones that werent useful and suddenly theres more recurring info on the first charge [19:51:27] huh [19:51:31] well cool [19:56:16] Actually gotta run a quick errand, then I'll look when I get back. [20:07:38] (PS6) Cstone: Ignore authorization IPN messages from recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) [20:08:20] (CR) jerkins-bot: [V: -1] Ignore authorization IPN messages from recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [20:09:18] ok that works for me in testing, the first charge will return a recurring.recurringDetailReference while subsequent ones dont return that [20:12:26] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11: dsk lg PTF opens immediately on banner load w/o amount selection - https://phabricator.wikimedia.org/T191417 (spatton) Nice fix @Pcoombe, I remember us first catching that issue in the last bundle QA; it's nice to see stackoverflow c... [20:16:57] cstone that sounds great! [20:17:13] i left out a piece in that patch fixing it now [20:26:09] (PS7) Cstone: Ignore authorization IPN messages from recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) [20:26:36] (CR) jerkins-bot: [V: -1] Ignore authorization IPN messages from recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [20:33:17] Wikimedia-Fundraising-Banners: Translation coding issue found on nlBE banners - https://phabricator.wikimedia.org/T246474 (Aklapper) Open→Invalid a:TSkaff→None Thanks for clarifying. In that case I do not see a bug here. :) [20:38:18] PROBLEM - check_puppetrun on payments2003 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 2 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/etc/rssh.conf],File[/etc/vim/vimrc.local],File[/etc/update-motd.d/99-footer],File[/etc/motd.tail] [20:43:16] PROBLEM - check_puppetrun on payments2003 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 7 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/etc/rssh.conf],File[/etc/vim/vimrc.local],File[/etc/update-motd.d/99-footer],File[/etc/motd.tail] [20:48:16] RECOVERY - check_puppetrun on payments2003 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [21:03:23] (CR) XenoRyet: [C: +2] Add ErrorCode enum to normalize processor errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:03:27] (CR) XenoRyet: [C: +2] Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:03:30] (CR) XenoRyet: [C: +2] Add convenience fn to check for error code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575564 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:03:48] (Merged) jenkins-bot: Add ErrorCode enum to normalize processor errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575272 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:03:51] (Merged) jenkins-bot: Normalize Adyen response errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575399 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:03:54] (Merged) jenkins-bot: Add convenience fn to check for error code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575564 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:08:32] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Jgreen) We're seeing an odd warning/error about bond0/eno2 on the new payments2003: [ 13.843817] bond0: invalid new link 3 on slave eno... [21:11:56] fundraising-tech-ops, Operations, ops-codfw: new payments2003 bonded ethernet network error/warning - https://phabricator.wikimedia.org/T246492 (Jgreen) [21:25:16] fundraising-tech-ops, Operations, ops-codfw: new payments2003 bonded ethernet network error/warning - https://phabricator.wikimedia.org/T246492 (Jgreen) ACPI: Added _OSI(Linux-Lenovo-NV-HDMI-Audio) tg3.c:v3.137 (May 11, 2014) tg3 0000:04:00.0 eth0: Tigon3 [partno(BCM95720) rev 5720000] (PCI Express)... [21:30:19] (PS3) Ejegg: Map Ingenico createPayment response to Response object [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575306 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [21:31:13] (CR) Ejegg: [C: +2] "This is a good start to build on." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575306 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [21:31:36] (Merged) jenkins-bot: Map Ingenico createPayment response to Response object [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575306 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [22:11:04] (CR) XenoRyet: [C: +2] "Looks like Ejegg beat me to it by a bit, but in the spirit of more eyes are better, it gets my +2 as well." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575306 (https://phabricator.wikimedia.org/T244536) (owner: Jgleeson) [22:17:13] Fundraising-Backlog, FR-Ingenico, Fr-planning-ahead, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (Ppena) @DStrine and @Ejegg can we regroup for this phab sooner versus later? We would like to test a small cohort fir...