[01:02:08] (CR) DannyS712: [C: +1] "LGTM" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/575727 (owner: Umherirrender) [01:34:59] (PS1) AndyRussG: Make Ingenico PaymentProvider implement IPaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T243340) [01:35:54] (CR) jerkins-bot: [V: -1] Make Ingenico PaymentProvider implement IPaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T243340) (owner: AndyRussG) [05:49:03] (PS2) AndyRussG: Make Ingenico PaymentProvider implement IPaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 [06:27:57] (CR) Zoranzoki21: [C: +1] "I think that this is patch with the most +1's, someone should +2 this :)" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/575727 (owner: Umherirrender) [06:48:46] (PS1) AndyRussG: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 [06:50:53] (CR) jerkins-bot: [V: -1] Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (owner: AndyRussG) [07:34:32] (CR) Thiemo Kreuz (WMDE): [C: +2] Improve param docs [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/575727 (owner: Umherirrender) [07:37:48] (Merged) jenkins-bot: Improve param docs [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/575727 (owner: Umherirrender) [07:37:50] (Merged) jenkins-bot: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/575794 (owner: Zoranzoki21) [11:40:17] Fundraising-Backlog, Phabricator: Please adapt Phabricator ACLs for "acl*WMF-FR" - https://phabricator.wikimedia.org/T246648 (Aklapper) Thanks for filing this, Moritz. The problem is that currently the only people with "Can Edit" capability are @DStrine and `@atgo`. @DStrine: On an related note, could y... [14:31:13] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Dampness, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Show selected countries and regions under tree selector - https://phabricator.wikimedia.org/T243012 (Sarahi) p:Triage→High [15:07:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue (Tracking), Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q3): Safari crashes on some click handling events for banners that move the centralNotice element outside o... - https://phabricator.wikimedia.org/T242895 [15:21:39] Fundraising-Backlog, Phabricator: Please adapt Phabricator ACLs for "acl*WMF-FR" - https://phabricator.wikimedia.org/T246648 (DStrine) I have removed the user and added the link to the form in the description. I've had a few conversations with Phabricator admins in the past about this setup. As far as I... [15:22:55] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Dampness, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 4 others: Show selected countries and regions under tree selector - https://phabricator.wikimedia.org/T243012 (DStrine) p:High→Triage [15:59:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue (Tracking), Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q3): Safari crashes on some click handling events for banners that move the centralNotice element outside o... - https://phabricator.wikimedia.org/T242895 [16:05:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi certificate request: Kristie Robinson - https://phabricator.wikimedia.org/T246677 (MBeat33) [16:16:45] Fundraising-Backlog: Fundraising tech engineers should have clear list of regular "chores" - https://phabricator.wikimedia.org/T246678 (mepps) [16:18:22] Fundraising-Backlog: Fundraising tech engineers should have clear list of regular "chores" - https://phabricator.wikimedia.org/T246678 (mepps) https://www.mediawiki.org/wiki/Fundraising_tech/Chores [16:36:44] PROBLEM - Host payments2001 is DOWN: PING CRITICAL - Packet loss = 100% [16:45:34] Fundraising-Backlog, Phabricator: Please adapt Phabricator ACLs for "acl*WMF-FR" - https://phabricator.wikimedia.org/T246648 (Aklapper) Thanks! @Dstrine: https://phabricator.wikimedia.org/project/edit/1070/ still says that only one single active individual (you) can change anything, and I consider that a... [16:48:14] RECOVERY - Host payments2001 is UP: PING OK - Packet loss = 0%, RTA = 36.37 ms [16:55:32] fundraising-tech-ops, Operations, ops-codfw: new payments2003 bonded ethernet network error/warning - https://phabricator.wikimedia.org/T246492 (Jgreen) Just finished imaging payments2001 and it is exhibiting the same behavior. We tested bond0 failover by unplugging eno1 on payments2003 and it fails... [17:14:10] (PS1) Ejegg: WIP map errors on Ingenico response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) [17:14:15] jgleeson ^^^ is the WIP [17:14:25] Definitely needs tests updated [17:16:54] oh weird, maybe not! [17:19:44] (PS2) Ejegg: Map errors on Ingenico createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) [17:19:50] ok, lemme just review your change again [17:20:02] ooh, and Andy's [17:21:58] ok, so I think when the top-levl error status is set there generally isn't a payment object to look at [17:22:07] so I put that into an elseif [17:24:15] hmm, so just how much do we deal with the error codes in DonationInterface [17:24:49] I mean how much do we deal with error codes from approvePayment? [17:25:38] if we get to that point, we've already gotten an authorization [17:27:01] ejegg: it looks like we dont get back a response with 'errors' [17:27:23] in the event that we get a top-line errors key, we throw an api exception [17:27:32] oho? [17:27:45] lemme link you [17:27:58] yep, looking at it now [17:28:11] so I figured we'd get rid of that [17:28:53] and just capture either your missing response message or the error response from ingenico into the response object dependant on which scenario arises [17:29:12] get rid of the ApiExceptions* [17:29:22] ok, got it [17:30:55] also it's probably not a job for now but the fact that we decode the raw json in the ingenico process feels like we've not actually capturing the raw response at the Response level. [17:31:25] I wonder if it would help to remove that decoding at the api lower level and move it higher up incase we ever need to show ingenico exactly what we got from the api [17:31:53] could be... although we might actually be logging stuff at the cURL level [17:32:44] yeah, CurlWrapper can log the full response [17:32:56] ok I'll park that point for now. lemme rebase my changes over your latest patch to see if I can pull in the tests and updates to remove the api exceptions [17:33:00] but it's worth a TODO or FIXME comment [17:33:33] jgleeson: you've got a good point about not needing to handle the top-level bit [17:33:52] let's leave the API exceptions there, and I'll just handle the payment status errors [17:35:07] ah ok [17:35:15] so we want the test to capture the exceptions [17:35:41] we're gonna need another try/catch block in the PaymentProvider methods [17:35:48] around the api calls [17:35:52] if we wanna keep those [17:35:59] I think [17:36:35] (if we wanna capture the exceptions and put them in the Response civi gets back [17:36:37] ) [17:36:55] otherise the raw exception will just bubble up to the client I think [17:37:50] I see what you mean, but maybe we can let it for now? [17:38:04] Were we catching it at the SmashPig level before? [17:38:55] I dont think so. we added this test script previously which shows awareness of them https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/80ff6bfc6735d271a5ffd74faa6d97a90b281161/PaymentProviders/Ingenico/Tests/manual/TestCreatePayment.php#L42 [17:39:40] and I think civi is calling createPayment directly and Di is calling approvePayment so if that's the case the exceptions will be visible I think [17:40:47] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9aa4f641a47c42baa421aecc95c473330072033d/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php#L176 [17:41:42] line 177 only appears to be run if it's a statusOutput error [17:41:53] otherwise the api exception will be thrown [17:44:35] also in DI the exception isn't caught I don't think https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/d293886c5c8bca223f0212867afe6f1fff5e21c3/ingenico_gateway/ingenico.adapter.php#L219 [17:45:33] ok so we wanna leave those as they are and I guess remove the check for $resp['errors'] as the code will never seen that at current right? [17:46:09] OK, yep, lemme redo my patch [17:46:40] and then decide whether we let the exception show up at AndyRussG's patch or we add in some new try/catch blocks within the PaymentProvider to put them in Response [17:46:56] ooh, crap, and for both adyen and ingenico we should change 'payment_id' in the $params for 'gateway_txn_id' [17:47:21] yeah, if they were bubbling up before let's let them keep doing that [17:47:33] feels sketchy that AndyRussG has to check for an exception because of one providers behaviour [17:47:35] and try to get this code out there without changing TOOOO much [17:47:42] wait, does he? [17:48:01] sorry, lemme look at that [17:48:17] yeah only ingenico fires api exceptions at the moment [17:48:33] they're currently not being caught in the civi extension [17:48:45] ok, let's leave that as it is then [17:49:05] if those exceptions haven't been bothering us, we probably want to see failmail when one happens [17:49:15] fair point [17:49:16] must mean they're truly exceptional [17:49:19] :) [17:50:48] oh tangential-ish question, I couldn't see where $data['id'] is set for DI for when it gets to curl_transaction [17:50:58] (CR) Ejegg: [C: -1] "I think it needs to return an ApprovePaymentResponse in order to really implement the interface. Also, let's change the 'payment_id' key (" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (owner: AndyRussG) [17:51:53] (PS3) Ejegg: Map errors on Ingenico createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) [17:52:53] jgleeson: ok, that bit stops looking at the top-level errors key ^^^ [17:54:43] looking now [18:16:01] (CR) XenoRyet: [C: +2] "Looks good, and does what it says on the tin." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [18:16:31] (Merged) jenkins-bot: Ignore authorization IPN messages from recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [18:17:22] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Papaul) [18:32:12] ejegg: jgleeson: so am I correct in understanding that the PaymentProcessorException thrown here: https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9aa4f641a47c42baa421aecc95c473330072033d/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php#L209 [18:32:49] eventually bubbles out to the calling loop as a CiviCRM_API3_Exception here? https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9aa4f641a47c42baa421aecc95c473330072033d/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPigRecurringProcessor.php#L367 [18:38:21] (PS1) Jgleeson: WIP:Add tests for Ingenico PaymentProvider Api Errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576111 (https://phabricator.wikimedia.org/T243340) [18:39:33] AndyRussG: I'm not sure about that code I've not come across it before [18:40:22] I'm cooking dinner now but will be back a little later so can look into it more to familiarise myself with it [18:52:42] fundraising-tech-ops, Operations, ops-codfw: new payments2001 and payments2003 bonded ethernet network error/warning - https://phabricator.wikimedia.org/T246492 (Jgreen) [18:53:27] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Jgreen) [18:54:41] (CR) AndyRussG: Map errors on Ingenico createPayment response (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [19:10:46] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (CDenes_WMF) Hi there Dallas! Happy Monday I do indeed have a Yubikey; and I will follow the directions for the ssh keypair. Please let me know how best to proceed. Thanks! Camille [19:16:00] fr-tech could someone point me to the code where we use 'gateway_txn_id' in queue messages, just for reference, in view of ejegg most recent comment here? thanks!! https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/575806 [19:16:25] AndyRussG: yep, that PaymentProcessorException does end up getting re-throuwn as the CiviCRM_API3_Exception [19:16:49] ejegg: okok cool yeah I imagined that was it, thanks! [19:17:43] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Jgreen) Open→Resolved [19:18:08] AndyRussG: for an example of gateway_txn_id, you can see it being mapped to Adyen's pspReference in DonationInterface's file adyen_gateway/config/var_map.yaml [19:18:30] ejegg: okok thanks! [19:18:34] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [19:18:36] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw: rack/setup/install 3 new payments server for frack - https://phabricator.wikimedia.org/T244169 (Jgreen) [19:19:11] fundraising-tech-ops: rack/setup/install replacement payments2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242271 (Jgreen) [19:19:18] btw I think I was confusing payment_id and civi's processor_id... do they both map to gateway_txn_id somehow? [19:20:25] AndyRussG: payment_id definitely does [19:20:47] fundraising-tech-ops: rack/setup/install replacement payments2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242271 (Jgreen) [19:20:49] I'm a little hazy on processor_id [19:21:09] fundraising-tech-ops: rack/setup/install replacement payments2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242271 (Jgreen) Open→Resolved p:Triage→Medium a:Jgreen [19:21:11] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [19:21:27] so processor_id exists on the recur row and not the individual payment row [19:21:49] civi does have a trxn_id on both the recur row and the individual payment row [19:22:01] but the bad thing about that is that it needs to be globally unique [19:22:10] when it really should be unique per payment processor [19:22:17] fundraising-tech-ops: rack/setup/install replacement payments2002.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242272 (Jgreen) [19:22:33] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [19:22:35] fundraising-tech-ops: rack/setup/install replacement payments2002.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242272 (Jgreen) Open→Resolved p:Triage→Medium a:Jgreen [19:22:50] I think that's why we have the concatenated form in the trxn_id column, and have the bare gateway_txn_id in its own column on the wmf_contribution_extra custom data table [19:23:01] * AndyRussG confused [19:23:23] fundraising-tech-ops: rack/setup/install replacement payments2003.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242273 (Jgreen) [19:23:37] fundraising-tech-ops: rack/setup/install replacement payments2003.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242273 (Jgreen) Open→Resolved p:Triage→Medium a:Jgreen [19:23:39] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [19:24:16] ejegg: wrt your comment in CR, if we use gateway_txt_id instead of payment_id, are there other things we'll have to adapt to take that change into account? [19:25:00] AndyRussG: just the tests, and the code that you already have to change because we're removing $payment_id as a separate parameter [19:25:52] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [19:29:02] ejegg: ok cool thanks... mmm 'nother newbie question here, will a lot of stuff have to change to accommodate returning an ApprovePaymentResponse from all the ingenico implementation of IPaymentProvider::approvePayment() ? [19:30:09] (CR) Ejegg: Map errors on Ingenico createPayment response (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [19:30:33] AndyRussG: in CiviCRM not too much. In DonationInterface maybe a bit more :S [19:31:23] okok thx! [19:31:56] I honestly forgot we would have to adapt that bit - I had the idea in my mind that we were only touching calls that were used in CiviCRM, not in DI [19:32:02] thanks for catching it! [19:33:10] ejegg: oh hey thank u... I'd say it's more like it caught me than vice versa.. [19:35:13] AndyRussG: So payment IDs are definitely confusing [19:35:43] I think we have a page dedicated to decoding them [19:36:09] https://www.mediawiki.org/wiki/Fundraising_tech/Transaction_IDs [19:37:03] that's... wide [19:38:04] thanks for those tests jgleeson|dinner! Looking now [19:39:28] ah, ok, so those are for the api errors [19:39:30] hi eileen ! [19:39:38] oh hey [19:39:47] have I missed something? [19:40:30] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) p:High→Medium [19:50:42] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (JMinor) [19:51:44] haven't missed anything world-shaking at any rate eileen [19:51:51] :-) [19:51:58] we're just trying to nail down all the changes needed for the adyen recurring [19:52:06] ah ok [19:52:39] ah, those 'api errors' are things we're throwing from one of the lower-level Ingenico classes in SmashPig [19:52:52] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Ingenico transactions stuck at 600 without fraud scores - https://phabricator.wikimedia.org/T239769 (EMartin) Resolved→Open Hi all, I am seeing a number of orphan's NOT rectified during the Sweden campaig... [19:53:15] which we've so far not been catching at the SmashPig level [19:53:46] but which are apparently exceptional enough that it hasn't mattered [19:54:02] so we're going to continue not to catch them at the low leverl [19:54:04] *level [19:54:33] makes sense.... [20:05:19] (CR) Ejegg: "Cool! Nice to get this working without having to rely on tangential things like the CVV status. Just one note on the property name - we're" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575313 (https://phabricator.wikimedia.org/T243334) (owner: Cstone) [20:06:44] yeah ejegg I'm gonna add in a test just to confirm the PaymentError scenario work as expected [20:07:07] and then I guess we can +2 that [20:08:14] we already have Response->hasErrors() tests somewhere so I'll just update that to check for a specific instance of PaymentError and the expectd message [20:15:58] fundraising-tech-ops: rack/setup/install replacement frpig2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242266 (Papaul) a:Papaul [20:16:13] fundraising-tech-ops: rack/setup/install replacement frpig2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242266 (Papaul) [20:16:38] fundraising-tech-ops: rack/setup/install replacement frpig2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242266 (Papaul) [20:17:29] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw:fundraising single-cpu misc servers frpig2001,civi2001.pay-lvs200[1-2] - https://phabricator.wikimedia.org/T244950 (Papaul) [20:18:57] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw:fundraising single-cpu misc servers frpig2001,civi2001.pay-lvs200[1-2] - https://phabricator.wikimedia.org/T244950 (Jgreen) [20:20:08] fundraising-tech-ops: rack/setup/install replacement pay-lvs2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242267 (Jgreen) a:Papaul [20:20:47] fundraising-tech-ops: rack/setup/install replacement pay-lvs2002.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242268 (Jgreen) a:Papaul [20:21:14] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) a:Papaul [20:23:49] Wikimedia-Fundraising-Banners: IE11 dsk lg & sm: Selecting monthly still gives "monthly convert" option - https://phabricator.wikimedia.org/T235706 (Pcoombe) Open→Resolved a:Pcoombe In Internet Explorer trying to get the selected radio button using 'form.frequency.value' returned undefined. Fixe... [20:24:09] Fundraising-Backlog, FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (DStrine) [20:25:11] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Ingenico transactions stuck at 600 without fraud scores - https://phabricator.wikimedia.org/T239769 (DStrine) I split the new donations into a new task: T246710 [20:25:14] (PS2) Jgleeson: Add tests for Ingenico PaymentProvider Response Errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576111 (https://phabricator.wikimedia.org/T243340) [20:25:15] Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Ingenico transactions stuck at 600 without fraud scores - https://phabricator.wikimedia.org/T239769 (DStrine) Open→Resolved [20:26:27] ejegg: AndyRussG I think it's fine to treat a declined as an error state. I know I sometimes mistype my own card details and get declined prompting me to type slower :) [20:26:35] (CR) Jgleeson: [C: +2] Map errors on Ingenico createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [20:26:55] (Merged) jenkins-bot: Map errors on Ingenico createPayment response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576092 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [20:27:02] ejegg: I've added in a test to confirm the PaymentError stuff, seems to work as expected [20:27:23] I'm just gonna update the Adyen tests to do the same, overkill maybe but futureproofs us [20:27:37] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Papaul) [20:27:45] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Papaul) ` [edit interfaces interface-range disabled] - member "ge-[0-1]/0/12"; [edit interfaces interface-range vlan-administ... [20:28:24] oh hey ejegg, you've already done it! [20:28:28] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: (Need by: TBD) rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Papaul) a:Papaul→Jgreen @Jgreen All yours [20:28:47] lemme just as in an instanceOf assertion to be extra meticulous! [20:32:56] fundraising-tech-ops, Operations, ops-codfw: (Need by: TBD) codfw:fundraising single-cpu misc servers frpig2001,civi2001.pay-lvs200[1-2] - https://phabricator.wikimedia.org/T244950 (Papaul) Open→Declined Declinning this task since it is been track in separate tasks T242270 T242266 T242267 T2... [20:33:29] fundraising-tech-ops: rack/setup/install replacement pay-lvs2002.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242268 (Papaul) [20:33:59] (PS3) Jgleeson: Add tests for Ingenico PaymentProvider Response Errors [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576111 (https://phabricator.wikimedia.org/T243340) [20:34:01] (PS1) Jgleeson: Minor updates to Adyen tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576134 (https://phabricator.wikimedia.org/T243340) [20:34:25] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11 dsk sm: below 1390px in certain articles/languages, big jump on step 2 - https://phabricator.wikimedia.org/T191422 (Pcoombe) @spatton I'm not able to reproduce this on current banners: [fr NASA article](https://fr.wikipedia.org/w/inde... [20:43:05] fundraising-tech-ops: rack/setup/install replacement frpig2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242266 (Papaul) [20:43:26] fundraising-tech-ops: rack/setup/install replacement frpig2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242266 (Papaul) [20:44:24] fundraising-tech-ops: rack/setup/install replacement frpig2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242266 (Papaul) [20:44:41] Fundraising-Backlog, fundraising-tech-ops: TASK FORCE Investigate parent task "Adjust modsecurity rules to work for us" - https://phabricator.wikimedia.org/T246711 (DStrine) [20:47:43] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Papaul) [21:29:55] Fundraising-Backlog, Phabricator: Please adapt Phabricator ACLs for "acl*WMF-FR" - https://phabricator.wikimedia.org/T246648 (DStrine) Open→Resolved [21:37:00] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) I'm not able to access the management IP, can you check it out? jgreen@frbast1001:~$ dig frnetmon1001.mgmt.frack.eqiad.wmnet ; <<>> D... [21:39:13] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) a:Jgreen→None [21:40:35] fundraising-tech-ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) @cmjohnson @Jclark-ctr can someone take a look at the management interface situation? It's not accessible via network as far as I can tell. [21:50:27] (PS1) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 [21:51:38] (PS2) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T243012) [21:52:40] (PS3) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) [21:56:39] (CR) jerkins-bot: [V: -1] Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) (owner: Mepps) [22:06:02] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, and 7 others: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (Eileenmcnaughton) Open→... [22:07:20] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: upstream creditnote_id fix - https://phabricator.wikimedia.org/T194313 (Eileenmcnaughton) Open→Resolved Done - we can... [22:07:22] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Eileenmcnaughton) [22:07:29] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: upstream creditnote_id fix - https://phabricator.wikimedia.org/T194313 (Eileenmcnaughton) [22:08:00] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, and 2 others: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (Eileenmcnaughton) @MBeat33 good... [22:08:33] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Patch-For-Review: 16 Multilingual Thank You Emails - https://phabricator.wikimedia.org/T243098 (Eileenmcnaughton) Open→Resolved Setting to resolved -... [22:09:04] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Remove 'quick autoreviewed' entity tag - https://phabricator.wikimedia.org/T245577 (Eileenmcnaughton) Open→Resolved We can't get a number on the DB reclaime... [22:09:06] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Decide what to do about the increasing civi crm db size - https://phabricator.wikimedia.org/T243870 (Eileenmcnaughton)