[00:11:54] fundraising-tech-ops: disable tls1.1 on all fundraising websites - https://phabricator.wikimedia.org/T246850 (Jgreen) [00:12:19] fundraising-tech-ops: disable tls1.1 on all fundraising websites - https://phabricator.wikimedia.org/T246850 (Jgreen) p:Triage→High [00:27:14] fundraising-tech-ops: disable tls1.1 on all fundraising websites - https://phabricator.wikimedia.org/T246850 (Jgreen) [00:39:37] (CR) Ejegg: [C: +2] "Thanks, AndyRussG! Nicely deduplicated." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [00:40:03] (Merged) jenkins-bot: Make Ingenico PaymentProvider implement IPaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [00:40:56] fundraising-tech-ops: disable tls1.1 on all fundraising websites - https://phabricator.wikimedia.org/T246850 (Jgreen) [00:57:01] Fundraising-Backlog, fundraising-tech-ops: Email deliverability stats for list of email domains - https://phabricator.wikimedia.org/T246811 (DStrine) [00:58:53] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Dwisehaupt) [01:00:29] Fundraising-Backlog, fundraising-tech-ops: Email deliverability stats for list of email domains - https://phabricator.wikimedia.org/T246811 (DStrine) @Jgreen do you have stats on these? I was talking to @MBeat33 and he doesn't have any consistent complaints from aol or comcast (comcast should be include... [01:02:52] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jclark-ctr) [01:02:54] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jclark-ctr) [01:22:55] Fundraising-Backlog, Commons, TimedMediaHandler: Commons video player does not work on IE 11 or older versions of Safari - https://phabricator.wikimedia.org/T243562 (jbolorinos-ctr) Open→Invalid Closing as invalid as I'm no longer able to replicate this error [01:50:53] (PS1) Ejegg: Fix Ingenico audit parsing for BPay donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576500 (https://phabricator.wikimedia.org/T245749) [01:51:34] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Ingenico, FR-WMF-Audit, Patch-For-Review: BPay transaction crashing Ingenico audit parser - https://phabricator.wikimedia.org/T245749 (Ejegg) p:Triage→High [01:58:28] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Ingenico: figure out cloudflare issues: Ingenico duplicate donations? or just baseline donor error? - https://phabricator.wikimedia.org/T244607 (MBeat33) Ope... [05:08:08] (PS1) Ppchelko: Remove usages of deprecated Revision::newFromTitle [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/576528 (https://phabricator.wikimedia.org/T246284) [05:16:17] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T246825 (AndyRussG) [05:16:52] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T246825 (AndyRussG) a:AndyRussG [05:17:03] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Adyen, Recurring-Donations: Normalize approvePayment method signatures and responses for Ingenico and Adyen PaymentProviders - https://phabricator.wikimedia.org/T246825 (AndyRussG) [05:20:40] Fundraising-Backlog, FR-Adyen, FR-Ingenico: Adapt DonationInterface to new method signatures and response objects for Adyen and Ingenico - https://phabricator.wikimedia.org/T246863 (AndyRussG) [05:44:14] (PS2) AndyRussG: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) [05:46:12] (CR) jerkins-bot: [V: -1] Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [05:47:47] (PS1) AndyRussG: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) [05:54:28] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [08:06:22] (PS3) ItSpiderman: Schema changes related to BannerTemplates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 [08:06:27] (PS19) ItSpiderman: Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 [09:59:23] (PS1) ItSpiderman: Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 [10:06:20] (PS4) ItSpiderman: Schema changes related to BannerTemplates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 [10:06:22] (PS20) ItSpiderman: Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 [10:06:24] (PS5) ItSpiderman: [WIP] Cloning Campaign [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/574667 (owner: AlexPinchuk) [10:06:49] (PS2) ItSpiderman: Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 [10:08:57] (PS6) AlexPinchuk: [WIP] Cloning Campaign [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/574667 [11:23:46] fundraising-tech-ops, Operations, netops: DHCP routing issue with civi2001 - https://phabricator.wikimedia.org/T246812 (ayounsi) Configuration looks good on the switch and router. This will need to be live troubleshooted, when the client is sending DHCP requests. First step is to run `show ethernet... [12:28:09] Wikimedia-Fundraising-CiviCRM: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (RLewis) [14:33:18] hi AndyRussG ! [14:35:35] fr-tech I'd like to get one more patch merged into SmashPig master before we bump the library version - https://gerrit.wikimedia.org/r/576500 [14:35:58] that'll get the ingenico audit parser to stop crashing every night [14:38:37] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/576846 [15:19:35] hi jgleeson ! [15:19:48] hey ejegg :) [15:19:52] ejegg jgleeson :) [15:20:04] looks like your 'add recurring parameters' patch is the only thing of substance in the DI deploy pipeline for now [15:20:29] feel like deploying today? https://gerrit.wikimedia.org/r/576846 [15:21:41] sure ejegg [15:21:49] rockin! [15:28:10] I have this on draft feedback also but might as well mention it in here AndyRussG ejegg. I noticed we've got some scenarios which allows a retry with adyen create payments and I don't think we handle this with the current code in the civi extension. [15:28:40] if AndyRussG's latest patch you can see that the check is on the presence of errors to indicate something is wrong https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/576536/1/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php@62 [15:29:13] so at first I thought maybe it would instead be better to use $Response->isSuccessful() as that is only set when we get a successful returned status [15:29:33] (PS1) Ejegg: Update usage of constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576857 [15:29:48] but then I realised we have some code to handle possible retryRefusalReason [15:29:50] s [15:30:41] which I guess would be fine if we called createPayment in isolation but in the smashpig extension we're not, we immediately call approvePayment IF there are no errors in the Response [15:30:53] (CR) jerkins-bot: [V: -1] Update usage of constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576857 (owner: Ejegg) [15:31:05] jgleeson: ah, so would that be errors for which we can retry immediately, or errors for which we can retry the next day? [15:31:08] I'm quite sure it's a bug? maybe? but something doesn't sit right [15:32:29] dang, we're still getting a lot of db lock failmail [15:34:04] oh wait, i'm being fooled by the way gmail groups those things [15:34:22] AndyRussG: ejegg I feel like the safer option is to check against Response->isSuccesful() and then if it's not successful we then check if they are any errors to bubble up as exceptions [15:35:11] otherwise we potentially open ourselves up to the scenario where the createPayment call is refused and it can be retried based on this list https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/b39e3777571a7eb9d7b385c31f93b613a192329e/PaymentProviders/Adyen/PaymentProvider.php#L246 but it was still refused in the first place so proceeding to approvePayment doesn't make sense [15:35:16] does that sense? [15:35:37] the newer 'Fail Mail : REMOVAL: civi1001 ' are all from the refund queue - the donations deadlocks are from before cstone turned off the deleted contacts cleanup [15:36:30] jgleeson: ahhh, yeah, we should indeed be checking for successful [15:37:12] actually, in the Ingenco error normalization patch I added a value for normal auth declines (retryable the next day) [15:37:37] hmm, and maybe I need to revisit that array - do those refusal reasons generally come with numerical codes prepended? [15:38:11] ok, so maybe we can ALSO add an error code for normal declines [15:38:23] I mean add an error with the normal decline code [15:38:36] good catch jgleeson [15:39:36] hmm interesting I don't see the '800 no contract found' error in the list of refusal reasons https://docs.adyen.com/development-resources/refusal-reasons#page-introduction [15:39:54] although I saw then when testing with our test script [15:40:17] maybe that's recurring specific [15:41:08] yeah, I added that one based on your test [15:41:28] ejegg: so the code in the PaymentProviders behaves like "if it can be retried. we DON'T add an error but it will still be set to the status of refused" right? [15:41:33] it sounded like something we wouldn't be able to retry [15:41:42] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/b39e3777571a7eb9d7b385c31f93b613a192329e/PaymentProviders/Adyen/PaymentProvider.php#L86 [15:41:51] jgleeson that's what I assumed for Adyen [15:42:31] but then I went ahead and changed it for Ingenico so I could better approximate the behavior of the big switch statement in DonationInterface's globalcollect.adapter.php [15:42:49] i.e. adding an error code for normal (retryable the next day) declines [15:43:09] So I should go back and make Adyen work the same way [15:43:22] do we need to enhance the smashpig extension code to pick up that info and do something with it if present? [15:43:45] where does the logic live that knows how to do stuff on the next working day [15:44:04] The smashpig Civi extension should at least check for hasError( ErrorCode::DECLINED_NO_RETRY ) [15:44:19] and in that case set the recurring txn to cancelled immediately [15:44:25] AndyRussG: ^^^^ [15:44:40] oooo I see [15:45:06] what I'm missing here is that the ext will run again anyway if the next_scheduled_payment isn't updated or something like that? [15:45:18] s/ext/extension/ [15:45:59] when it gets a normal decline code it should set the status to 'failing' and advance the next scheduled date by one day [15:46:18] (the older recurring processor uses the retry_date, which maybe we should be using too!) [15:46:28] but anyway, it should try again the next day [15:49:00] ah I feel like I should have paid more attention to yours and eileen's effort around introducing 'failing' [15:49:15] so that was a core CiviCRM change [15:49:35] there used to be a single set of statuses used for both one-time contributions and recurring contributions [15:49:59] but there were some that only made sense for one and not the other [15:50:59] And when the core team split those two status groups out, they added a couple of statuses that made more sense for recurring [15:51:03] like 'failing' [15:52:09] (PS2) Ejegg: Fix Ingenico audit parsing for BPay donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576500 (https://phabricator.wikimedia.org/T245749) [15:53:52] ok so just to confirm patch feedback here, https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/576536/ we need to add in a check to see if the createPayment call was successful by checking Response->isSuccessful() before proceeding to approvePayment, and in the event that the createPayment result is false we need add in a further check to see if it's an error type that warrants [15:53:54] cancelling the recurring subscription and doing so if required [15:53:58] ejegg: AndyRussG ^^ [15:56:19] fundraising-tech-ops, Operations, netops: DHCP routing issue with civi2001 - https://phabricator.wikimedia.org/T246812 (ayounsi) a:Papaul At bootup that MAC shows up on ge-1/0/9 ` ayounsi@fasw-c-codfw> show ethernet-switching table | match 4c:d9:8f:aa:77:b4 frack-payments-codfw 4c:d9:8f:aa:7... [15:57:33] jgleeson yes, that's correct [15:58:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (DStrine) [16:06:06] (CR) Jgleeson: "Nice work on splitting out the error handling, really tidies things up. I noticed a couple of small things that I added inline." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [16:06:17] Fundraising-Backlog: Review Banner Templating - https://phabricator.wikimedia.org/T246347 (DStrine) [16:09:40] fr-tech any news for scrum of scrums? [16:09:47] nopes [16:20:06] (PS1) Ejegg: WIP Adyen: add PaymentError for normal declines [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576877 (https://phabricator.wikimedia.org/T243340) [16:20:17] (CR) Jgleeson: [C: -1] "Looks like we need to switch over from Response->hasErrors() to Response->isSuccessful() and then also if the createPayment call was unsuc" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [16:29:48] ejegg: none here, thanks! [16:30:01] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (spatton) Hi @JMinor, we're still seeing about 10 donations coming in through the iOS app every day. Could we please go with the option of... [16:38:23] (PS3) Mepps: Geotargeting: Collapse countries and regions into one column and fix regions code bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571768 (https://phabricator.wikimedia.org/T243011) [16:38:47] (PS4) Mepps: Geotargeting: Collapse countries and regions into one column and fix regions code bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571768 (https://phabricator.wikimedia.org/T243011) [16:41:36] (PS1) Ejegg: Adyen test script: request specific response codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576891 [16:42:08] (CR) jerkins-bot: [V: -1] Geotargeting: Collapse countries and regions into one column and fix regions code bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571768 (https://phabricator.wikimedia.org/T243011) (owner: Mepps) [16:43:32] (PS4) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) [16:44:30] (PS5) Mepps: Geotargeting: Collapse countries and regions into one column and fix regions code bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571768 (https://phabricator.wikimedia.org/T243011) [16:44:57] ejegg: are you ok for your rate limiting patch to go live? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/554133/ [16:46:07] and this one which stops gateway pages loading in frames https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/558244/ [16:46:56] (CR) jerkins-bot: [V: -1] Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) (owner: Mepps) [16:47:18] sorry ejegg ignore that, I was comparing against an old version of deployment locally [16:47:27] those patchs are already out in the wild! [16:47:33] patches [16:51:50] (PS5) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) [16:52:14] Wikimedia-Fundraising-Banners: Misplaced Currency Symbol on Desktop Large - Nag banner in Hebrew - https://phabricator.wikimedia.org/T242395 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr {F31662249} Fix verified, closing this now. [16:53:04] (PS1) Ejegg: Add form settings for Adyen recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576895 [16:53:05] jgleeson: ooh, one more thing to add - updates to FormSettings to allow recurring for adyen [16:53:24] (PS1) Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/576896 [16:54:02] (CR) jerkins-bot: [V: -1] Add form settings for Adyen recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576895 (owner: Ejegg) [16:54:40] hmm [16:55:19] Ci wobble? [16:55:24] yah, stderr: 'fatal: unable to access 'https://gerrit.wikimedia.org/r/mediawiki/extensions/DonationInterface/': The requested URL returned error: 502' [16:55:35] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576895 (owner: Ejegg) [16:56:00] (CR) jerkins-bot: [V: -1] Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) (owner: Mepps) [16:56:06] maybe we could spend 5 minutes on tech-talk going over the formsettings stuff, I feel like I don't know enough about how it works [16:56:09] I think we do need that for banners that steer donors through the form chooser [16:56:14] yeah, it's a relic [16:56:27] from the days of our old 'RapidHTML' forms [16:56:37] which had a dozen or so different templates [16:56:52] I've got a couple of patches that try to clean up the chooser logic a bit [16:57:29] ah, just this one: https://gerrit.wikimedia.org/r/338458 [16:57:45] oh shoot I need to go and pickup Oscar, I'll abandon my deployment patch, +2 yours and then make the deployment patch again once I get back [16:58:04] (Abandoned) Ejegg: WIP add PaymentParameters and PaymentProvider interface [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334709 (owner: Ejegg) [16:58:17] jgleeson|baksoon: no don't +2 mine! [16:58:26] ok! [16:58:34] Or not my merge patch anyway [16:58:42] yes please +2 my formsettings patch [16:58:48] yeah that one I meant [16:59:10] ah thanks [16:59:29] (Abandoned) Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/576896 (owner: Jgleeson) [16:59:50] (CR) Jgleeson: [C: +2] Add form settings for Adyen recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576895 (owner: Ejegg) [16:59:55] right baksoon! [16:59:56] (PS6) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) [17:03:53] hi XenoRyet [17:07:41] (Merged) jenkins-bot: Add form settings for Adyen recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576895 (owner: Ejegg) [17:10:45] mornin' [17:11:12] Just saw the news that there's two cases of COVID-19 in my county. [17:11:22] But I guess it's not all bad, at least Bloomberg dropped out. [17:18:47] hmm, wonder if he's got another 500M to spare on the general election [17:28:01] jeez, I still can't get that ResponseCode testing working [17:28:13] I think I'm hitting exactly the same issues as jgleeson did [17:29:32] which bit of testing ejegg ? [17:29:36] @_@ [17:31:44] jgleeson: I was trying to use that additionalData section [17:31:48] (PS2) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/576846 [17:31:58] to get some specific response codes back [17:32:04] ah gotcha [17:32:47] and kept getting those soap errors [17:32:55] ejegg: standup:) [17:59:19] (PS2) Ejegg: Adyen: add PaymentError for normal declines [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576877 (https://phabricator.wikimedia.org/T243340) [18:16:14] (PS1) Ejegg: Adyen recurring: fix 'token' parameter name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576918 (https://phabricator.wikimedia.org/T242277) [18:16:53] found a little inconsistency in the createPayment params ^^^ [18:17:27] hmm guess adyen has no problem having two of the same merchant reference [18:23:06] yeah, I was trying to trigger an error by authorizing a huge amount more than the initial, or using different currencies [18:23:13] and all came back with an auth [18:23:34] (CR) Jgleeson: [C: +2] Adyen recurring: fix 'token' parameter name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576918 (https://phabricator.wikimedia.org/T242277) (owner: Ejegg) [18:23:38] hmm, how about a negative amount [18:24:00] good spot ejegg, I think I just put token in out of laziness as I was testing from the cli :| [18:24:18] nah, negative amount gets caught in the soap validation [18:25:16] 0 doesnt error too i tried that before [18:25:21] jgleeson I left the CLI option as 'token' - that's actually consistent with something in ingenico [18:25:28] cstone haha, just tried that now [18:25:53] the auth doesn't error, but the capture does [18:26:10] though the capture error is again in validation [18:26:38] fr-tech I was planning on picking up https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/576536/ but I probably won't do much to it until tomorrow as my day ends after tech-talk. With our time pressure it might be best someone else looks at it and then I pick up tomorrow first thing if it's not done? How do others feels? [18:26:40] -s [18:26:46] jgleeson: thanks for the c+2! Does that parent patch look good too? [18:27:11] jgleeson I'd be happy to work on that patch for a bit [18:27:25] and I'll try to give a detailed account of where I leave off in my EOD email [18:29:11] ejegg: that parent patch had me thiking we might be assigning declined as errorcode to retryRefusalReasons that may have more specific error codes (strings) [18:29:34] so I just wanted to check that [18:30:09] cstone I guess a $0 auth is totally common: https://www.cardfellow.com/blog/visa-zero-dollar-verification-fee/ [18:31:10] jgleeson true - but do they mean we need to act differently in the civi extension? [18:31:32] hmmm this brings up authorize.net memories maybe they did that [18:32:17] would we wanna retry when the refusalReason is 'FRAUD', [18:32:19] 'FRAUD-CANCELLED', [18:32:35] sorry that was a non-point [18:32:43] scratch that [18:32:47] oo tech-talk [19:00:15] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) [19:01:35] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Jgreen) Management interface network config had some issues, fixed now. [19:07:51] Wikimedia-Fundraising, Wikipedia-iOS-App-Backlog, iOS-app-feature-Feed: Fundraising banners still showing on iOS app? - https://phabricator.wikimedia.org/T242347 (JMinor) Ok, will circle back with the team to get ETA for that. Sorry about this! [19:10:17] (PS1) Ejegg: Update spelling of gatewayTxnId [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576926 (https://phabricator.wikimedia.org/T243340) [19:16:16] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, Fr-planning-ahead: fill out PCI saq a forms and document process - https://phabricator.wikimedia.org/T243020 (XenoRyet) a:XenoRyet [19:16:18] (PS2) Ejegg: Update spelling of gatewayTxnId [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576926 (https://phabricator.wikimedia.org/T243340) [19:20:41] (PS2) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [19:26:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) [19:27:35] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [19:33:32] Fundraising-Backlog: Implementing GPAY for donors - https://phabricator.wikimedia.org/T244513 (DStrine) [19:33:47] fundraising-tech-ops, Operations, netops: DHCP routing issue with civi2001 - https://phabricator.wikimedia.org/T246812 (Papaul) @ayounsi thanks for the troubleshooting I will look into this tomorrow. [19:34:30] fundraising-tech-ops, Operations, netops: DHCP routing issue with civi2001 - https://phabricator.wikimedia.org/T246812 (Papaul) p:Triage→Medium [19:45:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [19:46:11] Wikimedia-Fundraising-Banners: Desktop large opt-in is broken for RTL languages - https://phabricator.wikimedia.org/T246344 (Pcoombe) @jbolorinos-ctr, I've got a suggested fix for this now. Since it involves changing the "showStep" method for both LTR and RTL, can you double check both are working okay befor... [19:50:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [19:59:37] fr-tech I'm getting MISSING_OR_INVALID_AUTHORIZATION when trying to do a local ingenico test donation, the api credentials are correct. Has anyone fixed this one recently? [20:00:12] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 8946054 Threads: 3 Questions: 2338827898 Slow queries: 739906 Opens: 1750037 Flush tables: 1 Open tables: 199 Queries per second avg: 261.436 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [20:00:30] hmmm [20:00:52] lemme try - maybe something expired? [20:00:54] i apparently ran into it last year but my notes are very helpful that "i fixed it" [20:00:58] hmmm [20:01:38] oho, I'm getting an error too, let's see which one it is [20:01:40] cstone: I think that's code for "this is a rabbit hole that will consume all your attention for three days, enjoy!" [20:01:53] hah [20:02:19] yep, same error [20:02:23] guessing it's expired [20:02:31] okay that makes more sense [20:02:53] oh, it's 'watch DS use Civi' time [20:04:38] AndyRussG: txn was decided to be the spelling https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/576926 [20:05:58] cstone yep, expired Feb 11th [20:06:13] I'll generate a new one and put it up in the credentials storage [20:06:19] ahh okay im failing at finding the login link for the test page [20:06:21] ok cool thanks [20:06:29] er test ingenico login [20:06:37] see private channel [20:14:22] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi deduper permission levels for DS - https://phabricator.wikimedia.org/T245843 (DStrine) [20:19:59] fr-tech is anyone available to review this audit parser fix? https://gerrit.wikimedia.org/r/576500 [20:20:54] It's pretty self-contained, though I had to resort to some crummy assumptions to get a useful result out of the ultra-sparse audit file entry [20:21:37] so this is a priority because there are some Ingenico donation we only get into Civi via the audit processor [20:21:51] which has been failing for two weeks now [20:21:58] ah, including iDEAL payments [20:23:10] I can ejegg [20:23:17] thanks! [20:23:33] (CR) Mepps: [C: +1] "Mostly looks good but I have one question. I'm glad to see the test!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576500 (https://phabricator.wikimedia.org/T245749) (owner: Ejegg) [20:23:38] so the PS includes a version of the crashy record in the gz file [20:24:29] if you want to track it down in the original, it's in the globalcollect/incoming directory of the audits dir on the civi server [20:24:40] cstone i took a quick look but i think your feedback might have better context than mine [20:25:18] mepps you probably know more about it than me hah [20:42:54] ejegg: I actually made a second minor change to that job enable - let me know if good to push out [20:43:27] eileen: taking a look [20:45:07] ooh, tricksy identifier forcing [20:45:20] lol - hacky tracking method :-) [20:47:07] eileen: is every 7 minutes pretty frequent for a batch size of 6000? [20:47:27] or because this is a second (third?) pass, we expect far fewer actual dedupes on that batch size? [20:48:08] ejegg: hmm - hopefully that's true - I just accepted what was before. [20:48:26] but I think each 6000 contact batch should have 'relatively few' duplicates [20:48:39] ok, let's see how long the first few runs take and adjust as necessary [20:48:40] (CR) Cstone: [C: +2] "Looks good, tests run for me locally." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576500 (https://phabricator.wikimedia.org/T245749) (owner: Ejegg) [20:49:02] (Merged) jenkins-bot: Fix Ingenico audit parsing for BPay donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576500 (https://phabricator.wikimedia.org/T245749) (owner: Ejegg) [20:49:09] thanks cstone ! [20:50:21] (PS2) Ejegg: Adyen recurring: fix 'token' parameter name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576918 (https://phabricator.wikimedia.org/T242277) [20:50:34] (PS3) Ejegg: Update spelling of gatewayTxnId [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576926 (https://phabricator.wikimedia.org/T243340) [20:51:29] (rebased those to not depend on the one that jgleeson had doubts about) [20:51:59] oops, just saw your cr + question mepps [20:52:29] ahh, I guess I hope there aren't any more methods like that. [20:53:19] an array called $legacyOnlyProducts just seemed like the easiest way to express the idea in code [20:54:02] the whole heuristic method of determining which integration we used is pretty sketchy :( [20:54:16] !log process-control config revision is 21eb2e891f [20:54:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:54:23] i figured maybe something else might end up in that status? [20:54:25] might have been better to cut over to a new account, though DS might have hated us for it [20:55:06] cstone maybe, I guess? There might be other legacy bank transfer things that people could use at any time [20:55:16] I only remember getting those weird records for bpay though [21:18:19] fundraising-tech-ops, Operations: rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Cmjohnson) a:Jgreen Removing ops-eqiad tag and assigning to @Jgreen [21:59:28] cstone I'm going to head out for a bit then work an hour or two later, so I can pick up from where you leave off if you push up another version of that patch [21:59:46] ok sounds good ejegg [22:16:03] ejegg: I'm thinking about turning the delete contacts job back on - I think it was actually a hung query it hit - but not too sure how traffic is expected to look [22:16:43] It's an Italy campaign right now, so I bet it's starting to quiet down for the night [22:17:12] looking at the dash to check volume.... [23:00:14] ejegg: I'll turn it on & maybe turn it off at the end of the day [23:01:51] !log process-control config revision is 734a7bfadd [23:01:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:26:39] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Dwisehaupt) Base OS installed. Puppet runs aren't clean yet due to the private repo needing sync. Will catch up with that tomorrow. [23:26:52] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Dwisehaupt) [23:49:23] Wikimedia-Fundraising-Banners: Desktop large opt-in is broken for RTL languages - https://phabricator.wikimedia.org/T246344 (jbolorinos-ctr) Open→Resolved Fix verified in English version: https://drive.google.com/file/d/1gueHmwgLTLwnONkP39NTAMSsLe1BxkdQ/view?usp=sharing Fix verified in Hebrew versio... [23:51:30] (PS2) Eileen: Add new ckeditor5 extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576443 (https://phabricator.wikimedia.org/T244323) [23:54:06] (CR) jerkins-bot: [V: -1] Add new ckeditor5 extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576443 (https://phabricator.wikimedia.org/T244323) (owner: Eileen)