[00:01:47] ahh okay thanks for explaining [00:03:58] (CR) Cstone: [C: +2] "And may it one day become invoice_id" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577384 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [00:04:18] (Merged) jenkins-bot: Adyen: rename 'reference' parameter to 'order_id' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577384 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [00:04:40] ejegg were you still trying to get responses like "refusalReason":"800 Contract not found" cause I just accidentally did that [00:04:53] oh hey! how did you manage that? [00:05:03] ah, just sending a bogus token? [00:05:13] i tried a recurring payment on yours not mine haha [00:05:25] php TestAdyenRecurring.php --config-node adyen --token="1572252874.1" --currency="USD" --amount="2.22" [00:05:49] whoops thats the right one [00:05:58] this one gave the error [00:06:00] php TestAdyenRecurring.php --config-node adyen --token="48990265.8" --currency="USD" --amount="2.22" [00:06:22] ok, so that's under a different test account than your current test credentials? [00:06:30] im guessing 48990265.8 is real but not set up as a recurring donation? [00:06:43] oh hmm [00:06:56] i grabbed it from the adyen UI [00:07:02] let me try and replicate it with my own donations [00:07:05] ah cool [00:09:24] oh darn, this not-throwing-exceptions thing breaks our getBankList iDEAL lookup [00:10:01] which we're actually using on the globalcollect iDEAL integration [00:10:02] Wikimedia-Fundraising-Banners: Large CC payment button on Safari Mobile 9.0 and earlier - https://phabricator.wikimedia.org/T240730 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr Hey Peter, This fix looks good! I've attached screenshots of the fixes verified below. Closing this now as Resolved.... [00:10:59] Wikimedia-Fundraising-Banners: Desktop large opt-in is broken for RTL languages - https://phabricator.wikimedia.org/T246344 (jbolorinos-ctr) Thanks Peter, yeah normally I think the best practice would be to post the Pull Request link from Github here when we verify fix and merge...but we'll get to that! ;) [00:12:08] ok though, we can check for the error up there [00:14:46] hmm for the error it might from different test accounts then I can't replicate with my own donations [00:19:36] ah ok [00:36:36] (PS1) Ejegg: Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) [00:36:46] whew, I think that should work ^^^ [00:37:27] ok, I had an ingenico failing donation to smoke test with --- let me dig that out [00:42:42] can you tell that in college I pulled all-nighters right before papers were due? [00:43:11] hehe, thanks for that CR cstone [00:43:28] i mean isnt that how college worked [00:43:31] i guess ingenico and adyen were sounding like biblical names to me [00:43:35] haha [00:43:51] shadrach, mishach, and ingenico? [00:44:11] adyen, shem, and japeth? [00:44:16] fits right in [01:02:11] ok, so I can confirm that with that SmashPig patch, we do get the normalized (integerized) ErrorCode bubbled up to where we can look for it [01:02:51] niceee [01:04:03] i was trying to create a situation to test it [01:05:11] (PS5) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [01:05:52] OK, now all that's left is to fix the tests and to handle the DO_NOT_RETRY errors [01:10:37] (PS6) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [01:10:44] and now to fix up the tests [01:11:10] (and I suppose maybe add a few more!) [01:12:06] would we want to separate out them per processor? [01:12:38] let's see [01:12:51] I think we might be mocking the PaymentProcessor objects [01:13:11] and those should be returning standardized responses now [01:13:34] Lemme try updating them and see if it makes sense to split them out [01:14:43] bah got the error then didnt have your patch checked out [01:15:06] haha the branch name for that :) [01:16:27] haha noo it went through successfully haha [01:17:34] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [01:18:51] Error: 1000009 invoice_id:1572252872.2 :D [01:22:43] oh the successful one was the adyen one [01:32:10] ohhhhh damn [01:32:27] damn damn damn [01:32:36] CRM depends on DI as a library [01:32:48] to do the globalcollect recurring [01:33:17] and DI needs to be updated at least a little bit because we moved the FinalStatus constant to a different namespace [01:33:22] fark fark fark [01:33:46] so we can't actually defer the DonationInterface fixes till next week [01:34:03] i so want to kill old globalcollect [01:36:18] (PS7) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [01:36:33] fack fack fack [01:36:51] do we leave the constants in the old spot for back compat for now?? [01:37:10] I really REALLY don't want to update the embedded DonationInterface :( [01:39:13] thats the work you and ei leen were doing to get the statuses in line with civi? [01:42:02] no, that's the work AndyRussG started to update DonationInterface to use the new SmashPig code [01:42:07] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [01:42:09] and I really wanted to leave that till next week [01:42:19] but... it looks like we can't [01:42:19] ahh okay [01:42:58] specifically because we moved the FinalStatus and ValidationAction classes to a new namespace [01:44:27] lemme see if leaving a copy back in the old place at least lets tests run [01:44:35] (so hacky) [01:45:37] why can't we leave the DI stuff till next weeek? [01:47:15] AndyRussG: because CiviCRM uses DonationInterface as a library to charge recurring globalcollect payments [01:48:06] and even though the adyen / ingenico work didn't touch that code path, we changed the namespace of a couple of other enums that ARE used in that codepath [01:49:15] so I need to revise that 'steps' document [01:50:09] we don't actually need to deploy the updated DonationInterface to payments-wiki [01:50:37] just update it enough to work under CRM and update its composer version [01:53:09] oh hmmm [01:53:23] so i.e. there are civi codepaths that call DI that call SmashPig? [01:54:41] yeah [01:54:49] or at least use enums defined in SmashPig [01:55:18] once we get rid of old Globalcollect we'll be almost rid of them [01:55:28] hummmmm [01:55:41] I think the paypal orphan rectifier might also depend on DonationInterface under CRM [01:55:47] but it's a smaller amount of code [02:00:04] ok, updated https://etherpad.wikimedia.org/p/adyen-recurring-deploy [02:05:07] AndyRussG: I've got a way to run tests under Civi without that yet, so I can keep chugging on fixing the tests there [02:05:33] if you want to go ahead with your DonationInterface patch [02:17:10] oh fun, updating my testing db fails because it's making the civicrm_contribution_page table too large [02:18:53] woudja believe I actually backed up my dbs before upgrading this time? [02:19:05] ok, let's see if I can hack that table down to size [02:19:11] since we never use it [02:40:49] well heck, once I restore my backup Civi doesn't want to let me upgrade again [02:40:55] keeps telling me it's already upgraded [02:40:57] booooo [02:41:05] tried cc all, system.flush [02:46:56] (CR) Cstone: [C: +1] "I was able to get the error code (1000009) in the top level loop of SmashPigRecurringProcessor" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [02:47:11] boo for database issues [02:47:36] I wasn't trying to test this but I got 3 adyen recurrings to go through [02:48:16] ahh, nice [02:48:48] ok, I don't know if it was the necessary step, but I got the db to let me upgrade after also restoring the old drupal db [02:49:08] and now to try running the actual tests! [02:49:20] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help Pats with her query - https://phabricator.wikimedia.org/T244194 (Eileenmcnaughton) Ok - I've been playing & so far it looks lik... [02:50:47] I'm blanking on what payment_instrument_id is tied to [02:52:00] cstone: that's like Amex, MC, Visa [02:52:09] I think it's a group of civicrm_option_value rows [02:52:32] ah okay cause it was suddenly different for the two recurrings [02:54:22] from visa to check [02:56:22] ooh, weird... [02:56:31] did we change that somehow? [02:56:53] it should copy that from the previous donation in the subscription [02:58:26] yeah the trxn_id is also missing the RECURRING [02:59:42] ahh, I wonder if your setup is saving the contrib direct to the db or sending it to the queue [03:00:08] hmm [03:00:27] let's see, there should be a 'smashpig settings' somewhere in the civi menus [03:00:40] i think its sending directly [03:00:45] if its just an issue with my local settings then thats fine [03:01:14] so I didn't bake our trxn ID weirdness into the extension [03:01:31] but I think if you send the txns through the queue, the queue consumer should add that RECURRING prefix [03:02:02] ok cool [03:02:16] huh, my civi menu is gone locally [03:02:22] oh there it is [03:02:44] can you look under 'Administer' -> 'System Settings' -> 'SmashPig Settings' ? [03:02:54] Then enable 'Use queue for recurring' [03:03:13] with that, you'll have to run drush qc after the charge job [03:03:22] but it might get the trxn_id in there [03:03:30] it'll also create the wmf_contribution_extra row [03:04:35] yeah yep that worked thanks! [03:04:41] nice! [03:04:43] the payment_instrument is still 4 though [03:04:58] oh hmm its says recurring ingenico hah [03:05:13] hrm? [03:05:30] RECURRING INGENICO 853583463843757E [03:05:38] instead of adyen [03:05:52] good catch! [03:06:00] ok, lemme try to see where that's coming from [03:06:27] hah: 'gateway' => 'ingenico', // TODO: generalize [03:06:35] in recordPayment [03:06:42] hah [03:07:11] let's see, we have that string down at the level of the SmashPig.php payment processor subclass [03:07:42] it is also copying the payment_instrument_id from the previous: [03:07:43] 'payment_instrument_id' => $previousPayment['payment_instrument_id'], [03:11:46] (PS8) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [03:11:55] ok, ^^^ should get the gateway name right [03:13:15] ok cool [03:13:26] oh, that can be inside the 'if' block [03:17:52] (PS9) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [03:17:55] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [03:17:56] woohoo, and most of the tests are passing [03:18:23] well, locally, with my hack to copy those two enums to their old namespace [03:21:15] [gateway] => adyen woo [03:23:54] yee [03:24:03] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [03:26:16] oh nice, the ny times has an article on '4 tips to stop touching your face' [03:26:47] hah did you see the video of the lady reading about not touching your face then she promptly licks her finger to turn the page [03:27:23] oh man [03:27:58] my friends in japan just kept telling me when i was touching my face it kind of worked [03:28:49] oh hey, the non-queue version doesn't set the payment_instrument_id [03:28:53] Let's add that [03:29:45] ah so thats where the 4 was appearing from it did behave correctly on the queue [03:33:20] (PS10) Ejegg: WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [03:34:20] ok, ^^^ should set payment instrument correctly for direct saves, and now caches those gateway name lookups [03:34:54] all the SmashPig tests except the one for the fallback previous contribution lookup are passing locally! [03:35:01] (again, with the namespace hack) [03:35:34] woo! [03:39:27] (CR) jerkins-bot: [V: -1] WIP: Adapt SmashPig recurring processor for Adyen/Ingenico generic APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [03:43:27] do we ever do the direct save method? [03:49:03] cstone nope, I just included it on the theory that someone else might want to use our code someday [03:49:14] ok thats what i was thinking [03:49:25] hence less tested :( [03:49:37] well.... it's about 11 pm here [03:49:46] and I've just written my EOD email [03:49:50] yeah its late for you! [03:50:14] have a good (short) evening! [03:50:17] I guess we can regroup on this tomorrow and see how much smoke testing we can all do locally [03:50:30] see you tomorrow! [03:50:38] thanks for all the help [04:06:04] cstone is there an inaturalist-type app to identify animals by sound? [04:06:12] hmmm [04:06:21] i think cornell has a bird specific one [04:06:34] but i dont know of an all animal one [04:06:37] we have a really noisy squeaky thing in the backyard and I want to know if it's a cricket or a frog [04:06:59] haha [04:07:08] oh hey, there's a feature request: https://forum.inaturalist.org/t/recognize-sounds-automatically/3527 [04:08:44] noisy squeaky thing maybe some sort of katydid? [04:09:47] maybe! [04:10:07] ok, away for reals. night! [04:10:12] hah night! [09:08:58] (CR) Seddon: [C: +2] Adding new ids for lang and project multi-select tr elements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571767 (owner: Seddon) [09:34:17] (PS2) Seddon: Adding new ids for lang and project multi-select tr elements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571767 [15:04:16] (CR) Jgleeson: [C: -1] "So this code looks good, but I think we might have an issue that is related. I remembered that we get a mix of responses from Ingenico wit" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:07:36] (CR) Jgleeson: [C: -1] "I think the reason this hasn't come before is due to us throwing the ApiException if the top-level 'error' element was present and disrega" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:09:49] (CR) Jgleeson: [C: -1] "sometimes we GET both*** typo in the first reply." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:19:04] (CR) Jgleeson: "I just noticed that we're also moving the Response mapping (not just errors) into a method called processErrorsForResponseObject() in this" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [15:19:52] jgleeson: so looking now at the patches above ^ [15:20:02] feel like doing a quick video chat to talk through where things are? [15:20:10] also anyone else, fr-tech? ^ [15:20:27] argh I'm in the gym lobby! sorry so not the best place to do a video call [15:20:43] I'm heading home shortly though so can jump on in mayb an hour? [15:20:47] jgleeson: ah okok no worries! [15:20:47] maybe* [15:21:11] they have free wifi here so i thought I'd try working here. It's quiet but they kinda want it to STAY quiet lol [15:21:20] ah right [15:21:54] AndyRussG: the that last comment was just something minor I noticed when debugging another patch. [15:21:55] mmmm I have a meeting starting in 40 minutes, then I have to go pick up Sofi and take her to register for a school exam [15:22:02] s/the// [15:22:15] ah okok [15:22:30] I can fix it [15:22:49] I think an updated method name is all it needs [15:22:52] (unfortunately it's the only day they gave us to register... they day you have to go is determined by the first letter of your last name) [15:23:18] jgleeson: ah ok cool yeah go for it! I'll keep looking at ejegg's patch first then [15:26:01] also, here's today's gross humour: https://xkcd.com/2277/ [15:31:05] (CR) Jgleeson: [C: -1] "So your updated top-level error unit test is passing which confused me as I expected it to bomb out due to the mismapping. Turns out the R" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:31:24] Ok gonna relocate back home. back soon! [15:43:12] (CR) AndyRussG: "> Patch Set 12:" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/575806 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [15:47:30] (CR) Ejegg: "When we have a top-level 'errors' element, doesn't it contain the same errors as the nested payment errors?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [15:57:57] (PS1) AndyRussG: Minor fixes in Ingenico PaymentProvider class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577594 (https://phabricator.wikimedia.org/T246825) [16:08:27] jgleeson|baksoon: fr-tech the meeting I had was just suspended, so I'm good for getting on a hangout to go over stuff [16:09:27] AndyRussG: sounds good! [16:09:37] let's use the daily standup chat [16:09:44] ejegg: sure! [16:10:06] I'm there now [16:11:04] hmm, everything is loading slowly for me [16:11:08] might have to restart my router [16:12:37] okok no worries [16:18:13] (CR) Ejegg: [C: +2] Minor fixes in Ingenico PaymentProvider class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577594 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [16:18:37] (Merged) jenkins-bot: Minor fixes in Ingenico PaymentProvider class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577594 (https://phabricator.wikimedia.org/T246825) (owner: AndyRussG) [16:24:48] (PS2) Ejegg: Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) [16:25:15] (PS3) Ejegg: Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) [16:28:54] fr-tech is there a chat going on? [16:29:12] jgleeson: yes in today's standup hangout! [16:44:13] (PS4) Ejegg: Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) [16:44:34] (CR) jerkins-bot: [V: -1] Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [16:47:33] (PS5) Ejegg: Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) [16:51:06] Wikimedia-Fundraising-Banners: Prepare banners for Netherlands iDeal recurring/Adyen pre-test March 17 - https://phabricator.wikimedia.org/T247102 (TSkaff) [18:03:49] Wikimedia-Fundraising-Banners: Prepare banners for France Adyen recurring test - https://phabricator.wikimedia.org/T246804 (Pcoombe) @TSkaff Okay, the banners should be ready from a technical perspective now. They are getting to a recurring Adyen form, but I have no idea if that is actually ready for local t... [18:07:14] Wikimedia-Fundraising-Banners: Prepare banners for France Adyen recurring test - https://phabricator.wikimedia.org/T246804 (TSkaff) Great! I'm going to add the last most recent French copy into these. cc-ing @Ejegg just in case but I think the setup you have is correct. Elliott, [[ https://fr.wikipedia.org/... [18:12:45] Wikimedia-Fundraising-Banners: [Dsk Lg][Nag] Donation amount and currency symbol are on separate lines - https://phabricator.wikimedia.org/T247112 (jbolorinos-ctr) [18:23:24] Wikimedia-Fundraising-Banners: Prepare banners for France Adyen recurring test - https://phabricator.wikimedia.org/T246804 (jbolorinos-ctr) Ok yup! I just added myself to the Asana task, do you want me to add the links to that @TSkaff? [18:32:01] Wikimedia-Fundraising-Banners: Prepare banners for France Adyen recurring test - https://phabricator.wikimedia.org/T246804 (TSkaff) @jbolorinos-ctr Ok I [[ https://app.asana.com/0/1163790070029001/1159893416230353 | added them as subtasks ]]--not an ideal format but i can't work on that right at this moment-... [18:45:02] (PS1) Ejegg: Update PHPDoc comments for Ingenico PaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577643 [18:51:45] ejegg: how did you happen to come across this error with ingenico? 'Error 410110 : UNKNOWN ORDER OR NOT PENDING' [18:52:22] when testing our new code across DI and Smashpig I can see that error in the logs although it appears to be showing up for SUCCESSFUL donations in testing [18:52:49] if I do the same test using the current live version of DI and Smashpig I don't see the error [18:53:05] so it appears to be related to our new stuff for adyen/ingenico recurring/normsalisation [19:06:14] (PS11) Ejegg: Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [19:12:28] (CR) jerkins-bot: [V: -1] Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [19:17:40] jgleeson: ejegg|afk: fr-tech: hey I'm back from my errand, so can continue Adyening-out here [19:21:59] hey AndyRussG we're still on today's standup chat . I'm just working on the DI patch to update ingenico to use the new approvePayments sig [19:24:39] things just got a little tricker due to our standardisation on using 'gateway_txn_id' [19:27:50] jgleeson: ah cool! there in a sec! [19:28:33] Oh hey, I didn't know that was still going. I'll jump on shortly as well. [19:58:17] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Papaul) [19:58:56] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Papaul) [20:02:40] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Papaul) [20:19:12] (PS3) Jgleeson: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [20:20:40] (CR) jerkins-bot: [V: -1] Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [20:33:11] (PS1) Jgleeson: Tidy up Ingenico approvePayment api call params. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577667 (https://phabricator.wikimedia.org/T246863) [20:52:30] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time in RO and LV - https://phabricator.wikimedia.org/T247126 (jbolorinos-ctr) [20:52:49] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time in RO and LV - https://phabricator.wikimedia.org/T247126 (jbolorinos-ctr) p:Triage→Medium [20:55:53] (PS2) Ejegg: Update usage of constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576857 [20:57:10] (CR) jerkins-bot: [V: -1] Update usage of constants from SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576857 (owner: Ejegg) [20:59:18] (PS4) Jgleeson: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [21:00:10] (PS5) Jgleeson: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [21:00:31] (PS6) Jgleeson: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [21:02:08] (CR) jerkins-bot: [V: -1] Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [21:21:36] (PS1) Ejegg: Use FinalStatus::COMPLETE for CAPTURE_REQUESTED [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577674 (https://phabricator.wikimedia.org/T243340) [21:37:40] (CR) Ejegg: [C: +2] Tidy up Ingenico approvePayment api call params. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577667 (https://phabricator.wikimedia.org/T246863) (owner: Jgleeson) [21:39:36] (CR) Jgleeson: [C: +2] Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:39:57] (Merged) jenkins-bot: Ingenico: don't throw ApiError when top-level has 'errors' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577392 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:40:01] (CR) Jgleeson: [C: +2] Update PHPDoc comments for Ingenico PaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577643 (owner: Ejegg) [21:40:24] (Merged) jenkins-bot: Update PHPDoc comments for Ingenico PaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577643 (owner: Ejegg) [21:40:26] (Merged) jenkins-bot: Tidy up Ingenico approvePayment api call params. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577667 (https://phabricator.wikimedia.org/T246863) (owner: Jgleeson) [21:41:01] (CR) Jgleeson: [C: +2] Use FinalStatus::COMPLETE for CAPTURE_REQUESTED [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577674 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:41:22] (Merged) jenkins-bot: Use FinalStatus::COMPLETE for CAPTURE_REQUESTED [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577674 (https://phabricator.wikimedia.org/T243340) (owner: Ejegg) [21:43:52] (PS7) Jgleeson: WIP: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [21:45:17] (CR) jerkins-bot: [V: -1] WIP: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [21:45:31] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time in RO and LV - https://phabricator.wikimedia.org/T247126 (spatton) Looks like there's a conflict w/ this css rule, which appears to be set in the stylesheet for the vector skins on those wikis: ` #siteNotice div { margin: 0; } ` [21:59:46] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) [22:07:06] (PS12) Ejegg: Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [22:17:25] (CR) jerkins-bot: [V: -1] Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [22:20:09] (CR) Ejegg: "Thanks for the CR eileen! Sorry to take so long with these answers:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/564274 (owner: Ejegg) [22:25:58] ooh, can we update the php version requirement for SmashPig now? [22:26:03] I'mma do it [22:26:43] ooh, and if we update phpunit we can get scrutinizer to stop failing [22:27:11] let's see if that will need much changes to the tests [22:27:42] ok, so phpunit 6 is the last with php7.0 compatibility [22:27:45] will use that [22:45:40] (PS1) Ejegg: Update minimum PHP version and PHPUnit version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577686 (https://phabricator.wikimedia.org/T243421) [22:45:41] boo something is messed up with my local DI I cant even get the tests to run on master [23:00:09] cstone I'mma hop back on the call with AndyRussG in a minute [23:00:29] ok! [23:00:29] so maybe we can talk through the DI tests after we get the SmashPig version updated [23:04:47] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue (Tracking), Performance-Team (Radar), Readers-Web-Backlog (Tracking): Safari crashes on some click handling events for banners that move the centralNotice element outside of the the ma... - https://phabricator.wikimedia.org/T242895 [23:20:57] (CR) Cstone: [C: +2] Update minimum PHP version and PHPUnit version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577686 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [23:21:13] (Merged) jenkins-bot: Update minimum PHP version and PHPUnit version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/577686 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [23:48:12] (PS1) Ejegg: Change version constraint for smashpig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/577695 [23:48:37] (CR) Ejegg: [C: +2] Change version constraint for smashpig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/577695 (owner: Ejegg) [23:49:19] (CR) jerkins-bot: [V: -1] Change version constraint for smashpig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/577695 (owner: Ejegg) [23:51:05] (CR) Ejegg: [C: +2] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/577695 (owner: Ejegg) [23:52:04] (CR) jerkins-bot: [V: -1] Change version constraint for smashpig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/577695 (owner: Ejegg) [23:54:01] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) Couple of commits to set up keys and merge repos: ` Date: Fri Mar 6 21:35:43 2020 +0000 Subject: [frack::puppet] 013638dc Adding frpm2001 as a puppetmaster Need to designate it as a puppet... [23:54:24] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) [23:55:10] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Dwisehaupt) [23:55:30] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Dwisehaupt) Interface bonding set up and activated.