[00:27:31] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (CDenes_WMF) Hi Dallas! Yubikey Public ID: cccccckudvcb ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCqYzeFwj7RC/Oti0fXiEJyyofoyLUU59XkCVsu3V2RW1wNw9sF5pMM+ElCKqyQ53XrkuWhtwLSTcmzZ67N8VFUbq... [00:42:27] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time in RO and LV - https://phabricator.wikimedia.org/T247126 (jbolorinos-ctr) Hey @Pcoombe, I'm still seeing this bug when I use this link: https://ro.wikipedia.org/wiki/wikipedia?banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=RO Has th... [01:05:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [01:06:03] Wikimedia-Fundraising-Banners: [Enhancement] Keep Paypal and CC options visible on Desktop Small - https://phabricator.wikimedia.org/T247276 (jbolorinos-ctr) [01:10:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [01:15:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [01:20:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1821 [01:25:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2121 [01:30:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [01:35:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2722 [01:40:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3021 [01:45:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [01:50:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [01:55:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [02:00:15] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [02:05:15] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 9399954 Threads: 4 Questions: 2984470214 Slow queries: 757950 Opens: 1830581 Flush tables: 1 Open tables: 200 Queries per second avg: 317.498 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 177 [04:05:15] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 2 others: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (Eileenmcnaughton) OK so plan is to ad... [07:24:00] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Prepare CN deploy 2020-03 - https://phabricator.wikimedia.org/T246461 (AndyRussG) >>! In T246461#5945348, @mepps wrote: > These are the patches I see waiting for review (aside from Geotargeting and Ba... [07:30:07] Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Prepare CN deploy 2020-03 - https://phabricator.wikimedia.org/T246461 (AndyRussG) Also, before we merge `master` to `wmf_deploy` we should properly revert [[ https://gerrit.wikimedia.org/r/c/mediawiki... [10:45:37] Wikimedia-Fundraising-Banners: [Enhancement] Keep payment method options visible on Desktop Small - https://phabricator.wikimedia.org/T247276 (Pcoombe) [11:32:08] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time in RO and LV - https://phabricator.wikimedia.org/T247126 (Pcoombe) No, I hadn't merged the change to the bundle desktop small banner, as I was waiting for feedback. I have done this now - [diff](https://meta.wikimedia.org/w/index.p... [13:20:09] Wikimedia-Fundraising-Banners: Single question mark on newline in Opt-in text in French - https://phabricator.wikimedia.org/T247270 (Pcoombe) Should be fixed now. The solution is to use a non-breaking space ` ` before punctuation marks, I went through the French translations and made sure this was done... [13:40:49] Wikimedia-Fundraising-Banners: Missing emoji colors on IE 11 - Opt in - https://phabricator.wikimedia.org/T247263 (spatton) @jbolorinos-ctr, the screenshot is of our desktop large banner, but your link in step 1 is to our desktop small banner; can you reconcile that? Looks like we've made some tweaks to the... [13:44:47] Wikimedia-Fundraising-Banners: Establish naming convention for shared banner UI elements - https://phabricator.wikimedia.org/T241857 (spatton) [13:45:09] Wikimedia-Fundraising-Banners: Establish naming convention for shared banner UI elements - https://phabricator.wikimedia.org/T241857 (spatton) [13:57:30] Wikimedia-Fundraising-Banners: Percentage and number on different lines for PTF - https://phabricator.wikimedia.org/T247269 (Pcoombe) @CDenes_WMF confirmed that a space between the number and % sign isn't needed for Romanian, and @TSkaff already fixed that. Thanks! I checked the other languages with % and f... [14:41:39] Wikimedia-Fundraising-Banners: [Enhancement] Keep payment method options visible on Desktop Small - https://phabricator.wikimedia.org/T247276 (spatton) Just noting that this is the behavior on mobile small, too. I like the idea of testing variants that keep the methods visible - I'll get that in our design q... [15:00:22] Wikimedia-Fundraising-Banners: Desktop large nag - button wrongly sized in Internet Explorer - https://phabricator.wikimedia.org/T247311 (Pcoombe) [15:03:27] hi fr-tech! [15:03:41] hi ejegg! [15:03:41] irssi just didn't want to start this morning [15:03:56] had to fool it into thinking it wasn't running under `screen` [15:04:10] Wikimedia-Fundraising-Banners: [Dsk Lg][Nag] Donation amount and currency symbol are on separate lines - https://phabricator.wikimedia.org/T247112 (Pcoombe) So there are two issues here: - We generally don't have white-space: nowrap; on the amount replacements any more. I tried just changing the frb.currenc... [15:04:24] looks like you didn't take the holiday mepps? [15:04:54] yeah ejegg i'd sort of forgotten about it so i just wehnt ahead and worked [15:05:05] hehe, nice, now you have a bonus day! [15:05:06] hey ejegg [15:05:20] hi jgleeson! [15:47:32] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 2 others: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (Ejegg) Weird, that COMPILE_CHECK cons... [15:48:47] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 2 others: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (Ejegg) Ahh, and that documentation pa... [16:06:20] fr-tech it looks like this patch is no longer WIP right? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/575827/ I think the tests are now passing so we can probably update the commit message [16:06:56] mornafternoon ejegg mepps jgleeson fr-tech [16:07:13] howdy AndyRussG :)_ [16:07:43] :) [16:09:35] Wikimedia-Fundraising-Banners: Percentage and number on different lines for PTF - https://phabricator.wikimedia.org/T247269 (TSkaff) Romanian space is fixed [16:12:14] jgleeson: hey.. wrt that patch, though I uploaded the first version, I don't know enough about those parts of the puzzle to say much [16:14:48] AndyRussG: I added a few bits to it last week and it looks like ejegg has finished out the remaining tests that were failing. ooo it looks like it's failing in CI due to code sniff violations so lemme fix that [16:19:15] (PS12) Jgleeson: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [16:42:09] jgleeson: nice! [16:47:45] ejegg fr-tech is https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/576536 also ready, other than CI issues? [16:48:22] all that should be needed there for ci is running composer fix locally--i tried to do it but i can't commit to someone else's patch apparently [16:48:28] but i don't know the larger answer [16:49:39] Also fr-tech I guess the best thing to do now is smoke test, as per ejegg's Friday EoD e-mail? [16:49:57] Yea, I think that's what's needed. [16:50:41] I think ejegg had some ideas on what specifically still needs it [16:51:32] AndyRussG: yep, that one just needs us to update the composer version of the donation-interface library [16:51:54] which we can do once we +2 the patch in DonationInterface [16:52:04] let's see, who has clean hands on that one? :) [16:52:34] mepps or cstone do you want to talk through that DI patch and see if there are any outstanding doubts [16:52:37] ? [16:53:03] ah cool thanks mepps ejegg XenoRyet [16:53:18] if i remember correctly that one was just an issue with tests when we left it last? [16:53:44] Also, I guess we can compare the differences between current code and the last donation-interface library version, to see if there's anything to worry about WRT the recurring globalcollect and the orphan rectifiers (places where we use DI under CRM) [16:53:46] ejegg: did the adyen skins get updated? [16:53:51] cstone those should be fixed now! [16:53:54] I'm getting redirects to mediawiki.d [16:53:57] jgleeson I did change those back [16:54:02] ooh yeah i see that [16:54:06] I forget where we managed that? [16:54:09] the one named 'ejegg' is again specialized for me [16:54:10] locally [16:54:20] and the one named 'frdev' is the generic vagrant URL [16:54:24] could we not just change the skins ID? [16:54:27] locally [16:54:39] jgleeson yep yep, but I think you have to change the HMAC too [16:54:41] * jgleeson needs to start add 'locally' in the same line [16:54:46] ahhh [16:54:56] so that's why we start using the preexist [16:54:58] ing [16:55:00] * jgleeson grrr [16:55:11] lemme check which credentials we have up on the localsettings repo [16:57:34] thanks! I've gotta pop out to pick up Oscar but I'll be back soon! [17:00:35] Fundraising-Backlog, fundraising-tech-ops: Audit mysql grants and ensure the grant scripts reflect the current reality - https://phabricator.wikimedia.org/T243342 (Dwisehaupt) Open→Stalled [17:13:52] learning nothing from friday afternoon I was not sshed into vagrant :P [17:14:52] haha [17:16:19] tests are passing now :) [17:22:18] donations going through too looks good for me [17:22:20] yay! [17:22:25] ok, great [17:22:38] so once we +2 that donationinterface patch [17:22:55] we can do a git tag / packagist update dance [17:23:04] and then maybe the crm patch will pass CI! [17:23:25] (CR) Cstone: [C: +2] "Local donations working and local tests passing for me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [17:24:49] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, and 3 others: Cull low value data from activity table - https://phabricator.wikimedia.org/T245088 (NNichols) I feel like even though we have contributions logged on... [17:28:15] cstone: thanks! :) [18:02:40] OK that's updated [18:02:46] I'll test a donation [18:10:29] this is strange. I'm getting my donations refused using the test card details [18:11:15] ooo Refused (DECLINED Expiry Incorrect) [18:11:36] oops [18:11:40] I was entering 03/2020 [18:11:47] and I should have been entering 03/2030 [18:15:57] cstone: I've just put through a local donation and the IPN messages have arrived from adyen. I'm not gonna run the local jobs to hopefully capture the first payment and then move on to testing the recurring payment in civi [18:16:10] I'm now* [18:16:27] ok cool [18:16:59] this cold isn't helping my cognitive functioning grr [18:17:06] i see you in the adyen console hah im the ones that start with 157 [18:18:18] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [18:22:12] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 4 minutes ago with 27 failures. Failed resources (up to 3 shown) [18:23:12] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [18:27:12] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 9 minutes ago with 27 failures. Failed resources (up to 3 shown) [18:28:18] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [18:28:57] who wants to update the donation-interface package version? [18:29:36] looks like there we do have a thing to mark the version number in code [18:30:04] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/extension.json$3 [18:30:11] fr-tech ^^ [18:32:12] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 25 seconds ago with 27 failures. Failed resources (up to 3 shown) [18:33:12] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [18:34:32] this is strange [18:34:58] the donation generated on the back of my ayden capture job generated a non-recurring donation in the redis queue [18:37:12] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 5 minutes ago with 27 failures. Failed resources (up to 3 shown) [18:37:17] jgleeson: is the skin stuff you were looking at earlier because you weren't getting a thank you page? [18:37:46] cstone: paymentwiki was being redirected to a broken URL [18:38:00] so not jumping out of the iframe to the thankyou page [18:38:07] ok i think im running into the same thing [18:38:12] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [18:38:17] ACKNOWLEDGEMENT - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 5 minutes ago with 27 failures. Failed resources (up to 3 shown): Dwisehaupt known error on new build host. [18:38:23] oh no that's not good [18:39:12] cstone: does this URL load for you? https://payments.wiki.local.wmftest.net:4430/w/index.php?title=Special:AdyenGatewayResult [18:39:17] ACKNOWLEDGEMENT - check_mysql on payments2001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) Dwisehaupt Checking issue after grant update [18:39:17] ACKNOWLEDGEMENT - check_mysql on payments2002 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) Dwisehaupt Checking issue after grant update [18:39:23] yes [18:40:08] ok so my problem was that the previous returnURL was https://payments.wiki.local.wmftest.net:4430/index.php?title=Special:AdyenGatewayResult and not https://payments.wiki.local.wmftest.net:4430/w/index.php?title=Special:AdyenGatewayResult (additional /w/) [18:40:37] so I updated the adyen test skin returnURL for SkinCode LjCGSSpF to that second URL [18:45:39] OK I've managed to get a recurring donation into civi and now at the point where I can run the smashpig extension [18:46:10] although I think I have some tinkering around to do to get the crm side of things using the right version of smashpig [18:46:19] yeah im at the same point hah [18:46:30] thanks for the detailed instructions in your eod email btw ejegg !!!! super helpful [18:47:49] oh crap I've just remembered I need to go the pharmacy before the mid-sprint checkin, back soon! [19:10:02] (PS1) Ejegg: Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 [19:10:20] fr-tech can someone give that the quick +2? ^^^ [19:10:27] sure [19:10:35] then we can update the packagist version for donation-interface [19:10:41] to 2.5.0 [19:10:48] and then crm testing should be easier [19:10:54] (CR) Cstone: [C: +2] Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 (owner: Ejegg) [19:10:56] (CR) Mepps: [C: +2] Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 (owner: Ejegg) [19:11:05] double +2! [19:11:13] oh cstone you beat me to it! :) [19:11:29] (CR) jerkins-bot: [V: -1] Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 (owner: Ejegg) [19:14:54] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 2 others: Work to reduce smarty cruft on the server - https://phabricator.wikimedia.org/T241688 (Eileenmcnaughton) yep [19:18:18] PROBLEM - check_mysql on payments2003 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) [19:19:27] ACKNOWLEDGEMENT - check_mysql on payments2003 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) Dwisehaupt fixing up perms [19:20:25] Fundraising-Backlog: Ingenico audit-file 3-9-2020 question - https://phabricator.wikimedia.org/T247345 (DStrine) [19:20:48] ooh, what was that -1? [19:20:50] Fundraising-Backlog, FR-Civi-Dedupe: Estimate amount of not-yet Deduped Civi Records - https://phabricator.wikimedia.org/T247343 (DStrine) [19:21:20] huh??? [19:21:33] not found SmashPig\CrmLink\FinalStatus ??? [19:21:49] that was the error i was getting when it wasn't looking at 6 [19:22:37] wait, didn't we merge the other bit already? [19:23:09] ahhh, no, https://gerrit.wikimedia.org/r/576857 still needs +2 [19:23:20] fr-tech anyone up for that? ^^^ [19:23:23] is that the constant one? [19:23:25] I'll rebase that version bump [19:23:28] cstone yeah [19:23:31] I just killed a query - soft credit related [19:23:40] cstone totally search-and-replace [19:24:42] hey eileen i'm looking at: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/576443 [19:25:00] yes mepps? [19:25:01] (PS2) Ejegg: Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 [19:25:03] i tried out installing the extension and going to an image upload, is that the right way to test? [19:25:20] oh derp, you said eileen not elliott [19:26:36] haha i did ejegg :) [19:27:10] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, and 3 others: Delete contacts deleted before 2017 - https://phabricator.wikimedia.org/T245087 (Eileenmcnaughton) Turning job off now Deleted contacts now: |... [19:27:11] (CR) Cstone: [C: +2] "Tests passing and local donation went through" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576857 (https://phabricator.wikimedia.org/T246863) (owner: Ejegg) [19:30:51] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Delete more deleted contacts? - https://phabricator.wikimedia.org/T247347 (Eileenmcnaughton) [19:30:59] (Merged) jenkins-bot: Update SmashPig & usage of SmashPig constants [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/576857 (https://phabricator.wikimedia.org/T246863) (owner: Ejegg) [19:31:04] (Merged) jenkins-bot: Use new SmashPig approvePayment() signature in Ingenico adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/575827 (https://phabricator.wikimedia.org/T246863) (owner: AndyRussG) [19:31:54] mepps: yep ckeditor5 [19:37:48] (CR) Cstone: [C: +2] Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 (owner: Ejegg) [19:43:20] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/578392 (owner: Eileen) [19:49:02] (Merged) jenkins-bot: Update version in extension.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/578587 (owner: Ejegg) [20:03:12] RECOVERY - check_mysql on payments2001 is OK: Uptime: 138 Threads: 11 Questions: 553 Slow queries: 0 Opens: 286 Flush tables: 1 Open tables: 93 Queries per second avg: 4.007 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [20:05:37] (PS1) Jgleeson: Update donation interface composer package to ^2.5 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) [20:10:23] !log process-control config revision is 2d7b926c1d [20:10:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:11:44] !log civicrm revision changed from 10506a9644 to 3de711ed49, config revision is 2d7b926c1d [20:11:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:14:33] Wikimedia-Fundraising-Banners: Entering too many numbers in the Other donation amount field pushes form out of view - https://phabricator.wikimedia.org/T246367 (jbolorinos-ctr) @scervantes I think it might be better for you to maybe look into this if you have some time? I know Peter is prepping a million thi... [20:15:08] (PS2) Jgleeson: Update donation interface composer package to ^2.5 and smashpig to ^0.6 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) [20:19:22] Wikimedia-Fundraising-Banners: Missing emoji colors on IE 11 - Opt in - https://phabricator.wikimedia.org/T247263 (jbolorinos-ctr) Hey @spatton, I apologize for the confusion, I'm pasting a lot of different links around in this Big Bundle QA so this was bound to happen, so I'll make sure to double/triple ch... [20:19:55] Wikimedia-Fundraising-Banners: Missing emoji colors on IE 11 - Opt in - https://phabricator.wikimedia.org/T247263 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr [20:28:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue (Tracking), Performance-Team (Radar), Readers-Web-Backlog (Tracking): Safari crashes on some click handling events for banners that move the centralNotice element outside of the the ma... - https://phabricator.wikimedia.org/T242895 [20:30:58] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time in RO and LV - https://phabricator.wikimedia.org/T247126 (jbolorinos-ctr) Hey @Pcoombe, Ok awesome! Thanks for posting the diff link, and yes my apologies for the confusion, the issue reported in this task is only affecting Deskto... [20:48:12] (PS3) Jgleeson: Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) [20:50:21] (CR) Mepps: [C: +2] Add new ckeditor5 extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576443 (https://phabricator.wikimedia.org/T244323) (owner: Eileen) [20:50:46] (CR) Ejegg: [C: +2] Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) (owner: Jgleeson) [20:54:06] (CR) jerkins-bot: [V: -1] Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) (owner: Jgleeson) [20:57:03] (Merged) jenkins-bot: Add new ckeditor5 extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576443 (https://phabricator.wikimedia.org/T244323) (owner: Eileen) [20:59:28] (PS4) Jgleeson: Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) [20:59:30] (PS13) Jgleeson: Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [21:05:31] (CR) jerkins-bot: [V: -1] Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) (owner: Jgleeson) [21:06:32] (CR) jerkins-bot: [V: -1] Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [21:08:12] PROBLEM - check_mysql on payments2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) [21:13:10] Wikimedia-Fundraising-Banners: Percentage and number on different lines for PTF - https://phabricator.wikimedia.org/T247269 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr Fix verified {F31674843} Closing this now. Thanks everyone! [21:13:12] RECOVERY - check_mysql on payments2001 is OK: Uptime: 270 Threads: 12 Questions: 71 Slow queries: 0 Opens: 33 Flush tables: 1 Open tables: 27 Queries per second avg: 0.262 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [21:22:09] Wikimedia-Fundraising-Banners: [Dsk Lg][Nag] Donation amount and currency symbol are on separate lines - https://phabricator.wikimedia.org/T247112 (Pcoombe) The wrapping for this and other %MINIMUM% / %AVERAGE% replacements should be fixed now. I made a change to LocalizeJS to wrap them in a custom element:... [21:23:18] RECOVERY - check_mysql on payments2003 is OK: Uptime: 307 Threads: 10 Questions: 107 Slow queries: 0 Opens: 38 Flush tables: 1 Open tables: 32 Queries per second avg: 0.348 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [21:32:39] Fundraising-Backlog, fundraising-tech-ops: Audit mysql grants and ensure the grant scripts reflect the current reality - https://phabricator.wikimedia.org/T243342 (Dwisehaupt) Did a little cleanup related to the root user after tests today. @Jgreen is still looking at it and will review the work as we ta... [21:33:25] Wikimedia-Fundraising-Banners: Entering too many numbers in the Other donation amount field pushes form out of view - https://phabricator.wikimedia.org/T246367 (Pcoombe) Is this Lowest priority or not? You don't need to keep bumping it. [21:33:27] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) [21:33:33] (PS5) Ejegg: Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) (owner: Jgleeson) [21:37:16] (PS14) Ejegg: Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [21:48:31] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/578614 [21:49:17] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/578614 (owner: Eileen) [22:15:12] thanks eileen! [22:17:01] for ? [22:17:09] RECOVERY - check_puppetrun on frpm2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [22:23:08] (PS1) Eileen: Don't parse non-smarty through smarty [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/578626 (https://phabricator.wikimedia.org/T241688) [22:23:39] ejegg: can you check that one ^^ - it should be trivial but I'm keen to do some comparisons on cruft-creation [22:24:54] ejegg im getting some food but I realize now I have no idea how to test run the orphan rectifier [22:33:32] (PS1) Eileen: Remove org.wikimedia.sendannualtyemail now it is merged & disabled [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578631 (https://phabricator.wikimedia.org/T245580) [22:34:25] ^^ is the last step in merging those 2 extensions - removing the now-empty one as I've disabled it on live & the new combined one is working on live [22:37:19] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 3 others: Merge wmf_thankyou & annual emails extension - https://phabricator.wikimedia.org/T245580 (Eileenmcnaughton) This is back in... [22:49:06] (PS1) Eileen: Fix mis-casing in css file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578635 (https://phabricator.wikimedia.org/T244323) [22:49:17] Another super trivial change ^^ [22:54:44] Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 3 others: Alternative method to Create settings_location.php - https://phabricator.wikimedia.org/T244323 (Eileenmcnaughton) @MBeat33 @... [22:56:31] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, and 3 others: Cull low value data from activity table - https://phabricator.wikimedia.org/T245088 (Eileenmcnaughton) @NNichols is having that in the activity tab use... [23:13:26] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) Initial commits pushed: ` [frack::puppet::private] bee2fc1 Adding cdenes as a user (Dallas Wisehaupt:Dallas Wisehaupt) Adding her yubikey and public ssh key. Bug: T24639... [23:17:51] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) [23:19:43] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) @spatton @CDenes_WMF I'm looking for a little clarity on what will be needed with this access. IE: will database access be needed of just basic shell access? [23:25:38] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help Pats with her query - https://phabricator.wikimedia.org/T244194 (Eileenmcnaughton) I've scheduled one report to go out (id = 46... [23:27:39] (CR) Ejegg: [C: +2] "Heh, that pluralize thing could be fun" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/578626 (https://phabricator.wikimedia.org/T241688) (owner: Eileen) [23:28:53] (CR) Eileen: "ejegg the pluralize fn is merged to core & gave me a merge-conflict so I just brought it in with this - next core upgrade we'll 'get it'" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/578626 (https://phabricator.wikimedia.org/T241688) (owner: Eileen) [23:30:41] (CR) Ejegg: [C: -1] "One more fix needed in the same file" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578635 (https://phabricator.wikimedia.org/T244323) (owner: Eileen) [23:32:28] (CR) Ejegg: [C: +2] Remove org.wikimedia.sendannualtyemail now it is merged & disabled [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578631 (https://phabricator.wikimedia.org/T245580) (owner: Eileen) [23:33:13] (PS2) Eileen: Fix mis-casing in css file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578635 (https://phabricator.wikimedia.org/T244323) [23:33:39] (CR) Eileen: Fix mis-casing in css file (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578635 (https://phabricator.wikimedia.org/T244323) (owner: Eileen) [23:35:07] (CR) Ejegg: [C: +2] Fix mis-casing in css file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578635 (https://phabricator.wikimedia.org/T244323) (owner: Eileen) [23:35:21] (Merged) jenkins-bot: Don't parse non-smarty through smarty [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/578626 (https://phabricator.wikimedia.org/T241688) (owner: Eileen) [23:37:12] (PS1) Eileen: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578642 [23:38:12] (CR) Eileen: [C: +2] CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578642 (owner: Eileen) [23:38:51] (Merged) jenkins-bot: Remove org.wikimedia.sendannualtyemail now it is merged & disabled [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578631 (https://phabricator.wikimedia.org/T245580) (owner: Eileen) [23:38:59] ejegg: are you gonna face that installments one too ? (you don't have to - just thinking about deploying) [23:41:33] (Merged) jenkins-bot: Fix mis-casing in css file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578635 (https://phabricator.wikimedia.org/T244323) (owner: Eileen) [23:41:38] Fundraising-Backlog, fundraising-tech-ops: Audit mysql grants and ensure the grant scripts reflect the current reality - https://phabricator.wikimedia.org/T243342 (Dwisehaupt) With the new check option, it's possible we could automate the query of grants and notification if they fall outside the expected... [23:43:11] eileen I'll do that after we deploy the other recurring stuff! [23:44:23] fr-tech shall we turn the recurring charge jobs off so that we can deploy the new code and have a fresh batch to test on at 0:00 UTC ? [23:44:32] (Merged) jenkins-bot: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578642 (owner: Eileen) [23:47:06] (PS6) Ejegg: Composer updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/578594 (https://phabricator.wikimedia.org/T242278) (owner: Jgleeson) [23:47:34] daylight savings time causing me all the confusion there [23:48:02] (PS15) Ejegg: Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [23:48:04] i'mma go ahead and turn those off in case we DO want to go ahead [23:48:09] I was like it already ran! [23:50:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [23:50:16] !log disabled recurring donation charge jobs for upgrade [23:50:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:50:52] eileen: do you want to deploy what's merged right now before we do the adyen recurring bits? [23:51:29] Fundraising-Backlog, fundraising-tech-ops: Create process to actively monitor active mysql grants vs what the grant scripts hold - https://phabricator.wikimedia.org/T247371 (Dwisehaupt) [23:52:02] cstone: so I'm just looking at the *orphan* scripts up on frpm1001 [23:52:10] and will try running all those drush jobs locally [23:52:34] Fundraising-Backlog, fundraising-tech-ops: Create process to actively monitor active mysql grants vs what the grant scripts hold - https://phabricator.wikimedia.org/T247371 (Dwisehaupt) a:Dwisehaupt→None [23:52:35] the good thing is it looks like most things in DonationInterface haven't changed since we put out 2.4.0 in September 2019 [23:52:45] so I don't see much risk on that front [23:54:55] (CR) jerkins-bot: [V: -1] Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [23:55:04] time to start getting dinner moving along. see you all tomorrow. [23:55:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1397 [23:55:32] hmm, what's that -1 ? [23:56:00] ejegg: sure [23:57:05] (PS16) Ejegg: Adapt SmashPig recurring processor to PaymentProcessor interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/576536 (https://phabricator.wikimedia.org/T242278) (owner: AndyRussG) [23:58:37] cstone I tried with the ingenico orphan rectifier and it failed because i'm missing some configuration. not sure if that config exists in vagrant or not! [23:58:49] s/or not// [23:59:09] hey back at computer sorry [23:59:54] i've got the embedded donationinterface lib settings in donationinterface.settings.php