[01:05:46] (PS1) Cstone: WIP: Ignore iDEAL ipn messages. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) [01:55:23] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Papaul) [02:05:48] (Abandoned) Ejegg: Update smash-pig library to 0.6 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/577700 (owner: Ejegg) [02:08:12] (Abandoned) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/576846 (owner: Ejegg) [02:09:13] (Restored) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/579335 (owner: Ejegg) [02:32:55] (CR) Ejegg: [C: -1] "Code looks great now! Unfortunately a typo gremlin snuck into the centralnotice-all message key." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571768 (https://phabricator.wikimedia.org/T243011) (owner: Mepps) [03:46:08] (PS1) Ejegg: Set financial type ID on ContributionRecur record [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/579462 [03:48:52] (CR) Ejegg: [C: +1] "This looks like all we need! Ready to un-WIP, or did you want to add a test?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [03:53:12] (CR) jerkins-bot: [V: -1] Set financial type ID on ContributionRecur record [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/579462 (owner: Ejegg) [12:37:14] Wikimedia-Fundraising-Banners: Stacked cc logos in payment option button on iPad mini - https://phabricator.wikimedia.org/T247579 (spatton) Hey @jbolorinos-ctr, is this a duplicate of T240730? [13:54:34] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install fran1001 - https://phabricator.wikimedia.org/T245554 (Jgreen) [14:16:02] mornafternoonsies fr-tech [14:16:20] can anyone remind me where DI accesses SmashPig from? (like the directory location?) [14:16:38] fundraising-tech-ops: rack/setup/install replacement pay-lvs2002.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242268 (Jgreen) Open→Resolved [14:16:40] fundraising-tech-ops: 2019-2020 Q3 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T242257 (Jgreen) [14:16:45] thx in advance! [14:17:59] hey hey AndyRussG :) [14:18:23] AndyRussG: I think it's vendor/wikimedia/smash-pig [14:18:34] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install fran1001 - https://phabricator.wikimedia.org/T245554 (Jgreen) [x] fixed BIOS serial port setting to redirect console output after boot [14:19:18] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Adyen: edit an internal adyen recurring donation to test it - https://phabricator.wikimedia.org/T243338 (Ejegg) Done! I edited the recurring contribution and th... [14:19:27] jgleeson: ahhh yeah right thanks! [14:28:27] stockpiling is getting extreme around here already. I couldn't buy nappies(diapers) today as they were sold out at every shop [14:29:51] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install fran1001 - https://phabricator.wikimedia.org/T245554 (Jgreen) @Cmjohnson DHCP request appear to be in the incorrect vlan (frack-administration-eqiad), can you please confirm the port settings to make sure both... [14:29:56] jgleeson: oh no! [14:30:14] I heard in Montreal there's a shortage of toilet paper [14:30:25] yeah we have that here also [14:30:29] and basic meds [14:30:33] oh no! [14:31:06] I think the contagion and the panic buying hasn't reached here quite yet... though I think in the north of Mexico it has [14:31:09] Maybe I should stock up [14:31:29] kinda unsure what to do, trust the supermarkets and government that supplies will arrive or join the bandwagon and order a truck load of supplies online for delivery and add to the shortage... [14:31:57] hmmm yeah it's a dilemma [14:32:04] no good options really [14:45:47] I would say baby poop containment is a big requirement [14:46:01] maybe also buy some cloth diapers as backup? [14:48:56] I'm gonna pop out again later to see if I can pick some up further afield [15:33:10] (CR) Jgleeson: [C: -1] WIP: Ignore iDEAL ipn messages. (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [15:45:27] fr-tech does anyone know where on the live adyen account we configure the IPN additonal data elements sent back with the IPN messages we get on live? I've just logged into the live console and it looks like we don't have any server communication profiles set up on live like we do on test which has got me scratching my head [15:48:05] oh hey it looks like we do have a server communication profile on live it was just against a the WikimediaDonations account and not the WikimediaFoundation account that I login with [15:49:38] hmm it looks like we don't check any additional data options other than 'Add Acquirer Result' [16:27:09] jgleeson: ah yeah, that merchant / company account distinction is confusing [16:30:02] (CR) AndyRussG: "Nice!! I guess my overall comment would be, I wonder if there isn't a nice way to encapsulate different mechanisms for rtbt and cc process" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [16:31:07] (CR) Ejegg: [C: +1] "jgleeson we seem to get two messages for each ideal donation. We can ignore the first one (authorization) since our response to auth messa" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [17:01:13] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install fran1001 - https://phabricator.wikimedia.org/T245554 (Cmjohnson) updated the vlan from administration to fundraising [17:48:26] (PS2) Cstone: Ignore iDEAL ipn messages. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) [18:06:48] fr-tech I wonder if renaming our smashpig payments methods from create/approve to authorise/capture would be a worthy cause to prevent any possible future confusion as we scale up? [18:07:23] or maybe create and capture? [18:07:43] Is there a sort of industry standard across payment providers for the terminology there? [18:07:54] the approvePayment() name we have at the moment feels like it suggests something it isnt [18:08:14] is capture just credit card focused or all types? [18:08:24] I think it's cc specific [18:08:29] maybe authorize/approve? or is approve credit cardy too hmm [18:08:52] so approve suggests to me at least that it's more of an auth thing [18:08:56] but it's not [18:09:06] it's the capturing of an early authenticate call [18:10:34] I think our current mapping is (wmf)crate=(pgp)authorise and (wmf)approve=(pgp)capture [18:10:38] grr [18:10:41] create* [18:11:28] jgleeson we're following the ingenico conventions with create/approve [18:11:58] and I feel like they have that because authorize/capture terms are specific to the credit card work flow [18:12:54] hmm [18:13:02] so does that mean for non-card payments we just use create [18:13:35] as the approve/capture step is cc specific [18:14:00] does authorise not fit as a first step for non-cc payments too/ [18:15:02] currently we use create as the first step for all and approve as the second for card only I think ? [18:16:08] I guess it makes sense to go with ingenico's convention if they're are primary pgp for now [18:16:41] our** [18:21:51] Note that the PENDING_APPROVAL status is used for payments that only allow a single capture. Such a capture will update the status of the payment. The similar PENDING_CAPTURE status is used for payments that allow multiple captures. These captures can be done using the capture payment API and result in a new Capture object. [18:22:00] https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/payments/approve.html?paymentPlatform=ALL#payments-approve [18:22:10] it looks like ingenico offer both approve and capture [18:22:22] alongside create [18:22:48] they also have complete payment [18:23:04] with specific use cases for each [18:24:00] hmm [18:25:09] I wonder if create/complete is more accommodating to different final stages [18:25:58] the ingenico approve step is specific to a particular use case [18:29:01] i like create/complete [18:30:28] yeah I'm just thinking out loud. It's confusing stepping into a method to see it do something else at the API level and wondering if we could harmonise the steps betters across different gateways [18:31:50] but then I guess it also has to be for non-cc tnxs too (deliberately omitting the r) :) [18:32:07] ok let's push up this renaming patch [18:37:27] cedit cad? [18:38:04] ya [18:38:12] :) [18:38:31] ejegg: I'm confused by your comment on cstone's patch [18:39:07] don't we only get the second (capture) IPN because of first job completing? [18:39:22] hmm yeah i think we only do get the 2nd ipn when the first completes [18:39:36] yeah so we don't get the second it we return early there [18:41:35] the capture state of an ideal txn is an anomaly anyway so we could just continue with that code and avoid triggering the capture IPN [18:41:57] but that would mean we only write it to the donations queue in one place to my understanding ejegg ? [18:42:12] (PS1) Jgleeson: Rename PaymentCaptureAction to ProcessAuthorizeMessageAction. Rename ProcessCaptureRequestJob to CaptureRequestJob. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579605 [18:42:23] if we were looking at the 2nd one too we would have no idea if it was a first recurring vs one time donation too [18:43:05] ya good point, we still not worked out any way to make that distinction with ideal IPNs? [18:44:11] i didnt try going through the addtionaldata list again but i wasnt getting browser data or subscription data with it [18:52:05] (CR) Jgleeson: [C: -1] "@ejegg I think we only get the second (capture) message for iDEAL transactions if this action gets to line 41 right? https://gerrit.wikime" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [18:52:10] (CR) Jgleeson: [C: +1] Ignore iDEAL ipn messages. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [18:54:56] cstone: I +1 cause it sounds like we're happy with the patch as it is. We can clear up the confusion around the second chance thing later [18:55:09] I'll let ejegg +2 [18:55:28] ok yeah maybe the acutal live responses will be different too [19:03:53] have a good weekend all! o/ [19:18:52] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need by: ASAP) rack/setup/install fran1001 - https://phabricator.wikimedia.org/T245554 (Jgreen) a:Jclark-ctr→Jgreen [19:19:40] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: rack/setup/install fran1001 - https://phabricator.wikimedia.org/T245554 (Jgreen) [19:47:56] fr-tech hey does someone have easily on hand a local URL to use on Vagrant for testing ideal? [19:48:07] i can get one for you [19:48:27] cool thx! [19:48:39] https://payments.wiki.local.wmftest.net:4430/w/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&payment_method=rtbt&recurring=&uselang=en&language=en¤cy=EUR&amount=10&country=NL&ffname=adyen&first_name=Jimmy&last_name=Wales&street_address=1+Montgomery+Street&city=San+Francisco&state_province=CA&postal_code=94104&email=jwales%40example.com [19:49:02] main things are payment_method=rtbt, currency=EUR, and country=NL [19:49:10] noice! [19:49:16] thx much :) [21:17:49] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) [21:19:52] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) From email: ` Hey Dallas, yes - SSH + mysql access would be great. ` Scripts and mysql access will be needed so adding that in. [21:26:38] Fundraising-Backlog: Invalid Pares Decline Error - https://phabricator.wikimedia.org/T247023 (EMartin) Please note: I see this error increasing to 4-5% of declines in Sweden. {F31680093} [21:54:38] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) configs have been pushed and mysql access granted: ` [frack::puppet] d4b143f2 Adding cdenes to the fundraising group ` ` [frack::puppet::private] 1fce902 Add cdenes user a... [21:56:11] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) [21:56:38] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) [23:33:40] (CR) Ejegg: [C: +2] Ignore iDEAL ipn messages. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [23:34:04] (Merged) jenkins-bot: Ignore iDEAL ipn messages. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579450 (https://phabricator.wikimedia.org/T241859) (owner: Cstone) [23:42:58] (PS1) DannyS712: Javascript coding conventions: Use $ as a prefix for jquery variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579664 [23:45:09] (PS2) DannyS712: Javascript coding conventions: Use $ as a prefix for jquery variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579664 [23:58:04] (CR) Ejegg: [C: +2] Javascript coding conventions: Use $ as a prefix for jquery variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579664 (owner: DannyS712)