[00:00:05] (Merged) jenkins-bot: Javascript coding conventions: Use $ as a prefix for jquery variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579664 (owner: DannyS712) [00:03:30] (PS2) Ejegg: Rename PaymentCaptureAction to ProcessAuthorizeMessageAction. Rename ProcessCaptureRequestJob to CaptureRequestJob. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579605 (owner: Jgleeson) [00:03:46] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) [00:08:43] (CR) Ejegg: [C: -1] "This is less confusing than the existing, but it might be nice to have the names of the actions we take in response to each message be sim" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/579605 (owner: Jgleeson) [00:14:41] (PS1) DannyS712: Javascript coding conventions: Clean up whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579673 [00:19:33] (PS2) DannyS712: Javascript coding conventions: Clean up whitespace (part 1) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579673 [00:28:14] (PS12) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [00:28:41] (CR) Ejegg: "PS12: Manual rebase around the stomp method rename" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [00:29:55] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [00:36:19] (PS13) Ejegg: WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [00:36:39] (CR) Ejegg: "PS13: formatting fix after manual rebase" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [00:37:50] (CR) jerkins-bot: [V: -1] WIP: Add iDEAL to adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/559178 (https://phabricator.wikimedia.org/T240981) (owner: Jgleeson) [06:50:48] Fundraising-Backlog, MediaWiki-Vagrant: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (Tgr) XDebug 2.7.0 is broken horribly with MediaWiki-Vagrant, see {T247587} (same issue @abi mentions above). 2.7.2 works fine. We need this ASAP. [06:56:11] Fundraising-Backlog, MediaWiki-Vagrant: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (Tgr) [06:58:18] Fundraising-Backlog, MediaWiki-Vagrant, Operations: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (Tgr) [06:58:30] Fundraising-Backlog, MediaWiki-Vagrant, Operations: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (Tgr) Reframed the task since it seems the PECL route was discarded (probably for the better). OTOH we are about to support PHP 7.4 in MediaWiki, and testing that... [13:02:15] (PS1) Umherirrender: Use MediaWikiServices::getMessageCache [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/579708 [14:10:05] (PS1) Zoranzoki21: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579731 [14:39:28] (PS1) Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579733 (https://phabricator.wikimedia.org/T195542) [15:03:40] (PS1) QEDK: Bump MV version, remove deprecated IP class, update .gitignore [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579738 (https://phabricator.wikimedia.org/T247155) [15:04:11] (PS2) QEDK: Bump MW version, remove deprecated IP class, update .gitignore [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579738 (https://phabricator.wikimedia.org/T247155) [15:51:33] (CR) Jforrester: [C: -1] "DonationInterface runs in production on MW 1.31 (LTS), and so has to maintain compatibility with that version of MediaWiki unfortunately. " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579738 (https://phabricator.wikimedia.org/T247155) (owner: QEDK) [15:56:51] (CR) QEDK: "> Patch Set 2: Code-Review-1" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579738 (https://phabricator.wikimedia.org/T247155) (owner: QEDK) [16:10:00] (CR) Jforrester: [C: +2] build: Replace jshint/jsonlint with eslint [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579733 (https://phabricator.wikimedia.org/T195542) (owner: Zoranzoki21) [16:10:06] (CR) Jforrester: [C: +2] Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579731 (owner: Zoranzoki21) [16:23:53] (CR) jerkins-bot: [V: -1] Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579731 (owner: Zoranzoki21) [16:23:54] (CR) jerkins-bot: [V: -1] build: Replace jshint/jsonlint with eslint [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579733 (https://phabricator.wikimedia.org/T195542) (owner: Zoranzoki21) [16:43:44] (CR) Jforrester: [C: +2] Use MediaWikiServices::getMessageCache [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/579708 (owner: Umherirrender) [16:54:43] (PS1) Jforrester: PHP 7.4 compatibility: Don't read array offsets of a variable that could be false [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579754 [16:56:49] (CR) Jforrester: "check php" [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579754 (owner: Jforrester) [17:00:05] (PS2) Jforrester: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579731 (owner: Zoranzoki21) [17:00:11] (PS2) Jforrester: build: Replace jshint/jsonlint with eslint [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579733 (https://phabricator.wikimedia.org/T195542) (owner: Zoranzoki21) [18:05:15] (CR) Umherirrender: [C: +2] PHP 7.4 compatibility: Don't read array offsets of a variable that could be false [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579754 (owner: Jforrester) [18:11:51] (Merged) jenkins-bot: Use MediaWikiServices::getMessageCache [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/579708 (owner: Umherirrender) [18:27:24] (Merged) jenkins-bot: PHP 7.4 compatibility: Don't read array offsets of a variable that could be false [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579754 (owner: Jforrester) [18:27:26] (Merged) jenkins-bot: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579731 (owner: Zoranzoki21) [18:27:28] (Merged) jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579733 (https://phabricator.wikimedia.org/T195542) (owner: Zoranzoki21) [20:12:13] (CR) Thiemo Kreuz (WMDE): Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic (1 comment) [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/579731 (owner: Zoranzoki21)