[00:12:25] (PS2) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [00:13:47] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/581155 [00:14:01] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/581155 (owner: Eileen) [00:18:28] !log civicrm revision changed from a1b2cbeac1 to 1c477ff07f, config revision is 37232d8460 [00:18:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:19:36] (CR) jerkins-bot: [V: -1] Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [00:22:01] fundraising-tech-ops, Operations: rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Dwisehaupt) Nessus package removed from bismuth and /opt/nessus removed. the tar.gz backup that was used during the transfer is still present on the host, just in case. [00:23:50] fundraising-tech-ops, Operations, Wikimedia-FR-Tech-Systems, ops-codfw: Fix incongruences between Netbox and DNS repository - https://phabricator.wikimedia.org/T248035 (Dwisehaupt) [00:24:47] Fundraising-Backlog, fundraising-tech-ops: R packages for frdb1003 - https://phabricator.wikimedia.org/T247980 (jkumalah) Here are a few more packages that would be useful data.table janitor jsonlite car [00:39:27] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (Eileenmcnaughton) Just an update that the 3 contacts causing problems are the... [00:39:54] eileen: so by 'drupal is not in sync' you mean the contribution_tracking table is just missing? [00:40:25] no - I mean it has rows in it for contributions that are non-existent on staging civi db [00:41:02] so when a contribution is created in the civi db it can't create a contribution tracking [00:41:13] due to there being a row already with that contribution id [00:41:49] ahhh, ok, I missed that - thought the only unique key there was the id [00:41:52] thanks [00:42:08] yeah - it's just a distraction - but it caused confusion [00:44:14] (PS3) Ejegg: Catch & handle exceptions on contibution tracking insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581069 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [00:44:32] eileen whatever editor you're using for commit messages - can you set it to wrap at 70 chars? [00:45:01] hmm - I'm not using one - I can look into using one [00:46:30] i just use the git commit boilerplate (the commented bits that start with # Please enter the commit message for your changes.) as a guideline for where to hit enter. [00:48:42] :-) [00:49:00] I spend most of my time fixing butterfly keyboard errors :-( [00:49:13] still haven't addressed that.... [00:49:56] (PS3) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [00:51:04] ohh tests passed this time :-) [00:51:18] oh different commit [00:56:27] (CR) jerkins-bot: [V: -1] Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [00:57:52] sigh - I've changed the test data & now have to adapt the tests [01:00:50] (PS4) Eileen: Catch & handle exceptions on contibution tracking insertt [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581069 (https://phabricator.wikimedia.org/T246889) [01:00:52] (PS2) Eileen: Minor code consolidation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581096 (https://phabricator.wikimedia.org/T246889) [01:00:54] (PS4) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [01:02:02] (PS5) Eileen: Catch & handle exceptions on contibution tracking insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581069 (https://phabricator.wikimedia.org/T246889) [01:02:59] (PS3) Eileen: Minor code consolidation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581096 (https://phabricator.wikimedia.org/T246889) [01:03:01] (PS5) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [01:09:49] (CR) jerkins-bot: [V: -1] Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [01:12:41] (PS6) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [01:18:45] (CR) jerkins-bot: [V: -1] Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [01:31:33] (PS7) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [01:33:28] (PS8) Eileen: Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) [01:41:10] PROBLEM - check_disk on frpm1001 is CRITICAL: DISK CRITICAL - free space: /dev 7957 MB (100% inode=99%): /run 1433 MB (89% inode=99%): / 5845 MB (10% inode=94%): /dev/shm 7974 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 7974 MB (100% inode=99%): /boot 161 MB (64% inode=99%): /srv 556626 MB (67% inode=55%): /run/user/3609 1594 MB (100% inode=99%): /run/user/573 1594 MB (100% inode=99%): /run/user/571 1594 [01:41:10] ) [01:46:10] PROBLEM - check_disk on frpm1001 is CRITICAL: DISK CRITICAL - free space: /dev 7957 MB (100% inode=99%): /run 1433 MB (89% inode=99%): / 5782 MB (10% inode=94%): /dev/shm 7974 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 7974 MB (100% inode=99%): /boot 161 MB (64% inode=99%): /srv 556626 MB (67% inode=55%): /run/user/3609 1594 MB (100% inode=99%): /run/user/573 1594 MB (100% inode=99%): /run/user/571 1594 [01:46:10] ) [01:51:10] PROBLEM - check_disk on frpm1001 is CRITICAL: DISK CRITICAL - free space: /dev 7957 MB (100% inode=99%): /run 1441 MB (90% inode=99%): / 5715 MB (10% inode=94%): /dev/shm 7974 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 7974 MB (100% inode=99%): /boot 161 MB (64% inode=99%): /srv 556626 MB (67% inode=55%): /run/user/3609 1594 MB (100% inode=99%): /run/user/573 1594 MB (100% inode=99%): /run/user/571 1594 [01:51:10] ) [01:56:10] RECOVERY - check_disk on frpm1001 is OK: DISK OK - free space: /dev 7957 MB (100% inode=99%): /run 1441 MB (90% inode=99%): / 14521 MB (27% inode=94%): /dev/shm 7974 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 7974 MB (100% inode=99%): /boot 161 MB (64% inode=99%): /srv 556626 MB (67% inode=55%): /run/user/3609 1594 MB (100% inode=99%): /run/user/573 1594 MB (100% inode=99%): /run/user/571 1594 MB (100% i [02:38:13] Fundraising-Backlog, FR-Civi-Dedupe: Find and Merge Duplicate Contacts: rgid=9 not loading smart group? - https://phabricator.wikimedia.org/T248046 (MBeat33) [03:06:09] Fundraising-Backlog, FR-Civi-Dedupe: Find and Merge Duplicate Contacts: rgid=9 not loading smart group? - https://phabricator.wikimedia.org/T248046 (Eileenmcnaughton) @MBeat33 did you try increasing the number of contacts to search? [03:20:09] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (Eileenmcnaughton) [04:46:33] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Nuria) I would encourage @Jgreen to focus in tools we use broadly to reduce maintenance costs of updates. For exploration/daily work for analysts jupyter notebooks is th... [13:19:16] Fundraising-Backlog, FR-Adyen, Fr-planning-ahead: Apple Pay Specs - Adyen - https://phabricator.wikimedia.org/T229039 (DStrine) Open→Resolved [14:16:37] fr-tech did the 50% hours update get announced on slack? [14:17:02] I'm not sure about slack, but there was the email from Katherine. [14:17:56] oh I must have missed it, I figured it may have come via slack [14:19:42] fr-tech did the meeting already end? [14:19:45] Looks like it came through last Saturday on the foundation-optional list [14:20:05] mepps: It's going, but we hit the cap for hangouts [14:20:25] It's being recorded, and I think they were trying to get a youtube streem going, but I haven't seen if that got set up yet. [14:20:26] i'm trying to watch the stream [14:20:34] mepps: it's full on google meet. [14:20:49] https://meet.google.com/linkredirect?authuser=1&dest=https%3A%2F%2Fwikimedia.zoom.us%2Fj%2F567321387%3Fpwd%3DMVNBVXVGanJNMHpMbFlTZGxsYyttUT09 [14:20:51] you can try this zoom link from grant: https://wikimedia.zoom.us/j/567321387?pwd=MVNBVXVGanJNMHpMbFlTZGxsYyttUT09 [14:20:56] mepps: That might work [14:21:13] my link got mangled, use dwisehaupt's [14:21:20] dwisehaupt what's the apssword? [14:21:33] oh.... let me see [14:22:07] may need to be logged in to zoom with your wiki creds. [14:23:02] still asks for a meeting password :( [14:23:43] someone update me on what happens fr-tech! [14:23:54] Heh, someone just left the hangouts meeting if you want to try to sneak in [14:24:23] mepps: try MVNBVXVGanJNMHpMbFlTZGxsYyttUT09 [14:24:36] thanks! also this should be in private chat...oops [14:25:07] not sure if that's the pwd but it's in the url. trying to coordinate with what i'm seeing in -office [14:25:30] i got it [14:25:38] thanks! [14:25:46] sweet. dunno why it didn't just work. *shrug* :) [14:26:11] it might have been user error, thanks for the link! [14:58:37] Wikimedia-Fundraising-Banners: Prepare banners for Netherlands iDeal recurring/Adyen pre-test March 24 - https://phabricator.wikimedia.org/T247102 (TSkaff) @DStrine This might be over-communication, but this is our Task for the prep work on NL banners--you'll let us know when we're able to test internally?... [15:11:42] Fundraising-Backlog, fundraising-tech-ops: R packages for frdb1003 - https://phabricator.wikimedia.org/T247980 (Jgreen) Resolved→Open [15:11:44] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) [15:27:47] (PS1) DannyS712: Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581619 (https://phabricator.wikimedia.org/T248000) [15:28:18] (PS2) DannyS712: Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581619 (https://phabricator.wikimedia.org/T248000) [15:36:02] Fundraising-Backlog, fundraising-tech-ops: R packages for frdb1003 - https://phabricator.wikimedia.org/T247980 (Jgreen) [15:46:09] Fundraising-Backlog, FR-Civi-Dedupe: Find and Merge Duplicate Contacts: rgid=9 not loading smart group? - https://phabricator.wikimedia.org/T248046 (MBeat33) I tried boosting contacts from 5k to 50k and then 500k, but none of them yielded results, @Eileenmcnaughton [15:49:07] Fundraising-Backlog, fundraising-tech-ops: R packages for frdb1003 - https://phabricator.wikimedia.org/T247980 (Jgreen) >>! In T247980#5982490, @jkumalah wrote: > Here are a few more packages that would be useful > data.table > janitor > jsonlite > car @jkumalah I installed all but janitor, that's not a... [15:50:28] Fundraising-Backlog, FR-Civi-Dedupe: Find and Merge Duplicate Contacts: rgid=9 not loading smart group? - https://phabricator.wikimedia.org/T248046 (MBeat33) Open→Resolved a:MBeat33 [16:27:20] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Jgreen) [16:36:27] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Review Banner Templating - https://phabricator.wikimedia.org/T246347 (DStrine) [16:47:58] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Review Banner Templating - https://phabricator.wikimedia.org/T246347 (DStrine) [16:58:06] (PS1) Jforrester: tests: Make SubscribeTest PHPUnit 8 compatible [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/581653 [16:58:14] picking up Oscar back soon! [16:59:01] (CR) Jforrester: "This will break the code on PHP 7.0, however; do we still run it on that?" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/581653 (owner: Jforrester) [16:59:26] (CR) jerkins-bot: [V: -1] tests: Make SubscribeTest PHPUnit 8 compatible [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/581653 (owner: Jforrester) [17:12:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [17:14:12] fundraising-tech-ops, Operations, Wikimedia-FR-Tech-Systems, ops-codfw, Patch-For-Review: Fix incongruences between Netbox and DNS repository - https://phabricator.wikimedia.org/T248035 (Jgreen) Open→Resolved a:Jgreen fixed! [17:16:53] (CR) Ppchelko: [C: +2] Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581619 (https://phabricator.wikimedia.org/T248000) (owner: DannyS712) [17:17:11] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (DStrine) [17:17:22] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [17:22:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1638 [17:25:52] Fundraising-Backlog, fundraising-tech-ops: R packages for frdb1003 - https://phabricator.wikimedia.org/T247980 (jkumalah) You can skip janitor @Jgreen. It isn't that important [17:27:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1938 [17:28:12] (PS1) Ejegg: WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [17:28:39] cstone: I've got another meeting in a sec, but there's a WIP for the directDebit bit ^^^ [17:29:27] thanks ejegg ! [17:29:28] (Merged) jenkins-bot: Replace WikiPage::doDeleteArticle with ::doDeleteArticleReal [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581619 (https://phabricator.wikimedia.org/T248000) (owner: DannyS712) [17:30:22] cstone: oh the meeting got changed [17:32:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [17:32:20] so let's start looking at how to update the createPayment method in the PaymentProvider class [17:37:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2538 [17:42:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2838 [17:47:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3138 [17:47:44] (PS1) DannyS712: Use lowercase for primitive type 'bool' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 [17:47:58] (PS2) DannyS712: Use lowercase for primitive type 'bool' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 [17:52:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3438 [17:55:04] fundraising-tech-ops: tune away replication timeout on fundraising analytics database - https://phabricator.wikimedia.org/T248115 (Jgreen) [17:57:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [17:57:57] ACKNOWLEDGEMENT - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) Dwisehaupt known [18:12:54] Fundraising-Backlog, fundraising-tech-ops: R packages for frdb1003 - https://phabricator.wikimedia.org/T247980 (Jgreen) Open→Resolved >>! In T247980#5984675, @jkumalah wrote: > You can skip janitor @Jgreen. It isn't that important Ok thanks! Closing the task again. [18:12:58] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) [18:30:45] cstone so we have three properties in common between all the responses, they're just found in different places [18:30:56] pspReference, refusalReason, resultCode [18:31:46] I guess we should refactor the Adyen PaymentProvider pretty much the same way that AndyRussG refactored the Ingenico PaymentProvider [18:38:31] ok cool looking at things now [18:42:12] RECOVERY - check_mysql on frdb1003 is OK: Uptime: 704461 Threads: 2 Questions: 44208631 Slow queries: 30 Opens: 16595 Flush tables: 1 Open tables: 665 Queries per second avg: 62.755 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [18:46:07] (PS2) Ejegg: WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [18:46:09] (PS1) Ejegg: WIP Refactor Adyen PaymentProvider with prepareResponse [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581700 (https://phabricator.wikimedia.org/T230837) [18:46:36] (CR) jerkins-bot: [V: -1] WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [18:46:38] (CR) jerkins-bot: [V: -1] WIP Refactor Adyen PaymentProvider with prepareResponse [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581700 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [18:46:41] ^^^ is gonna fail the test, but something like that [18:55:51] (PS3) DannyS712: Remove Special:CNReporter [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/549202 (https://phabricator.wikimedia.org/T232912) [20:07:20] fundraising-tech-ops: clean up fundraising nsca collection aka overhaul nsca_frack.cfg.erb - https://phabricator.wikimedia.org/T247855 (Jgreen) first phase deployed [20:08:20] Fundraising-Backlog, fundraising-tech-ops: figure out Buster package for python3-mysql.connector for use with fruec - https://phabricator.wikimedia.org/T246823 (Jgreen) [20:10:08] Fundraising-Backlog, fundraising-tech-ops: figure out Buster package for python3-mysql.connector for use with fruec - https://phabricator.wikimedia.org/T246823 (Jgreen) >>! In T246823#5946630, @Dwisehaupt wrote: > We currently have the following mysql modules for python3 in the repos: > ` > python3_mysql... [20:22:01] fr-tech I'm having a hard time getting my devwiki up and running. I've so far pulled on mediawiki, central notice and the vector skin due to some UI issues and now I'm seeing some php and js errors that I'm gonna dive into. Has anyone come across any of these before? https://phabricator.wikimedia.org/F31692836 [20:22:56] good typo [20:23:53] * jgleeson|dinner is off to self-flagellate [20:25:41] hate the din, love the dinner [20:33:29] (PS2) Ejegg: Refactor Adyen PaymentProvider with prepareResponse [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581700 (https://phabricator.wikimedia.org/T230837) [20:33:31] (PS3) Ejegg: WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [20:42:13] (PS3) Thiemo Kreuz (WMDE): Use lowercase for primitive type 'bool' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 (owner: DannyS712) [20:42:16] (CR) Thiemo Kreuz (WMDE): [C: +1] Use lowercase for primitive type 'bool' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 (owner: DannyS712) [20:42:44] (PS4) Ejegg: WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [20:42:57] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (mpopov) >>! In T238395#5982770, @Nuria wrote: > I would discourage setting up another dashboarding tool such us Rstudio. For the record RStudio is an IDE for working w... [20:43:36] (CR) jerkins-bot: [V: -1] WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [20:45:01] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Nuria) Sorry, R-bashed dashboarding. [21:07:39] MBeat_: :) [21:08:21] always up for a good theological pun or two [21:12:19] A+ typo jgleeson [21:32:31] :> [21:40:57] cstone: I've gotten a bit deeper into a refactor of the adyen tests than i initially intended [21:41:07] but I think it'll be better in the end [21:41:17] not to have the mock class defined [21:41:29] and to use the ->expects() syntax everywhere [21:50:51] (PS4) Umherirrender: Use lowercase for primitive type 'bool' and 'string' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 (owner: DannyS712) [21:50:54] (CR) Umherirrender: [C: +1] Use lowercase for primitive type 'bool' and 'string' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 (owner: DannyS712) [21:56:49] nice ejegg I don't think thats too bad if itll be better in the end [22:01:54] (PS5) Ejegg: WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [22:01:56] (PS1) Ejegg: WIP refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 [22:02:11] hmm hmm, I think I want to rebase that to go before the direct debit bits [22:02:17] if it's still possible [22:02:27] (CR) jerkins-bot: [V: -1] WIP refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 (owner: Ejegg) [22:09:03] (PS2) Ejegg: Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 [22:09:36] (CR) jerkins-bot: [V: -1] Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 (owner: Ejegg) [22:09:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) Ran the alter on civicrm_contact. Not as much reclamation there. This one took much long... [22:11:41] (PS3) Ejegg: Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 [22:12:20] ok cstone ^^^ should be ready for review [22:15:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Eileenmcnaughton) OK - well the 40 mins is good to know 13 GB is not nothing but it's also I suppose... [22:15:11] so the slightly disorienting bit of that change is that with expects() syntax we need to make the assertions about what parameters we want BEFORE running the code under test and not after [22:25:29] oh hmm, looks like there's an extra 'response' layer in that direct debit response? [22:25:35] lemme try that again [22:32:38] oh derp [22:32:52] I'm doing the switch on method wrong [22:33:01] Those should be subclasses [22:38:37] hmm, I don't like having approvePayment on the IPaymentProvider [22:40:50] is received the final good status for the direct debits? [22:42:24] dwisehaupt: just thinking - the civicrm_entity_tag table & maybe activity & activity_contact could have shrunk [22:44:23] (PS4) Ejegg: Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 [22:44:33] cstone it's just like in the front end [22:44:54] 'Received' is basically pending - the bank has received the request, but they haven't necessarily transferred the money [22:45:04] but it's the last step as far as we are concerned [22:46:05] ok [22:46:35] (PS5) Ejegg: Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 [22:51:44] (PS6) Ejegg: WIP add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [22:52:43] OK, ^^^ is a version with PaymentProvider subclasses for each method, just like Ingenico [22:55:24] (PS7) Ejegg: Add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [22:57:49] fr-tech was someone already planning to take on that NL thank you letter update? [22:57:58] If not I'll just put that on staging real quick [23:08:03] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (Ejegg) @CDenes_WMF this is up on staging, and I sent a copy to you. [23:09:45] (PS3) Ejegg: Refactor Adyen PaymentProvider with prepareResponse [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581700 (https://phabricator.wikimedia.org/T230837) [23:12:34] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Adyen iDeal handled through smashpig. - https://phabricator.wikimedia.org/T230837 (Ejegg) p:Triage→High a:Ejegg [23:16:47] turns out if you turn off the pending queue consumer nothing gets to the pending database.... haha [23:16:51] self sabotage [23:18:16] eileen: thanks. i'll do those next. just finished up the script testing to make it easier and repeatable. [23:18:26] cool [23:18:27] running things by hand-- [23:19:22] yep - that's a drag [23:19:54] but that will have to wait until tomorrow. been online since 5am and i need to get away from the screen. [23:20:04] i'll do those tomorrow and update the ticket.