[00:03:57] cstone did you want a quick live overview of any of those patches? [00:04:29] I know that tests one is a bit big [00:07:34] hey maybe tomorrow for the tests one, I have a good idea on the paymentprovider one [00:08:59] or where to start [00:09:06] ok, cool! [00:09:25] in that case I'll sign off [00:09:34] stay safe, everyone! [00:31:43] Wikimedia-Fundraising-Banners, Vector, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (MBinder_WMF) [00:35:10] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Jdlrobson) @MBinder_WMF is this a gadget or a browser extension? [00:47:07] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Reedy) >>! In T248139#5985848, @Jdlrobson wrote: > @MBinder_WMF is this a gadget or a bro... [00:48:10] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Reedy) https://en.wikipedia.org/wiki/NASA?banner=programmatic_mlWW_rsp_covid19&force=1&co... [01:22:35] (PS1) VolkerE: Remove unnecessary, overqualified element parts of id selectors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/581815 (https://phabricator.wikimedia.org/T248137) [02:30:32] (CR) Cstone: [C: +2] "It does cut down on the repetition. Looks good, tests behaving." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581700 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [02:30:46] (Merged) jenkins-bot: Refactor Adyen PaymentProvider with prepareResponse [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581700 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [02:45:12] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Jdlrobson) I meant the dark mode... I am not aware of code for dark mode in Vector so cur... [07:06:24] (CR) Thiemo Kreuz (WMDE): [C: +2] Use lowercase for primitive type 'bool' and 'string' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 (owner: DannyS712) [07:18:42] (Merged) jenkins-bot: Use lowercase for primitive type 'bool' and 'string' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/581670 (owner: DannyS712) [11:50:51] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (RLewis) @Eileenmcnaughton thanks for sharing this information. Can you share... [13:25:34] fundraising-tech-ops, Operations, observability, Patch-For-Review, User-fgiunchedi: Icinga latency is skyrocketing and commands ignored - https://phabricator.wikimedia.org/T247538 (fgiunchedi) [14:21:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Changing translation source in banner should mark translations as outdated in translation extension - https://phabricator.wikimedia.org/T248176 (Jseddon) [15:24:38] hi fr-tech! [15:24:58] thanks for the code review cstone [15:25:28] anyone want to do some live code review for any of the outstanding patches? [15:34:15] ejegg: morning [15:34:17] sure [15:34:25] hi AndyRussG ! [15:34:48] let's see, want to use the daily standup call? [15:34:59] okok [15:35:43] hehe, i love seeing "miss jessi's harry potter reading hour" on the work schedule [15:36:27] (PS6) Ejegg: Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 [15:36:30] ejegg: actually maybe give me 10 minutes or so? [15:36:47] sure thing [15:36:57] (PS1) DannyS712: Use lowercase for primitive type 'string' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/582081 [15:37:09] (PS2) DannyS712: Use lowercase for primitive type 'string' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/582081 [15:37:30] I'll just leave the thing open in the background (w/ my video off to save bandwidth) and you can shout when you're in. [15:48:09] ejegg: hey, I'm in the call now! [16:00:35] (CR) D3r1ck01: [C: +2] Use lowercase for primitive type 'string' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/582081 (owner: DannyS712) [16:08:30] fundraising-tech-ops, DC-Ops, Operations, decommission, ops-eqiad: decommission frav1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T222109 (Papaul) [16:20:33] (Merged) jenkins-bot: Use lowercase for primitive type 'string' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/582081 (owner: DannyS712) [16:31:13] (PS8) Ejegg: Add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [16:45:39] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Dwisehaupt) Added civi2001 into the mix for rsync_blaster/FrDeploy. Ran initial sync. `[frack::puppet] ded00800 Adding civi2001 to the mix for FrDeploy` [17:12:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1],Amazon_endpoint_critical 1 [=1],Paypal_endpoint_critical 1 [=1] [17:17:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1],Amazon_endpoint_critical 1 [=1],Paypal_endpoint_critical 1 [=1] [17:22:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1],Amazon_endpoint_critical 1 [=1],Paypal_endpoint_critical 1 [=1] [17:27:11] RECOVERY - check_log_messages on frav1002 is OK: OK [17:38:22] (CR) Aron Manning: Remove unnecessary, overqualified element parts of id selectors (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/581815 (https://phabricator.wikimedia.org/T248137) (owner: VolkerE) [17:39:59] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) [17:40:24] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) [17:41:27] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) [17:41:53] fundraising-tech-ops: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) [17:41:56] fundraising-tech-ops: refactor drush install - https://phabricator.wikimedia.org/T240499 (Jgreen) [17:59:21] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (MBinder_WMF) @Jdlrobson I was sent this by @spatton : https://www.mediawiki.org/wiki/Skin... [18:16:36] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Demian) >>! In T248139#5985848, @Jdlrobson wrote: > @MBinder_WMF is this a gadget or a br... [18:20:27] fr-tech is everyone on slack. I haven't joined yet but figure we all need to [18:20:53] and once we're all on slack, are we gonna still use IRC for comms? [18:21:02] (text comms) [18:22:54] jgleeson: i'm on slack. i plan on still using irc at this point and using slack as a backup if needed. [18:23:02] i have it but just mostly ignore it (slack that is) [18:25:33] i'mma keep using IRC [18:26:02] yeah I like IRC and don't normally need beyond what you can do on it [18:26:03] the WMF shouldn't shut itself off from the community [18:26:18] do community members get slack accounts? [18:26:27] no idea [18:26:31] guessing no [18:27:51] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (MBinder_WMF) > "Dark Reader" is this extension: > https://chrome.google.com/webstore/deta... [18:27:59] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Demian) >>! In T248139#5985871, @Reedy wrote: > https://en.wikipedia.org/wiki/NASA?banner... [18:28:28] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (MBinder_WMF) [18:28:54] Wikimedia-Fundraising-Banners, Community-Tech, Dark-Mode, Reading-Web-Local-Wiki-Issues, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (MBinder_WMF) [18:30:48] Yea, I'm on slack, but IRC is stilly what I plan to use for primary comms. [18:32:30] Wikimedia-Fundraising-Banners, Community-Tech, Reading-Web-Local-Wiki-Issues, Dark-Mode, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (Pcoombe) Open→Resolved Looks like @scervantes [fixed this](https://meta.wikimedia... [19:05:25] Wikimedia-Fundraising-Banners, Community-Tech, Reading-Web-Local-Wiki-Issues, Dark-Mode, covid-19: COVID-19 "uncertainty" banner does not respond to dark mode - https://phabricator.wikimedia.org/T248139 (MBinder_WMF) {meme, src="seal-of-approval", above=SEAL, below="OF APPROVAL"} [19:06:21] XenoRyet: One of my last standing pieces of advice. Fundraising will always need to retain a presence on IRC [19:12:20] heh. having been on irc since ~'93, i don't know if i'll ever not be on it. :) [19:16:44] Seddon: Yep, I agree. [19:29:59] cstone the refusalReason when you get the token wrong is "800 Contract not found" so I guess some of them DO start with numbers [19:34:17] yeah i thought they were all like that then i saw just Insufficient balance on payment in the reason [19:38:27] (PS9) Ejegg: Add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [19:38:42] ok, ^^^ now has a test for the negative case [19:38:59] and added at least one comment. [19:39:10] I think I'll do another patch with more comments and type hints [20:02:44] ooh, found an actual bug in cancellation [20:03:09] (PS1) Ejegg: Fix Adyen payment cancellation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582162 [20:03:11] (PS1) Ejegg: WIP more comments and cleanup for Adyen classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582163 [20:16:19] (PS2) Ejegg: Additional comments and cleanup for Adyen classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582163 [20:28:25] Fundraising-Backlog, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (NNichols) [20:32:31] (PS1) Ejegg: Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 [20:33:05] AndyRussG: ^^^ breaks up that one big function [20:33:15] (CR) jerkins-bot: [V: -1] Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 (owner: Ejegg) [20:33:17] and the one before it adds some comments [20:33:19] oops [20:33:28] let's see what just broke [20:34:09] heh, stray comma [20:34:32] i swear i OFTEN run unit tests before making zuul do it [20:35:38] (PS2) Ejegg: Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 [20:40:30] (PS1) Ejegg: Add type hints and return types to Ingenico classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582170 (https://phabricator.wikimedia.org/T243421) [20:41:16] (CR) jerkins-bot: [V: -1] Add type hints and return types to Ingenico classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582170 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [20:41:24] fr-tech I'm building a bit of a tall stack of patches here - if anyone is available for review I'd be happy to talk through this stuff live [20:42:06] hey i was looking at the test one but got a bit distracted trying to get pizza delivered from a place that just started delivery hah [20:42:32] ejegg: I can chip in if needed. Can you link the patches? [20:43:26] cstone: you looking at this one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/SmashPig/+/581776/? [20:43:34] (PS2) Ejegg: Add type hints and return types to Ingenico classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582170 (https://phabricator.wikimedia.org/T243421) [20:44:01] jgleeson: ah yeah, that one would be perfect! [20:44:21] That is, I'd like to get your feedback in particular [20:44:45] I actually looked over that one earlier and it looked good to me [20:45:04] I'll just try it out locally [20:45:14] although if cstone is reviewing I'll hold off [20:45:19] yeah it runs good for me locally i was just digging into understanding it a bit more [20:45:33] feel free jgleeson im distracted by pizza for a bit [20:46:28] sure [20:47:05] oops, now _I_ have to go on a supply run! [20:47:09] back soon [20:47:24] good luck! [20:47:42] good luck! [21:06:10] fundraising-tech-ops: reenable archive_purge on fundraising backup role - https://phabricator.wikimedia.org/T248201 (Jgreen) [21:06:31] fundraising-tech-ops: reenable archive_purge on fundraising backup role - https://phabricator.wikimedia.org/T248201 (Jgreen) p:Triage→High [21:09:51] pizza acquired [21:11:12] :) [21:16:03] (CR) Jgleeson: [C: +2] "Big improvement and will help tests going forward too! Working fine for me." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 (owner: Ejegg) [21:16:31] (Merged) jenkins-bot: Refactor Adyen tests for modern mocking [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581776 (owner: Ejegg) [21:18:48] cstone: I notice in the directDebit stuff for adyen the recurring block is still added to the api call. https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/SmashPig/+/581665/9/PaymentProviders/Adyen/Api.php do we need this for direct debit? I kinda expected it to be recurring by default [21:19:40] did folks find for docs for that api call/ [21:19:42] ? [21:21:26] im still not 100% on what exactly the recurring needs ejegg might have reverse engineered it. last I knew we couldn't really find docs [21:21:46] I wonder if the WSDL provides any hints [21:21:55] about optional/mandatory fields [21:22:16] lemme check that out [21:22:29] they just enabled the sepdadirectdebit on the test account yesterday and i havent dug too much back into the responses since then [21:23:56] https://www.irccloud.com/pastebin/K4LwlW8F/ [21:24:04] getting this back was as far as i tested [21:25:09] I haven't used this tool for a long time https://www.soapui.org/downloads/thank-you-for-downloading-soapui.html [21:25:31] I think it lets you make test run calls from the UI to the endpoint [21:25:50] handy for playing with methods on the api before writing code [21:26:01] 144mb! [21:31:19] so it looks like the recurring block IS optional [21:31:26] although that might mean we still want it [21:33:43] hmm it looks like every property is optional [21:33:51] at least on that soap method [21:35:10] I wonder if I can extract out the XML sent and drop it into SOAP UI [21:35:31] this is what I'm looking at https://phabricator.wikimedia.org/F31695216 [21:36:12] I wonder if I can tweak out adyen test maintenance script to call direct debit instead and capture it before it hits the server to then take out the recurring info and see what happens [21:37:07] pizza distraction is done, just got to the 144mb step haha [21:37:14] but looks like a fun? tool to mess around with [21:37:38] I used to use it a lot back when I worked more with SOAP apis [21:46:56] yeah it looks like it's required according to the docs https://docs.adyen.com/payment-methods/sepa-direct-debit/api-only?tab=%23codeBlock9bt3G_PHP [21:48:15] ejegg|afk: says that they only support recurring SEPA here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/SmashPig/+/581665/9/PaymentProviders/Adyen/DirectDebitPaymentProvider.php [21:49:08] hmm I kinda wanna put through a test using the test details on the docs first before +2ing and I'm out of time for tonight so I'll pause my review for now on that patch. Feels free to carry it forward if you feel like it cstone, if not I'll check back in monday [21:49:24] have a good weekend all! [21:49:28] thanks jgleeson ! get that trampoline built! [21:49:38] ha! yep that's my first job tomorrow [21:49:42] :> [21:49:45] o/ [22:05:49] jgleeson sorry, I'll mkae clearer that it's our API wrapper that only supports the recurring payments [22:07:52] (PS10) Ejegg: Add direct debit recurring for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/581665 (https://phabricator.wikimedia.org/T230837) [22:07:54] (PS2) Ejegg: Fix Adyen payment cancellation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582162 [22:07:56] (PS3) Ejegg: Additional comments and cleanup for Adyen classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582163 [22:07:57] ok, fixed that comment [22:09:16] cstone so they don't seem to have any classic integration docs for sepa [22:09:35] I just looked at the WSDL and tried to make a similar reqest to the one for recurring card payments [22:10:04] ok i thought something like that [22:10:51] oh so the maintenance script can now be called with --method=rtbt (or --method=dd) to use the direct debit class [22:25:45] cool just got one through kind off well its in adyen hah