[00:18:13] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/577024 (https://phabricator.wikimedia.org/T246962) (owner: Cdenes) [00:28:10] (CR) Cstone: [C: +2] Interface for status normalizer classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582865 (owner: Ejegg) [00:28:35] (Merged) jenkins-bot: Interface for status normalizer classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582865 (owner: Ejegg) [01:03:23] (CR) Cstone: [C: +2] "I like type hints." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582170 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [01:03:46] (Merged) jenkins-bot: Add type hints and return types to Ingenico classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582170 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [02:34:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) This one got us another 7GB reclaimed with: ./compress_table.sh -d civicrm -t civicrm_ac... [02:37:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) @Eileenmcnaughton Any other tables we'd like to try and see if we can reclaim space on?... [02:44:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Eileenmcnaughton) @Dwisehaupt maybe civicrm_email & civicrm_address That civicrm_mailing_provider_... [03:37:28] (PS1) Eileen: Remove some trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582950 [03:37:30] (PS1) Eileen: Put contacts relevant to ts export into a group. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) [03:39:11] (CR) jerkins-bot: [V: -1] Remove some trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582950 (owner: Eileen) [03:39:25] (CR) jerkins-bot: [V: -1] Put contacts relevant to ts export into a group. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [03:45:03] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582950 (owner: Eileen) [03:46:05] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [04:36:17] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [04:45:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [05:21:16] (PS1) Eileen: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) [05:23:20] (CR) jerkins-bot: [V: -1] Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [05:23:29] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [15:24:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Privacy Engineering, Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297 (JFishback_WMF) [15:37:56] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (Ejegg) I sent another test one with that space added, but like I said in an email (commenting on a test email I forw... [15:38:21] shoot, irssi notifier isn't sending stuff to my phone any more [15:39:33] mepps I had a tiny formatting suggestion on https://gerrit.wikimedia.org/r/576153 (that's why I gave it a +1 and not +2) [15:39:58] then I think someone else needs to +2 the two patches above that in the chain, as I did a lot of rework on those [15:40:58] Okay ejegg I’ll look after childcare duty [15:44:51] (PS6) Ejegg: Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 [15:45:16] AndyRussG: ^^^ is no longer merge-conflict-y in case you think it's worth doing [15:45:47] I'mma tag another composer version today once we decide to merge that or not [15:46:59] (Abandoned) Ejegg: Adyen test script: request specific response codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/576891 (owner: Ejegg) [15:59:24] ejegg: ok thanks! [16:27:10] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (CDenes_WMF) Sorry Elliott, that was a typo on my end! Should say "u" instead of "je" (u is formal; je is informal)... [16:30:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) Save just under 2G with: ./compress_table.sh -d civicrm -t civicrm_email ` Alter comple... [16:37:00] Fundraising-Backlog, FR-AutoTY-Email, Epic: EPIC: Auto TY emails from Civi - https://phabricator.wikimedia.org/T248358 (DStrine) [17:02:36] (PS9) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) [17:03:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) Saved another 4G+ with this: ./compress_table.sh -d civicrm -t civicrm_address ` Alter... [17:04:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New certificate for Breianne B - https://phabricator.wikimedia.org/T248398 (LeanneS) [17:21:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New certificate for Breianne B - https://phabricator.wikimedia.org/T248398 (Dwisehaupt) a:Dwisehaupt Hi @LeanneS, will she still need to use the other computer in the future? If I create her a new certificate, it will inval... [17:24:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New certificate for Breianne B - https://phabricator.wikimedia.org/T248398 (LeanneS) @Dwisehaupt She likely will use the other computer once she is able to return to her office. That's good to know! I'll ask her to install the... [17:25:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New certificate for Breianne B - https://phabricator.wikimedia.org/T248398 (Dwisehaupt) @LeanneS Sounds good. Just let me know. [17:31:45] (PS3) Ejegg: Edits to the Dutch TY email for the NLNL campaign coming up [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/577024 (https://phabricator.wikimedia.org/T246962) (owner: Cdenes) [19:28:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) Definitely took a while, but it reclaimed a good chunk of 39G with: ./compress_table.sh... [19:30:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) Passing this back to you @Eileenmcnaughton for now. I can run this compaction on additio... [19:31:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Fr-planning-ahead: Determine how much space is regained from contact deletion - https://phabricator.wikimedia.org/T246828 (Dwisehaupt) a:Dwisehaupt→Eileenmcnaughton [19:33:12] Fundraising-Backlog: Damaged message view not working in vagrant - https://phabricator.wikimedia.org/T248410 (mepps) [19:37:24] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [19:38:39] (PS1) VolkerE: Remove unnecessary, overqualified element parts of class selectors [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/583132 (https://phabricator.wikimedia.org/T248137) [19:40:18] Fundraising-Backlog, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (Eileenmcnaughton) related to https://phabricator.wikimedia.org/T245641 [19:41:07] (CR) jerkins-bot: [V: -1] Remove unnecessary, overqualified element parts of class selectors [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/583132 (https://phabricator.wikimedia.org/T248137) (owner: VolkerE) [19:56:22] this could do with review XenoRyet https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/581145/ (couple in the chain before it) [19:56:34] Also quick +2 on this for someone https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/582950/ [19:56:37] 10-4 [20:02:54] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (Ejegg) OK, just sent another test with 'u' in place of 'je'. [20:25:24] I don't believe gerrit is running properly on https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/582951/ - I think if the (whitespace only) one before it is merged a rebase might help [20:36:02] (CR) Jgleeson: [C: +2] Remove some trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582950 (owner: Eileen) [20:36:15] thanks jgleeson [20:36:19] np [20:36:38] (PS2) Eileen: Put contacts relevant to ts export into a group. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) [20:43:31] (Merged) jenkins-bot: Remove some trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582950 (owner: Eileen) [20:44:02] Fundraising-Backlog, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration, and 3 others: 2017 USA banners may freeze your browser for 1-2 seconds - https://phabricator.wikimedia.org/T174267 (Krinkle) Open→Declined @Fundraising-Tech: I'm... [20:48:42] yay gerrit ran through now! [20:49:52] jgleeson: maybe this is one you could review https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/582951/ - it's the prep for export - I found that I could export from the UI so decided to put the contacts into a group & MG can export it (gives them a chance to dedupe & less file mucking around) - I ran it on staging & it worked [20:51:59] (PS2) Eileen: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) [20:54:28] (CR) jerkins-bot: [V: -1] Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [20:55:15] (PS3) Eileen: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) [20:56:49] (CR) jerkins-bot: [V: -1] Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [20:56:56] Fundraising-Backlog, Patch-For-Review: Damaged message view not working in vagrant - https://phabricator.wikimedia.org/T248410 (mepps) Open→Resolved a:mepps [20:56:59] (PS4) Eileen: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) [20:58:39] (CR) jerkins-bot: [V: -1] Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [20:58:42] eileen: I need to jump off now but I'll check that our first thing tomorrow if that works? [20:58:51] sure - thanks [20:59:07] looks good but I'll see if I can test it locally also [20:59:10] thanks! [20:59:14] great [20:59:38] have a good evening/morning(eileen) all :) [20:59:44] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, and 2 others: BannerExistenceException due to non-existing CentralNotice banner (throws on job queue after Special:LanguageStats view... - https://phabricator.wikimedia.org/T157997 [20:59:46] :-0 [21:00:14] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, and 2 others: BannerExistenceException due to non-existing CentralNotice banner (throws on job queue after Special:LanguageStats view... - https://phabricator.wikimedia.org/T157997 [21:04:38] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, and 2 others: BannerExistenceException due to non-existing CentralNotice banner (after Special:LanguageStats view) - https://phabricator.wikimedia.org/T157997 (Krinkle) [21:05:05] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, and 2 others: BannerExistenceException due to non-existing CentralNotice banner (after Special:LanguageStats view) - https://phabricator.wikimedia.org/T157997 (Krinkle) [21:06:41] Fundraising-Backlog: 3 Paypal recurring payments missing predecessor - https://phabricator.wikimedia.org/T248420 (mepps) [21:07:48] Fundraising-Backlog: 3 Paypal recurring payments missing predecessor - https://phabricator.wikimedia.org/T248420 (mepps) Hmm one belongs to CID 10936530 that has a recurring payment which hasn't been run since June 6th 2019. [21:10:16] Fundraising-Backlog: 3 Paypal recurring payments missing predecessor - https://phabricator.wikimedia.org/T248420 (mepps) This actually looks like a new contribution based on the amount--it looks like it could be from upsell. [21:12:10] Fundraising-Backlog: 3 Paypal recurring payments missing predecessor - https://phabricator.wikimedia.org/T248420 (mepps) cid 41437821 appears to have their contribution recorded even though the message is still listed in the /damaged view. [21:13:27] (PS5) Eileen: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) [21:15:27] (CR) jerkins-bot: [V: -1] Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [21:30:56] Wikimedia-Fundraising, MediaWiki-extensions-FundraiserLandingPage, Wikimedia-production-error: "PHP Warning: preg_match() expects parameter 2 to be string" from Special:FundraiserLandingPage - https://phabricator.wikimedia.org/T226456 (Krinkle) Still reproducible. [21:31:17] Wikimedia-Fundraising, MediaWiki-extensions-FundraiserLandingPage, donate.wikimedia.org, Wikimedia-production-error: "PHP Warning: preg_match() expects parameter 2 to be string" from Special:FundraiserLandingPage - https://phabricator.wikimedia.org/T226456 (Krinkle) [21:37:48] (CR) Eileen: "I just tested this successfully on staging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [21:38:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/ - https://phabricator.wikimedia.org/T244020 (Krinkle) Still reproducible. @DStrine What is this blocked on / or / who is the not-fr-tech this sho... [21:39:10] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, and 5 others: Cull low value data from activity table - https://phabricator.wikimedia.org/T245088 (Eileenmcnaughton) I'v... [22:02:42] (CR) XenoRyet: [C: +2] Catch & handle exceptions on contibution tracking insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581069 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [22:03:50] anyone else on for tech talk now? [22:05:00] It sounds like Dylan may be waking up from her nap now, I'll have to handle that, but maybe I can jump on if she settles down to something that'll hold her attention for a bit. [22:08:48] (Merged) jenkins-bot: Catch & handle exceptions on contibution tracking insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581069 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [22:16:46] Fundraising-Backlog, fundraising-tech-ops: payments2001 showing mysql errors about reading log events - https://phabricator.wikimedia.org/T248429 (Dwisehaupt) [22:24:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/ - https://phabricator.wikimedia.org/T244020 (DStrine) hmm I am not sure. I will have to ask the team tomorrow and get back to you. [22:31:36] Fundraising-Backlog, fundraising-tech-ops: payments2001 showing mysql errors about reading log events - https://phabricator.wikimedia.org/T248429 (Dwisehaupt) I took a look into this. It looks like the error started showing up in logs around 2000 UTC on March 10th. ` payments.error-20200311.gz:Mar 10 20:... [22:47:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Custom Field - Opt Out Endowment Emails - https://phabricator.wikimedia.org/T248019 (Eileenmcnaughton) @NNichols there is no hard rule here - but groups or tags are also options, especially if these are not going to be last 2 [23:02:53] (CR) XenoRyet: [C: +2] Minor code consolidation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581096 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [23:04:13] (CR) jerkins-bot: [V: -1] Minor code consolidation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581096 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [23:40:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Point version upgrade on civi -do early April in prep for security release mid April - - https://phabricator.wikimedia.org/T248432 (Eileenmcnaughton) [23:50:56] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Fundraising tech engineers should have clear list of regular "chores" - https://phabricator.wikimedia.org/T246678 (Eileenmcnaughton) @mepps OK updated - I also added http... [23:58:30] eileen: that dedupe job seems to be failing really often [23:58:40] it'd be nice not to get so much email... [23:58:57] ejegg: earlier today there was a problem - ie someone messed with the rules [23:59:17] but since that was fixed we've had a few time overruns