[00:12:28] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Fundraising tech engineers should have clear list of regular "chores" - https://phabricator.wikimedia.org/T246678 (mepps) @XenoRyet @Cstone @AndyRussG @jgleeson One of yo... [00:18:08] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Fundraising tech engineers should have clear list of regular "chores" - https://phabricator.wikimedia.org/T246678 (XenoRyet) Looking pretty good. Do we want to do more l... [01:15:29] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Fundraising tech engineers should have clear list of regular "chores" - https://phabricator.wikimedia.org/T246678 (mepps) I like the idea of adding documentation as part... [02:47:27] (PS1) Ejegg: Updates to SmashPig to support recurring iDEAL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) [04:30:59] (CR) Eileen: [C: +1] "This code all looks good & it does what it says on the packet. I tried substituting iDeal into the test case and it did load iDeal but th" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [05:02:07] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Restricting "Assigned to" options - https://phabricator.wikimedia.org/T245641 (Eileenmcnaughton) [11:38:49] (PS11) AlexPinchuk: Cloning Campaign [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/574667 [13:36:37] (PS12) AlexPinchuk: Cloning Campaign [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/574667 [15:11:28] (CR) AndyRussG: "Looks great overall, thanks for doing this!!! Really noice!!!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 (owner: Ejegg) [15:30:03] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (CDenes_WMF) Thank you! [15:49:33] Fundraising-Backlog, fundraising-tech-ops: payments2001 showing mysql errors about reading log events - https://phabricator.wikimedia.org/T248429 (Dwisehaupt) Open→Resolved [15:51:16] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) Going to test this as a working replacement today with a few hosts, and if all goes well, we can cut over. [16:22:26] fr-tech anyone set up to test recurring iDEAL want to take a look at this patch to the CRM extension? https://gerrit.wikimedia.org/r/583193 [16:22:37] ejegg: I was testing it [16:22:48] looking good [16:25:37] ejegg: that need to check PENDING_POKE had me thinking maybe we need a finished flag on things [16:25:44] isComplete or alike [16:26:08] although I think the status complete already lives somewherE? [16:26:32] hmm, there is a completed status [16:26:58] but yeah, I can see the utility of an isCompleted method [16:27:23] it might not help but the need to have different finish lines made me think we could handle that in our normalize step [16:27:42] Could there be other potential states besides completed and pending_poke at that point though? [16:28:07] I felt like pending_poke was a very specific thing that meant 'you need to approve this' [16:28:26] and so it was exactly what I wanted to check to decide whether to call approvePayment [16:28:28] ya I just think pending_poke is not immediately obvious why that's significant [16:28:46] just that the name sounds funny? [16:28:51] pretty much [16:29:02] so a needsApproval() method maybe? [16:29:14] oh that could work [16:29:34] fr-tech gonna be late for standup, groceries just arrived! [16:29:37] which just returns status==pending_poke? [16:29:43] and would be specific to the createPaymentResponse [16:29:45] yeah [16:30:52] I've seen this decision point in two place so far, here and in the tesyAdyenScript. Is there a third? [16:30:58] places [16:32:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Translations page does not update preview of translated messages sometimes - https://phabricator.wikimedia.org/T245057 (Pcoombe) [16:50:40] (CR) Cstone: [C: +2] "Looks good, both ideal and credit card test payments going through." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [16:52:17] (CR) jerkins-bot: [V: -1] Updates to SmashPig to support recurring iDEAL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [16:59:26] hmm, what's that -1? [17:00:36] looks like the same thing the nlNL one ran into a couple days ago? [17:00:57] yep yep, Could not authenticate against github.com [17:01:08] I guess we have a bulk use API token [17:01:19] that can exire and needs to be purged from the docker image [17:01:25] but I'm not sure exactly where to do that [17:01:30] will ask on -releng [17:03:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Translations page does not update preview of translated messages sometimes - https://phabricator.wikimedia.org/T245057 (jbolorinos-ctr) Instead of fixing this bug can we maybe just include some sort of translation tool in the upcoming CN release? W... [17:08:14] PROBLEM - check_puppetrun on frbast2001 is CRITICAL: CRITICAL: Puppet has 31 failures. Last run 6 minutes ago with 31 failures. Failed resources (up to 3 shown) [17:10:14] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 21 failures. Last run 8 minutes ago with 21 failures. Failed resources (up to 3 shown) [17:13:14] RECOVERY - check_puppetrun on frbast2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [17:15:14] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 21 failures. Last run 13 minutes ago with 21 failures. Failed resources (up to 3 shown) [17:16:14] PROBLEM - check_puppetrun on heka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 8 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[pbuilder create --distribution stretch] [17:20:14] RECOVERY - check_puppetrun on frauth2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [17:21:14] RECOVERY - check_puppetrun on heka is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [17:32:42] fr-tech we're going to go over how to use the CentralNotice staging server over in fr-tech-talk [17:34:37] jgleeson: is it dinnertime where you are? [17:35:53] ejegg: I was watching the government public announcement but it's just finished so I'm gonna join now [17:40:44] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) frpm2001 is currently set as the main puppetmaster in codfw. Tested and then enabled with the following changes: ` [frack::puppet] 26fef9a7 Using 3 hosts as test hosts for frpm2001 full fun... [18:36:32] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [18:38:51] (CR) jerkins-bot: [V: -1] Updates to SmashPig to support recurring iDEAL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [19:32:46] fundraising-tech-ops, Operations: rack/setup/install frnetmon1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T232137 (Dwisehaupt) Monitoring enabled. Just need to update netbox and we can close this out. [19:40:14] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583193 (https://phabricator.wikimedia.org/T230837) (owner: Ejegg) [19:42:39] (PS2) Ejegg: Add missing extension reqs to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/580115 [19:43:42] (CR) jerkins-bot: [V: -1] Add missing extension reqs to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/580115 (owner: Ejegg) [19:54:00] ejegg i keep trying to provision more staging servers for central notice but i'm running into nfs errors :( [19:55:56] mepps wasn't the nfs error you got the first time with an older version of the operating system image? [19:56:20] yup ejegg but now i'm getting it using the same os as the working instance [19:56:31] oh darn [19:57:18] I'm currently digging through the CI test boxes looking for where to fix these github auth failures, but I can take a look at the provisioning process in a bit [20:01:11] no worries ejegg, have you chatted with Release engineering? [20:01:25] i was more just saying it out loud becuase that helps with the frustrating [20:03:23] i posted in wikimedia-cloud [20:03:59] mepps: are the errors wrapped in puppet stuff? [20:04:27] i don't think so jgleeson? i get this: mount.nfs: mount to NFS server '192.168.122.1:/srv/mediawiki-vagrant' failed: RPC Error: Unable to receive [20:06:31] oh i see [20:38:57] I'm starting to think I might need to create a separate google calendar for our internet connection! [20:39:09] oh no, is it playing up eileen ? [20:39:28] It being 'them' [20:39:40] so twice a day 'Cinda breaks the internet' [20:40:07] ಠ_ಠ [20:40:09] but also now the kids are having karate classes over the internet [20:40:30] ooo I see [20:40:44] the rest of the family are hogging it [20:40:45] If anyone sees 'karate' in my calendar it doesn't mean I'm doing karate - the kids are & hopefully we have enough bandwidth for me to have hangouts at the same time.... [20:41:10] yep combo of the rest of the family & basically whenever Jacinda addresses the nation it overloads [20:41:50] well actually she addresses the nation once a day but there is another briefing before that where the various ministers address the nation [20:41:52] yeah we're getting the daily briefings here also although they keep changing the times [20:42:45] there's a lot of people losing their jobs here [20:43:32] feel extremely lucky to already work remotely [20:43:39] even tech companies are cutting people here [20:45:40] the government announce they'd pay 80% of employee's salaries if they have to stop working due to the virus but that only seems to apply if the employer either shut down entirely or agree to put staff on extended leave. If companies just make redundancies and keep operating then those people miss out. [20:51:49] well shoot, I'm trying to get the smashpig package updated in our branch of mediawiki/vendor [20:51:59] and it's telling me The requested package amzn/login-and-pay-with-amazon-sdk-php (locked at dev-master) is satisfiable by amzn/login-and-pay-with-amazon-sdk-php[dev-master] but these conflict with your requirements or minimum-stability. [20:52:49] we've got a stability flags section that supposedly should make it accept that [20:52:55] (in the log file at least) [20:52:59] *lock file [20:53:06] hmmm [20:53:13] oh man [20:53:26] composer dependencies confuse the hell outta me [20:53:59] I gave up trying to install rectorphp because I just couldn't get past them on civi and DI [21:01:50] fundraising-tech-ops, DC-Ops, Operations, decommission: decommission bismuth.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T248516 (Dwisehaupt) [21:20:24] (CR) Jgleeson: [C: +2] "Group export working for me! nice" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [21:21:54] (CR) jerkins-bot: [V: -1] Put contacts relevant to ts export into a group. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582951 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [21:25:18] eileen: fr-tech looks like that patch is also hitting the github api issues [21:30:50] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (Ejegg) Is this fine to merge and deploy @CDenes_WMF ? [21:31:13] (PS4) Ejegg: Edits to the Dutch TY email for the NLNL campaign coming up [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/577024 (https://phabricator.wikimedia.org/T246962) (owner: Cdenes) [21:31:52] jgleeson and eileen: the releng team is on the case [21:32:00] thanks! [21:32:20] looks like they have a bit of setup to do to get some auth tokens into the docker containers [21:33:14] (CR) jerkins-bot: [V: -1] Edits to the Dutch TY email for the NLNL campaign coming up [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/577024 (https://phabricator.wikimedia.org/T246962) (owner: Cdenes) [22:10:49] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581096 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [22:15:14] (CR) QEDK: "Recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579738 (https://phabricator.wikimedia.org/T247155) (owner: QEDK) [22:16:20] (CR) jerkins-bot: [V: -1] Bump MW version, remove deprecated IP class, update .gitignore [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/579738 (https://phabricator.wikimedia.org/T247155) (owner: QEDK) [22:19:01] brb, going to try restarting my VPS to see if I can make IrssiNotifier work again [22:42:48] dstrine: I'm going to spread my work out more with kids at home - so should be more available for meetings on your Thurs/ my Fri (& tbh your Fri/ my Sat given the days are all the same now) [22:56:25] (PS2) Ejegg: Audits: use invoice_id field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 [22:57:10] (CR) jerkins-bot: [V: -1] Audits: use invoice_id field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 (owner: Ejegg) [22:59:06] (PS3) Ejegg: Audits: use invoice_id field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 [23:12:26] (PS7) Ejegg: Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 [23:12:37] AndyRussG: I fleshed out the comments a bit there ^^^ [23:13:23] (PS8) Ejegg: Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 [23:35:39] (PS1) Ejegg: Push most response properties to base, add requiresApproval [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/583484 [23:36:02] jgleeson ^^^ contains the new fn so consuming classes won't need to know about PENDING_POKE [23:36:27] AndyRussG: it also reorganizes the heirarchy of response classes like we talked about this morning [23:36:40] (CR) jerkins-bot: [V: -1] Push most response properties to base, add requiresApproval [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/583484 (owner: Ejegg) [23:36:44] oops [23:40:06] (PS2) Ejegg: Push most response properties to base, add requiresApproval [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/583484 [23:40:32] (CR) jerkins-bot: [V: -1] Push most response properties to base, add requiresApproval [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/583484 (owner: Ejegg) [23:42:42] ejegg i was looking at the drush script you started for old ingenico is there a difference between cancel_date and end_date? or do we use both of them the same way [23:43:54] cstone I think maybe we were using cancel_date for civi-side cancels and end_date for cancels we hear about from IPN messages? [23:45:15] (PS3) Ejegg: Push most response properties to base, add requiresApproval [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/583484 [23:47:17] ok thanks! [23:48:19] (CR) XenoRyet: [C: +2] Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [23:49:48] (CR) jerkins-bot: [V: -1] Minor code consolidation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581096 (https://phabricator.wikimedia.org/T246889) (owner: Eileen) [23:49:50] (CR) jerkins-bot: [V: -1] Consolidate email location handling & use core api to add emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/581145 (https://phabricator.wikimedia.org/T246889) (owner: Eileen)