[00:13:46] <ejegg>	 hi eileen_ - I haven't yet!
[00:13:52] <ejegg>	 thanks for the reminder
[00:13:53] <eileen_>	 ok - I'll do it
[00:14:32] <ejegg>	 ah, thanks
[00:16:10] <wikibugs>	 (PS2) Ejegg: Remove hacky handling that is  no longer required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583495 (owner: Eileen)
[00:16:58] <wikibugs>	 (CR) Ejegg: [C: +2] "Yay!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583495 (owner: Eileen)
[00:23:06] <wikibugs>	 (Merged) jenkins-bot: Remove hacky handling that is  no longer required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583495 (owner: Eileen)
[00:31:22] <wikibugs>	 Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (Eileenmcnaughton) @rlewis we've pushed out a fix for this so this particular bug should not recur
[00:31:30] <wikibugs>	 Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import error message received - https://phabricator.wikimedia.org/T246889 (Eileenmcnaughton) Open→Resolved
[00:32:50] <eileen_>	 hmm where are we at on php update - the php 7.0 support in Civi is coming to an end....
[00:37:30] <wikibugs>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/583493 (owner: Eileen)
[00:39:45] <wikibugs>	 (PS2) Eileen: Add squiffle assignee extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583496 (https://phabricator.wikimedia.org/T245641)
[00:57:25] <wikibugs>	 Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (Eileenmcnaughton)
[02:01:17] <ejegg>	 eileen_: I was just asking Jeff_Green about that
[02:01:51] <ejegg>	 he says that civi2001 is all built out and nearly ready to test
[02:02:02] <ejegg>	 so next week we can try it out on i think 7.3
[02:02:05] <ejegg>	 or maybe 7.2
[02:03:23] <eileen_>	 nice
[02:03:39] <eileen_>	 if it's a choice then 7.3
[02:09:13] <ejegg>	 going to sign off for the night. Have a good one!
[06:04:45] <wikibugs>	 (PS3) VolkerE: Remove unnecessary, overqualified element parts of id selectors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/581815 (https://phabricator.wikimedia.org/T248137)
[08:31:17] <wikibugs>	 Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deadlock should result in requeueing the message - https://phabricator.wikimedia.org/T118487 (Aklapper)
[13:53:20] <wikibugs>	 fundraising-tech-ops: rebuild frbackup2001 - https://phabricator.wikimedia.org/T248621 (Jgreen)
[15:01:58] <wikibugs>	 Wikimedia-Fundraising-Banners: Prepare banners for Netherlands Adyen iDeal (inc recurring) pre-test March 26 - https://phabricator.wikimedia.org/T247102 (Pcoombe) Open→Resolved Thanks @Ejegg. I checked the banners and they are all linking to the correct forms now. Looks like we're ready to test!
[15:06:18] <ejegg>	 hi fr-tech!
[15:07:20] <dwisehaupt>	 morn
[15:07:54] <AndyRussG>	 dwisehaupt: ejegg: hellooooo
[15:17:20] <wikibugs>	 Fundraising Dash: Add date filters to common filter component - https://phabricator.wikimedia.org/T120174 (Ejegg) a:Ejegg→None
[15:17:43] <wikibugs>	 Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 5 others: NULL referrers in contribution_tracking - https://phabricator.wikimedia.org/T161539 (Ejegg) a:...
[15:18:20] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change any donor-facing GlobalCollect branding to read "Ingenico". - https://phabricator.wikimedia.org/T122597 (Ejegg) a...
[15:18:44] <wikibugs>	 Fundraising Sprint Kickstopper, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Epic: Reconcile SmashPig and DonationInterface configuration - https://phabricator.wikimedia.org/T143831 (Ejegg) a:Ejegg→None
[15:19:20] <wikibugs>	 Fundraising Dash: Backend component to retrieve Failed Donations for X-by-Y chart - https://phabricator.wikimedia.org/T86848 (Ejegg) a:Ejegg→None
[15:19:52] <ejegg>	 how's it going dwisehaupt and AndyRussG ?
[15:22:09] <dwisehaupt>	 going good here. kids are on their computers doing school work. $spouse is on her computer meeting with students. i'm on my computer working. guess we're out of the stone age now. :)
[15:24:43] <ejegg>	 into the screen age
[15:31:33] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change any donor-facing GlobalCollect branding to read "Ingenico". - https://phabricator.wikimedia.org/T122597 (DStrine)...
[15:42:21] <AndyRussG>	 ejegg: dwisehaupt: yeah same here! I'm actually amazed at how dedicated they've both bee
[15:42:23] <AndyRussG>	 been
[15:42:34] <AndyRussG>	 Ceci is doing an open-book exam here right now
[15:43:24] <AndyRussG>	 Installed debian on an old laptop, almost done the second one, so they can both have 'puters to work with.... should have done this ages ago
[16:03:39] <ejegg>	 nice
[16:09:10] <ejegg>	 fr-tech there are a lot of patches in SmashPig master that we haven't yet deployed to the listener (smashpig standalone) - we should deploy that early next week
[16:13:38] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/583998
[16:15:14] <wikibugs>	 (PS7) Ejegg: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen)
[16:23:45] <wikibugs>	 (PS1) Ejegg: Update IListenerMessageAction::execute with return type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584002 (https://phabricator.wikimedia.org/T243421)
[16:27:17] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Dwisehaupt) Starting on frdb2002 today.
[16:40:43] <wikibugs>	 (PS1) Ejegg: Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421)
[16:42:04] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg)
[16:57:28] <wikibugs>	 fundraising-tech-ops: rebuild frbackup2001 - https://phabricator.wikimedia.org/T248621 (Jgreen)
[16:58:27] <wikibugs>	 fundraising-tech-ops: rebuild frbackup2001 - https://phabricator.wikimedia.org/T248621 (Jgreen) root@frbackup2001:~# ssacli ctrl all show config  Smart Array P440ar in Slot 0 (Embedded)   (sn: PDNLH0BRH679X5)       12G SAS Exp Card at Port 1I, Box 1, OK      Port Name: 1I     Port Name: 2I     Array A (SATA,...
[17:05:33] <wikibugs>	 fundraising-tech-ops, DC-Ops, Operations, decommission: decommission heka.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T248628 (Papaul) ` [edit interfaces interface-range disabled]      member "ge-[0-1]/0/4" { ... } +    member "ge-[0-1]/0/5"; [edit interfaces interface-range vlan-admini...
[17:06:07] <wikibugs>	 fundraising-tech-ops, DC-Ops, Operations, decommission: decommission heka.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T248628 (Papaul)
[17:10:18] <wikibugs>	 fundraising-tech-ops, DC-Ops, Operations, decommission: decommission heka.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T248628 (Jgreen)
[17:36:01] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Investigate donor data delivery tool - https://phabricator.wikimedia.org/T248699 (DStrine)
[17:38:53] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Investigate the rebrand url changes - https://phabricator.wikimedia.org/T248700 (DStrine)
[17:41:21] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (DStrine)
[19:43:39] <wikibugs>	 (PS1) Ejegg: Adyen: use StagingHelper for allowedMethods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584044
[19:44:07] <ejegg>	 jgleeson: ^^^ might do the trick
[19:44:49] <ejegg>	 hmm, though we could also use the one StagingHelper for both
[19:45:44] <ejegg>	 ah damn, we do stage data right in the constructor
[19:45:56] <ejegg>	 well, at least this patch won't crash on empty payment_method
[19:46:56] <ejegg>	 AndyRussG: ^^^ is an example of using a data transformer class for that bit of transaction setup
[20:01:16] <jgleeson>	 ejegg: moving the chat here
[20:01:26] <jgleeson>	 testing your patch now
[20:01:57] <AndyRussG>	 ejegg: okok I'll check it out, thanks!
[20:05:37] <jgleeson>	 ejegg: does the 'values' block of a transaction defined become $stagedData?
[20:06:09] <jgleeson>	 trying to see how $stagedData['allowed_methods'] = $allowedMethods; replaces
[20:06:11] <jgleeson>	    'values' => [
[20:06:13] <jgleeson>	     'allowedMethods' => $allowedAdyenMethods,
[20:06:16] <ejegg>	 jgleeson it's merged with $stagedData when building the actual curl request
[20:06:39] <ejegg>	 well, it's mapped via var_map
[20:08:29] <ejegg>	 let's see, somewhere in buildRequestParams ?
[20:09:00] <ejegg>	 getTransactionSpecificValue
[20:10:11] <ejegg>	 gatway adapter line 770
[20:10:11] <ejegg>	 		// If there's a hard-coded value in the transaction definition, use that.
[20:10:22] <ejegg>	 is where the 'values' array is consulted
[20:11:04] <ejegg>	 then down in 785 they map stuff from staged_data, changing the name via var_map
[20:11:37] <jgleeson>	 thanks
[20:12:07] <wikibugs>	 (CR) Jgleeson: [C: +2] "Nice clean up. Works good over here!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584044 (owner: Ejegg)
[20:13:53] <wikibugs>	 (Merged) jenkins-bot: Adyen: use StagingHelper for allowedMethods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584044 (owner: Ejegg)
[20:15:06] <ejegg>	 thanks!
[20:18:05] <ejegg>	 I'd like to deploy that now if nobody objects
[20:18:59] <wikibugs>	 (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/584051
[20:26:15] <wikibugs>	 (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/584051 (owner: Ejegg)
[20:26:52] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/584051 (owner: Ejegg)
[20:32:29] <wikibugs>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/584053
[20:37:50] <wikibugs>	 (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/584053 (owner: Ejegg)
[20:42:30] <wikibugs>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/584053 (owner: Ejegg)
[20:51:50] <ejegg>	 !log updated payments-wiki from db618f429d to 1640f5e21e
[20:51:54] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:52:58] <jgleeson>	 ejegg: I'll create a ticket for the bug
[20:56:22] <wikibugs>	 Fundraising-Backlog: Adyen sending back 'paymentMethod=ideal' in returnURL which is not being mapped - https://phabricator.wikimedia.org/T248712 (jgleeson)
[20:57:20] <jgleeson>	 MBeat: I just attached you to a ticket added for the bug related to the error page issue you reported https://phabricator.wikimedia.org/T248712
[20:57:31] <MBeat>	 thanks, jgleeson
[20:57:36] <jgleeson>	 it looks like these payments are going through correctly but we're mishandling the return sent back from adyen
[20:57:52] <MBeat>	 so I can conform to the donors that we received the funds, jgleeson ?
[20:57:56] <jgleeson>	 adyen ideal is switched off now right?
[20:58:43] <jgleeson>	 MBeat: there was 300+ instances of that failure and the handful I check had successful payments in the adyen console
[20:59:13] <MBeat>	 ok, we’ll check case by case when following up/donors - only 6 so far - thanks
[21:00:26] <jgleeson>	 hmm MBeat maybe we can't be sure they're all completed payments. ejegg it's possible the status was not AUTHORISED in all cases right?
[21:00:48] <jgleeson>	 but the URL would have still contained the problematic paymentMethod=ideal
[21:00:52] <MBeat>	 if they are in Civi is it ok to confirm?
[21:01:09] <jgleeson>	 yeah if they're complete in civi that's enough to confirm
[21:01:26] <jgleeson>	 it's possible we have ideal payments that were not authorised which triggered the same error
[21:04:16] <jgleeson>	 One way to get a count of successful payments which displayed the error page would be to ask Jeff_Green to scan the log entries for 'Special:AdyenGatewayResult?authResult=AUTHORISED' which also include 'paymentMethod=ideal' across the period ideal was being tested
[21:04:40] <jgleeson>	 that would give us a pretty good idea of how many donations ideal came back to us on that were authorised
[21:04:51] <jgleeson>	 adyen*
[21:05:26] <MBeat>	 ty
[21:07:52] <jgleeson>	 MBeat: just to confirm adyen ideal is off now?
[21:08:05] <jgleeson>	 the test I mean sorry
[21:08:56] <MBeat>	 I believe so, the test was only for 3 hours
[21:09:35] <MBeat>	 but I’m not aure how to confirm banners are down. tskaff_ would know for sure
[21:09:42] <MBeat>	 *sure
[21:11:55] <jgleeson>	 thanks. I just wanted to confirm before I jump off. If it was still running we'd probably need to take it down until we release a patch
[21:12:04] <jgleeson>	 fr-tech do we know what's going on with the ideal test?
[21:12:45] <ejegg>	 I think it's not running any more
[21:12:52] <ejegg>	 wasn't it just going to be 3 hrs?
[21:13:03] <ejegg>	 right, like MBeat says above
[21:13:40] <ejegg>	 jgleeson yeah, we should look to see if any unexpected statuses came back
[21:14:13] <ejegg>	 Jeff_Green: can you maybe just give us a dump of all the requests for Special:AdyenGatewayResult along with their query strings?
[21:14:23] <ejegg>	 or dwisehaupt ^^^
[21:14:56] <dwisehaupt>	 slack says the banners came down at 12noon PST.
[21:15:07] <jgleeson>	 ah shoot. I need to get on slack
[21:15:35] <jgleeson>	 ejegg: yeah we could just remove the auth value for the full count
[21:15:44] <jgleeson>	 I'm head off, have a great weekend all
[21:15:46] <jgleeson>	 o/
[21:15:52] <ejegg>	 have a good one jgleeson!
[21:16:37] <ejegg>	 MBeat is there already a phab for the ideal donors who saw error messages while the payment went through?
[21:17:06] <MBeat>	 jgleeson|away: made T248712, ejegg
[21:17:06] <stashbot>	 T248712: Adyen sending back 'paymentMethod=ideal' in returnURL which is not being mapped - https://phabricator.wikimedia.org/T248712
[21:17:21] <ejegg>	 thanks
[21:19:49] <Jeff_Green>	 ejegg: you just want weblogs for today?
[21:21:35] <ejegg>	 yes please!
[21:22:09] <ejegg>	 trying to figure out why some iDEAL donors saw errors
[21:22:20] <dwisehaupt>	 ejegg: also worth looking in the payments mod_security logs on the log host, there appears to be some entries in there that may be worth investigating. not saying they are related, just noticed them when starting to look at different logs.
[21:24:53] <ejegg>	 thanks dwisehaupt
[21:27:04] <wikibugs>	 Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, and 3 others: Server for previewing/usability testing new CentralNotice features - https://phabricator.wikimedia.org/T241070 (mepps...
[21:29:03] <ejegg>	 dwisehaupt: looks like some false positives on the merchantSig field
[21:29:24] <ejegg>	 I think that'll always be a base64 string about the same length
[21:36:29] <dwisehaupt>	 cool. not sure what to do with it, but figured i'd mention it since i noticed them.
[21:36:49] <wikibugs>	 (PS1) Ejegg: Remove unused parameters from txn building fns [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584062
[21:39:28] <MBeat>	 hey ejegg Evelyn has a question about the iDEAL error message that the donors see: “do you happen to know if the message is from the bank or from Wikimedia when they are told their payment can't be accepted?” - do you know?
[21:56:54] <ejegg>	 MBeat: I'm guessing it's from our own site
[21:57:01] <MBeat>	 thanks ejegg
[22:00:24] <wikibugs>	 Fundraising-Backlog: Estimate the proportion of people who send us complaints vs are affected by an issue - https://phabricator.wikimedia.org/T120722 (MBeat33) T248712 300 affected, 6 complained
[22:01:03] <wikibugs>	 (PS1) Ejegg: Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421)
[22:01:30] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg)
[22:07:49] <ejegg>	 MBeat: we put up one fix that might help, but it's hard to tell exactly how to reproduce the issue
[22:08:16] <MBeat>	 ok, it’s a start, thank you
[22:31:56] <wikibugs>	 (PS2) Ejegg: Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421)
[22:33:49] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Dwisehaupt)
[22:34:02] <wikibugs>	 (PS2) Ejegg: Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421)
[22:35:38] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg)
[22:36:29] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Dwisehaupt) Finished up frdb202. Timings were similar in most cases, but some ran longer. Data reclaimed was also similar as expected. As a note, these queries did not propagate through...