[07:20:42] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584363 (owner: L10n-bot) [07:25:15] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584452 (owner: L10n-bot) [08:11:42] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584363 (owner: L10n-bot) [08:12:36] (CR) Raimond Spekking: [C: +2] "false posirive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584452 (owner: L10n-bot) [14:13:17] fundraising-tech-ops, Operations, observability, User-fgiunchedi: Icinga latency is skyrocketing and commands ignored - https://phabricator.wikimedia.org/T247538 (fgiunchedi) Open→Resolved a:fgiunchedi With https://gerrit.wikimedia.org/r/580985 merged I'm resolving this task since che... [14:49:17] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/583998 (owner: Ejegg) [14:50:03] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/583998 (owner: Ejegg) [15:36:00] !log updated payments listener (standalone SmashPig) from dc0c6b208b to d80e4c5abd [15:36:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:37:42] hello fr-tech [15:39:13] howdy ejegg [15:42:48] my lappy seems to have updated to php7.4 on the command line [15:43:02] finding a bunch of things that will need fixing in drupal [15:43:22] dwisehaupt: do you know if the new civi box (2001) is using php7.2 or php7.3? [15:43:34] oh, I guess I can probably ssh in! [15:43:46] i think it's 7.3, but yeah, you can ssh in. :) [15:44:01] yep, 7.3.14 [15:48:52] bizarre, I can't find what it's complaining about [15:49:10] Array and string offset access syntax with curly braces is deprecated in include_once() (line 20 of crm/drupal/includes/file.phar.inc) [15:49:30] that line includes PharStreamWrapper [15:50:45] ahhh, there it is [15:50:53] line 479 of PharStreamWrapper [15:53:20] (PS1) Ejegg: Fix php7.4 incompat in PharStreamWrapper [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/584623 [16:05:14] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog: Get setup with HEP for matching gifts V2 and break down tasks - https://phabricator.wikimedia.org/T247878 (Ejegg) a:Ejegg [16:15:23] hi ejegg dwisehaupt fr-tech! [16:15:29] hi AndyRussG [16:16:40] hi AndyRussG [17:00:27] :) [17:02:22] hey fr-tech :) [17:02:31] hi jgleeson [17:02:35] hellooo jgleeson :) [17:04:12] hi jgleeson ! [17:25:21] so fr-tech I think we still have a bug with the adyen mapping on line? [17:25:24] on live* [17:26:27] https://phabricator.wikimedia.org/T248712 [17:26:42] just gonna look at a good place to capture and map that param [17:35:19] hi fr-tech [17:35:27] hi mepps [17:35:39] mepps: hellooo :) [17:35:55] hey mepps :) [17:36:29] jgleeson so myabe in the processDonorReturn function? [17:36:39] That one gets a list of all the QS params [17:37:26] yeah ejegg feels like a good place to start. this feels like something we'd want config driven maybe to wire up with the other var map stuff so we can avoid it getting lost in a year or two, do you agree? [17:38:22] actually it looks like processDonorReturn is very specific to each gateway [17:39:10] So the value they send I think maps to the brandCode in Adyen's payment_submethods.yaml [17:39:13] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/adyen_gateway/config/payment_submethods.yaml [17:40:16] we should be able to search by brandCode, use 'group' to set payment_method, and use the top-level submethod key to set payment_submethod [17:40:39] hmm, maybe we could additionally log if those differ from what we've got in session [17:40:55] yeah, let's definitely log those differences [17:53:09] (CR) Ejegg: [C: +2] Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [17:55:02] jgleeson that mapping could potentially happen in the AdyenPaymentMethodCodec [17:55:19] hmm [17:55:31] if you make it implement UnstagingHelper [17:55:49] may or may not be logical [17:58:53] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-Adyen: Adyen iDeal handled through smashpig. - https://phabricator.wikimedia.org/T230837 (Ejegg) Open→Resolved [17:58:55] Fundraising-Backlog: EPIC: Enable the ability for user to pay with iDeal through Adyen - https://phabricator.wikimedia.org/T231370 (Ejegg) [17:59:08] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-AutoTY-Email: NLNL TY Email - https://phabricator.wikimedia.org/T246962 (Ejegg) Open→Resolved [17:59:49] I guess we are unstaging [18:00:42] I'll try that [18:01:58] (Merged) jenkins-bot: Remove activities relating to deleted-by-merge contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582954 (https://phabricator.wikimedia.org/T245088) (owner: Eileen) [18:27:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: system status warning on civi production - https://phabricator.wikimedia.org/T248900 (DStrine) [18:32:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New certificate for Breianne B - https://phabricator.wikimedia.org/T248398 (Dwisehaupt) @LeanneS I just wanted to check back in and verify that Brianne was able to use her existing cert. If so, we can close out this request. Th... [18:35:51] fundraising-tech-ops: Document changes needed to bring up a new build host as full puppet master - https://phabricator.wikimedia.org/T248901 (Dwisehaupt) [18:36:25] fundraising-tech-ops: Document changes needed to bring up a new build host as full puppet master - https://phabricator.wikimedia.org/T248901 (Dwisehaupt) a:Dwisehaupt→None [18:36:45] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Dwisehaupt) Open→Resolved [18:36:47] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frpm2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242269 (Dwisehaupt) [18:55:18] (CR) Ejegg: [C: +2] "Works locally, doesn't break any other forms as far as I can tell." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/583493 (owner: Eileen) [18:56:09] jgleeson: lmk if the unstaging flow seems clunky [19:01:37] (Merged) jenkins-bot: Ensure options are loaded for metadata [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/583493 (owner: Eileen) [19:18:14] (CR) Mepps: [C: +2] "Works as expected for me locally!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583496 (https://phabricator.wikimedia.org/T245641) (owner: Eileen) [19:24:35] (Merged) jenkins-bot: Add squiffle assignee extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583496 (https://phabricator.wikimedia.org/T245641) (owner: Eileen) [19:26:38] (CR) Ejegg: [C: +2] "works well for me too - just had trouble finding the settings in any parent menu and had to go directly to civicrm/assigneesettings." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/583496 (https://phabricator.wikimedia.org/T245641) (owner: Eileen) [19:27:55] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, and 4 others: Cull low value data from activity table - https://phabricator.wikimedia.org/T245088 (mepps) Moving to Pend... [19:32:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New certificate for Breianne B - https://phabricator.wikimedia.org/T248398 (LeanneS) @Dwisehaupt She is all set with her current certificate. Thanks! [19:37:41] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, Fr-planning-ahead: fill out PCI saq a forms and document process - https://phabricator.wikimedia.org/T243020 (XenoRyet) Open→Resolved [19:40:05] Fundraising-Backlog, fundraising-tech-ops: Investigate the rebrand url changes - https://phabricator.wikimedia.org/T248700 (DStrine) [19:48:11] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (DStrine) [20:14:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: system status warning on civi production - https://phabricator.wikimedia.org/T248900 (DStrine) [20:15:16] Fundraising-Backlog, FR-Adyen: Adyen sending back 'paymentMethod=ideal' in returnURL which is not being mapped - https://phabricator.wikimedia.org/T248712 (DStrine) [20:16:22] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-Adyen: Adyen sending back 'paymentMethod=ideal' in returnURL which is not being mapped - https://phabricator.wikimedia.org/T248712 (DStrine) [20:19:59] Fundraising-Backlog: 3 Paypal recurring payments missing predecessor - https://phabricator.wikimedia.org/T248420 (DStrine) Open→Resolved [20:27:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/ - https://phabricator.wikimedia.org/T244020 (DStrine) @Quiddity and @Seddon as fYI There should be some validation and better messaging about bann... [20:30:20] (PS7) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [20:37:54] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [21:02:20] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (mepps) @Eileenmcnaughton can you let me know your thoughts/how I can help with this task? Also is the a... [21:17:16] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (Jgreen) Mostly from today's fr-tech/fr-tech-ops meeting, how we architect this really depends on what we need in terms of backend and endpoint handling. Host... [21:40:22] back on line XenoRyet|afk - when you are ready - or we can skip too [21:40:28] (PS8) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [21:46:50] (PS3) Ejegg: Add missing extension reqs to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/580115 [21:47:39] ejegg: I'm going down a rabbit hole on this adyen fix. it looks like there is stuff written to the unstaged array via this route https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/93ad3f3938526a1eff56eb40f5bdc74b26cf0c17/adyen_gateway/adyen.adapter.php#L310 which then calls [21:47:41] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/128117e60c5844d0ea8588c4d9206aa5315df5c3/gateway_common/gateway.adapter.php#L2456 but that route skips the Transformers. I wonder if $this->addRequestData() should instead be $this->addResponseData() [21:48:15] I like the idea of transforming the response data if possible so getting this to work feels like the right thing to do [21:49:21] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [21:49:22] I could add an additional call to $this->addResponseData() to trigger the transformers and leave stuff alone but then I'm wonder whether we need the addRequestData() call. I don't see what it does in the context of this flow [21:49:54] most other places, addRequestData is used before an API call [21:50:18] jgleeson yeah, addResponseData does sound more like what we'd want [21:50:31] lemme try swapping that out and seeing what happens [21:50:44] I guess that expects the mapped parameter names though [21:56:40] (CR) Ejegg: "recheck" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/567991 (https://phabricator.wikimedia.org/T243806) (owner: Ejegg) [21:57:37] eileen: Yea, I think we'd better skip, too much else to do today. [21:58:03] cool [22:09:15] I trying export - started at 22.07 [22:09:45] & it has errored out [22:12:14] OK found it - PHP Fatal error: Maximum execution time of 60 seconds exceeded in [22:12:18] We can fix that [22:23:21] (PS1) Jgleeson: Handle mapping of adyen payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584718 [22:25:42] ejegg: I haven't been able to confirm this fixes the problem. I tried deleting session values prior to the code that fails running but with your new changes from friday it moves that logic to a later point which I don't think results in the same error... so I'm a little stumped on this [22:26:21] I might try that fix with the old code to see if it fixes the original problem [22:27:06] have a good evening all [22:28:24] (PS2) Jgleeson: Handle mapping of adyen payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584718 (https://phabricator.wikimedia.org/T248712) [22:28:43] (PS1) Ejegg: Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) [22:28:48] (PS3) Jgleeson: Handle mapping of Adyen ideal payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584718 (https://phabricator.wikimedia.org/T248712) [22:29:13] (CR) jerkins-bot: [V: -1] Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [22:34:24] (PS3) Ejegg: Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421) [22:38:49] (PS4) Ejegg: Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) [22:38:51] (PS2) Ejegg: Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) [22:39:28] (CR) jerkins-bot: [V: -1] Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [22:42:07] (PS3) Ejegg: Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) [22:46:40] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (Eileenmcnaughton) @mepps my understanding is that they want the 'Refine Search' box on all 3 fields. It... [23:02:26] mepps: I added some notes - I'm just trying to get a fix for that export & I'll dig in more [23:05:22] (PS1) Ejegg: Return and argument types for config & context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584730 (https://phabricator.wikimedia.org/T243421) [23:17:01] (PS1) Eileen: Temporary fix to help export TS data [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/584732 (https://phabricator.wikimedia.org/T247624) [23:17:38] I've lost patience to do a good fix for the export issue -anyone up for approving the hack above ^^ [23:24:44] (CR) Ejegg: [C: -1] "This looks like a step in the right direction! Let's go further and use $adapter->getPaymentSubmethods() and filter for the one with a mat" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584718 (https://phabricator.wikimedia.org/T248712) (owner: Jgleeson) [23:34:50] eileen: sure! since it's a hack, should I ignore the leading space inside the parens? :) [23:35:01] ejegg: :-) [23:35:14] I will let the patch go when we upgrade [23:35:18] k [23:35:54] (CR) Ejegg: [C: +2] Temporary fix to help export TS data [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/584732 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [23:36:38] signing off for now. See ya! [23:42:15] (Merged) jenkins-bot: Temporary fix to help export TS data [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/584732 (https://phabricator.wikimedia.org/T247624) (owner: Eileen) [23:47:47] (PS1) Eileen: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/584740 [23:47:58] (CR) Eileen: [C: +2] Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/584740 (owner: Eileen) [23:49:19] (CR) jerkins-bot: [V: -1] Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/584740 (owner: Eileen) [23:49:41] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/584740 (owner: Eileen) [23:56:38] (Merged) jenkins-bot: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/584740 (owner: Eileen)