[01:20:58] Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Eileenmcnaughton) So does this look right? |table|Before|After|saved |civicrm_activity|110GB|103GB|7GB| |civicrm_activity_contact|33GB|20GB|13GB| |civicrm_addresst|12GB|7GB|5GB| |civic... [12:24:06] Fundraising-Backlog, fundraising-tech-ops, Epic: Look at deleting indexes - https://phabricator.wikimedia.org/T249046 (Zoranzoki21) Looks like that this task is duplicate of {T249044}, so I closing this task. [12:24:22] Fundraising-Backlog, fundraising-tech-ops, Epic: Look at deleting indexes - https://phabricator.wikimedia.org/T249044 (Zoranzoki21) [12:24:24] Fundraising-Backlog, fundraising-tech-ops, Epic: Look at deleting indexes - https://phabricator.wikimedia.org/T249046 (Zoranzoki21) [14:58:46] hey dstrine I've finished my review notes for the banner template patch (the main one) and tested the functionality. I just need to check them against the RFP. Just saw the email [15:03:04] jgleeson: oh oops well let's talk next week [15:05:57] cool [15:21:47] fr-tech any news for scrum of scrums? [15:35:28] nope from me ejegg [15:44:51] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 9 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (Ejegg) a:Ejegg... [15:44:59] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, fundraising Sprint Grep works IRL, FR-Ingenico, and 2 others: Test migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (Ejegg) a:Cstone [15:45:28] Fundraising-Backlog, fundraising Sprint Grep works IRL, Fr-planning-ahead: Planning ahead tasks for sprint G 2020 - https://phabricator.wikimedia.org/T249017 (Ejegg) [15:52:41] r-tech anyone want to offer a tidbit for the advancement email standup? [15:52:51] oops [15:52:54] fr-tech ^^ [15:57:07] dstrine not a lot to say - we're trying to figure out the HEPdata API (waiting on a response about authentication) [15:57:26] and have a couple little fixes for the Adyen frontend in review [15:57:35] ejegg: I was looking for a personal tidbit [15:57:43] oh right, tidbits [15:57:44] like, how are your banana plants doing? [15:57:57] errr, still way too little to have bananas [15:58:15] and it's cloudy here so not a good day to take a picture [15:58:51] That was just an example. I'm down to share any news [16:34:11] Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice: investigate: Find alternative to Special:HideBanners cookies to mitigate the loss of 3rd-party cookie support - https://phabricator.wikimedia.org/T244699 (Ejegg) The exception for Safari - the '[[ https://webk... [17:05:58] fundraising-tech-ops, Operations, decommission, ops-eqiad: decommission frav1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T222109 (RobH) [17:08:55] (PS1) Ejegg: Update terminology: allow list / deny list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/585277 [17:09:26] mepps I just got it in my head to make ^^^ change - I think we'd talked about doing it, but I don't see a phab [17:09:54] Nice ejegg!! [17:21:22] Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice: investigate: Find alternative to Special:HideBanners cookies to mitigate the loss of 3rd-party cookie support - https://phabricator.wikimedia.org/T244699 (spatton) Thanks for managing this, @Ejegg. I'm also th... [17:30:46] fr-tech I'll be in -talk soon [17:31:53] Yea, few minutes for me as well. Trying to get the kids settled into an activity. [17:39:09] fundraising-tech-ops, Operations, decommission, ops-eqiad: decommission bismuth.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T248516 (RobH) [17:39:58] fundraising-tech-ops, Operations, decommission, ops-eqiad: decommission americium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T245038 (RobH) [17:48:13] hey fr-tech, sorry got online late due to nap issues and have a bit of a headache [17:52:19] Fundraising-Backlog, MediaWiki-Vagrant, Operations: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (hashar) [17:55:45] No worries mepps. We're hanging out in tech-talk if you want to join. [17:56:01] Lots of us realizing our VPN setups had gone stale. [17:57:51] oh me to XenoRyet [18:04:58] Fundraising-Backlog, MediaWiki-Vagrant, Operations: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (hashar) I have added a couple tasks that are related to Xdebug 2.7.0 having bug. For T234418, I have identified the upstream patch and got it added to our Debia... [18:38:30] (CR) Mepps: "Does this need ot change in wmf_audit to be done concurrently? I don't want to +2 if we want to wait for that." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 (owner: Ejegg) [18:42:07] (CR) Ejegg: "Thanks mepps! The wmf_audit change will be needed when we update the package version and also update the package in CRM, so we can control" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 (owner: Ejegg) [18:42:41] officially no april fools prank from google this year [18:43:22] we can all watch this BBC one from 1957: https://www.youtube.com/watch?v=tVo_wkxH9dU [18:43:41] (CR) Mepps: [C: +2] "Cool, this looks good to me." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 (owner: Ejegg) [18:43:49] ejegg: that one is a classic [18:45:26] (Merged) jenkins-bot: Audits: use invoice_id field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/436087 (owner: Ejegg) [18:52:20] (CR) Mepps: [C: +2] "Nice!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/569294 (https://phabricator.wikimedia.org/T234342) (owner: Ejegg) [18:56:24] (CR) XenoRyet: [C: +2] Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [19:01:22] (Merged) jenkins-bot: Better PAN validation for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/569294 (https://phabricator.wikimedia.org/T234342) (owner: Ejegg) [19:02:15] (CR) XenoRyet: [C: +2] Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [19:07:24] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Dwisehaupt) Spent some time digging into superset and how to get it packaged up for use on our hosts. There is no debian package, and the install proce... [19:09:30] (CR) XenoRyet: [C: +2] Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [19:12:04] (CR) XenoRyet: [C: +2] Return and argument types for config & context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584730 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [19:13:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Civi: enable all DS agents to delete smart groups - https://phabricator.wikimedia.org/T249153 (DStrine) [19:34:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Don't save bogus email addresses to Civi - https://phabricator.wikimedia.org/T249160 (DStrine) [19:41:12] (CR) Jgleeson: [C: -1] "hi! could you also update CentralNotice.sql to include these changes. thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 (owner: ItSpiderman) [19:42:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Don't save bogus email addresses to Civi - https://phabricator.wikimedia.org/T249160 (Eileenmcnaughton) 'na@na.com', 'name@domain.com', 'no@gmail.com', 'no@no.com', 'noemail@gmail.com', 'noemail@noemail.co... [19:51:12] Fundraising-Backlog: Issue generating new ssh keypair - https://phabricator.wikimedia.org/T249165 (MSuijkerbuijk_WMF) [19:52:26] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Nuria) @Dwisehaupt you can take advantage of the already existing puppet modules for superset. See a recent example of changes to those: https://gerri... [19:57:57] (PS2) AndyRussG: Get language from session when non-standard URL parameters used [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584741 (https://phabricator.wikimedia.org/T247885) [19:58:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Don't save bogus email addresses to Civi - https://phabricator.wikimedia.org/T249160 (MBeat33) couple more: 'a@a.com', 'test@test.com', 'xxx@xxx.com', 'no@email.com', 'abc@gmail.com', 'no@thanks.com', 'x@x.com', 'a@gmail.com', 'test@gmail... [19:59:00] fr-tech ready for review again ^ [20:04:21] (CR) Jgleeson: [C: -1] "Functionality working as expected for me at this end. I had a few questions about type casting and test clean up but not much else! Nice w" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [20:12:19] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Nuria) Also https://wikitech.wikimedia.org/wiki/Analytics/Systems/Superset#Administration https://wikitech.wikimedia.org/wiki/SWAP#Administration [20:14:45] (CR) Jgleeson: "this looks good but I won't +2 yet until you get chance to look at the earlier patches" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 (owner: ItSpiderman) [20:15:27] dstrine: I've finished review on the banner templates stuff for CN [20:15:47] hey eileen [20:15:49] jgleeson: cool. Do you think there is anything they need to address/change? [20:16:04] ye there are a few questions which I've added to the tickets [20:16:19] only small things [20:16:33] on the whole it works well [20:17:17] ok cool and thanks. If you are looking for anything else, the next priority is the matching gifts stuff. But ejegg is working through the early stages of that [20:17:28] awesome [20:17:36] I don't know if you can help review or anything before standup tomorrow [20:20:40] I know ejegg has a bunch of stuff in review from his eod so I'll jump on that if nothing else is available [20:40:43] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, fundraising Sprint Grep works IRL, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (mepps) @Eileenmcnaughton I saw the trait PR was merged. Where did... [20:46:55] Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Dwisehaupt) @Eileenmcnaughton That is pretty close. The numbers are a little bit off in a place or two, but I'm pretty sure it's due to converting to gigabytes using 1000 vs 1024 as the... [20:48:01] Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Dwisehaupt) frdb1003 is complete. Here are the details on it's compaction. ` # compact_innodb_table -d civicrm -t civicrm_entity_tag Alter complete in: 20 seconds AKA: 0 minutes and... [20:50:20] Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Dwisehaupt) [20:54:05] This is worth a look - https://github.com/civicrm/civicrm-core/pull/16942 [20:54:41] :) eileen [20:55:10] haha excellent eileen [20:55:13] 😅 [20:55:56] 🦖 [20:57:25] 🐇 [20:59:58] Fundraising-Backlog, fundraising-tech-ops: Issue generating new ssh keypair - https://phabricator.wikimedia.org/T249165 (Dwisehaupt) Hi Mariana, You need to specify the path on your local machine for your username. So, instead of specifying `/Users/you/fr_id_rsa` for the key file location, you would wan... [21:00:12] Fundraising-Backlog, fundraising-tech-ops: Tables to compact on frdb hosts - https://phabricator.wikimedia.org/T248609 (Eileenmcnaughton) @Dwisehaupt it occurred to me that we could update the dev db on staging with a restore & then see if any of it's tables are smaller to see if we missed any... [21:01:35] Fundraising-Backlog, fundraising-tech-ops, Analytics: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Dwisehaupt) @Nuria Thanks for those links. I hadn't dug into the puppet portions yet but will do so. Hopefully there will be some bits we could reuse g... [21:07:54] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, fundraising Sprint Grep works IRL, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (Eileenmcnaughton) @mepps this is pretty much the latest - https:... [21:22:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [21:26:44] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, fundraising Sprint Grep works IRL, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (mepps) @Eileenmcnaughton that looks like you got pretty far! But... [21:27:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1201 [21:31:30] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising-Backlog, fundraising Sprint Grep works IRL, FR-Civi-Prospect: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (Eileenmcnaughton) @mepps I replied over on that PR [21:32:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1501 [21:37:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [21:42:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [21:47:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [21:50:25] ACKNOWLEDGEMENT - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) Dwisehaupt Known [23:16:40] (PS3) Ejegg: Get language from session when non-standard URL parameters used [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584741 (https://phabricator.wikimedia.org/T247885) (owner: AndyRussG) [23:16:59] (CR) Ejegg: [C: +2] "Thanks! This works, and it looks like the safest way to go about it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584741 (https://phabricator.wikimedia.org/T247885) (owner: AndyRussG) [23:17:11] RECOVERY - check_mysql on frdb1003 is OK: Uptime: 1844161 Threads: 2 Questions: 69732028 Slow queries: 130 Opens: 33210 Flush tables: 1 Open tables: 700 Queries per second avg: 37.812 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [23:18:53] (Merged) jenkins-bot: Get language from session when non-standard URL parameters used [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584741 (https://phabricator.wikimedia.org/T247885) (owner: AndyRussG) [23:24:29] (PS9) Ejegg: Split out Adyen prepareResponseObject function [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/582169 [23:24:41] (PS4) Ejegg: Push most response properties to base, add requiresApproval [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/583484 [23:24:47] (PS2) Ejegg: Update IListenerMessageAction::execute with return type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584002 (https://phabricator.wikimedia.org/T243421) [23:24:53] (PS4) Ejegg: Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421) [23:25:00] (PS5) Ejegg: Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) [23:25:09] (PS4) Ejegg: Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) [23:25:15] (PS2) Ejegg: Return and argument types for config & context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584730 (https://phabricator.wikimedia.org/T243421) [23:50:47] Fundraising-Backlog: Rejects in Spain During Big Bundle starting 3.31.2020 - https://phabricator.wikimedia.org/T249182 (EMartin) [23:57:09] (PS4) Ejegg: Handle mapping of Adyen ideal payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/584718 (https://phabricator.wikimedia.org/T248712) (owner: Jgleeson) [23:57:11] (PS1) Ejegg: Unstage Adyen payment method using ReferenceData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/585352 (https://phabricator.wikimedia.org/T248712)