[05:31:42] (PS1) Awight: Fix hard tab in YAML [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/591631 [05:32:05] (CR) jerkins-bot: [V: -1] Fix hard tab in YAML [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/591631 (owner: Awight) [05:44:39] (PS1) Awight: PEP 8: underscore prefix for internal methods [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/591634 [06:02:50] Fundraising-Backlog: Improve process-control logging around locks - https://phabricator.wikimedia.org/T165072 (awight) Hi, I'm just looking at some `process-control` tasks for fun... I'm trying to remember if this is actually a thing, > should log when a job is not run because a lockfile exists The `failop... [06:34:55] (PS1) Awight: Clean up stale lockfile handling [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/591657 (https://phabricator.wikimedia.org/T165072) [06:56:39] Fundraising-Backlog: Minor process-control lock refactor for separation of concerns - https://phabricator.wikimedia.org/T177296 (awight) +1 this sounds like a good idea! I poked around a bit looking for a precedent we can follow, but didn't find anything great. What we want is similar to a [[ https://docs.... [10:56:03] (PS1) Awight: Open lockfile as exclusive-create [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/591808 (https://phabricator.wikimedia.org/T177296) [11:01:57] Fundraising-Backlog, fundraising-tech-ops: process-control repeated failure handling - https://phabricator.wikimedia.org/T161567 (awight) If you end up handling at the Python level, there's a nice library "[[ https://pypi.org/project/retry/ | retry ]]" which includes geometric back-off and stuff. [14:53:41] AndyRussG: no CN hallo welt call this week but definitely next week [15:06:11] dstrine: ah ok cool thanks! heheh sorry I just pinged you to elsewhere ask about just that, should have checked my other pings first! [15:08:13] dstrine: I guess maybe you saw, jgleeson fixed the issue test issue rather than writing it up, since it was quite straightforward, as far as I understand [16:29:20] ah ok AndyRussG [16:32:46] dstrine: :) pls don't hesitate to reach out if you have any work stuff... I'm just here doing some housework in preparation for my kids coming over, and I'll just mainly be doing my music stuff later on, also on the computer [16:33:38] ok well I'm just heads down documenting things also. Trying to get to a bunch of asynchronous stuff. [16:35:19] dstrine okok have fun! [16:45:50] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) [16:53:03] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) [16:53:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Monthly convert: tracking in civi - https://phabricator.wikimedia.org/T235546 (DStrine) [16:55:03] Fundraising-Backlog: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) [16:55:29] (PS12) ItSpiderman: Schema change for region-level geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/552121 (https://phabricator.wikimedia.org/T226438) (owner: Ejegg) [16:55:31] (PS57) ItSpiderman: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [16:55:33] (PS15) ItSpiderman: Geotargeting: Collapse countries and regions into one column [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/571768 (https://phabricator.wikimedia.org/T243011) (owner: Mepps) [16:55:35] (PS14) ItSpiderman: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) (owner: Mepps) [16:55:37] (PS3) ItSpiderman: Add method for creating unique region code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/588132 (https://phabricator.wikimedia.org/T102848) (owner: Ejegg) [16:55:39] (PS3) ItSpiderman: Geotarget list below selector: sort and add separator [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/588156 (https://phabricator.wikimedia.org/T226438) (owner: Ejegg) [16:55:41] (PS5) ItSpiderman: Banner Allocation: region dropdown depends on country [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/588765 (https://phabricator.wikimedia.org/T102848) (owner: Ejegg) [16:55:43] (PS3) ItSpiderman: Include country and region codes in tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/591123 (https://phabricator.wikimedia.org/T243012) (owner: AndyRussG) [16:55:45] (PS10) ItSpiderman: Schema changes related to BannerTemplates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 [16:55:47] (CR) Jforrester: [C: +2] Don't use addExtensionUpdate and arrays, use specific functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/591484 (owner: Reedy) [16:55:51] (PS26) ItSpiderman: Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 [16:56:09] (PS10) ItSpiderman: Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 [16:56:43] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) [16:56:46] Fundraising-Backlog, FR-AutoTY-Email: translate monthly conversion TY email - https://phabricator.wikimedia.org/T244797 (DStrine) [16:57:18] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) [17:01:05] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (DStrine) [17:08:44] Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice: investigate: Find alternative to Special:HideBanners cookies to mitigate the loss of 3rd-party cookie support - https://phabricator.wikimedia.org/T244699 (DStrine) correction. It is technically possible to add... [17:12:53] (Merged) jenkins-bot: Don't use addExtensionUpdate and arrays, use specific functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/591484 (owner: Reedy) [17:30:30] Fundraising-Backlog, FR-AutoTY-Email, Epic: EPIC: Q4 FY 19/20 TY recurring email polish pass - https://phabricator.wikimedia.org/T250921 (DStrine) [17:31:49] (PS15) Mepps: Geotargeting: Show selected countries and regions under tree selector [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576153 (https://phabricator.wikimedia.org/T226438) [17:32:38] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) [17:32:41] Fundraising-Backlog, FR-AutoTY-Email, Epic: EPIC: Q4 FY 19/20 TY recurring email polish pass - https://phabricator.wikimedia.org/T250921 (DStrine) [17:32:43] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) [17:57:53] Fundraising-Backlog: Put a loading indicator after clicking CONTINUE on PaymentsWiki - https://phabricator.wikimedia.org/T237279 (DStrine) I feel like there was a previous task describing this and we declined it. We don't have a ton of control over this. The lag is highly dependent on the psp's performance a... [17:59:53] Fundraising-Backlog: restart training fr-online peeps on editing payments wiki - https://phabricator.wikimedia.org/T250924 (DStrine) [23:09:49] (PS3) Ejegg: Update IListenerMessageAction::execute with return type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584002 (https://phabricator.wikimedia.org/T243421) [23:09:51] (PS5) Ejegg: Update SmashPigDatabase and subclasses for php7 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584013 (https://phabricator.wikimedia.org/T243421) [23:09:53] (PS6) Ejegg: Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) [23:09:55] (PS5) Ejegg: Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) [23:09:57] (PS3) Ejegg: Return and argument types for config & context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584730 (https://phabricator.wikimedia.org/T243421) [23:09:59] (PS1) Ejegg: Use PSR-12 standard spacing for return types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/592109 (https://phabricator.wikimedia.org/T243421) [23:11:01] (CR) Ejegg: "Thanks, jgleeson! I added a new patch Ica45776089d451e0 to fix the existing inconsistencies and then rebased all these patches on top of i" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584002 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [23:16:13] (CR) Ejegg: [C: +2] "Code looks good and it works well for me locally." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/591123 (https://phabricator.wikimedia.org/T243012) (owner: AndyRussG) [23:43:41] (CR) Ejegg: [C: -1] "First pass over the code, still haven't run it successfully but tried to answer some of the inline questions" (11 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg)