[00:46:51] (PS9) Cstone: Drush script to tokenize old recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [00:48:20] (CR) Cstone: Drush script to tokenize old recurring GC (12 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [12:44:22] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (RLewis) @Dwisehaupt so sorry for the delay on getting back to you on this. I do need access to this after all. I'll attempt to start the process above and reach out if I have... [12:50:32] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (RLewis) @Dwisehaupt here's what I could see on the terminal after following the steps: Rosies-MacBook:~ rosielewis$ cat ~/.ssh/fr_id_rsa.pub ssh-rsa AAAAB3NzaC1yc2EAAAADAQAB... [12:54:12] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (RLewis) Public yubikey details: Your Yubikey Public ID is: ccccccrdrdcj [13:24:16] (PS66) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [13:26:08] (CR) jerkins-bot: [V: -1] Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [13:28:02] Fundraising-Backlog, Security: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (mepps) [13:30:21] (PS67) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [13:30:57] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, and 6 others: Address final code review comments on geotargeting - https://phabricator.wikimedia.org/T250751 (mepps) a:mepps→And... [13:32:14] (CR) jerkins-bot: [V: -1] Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [13:48:13] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/592948 [13:52:18] ejegg|away i wanted to deploy the change for NL but i notice that there are a bunch of other patches, should i deploy them all or do it as a one-off? [14:01:21] (PS68) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [14:02:00] fr-tech in case anyone else knows the answer to my question for ejegg|away above ^^ [15:21:31] mepps let's deploy it all [15:21:50] (CR) Mepps: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/592948 (owner: Mepps) [15:22:36] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/592948 (owner: Mepps) [15:22:51] i'll try an adyen payment once it goes out - one of the patches affects how the donor return is processed [15:24:36] (PS1) Mepps: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/592981 [15:27:02] (CR) Mepps: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/592981 (owner: Mepps) [15:32:57] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/592981 (owner: Mepps) [15:35:25] (PS11) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [15:37:38] (CR) jerkins-bot: [V: -1] WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [15:42:18] !log updated payments-wiki from 45bf1734e0 to 8c896a8247, [15:42:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:42:32] okay ejegg it went out [15:45:39] (PS1) Ejegg: Add drush 8 as a composer dependency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/592986 (https://phabricator.wikimedia.org/T245562) [16:14:11] oops, testing now [16:14:25] ugh, I need to fix that IRC notifier [16:16:00] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) Stalled→Open [16:16:02] fundraising-tech-ops: Access to the ssh frdev1001 server - https://phabricator.wikimedia.org/T232401 (Dwisehaupt) [16:21:25] ut-oh, I got an error [16:21:38] may have been a typo? [16:28:09] Fundraising-Backlog, FR-Adyen: Recent settled Adyen iDEALs not reachning Civi - https://phabricator.wikimedia.org/T251296 (MBeat33) [16:28:20] Fundraising-Backlog, FR-Adyen: Recent settled Adyen iDEALs not reachning Civi - https://phabricator.wikimedia.org/T251296 (MBeat33) p:Triage→High [16:28:45] Fundraising-Backlog, FR-Adyen: Recent settled Adyen iDEALs not reaching Civi - https://phabricator.wikimedia.org/T251296 (MBeat33) [16:31:07] oh dang MBeat, looking at the logs now. We did have a tough time parsing audit files for the GlobalCollect iDEAL donations, but that shouldn't be affecting Adyen ones [16:31:31] many thx ejegg [16:37:03] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) [16:37:48] tzag fr-tech [16:38:20] jgleeson: tzag! :) [16:38:33] :):) [16:38:37] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) Changes pushed for account, ssh key, and yubikey: ` [frack::puppet] 9866c2f4 Adding account for rlewis [frack::puppet::private] 194b388 Adding yubikey and ssh pu... [16:38:42] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (jgleeson) a:jgleeson→None [16:39:12] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (jgleeson) a:jgleeson→None [16:39:27] tzag jgleeson AndyRussG ! [16:39:47] cstone: :) [16:40:27] :) [16:46:08] hi jgleeson, cstone, AndyRussG ! [16:50:21] Fundraising-Backlog, FR-Adyen: Recent settled Adyen iDEALs not reaching Civi - https://phabricator.wikimedia.org/T251296 (Ejegg) Looking for the first attempt ID in the logs, I see neither a return to payments-wiki nor an IPN message confirming the payment capture (there are logs of the attempt initializ... [16:50:48] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) Forgot to increment the uid. Did that in this commit: ` [frack::puppet] 65f6ae02 Fixup on the UID for rlewis. ` [16:53:14] PROBLEM - check_puppetrun on frbast2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 7 minutes ago with 1 failures. Failed resources (up to 3 shown): User[rlewis] [16:53:39] hi ejegg ! [16:58:09] ejegg hellooooo :) [16:58:14] RECOVERY - check_puppetrun on frbast2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [17:04:38] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) [17:05:52] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) Added to mysql grants, applied grants, verified could get in to mysql as the user. ` [frack::puppet::private] 135c3fc Adding rlewis mysql account and grants ` [17:07:00] mepps: eileen made a page with all the civi communication fields described. I know you edited it too. I can't seem to find it. I don't think it's actually linked to any other pages :/ [17:09:15] dstrine it’s linked on the fundraising tech homepage: https://m.mediawiki.org/wiki/Fundraising_tech/CiviCRM [17:16:46] Fundraising-Backlog, FR-Adyen: Recent settled Adyen iDEALs not reaching Civi - https://phabricator.wikimedia.org/T251296 (Ejegg) OK, the ratio of those 'buffered' warnings to total payment attempts has been more or less constant over the year to date at about 1 in 3, so there's no spike in that particula... [17:20:22] oh dang fr-tech, looks like in production we only get the AUTHORIZATION ipn for Adyen/iDEAL [17:20:29] we never get a CAPTURE [17:20:40] :? [17:20:41] we were getting both in the sandbox, weren't we? [17:20:57] hmm I can't remember [17:21:00] What does that mean ejegg? [17:21:08] hmm i cant remember either [17:21:14] I mean for contributions [17:21:15] so for iDEAL we should treat the AUTHORIZATION like we treat a cc CAPTURE [17:21:22] mepps: it's the status of the transactions we get back from the first send and the followup IPN [17:21:27] i.e. send it to Civi right then [17:21:34] I feel like we were seeing both in sandbox, but I don't remember for certain. [17:21:55] we've still got the script thingy right [17:22:02] the cli testAdyenyadayda [17:22:23] i still have everything set up locally I think to see [17:22:28] let me check the payment console and see if we have to configure it [17:22:29] awesome [17:28:51] so we have the 'standard notification' configured on test and live [17:29:44] oh fun, and the ingenico WX parser is still timing out [17:30:03] so the iDEAL donors who gave via the old gateway still haven't gotten TY mails either [17:30:13] OK, that one I think I know how to fix [17:30:29] we need to clear out a bunch of old audit files and re-run [17:32:14] ejegg: are these process control jobs? [17:32:19] yeah [17:35:06] ok fr-tech so with ideal we could test what messages we get back by submission a local adyen ideal donation while also running ngrok to listen for IPNs. I guess also even if we do get get IPN back to capture, are we supressing this or does it get through? I can't remember [17:35:15] yeah I just tested two [17:35:16] submitting [17:35:22] we are supressing [17:35:29] jgleeson we're ignoring the AUTH message [17:35:34] AUTHORISATION [17:35:40] is the only one i see coming back [17:35:42] and recording the donation on CAPTURE [17:35:45] oooh crap [17:35:56] so we need to change that [17:36:02] sorry, I thought we got both [17:36:32] instead of ignoring the AUTH when it's iDEAL, we need to treat the AUTH like it's a CAPTURE [17:36:50] ah [17:37:21] cstone: does the auth payload include the payment method? [17:37:25] yep! [17:37:32] awesome [17:38:00] yeah right now its ignoring the ipns with payment method = ideal [17:39:04] yep I can see that here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/2e59497980bb6cb0989ff69cc21e95a2a9949987/PaymentProviders/Adyen/Actions/PaymentCaptureAction.php#L30 [17:41:11] so I guess we wanna change the body of that conditional statement to generate a ProcessCaptureRequestJob ? [17:41:51] that doesn't feel right [17:42:24] well I guess thats what happens when things go to plan [17:42:29] no, it should generate a RecordCaptureJob [17:42:49] ahhh ok I wasn't sure on that [17:43:01] just need to change RecordCaptureJob's factory method to accept the parent message class (AdyenMessage) [17:43:18] and add a getGatewayTxnId method on AdyenMessage [17:43:43] that returns the pspReference for Auth and the originalReference for Capture [17:43:55] Lemme just get that up real fast [17:44:50] oh jgleeson, did you see I fixed the spacing around the colon for those return types? [17:45:13] I could do this fix from current master and rebase that stuff over it [17:45:38] yeah, probably best to just do this fix if we need to push it out quick [17:48:03] ok it feels like you have a better handle on the parts of the code that need tweaking to fix the issue so maybe once you've done that the rest of us could do a test with the IPN set up! [17:49:08] cool ejegg I hadn't caught that but I'll check my gerrit emails now and take a peak [17:51:37] heh, I've been leary of ngrok and feeling like I should be able to make my listener work via one of my VPSes [17:52:01] but haven't quite gotten that working [17:53:38] I think `vagrant share` used to wrap ngrok if I remember correctly but now they use something else [17:54:03] actually they still use it [17:55:19] that's fine there's a few of us with it set up but might be a good opportunity for others who haven't done much with the adyen IPN stuff to try it out fr-tech? [17:56:58] here are some pointers on using it with adyen IPN testing https://www.mediawiki.org/w/index.php?title=Fundraising_tech/Testing#Adyen [17:58:07] although I remember that there were things missing from that guide that I had planned to add in but now I've forgotten them, which is a bad habit I don't see to be able to shake [17:58:27] i added a couple of things to it jgleeson [17:58:46] ah thanks cstone! [18:06:06] (PS1) Ejegg: Adyen iDEAL: record payment on AUTH message [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593021 (https://phabricator.wikimedia.org/T251296) [18:06:44] I'm going to hold off actually renaming the classes till we get those php7 patches merged [18:07:22] e.g. RecordCaptureJob -> RecordPaymentJob [18:07:28] I'm a bit confused on the ideal issue, were the donations not getting to civi in production then? [18:07:42] cstone yeah, see https://phabricator.wikimedia.org/T251296 [18:08:18] I need to look around to see how widespread the errors on donor return were [18:08:42] and whether the stuff we just pushed up might fix them [18:08:59] (CR) Jgleeson: [C: +2] "Looks good!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/592109 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [18:09:06] thanks jgleeson ! [18:09:21] oh wait, that was the spacing one [18:09:24] (Merged) jenkins-bot: Use PSR-12 standard spacing for return types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/592109 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [18:09:29] yeah that was the base one [18:09:37] I'll move up through the others [18:09:48] or do you need a specific one first [18:09:59] OK, I can rebase the iDEAL fix after those [18:10:11] and do the renaming in an immediately-following patch [18:10:25] oh shoot, sorry [18:11:05] no worries, shouldn't be too complicated [18:11:21] I can remove the +2 [18:11:28] for now and then we can merge it later [18:11:34] nah, that one's really easy to rebase over [18:13:04] (PS2) Ejegg: Adyen iDEAL: record payment on AUTH message [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593021 (https://phabricator.wikimedia.org/T251296) [18:14:34] ok fr-tech, I think ^^^ should get us recording iDEAL donations on the AUTH message [18:14:59] without messing with how Adyen card IPNs are handled [18:16:03] ok cool so we wanna get that patch asap? [18:16:09] out* [18:16:10] yep yep [18:16:45] though we also need to fix whatever was giving that donor error messages [18:20:14] ahh, I should add a test for the iDEAL case [18:20:53] The code looks good. Would anyone else like to test out the donation and IPN kickback fr-tech? [18:21:10] i am testing now too [18:21:58] thanks cstone ! [18:23:08] I think we could do with testing a cc transactions also to confirm the Capture getGatewayTxnId behaves as expected for that flow [18:23:14] so I'll do that if that helps [18:25:55] Fundraising-Backlog: seeing English text on Dutch payments wiki AdyenGateway page - https://phabricator.wikimedia.org/T251315 (MNoorWMF) [18:25:57] ok so is the expected outcome: the first donation on the queue from Donation Interface and then the ipn creating a duplicate that's discarded? then when issues come where the first one is missed we still get it from the ipn? [18:29:37] I'm not sure on that [18:30:13] I wasn't expecting two donation messages tbh [18:31:04] actually I think you might be right but I'll take a look to remember myself [18:31:11] cstone yep, two donation messages is expected [18:31:17] i guess I'm still confused on that part cause weren't we ignoring the ipn cause we immediately insert it from donation interface? [18:31:18] ah okay [18:31:48] since we get the money even when the donor doesn't make it back to our site [18:32:03] we want to make sure we record it from the IPN as a backup [18:32:19] and they'll at least get a TY email as a confirmation [18:32:23] okay [18:33:29] jgleeson: I just tested a cc too looks good, i can do some recurrings too cause I have a bunch set up [18:33:37] ooh wait, we still want to check the success code for iDEAL [18:33:53] lemme fix that [18:37:25] nice cstone you are moving much faster than me! [18:38:00] Fundraising-Backlog: restart training fr-online peeps on editing payments wiki - https://phabricator.wikimedia.org/T250924 (jbolorinos-ctr) Hey @DStrine could you add me to this as well if it wouldn't be too much trouble? [18:39:44] (PS3) Ejegg: Adyen iDEAL: record payment on AUTH message [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593021 (https://phabricator.wikimedia.org/T251296) [18:40:12] hmm looks like I've lost my api config on my vagrant box [18:40:37] ok cstone jgleeson ^^^ has a test and should only send successful iDEAL auths to Civi [18:40:38] they must get reset during vagrant things [18:40:53] jgleeson do you have them in a puppet-managed file? [18:41:21] no I think I was adding them manually to /etc/smashpig/adyen/main.yaml [18:41:34] ahh, that might be puppet-managed [18:41:52] yeah I'm just gonna take a look at the smashpig puppet class [18:41:58] so.... the DonationInterface side of this doesn't actually use the smashpig settings for adyen credentials I think [18:42:16] that bit should still be in the non-puppet managed 20-DI-account.php or the like [18:42:19] in the settings.d [18:43:59] it's happening here https://github.com/wikimedia/mediawiki-vagrant/blob/a3be4b46c3ab65acfcd26451c57aaf88a66a26a5/puppet/modules/smashpig/manifests/init.pp#L40 [18:44:16] although I'm not sure why a vagrant provision is overwriting it everytime. I must not understand how that works [18:44:49] so bother I guess I can pull them from frpm [18:45:32] ejegg: do you mean I can reuse the api credentials from DI? [18:45:56] I guess I'm unsure on the yaml keys [18:46:55] oh this is the PART I was missing from the IPN guide [18:47:07] where to get the sandbox credentials! [18:47:24] as I don't think they existed on frpm at the time [18:56:38] cstone I think I saw both our capture IPNs come through [18:56:57] yeah mine should be for hopefully different amounts as yours [18:57:12] mine is the 11.00 and I think yours is the 12.23 [18:57:22] did you just refund yours also? [18:57:31] so sandbox is sending captures IPNs for ideal, not just auth IPNs? [18:57:38] that makes me feel a little better [18:57:52] we can blame Adyen's environment disparity [18:57:53] i was doing CC tests [18:58:02] oh ok [18:58:03] me too [18:58:33] i didnt refund the 12.23 [18:59:39] ah no that was an ideal payment [18:59:54] ideal [18:59:56] jgleeson and it got both AUTH and CAPTURE messages? [19:00:04] 1572253478.10 [19:00:10] 43 EUR [19:00:23] no only AUTH ejegg [19:00:24] ok, i'mma try setting up ngrok [19:00:34] ahh, right, so it IS like production [19:01:19] Fundraising-Backlog: Put a loading indicator after clicking CONTINUE on PaymentsWiki - https://phabricator.wikimedia.org/T237279 (scervantes) Thank you @DStrine . Do you recommend another approach? I understand the technical implications you mention, however to the end user this still might look broken/lagg... [19:01:30] sorry to spam the ipns jgleeson I was creating 2 new recurrings to mess with hah [19:01:59] all good [19:07:20] fr-tech I agree with cstone. working as expected for cc and ideal [19:07:34] I see the two donation messages for ideal [19:08:46] ok, great [19:09:10] just gonna pull down the updated patch [19:10:12] I'm seeing WD wmf_common: INVALID_MESSAGE Missing gateway when i run the smashpig recurring script locally but it processed the donations fine, looking if its a setting i changed [19:11:12] actually thats always been there for me nevermind [19:11:50] oh right, that reminds me of an issue that I think ejegg patched moving some logic from defineTrasaction into a transformer [19:13:20] cstone do you have the latest DonationInterface? [19:13:42] oh derp you were talking about smashpig recurring [19:14:05] wmf_common is civi right? [19:14:14] drupal [19:14:21] yeah i think it was just from bad data in my db [19:14:37] hah trying to test again and SOAP-ERROR: Parsing WSDL: Couldn't load from 'https://pal-test.adyen.com/pal/Payment.wsdl' : failed to load external entity "https://pal-test.adyen.com/pal/Payment.wsdl" [19:14:46] ahh, not sure if it's this setting but I should set the smashpig 'use queue' setting in vagrant [19:14:49] oh shoot [19:15:12] huh, that url loads fine for me [19:15:31] yeah it worked like a minute ago too [19:15:32] momentary blip maybe [19:18:16] ejegg: you were right I thought I had the queue on but must have turned it off again, that error is gone now [19:19:24] but yeah all tests look good from my end [19:22:31] cool wanna +2? [19:22:38] looks good to me also [19:23:20] looks like we have a meeting in 8 minutes so I'm gonna grab a snack and a drink, back soon! [19:24:16] (CR) Cstone: [C: +2] "Looks good, tests worked with iDEAL and cc." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593021 (https://phabricator.wikimedia.org/T251296) (owner: Ejegg) [19:24:38] (Merged) jenkins-bot: Adyen iDEAL: record payment on AUTH message [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593021 (https://phabricator.wikimedia.org/T251296) (owner: Ejegg) [19:24:45] (PS69) Mepps: Finer geo targeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [19:24:48] Fundraising-Backlog, FR-Adyen, Patch-For-Review: Recent settled Adyen iDEALs not reaching Civi - https://phabricator.wikimedia.org/T251296 (MBeat33) Thanks, @Ejegg - do you know what the 'real' status of these donations is? Should we refund three of them if one will settle into Civi? [19:31:37] thanks cstone [19:32:43] Fundraising-Backlog, FR-Adyen, Patch-For-Review: Recent settled Adyen iDEALs not reaching Civi - https://phabricator.wikimedia.org/T251296 (Ejegg) @MBeat33 if they're at 'settled' in the console, I'd consider that definitive and that we should refund all but one. I think they should eventually make... [20:02:56] (PS12) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [20:04:04] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi point version update - https://phabricator.wikimedia.org/T250226 (Eileenmcnaughton) Open→Resolved [20:09:13] Fundraising-Backlog, FR-Adyen, Patch-For-Review: Recent settled Adyen iDEALs not reaching Civi - https://phabricator.wikimedia.org/T251296 (MBeat33) Great, thank you. [20:11:46] (PS1) Ejegg: Add email explain translation in NL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593050 (https://phabricator.wikimedia.org/T251315) [20:12:02] Fundraising-Backlog: Create job to update/generate employer dataset for usage within paymentswiki - https://phabricator.wikimedia.org/T251201 (DStrine) [20:16:46] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 6 others: CRM contribution tracking writing should have a switch to use the new infrastruct... - https://phabricator.wikimedia.org/T215463 [20:18:40] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 6 others: CRM contribution tracking should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Ejegg) a:... [20:18:50] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 6 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Ejeg... [20:18:52] Fundraising Sprint I 2020, Fundraising-Backlog, Patch-For-Review: seeing English text on Dutch payments wiki AdyenGateway page - https://phabricator.wikimedia.org/T251315 (DStrine) [20:18:55] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Frontend - Make employer field autocomplete which integrates with new backend MW employer data API - https://phabricator.wikimedia.org/T251200 (DStrine) [20:18:57] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): switch NL credit card processing to adyen - https://phabricator.wikimedia.org/T251172 (DStrine) [20:19:00] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (DStrine) [20:19:02] Fundraising Sprint I 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import new donor list back into Civi - https://phabricator.wikimedia.org/T250755 (DStrine) [20:19:05] Fundraising Sprint I 2020, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Adyen/iDEAL message getting from DonationInterface to Civi missing payment_submethod - https://phabricator.wikimedia.org/T251025 (DStrine) [20:19:07] Fundraising Sprint I 2020, Fundraising-Backlog: Ingenico/Globalcollect SSL cert failures 04-23-2020 - https://phabricator.wikimedia.org/T250950 (DStrine) [20:19:09] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search adyen % + recurring=yes yields no results - https://phabricator.wikimedia.org/T250123 (DStrine) [20:19:11] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make Civi matching gifts extension store data in custom fields - https://phabricator.wikimedia.org/T249924 (DStrine) [20:19:13] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Recurring-Donations: PayPal recurring: cycle of authorization reversals? - https://phabricator.wikimedia.org/T249951 (DStrine) [20:19:16] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising Sprint Visual Basic Instinct, and 7 others: Address final code review comments on geotargeting - https://phabricator.wikimedia.org/T250751 (DStrine) [20:19:18] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, fundraising Sprint Grep works IRL: Fundraising engineer complete list of chores this week - https://phabricator.wikimedia.org/T249524 (DStrine) [20:19:21] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (DStrine) [20:19:23] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, fundraising Sprint Grep works IRL, Fr-planning-ahead: Planning ahead tasks for sprint H 2020 - https://phabricator.wikimedia.org/T249017 (DStrine) [20:19:25] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, and 3 others: Adyen sending back 'paymentMethod=ideal' in returnURL which is not being mapped - https://phabricator.wikimedia.org/T248712... [20:19:27] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, and 2 others: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (DStrine) [20:19:30] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, and 3 others: When a donor whose initial form was in language=NL cancels an iDEAL donation, t... - https://phabricator.wikimedia.org/T247885 [20:19:32] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Dedupe task inappropriately trying to delete contacts - https://phabricator.wikimedia.org/T247377 (DStrine) [20:19:34] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: system status warning on civi production - https://phabricator.wikimedia.org/T248900 (DStrine) [20:19:36] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, fundraising Sprint Grep works IRL: Review Banner Templating - https://phabricator.wikimedia.org/T246347 (DStrine) [20:19:38] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint Grep works IRL: Investigate how to generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (DStrine) [20:19:54] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, fundraising Sprint Grep works IRL: Capturing 'contauth' recurring transactions through Adyen - https://phabricator.wikimedia.org/T250106 (DStrine) [20:19:55] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, Gerrit, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (DStrine) [20:19:59] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint I 2020, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (DStrine) [20:20:01] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint I 2020, Fundraising-Backlog, and 4 others: Create script to migrate existing GlobalCollect recurring payments to Connect t... - https://phabricator.wikimedia.org/T169357 [20:40:18] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import new donor list back into Civi - https://phabricator.wikimedia.org/T250755 (LeanneS) @Eileenmcnaughton Great thank you! These two contacts look good to me. Glad the existing mapping works to use a... [20:44:22] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (Aklapper) Assuming this task is about the #Mediawiki-extensions-Centralnotice codenase, hence adding that project tag so other... [20:52:20] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1844 processes [20:57:20] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 228 processes [21:09:46] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Recurring-Donations: PayPal recurring: cycle of authorization reversals? - https://phabricator.wikimedia.org/T249951 (EMartin) From Paypal: Generally with recurring transactions... [21:23:27] Fundraising-Backlog, fundraising-tech-ops: adjust fr-log-announcer to use IRC more securely - https://phabricator.wikimedia.org/T122104 (Dwisehaupt) a:Dwisehaupt Took a look at this and think I have a decent small change to make it work over SSL enabled ports. This seemed a bit easier as freenode has... [21:27:15] fr-tech I'm going to deploy smashpig standalone [21:27:22] aka payments listener [21:27:34] no need to tag a new version just yet [21:28:47] (PS1) Ejegg: Remove mistakenly added test file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593065 [21:28:51] (CR) Ejegg: [C: +2] Remove mistakenly added test file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593065 (owner: Ejegg) [21:29:13] (Merged) jenkins-bot: Remove mistakenly added test file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/593065 (owner: Ejegg) [21:32:42] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/593067 [21:33:00] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/593067 (owner: Ejegg) [21:33:19] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/593067 (owner: Ejegg) [21:55:43] !log updated Payments IPN listener (Standalone SmashPig) from d80e4c5abd to 8c30ed7fe5 [21:55:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:57:46] fr-tech anyone want to give a quick +2 to the NL email explanation? https://gerrit.wikimedia.org/r/593050 [21:59:30] oh yeah I can [22:00:08] is a there a reason it wasnt showing up at all for me locally? compared to the screenshot in the task [22:02:07] hrm, does that still need variant=emailExplain? [22:02:17] or did we go ahead and make that default? [22:03:02] aah, it only appears when someone is opted out [22:04:19] ah okay [22:04:35] (PS1) Ejegg: Debug logging for Adyen resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593072 (https://phabricator.wikimedia.org/T251296) [22:04:58] fr-tech ^^^ is an attempt to get more info on the adyen bug [22:07:44] (CR) Cstone: [C: +2] Add email explain translation in NL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593050 (https://phabricator.wikimedia.org/T251315) (owner: Ejegg) [22:09:25] (Merged) jenkins-bot: Add email explain translation in NL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593050 (https://phabricator.wikimedia.org/T251315) (owner: Ejegg) [22:10:16] (PS2) Ejegg: Debug logging for Adyen resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593072 (https://phabricator.wikimedia.org/T251296) [22:32:05] (PS3) Ejegg: Debug logging for Adyen resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593072 (https://phabricator.wikimedia.org/T251296) [22:36:14] (CR) Cstone: [C: +2] Debug logging for Adyen resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593072 (https://phabricator.wikimedia.org/T251296) (owner: Ejegg) [22:51:41] (Merged) jenkins-bot: Debug logging for Adyen resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593072 (https://phabricator.wikimedia.org/T251296) (owner: Ejegg) [23:23:07] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/593082 [23:23:16] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/593082 (owner: Ejegg) [23:23:56] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/593082 (owner: Ejegg) [23:26:37] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/593083 [23:26:44] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/593083 (owner: Ejegg) [23:31:33] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/593083 (owner: Ejegg) [23:40:33] !log updated payments-wiki from 8c896a8247 to afb84cc391 [23:40:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:45:10] intial ts imports looking straight forward - just trying a few from drush nnow [23:56:28] eileen: oh, speaking of drush, it looks like 8.x is the version we want [23:56:36] it works with drupal 7 [23:56:37] cool [23:56:40] yep [23:56:41] and drush 7.x is EOL [23:56:59] i've got it installed via composer, now just need to try out our custom commands with it