[00:03:20] oops cstone just saw your question [00:03:27] so to merge to production [00:04:16] yeah, you should be able to git checkout origin/deployment -b deployment [00:04:36] the just git merge master [00:04:58] oh, before that you can run this command to generate a merge list for the commit message: [00:05:14] git log --oneline --no-merges --reverse deployment..master [00:05:38] hah thanks ejegg i overly freakout when deploying things so like normal non smashpigy deploy [00:07:20] it grabbed two other patches Update IListenerMessageAction::execute with return type [00:07:20] b991583 Update SmashPigDatabase and subclasses for php7 [00:07:20] I know they are smaller [00:13:02] hmm will also responded and said that the reference would be in all the responses if he adds it [00:21:22] hey ejegg cstone how's it going? I see some updates on tasks and an email to adyen [00:21:42] I want to recognize that it is late for you two [00:22:00] should we tell banners to hold? [00:22:25] hey dstrine there is a patch but it hasn't been deployed yet [00:24:06] cstone: ejegg how long do you think that will take? I don't want you to feel stuck working on this late [00:24:43] I am not 100% sure how to deploy it though dstrine [00:25:49] cstone: is anyone else online who can? [00:26:13] and/or can we survive the 1 hour test tomorrow and fix the transactions? [00:26:21] does this look like anything to the donor? [00:26:27] so the bug is that the donor experience is fine [00:26:37] but if any recurring donations happen they sit at the authorize step [00:27:13] cstone: do they get a thank you email? [00:27:19] oh they wouldnt get a thank you email [00:27:34] ok this might be enough to postpone things [00:27:50] cstone: is anyone else on who knows how to deploy? [00:29:04] cstone: is it just recurring? [00:29:29] ejegg was saying to deploy it in a way i havent done before so not sure on who knows how to deploy dstrine [00:29:33] its just recurring [00:30:16] ok If I don't hear anything from anyone else in 10 minutes I'll email fr-online with this info [00:43:32] ok I'm sending the email [00:49:52] thanks dstrine [00:50:55] thanks for looking at this cstone ! [01:02:08] Confirming we'll delay the test until we feel ready. Thanks for looking into this team! [01:03:55] thanks tskaff_ [01:05:15] Thank *you* Christine, hope you're logging off soon [01:05:41] haha I am its not too late here though :) [01:17:16] cstone do you want a walkthrough? [01:17:35] ah shoot, too late? [01:18:12] OK, looks like folks are holding off [01:18:20] well, I'mma |away for real then [02:40:03] (PS1) DannyS712: Remove use of WikiPage::doEditContent and the Revision object returned [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/594342 (https://phabricator.wikimedia.org/T250638) [02:44:17] (PS2) DannyS712: Remove use of WikiPage::doEditContent and the Revision object returned [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/594342 (https://phabricator.wikimedia.org/T250638) [02:47:28] (CR) jerkins-bot: [V: -1] Remove use of WikiPage::doEditContent and the Revision object returned [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/594342 (https://phabricator.wikimedia.org/T250638) (owner: DannyS712) [02:47:49] (PS3) DannyS712: Remove use of WikiPage::doEditContent and the Revision object returned [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/594342 (https://phabricator.wikimedia.org/T250638) [03:23:41] (CR) Eileen: [C: +2] "Yep - I think this is fine. I think it's more normal to do this somewhere on the server other than in the crm repo (buildkit does it's own" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/592986 (https://phabricator.wikimedia.org/T245562) (owner: Ejegg) [03:31:07] (Merged) jenkins-bot: Add drush 8 as a composer dependency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/592986 (https://phabricator.wikimedia.org/T245562) (owner: Ejegg) [03:33:17] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import new donor list back into Civi - https://phabricator.wikimedia.org/T250755 (Eileenmcnaughton) a:Eileenmcnaughton @leannnes this is done [12:39:42] Fundraising-Backlog, fundraising-tech-ops, Analytics, Patch-For-Review: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (ayounsi) [12:47:30] RECOVERY - check_swap on frdb1002 is OK: SWAP OK - 73% free (5542 MB out of 7629 MB) [14:55:48] fr-tech anyone want to take a quick look at this crm audit patch? [14:55:50] https://gerrit.wikimedia.org/r/594252 [14:55:58] sure ejegg! [14:56:03] thanks mepps! [14:57:58] ejegg the logic looks good, just curious is there any time data could have been blanked out? [14:59:15] also were the test files you added missing before? it looks like there's new test data files but no new tests [15:00:24] (CR) Mepps: "Two questions: is there any circumstance under which a value could go from populated to blank? Also, I see new files in the tests director" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/594252 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [15:00:47] i put those questions on the task--the code looks good though [15:01:43] mepps so we use that function to combine data from the audit file with data from the log file [15:02:15] and what's happening now is that we have a payment_submethod from the audit file [15:02:26] and payment_submethod='' from the log file [15:02:38] since the log file came second in the old array_merge() call [15:02:49] it was overwriting any key that existed in both [15:03:54] (CR) Ejegg: "We're currently getting a blank key payment_submethod from the log data overwriting the same key (populated) from the audit file. And the " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/594252 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [15:06:45] (PS1) Ejegg: Install drush 8.3.2 and dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/594499 [15:11:52] ok, I guess I should use vagrant to test those contribution tracking patches [15:16:32] sure ejegg i was just curious if there were any fields that could become blank later [15:17:56] mepps sorry, later like after that function is called? [15:18:15] well it's iterating over all the fields, right? not jut payment submethod [15:18:26] yep [15:19:07] if a field exists in one of the data sources but is blank in the other, I think we'll always prefer the source that exists, right? [15:19:43] okay i'm looking at the fields, that seems safe enough [15:19:59] (CR) Mepps: [C: +2] Audit parsing: Use non-blank values in merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/594252 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [15:22:06] hi fr-tech [15:22:18] hi cstone [15:24:40] hey ejegg i want to keep looking at contribution tracking too but i'm in local setup craziness :( [15:27:39] (Merged) jenkins-bot: Audit parsing: Use non-blank values in merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/594252 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [15:28:16] thanks for the CR mepps! [15:28:46] mepps I'm just starting to re-setup vagrant and I'm getting this on my first vagrant up: Could not find a directory environment named 'vagrant' anywhere in the path: /vagrant/puppet/environments. Does the directory exist? [15:28:51] have you seen that one? [15:29:18] ejegg i saw that recently and i just ran vagrant destroy and then vagrant up again and it went away [15:29:24] re-running vagrant up just keeps crashing on that error. [15:29:28] hmm, maybe I'll try again [15:29:31] i'll be curious if your civi works correctly! [15:29:40] i might have also restarted my computer [15:31:45] ejegg on me trying to deploy last night, there are 2 more patches that are before mine that hadn't been deployed, would that still be okay to do the non composer way? [15:32:00] ok, this time I also set nfs_shares to no before vagrant up [15:32:06] and it seems to be getting further [15:32:10] cstone yeah, totally [15:32:20] those should be no-op code cleanups [15:32:47] so the merge to deployment is just like the merge to deployment you'd do in crm or in donationinterface [15:33:06] and then just a plain vanilla fundraising_code_update -p SmashPig [15:33:18] and rsync_blaster ALL:SmashPig [15:33:36] hah okay somehow i missed that smashpig had a easier way of updating [15:34:10] so the easier way is just for the standalone install of SmashPig used for the IPN listener [15:34:39] SmashPig-as-a-library under another project will always need a point upgrade via packagist [15:35:03] that makes sense [15:39:32] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/594509 [15:42:51] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/594509 (owner: Cstone) [15:43:12] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/594509 (owner: Cstone) [15:44:23] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/594512 [15:46:40] (PS2) Ejegg: Install drush 8.3.2 and dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/594499 [15:46:48] (CR) Ejegg: [V: +2 C: +2] Install drush 8.3.2 and dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/594499 (owner: Ejegg) [15:47:21] !log SmashPig revision changed from 8c30ed7fe5 to cd1a49da5f [15:47:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:47:38] ejegg how's it going with vagrant? [15:47:40] haha my 3 letter key was ass [15:47:51] ha cstone! [15:47:59] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/594512 [15:48:03] meps so far so good! [15:48:14] right now it's cloning mediawiki core [15:48:25] gotcha ejegg, provisioning took a while for me yesterday [15:48:36] i'm really curious about these js issues in civi [15:48:44] yep yep, lots to pull down [15:48:50] since i'm having them on a fresh install [15:48:56] but it's driving me a little nuts [15:49:30] also i made a test donation on paymentswiki that hasn't found it's way to civi yet [15:49:38] i thoguht that was automated in vagrant in the past? [15:52:21] I think it should be mepps. As far as I know the queue consumers are set to run every few minutes by default. Maybe check to see if it's still on your queue? [15:54:29] i think you still have to manually run the donations one? or i turned that setting off and forgot [15:55:23] I have a vauge memory of that consumer trying to run and messing up some of my debug sessions, but that was a while ago. I might be wrong or it might be different now. [15:55:29] Running manually would certainly work. [15:56:22] i do see my donation in the queue... [15:56:40] Ok, probably cstone is right then and you have to run the consumer manually. [15:57:38] The 'last steps' section here has the command: https://www.mediawiki.org/wiki/Fundraising_tech/Queue_testing [15:57:42] hmm igot multipe errors of: RuntimeException@/vagrant/srv/SmashPig/Core/QueueConsumers/JobQueueConsumer.php:64 (Job message needs either 'php-message-class' or 'class' and 'payload') [15:57:55] I always have to look it up. [15:59:46] longest 5 minute wait ever but got the capture ipn message on a recurring wooo [16:00:22] great cstone [16:00:57] so what's the plan for dealing with the ones for non-initial recurring? [16:01:36] as of now they go into the damaged queue for having missing pending db data, right? [16:01:51] we want to be able to discard them more cleanly [16:02:21] yeah i havent looked at the capture ipn message fully there might be something on there we can use [16:02:22] mepps wierd, sounds like an array that's not actually a job [16:02:30] what queue were you pulling from? [16:02:36] donations ejegg [16:02:40] and can you examine the messages with redis-cli? [16:03:28] hmm, would be nice to have a queue peek script in SmashPig, no? [16:03:48] looks like it's not in redis-cli anymore ejegg but i'm looking in the smashpig db [16:03:49] just show the first message on a queue without popping it off the stack [16:04:04] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, FR-Adyen: IL Adyen test donation questions - https://phabricator.wikimedia.org/T251822 (Cstone) @MBeat33 @TSkaff I just deployed a fix and tested - new adyen recurrings are getting to civi now [16:04:08] i use lindex for that [16:04:13] that shouldn't pop it off, right? [16:04:32] sounds like the right thing to do [16:05:08] just thinking it might be easier to have a script that just took the queue name and figured the rest out for you [16:05:12] maybe even pretty-print it [16:05:51] that'd be fun ejegg! [16:06:19] maybe we can write it during tech talk [16:07:09] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/594512 (owner: Ejegg) [16:07:15] fr-tech, jumping off for lunch, ejegg i'll be curious to hear how your vagrant works after it's provisioned! [16:07:25] bon apetit [16:08:18] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/594512 (owner: Ejegg) [16:11:58] howdy fr-tech :) [16:12:51] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (DStrine) [16:12:55] Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (DStrine) [16:13:55] hi jgleeson ! [16:18:40] hey fr-tech :) [16:18:52] Hey there jgleeson, AndyRussG [16:19:16] hi AndyRussG [16:19:23] and hi jgleeson and XenoRyet [16:20:13] :) [16:21:39] Fundraising-Backlog: Investigate creating non iframe variants for ingenico, adyen and dlocal - https://phabricator.wikimedia.org/T251916 (DStrine) [16:24:08] :) [16:24:13] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, FR-Adyen: IL Adyen test donation questions - https://phabricator.wikimedia.org/T251822 (MBeat33) Many thanks, @Cstone [16:27:51] jgleeson: I'm looking at your change to the gruntfile and I can't seem to make it run 'fix' [16:28:09] should it just be grunt eslint --fix [16:28:20] or is there a different way to pass options to a subcommand? [16:38:10] jgleeson: oh derp, I didn't actually have your patch applied [16:38:24] umm, but it looks like with your patch, grunt eslint ALWAYS changes the files [16:38:38] and I think we don't want our automated tests fixing things in CI [16:38:53] that is, I just ran grunt eslint and it changed things [16:39:35] maybe we could define a new grunt task for that? [16:39:41] sorry ejegg just catching up. Been suffering with toothache [16:39:49] ah man, sounds miserable :( [16:40:18] so ignore all but the last 5 lines [16:40:21] yea it calmed down yesterday but its back in full force today [16:41:11] ejegg: my understanding was that fix:true just allowed the flag to be passed and doesn't fix on each run [16:41:36] I might have misunderstood that [16:42:23] Fundraising-Backlog, fundraising-tech-ops, Analytics, Patch-For-Review: Install superset on front end server for analytics - https://phabricator.wikimedia.org/T245755 (Jgreen) Open→Resolved This is done. [16:42:27] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) [16:42:59] jgleeson When I tried it just now without any flag, it did change the files [16:43:26] oh shoot that's not good [16:43:40] anyway, looks like we weren't linting all the files we should have been. Will put up another patch to add those in (with their autofixes!) [16:44:04] hey jgleeson [16:44:34] do you have your local vagrant set up to automatically run the queue runner or do you it manually? [16:44:40] lemme see if I can work out how we just add support for `--fix`. I'm pretty sure it didn't work first time round which lead me to add to the options [16:44:43] hey mepps [16:45:07] mepps: I manually run the queue consumer via the drush command [16:45:16] Fundraising-Backlog, fundraising-tech-ops: Set up database dumps and archiving for fundraising analytics mariadb server. - https://phabricator.wikimedia.org/T251921 (Jgreen) [16:45:29] with a whole load of -vvvvvv for good measure [16:48:27] it looks like this is where the documentation is: https://www.mediawiki.org/wiki/Fundraising_tech/Queue_testing :) [16:48:31] thanks to all who added to that! [16:50:14] well my donation got to civi--yay! [16:50:23] now i can try without sequential ct_ids :) [16:51:38] (PS1) Ejegg: Lint accidentally-skipped JS files [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594523 [17:04:06] folks I'm gonna have to head out and pick up some stronger pain meds, back shorty! [17:16:46] mepps good news! My vagrant Civi instance is broken in exactly the same way yours is [17:17:05] The resource from “http://crm.local.wmftest.net:8080//vagrant/srv/org.wikimedia…crm/civicrm/packages/jquery/plugins/jquery.mousewheel.min.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff). [17:17:20] so yeah, that path is bad [17:19:33] Yay ejegg! I’m not crazy [17:20:51] Yeah what’s weird is the resource url is set [17:21:07] I dug into the code at one point [17:30:38] ejegg is it obvious to you what's happening? [17:33:32] Fundraising-Backlog: Investigate creating non iframe variants for ingenico, adyen and dlocal - https://phabricator.wikimedia.org/T251916 (Ejegg) D*Local is already full redirect. The Ingenico redirect variant exists but seems to be broken - I end up on donate-wiki after clicking a card type button https://p... [17:33:42] mepps nope, I figured probably a resource path [17:33:56] So I was going to compare with my non-vagrant civi installs [17:34:02] and got sidetracked bringing those up to date [17:34:13] just about have them working againt [17:34:16] *again [17:34:55] it sounds like that bug is worthy of a ticket [17:35:09] maybe one for the vagrant chores list [17:38:59] okay cool ejegg, i was also going to chat with eileen about it later today [17:39:22] sure jgleeson i'll make a ticket [17:40:11] Fundraising-Backlog: CiviCRM js broken after upgrade to 5.25 on vagrant - https://phabricator.wikimedia.org/T251934 (mepps) [17:40:34] dstrine see the ticket above--i'm going to have to resolve before i make much progress on other things [17:41:15] ok I'll add it to the sprint mepps [17:41:27] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog: CiviCRM js broken after upgrade to 5.25 on vagrant - https://phabricator.wikimedia.org/T251934 (DStrine) [17:57:16] curiously, some of the script tags have good values [17:57:45] mepps if you look at all the script tags under the can you see a pattern in which ones have bad paths? [17:58:26] looks like anything under bower_components is mis-loaded for example [17:58:35] maybe it's specifically shoreditch? [17:58:51] ugh, is it loading multiple copies of jquery? [17:59:04] ah yeah, one is from drupal [17:59:15] ejegg: you're right it is fixing the code each time which I guess we don't want. Passing the --fix flag doesnt have any effect which isn't helpful either [17:59:31] jgleeson I think we would need to define a separate grunt task [17:59:33] ejegg shoreditch has been an issue for me but i see mostly jquery/outside libraries being the issue [17:59:58] the problem persists even if shoreditch is disabled [18:00:00] mepps ok, my new thought was that drupal's scripts are loading right but civi's aren't [18:00:11] some of civi's scripts are loading ejegg [18:00:32] like crm.menubar.js [18:00:37] hmm, css has the same bad paths [18:01:08] all the node modules, bower components and plugins are looking for this bad path [18:02:44] okay i'm remembering when i looked into this before i tracked these urls to the Civi class [18:02:49] i'm looking to see what's changed there recently [18:03:14] it's not the old CRM_Core_Resources, is it? [18:04:06] new one seems to be Civi\Core\Paths [18:04:44] oho [18:05:10] yah, that one seems to have gotten some 'absolute' options added [18:05:25] which seems wrong [18:05:36] let's see why that was added upstream [18:05:41] ahh ejegg [18:06:26] ejegg https://github.com/civicrm/civicrm-core/commit/d0cda11f761d4babb3fc515517dbbc0a80743338 [18:10:19] hmm deleting the absolutes isn't fixing this for me [18:10:28] (after clearing caches) [18:10:42] ah, dang, was just clearing my caches in the hopes that would do it [18:10:56] everything in vagrant is super slow for me [18:11:58] ok, yeah, for me it's still trying the same paths [18:12:15] ditto ejegg [18:12:16] so can we add those computed paths to our settings file? [18:13:19] oh, or at least [civicrm.root] [18:15:27] it looks like we have that set ejegg [18:16:07] in civicrm.settings.php: https://github.com/civicrm/civicrm-core/commit/d0cda11f761d4babb3fc515517dbbc0a80743338 [18:22:48] oops [18:22:51] i pasted the wrong thing [18:25:18] what a puzzle... [18:25:27] gonna eat some lunch [18:39:58] Fundraising-Backlog, fundraising-tech-ops: puppet framework for Advancement Analytics staff and server roles - https://phabricator.wikimedia.org/T244859 (Jgreen) a:Jgreen [18:47:50] ooh ejegg i think i might be getting closer [18:51:02] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Epic: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (CCogdill_WMF) Checked in with David and Dylan today and bumped Mariana's question abov... [19:05:03] ok looks like I'll have to go the new grunt task route ejegg|food like you suggested. I came across https://gruntjs.com/api/grunt.option and thought it would help but no joy with that either. [19:27:17] mepps what did you find? [19:28:08] ejegg i didn't fix it, i found that currently the 'relative' flag is actually doing nothing for us but it wouldn't work correctly even if it was [19:28:32] ok [19:28:44] there's a mismatch between the $_SERVER['host] value and $paths['host'] [19:28:47] but it's not cauisng this [19:28:55] so the broken ones are the ones going through the new Civi\Core\Paths, right? [19:29:05] yes [19:29:47] i tried rolling back to a version of that file a few commits ago but it didn't fix it [19:31:54] XenoRyet i ran vagrant up and now i'm back to no battery life [19:32:19] Of course [19:40:25] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search adyen % + recurring=yes yields no results - https://phabricator.wikimedia.org/T250123 (Cstone) Open→Resolved [19:43:15] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (DStrine) [19:46:28] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, FR-Adyen: Disregard Adyen recurring authorization IPNs - https://phabricator.wikimedia.org/T243334 (Cstone) Resolved→Open [19:49:29] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Ice cream cures everything, and 2 others: Disregard Adyen recurring authorization IPNs - https://phabricator.wikimedia.org/T243334 (DStrine) [19:52:07] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.31; 2020-05-05): seeing English text on Dutch payments wiki AdyenGateway page - https://phabricator.wikimedia.org/T251315 (Ejegg) Open→Resolved a:Ejegg [19:53:11] (PS27) Jgleeson: Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [19:56:33] (CR) jerkins-bot: [V: -1] Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [20:20:15] Wikimedia-Fundraising-Banners: Changed amount tracking not working correctly with Other field? - https://phabricator.wikimedia.org/T211333 (EWilfong_WMF) Confirming that this is still an issue. I do not have a proposed solution yet, but wanted to note that I can recreate it. [20:59:00] (CR) Jgleeson: [C: +1] "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [21:29:15] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, and 3 others: When a donor whose initial form was in language=NL cancels ... - https://phabricator.wikimedia.org/T247885 [21:31:38] mepps yeah, vagrant / vbox is a huge power drain [21:38:53] mepps do you have xdebug working under vagrant? [21:39:47] I used to but don’t anymore, I was working on that but I’m with the kids now [21:39:56] ok, have fun! [21:48:53] sorry I missed the check in - I just had to get a bit more sleep in as I've got a bit of a deficit [21:50:44] (PS11) Ejegg: Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 (owner: ItSpiderman) [21:54:23] (CR) jerkins-bot: [V: -1] Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 (owner: ItSpiderman) [23:17:37] Fundraising-Backlog, FR-Civi-Dedupe: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (MBeat33)