[00:28:31] (CR) DannyS712: [C: -1] Remove use of WikiPage::doEditContent and the Revision object returned [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/594342 (https://phabricator.wikimedia.org/T250638) (owner: DannyS712) [02:22:34] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Nuria) @Jgreen can probably speak of engineering efforts of #1 and #2 Some links: https://wikitech.wikimedia.org/wiki/Analytics/Systems/Kerber... [12:30:08] Fundraising-Backlog, fundraising-tech-ops: Allow tunnelling for frdb1003 / fran1001 - https://phabricator.wikimedia.org/T252196 (EYener) [13:23:22] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Jgreen) >>! In T252049#6118123, @Nuria wrote: > @Jgreen can probably speak of engineering efforts of #1 and #2 #1 For now the fundraising super... [14:31:36] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Nuria) Also, I would encourage the FR team to explore making non PCI data available in the analytics environment. That data can have restricte... [14:32:00] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Nuria) @Jgreen sounds good, let us know of your findings. [14:40:11] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) [14:41:48] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Jgreen) >>! In T252049#6118864, @Nuria wrote: > Also, I would encourage the FR team to explore making non PCI data available in the analytics... [15:01:56] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Nuria) @Jgreen yes, it is a project we will do with main SRE team next year but 2FA will not substitute kerberos, it's an add on to the ldap bas... [15:33:53] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Jdlrobson) Ideally this would be in one of the fundraising extensions to give fundraising tech the ability to turn this on o... [15:42:40] hi fr-tech! [15:45:25] hey ejegg :) [15:51:17] (CR) Jgleeson: [C: +2] Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [15:51:46] (Merged) jenkins-bot: Add more type hints, slight other cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584067 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [15:51:48] (CR) Jgleeson: [C: +2] Return and argument types for config & context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584730 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [15:51:50] (Merged) jenkins-bot: Add argument and return types to queue classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584719 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [15:52:09] (Merged) jenkins-bot: Return and argument types for config & context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/584730 (https://phabricator.wikimedia.org/T243421) (owner: Ejegg) [15:59:04] (CR) Jgleeson: [C: +2] "Working as expected for me, nice work! :)" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/594775 (owner: Cstone) [15:59:26] (Merged) jenkins-bot: Maintenance script to show the top message on the queue. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/594775 (owner: Cstone) [16:00:04] holy shit ejegg I never even made that connection with the whitelist naming convention [16:06:57] (CR) Jgleeson: [C: +2] "Nothing breaks when testing a donation with this patch!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/585277 (owner: Ejegg) [16:07:44] (CR) Jgleeson: [C: +2] Schema changes related to BannerTemplates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 (owner: ItSpiderman) [16:08:19] (CR) Jgleeson: [C: +1] "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [16:08:56] (Merged) jenkins-bot: Update terminology: allow list / deny list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/585277 (owner: Ejegg) [16:09:26] thanks for all the code review jgleeson ! [16:10:04] (CR) Jgleeson: [C: +2] "Good spot. We've also got a working eslint --fix task config here https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterfac" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594523 (owner: Ejegg) [16:10:29] oh cool, I'll take a look at that --fix patch in a second [16:10:56] (Merged) jenkins-bot: Schema changes related to BannerTemplates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 (owner: ItSpiderman) [16:11:40] (Merged) jenkins-bot: Lint accidentally-skipped JS files [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594523 (owner: Ejegg) [16:12:33] (CR) Jgleeson: [C: +2] "always happy to have more tests!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/594233 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [16:12:55] (Merged) jenkins-bot: Adyen iDEAL audit parse test [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/594233 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [16:17:26] (CR) Jgleeson: [C: +2] Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [16:17:35] (CR) Jgleeson: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 (owner: ItSpiderman) [16:21:06] (Merged) jenkins-bot: Banner templates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/572672 (owner: ItSpiderman) [16:24:14] (CR) Jgleeson: [C: +2] Test to examine log & queue msg for RTBT [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594213 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [16:25:45] (CR) Jgleeson: [C: +2] Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 (owner: ItSpiderman) [16:26:11] (Merged) jenkins-bot: Test to examine log & queue msg for RTBT [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594213 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [16:29:01] (Merged) jenkins-bot: Rename methods to avoid confusion [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/576648 (owner: ItSpiderman) [16:29:32] Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice, Performance-Team: CentralNotice banners shouldn't be served to bots - https://phabricator.wikimedia.org/T252200 (AndyRussG) [16:40:54] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (DStrine) Thanks all for the info. This is just an investigation and I appreciate all the work to understand the effort involved in this. I wan... [16:42:14] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Jgreen) Related tasks/projects on authentication to keep in mind as we explore options here: T251890 and T233921. [16:42:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing information on the Engage Receipt - https://phabricator.wikimedia.org/T249771 (DStrine) Open→Declined [17:49:28] fundraising-tech-ops: update risky_package_updater to use systemctl for restarting services instead of the system V service command - https://phabricator.wikimedia.org/T251183 (Dwisehaupt) Open→Resolved a:Dwisehaupt This did the trick. Tested just fine. [19:16:55] (PS1) Dwisehaupt: Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104) [19:17:09] (CR) jerkins-bot: [V: -1] Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104) (owner: Dwisehaupt) [20:08:54] (CR) Reedy: Schema changes related to BannerTemplates (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/573520 (owner: ItSpiderman) [20:10:17] (PS2) Dwisehaupt: Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104) [20:10:31] (CR) jerkins-bot: [V: -1] Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104) (owner: Dwisehaupt) [20:20:14] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (jgleeson) **To test this... [20:22:19] (PS7) Jgleeson: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) [20:22:21] (PS3) Jgleeson: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) [20:24:23] ooh, un-WIP-ed! [20:24:36] (PS3) Dwisehaupt: Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104) [20:27:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, QuickSurveys, Readers-Web-Backlog, and 4 others: Consolidate QuickSurveys into CentralNotice - https://phabricator.wikimedia.org/T217374 (Krinkle) [20:29:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, QuickSurveys, Epic, and 2 others: [EPIC] Integrate QuickSurveys and CentralNotice - https://phabricator.wikimedia.org/T125125 (AndyRussG) [20:35:18] have a good weekend fr-tech, see you all tuesday! [20:35:33] Fundraising-Backlog: Need clarification on Amount fields in Acoustic - https://phabricator.wikimedia.org/T252245 (KHaggard) [20:41:34] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [20:47:04] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (DStrine) I'm a little behind on this topic. Has this already been tested? CentralNotice could help A/B this but there could... [20:55:46] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [21:04:23] Fundraising-Backlog, FR-Adyen: Turn on monthly convert for Adyen - https://phabricator.wikimedia.org/T252248 (DStrine) [21:36:47] (PS4) Dwisehaupt: Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104) [22:59:33] (PS5) Dwisehaupt: Changes for slander to work with python2 or python3 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/595217 (https://phabricator.wikimedia.org/T122104)