[15:32:47] (PS5) Ejegg: Add 'fix' option to eslint options to allow the `--fix` flag to be passed when running `grunt eslint` [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593796 (owner: Jgleeson) [15:33:04] (CR) Ejegg: [C: +2] "It works! That's handy." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593796 (owner: Jgleeson) [15:48:24] (Merged) jenkins-bot: Add 'fix' option to eslint options to allow the `--fix` flag to be passed when running `grunt eslint` [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593796 (owner: Jgleeson) [16:38:40] (PS1) Ejegg: Maintenance script to initialize sequence [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/595585 (https://phabricator.wikimedia.org/T215463) [16:47:41] (PS2) Ejegg: Maintenance script to initialize sequence [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/595585 (https://phabricator.wikimedia.org/T215463) [16:48:13] git log [16:48:16] derp [16:58:50] Fundraising-Backlog, fundraising-tech-ops: figure out Buster package for python3-mysql.connector for use with fruec - https://phabricator.wikimedia.org/T246823 (AndyRussG) [16:58:52] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [17:48:28] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12): Adyen/iDEAL message getting from DonationInterface to Civi missing payment_submethod - https://phabricator.wikimedia.org/T251025 (mepps) All the p... [17:49:32] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog: CiviCRM js broken after upgrade to 5.25 on vagrant - https://phabricator.wikimedia.org/T251934 (mepps) If anyone comes across this in the next few weeks, you'll need to pull down the patch and reprovision or change the value of $civicrm_... [17:49:40] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog: CiviCRM js broken after upgrade to 5.25 on vagrant - https://phabricator.wikimedia.org/T251934 (mepps) Open→Resolved a:mepps [18:10:34] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12): Adyen/iDEAL message getting from DonationInterface to Civi missing payment_submethod - https://phabricator.wikimedia.org/T251025 (Ejegg) The last... [18:15:21] mepps OK, I guess we want to refactor the tests a bit so that they all let us set up a contribution tracking record before we process any messages that are part of the setup [18:15:40] And I guess that refactor could be a preliminary patch [18:15:52] ejegg, hmm do we just want to change the tests or do you think tehy're catching a real bug? [18:16:09] In this case the tests look a bit wrong [18:16:18] those RecurringQueueTests [18:16:34] are importing a message and then trying to add contribution tracking roes [18:16:37] *rows [18:16:41] as part of the test setup [18:17:14] when in the normal course of business we add the contribution tracking rows before the message import [18:18:06] that makes sense ejegg but when it comes to update through the queue wrapper, that looked like the syncronicity issue could cause problems outside the test environment [18:20:20] we should definitley make sure the test environment mimics how it actually works though [18:23:14] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12): Adyen/iDEAL message getting from DonationInterface to Civi missing payment_submethod - https://phabricator.wikimedia.org/T251025 (mepps) Cool @Eje... [18:25:37] i'm going to make myself some tea [18:34:18] (PS1) Ejegg: Fix loading of CiviMail test base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595607 [19:22:29] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [19:26:47] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [19:27:35] (CR) AndyRussG: "Cool! Thanks for doing this!!!" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [19:59:54] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, and 4 others: Test migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (E... [20:01:54] fundraising-tech-ops: refactor drush install - https://phabricator.wikimedia.org/T240499 (Jgreen) drush wrapper script has been adjusted to point to /srv/org.wikimedia.civicrm/vendor/drush/drush/drush [20:07:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dash security in package - https://phabricator.wikimedia.org/T252309 (DStrine) [20:09:28] Fundraising-Backlog, FR-Adyen: Turn on monthly convert for Adyen - https://phabricator.wikimedia.org/T252248 (DStrine) [20:09:58] dwisehaupt: that drush change didn't work? [20:10:48] eileen: sorry, which drush change? that's popped off my memory stack. :) [20:12:39] the one jeff made on the call [20:12:44] see failmail... [20:13:00] oh. odd. checking. [20:19:50] ah, drush didn't get deployed with +x ... [20:27:52] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, fundraising Sprint Grep works IRL: Capturing 'contauth' recurring transactions through Adyen - https://phabricator.wikimedia.org/T250106 (Cstone) Confirming this is fixed, recurri... [20:30:10] eileen / ejegg: Ok, I think I got the relevant permissions fixed for drush/drush/drush* [20:45:52] Jeff_Green: so the wrapper is just switched over to drush 8 for everything? [20:46:26] for anything that uses /usr/local/bin/drush yes [20:47:16] looks like all the p-c jobs use /usr/local/bin/drush too [20:49:13] hey ejegg i'm around whenever you're ready to chat [20:50:00] i'll probably go do kid time in about 30 minutes [20:50:20] ok, I'm back in the fr tech / ops coordination [20:50:30] mepps [20:52:35] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, fundraising Sprint Grep works IRL: Capturing 'contauth' recurring transactions through Adyen - https://phabricator.wikimedia.org/T250106 (EMartin) Awesome! I was just looking at... [21:14:29] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [21:37:09] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [21:42:09] RECOVERY - check_log_messages on frav1002 is OK: OK [22:12:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 6 [=1] [22:17:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 6 [=1] [22:22:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 6 [=1] [22:27:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 3 [=1] [22:32:12] RECOVERY - check_log_messages on frav1002 is OK: OK [23:09:03] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import new donor list back into Civi - https://phabricator.wikimedia.org/T250755 (LeanneS) Thanks @Eileenmcnaughton! I did a spot check and they looked good. [23:13:09] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import new donor list back into Civi - https://phabricator.wikimedia.org/T250755 (Eileenmcnaughton) Open→Resolved [23:13:17] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import new donor list back into Civi - https://phabricator.wikimedia.org/T250755 (Eileenmcnaughton) [23:13:59] (CR) Eileen: [C: +2] Fix loading of CiviMail test base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595607 (owner: Ejegg) [23:20:58] (Merged) jenkins-bot: Fix loading of CiviMail test base class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595607 (owner: Ejegg) [23:44:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dash security in package - https://phabricator.wikimedia.org/T252309 (Ejegg) Open→Invalid I looked at it, and we don't actually install csv-parse - it's just a devDependency of one of the things we do have installed. We've seen a few false alarm...