[00:07:52] ejegg: was that the word-war of the bots? [00:20:25] (PS1) Reedy: Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252472) [00:20:52] (PS1) Reedy: Convert to manifest_version 2 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/595726 (https://phabricator.wikimedia.org/T252472) [00:21:11] (PS1) Reedy: Convert to manifest_version 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595729 (https://phabricator.wikimedia.org/T252472) [00:23:33] (CR) jerkins-bot: [V: -1] Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252472) (owner: Reedy) [00:29:36] (PS9) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [00:31:59] (PS10) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [00:33:55] (PS2) Reedy: Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) [00:34:37] (PS2) Reedy: Convert to manifest_version 2 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/595726 (https://phabricator.wikimedia.org/T252470) [00:35:12] (PS2) Reedy: Convert to manifest_version 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595729 (https://phabricator.wikimedia.org/T252470) [00:36:30] (CR) jerkins-bot: [V: -1] Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:38:44] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [00:49:03] (CR) Jforrester: [C: +2] Convert to manifest_version 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595729 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:49:15] (CR) Jforrester: [C: +2] Convert to manifest_version 2 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/595726 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:52:40] (PS1) Reedy: Convert to manifest_version 2 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/595742 (https://phabricator.wikimedia.org/T252470) [00:53:32] (CR) Jforrester: [C: -1] Convert to manifest_version 2 (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:53:34] (PS1) Reedy: Convert to manifest_version 2 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/595752 (https://phabricator.wikimedia.org/T252470) [00:56:28] (CR) jerkins-bot: [V: -1] Convert to manifest_version 2 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/595742 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:56:47] (CR) Reedy: "Yeah, these are just the output of running updateExtensionJsonSchema.php, extra work for some % was always likely :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:57:44] (Merged) jenkins-bot: Convert to manifest_version 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595729 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [00:59:03] (Merged) jenkins-bot: Convert to manifest_version 2 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/595726 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [01:12:08] (PS11) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [01:19:11] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [01:22:02] (PS3) Jforrester: Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [01:23:38] (CR) Jforrester: [C: +2] Convert to manifest_version 2 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/595752 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [01:25:53] (CR) Jforrester: [C: +2] Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [01:30:56] (PS2) Jforrester: Convert to manifest_version 2 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/595742 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [01:38:47] (Merged) jenkins-bot: Convert to manifest_version 2 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/595752 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [01:39:24] (Merged) jenkins-bot: Convert to manifest_version 2 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/595721 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [02:34:49] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Eje... [02:38:16] (PS12) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [02:41:38] (PS1) Ejegg: Fix a couple of issues installing and testing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595799 [02:44:42] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [02:47:12] (CR) Eileen: [C: +2] Fix a couple of issues installing and testing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595799 (owner: Ejegg) [02:53:30] (Merged) jenkins-bot: Fix a couple of issues installing and testing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595799 (owner: Ejegg) [07:24:53] Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): CentralNotice banners shouldn't be served to bots - https://phabricator.wikimedia.org/T252200 (Gilles) [15:10:31] (PS13) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [15:16:54] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [15:29:46] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [15:38:34] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [15:40:58] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (mepps) @jgleeson thanks... [15:53:45] (CR) Mepps: "Yay the api explorer works!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [15:54:40] (CR) Mepps: "as does the api call!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [15:57:50] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (mepps) I went ahead and... [16:18:31] (CR) Jforrester: [C: +2] Convert to manifest_version 2 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/595742 (https://phabricator.wikimedia.org/T252470) (owner: Reedy) [16:19:48] (PS14) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [16:27:47] (PS1) Ejegg: Exclude another vendor dir from linting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595978 [16:29:44] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [16:30:37] (PS15) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [16:32:44] tzag fr-tech! [16:33:09] hi jgleeson [16:34:49] :) [16:34:54] jgleeson: cstone: :) [16:35:04] :):) [16:49:08] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [16:58:57] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 7 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Eje... [16:59:28] hi jgleeson|dinner ! [17:14:38] hi ejegg :) [17:18:36] cstone: were all those 'could not find donor details' damaged messages from this morning Adyen recurrings? [17:20:04] ejegg: are those failmail or somewhere else? [17:21:12] ooh i see now [17:21:13] hmm [17:21:44] it looks like it I see the successful one i checked yesterday there too [17:21:56] are they from the double IPNs? [17:24:49] Fundraising-Backlog: export db table descriptions for... everything :P - https://phabricator.wikimedia.org/T252570 (DStrine) [17:27:32] yeah looks like it hmm [17:29:22] do those IPNs have any info we can use to distinguish them from the one-time IPNs? [17:33:42] yeah since adyen turned on the extra info on live the old patch could be applied again, im working on testing it locally now [17:49:35] (PS11) Cstone: Drush script to tokenize old recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [17:50:55] hey mepps thanks for reminded me about caching them employers data. It looks like we missed that part off the tech-talk idea that I was working from but now looking at the code I think it would benefit from some type of in-memory cache. [17:50:56] (PS1) Reedy: Remove _merge_strategy from value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595997 [17:53:27] we did chat about redis as an alternative to the csv but I guess we could also use them together to compliment each other. I'm gonna look at how that'll work [17:54:19] yeah jgleeson i'm just wondering about having to read the csv each time someone makes a request [17:54:45] yeah that's definitely gonna be much slower than accessing the records from memory [17:56:27] thanks for the review! [17:56:28] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (mepps) From @jgleeson in... [17:56:38] Fundraising-Backlog: export db table descriptions for... everything :P - https://phabricator.wikimedia.org/T252570 (DStrine) [17:56:43] should i move the ticket back to doing jgleeson or should it be a separate ticket? [17:57:07] it's ok I'll move it back. this feels like it should be there before that ticket is +2'd [17:57:26] Fundraising-Backlog, fundraising-tech-ops: export db table descriptions for... everything :P - https://phabricator.wikimedia.org/T252570 (DStrine) [17:58:24] actually mepps scrap that [17:58:33] I'll add a follow on patch [17:59:11] that will make it easier for me to add in the API test I was working on which should hopefully not see the caching layer [18:02:07] (PS1) Reedy: Remove _merge_strategy from value [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/596000 [18:05:06] Fundraising-Backlog, fundraising-tech-ops: export db table descriptions for... everything :P - https://phabricator.wikimedia.org/T252570 (Dwisehaupt) Open→Resolved a:Dwisehaupt Scripted this up and pulled all the data for the current db realms into this sheet. Will do some cleanup on the scri... [18:05:10] (CR) Jforrester: [C: +2] Remove _merge_strategy from value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595997 (owner: Reedy) [18:05:47] (CR) Jforrester: [C: +2] Remove _merge_strategy from value [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/596000 (owner: Reedy) [18:09:24] James_F: Reedy: Thanks so much for helping keep CN up-to-date...!!!! Is there a quick explanation somewhere for removing this merge_strategy stuff? I see it's something wider than just CN... https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#Merge_strategies https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/596000 [18:17:48] (PS1) Reedy: Remove _merge_strategy from value [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/596005 [18:18:28] AndyRussG: It was erroneously transferred [18:18:33] In v1 it was part of the config value [18:18:44] in v2, it's a seperate attribute, but it wasn't removed from value due to a bug in the script [18:18:50] So just fixing up the mess we created [18:18:56] (Merged) jenkins-bot: Remove _merge_strategy from value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/595997 (owner: Reedy) [18:19:00] (Merged) jenkins-bot: Remove _merge_strategy from value [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/596000 (owner: Reedy) [18:29:51] Fundraising-Backlog: [Investigate] Trigger monthly convert on payments wiki w/o submitting one-time gift - https://phabricator.wikimedia.org/T252579 (jbolorinos-ctr) [18:32:36] Fundraising-Backlog: [Investigate] Trigger monthly convert on payments wiki w/o submitting one-time gift - https://phabricator.wikimedia.org/T252579 (spatton) [18:33:12] (CR) Jforrester: [C: +2] Remove _merge_strategy from value [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/596005 (owner: Reedy) [18:39:32] Fundraising-Backlog, Recurring-Donations: [Investigate] Trigger monthly convert on payments wiki w/o submitting one-time gift - https://phabricator.wikimedia.org/T252579 (DStrine) [18:43:23] jgleeson maybe that cache isn't needed? [18:43:36] now that I think about it [18:44:01] if we're reading the file often enough, the filesystem or the HDD will probably cache it in memory anyway [18:45:08] let's try without the caching and then update it if it's slow or makes the box work too hard [18:46:18] (Merged) jenkins-bot: Remove _merge_strategy from value [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/596005 (owner: Reedy) [18:47:32] ejegg: how about a follow on patch for the caching, I don't think it's too much work. I'm imagine a scenario where thousands of requests are making calls to the file system each time for each key click [18:47:37] imagining [18:47:55] and that scares me to be honest [18:48:49] my current thinking is I'm just gonna check if the list exists in redis, nothing fancy. If it doesn't populate it [18:49:39] each key on the form will make the API request and open the file 2-3 times with the current code. [18:50:36] ejegg: I wasn't aware about the OS level file caching due to frequent access [18:56:05] yeah ejegg i agree with jgleeson, given that the api call is meant to be hit on each keystroke i think caching is in order [18:56:24] but can be done as a follow on [18:56:30] jgleeson, are you adding tests to that first patch? [18:56:50] mepps: the form field enhancements? [18:56:59] no jgleeson i mean the api patch [18:57:04] i haven't looked at the form yet [18:57:07] yep! [18:57:12] for the API patch I am [18:57:15] cool, i'll wait on +2ing then :) [18:58:37] I'd like to add something for the frontend patch but I'm guessing trying to properly test an autocomplete will take some time if no one else has invested the time to set up something like a selenium adapter [18:59:06] I think something like that exists in mw but I need to take a look [19:05:23] (CR) Mepps: "I'll wait on tests to +2" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [19:12:20] jgleeson are you debouncing so it's not EVERY keystroke? [19:13:19] i.e. setting it on a short timeout (like 100 or 200 ms) and only running once for however many keystrokes are hit during that time? [19:13:56] mepps here's the vagrant patch adding all the queue consumers to a crontab: https://gerrit.wikimedia.org/r/596023 [19:14:18] I'll reword the main CT patch commit message [19:15:40] ejegg: no nothing clever like that. At the moment it just serves up the results as you type [19:16:00] Ah, I think there's a simple jquery way to do it [19:16:01] I'm limiting the results to 10 items also to prevent a huge list [19:16:13] so as you type, it filters more specifically [19:16:33] we might not want to stop you hitting the api after the third and forth keystroke? [19:17:07] maybe we could save the initial result somehow so it filters only that [19:18:02] wait, that might be bad [19:18:20] so if you type B and it gives you back 10 things starting with BA [19:18:41] Then you type O and it has nothing? [19:19:00] so it won't do that at current [19:19:05] it will search for b0 [19:19:14] actually the min length is 2 keystrokes [19:19:18] ah yeah [19:19:24] but to use your example, bb0 [19:19:41] bb would get back all the bba results [19:19:42] heh, that was an uppercase o, not a 0... [19:19:48] ah [19:19:50] ok [19:19:54] anyway [19:21:25] hmm, not finding it in jquery core, but debounce is pretty simple to implement [19:21:46] instead of calling the API on keyup [19:22:01] have a single timeout ID var [19:22:40] and on keyup first clearTimeout() if it's set [19:22:44] ejegg: this came up for me https://code.google.com/archive/p/jquery-debounce/ [19:23:04] then set the timout id var to setTimeout(callApi, 100) [19:23:24] cstone: hey! on lines 52 and 53 of the drush script, where it says, "'In Progress', 'Completed'", is that some kind of civi magic for contribution statuses? It looks like that DB column is integer, not string... [19:23:47] wow, google code sure doesn't make it easy to browse [19:23:50] yep AndyRussG [19:23:58] I have to download the whole zip? [19:24:25] yeah that sucks [19:24:42] cstone ok cool I imagined as much... could u maybe point me to the code or tables that show how it work? I couldn't find an equivalent lookup table for those values, also, though maybe I missed it... thanks much!! [19:24:51] ejegg: https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/jquery-debounce/jquery.debounce-1.0.5.js [19:25:38] seems like that defines both throttle and debounce [19:26:03] I like the idea of this AND the redis cache ha [19:26:05] I guess one runs immediately then prevents repeat calls, while the other waits till things have settled to run the call [19:26:15] yeah, that was the original ticket [19:26:38] ticket? [19:28:35] AndyRussG: the tables are civicrm_option_group and civicrm_option_value. So the id for contribution_status from the group table matches to the values with that option_group_id [19:29:00] whoaaaa [19:29:03] ok [19:29:55] * AndyRussG is like, welcome to a new parallel universe [19:30:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team, Security: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (AndyRussG) [19:33:07] (PS16) Ejegg: Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [20:08:41] Fundraising-Backlog, fundraising-tech-ops: export db table descriptions for... everything :P - https://phabricator.wikimedia.org/T252570 (Dwisehaupt) For posterity, the tool that generates this has been checked in: `[frack::puppet] 44e512d5 Adding the schema_dumpler tool` [20:11:04] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): switch NL credit card processing to adyen - https://phabricator.wikimedia.org/T251172 (DStrine) Open→Resolved [20:11:17] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: system status warning on civi production - https://phabricator.wikimedia.org/T248900 (DStrine) Open→Resolved [20:11:25] Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, FR-Adyen: IL Adyen test donation questions - https://phabricator.wikimedia.org/T251822 (DStrine) Open→Resolved [20:11:40] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, fundraising Sprint Grep works IRL: Review Banner Templating - https://phabricator.wikimedia.org/T246347 (DStri... [20:12:03] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, fundraising Sprint Grep works IRL: Capturing 'contauth' recurring transactions through Adyen - https://phabricator.wikimedia.org/T250106 (DStrine) Open→Resolved [20:12:53] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Dedupe task inappropriately trying to delete contacts - https://phabricator.wikimedia.org/T247377 (DStrine) Open→Resolved [20:13:18] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Visual Basic Instinct, and 7 others: Address final code review comments on geotargeting - https://phabricator.wikimedia.org/T250751 (AndyRu... [20:14:05] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Dedupe task inappropriately trying to delete contacts - https://phabricator.wikimedia.org/T247377 (Eileenmcnaughton) Fixed upstream -... [20:14:11] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, fundraising Sprint Grep works IRL: Fundraising engineer complete list of chores this week - https://phabricator.wikimedia.org/T249524 (DStrine) Open→Resolved [20:14:31] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Gerrit, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (DStrine) ... [20:14:54] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, and 3 others: Adyen sending back 'paymentMethod=ideal' in returnURL which... - https://phabricator.wikimedia.org/T248712 [20:15:21] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Visual Basic Instinct, and 7 others: Address final code review comments on geotargeting - https://phabricator.wikimedia.org/T250751 (AndyRu... [20:15:56] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, and 11 others: Show selected countries and regions under tree selector - https://phabricator.wikimedia.org/T243012 (... [20:15:59] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 6 others: Epic: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (DStrine) [20:16:11] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, and 12 others: Collapse countries and regions into one column in the campaign list - https://phabricator.wikimedia.org/T243011 (DStrine) Open... [20:16:14] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 6 others: Epic: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (DStrine) [20:16:43] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 6 others: Epic: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (DStrine) [20:16:46] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Visual Basic Instinct, and 7 others: Address final code review comments on geotargeting - https://phabricator.wikimedia.org/T250751 (DStrin... [20:19:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Deploy new regional geotargeting and banner template features - https://phabricator.wikimedia.org/T252596 (AndyRussG) [20:22:39] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, fundraising Sprint Grep works IRL, Fr-planning-ahead: Planning ahead tasks for sprint H 2020 - https://phabricator.wikimedia.org/T249017 (DStrine) Open→Resolved [20:25:37] (PS1) Ejegg: Stop showing ALL THE LOGS on test fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596057 [20:27:42] Fundraising-Backlog: Need clarification on Amount fields in Acoustic - https://phabricator.wikimedia.org/T252245 (DStrine) @KHaggard we are not including the endowment on these. The native_amount ones will have to be calculated on export. we'll need to find time for this. [20:34:36] Fundraising Sprint J 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (DStrine) [20:34:38] Fundraising Sprint J 2020, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Deploy new regional geotargeting and banner template features - https://phabricator.wikimedia.org/T252596 (DStrine) [20:34:41] Fundraising Sprint J 2020, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team, Security: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (DStrine) [20:34:44] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, Fundraising-Backlog, and 2 others: Frontend - Make employer field autocomplete which integrates with new backend MW employer data API - https://phabricator.wikimedia.org/T251200... [20:34:47] Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12): Adyen/iDEAL message getting from DonationInterface to Civi missing payment_... - https://phabricator.wikimedia.org/T251025 [20:34:50] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, Fundraising-Backlog, and 2 others: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (DStrine) [20:34:52] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make Civi matching gifts extension store data in custom fields - https://phabricator.wikimedia.org/T249924 (DStrine) [20:34:54] Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, Fundraising-Backlog: Ingenico/Globalcollect SSL cert failures 04-23-2020 - https://phabricator.wikimedia.org/T250950 (DStrine) [20:34:56] Fundraising Sprint J 2020, Fundraising-Backlog: Update PayTM logo on India payment pages - https://phabricator.wikimedia.org/T249232 (DStrine) [20:34:58] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, and 3 others: Civi mail To, CC, BCC email additions diffcult - https://phabricator.wikimedia.org/T248199 (DS... [20:35:00] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, and 5 others: Test migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017... [20:35:02] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Ice cream cures everything, and 3 others: Disregard Adyen recurring authorization IPNs - https://phabricator.wikimedia.org/T243334 (DStrine) [20:35:04] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, Fundraising-Backlog, and 2 others: Investigate how to generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (DStrine) [20:35:06] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (DSt... [20:35:10] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint J 2020, and 5 others: Create script to migrate existing GlobalCollect recur... - https://phabricator.wikimedia.org/T169357 [20:37:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1234 processes [20:38:24] (CR) Eileen: [C: +2] "Yep - that annoys me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596057 (owner: Ejegg) [20:38:53] (CR) Eileen: [C: +2] Exclude another vendor dir from linting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/595978 (owner: Ejegg) [20:42:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1164 processes [20:44:39] Fundraising-Backlog: Need clarification on Amount fields in Acoustic - https://phabricator.wikimedia.org/T252245 (KHaggard) Ok, thanks for the quick reply! I'll adjust the title and description, then. thanks! [20:51:33] Fundraising-Backlog: Need endowment version of the amount fields in Acoustic - https://phabricator.wikimedia.org/T252245 (KHaggard) [20:51:56] (Merged) jenkins-bot: Stop showing ALL THE LOGS on test fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596057 (owner: Ejegg) [20:57:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1083 processes [21:04:41] fr-tech, I seen the downtime in asana! [21:04:47] :) [21:06:44] so ejegg how do you feel about adding in support for the throttle behaviour and also dumping the list of employers in a redis list. I'm guessing the debounce thingy would be maybe on request every second to prevent lag to the user? [21:07:02] one* [21:07:24] jgleeson: cool! I see it too! actually dstrine I see other simultaneous banner campaigns and an e-mail campaign that ends shortly before...?! [21:17:25] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 344 processes [21:21:02] jgleeson could be even more - let's see what a generally used value for autocompletes is [21:24:46] jgleeson|baksoon: this article gets into some edge cases and optimizations I hadn't thought of - https://www.peterbe.com/plog/how-to-throttle-and-debounce-an-autocomplete-input-in-react [21:31:52] (PS17) Ejegg: Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [21:36:51] thanks ejegg I'll give it a read [21:37:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1103 processes [21:47:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1126 processes [21:52:25] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1235 processes [22:12:19] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 349 processes [23:07:00] Fundraising-Backlog: Need endowment version of the amount fields in Acoustic - https://phabricator.wikimedia.org/T252245 (KHaggard) [23:08:09] Fundraising-Backlog: Need endowment version of the amount fields in Acoustic - https://phabricator.wikimedia.org/T252245 (KHaggard) Also adding in "highest_donation_date" as we will be using that in our targeting queries.