[00:02:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1246 processes [00:12:19] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 484 processes [00:57:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1185 processes [01:02:20] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 442 processes [01:09:04] Wikimedia-Fundraising-Banners: Dsk lg: QA enUS control - https://phabricator.wikimedia.org/T250077 (jbolorinos-ctr) Open→Resolved [01:09:32] Wikimedia-Fundraising-Banners: M sm: QA enUS control - https://phabricator.wikimedia.org/T250082 (jbolorinos-ctr) [01:09:54] Wikimedia-Fundraising-Banners: M sm: QA enUS control - https://phabricator.wikimedia.org/T250082 (jbolorinos-ctr) Open→Resolved [01:09:56] Wikimedia-Fundraising-Banners: QA all control banners for 04/15 enUS pretest - https://phabricator.wikimedia.org/T250075 (jbolorinos-ctr) [01:10:15] Wikimedia-Fundraising-Banners: M lg: QA enUS control - https://phabricator.wikimedia.org/T250081 (jbolorinos-ctr) [01:27:25] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1020 processes [01:32:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1277 processes [01:37:19] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 342 processes [01:51:30] database locks? [01:52:24] huh, nuthin' running just now [01:56:17] (CR) Eileen: [C: +2] Add missing extension reqs to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/580115 (owner: Ejegg) [01:58:21] (Merged) jenkins-bot: Add missing extension reqs to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/580115 (owner: Ejegg) [02:00:51] ejegg|away: I killed stuff [03:24:56] (CR) Eileen: "Wow - this is kinda mind bending as an approach because with imports this donations go in real time but the tracking records go into the q" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [04:52:10] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [04:57:15] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:02:09] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:07:09] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:12:09] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:17:15] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 47 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:22:10] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:27:15] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:32:09] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 49 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:37:09] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [05:42:09] RECOVERY - check_puppetrun on frav1002 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [10:51:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [10:56:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:01:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 36 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:06:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:11:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:16:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:21:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:26:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:31:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 33 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:36:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:41:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:46:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 13 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:51:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:56:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:01:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 13 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:06:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:11:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:16:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 54 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:21:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:26:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [12:31:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 36 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-server] [12:36:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-server] [12:41:14] RECOVERY - check_puppetrun on frdb2002 is OK: OK: Puppet is currently enabled, last run 43 seconds ago with 0 failures [14:44:58] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) a:mepps I'd like to take a look at this. I see what @MBeat33 is saying, both about the filters and the other users being in source name... [14:45:29] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) Also I suspect that this might have to do with one of the recent point upgrades. [14:47:50] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) Of course the deleted contact does not have a contribution history, because it was moved to the new contact :). [15:02:12] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) @Eileenmcnaughton the filtering bug is definitively because of this commit in CRM_Report_Form_Activity: https://github.com/civicrm/civicrm-... [15:15:01] (PS1) Mepps: Upstream dev/core#1729 Fix filters skipping onn activity report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/596234 (https://phabricator.wikimedia.org/T251958) [15:39:32] fr-tech any news for scrum-o-scrums? [15:39:59] https://www.youtube.com/watch?v=GQ05_gDud6w [15:42:09] ejegg: nothing here, thnaks! [15:58:56] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) So the merge activity source name issue feels a little trickier. I went ahead and tested merges locally that got the... [16:48:34] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Coleman Watts - https://phabricator.wikimedia.org/T252693 (DStrine) [16:51:55] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Tim Otten - https://phabricator.wikimedia.org/T252694 (DStrine) [17:29:47] Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Cmjohnson) [19:05:03] (CR) Eileen: [C: +2] Upstream dev/core#1729 Fix filters skipping onn activity report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/596234 (https://phabricator.wikimedia.org/T251958) (owner: Mepps) [19:08:35] (CR) Ejegg: [C: +2] Upstream dev/core#1729 Fix filters skipping onn activity report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/596234 (https://phabricator.wikimedia.org/T251958) (owner: Mepps) [19:09:02] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) @Eileenmcnaughton is confirming that when the script dedupes, it sets the source as the deleted contact. [19:12:01] fundraising-tech-ops, Operations, decommission, ops-eqiad, Patch-For-Review: decommission bismuth.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T248516 (Cmjohnson) [19:12:02] (Merged) jenkins-bot: Upstream dev/core#1729 Fix filters skipping onn activity report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/596234 (https://phabricator.wikimedia.org/T251958) (owner: Mepps) [19:14:13] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) We might want to see why target contact is not being set when the script dedupes, but source name as the deleted cont... [19:14:29] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596273 [19:15:33] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596273 (owner: Eileen) [19:22:05] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) @Eileenmcnaughton When, exactly, does the dedupe script run? I'd like to test this locally to see about the target. [19:22:05] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/596274 [19:22:30] (Merged) jenkins-bot: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596273 (owner: Eileen) [19:26:43] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/596274 (owner: Eileen) [19:34:53] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (mepps) Also from Eileen in chat, here's where the target should be set: https://github.com/civicrm/civicrm-core/blob/bbc11d1... [19:50:44] Fundraising-Backlog: Info for moving Adyen off of IFrame and onto Hosted Payment Page - https://phabricator.wikimedia.org/T252713 (EMartin) [20:22:11] oh boy, a new missing payment instrument failmail! [20:22:24] maybe the new logging will shed some light [20:24:43] !! [20:25:14] well, sort of... [20:25:43] shows what browser, and that the payment_submethod didn't get posted back from the form [20:25:49] (or got posted back blank) [20:27:09] but the utm_source DOES have the payment_submethod included, so it was definitely there at some point [20:27:57] probably on the querystring from donatewiki [20:29:23] huh, had variant=monthlyConvert too, though we don't support that via Adyen yet [20:31:31] interesting [20:36:26] I wonder if this could be causing issues: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/modules/js/ext.donationInterface.forms.js$199 [20:37:35] hmm, why was that originally written ejegg? [20:37:41] it does seem like it could to me! [20:38:09] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/596274 (owner: Eileen) [20:39:00] mepps for people either loading the page via refresh or back button i think [20:39:25] hmmm [20:39:55] but if that's empty doesnt the validation prevent the form from being submit [20:40:01] since this is happening for the single-submethod case, the easiest thing to do would be to check how many options exist there [20:40:10] good question jgleeson, let's see [20:41:39] it looks like the form gets submit WHEN someone clicks a submethod [20:42:11] ahhh and the paymentContinueBtn.. [20:43:41] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/75effede7faf2a2d9e9f68ce0031a8a384988133/modules/js/ext.donationInterface.forms.js#L204 [20:44:10] so I realised the reason my github links dont work is because my local version of master is newer than the github mirror [20:44:16] github links in phpstorm [20:44:27] so quickly checking out origin/master fixes those [20:45:01] oho, another possibility: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/modules/validate_input.js$96 [20:45:21] I bet we can recreate this locally by triggering an error on form validation [20:56:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Enable Civi to more accurately reflect Silverpop unsubscribes - https://phabricator.wikimedia.org/T252715 (MBeat33) [20:57:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Civi: enable all DS agents to delete smart groups - https://phabricator.wikimedia.org/T249153 (MBeat33) will check with Rakhi to see if her permission has changed [20:59:03] ejegg: I went to push out the report patch but it says the civi version is locked - is that to prevent any cont tracking going out by accident? [21:01:16] eileen oh interesting, that usually happens if someone rolled back [21:01:26] hmm [21:01:49] fr-tech did anyone lock the civi revision when deploying? [21:02:12] Ahh, I think it can also happen if someone uses fr_code_update with a specific revision hash [21:02:20] not I... not sure what that is, also [21:02:29] eileen: we shouldn't need it for that reason [21:02:44] I mean to prevent contribution tracking changes being deployed [21:02:54] those are still not even merged to master let alone deployment [21:02:59] ok - so I have to unlock it & I can deploy [21:04:21] eileen yep [21:04:23] afaik [21:05:07] !log civicrm revision changed from cfb6101e39 to ed4c9522ac, config revision is 2eb75f8dff [21:05:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:05:31] MBeat: that activity report should be fixed [21:05:42] thx, eileen [21:05:57] mepps: I deployed ^^ [21:12:31] Fundraising Sprint Just space out, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: report/instance/107 being weird - https://phabricator.wikimedia.org/T251958 (Eileenmcnaughton) @mepps the script looks like drush civicrm-merge --rule_group_id=13 --batch=5000 --threshold=550 --thres... [21:26:21] (PS1) Ejegg: Don't clear sole submethod on validate fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/596286 (https://phabricator.wikimedia.org/T251025) [21:26:29] jgleeson I think ^^^ will actually fix it! [21:26:43] AndyRussG: that debug logging for Adyen paid off [21:26:56] looks like the issue was probably client-side [21:27:19] you can repro it by triggering a validation error before submitting an ideal form [21:27:30] like putting in a badly formatted email address [21:28:11] (CR) jerkins-bot: [V: -1] Don't clear sole submethod on validate fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/596286 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [21:29:10] hmm [21:30:57] (PS2) Ejegg: Don't clear sole submethod on validate fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/596286 (https://phabricator.wikimedia.org/T251025) [21:36:06] k, just a couple missing spaces [21:40:39] (PS3) Ejegg: Don't clear sole submethod on validate fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/596286 (https://phabricator.wikimedia.org/T251025) [21:45:56] ejegg: that looks good to me. will test it out locally in a min just pushing up some tests for the autocomplete stuff [21:46:42] thanks! [21:50:16] (PS8) Jgleeson: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) [21:50:18] (PS4) Jgleeson: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) [21:57:15] (CR) Ejegg: "Thanks! Couple of questions from a quick look at the code." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [22:05:19] thanks ejegg [22:05:28] right lets test out that patch [22:05:47] so I need to enter an invalid amount on an ideal form [22:06:03] to confirm the current code is broke [22:06:05] / [22:06:07] ? [22:06:09] let's try that [22:07:31] (CR) Jgleeson: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [22:07:38] (CR) Jgleeson: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [22:08:58] jgleeson no, not an invalid amount [22:09:04] an invalid email address [22:09:16] the bad old code was inside validate_personal [22:10:51] ahhh thanks [22:13:27] ejegg: when I browse to the ideal payment form there is no radio group [22:13:41] input:radio[name=payment_submethod] [22:13:49] right, it's hidden [22:14:05] if you search for it in the code you should see it though [22:14:11] *html that is [22:14:12] sorry I'm being silly [22:14:15] it is there [22:14:19] I just missed the type [22:14:21] @_@ [22:14:53] * ejegg puts on 'Sauceful of Secrets' in honor of the sprint name [22:15:04] *Saucerful [22:17:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1050 processes [22:17:21] nice. my second favorite floyd album, after Meddle [22:18:07] hmm ejegg checkout https://phabricator.wikimedia.org/F31816471 [22:18:24] argh sorry [22:18:28] it's checked isn't it [22:18:44] it's i't't't't... [22:18:52] let's try that test again [22:20:56] ok that's the current broken code https://phabricator.wikimedia.org/F31816476 [22:22:10] nicely demonstrated! [22:22:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1206 processes [22:22:47] :) [22:23:17] dwisehaupt: any idea what's behind that procs critical warning ? [22:23:19] and now the fixed code behaviour! https://phabricator.wikimedia.org/F31816478 [22:23:36] i'll check again. [22:24:00] jgleeson: yay! [22:24:19] (CR) Jgleeson: [C: +2] "Working well for me. Good spot!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/596286 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [22:24:37] yep, as suspected. [22:24:41] Thanks jgleeson [22:24:54] I'll just deploy that as soon as it merges so we can move the ticket along [22:25:17] it's a dedupe run. it tends to push the machine hard enough that a chunk of kworker procs fire up and that puts us over the count threshold [22:25:37] ah wow [22:26:07] yeah. the threshold isn't really that high. [22:26:34] (Merged) jenkins-bot: Don't clear sole submethod on validate fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/596286 (https://phabricator.wikimedia.org/T251025) (owner: Ejegg) [22:27:17] dedupe does a lot of work that gets portioned out. we could safely bump that limit up [22:27:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1443 processes [22:32:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1581 processes [22:32:37] wow - I just got a huge bunch of flowers from a CiviCRM person in Netherlands (Jaap - was in Barcelona) [22:34:37] eileen: that's awesome! [22:34:46] did it include a note asking you to review a patch :) @? [22:34:51] mepps: how much longer are you working? [22:35:23] jgleeson: lol - no that's probably coming when I let my guard down :-) [22:35:31] ha [22:39:45] ejegg: i've bumped that threshold. been thinking about doing it for a few days and this pushed me over. :) [22:42:19] PROBLEM - check_procs on frdb1002 is CRITICAL: PROCS CRITICAL: 1266 processes [22:43:27] nice eileen! [22:47:19] RECOVERY - check_procs on frdb1002 is OK: PROCS OK: 569 processes [22:54:25] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/596314 [22:54:29] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/596314 (owner: Ejegg) [22:55:26] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/596314 (owner: Ejegg) [23:00:00] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/596315 [23:00:04] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/596315 (owner: Ejegg) [23:06:11] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/596315 (owner: Ejegg) [23:12:18] hmph [23:14:26] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/596315 (owner: Ejegg) [23:17:59] (PS1) Cstone: Ignore authorization IPN messages from subsequent recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/596320 [23:20:22] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/596315 (owner: Ejegg) [23:26:06] (CR) Ejegg: [C: +2] "Looks good! Thanks for fixing that undeclared var too." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/596320 (owner: Cstone) [23:26:37] (Merged) jenkins-bot: Ignore authorization IPN messages from subsequent recurring Adyen donations. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/596320 (owner: Cstone) [23:27:01] thanks ejegg! [23:29:38] !log updated payment-wiki from dabba1804c to 3c465cb11c [23:29:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:32:01] cool, that deploy didn't seem to break things! [23:33:35] Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): Adyen/iDEAL message getting from DonationInterface to Civi missing ... - https://phabricator.wikimedia.org/T251025 [23:35:17] ah crap, something looks bad in the logs [23:35:19] reverting [23:35:47] ejegg think its ok to push out that smashpig fix? looks like its that fix and the code cleanups that would go out [23:36:10] !log rolled back payments-wiki to dabba1804c [23:36:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:36:25] cstone sure! [23:36:36] I'll watch the logs for that one [23:37:08] so hmm, what's causing the 'invalid argument for foreach()' that I saw when I deployed just now? [23:37:31] DataValidator.php 611 [23:37:52] ohhhh [23:38:15] I didn't change the settings when I changed the blacklist/whitelist [23:38:18] derp [23:38:19] lemme fix that [23:38:25] and redeploy [23:40:39] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/596321 [23:42:02] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/596321 (owner: Cstone) [23:42:24] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/596321 (owner: Cstone) [23:43:19] !log updated payments-wiki from dabba1804c to 3c465cb11c [23:43:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:44:42] ok, that looks better! [23:46:40] !log SmashPig revision changed from cd1a49da5f to 2702b04329 [23:46:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:53:28] ejegg i made a one time and recurring donation and both look good, im gona go get some food and I can push through one of my recurrings when i get back