[00:13:01] great! [00:13:47] logs look fine [00:26:11] ok, calling it quits for tonight [00:28:31] ugh, database locks [00:29:39] ok, killed some queries [00:30:40] hokey smokes but those were some huge contact1.id IN (...) lists [00:41:30] yeah, that was 20001 contacts in each dedupe list [00:48:13] that's being set by the staff I guess to get nice big lists - probably trying to widen the net [00:50:33] dang, I killed it like 20 minutes ago and it's still in 'query end' state [00:50:45] and still causing failmail [00:51:48] (PS1) Eileen: Core 5.25 updates [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/596324 [00:55:01] I found a bug that I could fix by grabbing slightly later core - [01:09:55] fr-tech failmail storm... [01:31:42] yeah AndyRussG there was a dedupe query that was stuck for a while [01:31:46] even after we killed it [01:32:07] bah, now we have to requeue a lot of messages [01:35:58] ok, I think that requeued a lot of them [03:02:52] ejegg|away: ah okok thanks! [11:33:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487 (Aklapper) Stalled→Open >>! In T95487#1361040, atgo wrote: > Waiting for MGF to import the next file to confirm that this is closed Five y... [12:17:18] Fundraising-Backlog, Performance Issue: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Aklapper) Stalled→Resolved Going to the static resources https://donate.wikimedia.org/static/images/project-logos/donatewiki.png the response heade... [12:17:20] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Epic, Performance Issue: [Epic] Payments performance tuning - https://phabricator.wikimedia.org/T140311 (Aklapper) [12:19:10] Fundraising-Backlog, Performance Issue: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Aklapper) (Ah, though not sure if `donate.wikimedia.org` == `payments.wikimedia.org`? I got redirected...) [15:37:31] fr-tech I updated some contribution tracking docs here: https://www.mediawiki.org/wiki/Fundraising_tech/Contribution_tracking [15:37:41] let me know what else you want to see there! [15:38:39] nice ejegg! [15:40:40] ejegg it looks really good, i wonder if the bottom part might eventually want to be bulleted lists? The narrative is well-written but might be harder to parse later [15:41:17] the part talking about the queue consumer? [15:41:50] hi fr-tech :) [15:42:14] Howdy [15:42:41] hi jgleeson XenoRyet [15:43:09] hey hey :) [15:44:43] Fundraising-Backlog, Performance Issue: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Ejegg) @Aklapper donate.wikimedia.org is a production-cluster wiki that hosts fundraising-related landing pages, thank you pages, and first-step donation f... [15:45:52] hi jgleeson and XenoRyet [15:50:57] Fundraising-Backlog, Performance Issue: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Ejegg) Resolved→Open The payments-wiki headers still don't include cache-control. Reopening. There's a new path for the image: https://payments.wi... [15:50:59] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Epic, Performance Issue: [Epic] Payments performance tuning - https://phabricator.wikimedia.org/T140311 (Ejegg) [15:52:24] Fundraising-Backlog, fundraising-tech-ops, Performance Issue: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Ejegg) [16:07:12] ejegg: I remember seeing somewhere that we bubble ip clientside errors to our backend logs. I wanted to add that in to the autocomplete stuff, do you remember how tha tworks? [16:07:24] s/ip/up/ [16:07:47] jgleeson we use javascript's onError, so it should catch errors there too [16:08:19] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/modules/js/ext.donationInterface.errorLog.js$2 [16:08:24] do in this case I'm checking to see if we get an error back from the api [16:08:38] and I don't want it to throw the js error at the browser level [16:08:40] shouldn't we log API errors server-side? [16:09:11] oh I guess I could catch it there [16:09:52] and just switch off the feature if the api is not working for some reason [16:10:11] hmm switch off isn't the right description [16:10:31] suppress behaviour and fallback to non autocomplete [16:11:42] feels like it would be better to fallback in the js if something breaks at the server end than let it fail and send back messages via the onError event [16:11:58] as we'll have it logged at the api level [16:14:33] Hmm, but free-text entries won't be a lot of help [16:14:47] unless they exactly match the name from the list [16:14:59] hi fr-tech! [16:15:00] I guess as a backup maybe it's better than hiding the field [16:15:03] hi AndyRussG ! [16:15:10] :) [16:15:23] DataValidator.php 611https://www.mediawiki.org/wiki/Fundraising_tech/Contribution_tracking [16:15:36] AndyRussG: I put a couple of sequence diagrams up at https://www.mediawiki.org/wiki/Fundraising_tech/Contribution_tracking [16:15:41] weird [16:16:09] anyway, those are the most-common case. Please let me know what else you'd like to see diagrammed [16:18:37] hi AndyRussG :) [16:22:18] :) :) [16:22:57] ejegg: bootiful! [16:23:12] thanks for doing that! [16:27:44] yeah ejegg thanks for such detailed diagrams [16:29:51] yw! [17:13:06] fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (Dwisehaupt) a:Dwisehaupt SSL capability is available on all dbs. Working though the different tools we have to ensure they use (or can use) ssl connectivity. Then moving onto large... [18:18:24] Jeff_Green / dwisehaupt where's the best place to test how long it'll take to alter the contribution tracking table to remove autoincrement on the ID column? [18:18:34] the frdev replica? [18:18:37] yeah [18:18:51] ok, cool. [18:49:41] dstrine fr-tech hey, I might have trouble joining the analytics meet [18:50:06] or might be a bit late [18:52:39] AndyRussG: it's cool its totally optional [18:59:18] dstrine okok thanks I might join by phone in 5 or 10 min [19:52:35] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [19:53:48] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [19:57:35] fr-tech I'm gonna try that alter table statement on frdev [19:58:34] ejegg what's the alter table statement? [20:00:16] mepps for contribution_tracking [20:00:27] hmm, but drush is asking for my password [20:00:39] Jeff_Green: is there something funky with the drush setup on frdev? [20:00:58] ejegg: looking [20:01:06] oh wait, I bet I need to check out the latest rev of the vendor dir [20:01:38] makes sense, lemme know if that doesn't fix it [20:02:40] whee, cpu over 100% [20:03:06] woot [20:03:10] looks like still a bunch of cores idle tho [20:03:14] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (mep... [20:05:42] ejegg, i just put that you were testing sql on the ticket so that others know what's been done :) [20:06:06] mepps oh just checking how long the updb will take [20:06:10] not much of a test... [20:06:16] cool ejegg [20:07:14] oops, just noticed a mistake in the sequence diagram [20:08:15] ah! [20:09:11] just that DonationData::postProcessDonation should instead be GatewayAdapter::postProcessDonation [20:09:14] fixing [20:10:09] Fundraising-Backlog: Document changes in Contribution Tracking - https://phabricator.wikimedia.org/T252818 (mepps) [20:10:29] hey ejegg, you've done a lot of work on that and i want to remember to try to edit it--i created a task for all that ^^ [20:14:43] thanks mepps! [20:52:17] Fundraising-Backlog: Document changes in Contribution Tracking - https://phabricator.wikimedia.org/T252818 (mepps) I'm thinking it might be helpful to move some of the narrative to bulleted lists but my brain isn't quite processing how I'd do that today :). I'm going to look again next week. [21:58:06] (CR) Jgleeson: Add autocomplete to Employer form field (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [21:58:31] (PS9) Jgleeson: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) [21:58:33] (PS5) Jgleeson: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) [22:14:07] (PS10) Jgleeson: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) [22:14:09] (PS6) Jgleeson: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) [22:54:45] ejegg i was doing weird amounts for testing to keep them apart and the ideal ones in the contribution_tracking table always say EUR 10.00 for the form_amount [22:55:02] am I missing a second spot where I should be changing that? [23:02:45] cstone ooh weird [23:03:08] hmm, I think it would always record the amount from the querystring, actually [23:03:19] let me try locally [23:03:31] i dont think this is from the ct patch it looks like its always been doing that locally [23:04:04] and that happens even with a different value on the testing link? [23:04:45] yeah [23:05:20] like i did a 2.22 ideal recurring and it was right everywhere else but 10.00 in ct [23:09:07] mepps I discovered another bug fix in latest released civi that we should grab - by agh [23:09:07] We could just grab the fix but I think updating the changed files make sense, even though we are not really affected by the other things (& the apiv4 thing is kinda noisy but not important) https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/596324/ [23:29:38] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Cst... [23:37:42] cstone oops, testing locally I just realized I hadn't initialized the sequence number so I was overwriting the first few rows in my db [23:38:39] hah yeah I accidentally reset it instead of running the adyen maintenance script then just put it at a higher number [23:40:59] ok, so loading in a private window with currency=EUR&amount=2.22 on the link [23:41:20] I do see fo rm_amount="EUR 2.22" in the queue message in redis [23:41:27] let's see what happens after I run the consumer [23:42:21] errr, where's they go? [23:43:22] oh derp, still going to my phpunit test db [23:43:37] switching that... [23:45:37] ok, that looks right now [23:45:49] cstone I wonder if you've got the 10.00 EUR saved in session? [23:45:54] how were you editing it? [23:45:58] yeah i was wondering if its something like that [23:46:01] want to show me in a screenshare? [23:46:02] in the URL [23:46:11] sure [23:46:50] this one? https://meet.google.com/nsc-symi-ici [23:46:56] ok