[00:35:56] (PS1) Eileen: Create new recurring contributions with Pending status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597402 [02:23:04] Fundraising-Backlog: Emojis in firstname/lastname causing names to be too long for Ingenico - https://phabricator.wikimedia.org/T241757 (Cstone) Happened again today with: \ud835\udcd3\ud835\udcea\ud835\udcf2\ud835\udcea\ud835\udcf7\ud835\udcea \u2764\ufe0f\ud83d\ude0d [02:27:09] Fundraising Sprint Just space out, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team, and 2 others: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (sbassett) Re: SecurityCheckPlugin in CI - [[ https://gerrit.wikimedi... [02:48:08] (PS3) Ejegg: Add custom matching gift fields in installer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597300 (https://phabricator.wikimedia.org/T249924) [03:43:30] (PS1) Eileen: Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 [03:45:19] (CR) jerkins-bot: [V: -1] Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (owner: Eileen) [03:49:15] (PS1) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 [03:51:10] (CR) jerkins-bot: [V: -1] Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (owner: Eileen) [03:54:53] (PS2) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 [04:01:17] (CR) jerkins-bot: [V: -1] Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (owner: Eileen) [10:05:00] Fundraising Sprint Just space out, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team, and 2 others: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (Daimona) The original issue was found too long ago (June 2019) for u... [10:05:28] (CR) Daimona Eaytoy: [C: +2] Remove XSS suppression added in Geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/597338 (https://phabricator.wikimedia.org/T251269) (owner: Mepps) [10:13:13] (Merged) jenkins-bot: Remove XSS suppression added in Geotargeting [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/597338 (https://phabricator.wikimedia.org/T251269) (owner: Mepps) [14:56:18] how's things going fr-tech? [15:09:43] so for the matching gifts extension, if I'm going to make a job progress table and store the search results while we process them [15:10:05] hey ejegg [15:10:06] i should split out the search and the details as two different api actions [15:10:10] hi mepps! [15:10:14] ejegg mepps fr-tech helloooo [15:10:18] hi AndyRussG ! [15:10:27] :) [15:10:39] ejegg have you put that on the ticket? i'm curious what you mean about a job progress table [15:10:54] mepps following eileen's example with omnimail [15:11:07] cool ejegg [15:11:11] there's a single 'job' that is to update our side with all the new info from their side [15:11:24] that involves a series of API calls from us to them [15:12:21] and the simplest way is to make an API call for the list of updated companies, assign that to a var, and loop over, making details api calls and assigning details to another array [15:12:34] but if that gets interrupted anywhere, we have to start from scratch [15:12:38] okay ejegg that makes sense [15:12:54] so the idea is to store where we get in case of interruption? [15:12:55] so in the interest of not wasting API calls, we'd save the initial list to a table [15:13:00] yep [15:13:18] that makes sense [15:13:39] where each row has the minimal company info returned from the search result, plus a job id (or just the timestamp of job start time?), plus a 'processed' flag [15:14:27] dumb question but where will the detailed info be at that point? [15:14:32] assuming an interruption [15:14:46] so we could put that into a holding table [15:15:05] or we could just go ahead and create / update the org contact records as we go [15:18:19] ejegg it seems like it would make sense to update the org record unless there's a more performant way to do that [15:24:27] yep, updating the org record seems like the right way to me too [15:29:00] cool ejegg [15:29:28] fr-tech anything you want me to share with other teams in scrum-o-scrums update? [15:32:52] wow, etherpad looks super new and shiny! [15:42:58] yeah ejegg i like the new theme [15:46:14] Fundraising-Backlog: Error 1099 : INVALID_VALUE: '2001.0000000000002' bug on local paymentswiki - https://phabricator.wikimedia.org/T253237 (jgleeson) [15:56:12] ejegg weirdly amazon audit options will not save for me [16:04:42] oh hmm [16:04:52] mepps no error visible? [16:05:20] ejegg i was able to set the variable via drush [16:09:49] ejegg: nothing here, thanks! [17:44:37] Fundraising Sprint Just space out, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Contribution tracking queue consumer should reject bad updates - https://phabricator.wikimedia.org/T253250 (Ejegg) [18:02:11] (PS1) Mepps: Update email address to donate@wikimedia.org [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597597 (https://phabricator.wikimedia.org/T25306) [18:18:36] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (spatton) Hey @DStrine, I realized that I've been assuming that when we say "make monthly convert default," we would be able to make that choice on a country by coun... [18:22:21] Fundraising-Backlog, Epic: EPIC: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (DStrine) @spatton for simplicity of maintenance a lot of this is global for an entire processor. I assume a per country control will be more work. I'll have to talk... [18:32:13] (PS2) Mepps: Update email address to donate@wikimedia.org [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597597 (https://phabricator.wikimedia.org/T253068) [18:33:04] for some reason that's not showing up on the ticket ^^ [18:33:20] Fundraising Sprint Just space out, Fundraising-Backlog: design edits for the payments maintenance page - https://phabricator.wikimedia.org/T253068 (mepps) Update email: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContributionTracking/+/597597/ [18:36:05] Wikimedia-Fundraising-Banners: Banner remains visible after user enters a valid email and clicks submit - https://phabricator.wikimedia.org/T253147 (EWilfong_WMF) I don't believe this is a bug. We can decide if it's a feature we want to implement. Currently, clicking outside of the nag does not close the n... [19:09:28] Fundraising-Backlog: endowment donor did not get TY email. - https://phabricator.wikimedia.org/T253257 (DStrine) [19:38:25] Fundraising-Backlog, Recurring-Donations: Civi: recurring Ingenico status question - https://phabricator.wikimedia.org/T253259 (MBeat33) [20:03:06] (PS18) Ejegg: Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [20:03:08] (PS1) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [20:04:39] fr-tech I just added a rollback plan header to the ct deployment etherpad [20:04:49] in the unlikely event it's needed [20:04:56] Good call, thanks. [20:04:56] https://etherpad.wikimedia.org/p/ContributionTracking [20:05:02] (CR) jerkins-bot: [V: -1] Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [20:15:42] (PS1) Eileen: Upstream patch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597610 [20:20:34] (CR) Ejegg: [C: +2] Upstream patch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597610 (owner: Eileen) [20:21:46] oh weird, that V-1 15 min ago was a failure to send a password reminder email on completion of drupal setup [20:21:52] when did that step creep in? [20:22:04] hmm, I guess I should add a test anyway [20:26:37] (Merged) jenkins-bot: Upstream patch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597610 (owner: Eileen) [20:28:35] (PS2) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [20:31:23] (CR) jerkins-bot: [V: -1] Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [20:33:38] (PS1) Eileen: Set silverpop as default rather than required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597615 [20:35:47] (CR) jerkins-bot: [V: -1] Set silverpop as default rather than required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597615 (owner: Eileen) [20:57:00] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597615 (owner: Eileen) [21:02:49] (PS3) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [21:04:42] (CR) jerkins-bot: [V: -1] Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [21:18:58] fr-tech, I've been able to confirm that paypal and amazon 1 time donations work as expected. I've also half completed a recurring paypal transaction but need to work out how to send back the right IPN for the recurring charge to drop a donation message on the queue as I've not seen one of them yet. It looks like we don't do recurring on amazon? [21:21:18] I've run into a blocker checking these results in civi. My current version of civicrm is 5.25.beta2 but the system status is Alert which then tells me I need to update so after running `drush cvupdb` I get all kinds of errors about a missing db field with the following: [21:21:20] UPDATE civicrm_domain [21:21:22] SET version = '5.23.alpha1' [21:21:24] [nativecode=1054 ** Unknown column 'config_backend' in 'OLD'] [21:21:26] * ERROR DEBUGINFO: [21:21:28] UPDATE civicrm_domain [21:21:44] which doesn't make much sense because apparently I'm already on 5.25 so I'm gonna try and work out what's up with that tomorrow [21:24:33] I managed to confirm they made it to civi however by checking the dv [21:24:35] db* [21:25:55] jgleeson that looks like there's a problem with triggers [21:28:24] fr-tech, correction, we do support recurring with amazon and that also worked [21:28:50] jgleeson: woohooo! way to go [21:29:39] ejegg: thanks. I'll dig into that in the morning. I've snapshotted a working version of the db so will restore back to that and try again [21:29:47] AndyRussG: :) [21:30:10] bye for now [21:36:23] bye! [21:41:57] (PS4) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [21:53:43] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Tim Otten - https://phabricator.wikimedia.org/T252694 (Dwisehaupt) Spoke with Tim in the call today. Setting up accounts now. [21:54:58] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Tim Otten - https://phabricator.wikimedia.org/T252694 (Dwisehaupt) [21:55:23] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Coleman Watts - https://phabricator.wikimedia.org/T252693 (Dwisehaupt) Spoke with Coleman in the call today. Setting up accounts now. [21:56:18] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Coleman Watts - https://phabricator.wikimedia.org/T252693 (Dwisehaupt) [22:07:37] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Coleman Watts - https://phabricator.wikimedia.org/T252693 (Dwisehaupt) [frack::puppet::private] 57a04eb Adding db perms for cwatts and totten - civicrmllc [22:07:45] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Tim Otten - https://phabricator.wikimedia.org/T252694 (Dwisehaupt) [frack::puppet::private] 57a04eb Adding db perms for cwatts and totten - civicrmllc [22:25:28] (PS1) Ejegg: Update email address in maintenance page [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597641 (https://phabricator.wikimedia.org/T253068) [22:26:33] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Coleman Watts - https://phabricator.wikimedia.org/T252693 (Dwisehaupt) [22:26:43] (CR) jerkins-bot: [V: -1] Update email address in maintenance page [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597641 (https://phabricator.wikimedia.org/T253068) (owner: Ejegg) [22:28:19] (PS2) Ejegg: Update email address in maintenance page [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597641 (https://phabricator.wikimedia.org/T253068) [22:28:22] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Coleman Watts - https://phabricator.wikimedia.org/T252693 (Dwisehaupt) Set up mysql config and verified I could log in as the user and verified db access and restrictions were in place and functioning. Acce... [22:28:42] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Tim Otten - https://phabricator.wikimedia.org/T252694 (Dwisehaupt) Set up mysql config and verified I could log in as the user and verified db access and restrictions were in place and functioning. Access w... [22:29:19] Fundraising-Backlog, fundraising-tech-ops: Setup shell access and civi access for civi staging for Tim Otten - https://phabricator.wikimedia.org/T252694 (Dwisehaupt) [22:30:05] Fundraising Sprint Just space out, Fundraising-Backlog: Update PayTM logo on India payment pages - https://phabricator.wikimedia.org/T249232 (Ejegg) Hi Evelyn, that looks just like the logo we're already using: https://payments.wikimedia.org/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&payme... [22:51:57] (CR) Ejegg: [C: +2] "Oops, I didn't see this before I uploaded I0e46d576051bbb2d01d6a3 . That one's configurable, but it does create a circular dependency with" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597597 (https://phabricator.wikimedia.org/T253068) (owner: Mepps) [22:52:40] (Abandoned) Ejegg: Update email address in maintenance page [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597641 (https://phabricator.wikimedia.org/T253068) (owner: Ejegg) [23:03:49] (Merged) jenkins-bot: Update email address to donate@wikimedia.org [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/597597 (https://phabricator.wikimedia.org/T253068) (owner: Mepps) [23:21:25] mepps: FYI this was the page I was looking for earlier - https://collab.wikimedia.org/wiki/Fundraising/Email_Processes_%26_Documentation/ESP_Overview_%26_Access [23:23:31] (Abandoned) Eileen: Core 5.25 updates [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/596324 (owner: Eileen) [23:24:24] also mepps this is from the call - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/597615/ [23:27:14] Fundraising Sprint Just space out, Fundraising-Backlog: Update PayTM logo on India payment pages - https://phabricator.wikimedia.org/T249232 (EMartin) ok, that's good news! I didn't compare it. Thanks [23:27:30] ejegg: my understanding is we should kill this as it's been superceded ? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/569616/ [23:30:01] (PS1) Eileen: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597651 [23:30:12] (CR) Eileen: [C: +2] Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597651 (owner: Eileen) [23:31:09] (CR) jerkins-bot: [V: -1] Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597651 (owner: Eileen) [23:33:17] (PS1) Eileen: Further tweak on PRINT_WATCHDOG_ON_TEST_FAIL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597652 [23:34:02] If anyone is able to +2 https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/597652/ it will help me on https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/2496/console [23:36:28] (Merged) jenkins-bot: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597651 (owner: Eileen) [23:46:55] I can eileen [23:47:08] (CR) Cstone: [C: +2] Further tweak on PRINT_WATCHDOG_ON_TEST_FAIL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597652 (owner: Eileen) [23:52:22] thanks cstonne [23:52:35] erm cstone [23:52:54] stonne sounds fancier [23:53:32] (Merged) jenkins-bot: Further tweak on PRINT_WATCHDOG_ON_TEST_FAIL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597652 (owner: Eileen) [23:55:27] (PS2) Eileen: Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 [23:57:17] (CR) jerkins-bot: [V: -1] Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (owner: Eileen) [23:58:07] (PS3) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 [23:58:11] cstone: an extra n for free