[00:04:22] (CR) jerkins-bot: [V: -1] Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (owner: Eileen) [00:30:14] (PS1) Eileen: Test fix - correct case in the test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597656 [00:30:32] another test-related fix ^^ if someone can +2 [00:32:39] (CR) XenoRyet: [C: +2] Test fix - correct case in the test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597656 (owner: Eileen) [00:32:48] thanks XenoRyet [00:32:53] No worries [00:33:47] (CR) jerkins-bot: [V: -1] Test fix - correct case in the test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597656 (owner: Eileen) [00:36:59] (PS4) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 [00:43:51] (CR) jerkins-bot: [V: -1] Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (owner: Eileen) [00:45:40] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (owner: Eileen) [00:48:14] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/597661 [00:50:01] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/597661 (owner: Eileen) [00:53:14] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/597661 (owner: Eileen) [01:04:50] (PS12) Cstone: Drush script to tokenize old recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [01:06:39] (CR) jerkins-bot: [V: -1] Drush script to tokenize old recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [01:27:48] (PS1) Eileen: Put slow sql statement from civicrm upgrade into wmf_civicrm install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597663 [01:29:34] (CR) jerkins-bot: [V: -1] Put slow sql statement from civicrm upgrade into wmf_civicrm install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597663 (owner: Eileen) [01:30:05] (PS5) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 [01:48:18] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Cst... [08:40:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Updating multiple contribution in Civi - can we increase the limit? - https://phabricator.wikimedia.org/T253293 (RLewis) [09:47:34] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (ovasileva) @DStrine - any updates from your side? In terms of testing - since there's no "before" for this one, perhaps we... [13:08:11] (CR) Mepps: [C: +2] Set silverpop as default rather than required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597615 (owner: Eileen) [14:40:08] Fundraising Sprint Just space out, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): design edits for the payments maintenance page - https://phabricator.wikimedia.org/T253068 (mepps) [14:41:10] Fundraising Sprint Just space out, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): design edits for the payments maintenance page - https://phabricator.wikimedia.org/T253068 (mepps) We learned that the ContributionTracking extension is deployed to donatewiki so if we could do another... [15:00:46] (CR) Mepps: Don't update c_t rows with more than contribution_id (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [15:41:23] mepps: the magic happens in Common.js https://donate.wikimedia.org/wiki/MediaWiki:Common.js [15:41:38] that's loaded I think with the skin js [15:45:35] and... pcoombe has it all figured out [15:45:53] He's got a better-looking maintenance template for donatewiki [15:46:04] https://donate.wikimedia.org/wiki/Template:Lp-layout-maintenance [15:46:49] With the updated English text that has an end date/time [15:47:21] and he says he can make it use the strings from the FundraiserMaintenance page for translations in other languages [15:49:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Special:FundraiserMaintenance is not mobile friendly - https://phabricator.wikimedia.org/T253318 (Pcoombe) [15:53:23] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (DStrine) When do you need a decision on this? We need to do a bunch of coordination with @Ppena @jrobell @MeganHernandez_WMF... [16:17:36] Fundraising-Backlog, FR-AutoTY-Email: Civi: possible email_greeting TY email feature request - https://phabricator.wikimedia.org/T253326 (MBeat33) [16:19:16] (PS5) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [16:19:32] ok mepps, I added the extra check on changing a contribution_id ^^^ [16:21:49] cool ejegg [16:25:48] ejegg did you see my comment on the patch earlier? [16:25:59] oops, nope - looking! [16:26:46] it's minor but might help for code readability later [16:32:39] Fundraising Sprint Just space out, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): design edits for the payments maintenance page - https://phabricator.wikimedia.org/T253068 (mepps) From @Pcoombe > We just discussed this. Since the payments maintenance page is not mobile friendly (h... [16:34:49] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [16:40:41] (PS1) AndyRussG: Schema change: fix bool field for template banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/597827 [17:03:34] XenoRyet: looks like they never took off here due to fondness for collecting food waste! https://www.quora.com/Why-arent-garbage-disposal-units-prevalent-in-the-UK [17:04:03] and fear of adding to the fatbergs? [17:04:14] quite possibly ejegg! [17:05:40] (PS6) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [17:05:41] ok mepps, renamed that var ^^^ [17:05:51] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [17:31:24] fr-tech are we meeting in the alerts channel? [17:34:01] Yep, that's the plan. [17:34:08] I'll get the doc ready. [18:29:06] Fundraising Sprint Just space out, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): design edits for the payments maintenance page - https://phabricator.wikimedia.org/T253068 (DStrine) @Pcoombe the copy looks is good for MG. However Caitlin pointed out that the button at the bottom is... [18:42:27] Fundraising Sprint Just space out, Fundraising-Backlog: Update PayTM logo on India payment pages - https://phabricator.wikimedia.org/T249232 (DStrine) This is closable according to @EMartin [18:42:35] Fundraising Sprint Just space out, Fundraising-Backlog: Update PayTM logo on India payment pages - https://phabricator.wikimedia.org/T249232 (DStrine) Open→Declined [18:54:59] fr-tech did something change with our smashpig gerrit repo? I'm trying to composer install the crm project and I'm getting asked for gerrit username and passwords at the composer prompt which I've not seen before. It looks like out packagist page for smashpig is pointing to gerrit here https://packagist.org/packages/wikimedia/smash-pig and clicking on the gerrit link takes you to a not found [18:55:00] page [18:55:59] (CR) Mepps: [C: +1] "mostly looks good. a couple more minor comments on tests that aren't necessarily show stoppers." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [18:56:51] that is odd jgleeson [18:57:08] yeah feels like maybe temporary gerrit weirdness? [18:57:13] trying to work around it [18:57:36] jgleeson [18:57:40] yup [18:57:44] git clone with that link still works [18:57:58] so i think it's just not accessible through a web get request [18:58:13] not sure about why the repo is asking for credentials [18:59:02] yeah I've not seen that before [18:59:20] at the composer point [19:00:15] mepps: I wonder if your ssh key is being used when you git clone skipping the basic auth [19:00:46] although I guess you checked out using the https url [19:00:50] nope jgleeson it used https [19:01:02] exactly [19:03:20] yeah I just tried cloning locally and that worked also so this is annoying [19:03:24] lol :/ [19:05:48] are you sure that's the repo asking for credentials jgleeson? [19:10:14] mepps: https://phabricator.wikimedia.org/F31836121 that's what I'm seeing. [19:10:43] tried entering the username and password for fun and also updating composer but still no joy [19:10:57] weird jgleeson! [19:11:09] i just ran composer install in crm and had no issue [19:11:36] why is it @gerrit in the url? [19:11:42] hmm I wonder if my extra github remotes are causing an issue [19:12:31] mepps: so that's the basic auth url and it's empty there because I just clicked through to get past it [19:12:45] in an earlier one it had my username and pw starred out [19:12:54] ah okay [19:13:33] do you have a composer.lock file aleady jgleeson? [19:13:37] maybe try deleting that? [19:13:42] I'm not sure why civi just sudden stopped working [19:13:46] suddenly [19:14:16] I'll try that next mepps just waiting for composer update to finish [19:14:32] k gleeson [19:14:39] civi just stopped working jgleeson? [19:15:28] yeah before I started testing the ct patches the civi ui just stopped working for me and was showing a system status of alert [19:15:46] at some point it told me my version of civi was out of date but I can't seem to find that screen anymore [19:16:05] that's what lead me down the path of reinstalling / upgrading [19:17:52] it's been a few months since I've run into a civi upgrade skirmish so maybe it's just my time [19:20:15] jgleeson did you have a pre upgrade snapshot? [19:20:23] i'm pretty sure you're running into the same error i did with upgrade [19:20:28] from the task i shared in standup [19:21:43] mepps: yeah although I'm trying to composer install on the pre-upgrade snapshot [19:22:15] ah okay jgleeson [19:22:22] want to hop on a short call? [19:23:36] mepps: sure. today's standup ? [19:24:06] sure jgleeson [19:37:14] Fundraising Sprint Just space out, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): design edits for the payments maintenance page - https://phabricator.wikimedia.org/T253068 (DStrine) @Pcoombe One last edit. Can you make it: " 23:00 UTC May 29th" [19:48:34] (PS7) Ejegg: Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) [19:48:48] ok mepps, updated the tests ^^ [19:49:39] (CR) Mepps: [C: +2] Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [19:50:35] (CR) jerkins-bot: [V: -1] Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [19:52:11] (CR) Mepps: [C: +1] "Oops I was too fast" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [19:52:51] (CR) Mepps: [C: +1] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [19:53:52] ooh, what's jerkins-bot saying? [19:54:17] oh freaky, that email error again [19:55:57] ejegg: testing that patch locally its catching the id errors but would there ever be a situation on live where two entries could have the same contribution_id? thats the error I'm getting but I am making old globalcollect donations [20:01:57] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (EYener) To add to the context and background on this, it is often important to in Fundraising to report on impression rate (impressions / pagevi... [20:13:12] cstone ahh, that shouldn't happen! [20:13:17] I mean in production [20:13:47] So the contribution_id in practice generally comes from a contribution that has just now been added to the DB [20:14:08] and has gotten its new ID from the autoincrement on civicrm_contribution [20:17:17] ok thanks for explaining ejegg ! [20:20:47] mepps: so close! I just ran into the canary error :(, CRM_Core_Exception: Found installation canary. This suggests that something went wrong with tracking installation process. Please post to forum or JIRA. in Civi\Core\InstallationCanary::check() (line 37 of /vagrant/srv/org.wikimedia.civicrm/civicrm/Civi/Core/InstallationCanary.php). [20:20:54] but I think I can fix that [20:21:02] thank again mepps for working through that with me [20:21:12] ahh at least it's a new error jgleeson [20:21:17] i haven't seen that one [20:21:17] yep! [20:21:38] I feel like I've run into this one before and eileen told me a quick way to quiet the canary down [20:25:04] okay ejegg i took a pass at the ct documentation [20:25:11] i just mean editing the text [20:28:08] thanks mepps [20:29:38] also, looks like CI gave a V+2 on recheck here: https://gerrit.wikimedia.org/r/597608 [20:30:08] Thanks for the section headers! [20:57:32] (CR) Mepps: [C: +2] Don't update c_t rows with more than contribution_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597608 (https://phabricator.wikimedia.org/T253250) (owner: Ejegg) [21:01:04] Fundraising-Backlog: Implications of using Ingenico Dynamic 3DS in Ingenico Configuration Manager - https://phabricator.wikimedia.org/T253344 (Reedy) [21:15:39] Fundraising-Backlog: Gather information related to audit files and Civi import timings - https://phabricator.wikimedia.org/T253347 (RhinosF1) Please add project tags in the project tags field. I'm not sure if there's a reason you are using the subscribers field for it but all tasks should have a project tag... [21:19:39] Fundraising-Backlog, wikitech.wikimedia.org: Help accessing wikitech for CCogdill (WMF) - https://phabricator.wikimedia.org/T197264 (RhinosF1) [21:28:32] just killing process from dedupe [21:28:54] looks like number of contacts to check is really high [21:30:45] Fundraising-Backlog: Invalid Pares Decline Error - https://phabricator.wikimedia.org/T247023 (EMartin) Open→Resolved a:EMartin This seems to be related to 3DS declines. More transactions are getting through to the issuer/less abandonment and so we are seeing more Non Pares declines. I'm closing... [21:32:24] Fundraising-Backlog: Gather information related to audit files and Civi import timings - https://phabricator.wikimedia.org/T253347 (EMartin) My mistake! [21:32:39] MBeat: the runaway dedupe query was by 21041858 - I think the limit of contacts was just set too high [21:33:12] thanks, eileen I’ll let SH know [21:44:47] Fundraising-Backlog: Gather information related to audit files and Civi import timings - https://phabricator.wikimedia.org/T253347 (MBeat33) Thank you for this task, @EMartin Even benchmarking the different kinds of transactions //within// a given PSP would be super helpful. How long a manually-settled GC6... [21:46:03] !log civicrm revision changed from ed4c9522ac to b658fd8233, config revision is 9babae3954 [21:46:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:00:31] fr-tech does anybody feel like +2-ing the main c_t queue patch? [22:08:12] or should we do that monday morning? [22:08:19] thanks eileen! [22:10:54] ejegg im comfortable with what i tested but I think jgleeson had one more paypal test to do? [22:11:03] ejegg: is that so we can deploy it before tomorrow ? [22:11:32] ah yeah cstone I've fell down a rabbit hole looking into a bug with the latest update in civi [22:11:58] and still not wrapped up that test although I feel like it's probably not a blocker [22:12:30] you said the other paypal ones worked fine? [22:12:43] yep! the one time donation works as expected [22:12:59] and amazon one-time and recurring donations also work as expected [22:14:28] nice [22:18:33] Fundraising-Backlog: Implications of using Ingenico Dynamic 3DS in Ingenico Configuration Manager - https://phabricator.wikimedia.org/T253344 (Ejegg) @EMartin we just want to make sure we don't send donors through the 3DS flow inside an iframe. So if Ingenico chooses whether to show the 3DS flow instead of u... [22:18:57] jgleeson no, not at all - we're going to deploy the CRM changes monday [22:19:48] I'm happy to wait for then to +2 as well [22:24:20] ejegg: what version of drupal is civi on? [22:39:37] I have no objections to the +2 ejegg [22:44:15] dstrine it's 7.something [22:44:17] one sec [22:44:40] jgleeson oh i'm happy to wait till monday in case something else needs to go out today [22:45:37] dstrine maybe 7.69? [22:55:44] (PS1) Ejegg: Update to Drupal 7.70 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597885 [22:55:46] (PS1) Ejegg: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597886 (https://phabricator.wikimedia.org/T241809) [22:58:07] wat - nyan cat theme engine test? [22:58:25] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/drupal/+/597885/1/modules/simpletest/tests/themes/test_theme_nyan_cat/test_theme_nyan_cat.info [23:01:36] (PS2) Ejegg: Update to Drupal 7.70 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597885 [23:01:38] (PS2) Ejegg: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597886 (https://phabricator.wikimedia.org/T241809) [23:01:39] jgleeson ejegg +2ing the crm patch right? i would actually suggest waiting [23:02:24] mepps jgleeson yeah, actually there IS somthing that needs to go out before that [23:02:28] and for safety [23:02:32] good call [23:07:34] (CR) jerkins-bot: [V: -1] Update to Drupal 7.70 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597885 (owner: Ejegg) [23:08:57] nyancat++ [23:09:29] another classic [23:10:39] i'm amased at the number of random meme tunes my kids have learned on piano just by listening to it so much. [23:10:45] amazed even. [23:22:23] (CR) Ejegg: [C: +2] Update to Drupal 7.70 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597885 (owner: Ejegg) [23:22:28] (CR) Ejegg: [C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597886 (https://phabricator.wikimedia.org/T241809) (owner: Ejegg) [23:22:35] (CR) Ejegg: [V: +2 C: +2] Update to Drupal 7.70 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597885 (owner: Ejegg) [23:22:37] (PS1) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 [23:24:04] (PS1) Ejegg: Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597892 [23:24:16] (CR) Ejegg: [V: +2 C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/597886 (https://phabricator.wikimedia.org/T241809) (owner: Ejegg) [23:24:37] (CR) Ejegg: [C: +2] Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597892 (owner: Ejegg) [23:24:54] (CR) jerkins-bot: [V: -1] Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [23:25:05] (CR) jerkins-bot: [V: -1] Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597892 (owner: Ejegg) [23:27:19] (CR) Ejegg: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597892 (owner: Ejegg) [23:28:47] (PS2) Eileen: Set silverpop as default rather than required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597615 [23:30:09] (PS2) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 [23:32:56] (CR) jerkins-bot: [V: -1] Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [23:42:19] (Merged) jenkins-bot: Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597892 (owner: Ejegg) [23:42:43] ok, gonna deploy civi [23:43:56] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/597898 [23:44:06] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/597898 (owner: Ejegg) [23:48:23] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597663 (owner: Eileen) [23:49:47] ejegg: mepps in the process of looking at the next upgrade I found it had a slow query in it. I have commented it from the civi update & put it in here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/597663/ - in the hope we can run it separately some time next week. I also added a few index drops. If we aren't taking civi down there might not be an obvious time though [23:55:30] eileen: we will have civi down on Monday [23:58:19] !log updated civicrm from b658fd8233 to 6b1d5902dd [23:58:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log