[00:08:00] ah, now it works! [00:08:16] ok, signing off for the night [03:22:20] (PS1) Eileen: Update composer package for silverpop retrieval [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599152 (https://phabricator.wikimedia.org/T252247) [03:29:14] (CR) jerkins-bot: [V: -1] Update composer package for silverpop retrieval [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599152 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [03:33:39] (PS2) Eileen: Update composer package for silverpop retrieval [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599152 (https://phabricator.wikimedia.org/T252247) [05:06:09] (PS1) Eileen: Update omnimail-silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599157 (https://phabricator.wikimedia.org/T252247) [06:58:57] (PS3) Eileen: Update composer package for silverpop retrieval [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599152 (https://phabricator.wikimedia.org/T252247) [06:58:59] (PS2) Eileen: Update omnimail-silverpop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599157 (https://phabricator.wikimedia.org/T252247) [06:59:01] (PS1) Eileen: Supply default mailing_provider for Omnimailing.load [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599269 [06:59:03] (PS1) Eileen: Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) [07:06:50] (CR) jerkins-bot: [V: -1] Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [07:42:34] (PS3) Eileen: Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 [07:42:36] (PS6) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 [07:44:33] (CR) jerkins-bot: [V: -1] Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (owner: Eileen) [07:55:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: civicrm-buildkit doesn't composer update our wikimedia projects correctly - https://phabricator.wikimedia.org/T104031 (hashar) [08:19:40] (PS2) Eileen: Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) [08:33:34] (CR) jerkins-bot: [V: -1] Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [14:20:53] (CR) Ejegg: [C: -1] "Looks like a gz file snuck in there" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [14:22:27] (CR) Ejegg: [C: +2] Supply default mailing_provider for Omnimailing.load [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599269 (owner: Eileen) [14:26:13] (CR) Ejegg: [C: +2] "Composer change is valid, underlying library change looks good too." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599152 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [14:30:20] (Merged) jenkins-bot: Supply default mailing_provider for Omnimailing.load [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599269 (owner: Eileen) [14:32:41] (Merged) jenkins-bot: Update composer package for silverpop retrieval [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599152 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [14:43:07] (PS1) Cstone: Ignore recurring sepa direct debit IPNs. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/599350 [14:44:41] (CR) jerkins-bot: [V: -1] Ignore recurring sepa direct debit IPNs. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/599350 (owner: Cstone) [14:45:58] (PS2) Cstone: Ignore recurring sepa direct debit IPNs. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/599350 [14:57:34] Fundraising-Backlog, FR-AutoTY-Email: Civi: possible email_greeting TY email feature request - https://phabricator.wikimedia.org/T253326 (NNichols) @MBeat33 Yes we do get this request a lot. As of now I just manually change the Email Greeting field in civi and resend the TY via email. If there were a w... [15:03:27] Fundraising-Backlog, FR-AutoTY-Email: Civi: possible email_greeting TY email feature request - https://phabricator.wikimedia.org/T253326 (DStrine) For the record, I think I might be wrong on the Hebrew note. I do think there are one or two other languages/countries that have similar problems to Japanese... [15:36:34] looking at those IPNs now cstone [15:37:00] should be safe, since SEPA is only used for subsequent installments of recurring [15:37:10] i guess they had always been coming in i saw damaged messages from april too [15:37:14] yeah [15:40:37] but the sepa ones are what was causing the fail mail from yesterday/today [15:45:33] ok, so we don't need to send a RecordCaptureJob since the Civi extension sends the donations to the queue [15:45:48] right, it's like the case above [15:45:58] hmm, let's make that a bit clearer [15:48:09] (CR) Ejegg: "Looks like it works, but it might be clearer to have a function on the message that tells us whether it's a recurring installment. Just go" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/599350 (owner: Cstone) [16:22:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Deleted contacts and silverpop export questions - https://phabricator.wikimedia.org/T253062 (EYener) Hi @Eileenmcnaughton - I ran the CIDs (both deleted and kept) above through activities yesterday as a test, and I'm not getting the expec... [16:53:29] Wikimedia-Fundraising-Banners: Fundraising banner "remind me later" code should be more re-usable - https://phabricator.wikimedia.org/T162937 (Pcoombe) a:Pcoombe→None [16:54:58] tzag fr-tech [16:55:08] hi jgleeson [16:55:09] Greetings [16:55:15] hi jgleeson [16:55:23] hey all :) [16:55:36] I'm just starting and I feel ready for bed [16:56:05] spent the day so far cutting down trees with a chainsaw and didn't realise it would be such hard work [16:56:44] Man, chainsaws scare me too. I have a little one, but I only use it when it's the only tool that'll do the job. [16:57:25] It's not even that useful for me either, most of my trees are in the palm family and the chainsaws won't work on those. [16:57:43] fundraising-tech-ops: Document changes needed to bring up a new build host as full puppet master - https://phabricator.wikimedia.org/T248901 (Jgreen) [16:57:44] yeah mine is pretty small, 40cm blade. The wooddust and chippings were everywhere! [16:57:45] fundraising-tech-ops: set up frpm2001 as a full puppet master - https://phabricator.wikimedia.org/T247133 (Jgreen) [16:58:38] I was only chopping down smallish trees for my mum as practice for trimming my own which are 2-3 times bigger but now I'm not so confident [16:59:19] more of a tidy up! than chopping down actually [16:59:57] it's a first for us having trees and I didn't realise how much they like their space :) [17:00:11] Yea, they'll get away from you if you let 'em. [17:00:22] fundraising-tech-ops: fundraising tech operations GDPR tracking task - https://phabricator.wikimedia.org/T226749 (Jgreen) [17:10:55] arborists are cheaper than chainsaws and hospital bills. :) [17:16:09] Fundraising-Backlog, fundraising-tech-ops: Add syntax checking and linting to fr-tech-ops repos - https://phabricator.wikimedia.org/T253899 (Dwisehaupt) [17:19:34] fundraising-tech-ops, Operations: Long term storage for frack prometheus data - https://phabricator.wikimedia.org/T175738 (Jgreen) Open→Declined Closing this as wontfix because it appears to be a larger project than we want to take on due to prometheus's design limitations--both in terms of the d... [17:19:37] Fundraising-Backlog, fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562 (Jgreen) [17:23:21] fundraising-tech-ops: fundraising tech operations GDPR tracking task - https://phabricator.wikimedia.org/T226749 (Jgreen) [17:36:41] fr-tech I forgot to mention I revisited the https://github.com/rectorphp/rector, the thing I gave up trying to install a while back which does automagic refactoring of code according to rulesets and spotted that they have a PSR-4 refactoring set which I'm guessing will generate PSR-4 support so that might be useful if we can get it working on donation interface when we come to that task. [17:36:43] https://github.com/rectorphp/rector/tree/master/rules/psr4 [17:37:03] oh wow [17:37:17] so it namespaces things based on existing folders? [17:37:38] I can't confirm how it works, I'll try it out on a small project locally and see what it does [17:37:46] but hopefully it will save us some time [17:38:37] https://github.com/rectorphp/rector/blob/master/docs/rector_rules_overview.md#psr4 [17:39:05] ejegg: loks like it have a few optios [17:39:07] options [17:40:05] hmm, our gateway_common folder is pretty cluttered. I bet we can sort those into a few categories [18:04:22] cstone: Going to be a min or to late [18:04:27] no worries [18:15:07] Fundraising-Backlog, FR-AutoTY-Email: Civi: possible email_greeting TY email feature request - https://phabricator.wikimedia.org/T253326 (MBeat33) Hungarian is customary to use the surname in the salutation, I'm pretty sure. [18:31:23] fundraising-tech-ops: upgrade fundraising superset to 0.36 - https://phabricator.wikimedia.org/T253900 (Jgreen) [18:33:13] fundraising-tech-ops: upgrade fundraising superset to 0.36 - https://phabricator.wikimedia.org/T253900 (Jgreen) [18:57:21] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Research: Requirements for banner history processing for segmentation based on site usage - https://phabricator.wikimedia.org/T244882 (AndyRussG) Hi again @leila! I think the details of FR-Tech and Advancement priorities are still being worked... [19:17:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Research: Requirements for banner history processing for segmentation based on site usage - https://phabricator.wikimedia.org/T244882 (leila) Thanks for the update, @AndyRussG. We would be happy to support you with the questions you have or poi... [19:17:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Research-Backlog: Requirements for banner history processing for segmentation based on site usage - https://phabricator.wikimedia.org/T244882 (leila) [19:48:15] fr-tech prmetheus process-control failmail [19:48:39] why is jenkins creating that file :/ [19:48:46] Jeff_Green: dwisehaupt [19:49:18] jgleeson: sorry/yeah this is me debugging [19:49:29] looks like a permissions issue with prometheus files on civi1001 [19:49:33] ah [19:50:01] jgleeson: weird, now I don't see the failmail [19:50:07] ha! [19:50:08] yes, it's intentional--I'm trying to debug why prometheus is complaining about a timestamp in one of the hundreds of metrics it's collecting from those .prom files [19:50:17] because I unlocked it [19:50:34] ejegg: fr-software-engineers.wikimedia.org [19:50:55] I was locking the files one by one so the non-privileged processes that write them can't write them, so I can effectively remove them from the scraper's input [19:50:56] looks like that's the mailing list [19:51:22] oh tricky Jeff_Green [19:51:45] best I could figure out since prometheus doesn't say which metric is doesn't like [19:52:00] good news is I've narrowed it down to process_control.prom [19:52:47] which means it three of the 42 metrics in that file [19:54:28] what's prom saying about the timestamp out of interest? [19:54:33] can't process it [19:54:43] I remember time is weird is prometheus [19:55:08] msg="Error on ingesting samples that are too old or are too far into the future" num_dropped=4 [19:55:17] it' [19:55:25] it's alternating between 3 and 4 dropped [19:56:33] hmm [20:11:07] (PS4) Ejegg: Move Special:FundraiserMaintenance to DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) [20:13:01] (CR) jerkins-bot: [V: -1] Move Special:FundraiserMaintenance to DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) (owner: Ejegg) [20:19:39] (PS5) Ejegg: Move Special:FundraiserMaintenance to DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) [20:28:57] Fundraising-Backlog, fundraising-tech-ops: Prometheus metric collection warnings for civi1001 - https://phabricator.wikimedia.org/T250442 (Jgreen) I managed to narrow it down to civi1001:/var/spool/prometheus/process_control.prom which typically has 10-15 metrics timestamped older than 10 minutes. What I... [20:48:28] jgleeson: be aware chain saws can cause leg pain [20:48:58] I haven't yet kicked Richard in the shins for decimating the tree I like but.... [20:49:25] lol [20:49:55] I did read some scary issues that can be brought on by continued use due to the vibrations [20:51:03] looks like ingenico test env is having some issues [20:51:05] May 25 21:18:59 mwv ingenico_gateway: 2147340759:2147340759.4 RETURNED FROM CURL:{"errorId":"5ed023b31c82c5305adf2e9df266102b","errors":[{"code":"11000400","requestId":"509","message":"Server time-out","httpStatusCode":500}]} [21:15:51] (PS1) Jgleeson: Tell folks where ContributionTracking stuff happens [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599446 [21:17:37] Wikimedia-Fundraising-Banners: Banner remains visible after user enters a valid email and clicks submit - https://phabricator.wikimedia.org/T253147 (EWilfong_WMF) Proposed solution in this banner: https://en.wikipedia.org/wiki/Wikipedia?banner=Trilogy_mlWW_dsk_p1_lg_RMLTiming1&country=US. This only changes t... [22:16:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Deleted contacts and silverpop export questions - https://phabricator.wikimedia.org/T253062 (Eileenmcnaughton) @EYener you are right - I missed the fact it joins through the parent activity ` SELECT deleted.contact_id as deleted_contact_... [22:34:07] (PS3) Eileen: Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) [22:34:16] (CR) Eileen: "opps - now removed" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [22:41:24] (CR) jerkins-bot: [V: -1] Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [22:43:12] (PS1) Eileen: Looks like it's already merged so I don't need to link to my fork now [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599467 [22:43:21] well that was quick ^^ [22:43:28] (CR) jerkins-bot: [V: -1] Looks like it's already merged so I don't need to link to my fork now [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599467 (owner: Eileen) [23:11:30] hmm - not picking up the latest - not sure why [23:11:40] (Abandoned) Eileen: Looks like it's already merged so I don't need to link to my fork now [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599467 (owner: Eileen)