[00:23:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Readers-Web-Backlog (Tracking): Banner close button overlaps search controls on mobile - https://phabricator.wikimedia.org/T176092 (Jseddon) Open→Resolved [00:40:31] Fundraising-Backlog, MediaWiki-extensions-Other, Documentation: [FundraisingTranslateWorkflow] Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996 (Jseddon) p:Triage→Lowest [08:30:59] Fundraising-Backlog, FR-Ingenico, Fr-planning-ahead: Apple Pay Spec - ingenico - https://phabricator.wikimedia.org/T228944 (Aklapper) @Emartin, @DStrine: The `Due Date` set for this open task is more than a month ago. Can you please either update or reset the Due Date (by clicking {nav icon=pencil, n... [12:31:26] Fundraising-Backlog, fundraising-tech-ops: python3 modules for frdb1003 - https://phabricator.wikimedia.org/T247981 (EYener) Resolved→Open @Jgreen could you also add the time module, please? [12:31:30] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (EYener) [14:05:02] Fundraising-Backlog, FR-Ingenico, Fr-planning-ahead: Apple Pay Spec - ingenico - https://phabricator.wikimedia.org/T228944 (EMartin) [15:11:37] Fundraising-Backlog, FR-Ingenico, Fr-planning-ahead: Apple Pay Spec - ingenico - https://phabricator.wikimedia.org/T228944 (DStrine) [15:11:52] Fundraising-Backlog, FR-Ingenico, Fr-planning-ahead: Apple Pay Spec - ingenico - https://phabricator.wikimedia.org/T228944 (DStrine) fixed, thanks [15:43:40] Fundraising-Backlog, fundraising-tech-ops: Prometheus metric collection warnings for civi1001 - https://phabricator.wikimedia.org/T250442 (Jgreen) Open→Resolved a:Jgreen Modified process_control_collector to exclude results that are more than 5 minutes old. Since this script runs every minut... [16:19:11] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Patch-For-Review: Move FundraiserMaintenance to DonationInterface - https://phabricator.wikimedia.org/T253057 (Ejegg) @Nikerabbit and... [16:23:00] tzag fr-tech! [16:23:12] jgleeson: hellooo [16:23:27] hi jgleeson [16:30:07] hellos :) [16:35:33] howdy jgleeson [16:37:01] cstone: in the old-to-new script, line 221 of the most recent PS, where it says "civicrm_api3('ContributionRecur', 'create', $cancel);" [16:37:12] are you sure it should say 'create' there? [16:37:52] grepping about, in RecurringQueueConsumer.php, I see this: $cancelStatus = civicrm_api3('ContributionRecur', 'cancel', [ [16:38:37] (CR) Raimond Spekking: [C: +1] "i18n review" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) (owner: Ejegg) [16:39:21] yeah the create if you give it an id it updates instead AndyRussG [16:39:55] I modeled it after recordFailedPayment in the SmashpigRecurringProcessor [16:41:03] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Patch-For-Review: Move FundraiserMaintenance to DonationInterface - https://phabricator.wikimedia.org/T253057 (Raymond) @Ejegg Contri... [16:41:07] cstone: ah okok thanks! interesting...... [16:49:03] Fundraising-Backlog, fundraising-tech-ops: python3 modules for frdb1003 - https://phabricator.wikimedia.org/T247981 (Jgreen) Open→Resolved Closed b/c 'time' is part of core python, no need to install anything. [16:49:07] Fundraising-Backlog, fundraising-tech-ops: Fundraising Analytics Infrastructure and Setup - https://phabricator.wikimedia.org/T238395 (Jgreen) [16:53:37] howdy dwisehaupt :) [16:53:59] hi jgleeson [16:54:06] howdy ejegg :) [16:55:11] good news fr-tech, the translation cabal is all set with their side of the 'move fundraiserMaintenance' patch: https://gerrit.wikimedia.org/r/c/599079 [16:55:37] so if ^^^ and the parent patch look good we can merge them [16:57:20] cabal :) [17:02:42] AndyRussG: so in Civi, just about every entity has a 'create' action [17:03:24] which doubles as an 'update' action if you send in the 'id' field [17:04:05] the ContributionRecur entity also has a 'Cancel' action - let's see what else it does besides just setting that status [17:04:32] I feel like it didn't give us the control we wanted maybe [17:17:14] interesting, the 'cancel' api action creates an activity record [17:17:40] so are we / should we be creating our own activity record in the SmashPig Civi extension? [17:18:30] werent we talking about doing that? [17:21:36] or is there a downside to having the activity records? [17:22:41] cstone I think we do want them [17:22:44] err [17:22:48] well, in the extension [17:23:07] maybe not for the old-to-new switch [17:23:17] since nobody's actually cancelling anything [17:24:16] ahhh, it looks like we only create those records in the queue consumer when it's a contribution cancelled by donor [17:24:46] in paypal IPN term, a subscr_cancel and not a subscr_failed [17:25:02] or subscr_eot [17:25:09] ahh i see [17:25:16] ejegg: cstone: hummm [17:25:41] So using 'create' as update is a core civi thing, not a WMF-civi-extension thing? [17:25:42] so that could be a justification - only create the cancel activity when it's a conscious decision [17:26:00] AndyRussG: right, core civi allows that for just about any entity [17:26:50] ejegg: hmmm okok just out of curiosity, not important, I guess civi documents that as a standardpractice somehwere? [17:28:46] AndyRussG: let's see [17:30:06] https://docs.civicrm.org/dev/en/latest/api/v3/actions/ [17:30:16] "Most entities support the following actions: [17:30:16] create [17:30:17] Insert or update one record. (Note: If an id is specified, then an existing record will be modified.)" [17:30:48] delete, get, and getsingle are the other generally-supported actions [17:30:54] ejegg: oh cool! thanks!! :) [17:51:20] (CR) Mepps: "I think a comment drifted in here that was from another patch." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) (owner: Ejegg) [17:52:37] mepps ah yeah, I can put that comment on the parent patch [17:58:24] (PS4) Ejegg: Stop referencing ContributionTracking db connection [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599078 (https://phabricator.wikimedia.org/T86253) [17:58:26] (PS6) Ejegg: Move Special:FundraiserMaintenance to DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) [17:59:29] ok, moved. It might not have a lot to do with the parent patch either, but it was while looking at the failing tests on the parent patch that someone asked me to note that side effect [17:59:37] and... gonna help with lunch [18:19:05] ejegg cstone the Ingenico doc for CONVERT_PAYMENTTOPROFILE says to first call INSERT_ORDERWITHPAYMENT [18:19:19] (pdf that ejegg e-mailed) [18:19:47] Then the doc for INSERT_ORDERWITHPAYMENT says, "This API call combines an API: INSERT_ORDER and an API: DO_PAYMENT" [18:20:06] So I guess we already have done that with the previous calls to make the recurring charges on the old system? [18:22:29] Grepping about I don't see those exact strings in civi or SmahsPig though [18:26:34] thats how I understand it AndyRussG but im not sure the exact calls the old system used, the recurring_globalcollect.module is calling Recurring_Charge but thats not in their documentation [18:27:14] it should be in the recurring_globalcollect module somewhere [18:28:00] cstone: right... I mean, so I guess the old Ingenico doc really should just say, this has to have happened previously, so it's just unclear, no? [18:28:20] What would be the point of converting something if it weren't recurring though? [18:28:33] yeah maybe the Recurring_charge call calls those [18:29:30] maybe to just have the token if you want to save peoples cards ? [18:33:23] Hmmm no idea [18:34:20] cstone: in any case it's been smoke tested all the way through as is and has worked, right? (Sorry if this has been mentioned more than once before, just checking 100% that I'm remembering right...) [18:35:00] yeah the only thing I havent been able to replicate is creaking a new token, all the test card numbers return tokens that have already been created [18:35:04] creating* [18:35:37] but since it is returning properly when it already exists I expect it to create new ones fine too [18:44:56] cstone: ah ok gotcha... And the rollout plan is to try it with a batch size of 1 first, right? [18:47:06] yep [19:09:30] cstone ejegg sorry to be so weedsy for a one-time script here... Just wondering, how does civi know that in the call to $newRecurring = civicrm_api3('ContributionRecur', 'Create', $createrecurring) [19:09:36] on line 210 [19:09:49] that this new recurring is going through the new system [19:09:56] looking [19:09:59] but that civicrm_api3('ContributionRecur', 'create', $cancel); [19:10:03] on line 221 [19:10:07] is cancelling a thing from the old system [19:10:24] I just don't see any params that say which processor each is for, but I'm sure I'm just confused [19:11:04] the old system still used ContributionRecur just had RECURRING GLOBALCOLLECT as the trxn_id [19:11:30] also didnt have a token_id tied to them [19:12:19] payment_token_id [19:14:24] there's also the payment_processor_id [19:18:22] ejegg cstone so right payment_processor_id comes in on $payment_token_result as does payment_token_id [19:19:03] yeah, payment_processor_id is the modern, proper way to tell Civi which payment processor is responsible for the payment [19:19:11] as opposed to a trxn_id prefix [19:19:19] ok hmmm [19:19:24] and we get that from wmf_civicrm_recur_payment_token_create() [19:19:28] though the trxn_id still needs to be globally unique [19:19:51] which gets processorId from wmf_civicrm_get_payment_processor_id($gateway); [19:20:19] ah, ok, so it already does the lookup from the string [19:20:22] So basically by specificying ingenico as the gateway on line 133 [19:20:24] makes sense [19:20:58] all the calls that get stuff from $payment_token_result will have contents that indicate the new ingenico [19:22:06] in this script, yeah [19:22:39] but we also make payment_token table entries for adyen recurring [19:23:01] fr-tech is anyone using chrome 83? [19:23:19] jgleeson: not I [19:23:22] i've got it installed [19:23:28] mostly just using it for google meet [19:23:34] want me to test something? [19:23:48] jgleeson ? [19:24:22] ejegg: I'm getting a bunch of mixed content https/http errors on paymentswiki [19:24:41] looks like a bunch of stuff is getting loaded in via http [19:24:44] ooh, that shouldn't happen [19:24:46] looking [19:24:56] not live ejegg [19:24:57] cstone what was the model u followed again for the call to wmf_civicrm_contribution_message_import ? [19:24:58] locally [19:25:18] let me find it AndyRussG [19:25:51] hmm, i see a 404 on the favicon.ico when loading the ingenico card form [19:25:56] in RecurringQueueConsumer::importSubscriptionPayment() maybe? cstone [19:27:00] yeah either that or the DonationQueueConsumer [19:27:02] jgleeson but I'm not seeing any mixed content [19:27:18] jgleeson: which form are you loading to see those issues? [19:27:26] oh, and is it after the iframe opens? [19:28:50] sry I'm digging around [19:28:57] lemme upload a screengrab [19:29:28] https://phabricator.wikimedia.org/F31850306 [19:30:08] What's new in Chrome 83. We broke your site [19:31:00] It's possible I'm entirely to blame for this tho so I'll hold back dissing Chrome for now [19:58:37] Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) Possibility for tech debt improvement No PSP code in Drupal 7, mostly in DI or SmashPig Queue rewrites are the major challenge Challenges: limited downtime availability next year **Likely to require at least... [19:59:15] Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) Could we start converting custom code to civi extensions to prepare? The less drupal dependent we are, the easier this would go. [20:08:39] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Payments should only send new contribution tracking messages if something changes - https://phabricator.wikimedia.org/T253602 (jgleeson) a:jgleeson [20:22:37] Fundraising-Backlog, FR-AutoTY-Email: Civi: possible email_greeting TY email feature request - https://phabricator.wikimedia.org/T253326 (mepps) Have we gotten any feedback about whether options 1 or 1a work for this? [20:43:47] mepps: https://en.wikipedia.org/wiki/Skipping_rope#Double_under [20:44:04] there's also an 'Awesome Annie' skip/jump! [20:44:26] https://en.wikipedia.org/wiki/Skipping_rope#Awesome_Annie [20:46:36] it is pretty awesome https://www.youtube.com/watch?v=mr7XAsJkrKo [20:54:54] ejegg: it looks like we're still lagging behind in vagrant land on stretch and there isn't an official ticket to upgrade to buster although a few users are reporting failures when testing stuff with buster so it's something on the radar [20:56:58] jgleeson oh shoot, that's disappointing [20:57:07] I wonder how big a lift that'll be [20:57:16] lots of config changes needed? [21:00:04] ejegg: I it's pretty straightforward just to pull in another image, that takes place around here. https://github.com/wikimedia/mediawiki-vagrant/blob/master/Vagrantfile#L71 [21:00:10] I think* [21:00:28] I guess we'd need to then just test then once built [21:00:52] I'll build a buster vm tomorrow and see how it goes [21:03:32] nice! [21:03:55] I wonder if the docker folks already have that covered [21:17:41] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Dwisehaupt) [21:17:56] that chrome bug looks like a red herring. It's trying to load drupal files when hitting paymentswiki which sounds like something is broke in the local web server space [21:20:04] (CR) Ejegg: [C: +2] Ignore recurring sepa direct debit IPNs. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/599350 (owner: Cstone) [21:20:16] looks good cstone ^^^ [21:20:22] thanks ejegg ! [21:20:22] jgleeson oh weird [21:20:38] (Merged) jenkins-bot: Ignore recurring sepa direct debit IPNs. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/599350 (owner: Cstone) [21:49:44] hmm restoring back to a version of my vm prior to running the latest vagrant provisioning stuff fixed it which i guess means it's a problem for the future :\ [21:51:00] I was testing out running single puppet modules, specifically just the crm module, when testing this patch https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/599456/ [21:51:09] which reminds me [21:53:08] if folks ever want to just provision a single puppet module instead of provisioning the entire puppet catalog relating to roles applied, you can edit this file https://github.com/wikimedia/mediawiki-vagrant/blob/09ddf4ac12d75a7ceb7954d7539245bba70a5c45/puppet/manifests/site.pp#L56 and just replace the hiera_include('classes') call with the name of the module you want to provision in isolation [21:53:09] e.g. include ::crm [21:53:42] myself and mepps were digging into that the week before last [22:01:16] nice jgleeson [22:11:51] fundraising-tech-ops: clean up payments-wiki configuration related to deprecated mysql contribution tracking connection - https://phabricator.wikimedia.org/T253653 (Dwisehaupt) This is staged in the branch contrib_tracking_cleanup_T253653 on the main puppet repo. This should not be pushed until the extension... [22:57:20] (PS11) Jgleeson: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) [22:57:22] (PS7) Jgleeson: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) [22:57:24] (PS1) Jgleeson: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) [22:57:59] (PS4) Eileen: Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) [22:59:07] (PS2) Jgleeson: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) [23:00:30] (PS3) Jgleeson: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) [23:19:15] I'm having a composer meltdown - since they merged my Pr I'm trying to remove my repo [23:19:15] but I keep getting the old commit [23:19:16] "url": "https://github.com/mrmarkfrench/silverpop-php-connector.git", [23:19:16] + "reference": "318ff74e6564d1c251b1df41ef4001f7b472bf6f" [23:19:17] https://github.com/mrmarkfrench/silverpop-php-connector [23:35:18] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [23:43:22] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 3 others: CiviCRM regular upgrade - https://phabricator.wikimedia.org/T254205 (Eileenmcnaughton)