[00:46:29] (CR) Ejegg: Move Special:FundraiserMaintenance to DonationInterface (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/599079 (https://phabricator.wikimedia.org/T253057) (owner: Ejegg) [00:49:29] (PS4) Eileen: Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (https://phabricator.wikimedia.org/T254205) [00:50:22] (PS7) Eileen: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (https://phabricator.wikimedia.org/T254205) [00:51:41] (CR) jerkins-bot: [V: -1] Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [00:55:03] (PS2) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598907 (https://phabricator.wikimedia.org/T230064) [00:55:05] (PS5) Eileen: Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598904 (https://phabricator.wikimedia.org/T230064) [00:55:07] (PS3) Eileen: Temporary hobble on non-English [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598905 (https://phabricator.wikimedia.org/T230064) [00:55:09] (PS2) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [01:01:44] (CR) jerkins-bot: [V: -1] Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598907 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:01:51] (CR) jerkins-bot: [V: -1] Temporary hobble on non-English [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598905 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:02:02] (CR) jerkins-bot: [V: -1] Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598904 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:02:04] (CR) jerkins-bot: [V: -1] Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [02:51:46] (PS1) Eileen: Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) [02:55:59] (CR) jerkins-bot: [V: -1] Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [03:07:29] (PS2) Eileen: Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) [03:11:50] (PS3) Eileen: Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) [03:19:16] (CR) jerkins-bot: [V: -1] Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [04:30:14] (PS4) Eileen: Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) [04:30:16] (PS1) Eileen: Add apiv4 FailureEmail.render api & use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601577 (https://phabricator.wikimedia.org/T252247) [04:32:01] (PS1) Eileen: Backport Apiv4 ContributionRecur [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/601578 (https://phabricator.wikimedia.org/T230064) [04:36:51] (PS2) Eileen: Add apiv4 FailureEmail.render api & use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601577 (https://phabricator.wikimedia.org/T252247) [04:37:19] (CR) jerkins-bot: [V: -1] Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [04:37:59] (CR) jerkins-bot: [V: -1] Add apiv4 FailureEmail.render api & use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601577 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [04:43:57] (CR) jerkins-bot: [V: -1] Add apiv4 FailureEmail.render api & use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601577 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [06:55:18] (CR) AndyRussG: [C: +2] "Woohooooooooo!!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [07:01:43] (Merged) jenkins-bot: Drush script to tokenize old recurring GC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/582883 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [14:46:49] Fundraising-Backlog: Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MNoorWMF) [14:47:12] Fundraising-Backlog: Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MNoorWMF) p:Triage→High [14:50:51] oh hey, ^^^ is an easy fix. They even provided the translation [14:53:26] dstrine the volunteer translators just hadn't gotten to that one yet [14:53:32] it's easy to add it directly too [14:53:41] and the translatewiki sync works both ways [14:53:44] ah lol [14:53:46] will have a patch in a sec [14:53:50] ok thanks! [14:54:11] Fundraising-Backlog: Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (DStrine) this is getting fixed right now [14:54:23] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog: Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (DStrine) [14:54:27] that 'por correo electrónico' seems redundant in context, but ehh [14:55:00] redundant Spanish is still better than english [14:55:09] congrats on the merge cstone [14:55:32] woooo [14:56:22] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog: Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (mepps) It seems to be missing from a few files, here's where it's present in the interface directory: ./gateway_common/i18n/interface/sv.js... [14:56:38] (PS1) Ejegg: Add Spanish translation for email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601754 (https://phabricator.wikimedia.org/T254252) [14:56:59] mepps ^^^ adds it for es [14:57:17] (CR) Mepps: [C: +2] Add Spanish translation for email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601754 (https://phabricator.wikimedia.org/T254252) (owner: Ejegg) [14:57:21] thanks! [15:00:18] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601755 [15:08:35] tzag fr-tech! [15:08:59] hi jgleeson ! [15:09:22] (CR) jerkins-bot: [V: -1] Add Spanish translation for email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601754 (https://phabricator.wikimedia.org/T254252) (owner: Ejegg) [15:09:27] hmph [15:10:21] oh crap [15:11:31] I thought Raymond was just going to deregister ContributionTracking for translate sysc [15:11:34] *sync [15:12:03] but that test failure was because it couldn't clone ContributionTracking from gerrit [15:12:25] dang, and I don't have force merge in this repo [15:12:33] eek Spanish emails are out in the wild [15:12:44] who do we need to contact? [15:13:08] i'll ask in -releng [15:17:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_warning 1 [=1],GlobalCollect_endpoint_critical 2 [=1],Paypal_endpoint_critical 2 [=1] [15:18:02] (CR) Hashar: "Gerrit fails to serve the ContributionTracking repo:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601754 (https://phabricator.wikimedia.org/T254252) (owner: Ejegg) [15:18:09] hmm. that's a bunch of things breaking at once ^^^ [15:18:57] endpoints? Would that be out connectivity then? [15:20:08] yeah, or DNS or something. looking [15:22:10] RECOVERY - check_log_messages on frav1002 is OK: OK [15:25:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe suggestion: track down OG contact records for "new" donors - https://phabricator.wikimedia.org/T238156 (CCogdill_WMF) @MNoorWMF will be taking the lead on this! We will need to make a change to all urls in all templates which will take a bit of t... [15:28:24] (CR) Ejegg: [C: +2] "Recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601754 (https://phabricator.wikimedia.org/T254252) (owner: Ejegg) [15:30:17] (Merged) jenkins-bot: Add Spanish translation for email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601754 (https://phabricator.wikimedia.org/T254252) (owner: Ejegg) [15:30:55] ok, I guess it was just a transient error on gerrit [15:31:11] that was just coincidentally in serving the repo we're about to delete [15:31:20] so, carrying on with the deploy merge [15:32:19] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (Jgreen) p:Triage→High a:Ottomata→None [15:33:47] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601755 (owner: Ejegg) [15:34:33] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601755 (owner: Ejegg) [15:36:02] okok, now for the mw branch update [15:39:38] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601777 [15:41:03] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601777 (owner: Ejegg) [15:41:49] Fundraising-Backlog: graceful handling of donors when payments wiki does not offer a payment option - https://phabricator.wikimedia.org/T254259 (DStrine) [15:44:47] merged; deploying [15:44:56] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (Jgreen) [15:46:51] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (Jgreen) Kafkatee configuration change is deployed. The rest is in progress. [15:47:11] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601777 (owner: Ejegg) [15:48:02] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601777 (owner: Ejegg) [15:51:04] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (ayounsi) [15:53:55] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601777 (owner: Ejegg) [15:54:25] Fundraising-Backlog, FR-AutoTY-Email: Civi: possible email_greeting TY email feature request - https://phabricator.wikimedia.org/T253326 (SHust) I added this thread to the DS vs Creative team meeting agenda on 6/3 so we should have a response soon. [15:54:52] actually merged [15:54:54] deploying [15:56:46] fr-tech im going to deploy the ideal recurring ipn check [15:57:20] (PS1) Cstone: c266da3 Ignore recurring sepa direct debit IPNs. [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/601780 [15:57:34] !log updated payments-wiki from d11efeb1cf to 1942a537ef [15:57:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:58:31] whoops out of order [15:58:56] (PS2) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/601780 [16:00:16] sounds good cstone ! [16:50:30] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/601780 (owner: Cstone) [16:51:13] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/601780 (owner: Cstone) [16:55:49] !log SmashPig revision changed from 44690f761c to b9de3c7aac [16:55:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:41:08] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (Ejegg) This is deployed and shows up fine. It does stretch into a second line though. I could... [17:56:29] fundraising-tech-ops: fundraising tech operations GDPR tracking task - https://phabricator.wikimedia.org/T226749 (DStrine) [17:58:08] Fundraising-Backlog: Code review Clone Campaign - https://phabricator.wikimedia.org/T254268 (DStrine) [17:59:06] Fundraising Sprint Kavascript: the chill new language: Code review for banner filter settings - https://phabricator.wikimedia.org/T254269 (DStrine) [18:00:43] Fundraising-Backlog: Code review for banner filter settings - https://phabricator.wikimedia.org/T254269 (DStrine) [18:05:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe donors before creating new contact - https://phabricator.wikimedia.org/T254270 (DStrine) [18:14:57] fr-tech it looks like we need to truncate utm_ fields before insert in the c_t queue consumer [18:15:02] I'll make a quick patch [18:19:27] ejegg: sounds good. I saw the failmail on that and wasn't sure if we wanted to trim those [18:20:10] ejegg: jgleeson: don't a lot of extra data bits sometimes get concatenated onto those? [18:20:23] IIRC some years ago hearing something about that [18:20:55] AndyRussG: I've seen some pretty long ones [18:21:25] although I haven't checked out the one which caused the error [18:21:36] AndyRussG: yeah, it's kinda messy [18:21:43] let's take a look at the erroring ones [18:22:14] oh, they don't end up in damaged? [18:22:20] I guess it's just a warning? [18:23:16] or maybe we're completely losing the message :( [18:27:33] pretty sure the previous code was just truncating without warning [18:47:03] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MNoorWMF) adding @MSuijkerbuijk_WMF to confirm if this is okay. Mariana, Elliot suggests rem... [18:55:03] Fundraising-Backlog: Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 (Pcoombe) [19:02:52] Fundraising Sprint Just space out, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team, and 2 others: SecurityCheck-XSS Suppressed in CentralNotice for Geotargeting - https://phabricator.wikimedia.org/T251269 (AndyRussG) @sbassett @Daimona @mepps @Aklapper @DStrine Thanks much!!!! [19:28:55] (PS1) Ejegg: Set adyen-usd form to 1 weight [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601834 (https://phabricator.wikimedia.org/T254274) [19:29:34] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [19:29:51] fr-tech does this look safe? T254274 [19:29:52] T254274: Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 [19:29:56] https://gerrit.wikimedia.org/r/601834 [19:30:04] oops, meant to past that link ^^ [19:30:08] *paste [19:30:34] It looks like any of those countries should have a higher-weight other form even after changing from 0 to 1 [19:45:08] fundraising-tech-ops: upgrade fundraising superset to 0.36 - https://phabricator.wikimedia.org/T253900 (Jgreen) upgrade procedure: [] commit but don't merge these changes to puppet/modules/superset/manifests/init.pp - $druid_enabled = false, + $druid_enabled = true, - $gunicorn_app = 'sup... [19:46:27] (CR) Cstone: [C: +2] Set adyen-usd form to 1 weight [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601834 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [19:48:55] (Merged) jenkins-bot: Set adyen-usd form to 1 weight [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601834 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [19:51:36] Fundraising-Backlog, GlobalUserPage, MediaWiki-extensions-CentralNotice: CentralNotice banner goes behind of global user page's top menu buttons - https://phabricator.wikimedia.org/T175865 (AndyRussG) [19:54:08] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601840 [20:37:35] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (Jgreen) Open→Resolved a:Jgreen done except for data recovery [20:57:32] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MarcoAurelio) OT re image in the description: The phrase `Monto De La Donación` is orthograph... [21:02:16] hi ejegg - you around? [21:02:38] in a meeting, but what's up hauskatze ? [21:03:16] ejegg: trying to correct translations re the picture at T254252 [21:03:17] T254252: Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 [21:03:33] hauskatze: it should be all set, no? [21:03:33] We don't use CamelCase [21:03:48] ah, I see [21:03:49] and "Monto" in Europe sounds very weird [21:04:09] We use that like 'monto a caballo' -> 'I ride a horse' [21:04:15] not very natural ;-) [21:04:28] I fixed some at translatewiki.net but cannot find those two [21:04:47] hmm, does it show up with uselang=qqq ? [21:05:31] where? paymentswiki? [21:05:35] huh, nope [21:17:07] Jeff_Green: dwisehaupt [21:17:14] oops sorry I meant to cancel that [21:17:21] heh. :) [21:17:35] I was gonna ask a question about grafana but I figured it out [21:17:52] I meant to post this [21:17:54] / FIXME: this constant is for test code [21:17:56] const DUMB_BIG_TY_DAYS = 100000; [21:17:58] another gem [21:18:16] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/54ebf9af442adaf2997c87d22c2e7c67fa888b66/sites/all/modules/thank_you/thank_you.module#L18 [21:18:43] ok so where does that code write the prometheus stats [21:18:50] that's what I'm interested in [21:19:15] i spent time trying to figure out the quantile_over_time function to seee if we could get some useful data out of there. [21:19:16] as I think somewhere around there is the data used for the graph cstone was linking to in the meeting [21:21:09] maybe line 419? [21:25:31] i would be interesting to look at metrics per transaction. ie having each transaciton logging the timings as it goes through the process. that's a huge undertaking to get started though. [21:34:10] dwisehaupt: good spot! [21:56:47] (PS1) Ejegg: Shorten es email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601879 (https://phabricator.wikimedia.org/T254274) [21:59:54] fr-tech another trivial i18n fix for tomorrow's test ^^^ [22:00:27] (CR) Cstone: [C: +2] Shorten es email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601879 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [22:00:38] thanks cstone [22:00:45] no problem [22:01:41] Tests: 483, Assertions: 4790, Errors: 2, Failures: 16, Risky: 1. ! [22:01:51] wooooo jgleeson ! [22:02:39] wow [22:07:52] (Merged) jenkins-bot: Shorten es email-explain [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601879 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [22:32:59] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/601894 [22:34:21] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/601894 (owner: Cstone) [22:40:59] (CR) Cstone: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/601894 (owner: Cstone) [22:48:01] !log civicrm revision changed from d1cd99166f to 657c4b9455 [22:48:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:48:57] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [22:54:07] (PS1) Ejegg: Truncate contribution_tracking data before insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 [22:59:23] eileen: ejegg did we recently rejig contribution statuses? It looks like locally I have failed when it should be cancelled [22:59:44] recurring contribution statsues* [22:59:59] for recuring contributions? a while back they were separated into a separate option group [23:00:12] I think both are valid [23:00:23] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9c506460374369ea25cffc6f690944ab7ec09e95/sites/all/modules/recurring_globalcollect/tests/RecurringGlobalCollectTest.php#L268 [23:00:41] that test is failing and I think it might be due to my local data [23:01:06] it's returning 'Failing' instead of the expected Cancelled [23:01:09] (CR) jerkins-bot: [V: -1] Truncate contribution_tracking data before insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 (owner: Ejegg) [23:02:40] (PS2) Ejegg: Truncate contribution_tracking data before insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 [23:09:27] hmm looks unrelated [23:09:35] thanks! [23:09:48] (CR) jerkins-bot: [V: -1] Truncate contribution_tracking data before insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 (owner: Ejegg) [23:10:11] jgleeson hmm, could it have to do with the failure_count? [23:11:22] stepping through that one now ejegg [23:12:44] (PS3) Ejegg: Truncate contribution_tracking data before insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 [23:12:44] cstone oops, another bad index [23:12:52] but PS3 should be good [23:12:56] its the inception [23:20:46] that was tricky [23:22:47] it looks like we may have broken the mastercard fine check [23:22:59] if I remember this correctly [23:23:05] https://phabricator.wikimedia.org/F31851641 [23:23:27] that check on line 267 is failing because the PaymentError class is now the smashpig lib one [23:23:52] even though the error code is in the list force cancel codes [23:24:14] if so, why isn't this causing civi to fail on CI? [23:27:14] Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.35 - https://phabricator.wikimedia.org/T254298 (Ejegg) [23:28:07] ooh, dang! [23:28:40] good catch, and good question [23:28:55] and good grief, it's late where you are! [23:29:03] 4 left [23:29:13] I can't quit now [23:29:35] although it looks like that one will need a patch unrelated to vagrant stuff [23:30:36] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601903 [23:30:53] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601840 (owner: Ejegg) [23:31:01] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601903 (owner: Ejegg) [23:31:29] ehh, too lazy to squash em [23:31:36] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601840 (owner: Ejegg) [23:32:03] ejegg truncating and in happily in the db [23:32:13] \o/ [23:32:13] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/601903 (owner: Ejegg) [23:32:46] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601904 [23:32:50] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601904 (owner: Ejegg) [23:34:19] fr-tech, the old globalcollect recurring stuff in crm is a soon to be a relic right? [23:34:32] yep jgleeson [23:35:15] (CR) Cstone: [C: +2] "Looks good, truncating!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 (owner: Ejegg) [23:35:31] hmmm I guess I should still tidy that up [23:35:38] I'll make a ticket [23:38:08] Fundraising-Backlog: Old globalcollect recurring force cancel behaviour not working - https://phabricator.wikimedia.org/T254303 (jgleeson) [23:39:00] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/601904 (owner: Ejegg) [23:41:32] (Merged) jenkins-bot: Truncate contribution_tracking data before insert [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601901 (owner: Ejegg) [23:47:58] cstone: so I'm going to deploy the crm repo [23:48:14] ok i did do it earlier too [23:48:21] ah cool [23:49:30] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/601907 [23:50:25] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/601907 (owner: Ejegg) [23:51:43] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/601907 (owner: Ejegg) [23:55:18] !log updated payments-wiki from 1942a537ef to e46114d8b1 [23:55:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:56:24] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (Ejegg) OK, I just deployed the shorter version of the email field explanation. [23:57:02] Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09): Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 (Ejegg) Deployed! [23:58:30] !log updated fundraising CiviCRM from 657c4b9455 to eb156dffa4 [23:58:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log