[00:23:57] Fundraising-Backlog: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (KHaggard) [00:43:14] (PS1) Eileen: Add FailureEmail.send api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601918 (https://phabricator.wikimedia.org/T252247) [00:46:49] (PS2) Eileen: Add FailureEmail.send api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601918 (https://phabricator.wikimedia.org/T252247) [00:47:24] (PS1) Mepps: WIP: Begin link for previewing and sending failed recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [00:47:58] (CR) jerkins-bot: [V: -1] Add FailureEmail.send api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601918 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [00:48:27] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [00:54:25] (CR) jerkins-bot: [V: -1] WIP: Begin link for previewing and sending failed recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [01:17:22] (CR) Mepps: [C: +2] Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:17:26] (CR) Mepps: [C: +2] Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:18:30] (CR) Mepps: [C: +2] Backport Apiv4 ContributionRecur [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/601578 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:19:19] (CR) jerkins-bot: [V: -1] Stock 5.26 rc CiviCRM [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:19:21] (CR) jerkins-bot: [V: -1] Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:19:23] (CR) jerkins-bot: [V: -1] Backport Apiv4 ContributionRecur [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/601578 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:26:04] (CR) Mepps: [V: +2 C: +2] "we will need to combine this wit" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:26:17] (CR) Mepps: [V: +2 C: +2] "the patch above to get CI to pass" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597414 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:26:50] (CR) Mepps: [C: +2] "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:33:54] (Merged) jenkins-bot: Remaining wmf hacks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/597415 (https://phabricator.wikimedia.org/T254205) (owner: Eileen) [01:34:05] woot [02:20:29] eileen :) [02:25:38] (PS1) Eileen: Submodule update civicrm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601926 [02:27:05] (CR) Eileen: [C: +2] Submodule update civicrm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601926 (owner: Eileen) [02:34:30] (Merged) jenkins-bot: Submodule update civicrm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601926 (owner: Eileen) [02:41:22] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [04:03:20] (PS4) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 [04:09:42] (CR) jerkins-bot: [V: -1] Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [04:18:13] (PS5) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 [04:19:47] (PS6) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 [04:35:08] (PS1) Eileen: Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) [04:42:36] (CR) jerkins-bot: [V: -1] Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [04:48:34] (PS2) Eileen: Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) [05:04:42] (Abandoned) Eileen: Add FailureEmail.send api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601918 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [05:04:54] (Abandoned) Eileen: Add apiv4 FailureEmail.render api & use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601577 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [05:53:33] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (elukey) @Jgreen should we add also monitors to prevent this from happening again? [06:04:12] (Abandoned) Eileen: Add base test class for smash pig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601544 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [06:04:36] (Abandoned) Eileen: Temporary hobble on non-English [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598905 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [06:04:47] (PS2) Eileen: WIP: Begin link for previewing and sending failed recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [06:05:10] (Abandoned) Eileen: Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598904 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [06:05:39] (Abandoned) Eileen: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598907 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [06:11:53] (CR) Eileen: "mepps note I rebased this as I squashed mine as they were getting messy" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [07:19:06] (CR) Raimond Spekking: "This was reverted by the l10n-bot with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/601965/ because changed" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601879 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [08:05:14] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MSuijkerbuijk_WMF) @Ejegg @MNoorWMF I don't think that works because I understood that we n... [08:07:38] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MSuijkerbuijk_WMF) @MNoorWMF I agree with @MarcoAurelio --Monto does not work in Spain, Spani... [11:21:56] Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09): Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 (Pcoombe) Open→Resolved a:Ejegg Looks good now, thanks! [12:16:57] Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09): Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 (Pcoombe) Resolved→Open Actually @spatton pointed out that now if a gateway isn't specified, US one-time defaults to Adyen, which isn't t... [13:08:45] fundraising-tech-ops: upgrade fundraising superset to 0.36 - https://phabricator.wikimedia.org/T253900 (Jgreen) Open→Resolved a:Jgreen Done! [13:32:01] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [14:53:33] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [14:58:14] hi fr-tech! [14:59:57] hi ejegg [15:00:37] oh hey, the meeting that was going to start now just disappeared! [15:01:15] fr-tech, anything I should send out to scrum-o-scrums? [15:16:23] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (Ejegg) I got a comment on my patch directly updating the message, asking to do translations t... [15:25:10] hey fr-tech ejegg cstone :) [15:25:16] ejegg: thanks, nothing here! [15:25:17] hi AndyRussG! [15:25:25] hi AndyRussG [15:32:14] fundraising-tech-ops: adjust fundraising firewalls and kafkatee configuration to accomodate new kafka brokers kafka-jumbo100[789] - https://phabricator.wikimedia.org/T254257 (Jgreen) >>! In T254257#6187560, @elukey wrote: > @Jgreen should we add also monitors to prevent this from happening again? We didn't... [15:45:39] (PS3) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [15:46:46] fr-tech there's a request for us to review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/598470 [15:46:53] (in scrum-o-scrums) [15:53:56] (CR) jerkins-bot: [V: -1] WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [15:58:56] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MarcoAurelio) Hi @Ejegg - I submitted some updates to translatewiki.net yesterday and those w... [16:12:09] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/602111 [16:13:13] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/602111 (owner: Ejegg) [16:19:58] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/602114 [16:27:11] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/602114 (owner: Ejegg) [16:32:18] Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Schema-change: CentralNotice: Deploy new regional geotargeting and banner template features - https://phabricator.wikimedia.org/T252596 (AndyRussG) [16:36:41] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/602111 (owner: Ejegg) [16:59:31] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/602114 (owner: Ejegg) [17:07:12] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/602114 (owner: Ejegg) [17:15:02] !log updated payments-wiki from e46114d8b1 to c1d14a5db7 [17:15:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:15:33] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (Ejegg) Thanks @MarcoAurelio ! I've just deployed those updates. [17:19:15] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (ovasileva) Need icon and url [17:19:39] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (ovasileva) [17:27:58] (PS4) Ejegg: Matching gifts extension with fetch API [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/596777 (https://phabricator.wikimedia.org/T249922) [17:28:00] (PS4) Ejegg: Add custom matching gift fields in installer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597300 (https://phabricator.wikimedia.org/T249924) [17:29:00] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:31:06] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:32:58] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:36:51] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:44:50] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:45:52] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:49:29] Fundraising-Backlog, FR-Smashpig: Use idempotency headers in payment processing requests - https://phabricator.wikimedia.org/T243967 (Ejegg) [17:51:35] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MarcoAurelio) @Ejegg Thanks. Is there any HTML that makes the titles to use CamelCase? See h... [17:56:10] fundraising-tech-ops, observability, Epic: [Epic] overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508 (Jgreen) [17:56:12] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [17:56:51] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02): Spanish translation in Paymentswiki missing - https://phabricator.wikimedia.org/T254252 (MNoorWMF) Thank you Elliot! [17:58:45] fundraising-tech-ops: improve banner logger and kafkatee monitoring - https://phabricator.wikimedia.org/T254382 (Jgreen) [18:43:54] (PS1) Ejegg: Scheduler test for running later in day [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602128 [18:45:12] (PS2) Ejegg: Scheduler test for running later in day [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602128 [19:06:01] mepps: can you rebase over this - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/601945/ - I squashed my commits as they were getting messy [19:09:36] sure eileen [19:18:53] mepps: I like small commits but it was to the point where my commits were changing previous commits substantially [19:24:46] fr-tech that smashpig recurring failmail is from the one charge from old to new, I updated the date in civi so itll stop [19:25:12] thanks! [19:32:45] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (CCogdill_WMF) Adding my notes here from our meeting just now with fr-tech and MGF to confirm next steps for email integration. I'm adding @MNoorWMF and @KHaggard to this t... [19:34:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create a job to send automatic matching gifts emails - https://phabricator.wikimedia.org/T249926 (CCogdill_WMF) Per my update on the parent task T228765, I think this task description needs to be updated to instead **Create a job to export HEP data to A... [19:35:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create template for automated matching gift email - https://phabricator.wikimedia.org/T249925 (CCogdill_WMF) Per my comment on the parent task T228765, I don't think fr-tech owns this portion of the task. Should we keep it open and have someone from my... [20:03:15] Fundraising-Backlog: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (CCogdill_WMF) p:Triage→High Thanks so much for catching this, Katie! This seems like a big deal so I am setting the priority at High. Katie noted that one possible implication is w... [20:03:34] hey eileen we still have our call on the calendar, did you want to chat again? [20:03:56] i'm making some slow and steady progress today :) [20:03:56] sure [20:04:11] cool, i'm there [20:08:32] fr-tech eyener jkumalah hi! for any of you who may have used the Jupyter notebook analytics servers, here's a reminder that any data you left there is about to disappear! :) https://phabricator.wikimedia.org/T249752 [20:09:37] thanks AndyRussG ! [20:09:50] ejegg: :) [20:20:49] (PS4) Mepps: WIP: Begin link for previewing and sending failed recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [20:21:43] (PS1) Eileen: Update extended report for datepicker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602151 [20:23:45] (PS5) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [20:31:16] (CR) Mepps: [C: +2] Update extended report for datepicker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602151 (owner: Eileen) [20:37:37] (Merged) jenkins-bot: Update extended report for datepicker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602151 (owner: Eileen) [20:41:34] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/602157 [20:42:48] (PS1) Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 [20:43:02] (PS3) Mepps: Send message from failed recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:43:42] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/602157 (owner: Eileen) [20:43:43] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [20:44:06] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/602157 (owner: Eileen) [20:45:32] (CR) jerkins-bot: [V: -1] build: Bump phan to 0.10.2, remove taint-check [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 (owner: Umherirrender) [20:46:22] (PS2) Umherirrender: build: Bump phan to 0.10.2, remove taint-check [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 [20:46:43] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [20:49:41] ejegg: jgleeson finally testing this last change, was the frequency installment supposed to be sending in as 0? or 1 is okay and it was the fact it was missing [20:49:56] !log civicrm revision changed from eb156dffa4 to 63508b01b9, config revision is 95dcdb0a8a [20:49:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:50:08] (PS7) Mepps: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:50:10] (PS4) Mepps: Send message from failed recurring if smashpig_recurring_send_failure_email set to true. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:50:26] (CR) jerkins-bot: [V: -1] Send message from failed recurring if smashpig_recurring_send_failure_email set to true. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:51:58] (CR) jerkins-bot: [V: -1] Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:52:23] cstone: I think it should have been 1 [20:52:52] so I guess it was the fact it was missing [20:53:04] or more precisely it was in a lower level of the array? [20:53:19] yeah it was lower [20:53:22] thanks jgleeson [20:53:24] np [20:53:29] i see it now where its checking 1 > 0 [20:54:26] (PS6) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [20:55:37] ejegg: is that matching gifts extension create pr still good to review or did today change stuff? [20:55:57] (PS3) Mepps: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:55:59] (PS7) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [20:56:17] eileen: no, it's good to review [20:56:22] ok cool [20:56:33] the automated emails are a ways in the future, the stuff in review is very basic [20:57:03] (PS1) Cstone: Switch the params sent to getDateForNextMonth to now send a frequency_interval. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602162 (https://phabricator.wikimedia.org/T169357) [21:01:21] eileen: do you have a couple of minutes? I'm struggling getting this test to pass locally https://github.com/wikimedia/wikimedia-fundraising-crm/blob/5f7efca165f4115f22f680d967883bd824c60563/sites/all/modules/wmf_civicrm/tests/phpunit/MergeTest.php#L597 looks like the merge api is sending back a conflict on the optin field which then results n a skipped merge (due to safe mode?) and I'm [21:01:23] confused as that looks like what should happen. [21:05:00] argh looks like you're in a meeting, sorry! It can wait [21:05:39] fr-tech that patch up a bit should fix the next_sched issue with old to new [21:07:36] (PS2) Ejegg: Switch the params sent to getDateForNextMonth to now send a frequency_interval. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602162 (https://phabricator.wikimedia.org/T169357) (owner: Cstone) [21:07:42] (CR) Ejegg: [C: +2] Switch the params sent to getDateForNextMonth to now send a frequency_interval. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602162 (https://phabricator.wikimedia.org/T169357) (owner: Cstone) [21:08:08] thanks ejegg [21:08:23] cstone: my case sense is tingling [21:08:29] i know haha [21:08:31] :) [21:08:40] how did AndyRussG miss that one :P [21:08:57] (CR) jerkins-bot: [V: -1] Switch the params sent to getDateForNextMonth to now send a frequency_interval. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602162 (https://phabricator.wikimedia.org/T169357) (owner: Cstone) [21:09:37] you can retry that I think [21:09:39] 22:08:30 ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") [21:10:26] cstone: ooohhh nice catch... and, ooops!!! ;p [21:10:34] classic [21:10:51] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602162 (https://phabricator.wikimedia.org/T169357) (owner: Cstone) [21:11:02] 100% classic indeed [21:15:09] jgleeson: do I need to do something else to make it redo the CI? [21:16:01] hmm you don't normally need [21:17:42] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (Jgreen) [21:18:15] I have a vague memory of needing to drop the jenkins vote when this gets hung up [21:18:24] hmm me too [21:18:49] just clicking on the x then? [21:19:24] give it a go [21:19:48] if that doesn't work maybe drop jenkins as a reviewer and readd it [21:20:08] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (Jgreen) [21:20:14] oo hey jenkins has come back [21:20:18] +2 cstone [21:20:40] oh no you removed the +2 :O [21:20:48] haha it was a -1 when I clicked it D: [21:20:51] haha [21:21:05] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602162 (https://phabricator.wikimedia.org/T169357) (owner: Cstone) [21:21:18] let's try recheck again and hope jenkins can let it slide :) [21:21:19] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (Jgreen) [21:21:52] ill wait a bit longer this time haha [21:23:36] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (Jgreen) [21:25:13] the jenkins gods are capricious [21:26:53] they are i can see it in zuul this time at least [21:28:47] yay [21:29:08] (づ￣ ³￣)づ [21:30:41] (◕‿◕✿) [21:31:14] huh, gate-n-submit passed but it didn't submit? [21:31:22] we can just plain click submit then [21:31:47] * ejegg submits [21:34:17] there was some user error ejegg [21:36:43] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/602172 [21:37:41] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/602172 (owner: Cstone) [21:41:22] (CR) Cstone: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/602172 (owner: Cstone) [21:43:47] !log civicrm revision changed from 63508b01b9 to 11b0e7c7e5 [21:43:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:44:32] Fundraising-Backlog, fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (Jgreen) [21:49:27] fr-tech im going to move another one over [21:53:18] 2020-07-03 00:00:00 wooo [21:53:22] success! [21:55:02] yay! [21:55:09] nice work [21:56:18] nice! [21:57:37] yay! [22:12:58] (PS1) Ejegg: Delete miscommitted file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602179 [22:13:44] oh wait, ^^^ might be a real thing after all [22:13:50] fr-tech I moved over 10 and they all look good [22:13:55] great cstone! [22:14:48] eileen I guess .github dir is supposed to be checked in? [22:14:58] I can abandon that patch then [22:15:18] I want to do them in larger groups to get all todays moved over but are we waiting on that? [22:17:45] should we maybe wait till we see a second recur on one? [22:18:34] well i know it triggers properly cause of the error earlier :p but wait a month then? [22:21:21] i guess thats on the task, so turn the old job back on then? [22:28:43] yeah, let's turn the old job on [22:28:55] ok I just pushed to process control if you want to check [22:29:08] i fell victim to my own naming conventions.... [22:29:20] ejegg: didn't you run into this issue a few weeks back with the smashpig global config [22:29:23] 1) DonationInterface_Adapter_GatewayAdapterTest::testConstructor [22:29:25] Error: Call to a member function getGlobalConfiguration() on null [22:29:58] a whole bunch of my DI tests are complaining about it [22:34:15] jgleeson oh? [22:34:28] And you're on the latest CRM ? [22:35:01] That happened on an early version of the patches to move to the sequence generator and c_t queue [22:35:19] but then I updated the tests to make sure the smashpig context object was always set up [22:36:09] Ahhh, maybe the vagrant box is using a newer version of donationinterface-the-composer-library ? [22:36:18] so there are more tests that will need upgrading [22:36:39] given that it's a test which touches gatewayAdapter, that's probably it [22:36:57] so... we are overdue for a composer update in crm anyway [22:37:15] most serious might be that we're on a version of phpmailer that's EOL [22:39:04] so we should update the DonationInterface library at the same time and fix those tests [22:39:24] hmm, but before we do that I'd like to get the bits that depend on ContributionTracking merged [22:40:30] https://gerrit.wikimedia.org/r/599078 in particular fixes the way it would get existing c_t rows when running under drupal [22:44:12] (PS1) Jgleeson: WIP: CiviCRM test fixes. This patch accompanies a mw-vagrant patch which fixes some default CiviCRM settings. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602185 [22:46:09] ejegg: I'm running the tests from donation interface [22:46:11] (CR) jerkins-bot: [V: -1] WIP: CiviCRM test fixes. This patch accompanies a mw-vagrant patch which fixes some default CiviCRM settings. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602185 (owner: Jgleeson) [22:47:01] ohh... [22:47:13] with which patch? [22:47:53] it was one of the matching gift frontend patches but then I tested master and got the same list [22:48:09] lemme push up a rebased version of the matching gifts patch to see if they happen on CI [22:49:37] (PS12) Jgleeson: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) [22:53:02] (CR) Eileen: [C: +2] Delete miscommitted file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602179 (owner: Ejegg) [22:53:48] (PS8) Jgleeson: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) [22:53:55] (PS4) Jgleeson: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) [22:56:30] ejegg: I can go either way on the .github folder [22:57:07] we'll need to add a gititgnore at some point if we want to keep it out [23:00:40] oh, got it. It is meant to be in the upstream git repo though? [23:03:13] yes - it causes PRs that are stale to be labelled & eventually closed [23:03:46] -> which is less rude that just closing them & saying 'I don't care about this' :-) [23:12:36] eileen: have you ever seen this failure on CI https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/2640/console (right at the bottom) [23:12:52] 00:02:53 1) BitpayFileTest::testImport [23:12:54] 00:02:53 Failure in api call for Contact delete: You have requested a non-existent service "prevnext.driver.". Did you mean one of these: "prevnext.driver.redis", "prevnext.driver.sql"? [23:13:11] I fixed that locally by setting the prenext driver to SQL but I haven't run into it before on CI [23:13:35] it looks like it's happening due to cleaning up import records after the test [23:14:18] cstone: congrats! [23:16:42] jgleeson: hmm - I haven't seen it before in tests - are we doing cleanup in a deconstruct? [23:17:16] yeah we're clearing out some imported contacts in the bitpay import test [23:17:36] well we add them to the base test class here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/602185/1/sites/all/modules/offline2civicrm/tests/BitpayFileTest.php [23:18:24] and then that list gets cycled through for deletion here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9c506460374369ea25cffc6f690944ab7ec09e95/sites/all/modules/wmf_common/tests/includes/BaseWmfDrupalPhpUnitTestCase.php#L64 [23:18:58] I ran into the same prevnext.driver bug locally and fixed it by setting that setting in civicrm to SQL. [23:20:01] on live I think the settings is under System Settings > Misc and set to Default(auto) [23:20:07] -s [23:23:46] jgleeson: do we have redis installed on the CI server [23:24:27] ejegg: FYI - I put this helper class into civi core - https://github.com/civicrm/civicrm-core/blob/master/Civi/Test/GuzzleTestTrait.php - which will be in the next release [23:24:55] oh nice! [23:27:33] eileen: I just checked on here and I can't see any mention of redis https://github.com/wikimedia/integration-config/tree/master/dockerfiles/civicrm [23:28:24] I guess that's it then - we've just tested under mysql to date I suppose [23:30:02] I'm pretty sure we use the tearDown stuff in https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9c506460374369ea25cffc6f690944ab7ec09e95/sites/all/modules/wmf_common/tests/includes/BaseWmfDrupalPhpUnitTestCase.php#L64 in a few other places [23:30:17] is there something specific about the bitpay stuff that invokes redis? [23:31:51] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, and 6 others: Test migrating old ingencio recurring to new ... - https://phabricator.wikimedia.org/T232017 [23:34:00] jgleeson maybe the smashpig library isn out of date? [23:34:05] *is out of date [23:34:10] or there's [23:34:18] something in the test that's not being mocked? [23:35:00] ejegg: is this in response to the earlier stuff [23:35:42] I wanted to see what CI made of the patches but it looks like I've locked zuul in a loop [23:36:06] with a Depends-On header [23:36:17] so just gonna try fixing that before I jump off [23:37:58] so is it this line causing the fail ? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/602185/1/sites/all/modules/offline2civicrm/tests/includes/BaseChecksFileTest.php [23:39:10] probably we have been increasingly not using the Fixtures due to it being a bit tricksie [23:40:57] yeah eileen that would lead to the BaseWmfDrupalPhpUnitTestCase->civicrm_api('Contact', 'delete', Array) calls [23:43:47] hmm maybe I should poke around more in that class to see why it causes the prevnext stuff to wake up [23:44:20] or I guess I could just delete the contacts at the db level via clean up [23:47:17] g'night!