[02:02:19] hey eileen, should the render api call return the message text? i assumed it woudl but it's currently not for me [02:02:52] mepps: if the template exists it should - works in the test but I haven't proven on staging yet - trying now [02:03:05] so i imported the template eileen [02:03:20] here's what i see returned: ‌Civi\Api4\Generic\Result::__set_state(array( [02:03:20] 147 => [02:03:20] array ( [02:03:20] 'msg_subject' => 'Test, renew your monthly donation to Wikipedia [02:03:20] ', [02:03:21] 'email' => 'pantha@wikimedia.org', [02:03:21] 'display_name' => 'Test Es', [02:03:22] 'language' => NULL, [02:03:22] ), [02:03:23] )) [02:03:47] hmm - so subject & no html - that's odd [02:04:12] (side thing - I can't get civicrm dir on staging 'clean' because you own ' ang/exportui/export.html') [02:05:13] argh sorry! although why i own that directory makes no sense to me [02:05:32] no - I'm not sure -maybe you can set your umask to 002 [02:07:44] at the moment i'm trapped under a cat but i can do that when i can get my yubikey [02:09:24] lol - I think if we can merge cividatastrings it might help with the stale thing - should be safe as it doesn't 'do' anything so we can still patch further [02:09:24] eileen it looks like Message::render() only returns the subject [02:12:07] hmm - on staging it's not returning much for me [02:15:49] mepps: this just worked locally for me - cv api4 FailureEmail.render '{"contributionRecurID":677}' [02:15:58] eileen i chmoded that directory on staging [02:16:16] interesting eileen [02:17:30] but not working on staging yet [02:20:19] mepps: you do have data in the tpl? [02:20:27] eileen trying to figure that out [02:20:44] was the text file meant to be a .txt.txt or .text.txt? [02:20:53] in hthe html field? civicm_message_template where workflow_name = recurring_failed_message [02:20:56] that shouldn't amtter though [02:21:31] locally eileen did you you use your template import patch or did you create the template? [02:21:41] okay i'll use that sql [02:21:46] i was just curious if it was the update [02:21:53] I can't recall [02:22:27] ah it's not on staging - let's check what I ran there [02:28:35] mepps: now I'm not seeing msg_html on staging - checkinng [02:29:15] eileen i see what happened [02:29:22] it's a missing "e" :) [02:35:15] lol [02:35:44] pretty stingy for someone with 3 e's to shortchange an e :-) [02:36:18] i'm fixing it eileen :) [02:36:30] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/602204/ [02:36:36] thanks - then you will be mpps [02:36:37] i can also squash that into the ealrier commit [02:36:49] oof you'd iln [02:37:04] mepps: did you pick up my rebase? [02:37:12] patch looks like maybe not? [02:37:16] argh [02:37:53] we might be best to merge the 2 extension ones if we are comfortable they won't 'do anything' [02:40:17] urghhhh [02:40:31] i deleted some of my work from earlier today and lost the commit by accident... [02:40:39] i got tangled in branches... [02:41:01] eileen is there a way to find a commit that's not in a branch anymore? [02:41:56] i clearly need to go to bed here [02:43:35] mepps: git reflog [02:45:41] thank you eileen [02:45:49] lifesaver [02:46:00] also this git craziness makes me think i need sleep [02:46:39] i'll start tomorrow by getting everything re-rebased eileen [02:47:16] cool - I'm just gonnna manually db update on staging & see if I can generate an email [02:47:34] & then maybe look at the test bug hurting Jack [02:48:09] sounds good eileen [02:48:54] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [02:58:14] mepps: I just generated an email - it seems to be sending text not html [02:59:21] I'm still gonna look at Jack's test now for a change of scenery [03:18:44] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, and 4 others: Civi mail To, CC, BCC email additions diffcul... - https://phabricator.wikimedia.org/T248199 [12:25:28] fundraising-tech-ops: donate.wikimedia.org mail feedback loop routing is broken - https://phabricator.wikimedia.org/T254468 (Jgreen) [12:37:57] fundraising-tech-ops: donate.wikimedia.org mail feedback loop routing is broken - https://phabricator.wikimedia.org/T254468 (Jgreen) Looks like a syntax error was introduced to /etc/postfix/virtual in commit b393b08c06d66c /^dmarc@donate\.wikimedia\.org>/ dmarc [14:12:16] fundraising-tech-ops: donate.wikimedia.org mail feedback loop routing is broken - https://phabricator.wikimedia.org/T254468 (Jgreen) Open→Resolved a:Jgreen Postfix configuration fixed, waylaid feedback mail moved to dmarc user and processed. [14:38:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Matching gifts should not update contribution_tracking to point to new contribution - https://phabricator.wikimedia.org/T254487 (Ejegg) [14:38:48] fr-tech ^^^ is probably the root cause of the current failstorm [15:03:47] Hey! [15:05:47] hi eljohnny [15:10:45] Haha, that moment when you're not sure if you joined the correct channel...thanks for confirming I made it Christine! :) [15:12:08] hah np [15:21:46] tzag fr-tech [15:21:54] woah looks like we've had a failmail wave [15:22:02] ah I see ejegg is already on it [15:22:07] hi jgleeson [15:22:12] hey cstone :) [17:26:13] (PS6) Mepps: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [17:26:15] (PS3) Mepps: Fix msg_text in template file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602204 [17:26:17] (PS11) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [17:31:27] (PS4) Mepps: Fix msg_text in template file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602204 (https://phabricator.wikimedia.org/T230064) [17:32:09] (PS12) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [18:21:53] right let's get that patch up [18:22:08] I cooked my second hellofresh meal during the staff meeting [18:22:30] the advised 20 minutes cooking time was off by about 20 minutes :) [18:26:16] wait, it was instant? wow [18:26:39] oh sorry I meant it was short 20 minutes [18:26:42] so 40 in all [18:27:11] yesterdays recipe said 40 minutes but took more like 80 [18:27:19] so I'm seeing a pattern forming :) [18:27:51] (PS3) Umherirrender: build: Updating composer dependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 [18:30:03] (CR) jerkins-bot: [V: -1] build: Updating composer dependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 (owner: Umherirrender) [18:32:08] (PS4) Umherirrender: build: Updating composer dependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 [18:36:54] (CR) Jforrester: [C: +2] build: Updating composer dependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 (owner: Umherirrender) [18:54:27] (Merged) jenkins-bot: build: Updating composer dependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/602158 (owner: Umherirrender) [19:23:46] (PS13) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [19:51:38] Fundraising-Backlog: large quantity of bounce messages in the civimail "ignored" bucket - https://phabricator.wikimedia.org/T254513 (Jgreen) [19:59:27] (PS1) Jgleeson: WIP: Add check to contribution import to stop matching gift contributions from updating the contribution tracking contribution id. Let's keep the original contribution id in that case. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602474 [20:01:26] (PS2) Jgleeson: WIP: Add check to contribution import to stop matching gift contributions from updating the contribution tracking contribution id. Let's keep the original contribution id in that case. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602474 [20:02:05] (PS3) Jgleeson: WIP: Add check to contribution import to stop matching gift contributions from updating the contribution tracking contribution id. Let's keep the original contribution id in that case. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602474 [20:02:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (LeanneS) [20:02:58] ejegg: sorry it took so long I was running tests on civi before pushing up. https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/602474/ [20:03:18] I've mark it as WIP as I think you'll do a better job adding a comment to our new check fn [20:03:23] marked [20:06:20] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [20:23:21] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [20:28:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (DStrine) @EYener actually just volunteered to pull this. Fr-tech will need to do the import. Let us know when you need our help! [20:28:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (DStrine) a:EYener [20:35:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (LeanneS) Cool! Thanks so much @EYener! [20:42:28] (PS14) Mepps: WIP: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) [20:46:24] thanks jgleeson ! [20:47:44] jgleeson those comments look fine to me [20:48:02] If you wanna un-WIP that I'd be happy to +2 [20:52:07] sure! [20:53:45] (PS4) Jgleeson: Add check to contribution import to stop matching gift contributions from updating the contribution tracking contribution id. Let's keep the original contribution id in that case. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602474 [20:55:37] (CR) Jforrester: [C: +2] Parse messages in string context [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/598205 (owner: Umherirrender) [20:59:26] fr-tech, not the usual song/album recommendation but I've been listening to this on repeat for most of the day and would recommend it highly! https://www.youtube.com/watch?v=jnoGiLDGneY [21:07:33] (CR) Ejegg: [C: +2] Add check to contribution import to stop matching gift contributions from updating the contribution tracking contribution id. Let's keep the [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602474 (owner: Jgleeson) [21:12:13] nick jgleeson|away [21:15:06] (Merged) jenkins-bot: Add check to contribution import to stop matching gift contributions from updating the contribution tracking contribution id. Let's keep the original contribution id in that case. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602474 (owner: Jgleeson) [21:42:50] (Merged) jenkins-bot: Parse messages in string context [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/598205 (owner: Umherirrender) [22:00:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (Eileenmcnaughton) @EYener if you are outputting a csv just be mindful it needs a few BOM characters at the start for utf-8 support in mysql. I can fish out the details fo you [22:02:58] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [22:28:05] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (EBjune) Nuria, the approach we're taking is that we want to move data into Advancement's version of superset. Can you please designate someone t... [22:42:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (EYener) Adding query for transparency and any future needs: ` SELECT DISTINCT c.contact_id, contact.nick_name, contact.first_name, contact.last_name, a.street_address, a.supplemental... [22:45:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (Eileenmcnaughton) @EYener also exclude based on opt in & out? This is what we used last time ` INSERT INTO civicrm_group_contact (group_id, status, contact_id) SELECT $groupID, '... [23:42:07] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Nuria) @EBjune : @Jgreen is already working on that on this ticket: {T251890} there is no action needed on analytics as all the works is on the...