[10:03:37] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (ovasileva) [11:37:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Amazon_endpoint_critical 1 [=1] [11:42:12] RECOVERY - check_log_messages on frav1002 is OK: OK [12:24:48] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Pcoombe) If it's possible to change the URL in some way to distinguish it from the desktop sidebar link, that would be reall... [13:46:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Major Gifts Events Related - Importing Activities at the same time when new importing contacts - https://phabricator.wikimedia.org/T254751 (RLewis) [15:16:38] hello fr-tech! [15:17:16] ejegg: :) [15:17:25] how's it going AndyRussG [15:17:26] ? [15:17:35] ejegg: ehhhh not too bad [15:17:39] hi ejegg AndyRussG [15:17:44] cstone: :) [15:18:02] hi cstone! How's things upstate? [15:18:14] To get a faster start in the morning, I left a little thing of coffee next to my bed [15:18:40] like I used to do when getting up at 5 am to work on my thesis, though this time it was 9 am [15:18:52] still helpful, I think [15:19:15] hmm, cold coffee? [15:19:32] bit chilly this weekend but turtles started moving to lay eggs on friday so had some good turtle finding [15:28:10] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [15:33:16] cstone: cool! heh when I first read your message ^ I was like, hmmm Colorado mountain turtles? but no, Colorado turtles don't lay eggs at this time of year [15:33:33] or any time of year, I guess [15:33:39] haha they might I have seen a snapping turtle in colorado [15:33:55] oh ok! hmmm I had no idea [15:35:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Major Gifts Events Related - Importing Activities at the same time when new importing contacts - https://phabricator.wikimedia.org/T254751 (DStrine) a:DStrine→None [15:36:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (DStrine) [15:37:24] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09): Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 (DStrine) [15:38:19] oh damn [15:38:26] US defaulting to adyen? [15:38:35] I didn't see that locally [15:38:43] what's up, gatewayformsettings? [15:40:29] oh hell, it's because of the multitude of submethods [15:40:42] https://en.wikipedia.org/wiki/Common_snapping_turtle [15:41:58] grrrrr, so we can either do a lot of messing around with the form settings to make them match the actual options [15:42:06] or refactor the dang chooser [16:22:20] Fundraising-Backlog: Flowchart all incoming data from non fundraising sources - https://phabricator.wikimedia.org/T254783 (DStrine) [16:54:01] (PS1) Ejegg: Explode out Adyen form settings by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/603540 (https://phabricator.wikimedia.org/T254274) [16:57:10] Fundraising Sprint Kavascript: the chill new language, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Patch-For-Review: Not getting Adyen gateway for one-time US donations - https://phabricator.wikimedia.org/T254274 (Ejegg) Dang, the RapidHTML-era logic strikes again. The formset... [16:57:31] fr-tech can anyone help review ^^^ ? [16:59:16] ejegg: https://gerrit.wikimedia.org/r/603540 no? My brain is totally in a different space but I could hop on that in about 1hr? or is it super urgent? [16:59:28] I suggest you verify empirically that the cards for each country correspond to the new settings [16:59:43] AndyRussG: something we want to get out today, not necessarily within the hour [17:00:17] K how about I ping here when i get to it, but if someone else wants to check it out sooner, that's also good? [17:02:42] tzag fr-tech :) [17:02:57] jgleeson: hellosie-ohs :) [17:02:59] thanks AndyRussG [17:03:01] hi jgleeson [17:03:02] hi jgleeson ! [17:03:10] :) [17:04:15] ejegg i see you broke out jcb from IL for adyen, which makes sense, but just making sure IL doesnt also use it [17:04:32] cstone not according to the payment_submethods.yaml [17:04:40] XenoRyet: was just telling me we the form chooser was giving us some headaches over the weekend? I see any emails [17:04:52] -we [17:05:04] didn't see any emails* [17:05:07] jgleeson: it's this ticket: https://phabricator.wikimedia.org/T254274 [17:05:11] off to a good start today typing... :) [17:05:20] thanks ejegg [17:05:39] so not over the weekend, just saw it in IRC an hour an a half ago [17:05:54] ahh I might have misunderstood [17:14:24] (CR) Ejegg: "Would Symfony events instead of the civicrm_apiWrappers hook work for this use case? Would they be any more efficient?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [17:25:34] Also looking at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/603540/ [17:27:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (Ejegg) It looks like stats for CID 30996345 have been incompletely combined with stats from CID 51099 for the silverpop export. CID 30996345 has a single p... [17:37:32] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [17:40:19] Fundraising-Backlog, Analytics: Dashboard for CentralNotice impression rates using Druid, centralnotice_analytics and CN events - https://phabricator.wikimedia.org/T254792 (AndyRussG) [17:42:21] ejegg: so before applying your patch, adyen shows as the default for all the country/currency configs set [17:42:23] for me locally [17:42:33] when I apply your patch should I expect ingenico to show up for some? [17:42:47] or do you want us to just confirm the card types are correct [17:43:00] (if it still defaults to adyen for them all as it does current( [17:43:07] )* [17:43:40] shows as default for all the country/currrency config sets CHANGED IN THE PATCH* [17:44:06] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (AndyRussG) Here's a task with a detailed proposal for how to create impression rate dashboards (following the idea described [[ https://phabrica... [17:44:57] ok just reread the commit message. we do wanna confirm ingenico is the default and not adyen [17:54:51] ok ingenico is now the default for US (and CA) after that patch [17:54:58] is that the desired outcome ejegg ? [17:55:15] yep jgleeson [17:55:34] adyen should stay default for NL, IL, and JP [17:56:21] Adyen still comes up for FR/IL/JP [17:56:29] the rest are ingenico [17:57:17] ejegg: did you mean FR [17:57:27] ingenico is coming up for NL for me [17:57:32] and adyen for FR [17:58:14] hmm, maybe because of the count of submethods in FR? [18:00:27] shoot I'm gonna have to start dinner, it's one of them recipe card thingies. Are you happy with adyen for FR ejegg and ingenico defaulting for NL ? [18:00:40] I can +2 if so [18:01:23] Sure, let's go with that for now [18:01:47] ok cool [18:07:22] (CR) Jgleeson: [C: +2] "Looks good. Tested locally and Ingenico is now the default for US/CA/NL/GB/IE/UA. Adyen still the default for FR/JP/IL." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/603540 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [18:07:34] thanks jgleeson! [18:07:40] np! [18:18:14] (Merged) jenkins-bot: Explode out Adyen form settings by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/603540 (https://phabricator.wikimedia.org/T254274) (owner: Ejegg) [18:21:53] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/603565 [18:33:21] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/603568 [18:33:38] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/603565 (owner: Ejegg) [18:38:09] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/603568 (owner: Ejegg) [18:38:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/603565 (owner: Ejegg) [19:09:46] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/603568 (owner: Ejegg) [19:16:04] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/603568 (owner: Ejegg) [19:25:07] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/603568 (owner: Ejegg) [19:31:30] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/603568 (owner: Ejegg) [19:33:49] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (AndyRussG) @Nuria, thank you so so much for the explanations here, hugely appreciated!!!! Thanks also @Jgreen, @DStrine, @EBjune and @EYener for... [19:44:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create a job to send automatic matching gifts emails - https://phabricator.wikimedia.org/T249926 (DStrine) Open→Declined [19:44:19] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (DStrine) [19:44:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create template for automated matching gift email - https://phabricator.wikimedia.org/T249925 (DStrine) Open→Declined [19:44:30] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (DStrine) [19:44:57] Fundraising-Backlog: donate.wikimedia.org pages are not search engine optimized - https://phabricator.wikimedia.org/T254808 (EWilfong_WMF) [19:46:53] Fundraising-Backlog, Epic: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (Ejegg) [20:03:37] Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (MBeat33) [20:06:23] Fundraising-Backlog, fundraising-tech-ops, Analytics: Bring Banner History data into Fundraising infrastructure - https://phabricator.wikimedia.org/T253050 (DStrine) [20:22:28] (CR) Eileen: "Interesting point - I hadn't thought about it. I'd rather punt for now though" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:35:18] (PS6) Eileen: Send message from failed recurring if smashpig_recurring_send_failure_email set to true. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) [20:36:00] mepps: so I squashed patches to get this - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/601945 - from here I think the form & the template can be disentangled once that is merged [20:37:29] (CR) jerkins-bot: [V: -1] Send message from failed recurring if smashpig_recurring_send_failure_email set to true. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:38:44] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:45:49] argh ci failing.... [20:46:38] (CR) Mepps: "hey eileen, why was omnimail enabling deleted?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:47:46] eileen, comment above might be a blocker to +2ing [20:48:03] It looks like a booboo [20:48:24] hang on - which file am I looking at? [20:48:56] mepps: ah ok - the reconcile_extensions does a reconciliation [20:49:09] so it doesn't need to run more than once [20:49:27] Fundraising-Backlog, Analytics: Dashboard for CentralNotice impression rates using Druid, centralnotice_analytics and CN events - https://phabricator.wikimedia.org/T254792 (AndyRussG) [20:49:52] where is reconcile extensions? also i think it's just confusing being in here [20:50:05] thanks for the clarification [20:50:23] (CR) Eileen: "Ah - it's not incremental - it just needs to run once to do all extensions" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:50:33] oh i see [20:50:35] okay [20:50:46] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:50:48] (PS9) Mepps: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:50:55] (CR) Mepps: [C: +2] Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:51:02] yay [20:51:20] I think this is OK to merge but I can't get tests to run :-( https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/601945/ [20:51:54] yea i was looking at those eileen [20:52:07] also should we squash together all these template commits? [20:52:18] yeah - I'm trying that now [20:52:24] oh cool eileen [20:52:29] the CI problem is not us is it? [20:52:52] that's what it looks like to me eileen but i'll try to dig in--it says not connecting to mysql which usually means CI [20:52:59] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:53:15] yeaah - sometimes ejegg knows how to give it a kick [20:53:45] that one I just recheck [20:54:02] ok - tryinng [20:54:03] there were some more persistent ones for a while that needed some manual intervention in the CI box [20:54:55] also mepps I wound up doing another extended reports patch https://gerrit.wikimedia.org/r/602551 - I found something in what we pushed out that was problematic [20:55:20] eileen wait [20:55:22] 16:39:37 ./sites/default/civicrm/extensions/afform/gui/ang/afGuiEditor/entityDefaults/Activity.json: Parse error on line 1: [20:55:22] 16:39:37 // Default values fo [20:55:23] 16:39:37 ^ [20:55:23] 16:39:37 Expected one of: 'STRING', 'NUMBER', 'NULL', 'TRUE', 'FALSE', '{', '[' [20:55:23] 16:39:37 ./sites/default/civicrm/extensions/afform/gui/ang/afGuiEditor/entityDefaults/Contact.json: Parse error on line 1: [20:55:23] 16:39:37 // Default values fo [20:55:23] 16:39:37 ^ [20:55:24] 16:39:37 Expected one of: 'STRING', 'NUMBER', 'NULL', 'TRUE', 'FALSE', '{', '[' [20:55:41] there's these errors though they're not related to the files in the patch [20:55:56] ejegg didn't we see something like this before ^^? [20:56:00] ug [20:57:49] mepps: tests passed that time [20:57:54] yay eileen! [20:58:19] (Merged) jenkins-bot: Add data strings extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597891 (owner: Eileen) [20:58:25] mepps oh yeah, we should make an upstream pull request [20:58:32] to get those comments out of the JSON [20:58:37] but that test is non-voting [20:58:49] either that, or we should exclude that json file from lintine [20:58:52] *linting [20:58:53] ejegg: did you look at those custom fields - if we enable extensions it will be better if those are in [20:59:03] oop, looking [20:59:04] ie https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/597300/ [20:59:14] sorry, i saw your ping on friday and got distracted [20:59:44] ah yeah, easy fixes. Doing them now! [21:02:26] (CR) Mepps: [C: +2] Send message from failed recurring if smashpig_recurring_send_failure_email set to true. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [21:02:33] woot [21:03:17] mepps: ok so I'm trying to clean up the templates - do you want to try to fix the form side into one commit. They should no longer be dependent [21:05:24] (PS5) Ejegg: Add custom matching gift fields in installer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597300 (https://phabricator.wikimedia.org/T249924) [21:05:43] ok eileen, there's the fixed custom field names ^^ [21:07:17] ejegg: what about whether the fields should be view only? [21:08:07] hmm, could be [21:08:32] I was just putting the subsidiary one as view only since it has to be valid json [21:09:01] if they update them will they be ovewritten? [21:11:29] only when the info is updated at hepdata [21:11:33] for that specific company [21:12:23] ok - that's fine then [21:12:31] (CR) Eileen: [C: +2] Add custom matching gift fields in installer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597300 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [21:15:58] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [21:19:48] (Merged) jenkins-bot: Add custom matching gift fields in installer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/597300 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [21:23:15] (PS7) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [21:24:26] mepps I just updated the template files ^^ - note I felt I had to add an html version due to the link in the suggested changes. I haven't really tested it yet [21:24:46] (PS7) Eileen: Send message from failed recurring if smashpig_recurring_send_failure_email set to true. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) [21:25:33] (Abandoned) Eileen: Fix msg_text in template file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602204 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [21:26:00] (Abandoned) Eileen: Respect msg_html vs msg_text fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602549 (owner: Eileen) [21:27:22] if we can merge this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/599270/ then we can close that out in this sprint [21:51:07] ok templates cleaned up - I'll clean up the form one [21:52:49] (PS8) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [22:02:44] (PS1) Esanders: build: Update devDependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603630 [22:02:46] (PS1) Esanders: ESLint: Enforce jQuery variable pattern [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 [22:04:27] (PS16) Eileen: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [22:05:09] (CR) Eileen: [C: +1] "mepps I've squashed the other into this - I'm happy with it as the first iteration- are you?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [22:05:54] (CR) jerkins-bot: [V: -1] ESLint: Enforce jQuery variable pattern [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 (owner: Esanders) [22:08:58] (PS9) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [22:14:32] gerrit slow for anyone fr-tech? [22:14:38] checkouts just hanging here [22:15:52] (Abandoned) Eileen: My WIP on the form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602550 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [22:16:18] back! [22:21:30] MBeat: I lost your reply about the correct link (because I saw it was updated in the doc) but I think the one in the doc is wrong [22:22:11] (PS2) Esanders: ESLint: Enforce jQuery variable pattern [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 [22:22:11] which link/doc, eileen ? [22:22:22] for the failure email [22:22:29] https://docs.google.com/document/d/1hnkJMfhOWkEnifOp4krHHrzRz4gtpOxonSu0vWoon-M/edit [22:22:35] please take one minute etc [22:22:54] ah. i may need backup on that, cause the format for the URL changed, let me root around a sec [22:24:46] (CR) jerkins-bot: [V: -1] ESLint: Enforce jQuery variable pattern [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 (owner: Esanders) [22:30:03] eileen: I just commented in the doc, I’m not sure what the URL should be, and I asked Cogdill if the email team has a preferred URL. If not, linking to the Monthly section of Ways to Give will do, but I’m not sure how to create that URL so that it geolocates [22:35:05] & I pinged Peter for the latter case [22:37:06] (PS10) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [22:41:56] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/603650 [22:42:05] ejegg: OK with all that lot going out? ^^ [22:42:14] yep yep! [22:42:31] ejegg: I'm not seeing those test failures on the matching gift patches locally which is strange. I am seeing a bunch of other failures though even after a fresh composer install of the latest donation interface. I've uploaded the output which I'm gonna look into tomorrow. https://phabricator.wikimedia.org/P11414 [22:43:34] fr-tech, do the DI tests pass for yall locally? [22:43:50] jgleeson for me they do on my non-vagrant install [22:44:03] I know they used to pass for me locally [22:44:51] one of those CI failures is a test in the core mediawiki suite (the missing apihelp missage one) [22:45:07] so if you're just running the DonationInterface group locally that won't show up [22:45:15] ah [22:45:48] ohh I wonder if I'm missing a default config block for smashpig in my /etc/smashpig/main.yaml [22:45:54] that's causing the Error: Call to a member function getGlobalConfiguration() on null [22:45:59] Oh? [22:46:07] did we do something like that? [22:46:08] I thought we were overriding all the local config for tests [22:46:30] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/603650 (owner: Eileen) [22:46:37] so getGlobalConfiguration would be called on the context object [22:47:36] jgleeson maybe more likely a LocalSettings bit overriding test settings? [22:47:43] I think that's a lot less clean [22:47:48] feels like this is a job for xdebug holmes [22:48:12] yeah, just getting a full stack trace from that would probably show the answer [22:48:37] ok more test fun tomorrow then [22:48:41] have a good evening [22:49:22] !log civicrm revision changed from 11b0e7c7e5 to be4c5a4951, config revision is 386b9bc457 [22:49:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:50:20] ejegg: if you did have a chance to review https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/599270/ - it would be good to close it out in the sprint. No worries otherwise - mepps might be able to as she has some familiarity [22:51:13] oh sure, i saw that earlier version but haven't gotten back to it. Would be great to get that new datasource, I agree. [22:51:18] looking! [22:51:27] it's actually not that big [22:51:49] but I have a suspicion the formatting might need iterating as we see what the data looks like [22:52:00] but we can do that as we get the data [22:52:24] ohh - I need to check vendor submodule statuus [22:53:20] oh right, I was having trouble running tests locally - something was looking for one more guzzle response I thought [22:54:19] I think I fixed it? Or is that with the latest? [22:55:28] MG extension deployed [22:55:56] Fundraising Sprint Fish Fight Frogs for Free French-Fry Frappées, Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, and 4 others: Civi mail To, CC, BCC email additions diffcul... - https://phabricator.wikimedia.org/T248199 [22:56:15] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 3 others: CiviCRM regular upgrade - https://phabricator.wikimedia.org/T254205 (Eileenmcnaughton) Open→... [22:56:20] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Investigate how to generate generic email for failed rec... - https://phabricator.wikimedia.org/T230064 [23:04:57] (CR) Jforrester: [C: +2] "Wonderful." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603630 (owner: Esanders) [23:09:53] (PS11) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [23:14:52] (PS5) Ejegg: Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [23:15:16] (CR) Ejegg: [C: +2] "Looks good! Crossing my fingers that this API is stable." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [23:15:23] thanks ejegg ! [23:16:36] (PS17) Eileen: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [23:18:33] (CR) Eileen: [C: +2] "I've decided that I feel I can +2 this - anything else can follow - but I re-tested & I think it's good & getting it merged now simplifies" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [23:19:52] ejegg: one more - just something I merged upstream to revert a change we've already deployed https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/602551/ [23:19:53] (Merged) jenkins-bot: build: Update devDependencies [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603630 (owner: Esanders) [23:21:49] (CR) Eileen: [C: +2] Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [23:23:44] (Merged) jenkins-bot: Add second field to store api retrieved criteria [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/599270 (https://phabricator.wikimedia.org/T252247) (owner: Eileen) [23:29:44] (Merged) jenkins-bot: Link and form for sending recurring failure messages manually [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601921 (https://phabricator.wikimedia.org/T230064) (owner: Mepps) [23:30:39] (PS1) Eileen: Vendor update - silverpop packages [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/603666 [23:31:52] MBeat: did that email I just forwarded look OK? Note that saying yes doesn't mean it will start going out - it is OK if it it's an OK iteration - in which case we'll try to at least make it UI-sendable pretty quickly [23:32:30] hi “Bob” yes, that is close enough to build the button! [23:32:39] (CR) Eileen: [C: +2] Vendor update - silverpop packages [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/603666 (owner: Eileen) [23:32:53] (CR) jerkins-bot: [V: -1] Vendor update - silverpop packages [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/603666 (owner: Eileen) [23:33:08] :-) [23:33:13] eileen: I might change the sender and suggest some small changes when I hear from some other stakeholders, but this is like Christmas, thank you [23:33:52] ok cool - ejegg do you think we can merge this too? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/598908/ - It will make it UI sendable but still turned off on the job (we have a setting to turn it on) [23:34:22] (you can see I'm doing a big deploy-push) [23:34:27] (CR) Eileen: [C: +2] Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [23:34:32] (CR) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [23:35:09] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/603666 (owner: Eileen) [23:39:52] (Merged) jenkins-bot: Vendor update - silverpop packages [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/603666 (owner: Eileen) [23:41:41] (PS1) Eileen: Vendor submodule update - silverpop [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/603670 [23:41:55] (CR) Eileen: [C: +2] Vendor submodule update - silverpop [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/603670 (owner: Eileen) [23:43:10] MBeat: do I need to forward that email to a broader list then? currently fr-tech [23:44:40] Kristie and Cogdill are the ones I’m hoping ot check with [23:44:48] *to check, I can fwd to CC [23:45:09] (PS3) Ejegg: Extended report fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602551 (owner: Eileen) [23:45:13] (CR) Ejegg: [C: +2] Extended report fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602551 (owner: Eileen) [23:45:28] looking at those templates now [23:46:20] looks like some funny invisible chars in the footer of a couple of those txt templates? [23:46:48] recurring_failed_message.html.txt and recurring_failed_message.text.txt [23:47:50] (CR) Ejegg: [C: -1] "copy looks good, just some funny nonprinting chars showed up in the footers" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [23:50:26] (PS12) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [23:51:41] (CR) jerkins-bot: [V: -1] Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [23:52:32] (Merged) jenkins-bot: Extended report fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/602551 (owner: Eileen) [23:54:14] ejegg: yeah weird - when I 'fix' them the won't commit [23:54:20] git is maybe ignoring them [23:56:06] man - I retyped the block and they came back! [23:56:50] it's a zero-width non-joiner! [23:58:40] (PS13) Eileen: Add template files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/598908 (https://phabricator.wikimedia.org/T230064) [23:59:03] ejegg: aha - wrong tpl - got em now [23:59:29] ZWNJ, fun