[00:11:30] (CR) Ppchelko: [C: +2] Remove use of the Revision object returned in WikiPage::doEditContent [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604174 (https://phabricator.wikimedia.org/T251853) (owner: DannyS712) [00:16:43] (Merged) jenkins-bot: Remove use of the Revision object returned in WikiPage::doEditContent [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604174 (https://phabricator.wikimedia.org/T251853) (owner: DannyS712) [01:04:32] (PS1) Eileen: Security update to services module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604204 [01:41:06] (PS1) Eileen: Remove submit confirmation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) [01:42:45] (PS2) Eileen: Remove submit confirmation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) [01:43:00] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 5 others: generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (... [01:44:41] (CR) jerkins-bot: [V: -1] Remove submit confirmation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:45:07] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [01:46:16] Fundraising Sprint L 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Eileenmcnaughton) The email that was in the email for the new server was already in Silvepop. I altered the entry to add the api access checkbox but have... [03:02:17] (PS1) Eileen: Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/604234 (https://phabricator.wikimedia.org/T254815) [03:03:22] Fundraising Sprint L 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (Eileenmcnaughton) OK - I found the issue - it's a regression caused by (ahem) a performance fix I did. It's hitting an unindexed query. I have put up a quick-hack f... [03:03:55] Fundraising Sprint L 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (Eileenmcnaughton) a:Eileenmcnaughton [04:55:36] Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint L 2020, Fundraising-Backlog, and 2 others: CentralNotice: Deploy new regional geotargeting and banner template features - https://phabricator.wikimedia.org/T252596 (Marostegui) [04:55:49] Fundraising-Backlog, Analytics: Dashboard for CentralNotice impression rates using Druid, centralnotice_analytics and CN events - https://phabricator.wikimedia.org/T254792 (AndyRussG) [06:17:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [06:18:41] (PS1) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604249 [06:22:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [06:27:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [06:32:08] RECOVERY - check_log_messages on frav1002 is OK: OK [06:41:04] (PS1) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [06:42:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [06:42:52] (PS2) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [06:47:08] RECOVERY - check_log_messages on frav1002 is OK: OK [07:07:08] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [07:12:08] RECOVERY - check_log_messages on frav1002 is OK: OK [07:26:29] (PS3) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [07:28:56] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [09:02:42] (PS4) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [09:03:01] (Abandoned) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604249 (owner: ItSpiderman) [09:05:45] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [10:50:56] (PS5) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [10:56:15] (PS6) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [10:59:14] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [11:19:40] (PS7) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [11:22:10] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [12:00:19] (PS8) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [12:04:00] (PS9) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [12:40:11] (PS10) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [12:59:03] Fundraising-Backlog, Analytics-Radar, WMDE-Analytics-Engineering, WMDE-FUN-Team, WMDE-Fundraising-Tech: Find a better way for WMDE to get impression counts for their banners - https://phabricator.wikimedia.org/T243092 (kai.nissen) @Nuria Sorry, that this has been sitting around for such a lon... [13:01:00] (PS11) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:03:33] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:06:16] (PS12) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [13:07:20] (PS13) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:10:27] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:14:08] (PS14) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [13:25:52] (PS15) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:28:15] (PS16) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [13:49:39] Fundraising Sprint L 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (MBeat33) @Eileenmcnaughton I'm not sure if this is related to this task, but multiple agents are getting this error today when deduping: DB Error: deadlock [13:54:27] hey fr-tech :) [14:02:59] (PS17) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [14:03:56] hi AndyRussG [14:07:58] (PS18) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [14:25:20] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 8 minutes ago with 2 failures. Failed resources (up to 3 shown): Package[clamav],Package[clamav-freshclam] [14:30:20] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 13 minutes ago with 2 failures. Failed resources (up to 3 shown): Package[clamav],Package[clamav-freshclam] [14:35:16] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [14:42:05] cstone: :) [14:57:08] (PS19) AlexPinchuk: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 [14:59:55] dstrine: sorry! Something's come up and i can't make it to the next meeting [15:00:08] that's fine it's totally optional for all [15:00:21] fr-tech also can someone please fill out our section here if they get a chance? https://etherpad.wikimedia.org/p/Scrum-of-Scrums [15:00:27] if not I can do it soon [15:15:43] ejegg|away: fr-tech: I can take the s-o-s doc [15:28:32] tzag fr-tech, i'm on a little late today because errands took much longer than expected [15:33:52] Ok, I added a few things to scrum of scrums, mostly around our sprint goal for this time. If anyone else would like to take a look and add anything else, feel free. [15:35:33] looks fine to me XenoRyet but i guess i'm curious how the notes are used [15:35:46] we could also mention the failureeemail eileen and i worked on [15:36:33] XenoRyet are you okay with me buying the books i emailed you? i wasn't sure whether to check with you first [15:37:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Contact Source job failed this morning 6/10/2020 - https://phabricator.wikimedia.org/T255033 (DStrine) [15:42:19] XenoRyet s-o-s doc looks good to me, thanks for doing that! [15:52:06] mepps: Yep, those look good. Totally fine by me. [15:54:14] (PS7) Mepps: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) (owner: Jgleeson) [15:56:31] (CR) jerkins-bot: [V: -1] Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) (owner: Jgleeson) [16:04:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Contact Source job failed this morning 6/10/2020 - https://phabricator.wikimedia.org/T255033 (KHaggard) The manual run of the DatabaseUpdate import seemed to work. I bet this was a timing issue. Adding a screenshot of completed jobs compar... [16:05:02] (PS1) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 [16:08:36] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (owner: Mepps) [16:09:39] (PS2) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [16:10:56] (PS8) Mepps: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) (owner: Jgleeson) [16:11:26] (PS3) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [16:16:11] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [16:16:59] (PS4) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [16:19:16] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [16:48:25] (CR) Mepps: [C: +2] Declare default mail_provider on forgetme job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/603762 (owner: Eileen) [16:55:35] (Merged) jenkins-bot: Declare default mail_provider on forgetme job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/603762 (owner: Eileen) [17:06:46] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (ovasileva) p:Medium→High [17:11:29] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (AndyRussG) Hi!!! :) Some salient points from yesterday's meeting: 1. FR-Tech cannot dedicate any substantial time to this, because of other prio... [17:12:23] Fundraising Sprint L 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Contact Source job failed this morning 6/10/2020 - https://phabricator.wikimedia.org/T255033 (DStrine) [17:24:03] Fundraising-Backlog, Analytics-Radar, WMDE-Analytics-Engineering, WMDE-FUN-Team, WMDE-Fundraising-Tech: Find a better way for WMDE to get impression counts for their banners - https://phabricator.wikimedia.org/T243092 (Nuria) >Currently, the data is published to the respective hive table with... [17:24:06] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (ovasileva) [18:11:29] (PS5) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [18:13:14] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [18:16:24] (PS6) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [18:19:30] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [18:32:19] (PS7) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [18:32:41] fr-tech I'm gonna have to fix my mic situation. I don't really know why it's swapping between sound levels. think I might need a new webcam as currently that's what the mic is going through [18:35:07] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [18:38:18] Fundraising Sprint L 2020, Fundraising-Backlog: Fr-tech engineer should take on chores this sprint - https://phabricator.wikimedia.org/T254938 (Cstone) a:Cstone [18:44:11] (CR) Mepps: [C: +2] Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) (owner: Jgleeson) [18:47:12] (Merged) jenkins-bot: Prevent unnecessary contribution tracking messages being sent to queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/601465 (https://phabricator.wikimedia.org/T253602) (owner: Jgleeson) [18:52:22] (PS8) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [18:52:32] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [18:53:05] (PS9) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [18:53:14] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [18:58:06] Wikimedia-Fundraising-Banners: [Dsk Lg] Stacked CC logos on all versions of Safari - https://phabricator.wikimedia.org/T255061 (jbolorinos-ctr) [18:59:00] (PS10) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [18:59:54] Wikimedia-Fundraising-Banners: [Dsk Lg] Stacked CC logos on all versions of Safari - https://phabricator.wikimedia.org/T255061 (jbolorinos-ctr) [19:01:10] Wikimedia-Fundraising-Banners: [Dsk Lg] Stacked CC logos on all versions of Safari - https://phabricator.wikimedia.org/T255061 (jbolorinos-ctr) p:Triage→Medium [19:01:48] (CR) jerkins-bot: [V: -1] Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [19:04:39] Wikimedia-Fundraising-Banners: [Dsk Lg] Stacked CC logos on all versions of Safari - https://phabricator.wikimedia.org/T255061 (jbolorinos-ctr) p:Medium→High Setting priority to High since this issue needs to be fixed before the Pre-Test if possible [19:09:22] Wikimedia-Fundraising-Banners: [All variants] Missing payment logo for Visa/Mastercard/Amex/DinersClubInternational/RuPay - https://phabricator.wikimedia.org/T255062 (jbolorinos-ctr) [19:10:37] Wikimedia-Fundraising-Banners: [All variants] Missing payment logo for Visa/Mastercard/Amex/DinersClubInternational/RuPay - https://phabricator.wikimedia.org/T255062 (jbolorinos-ctr) p:Triage→Medium Setting priority to High since this issue affects all banners and should be fixed before the pre-test... [19:10:46] Wikimedia-Fundraising-Banners: [All variants] Missing payment logo for Visa/Mastercard/Amex/DinersClubInternational/RuPay - https://phabricator.wikimedia.org/T255062 (jbolorinos-ctr) p:Medium→High [19:11:03] Fundraising-Backlog, fundraising-tech-ops: Package PrivateBin for FR-Tech hosts - https://phabricator.wikimedia.org/T255063 (Dwisehaupt) [19:15:52] Fundraising Sprint L 2020, Fundraising-Backlog, fundraising-tech-ops: Determine how to best separate read and write functionality in PrivateBin - https://phabricator.wikimedia.org/T255064 (Dwisehaupt) [19:18:03] (PS11) Mepps: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) [19:20:41] (PS1) Mepps: Make $tracking_data into instance level variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 [19:21:01] (PS2) Mepps: Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 [19:22:14] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on Payments wiki page - https://phabricator.wikimedia.org/T255065 (jbolorinos-ctr) [19:24:27] (CR) jerkins-bot: [V: -1] Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 (owner: Mepps) [19:25:30] Fundraising-Backlog: Japanese TY Email - https://phabricator.wikimedia.org/T254052 (CDenes_WMF) Hi @DStrine ! Just checking in as I saw this was moved to the June23-July 7 sprint. Wanted t to ask if it could please be expedited as the pre-test date is July 2nd. Please let me know. Thank you! Kind regards,... [19:26:05] (PS3) Mepps: Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 [19:26:29] (PS11) Mepps: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [19:26:31] (PS16) Mepps: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [19:28:01] (CR) jerkins-bot: [V: -1] Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 (owner: Mepps) [19:28:24] (PS1) Cstone: Ignore Adyen sepa direct debit IPNs [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/604493 [19:29:08] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on Payments wiki page - https://phabricator.wikimedia.org/T255065 (mepps) This doesn't seem to be the case for USD, so it might be specific to that currency: {F31860456} [19:29:21] (CR) jerkins-bot: [V: -1] Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [19:29:44] (CR) jerkins-bot: [V: -1] Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [19:30:16] Fundraising-Backlog: Upgrade for mariaDB - https://phabricator.wikimedia.org/T255066 (EYener) [19:32:39] (PS12) Mepps: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [19:32:41] (PS17) Mepps: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [19:33:17] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on Payments wiki page - https://phabricator.wikimedia.org/T255065 (mepps) Oh I tested with ingenico.. [19:34:16] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on Payments wiki page - https://phabricator.wikimedia.org/T255065 (mepps) But I confirmed I don't see it on Astropay with USD: {F31860465} [19:42:57] Wikimedia-Fundraising-Banners: [Dsk Sm] Not so small Desktop Small banner on IE 11 - https://phabricator.wikimedia.org/T255067 (jbolorinos-ctr) [19:44:17] Wikimedia-Fundraising-Banners: [Dsk Sm] Not so small Desktop Small banner on IE 11 - https://phabricator.wikimedia.org/T255067 (jbolorinos-ctr) [19:44:57] Wikimedia-Fundraising-Banners: [Dsk Sm] Not so small Desktop Small banner on IE 11 - https://phabricator.wikimedia.org/T255067 (jbolorinos-ctr) p:Triage→Low Changing priority to low since this issue is only visible on lesser used browsers [19:48:03] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on Payments wiki page - https://phabricator.wikimedia.org/T255065 (jbolorinos-ctr) Thanks for the quick reply Mepps! Since this banner is going to be used for the India campaign, we need it to display t... [19:49:05] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on Payments wiki page - https://phabricator.wikimedia.org/T255065 (mepps) @jbolorinos-ctr Yes, I was just confirming that it's only on the INR currency, meaning we have to look specifically what's going o... [19:55:16] Wikimedia-Fundraising-Banners: Different currency symbol formats used in error messages - https://phabricator.wikimedia.org/T255071 (jbolorinos-ctr) [19:55:33] Wikimedia-Fundraising-Banners: Different currency symbol formats used in error messages - https://phabricator.wikimedia.org/T255071 (jbolorinos-ctr) [19:56:38] Wikimedia-Fundraising-Banners: Different currency symbol formats used in error messages - https://phabricator.wikimedia.org/T255071 (jbolorinos-ctr) p:Triage→Low Setting priority to Low as it is unlikely a user will display all error messages at once. I'm also not entirely sure if this decision was m... [19:58:36] (CR) Mepps: [C: +1] "The tests are great and this works. I wonder if it's the most performant way to do it but at this point, we need to get it out and these d" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [19:59:00] Fundraising-Backlog: Japanese TY Email - https://phabricator.wikimedia.org/T254052 (DStrine) We are in the middle of a big project. If we suddenly made a ton of progress we could work on this early. but we might not be able to look at this until around June 23rd. [19:59:09] (CR) Mepps: [C: +2] "I guess since I said I'm up for +2ing it, I can just do that :)." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [20:00:09] (CR) Mepps: "I'm glad there's some client-side caching! It worked for me, and looks good." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [20:00:35] Wikimedia-Fundraising-Banners: [Dsk Lg] Stacked CC logos on all versions of Safari - https://phabricator.wikimedia.org/T255061 (jbolorinos-ctr) a:jbolorinos-ctr→Pcoombe [20:00:40] (CR) Mepps: [C: +2] Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [20:01:05] Wikimedia-Fundraising-Banners: [All variants] Missing payment logo for Visa/Mastercard/Amex/DinersClubInternational/RuPay - https://phabricator.wikimedia.org/T255062 (jbolorinos-ctr) a:jbolorinos-ctr→Pcoombe [20:01:57] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (mepp... [20:02:17] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (mepps) [20:03:46] (Merged) jenkins-bot: Create MW API to expose employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/594330 (https://phabricator.wikimedia.org/T251199) (owner: Jgleeson) [20:07:29] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (mepps) @jbolorinos-ctr It looks like [[ https://fastspring.com/blog/how-to-format-30-currencies-from-countries-all-over-the-world/ | th... [20:09:34] (CR) Mepps: "I'd like to have current_hash actually be a method but I'm not sure if that's overkill. I also considered making $ctid an instance variabl" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [20:11:28] (PS4) Mepps: Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 [20:13:56] (CR) Mepps: Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/604234 (https://phabricator.wikimedia.org/T254815) (owner: Eileen) [20:14:20] Fundraising Sprint L 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (mepps) https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/604234/ I put one question on this patch. [20:14:28] (CR) jerkins-bot: [V: -1] Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 (owner: Mepps) [20:24:02] (Merged) jenkins-bot: Add autocomplete to Employer form field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/593316 (https://phabricator.wikimedia.org/T251200) (owner: Jgleeson) [20:48:23] (CR) Mepps: [C: +2] Fix SmashPig form using CRM_Admin_Form_Generic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/603763 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:48:59] (CR) Mepps: [C: +2] "I'd personally prefer a confirmation before sending an email to a donor but I'll trust your judgment eileen." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:50:58] (CR) Mepps: [C: +1] "wait, testing." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:52:06] (CR) Mepps: [C: +2] Remove submit confirmation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:52:44] (CR) jerkins-bot: [V: -1] Remove submit confirmation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:53:17] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 5 others: generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (... [20:53:24] Fundraising-Backlog, fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049 (Nuria) >Or, baring that, we could run a Druid query from a script running on the Analytics cluster, save the results as a csv file, and then cop... [20:55:09] (Merged) jenkins-bot: Fix SmashPig form using CRM_Admin_Form_Generic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/603763 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:55:45] (Merged) jenkins-bot: Remove submit confirmation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604214 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [20:58:16] fr-tech I'm going to use the one_off job to delete the paypal audit that was missing all those rows so our download jobs picks up the fixed one [21:02:29] cool [21:07:52] ejegg: noice! [21:35:08] (CR) Eileen: Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/604234 (https://phabricator.wikimedia.org/T254815) (owner: Eileen) [21:35:36] is someone able to +2 ^^ - it is impacting on DS deduping so I'd like to get it out [21:36:03] I'll take a look eileen [21:40:03] eileen: I see the index on table/id [21:40:16] is the issue that id isn't used in the query? [21:40:16] but it's id_table isn't it? [21:40:20] yep [21:40:28] makes sense [21:40:50] (CR) Jgleeson: [C: +2] Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/604234 (https://phabricator.wikimedia.org/T254815) (owner: Eileen) [21:42:30] thanks jgleeson [21:42:42] np [21:48:52] (Merged) jenkins-bot: Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/604234 (https://phabricator.wikimedia.org/T254815) (owner: Eileen) [22:00:40] (PS1) Eileen: submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604517 [22:00:50] (CR) Eileen: [C: +2] submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604517 (owner: Eileen) [22:01:34] Can I get a +2 on this too - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/604204/ - it doesn't really get used by us AFAIK but it should be secure [22:02:37] (CR) jerkins-bot: [V: -1] submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604517 (owner: Eileen) [22:02:58] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604517 (owner: Eileen) [22:04:42] (CR) jerkins-bot: [V: -1] submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604517 (owner: Eileen) [22:07:00] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/604517 (owner: Eileen) [22:07:18] if that doesn't work this time I'm gonna force it [22:07:53] phew [22:09:05] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/604518 [22:09:27] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/604518 (owner: Eileen) [22:10:21] ok deploying but will do a second deploy if I get https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/604204/ +2d [22:11:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe suggestion: track down OG contact records for "new" donors - https://phabricator.wikimedia.org/T238156 (KHaggard) Hey there! I met with CCogdill to test this out using contact_hash. Unfortunately, a new contact record was made instead of merging... [22:14:53] !log civicrm revision changed from 80a0d22350 to f01b036128, config revision is a26d023633 [22:14:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:18:35] Fundraising-Backlog, fundraising-tech-ops: Determine how to best separate read and write functionality in PrivateBin - https://phabricator.wikimedia.org/T255064 (DStrine) [22:20:49] Fundraising Sprint L 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (Eileenmcnaughton) @MBeat33 I just deployed a fix & it seemed OK in my testing just now [22:22:58] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint L 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (Eileenmcnaughton) As an aside it wou... [22:25:42] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (... [22:34:27] Fundraising Sprint L 2020, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (MBeat33) Thank you @Eileen McNaughton [22:34:54] Fundraising Sprint L 2020, Fundraising-Backlog: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (jgleeson) a:jgleeson [22:39:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe suggestion: track down OG contact records for "new" donors - https://phabricator.wikimedia.org/T238156 (DStrine) @KHaggard It looks like you have 2 donations about 45 minutes apart. They have different email addresses. Does that sound right? Did... [22:49:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe suggestion: track down OG contact records for "new" donors - https://phabricator.wikimedia.org/T238156 (KHaggard) Thanks @DStrine - to answer your question, yes - I messed up the first donation by putting in my email associated with the URL's CID... [23:44:43] (PS5) Mepps: Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 [23:46:25] (CR) jerkins-bot: [V: -1] Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 (owner: Mepps) [23:48:20] (PS6) Mepps: Make $tracking_data into instance variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489