[00:13:18] Wikimedia-Fundraising-Banners: [Enhancement] Update radio inputs to be larger buttons - https://phabricator.wikimedia.org/T255637 (jbolorinos-ctr) [00:15:51] Wikimedia-Fundraising-Banners: [BETA] QA Touch Target Size Guidelines variant - https://phabricator.wikimedia.org/T255636 (jbolorinos-ctr) Open→Resolved @EWilfong_WMF is there a mobile variant for this one? Or is this for desktop only? [00:16:16] Wikimedia-Fundraising-Banners: [BETA] QA Touch Target Size Guidelines variant - https://phabricator.wikimedia.org/T255636 (jbolorinos-ctr) Resolved→Open [00:16:34] (PS3) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [00:17:09] ejegg: ah okok... I just updated the code (not yet taking that suggestion into account, but with other fixes) [00:19:07] (CR) jerkins-bot: [V: -1] Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [00:37:14] Wikimedia-Fundraising-Banners: QA for Google LP - https://phabricator.wikimedia.org/T255640 (jbolorinos-ctr) [00:37:38] Wikimedia-Fundraising-Banners: [BETA] QA for Google LP - https://phabricator.wikimedia.org/T255640 (jbolorinos-ctr) [00:37:48] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (jbolorinos-ctr) [00:41:39] (PS1) Eileen: Remove fields timezone & latest_currency_symbol [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606043 (https://phabricator.wikimedia.org/T252245) [00:55:51] (PS1) Eileen: Remove latest_usd_amount from silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606048 (https://phabricator.wikimedia.org/T252245) [00:56:31] (CR) jerkins-bot: [V: -1] Remove latest_usd_amount from silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606048 (https://phabricator.wikimedia.org/T252245) (owner: Eileen) [00:58:42] (PS2) Eileen: Add modified date to the silverpop_export_staging table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605816 (https://phabricator.wikimedia.org/T253152) [00:59:31] (CR) jerkins-bot: [V: -1] Add modified date to the silverpop_export_staging table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605816 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [01:07:30] (PS1) Eileen: Add index to log_civicrm_email.email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/606053 (https://phabricator.wikimedia.org/T253152) [01:10:05] Wikimedia-Fundraising-Banners: Oversized logo and quote on mobile - https://phabricator.wikimedia.org/T255642 (jbolorinos-ctr) [01:10:48] (CR) jerkins-bot: [V: -1] Add index to log_civicrm_email.email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/606053 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [01:15:04] (PS2) Eileen: Add index to log_civicrm_email.email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/606053 (https://phabricator.wikimedia.org/T253152) [01:27:50] (PS2) Eileen: Remove latest_usd_amount from silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606048 (https://phabricator.wikimedia.org/T252245) [01:28:31] (CR) jerkins-bot: [V: -1] Remove latest_usd_amount from silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606048 (https://phabricator.wikimedia.org/T252245) (owner: Eileen) [01:31:05] (PS3) Eileen: Remove latest_usd_amount from silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606048 (https://phabricator.wikimedia.org/T252245) [01:33:01] (PS3) Eileen: Add modified date to the silverpop_export_staging table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605816 (https://phabricator.wikimedia.org/T253152) [01:36:47] (PS4) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [02:24:44] (PS1) Eileen: Will tests accept source [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606058 [02:25:30] (CR) jerkins-bot: [V: -1] Will tests accept source [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606058 (owner: Eileen) [02:34:22] (PS1) Eileen: Test Pulling out schema create into it's own file [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 [02:35:01] (CR) jerkins-bot: [V: -1] Test Pulling out schema create into it's own file [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (owner: Eileen) [02:49:07] (Abandoned) Eileen: Will tests accept source [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606058 (owner: Eileen) [03:12:01] (PS2) Eileen: Test Pulling out schema create into it's own file [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 [03:59:28] (PS3) Eileen: Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) [04:05:14] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [04:10:14] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 1944458 Threads: 3 Questions: 63824693 Slow queries: 135916 Opens: 1265697 Flush tables: 1 Open tables: 200 Queries per second avg: 32.823 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [11:54:15] (PS3) Ejegg: Doc and default value for $wgDonationInterfaceEmployersListDataFileLocation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/605633 (https://phabricator.wikimedia.org/T251199) (owner: AndyRussG) [11:54:59] (CR) Ejegg: [C: +2] "Thanks! Nice default location - as though DonationInterface were normal software!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/605633 (https://phabricator.wikimedia.org/T251199) (owner: AndyRussG) [11:57:04] (Merged) jenkins-bot: Doc and default value for $wgDonationInterfaceEmployersListDataFileLocation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/605633 (https://phabricator.wikimedia.org/T251199) (owner: AndyRussG) [12:34:37] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (... [13:13:43] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, Readers-Web-Backlog (Kanbanana-2019-20-Q4): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Niedzielski) a:vas @vas, I'm assigning this task to you and moving to doing to clarify who is working on it {icon thumbs... [13:43:58] (PS23) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:47:47] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [13:59:46] (PS24) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [14:03:24] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [14:05:50] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) A sort of silly noticing... [14:21:12] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) Weirdly the french thank... [14:23:09] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) The italian receipt has n... [14:29:17] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) Also there is not eoy rec... [14:29:52] (PS3) Mepps: Adding tax deductibility language for all eoy_thank_you templates where available [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605985 (https://phabricator.wikimedia.org/T242001) [14:53:47] tzag fr-tech! [14:55:43] hi jgleeson [14:59:24] hey :) [14:59:43] we've got a thunder storm here atm just watching out the window [14:59:50] Jun 17th welcome to the UK [15:03:03] nice i do not miss the daily ones Colorado would have in the summer [15:04:41] yeah there was flooding in the streets about 30 miles from here yesterday so it looks like it's our turn today [15:07:56] hi fr-tech [15:08:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Gift Source = Alternative Gifts created - https://phabricator.wikimedia.org/T239845 (DStrine) [15:08:16] anyone want to put stuff in the scrum of scrums news? [15:08:30] or rather, anyone have stuff they want me to put in that news? [15:08:36] hey fr-tech ejegg jgleeson cstone [15:08:40] nothing here ejegg, thanks! [15:08:46] nothing here! [15:08:50] hey AndyRussG ejegg [15:09:10] AndyRussG: just looking at your patches and I had a quick question on the path used here https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/605633/3/README.txt [15:10:27] is that a path local to your setup or a sample path [15:10:56] thanks for adding that btw! I missed it [15:12:40] jgleeson: hey! no worries, thank u also for working on this... It's just a sample path [15:13:00] Locally I have it in some vagranty place [15:13:55] I guess I could have put that in the default [15:14:35] the easiest place to put it for purposes of deployment using existing tools [15:14:42] would be within the DonationInterface root dir [15:14:50] alongside DonationInterfaceFormSettings [15:28:04] (CR) Jgleeson: "Looks good on first glance. spotted a tiny typo. I'll pull the patch down and test it out later today. Thanks" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [15:30:59] jgleeson: hey, thanks for looking at that patch! Actually I also had a question about that code... I just need like 10 min to get some coffee though..... ;p [15:31:48] Fundraising-Backlog: Recurring Adyen amex IPNs not ignored - https://phabricator.wikimedia.org/T255303 (Cstone) Another happened today cid: 35179361 ct: 80458430.2 [15:44:03] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (DStrine) From our meeting today: @jgleeson can you share an example of the data that would show up under these headings? In general we are ok sending more info... [15:44:09] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) After doing this, I'd lik... [15:45:25] ejegg: can I chat to you for an extra few minutes [15:45:46] in today's standup? [15:53:09] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (DStrine) >>! In T242001#6232067,... [15:55:18] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) From what I'm seeing it'd... [15:56:18] Fundraising-Backlog, FR-AutoTY-Email, Epic: EPIC: Auto TY emails from Civi - https://phabricator.wikimedia.org/T248358 (DStrine) [15:56:37] (CR) Mepps: "I know i approved this already but I just noticed there's no tests for the api calls and that getContributionRecur in Send doesn't seem to" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/601945 (https://phabricator.wikimedia.org/T230064) (owner: Eileen) [15:57:32] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) @Eileenmcnaughton also se... [15:57:39] (PS1) Dwisehaupt: Move fruec to use pymysql instead of mysql.connector [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/606213 (https://phabricator.wikimedia.org/T246823) [16:01:49] Fundraising-Backlog, FR-PayPal-ExpressCheckout, Recurring-Donations: PayPal recurring donation question - https://phabricator.wikimedia.org/T255691 (MBeat33) [16:07:34] sure thing jgleeson! [16:08:48] jgleeson: hey I'm all coffeed up now [16:09:00] heh that took a while to take effect [16:09:25] I guess maybe you're busy just now though? [16:09:38] Wikimedia-Fundraising-Banners: Different currency symbol formats used in error messages - https://phabricator.wikimedia.org/T255071 (Pcoombe) a:jbolorinos-ctr→Pcoombe [16:10:28] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (jgleeson) Sample Company: Boeing | **Field** | **Sample** | matching_gifts_provider_info_url | http://www.boeing.com/ | name_from_matching_gift_db)| Boeing Compa... [16:11:38] Fundraising-Backlog: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (MNoorWMF) [16:11:59] Fundraising-Backlog: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (MNoorWMF) p:Triage→High [16:18:27] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (mepps) > I think @Ejegg and @Eil... [16:19:43] Wikimedia-Fundraising-Banners: [Enhancement] Update radio inputs to be larger buttons - https://phabricator.wikimedia.org/T255637 (jbolorinos-ctr) p:Triage→Lowest [16:27:05] Hey AndyRussG I was just trying to package up my patch before standup. what can I do for you :) [16:27:45] jgleeson: just a question about the test that I saw about parent/subsidiary companies [16:27:56] we could also go over it on video chat if u like [16:29:02] ejegg: so on the first line I was hoping to grab you straight after our last call but then I realise the "in today's standup" wasn't clear that I meant we could use that as the chat venue ha. I'll try and catch you after tech-talk as between standup and tech-talk I'm grabbing dinner. I wanna talk over how we're gonna get a list of companies upfront for the MG stuff [16:31:32] AndyRussG: test on the MG stuff? hmm I don't recall it [16:31:36] lemme take a look at your patch [16:32:32] ok I see it [16:34:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (KHaggard) Great, here's the rest of the CIDs. There's actually 20 in total: 40331964 5011493 40803102 40872242 12395037 40824161 40633943 5007349 1476323 39... [16:37:25] Fundraising-Backlog: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (MNoorWMF) Just a heads up: Acoustic planned upgrades have been rescheduled to occur on Saturday, June 27 between 12am and 4am ET. Users will experience downtime or inability to access Acoustic Campaign... [16:40:15] Wikimedia-Fundraising-Banners: [Enhancement] Implement JS function to auto apply fixed space formatting to banner text - https://phabricator.wikimedia.org/T250434 (Pcoombe) a:Pcoombe [17:14:48] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (KHaggard) Coordinating on a day to delete sounds good... [17:15:02] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (MNoorWMF) @Eileenmcnaughton we have a quick last minut... [18:21:32] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 2 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (vas) a:vas→Jdlrobson Jon, please review my patch. I have several questions: 1. see includes/Menu/Definitions.php line 383 Is it possible to get it... [18:26:56] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 2 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Jdlrobson) Have replied on ticket. [18:30:23] Fundraising-Backlog: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (CCogdill_WMF) Thank you, Moska! Re your last comment, we are on Pod 4 so we will be affected. @fr-tech, I believe you use these urls for some of the data integrations between Acoustic > Civi. If we're... [18:37:16] Wikimedia-Fundraising-Banners: Different currency symbol formats used in error messages - https://phabricator.wikimedia.org/T255071 (Pcoombe) Open→Resolved We discussed this in the fr-creative meeting and decided to go ahead and change to using the currency symbol, and not highlight the average on er... [18:37:18] Wikimedia-Fundraising-Banners: [CANDIDATE] QA India Banners - https://phabricator.wikimedia.org/T254903 (Pcoombe) [19:17:16] Fundraising-Backlog, fundraising-tech-ops: Determine how to best separate read and write functionality in PrivateBin - https://phabricator.wikimedia.org/T255064 (Dwisehaupt) I've done some more digging in on this. I think the best route will be to restrict access to any post requests to set ip addresses.... [19:17:32] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) We need to white list the page because we have: $wgGroupPermissions['*']['read'] = false; set. [19:19:35] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) It looks like we're using [[ https://www.mediawiki.org/wiki/Extension:Lockdown | Lockdown ]]. There's a chance this may be more challeng... [19:21:58] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) I'm currently looking at: https://phabricator.wikimedia.org/T148582 to see how I add the api to the allow list. [19:33:11] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) There are two paths: - allow the api to be accessed by any anonymous user (still making sure we can do this) - but I think it would be a... [19:33:49] jgleeson ejegg fr-tech i'd love feedback on what i found in the task above ^^, basically which path we want to go down [19:34:54] fr-tech actually now thinking about the parent-subsidiary data, maybe it'd be better to have different company ids, and record in the form which one people select? [19:35:33] I feel like by just assigning them the same ID and only storing that, we could lose data that we might need for resolving issues, or in case for the donor it did happen to make a difference which company the selected? [19:35:54] maybe we could just have a table in the database instead that says which companies are part of which other ones? [19:36:25] AndyRussG it's not a bad point if the email team might want that data but dstrine might know [19:36:58] like i could see emailing someone saying "your employer X matched your gift" and it might be weird for them if we say the parent company but not what they put [19:37:00] also what if in the future a subsidiary is sold to a different parent company? maybe we'd want to keep the record of which company the donor directly belongs to, yeah mepps, like for e-mail purposes [19:37:12] yeah exactly [19:37:16] dstrine: ^ [19:38:00] is there anything like use case requirements written up somewhere that specifies how this should work? or where it could be added? [19:38:07] hmm [19:38:20] AndyRussG do you know anything about Lockdown and MediaWiki apis? [19:38:47] mepps I imagine it's a user rights thing, lemme try to find some doc quickly [19:39:06] I agree that data structure would be better however it could be tricky accomplishing that and maintaining it due to how we get the subsidiary data. mepps AndyRussG take a look at this patch to see how it comes over https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/596777/ [19:39:20] to accomplish*** [19:39:37] actually it made sense, scrap the correction [19:40:38] AndyRussG i've found the docs already [19:40:41] you can check my task above [19:40:46] i was just curious if you had experience with it [19:40:49] mepps: ah okok [19:40:57] mepps: looking now also [19:41:19] jgleeson: I mean, if we know enough about the companies to assign them the same ID in our systems, we should also be able to create a new ID for each and a link table or something to indicate they were part of the same conglomerate [19:43:17] mepps: ah I see... https://phabricator.wikimedia.org/T148582 [19:43:29] I'm not familiar with Lockdown then, sorry I didn't realize it was a thing [19:43:46] fundraising-tech-ops: Reconfigure fundraising public-reporting server role to fundraising-data - https://phabricator.wikimedia.org/T255435 (Jgreen) [19:44:02] k AndyRussG, then if you have an opinion about the two paths i outlined, i'd just comment on my task [19:44:20] mepps jgleeson I guess it comes down to, do we want the list to be readable from anywhere? someone could scrape it and get that data? don't we pay for it somewhere? [19:44:38] yea I feel like we'd wanna lock this down [19:44:41] if possible [19:44:45] yeah i'm not sure what our agreement with HEP states [19:45:01] i agree jgleeson [19:45:02] cool [19:45:15] dstrine also ^ do we need to prevent people from scraping our HEP data? [19:45:59] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) Based on a brief conversation in chat with @AndyRussG and @jgleeson we will want to lock this down and probably add a config token for a... [19:46:38] mepps I think in this case maybe we'd need a task for specifically adding some auth mechanism to the code then [19:46:59] yeah AndyRussG also i think your subsidiary question should be a taks [19:48:32] AndyRussG: I think we could do what you're suggesting but it may complicate the work ejegg is already doing. [19:48:57] the use case you describe makes sense to me [19:51:51] AndyRussG: we can disable access with .htaccess [19:52:18] oh, i mean to not let them pull down the whole file [19:52:56] since this is just names and IDs I don't think it's too important [19:53:20] good point [19:53:49] hmm ok [19:54:09] ejegg ^ any thoughts about the subsidiary/parent questions further back in the backscrool? [19:59:09] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) @Ejegg says we can try allowing it. Now I just have to make sure that's doable :). [20:00:33] jgleeson i'm thinking we should add Lockdown to the vagrant fundraising role [20:00:40] so that things like this come up in local testing.. [20:00:48] good idea! [20:01:19] to test my fix for the api stuff i could deploy the addition to the allow list now ejegg but i'm always nervous testing on prod [20:02:38] (CR) Jgleeson: "fn looks good. I just had one suggestion on moving the initial hashing into it also. Thanks!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [20:02:45] What? We're not supposed to test on prod? [20:02:47] Fundraising-Backlog: Add lockdown to vagrant fundraising role - https://phabricator.wikimedia.org/T255713 (mepps) [20:03:12] right XenoRyet? [20:04:31] (CR) Mepps: Extract boolean method to check for updated ct data (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [20:07:12] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error when testing - https://phabricator.wikimedia.org/T255478 (mepps) I added Lockdown locally and am trying to match the prod settings. [20:07:41] fr-tech I've been in a few meetings. Looking at backscroll now... [20:10:42] Fundraising-Backlog: Investigate whether we need subsidary company id instead of parent - https://phabricator.wikimedia.org/T255714 (mepps) [20:10:58] dstrine i tried to encapsulate one of the conversatoins into a task above [20:11:34] just as a starting point, because it's probably something ccogdill will have an opinion about [20:12:32] mepps: AndyRussG I will loop in Nora on that [20:13:13] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error in production - https://phabricator.wikimedia.org/T255478 (mepps) [20:13:33] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error in production - https://phabricator.wikimedia.org/T255478 (mepps) Sadly adding "api" to the setting did not solve the problem :(. [20:17:57] mepps: AndyRussG Nora deals with this quite a lot (which is why we are trying to make it automatic now) people get emails referring to the parent company already and this doesn't seem to be an issue. [20:18:06] but good call out for an edge case [20:18:20] cool dstrine, thanks! [20:18:41] Fundraising-Backlog: Investigate whether we need subsidary company id instead of parent - https://phabricator.wikimedia.org/T255714 (DStrine) I've spoken with @NNichols and this is not an issue. [20:18:48] np [20:19:10] Fundraising-Backlog: Investigate whether we need subsidary company id instead of parent - https://phabricator.wikimedia.org/T255714 (DStrine) Open→Declined [20:20:15] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (DStrine) [20:20:17] Fundraising-Backlog: Investigate whether we need subsidary company id instead of parent - https://phabricator.wikimedia.org/T255714 (DStrine) [20:20:41] I made sure that task is still associated with the epic so we can track the conversation around the edge case [20:23:40] (CR) Jgleeson: [C: -1] "I'm on the fence on this change leaning towards it not being needed right now." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604489 (owner: Mepps) [20:26:38] dwisehaupt: I've set a query going again so we will see - but it's not like every time I've tried a slow query it has crashed so it might not be that straightforward [20:27:09] If it takes more than 30 mins I'll kill (since I want to know if it takes longer than a different query) [20:28:24] nope - query failed quickish [20:32:29] Fundraising-Backlog: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (jgleeson) FR-Tech, @mepps @Cstone and I looked at this on tech-talk it looks like the two places we need to check in relation to this are: ## Silverpop export Config File: /etc/fundraising/silverpop... [20:36:04] dstrine: ok thanks... Hmmm it just feels hacky to be throwing away donor information like that [20:36:42] Like also what if sometime we want to do analytics on which companies people match gifts from [20:37:23] If we can just store consistent full data from the start without much additional effort, I feel like that makes more sense [20:39:00] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Employer autocomplete showing readonly error in production - https://phabricator.wikimedia.org/T255478 (mepps) So even though the settings say "Lockdown", it looks we don't have it installed. However, the problem remains the same that $wgGroupPer... [20:40:02] eileen: ok cool. feel free to test. i'm around to restart replication if it times out. [20:49:22] AndyRussG: I read the conversation as if it was a question of how this is presented to the donor. It doesn't seem to matter how it is presented to the donor. [20:49:46] AndyRussG: about saving info, we will at least be saving which parent company they are associated with [20:52:18] but also, saving info about subsidiaries would require the email team to understand these nuances too [20:52:26] I'm asking nora about this [20:55:36] (PS5) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [20:55:46] (CR) jerkins-bot: [V: -1] Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [20:55:47] dwisehaupt: is it replicating OK now? I made a minor change on live & it seems vey slow getting back to staging [20:56:44] dstrine: yeah it's about saving the specific information that the user types in. As it is now, the plan has been to have a single ID for parent and subsidiary companies [20:56:59] it hasn't timed out.has the query finished yet? since it won't hit the replication stream until it has completed [20:57:27] dstrine: in the current scenario, so the donor could type in whichever, and we'd just record the ID, so we wouldn't know or record whether they typed in their direct employer or the subsidiary name [20:57:40] AndyRussG: yup got it. I'm checking with Nora but she may be offline for the day [20:58:07] so the possible change in plan we're talking about is just to record whatever they actually did type in, so that we at least have that info, and can decide how to do it later [20:58:28] dstrine: ok cool yeah I don't think it's urgent [21:01:53] (PS6) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [21:04:37] (CR) jerkins-bot: [V: -1] Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [21:15:12] (PS7) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [21:16:27] dwisehaupt: query died quickly - I have to fix some data on live & have it replicate back [21:17:31] kk. [21:27:54] (PS8) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [21:29:10] fr-tech ^ caching patch now ready for review again, based on what we talked about in tech-talk :) [22:03:56] dwisehaupt: eyener has a table she wants exported to a csv & brought off the server - I have a feeling we need you to do that? We would want to add the 'BOM'char to the start of the file - but that could be in an editor once exported [22:04:36] is there a task for that? [22:09:17] Hi dwisehaupt and eileen! [22:09:33] Here is the task: https://phabricator.wikimedia.org/T254517 [22:11:08] Some back story is that I was originally thinking 'hey, Superset might be great for this and eliminate some of the file transfer' but it looks like (for now at least) Superset has a row limit to contend with. However, the table is built in frdb1003 and just needs to go from frdb1003 to smb://fileserve [22:11:35] ok. [22:12:04] yep - just needs to be a csv with a couple of hex chars prepended (to tell excel but not Leanne's that it is utf8 [22:13:40] in php that bit looks like echo "\xEF\xBB\xBF"; [22:14:44] ie https://en.wikipedia.org/wiki/Byte_order_mark#UTF-8 [22:15:04] sounds good. [22:16:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (Eileenmcnaughton) Note that the way to make MS Excel (except Leanne's copy) interpret special characters is to add some hex to the start of the file - https://en.wikipedia.org/wiki/By... [22:16:33] I put that inn there [22:16:46] eyener: can you add the table name to export from [22:20:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [22:21:02] eileen: looks like the replication just stopped. how was the output of your query? [22:21:27] dwisehaupt: Query OK, 23979983 rows affected (18 min 30.38 sec) [22:22:11] so I locked tables on staging.civicrm for that long - but so does silverpop export... [22:22:29] hmmmm... ok. [22:23:23] ejegg: silverpop export runs on staging doesn't it? [22:23:35] we'd need to turn up the logging on frdev to get useful data if we want to dig more. [22:23:58] i'm pretty sure we have the slow log off there since it is generally noisy due to the queries we run regularly. [22:24:25] dwisehaupt: if I can't test these queries it will be blocking for me - I need to run through a few &I see if changing them will impact the time taken [22:25:12] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 2010158 Threads: 3 Questions: 65080078 Slow queries: 138143 Opens: 1267864 Flush tables: 1 Open tables: 200 Queries per second avg: 32.375 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [22:29:32] yeah. these usually crop up when a table is held open for too long (aka past the timeout) and the waiting query gives up. in this case it's jut the replication thread. [22:30:00] the janky thing to do is crank the timeout way way up. but that can lead to other problems. [22:31:57] to be honest, i'm ok with your running through the queries. it's easy to restart replication and up until a reasonable hour, i'm glad to do it. [22:32:29] dwisehaupt: OK - I'll try the next one now - that should cover the theory I'm currently testing..... [22:32:51] all the fixes i can think of right now are probably worse than the annoyance this is. [22:33:08] i'm fine with you running them for the next 5 hours or so TBH. [22:33:36] my phone will alert when it happens and i can just step over and start replication back up. [23:16:58] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (Eileenmcnaughton) Note that MG would like these availa... [23:17:08] dwisehaupt: thanks! [23:32:25] (PS2) Eileen: Remove fields timezone [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606043 (https://phabricator.wikimedia.org/T252245) [23:33:38] (PS1) Eileen: Add local yaml config to gitignore [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606294 [23:34:13] Can I get a +2 on the gitignore one just above so I don't keep getting that file incorrectly commited [23:35:16] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [23:36:47] (CR) Ejegg: [C: +2] Add local yaml config to gitignore [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606294 (owner: Eileen) [23:36:56] thanks [23:37:35] (Merged) jenkins-bot: Add local yaml config to gitignore [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606294 (owner: Eileen) [23:37:59] replication restarted. [23:38:54] you should be good to go again. [23:39:49] dwisehaupt: lol - it does seem to be me [23:40:16] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 2014659 Threads: 3 Questions: 65125881 Slow queries: 138299 Opens: 1268975 Flush tables: 1 Open tables: 200 Queries per second avg: 32.326 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [23:40:35] on the bright side I now know that the query we split into 2 * 18-20 minute queries takes 18-20 minutes to do as a single query [23:40:50] so our optimisation ... takes twice as long [23:47:24] (PS3) Eileen: Remove fields timezone [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606043 (https://phabricator.wikimedia.org/T252245) [23:47:26] (PS4) Eileen: Remove latest_usd_amount from silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606048 (https://phabricator.wikimedia.org/T252245) [23:51:13] (Abandoned) Eileen: WIP - am guessing tests won't cope... [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605716 (owner: Eileen)