[00:01:44] (PS1) Mepps: Change to require post and not read mode to allow access from form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) [00:04:46] (CR) jerkins-bot: [V: -1] Change to require post and not read mode to allow access from form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) (owner: Mepps) [01:41:23] (CR) Ejegg: [C: -1] "Looks great, matches with the donation api permissions. This would be a +2 if not for the stray console.log." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) (owner: Mepps) [06:56:47] (PS1) AndyRussG: Remove unused bannerController RL modules [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606370 (https://phabricator.wikimedia.org/T224034) [07:01:52] (CR) jerkins-bot: [V: -1] Remove unused bannerController RL modules [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606370 (https://phabricator.wikimedia.org/T224034) (owner: AndyRussG) [07:04:41] (PS1) AndyRussG: Don't show Amdin Ui tabs on subscribing wikis [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 [07:05:09] (PS2) AndyRussG: Don't show Admin UI tabs on subscribing wikis [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 [07:09:34] (CR) jerkins-bot: [V: -1] Don't show Admin UI tabs on subscribing wikis [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 (owner: AndyRussG) [07:50:55] (CR) AndyRussG: Add object caching for API for employer data (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [07:52:24] Fundraising-Backlog: SIlverpop urls expiring at the end of the month will our integrations break? - https://phabricator.wikimedia.org/T255739 (Aklapper) Assuming this should be in the #Fundraising-Backlog basket. (If not, then please correct me.) [12:55:14] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 23 failures. Last run 5 minutes ago with 23 failures. Failed resources (up to 3 shown) [13:00:18] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 23 failures. Last run 10 minutes ago with 23 failures. Failed resources (up to 3 shown) [13:05:18] RECOVERY - check_puppetrun on frbackup2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [13:21:26] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (EYener) Hi @Eileenmcnaughton - I'm curious which of th... [13:26:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (EYener) The table above is in frdb1003: analytics_ad_hoc.targetsmart_export_june_2020. However, I ended up running a tunnel through R, creating a query, and writing that query output t... [13:40:18] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 8 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/etc/update-motd.d/99-footer],File[/etc/motd.tail],File[/usr/local/bin/package_update_check] [13:45:16] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 13 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/etc/update-motd.d/99-footer],File[/etc/motd.tail],File[/usr/local/bin/package_update_check] [13:50:18] RECOVERY - check_puppetrun on frbackup2001 is OK: OK: Puppet is currently enabled, last run 23 seconds ago with 0 failures [14:14:40] Fundraising-Backlog, fundraising-tech-ops: Help me finish setting up my new yubikey - https://phabricator.wikimedia.org/T255777 (spatton) [14:54:43] (PS2) Mepps: Change to require post and not read mode to allow access from form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) [15:01:38] fr-tech, for anyone who hasn't caught the email, wellness can be claimed up until 8pm UTC today. [15:02:07] thanks jgleeson! [15:02:17] np! [15:10:25] (CR) Jgleeson: [C: +2] Extract boolean method to check for updated ct data (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [15:15:40] (Merged) jenkins-bot: Extract boolean method to check for updated ct data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/604432 (https://phabricator.wikimedia.org/T253602) (owner: Mepps) [15:16:28] mepps: I'm curious why we changed the API to post over get here https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/606296/2/modules/js/ext.donationInterface.employerAutoComplete.js [15:16:49] jgleeson because to get past the permissions issue you have to require post for the api [15:16:54] do you see the changes in the php file [15:17:01] yeah [15:17:04] oh that's odd [15:17:23] I would typically associate an http get request with a behaviour that gets stuff [15:17:29] and post when we update/create stuff [15:18:18] that makes sense but i think it's also a little safer, and it doesn't allow someone to browse to the api page [15:20:54] hmm [15:22:16] it looks like isReadMode being false is enoguh to allow all api calls [15:22:24] i was copying donations api [15:22:28] so we could allow both too [15:23:18] we had said we arent' super concerned about this data getting out [15:23:56] I guess I can see that folks can paste the URL into the browser and mess with the query string so it's not as convenient in that sense however I think it's easier enough to replay the api call from the browser tools or something like postman. I'm also assuming the API sandbox works also [15:24:22] if privacy was the concern [15:24:56] but as you say, it's not really, so it feels unusual to me to have a POST endpoint which retrieves search results [15:25:25] I'm probably showing a bias towards RESTful design here [15:25:34] and it isn't a REST api [15:27:25] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) Copied from the task below: > In T242001#6232067, @mepps wrote: > > After doing this, I'd like to map out the ideal road for moving our thank you translatio... [15:27:35] oh it looks like APISandbox is behind auth on paymentswiki [15:31:32] jgleeson i would say using a tool is much harder than posting params into a browser but as i said, i'm up for switching it [15:31:52] i hope this works in prod either way! i copied down the settings that were blocking us before [15:32:50] hi fr-tech [15:33:14] (PS3) Mepps: Change to not read mode to allow access from form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) [15:34:24] pulling down the latest [15:37:59] yeah I get what you mean mepps I'm just leaning more towards the API design "norms" (which is probably subjective) over obfuscation techniques to make it harder to find. [15:38:28] jgleeson either is fine with me, as i said i just modeled it after donations api [15:39:13] sure thing [15:40:16] s/sure thing/understood/ [15:48:33] (CR) Mepps: [C: +1] "Pretty straightforward, but I'm seeing some discussion on the task. Okay to +2 this and usd amount?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606043 (https://phabricator.wikimedia.org/T252245) (owner: Eileen) [15:58:01] Fundraising-Backlog: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (DStrine) [15:58:16] works well for me locally [15:58:33] (PS4) Ejegg: Change to not read mode to allow access from form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) (owner: Mepps) [15:58:52] (CR) Ejegg: [C: +2] "Looks good, works well" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) (owner: Mepps) [15:59:40] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog: Special Characters do not export well from civi - https://phabricator.wikimedia.org/T237564 (DStrine) Open→Declined We found out that this is an issue with a... [16:00:31] jgleeson i'm currently seeing two tasks from AndyRussG in review but it looks like you're reviewing them? otherwise the only actionable thing in the backlog i see the is the drupal upgrade investigation [16:00:42] i could also pair with someone today [16:00:53] fr-tech ^^ just trying to figure out what to work on next [16:01:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (LeanneS) @EYener Thank you! I was able to open it easily. Appreciate your help! [16:02:19] (Merged) jenkins-bot: Change to not read mode to allow access from form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606296 (https://phabricator.wikimedia.org/T255478) (owner: Mepps) [16:05:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New list pull from Civi - https://phabricator.wikimedia.org/T254517 (EYener) Open→Resolved Great, thanks! I will mark this as resolved (I think I can do that...) [16:07:14] Fundraising-Backlog, fundraising-tech-ops: Help me finish setting up my new yubikey - https://phabricator.wikimedia.org/T255777 (Dwisehaupt) a:Dwisehaupt Sure thing. I'll get that plugged in. [16:11:37] mepps: just checking those two things [16:15:34] mepps: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/606016/ looks like it contains the work for both of the tickets in review. I won't get to that today as I'm leaving after standup so if you wanna pick it up that's cool. I think AndyRussG has added in the improved api response stuff you suggested on tech-talk yesterday in that patch [16:20:45] (PS4) Ejegg: Filter matching gift policies on type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) [16:21:38] Fundraising-Backlog, fundraising-tech-ops: Help me finish setting up my new yubikey - https://phabricator.wikimedia.org/T255777 (Dwisehaupt) Open→Resolved p:Triage→High Updated key has been pushed around. You should be ok to use the new key. ` [frack::puppet::private] 73df951 New yubikey... [16:23:04] (CR) Ejegg: "OK, this way should be more efficient." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [16:24:23] (PS5) Ejegg: Filter matching gift policies on type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) [16:25:36] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: OKR 2019-2020 Q3: Increase visibility and awareness of Fundraising system health and wellness - https://phabricator.wikimedia.org/T243110 (Dwisehaupt) [16:25:55] oops, I need to dedupe that combined result [16:27:49] Fundraising-Backlog, fundraising-tech-ops: Upgrade mariaDB on frdb1003 to >= 10.2 - https://phabricator.wikimedia.org/T255066 (Dwisehaupt) @EYener We will need to find a time when we can take the host down for the upgrade. I anticipate the upgrade will take up to 45 minutes and then we'll want to make su... [16:30:41] (PS1) Jgleeson: WIP: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 [16:31:12] (PS2) Jgleeson: WIP: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) [16:31:54] (CR) jerkins-bot: [V: -1] WIP: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [16:34:18] Fundraising-Backlog, fundraising-tech-ops: Upgrade mariaDB on frdb1003 to >= 10.2 - https://phabricator.wikimedia.org/T255066 (EYener) Good question - let me check and get back to you. Thanks @Dwisehaupt [17:01:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (DStrine) [17:06:43] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, FR-dlocal, MediaWiki-extensions-DonationInterface, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): Make PAN field default to upper case - https://phabricator.wikimedia.org/T255171 (DStrine) [17:11:28] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (DStrine) a:jbolorinos-ctr→None [17:14:15] hey cstone it looks like we lost each other [17:14:27] haha mepps I thnk i was talking to past you [17:14:33] but i was going to suggest trying again and looking at syslog [17:14:47] i might go eat some lunch right now [17:14:55] ok well knowing i was clicking on the wrong thing is a giant step forward haha [17:14:57] ok sounds good [17:16:05] Fundraising-Backlog: Investigation: Civicrm has two end of year summary links - https://phabricator.wikimedia.org/T255799 (mepps) [17:17:08] fr-tech mepps No CR comments on the caching patch that haven't been addressed, so it's definitely ready for more review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/606016 [17:17:19] If anyone gets to it and has questions, pls don't hesitate to ping!!! [17:20:14] Fundraising-Backlog, FR-AutoTY-Email: JAN Summary Emails 2021 need a signature - https://phabricator.wikimedia.org/T251424 (DStrine) [17:27:30] fr-tech yeah my issues with banner history were due to DNT enabled in my browser. However it seems that one of the common default settings will enable that. I think we might investigate how common that is, so I'll make a task [17:55:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TS update import back into Civi - https://phabricator.wikimedia.org/T255805 (LeanneS) [18:18:14] Fundraising-Backlog, Fundraising-Backlog-Old, Wikimedia-Fundraising, Language-Team, donate.wikimedia.org: Exporting Fundraising translations from meta.wikimedia.org to donate.wikimedia.org should be more automated - https://phabricator.wikimedia.org/T111678 (Pcoombe) Open→Declined Thi... [18:21:48] Fundraising-Backlog, Fr-CentralNotice-Caching: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) [18:22:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) [18:24:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigation: How many users are we missing banner history for due to modern tracking protections? - https://phabricator.wikimedia.org/T255811 (AndyRussG) [18:27:40] (CR) Krinkle: [C: +2] Don't show Admin UI tabs on subscribing wikis (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 (owner: AndyRussG) [18:27:57] (CR) Krinkle: [C: +2] "(won't merge until the Phan issue is resolved in CN master.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 (owner: AndyRussG) [18:31:40] cstone did you get mail working? [18:32:16] (CR) jerkins-bot: [V: -1] Don't show Admin UI tabs on subscribing wikis [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 (owner: AndyRussG) [18:44:06] mepps: just getting back to trying it its still doing the hanging thing even with a unique email [18:44:43] looks like i got a js error though so looking at that [18:56:54] (PS6) Ejegg: Filter matching gift policies on type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) [19:12:53] (PS3) Ejegg: Matching gifts fetcher factory, beef up interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605637 (https://phabricator.wikimedia.org/T249924) [19:12:55] (PS3) Ejegg: WIP new api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) [19:15:20] (CR) jerkins-bot: [V: -1] WIP new api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [19:17:43] Wikimedia-Fundraising-Banners: Early QA: Japan Banners - https://phabricator.wikimedia.org/T255813 (jbolorinos-ctr) [19:26:38] Wikimedia-Fundraising-Banners: Early QA: Japan Banners - https://phabricator.wikimedia.org/T255813 (TSkaff) [19:32:25] Fundraising-Backlog: Investigation: Civicrm has two end of year summary links - https://phabricator.wikimedia.org/T255799 (mepps) It looks like the second link is suppressed on prod. [19:33:02] cool cstone [19:44:11] (CR) Mepps: [C: +1] "Could there be a test specifically for the cache? It works well for me locally so far, and the step through looked fine. Still reading thr" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [19:52:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team: CI Phan check blocking CentralNotice patches - https://phabricator.wikimedia.org/T255822 (AndyRussG) [19:59:09] (CR) Mepps: [C: +1] "One more question about the README change. A mistake?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [20:03:19] (CR) Mepps: [C: +1] "Aside from the two comments above, this looks +2able to me, and works locally." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [20:46:43] mepps its working now and I didnt nothing differently that I know of -_- but yay for working [20:47:03] yay cstone! [20:50:18] (PS9) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [20:52:36] (CR) Cstone: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605985 (https://phabricator.wikimedia.org/T242001) (owner: Mepps) [20:59:55] (Merged) jenkins-bot: Adding tax deductibility language for all eoy_thank_you templates where available [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605985 (https://phabricator.wikimedia.org/T242001) (owner: Mepps) [21:05:30] (CR) AndyRussG: "> Patch Set 8: Code-Review+1" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [21:15:27] Fundraising-Backlog, fundraising-tech-ops: Upgrade mariaDB on frdb1003 to >= 10.2 - https://phabricator.wikimedia.org/T255066 (EYener) Hi @Dwisehaupt how about 9PM UTC / 5PM Eastern / 2 PM Pactific on Monday? Alternately, the same time on Tuesday or Thursday would be preferable. [21:46:22] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (TSkaff) [22:05:13] Fundraising-Backlog, fundraising-tech-ops: Upgrade mariaDB on frdb1003 to >= 10.2 - https://phabricator.wikimedia.org/T255066 (Dwisehaupt) a:Dwisehaupt 9pm UTC on Monday 06/22 works for me. I'll add it to my calendar and get the prep rolling. [22:34:05] (PS10) AndyRussG: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) [22:40:15] (CR) AndyRussG: "K added tests of getEmployersList() return value." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [22:40:39] mepps fr-tech ^ caching patch should respond to all CR now [23:40:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add translations to generic email for failed recurring donations - https://phabricator.wikimedia.org/T255837 (MBeat33) [23:48:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add translations to generic email for failed recurring donations - https://phabricator.wikimedia.org/T255837 (MBeat33)